Kaladaran/briar
0
0
Fork 0
mirror of https://code.briarproject.org/briar/briar.git synced 2026-02-13 03:09:04 +01:00
Code Issues Projects Releases Wiki Activity

Address issues found in code review

Browse Source
This commit is contained in:
Torsten Grote
2016-10-18 15:50:05 -02:00
parent 7bf4aebdaf
commit 0523c4e718
15 changed files with 235 additions and 163 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
briar-android/src/org/briarproject/android/privategroup/conversation/GroupActivity.java
View File

@@ -1,8 +1,9 @@
package org.briarproject.android.privategroup.conversation;
import android.content.Intent;
import android.os.Bundle;
import android.support.annotation.LayoutRes;
import android.support.annotation.Nullable;
import android.support.annotation.StringRes;
import android.support.v7.app.ActionBar;
import android.support.v7.widget.LinearLayoutManager;
import android.view.Menu;
@@ -18,11 +19,13 @@ import org.briarproject.api.privategroup.PrivateGroup;
import javax.inject.Inject;
import static org.briarproject.api.privategroup.PrivateGroupConstants.MAX_GROUP_POST_BODY_LENGTH;
public class GroupActivity extends
ThreadListActivity<PrivateGroup, GroupMessageItem, GroupMessageHeader, GroupMessageAdapter> {
@Inject
protected GroupController controller;
GroupController controller;
@Override
public void injectActivity(ActivityComponent component) {
@@ -37,23 +40,18 @@ public class GroupActivity extends
@Override
public void onCreate(Bundle state) {
super.onCreate(state);
Intent i = getIntent();
String groupName = i.getStringExtra(GROUP_NAME);
if (groupName != null) setTitle(groupName);
loadNamedGroup();
list.setEmptyText(R.string.groups_no_messages);
}
@Override
protected @LayoutRes int getLayout() {
return R.layout.activity_forum;
}
@Override
protected void setActionBarTitle(@Nullable String title) {
if (title != null) setTitle(title);
loadGroupItem();
}
@Override
protected void onGroupItemLoaded(PrivateGroup group) {
super.onGroupItemLoaded(group);
protected void onNamedGroupLoaded(PrivateGroup group) {
setTitle(group.getName());
// Created by
ActionBar actionBar = getSupportActionBar();
if (actionBar != null) {
@@ -62,6 +60,12 @@ public class GroupActivity extends
}
}
@Override
@LayoutRes
protected int getLayout() {
return R.layout.activity_forum;
}
@Override
protected GroupMessageAdapter createAdapter(
LinearLayoutManager layoutManager) {
@@ -89,11 +93,18 @@ public class GroupActivity extends
}
@Override
protected int getMaxBodyLength() {
return MAX_GROUP_POST_BODY_LENGTH;
}
@Override
@StringRes
protected int getItemPostedString() {
return R.string.groups_message_sent;
}
@Override
@StringRes
protected int getItemReceivedString() {
return R.string.groups_message_received;
}