From 152ac3df43f44460e690ff1984268394c1524da1 Mon Sep 17 00:00:00 2001 From: Torsten Grote Date: Tue, 20 Nov 2018 11:48:44 -0200 Subject: [PATCH] [android] improve bitmap transformation hashKey and DiskCacheKey --- .../conversation/glide/ImageCornerTransformation.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/briar-android/src/main/java/org/briarproject/briar/android/conversation/glide/ImageCornerTransformation.java b/briar-android/src/main/java/org/briarproject/briar/android/conversation/glide/ImageCornerTransformation.java index fb418d6d7..b41c0cf31 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/conversation/glide/ImageCornerTransformation.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/conversation/glide/ImageCornerTransformation.java @@ -98,14 +98,14 @@ class ImageCornerTransformation extends BitmapTransformation { @Override public int hashCode() { - return ID.hashCode() + smallRadius * 100 + radius * 10 + - (leftCornerSmall ? 9 : 8) + (bottomRound ? 7 : 6); + return ID.hashCode() + (smallRadius << 16) ^ (radius << 2) ^ + (leftCornerSmall ? 2 : 0) ^ (bottomRound ? 1 : 0); } @Override public void updateDiskCacheKey(@NonNull MessageDigest messageDigest) { - messageDigest.update((ID + smallRadius + radius + leftCornerSmall + - bottomRound).getBytes(CHARSET)); + messageDigest.update((ID + '|' + smallRadius + '|' + radius + '|' + + leftCornerSmall + '|' + bottomRound).getBytes(CHARSET)); } }