diff --git a/bramble-core/src/main/java/org/briarproject/bramble/db/DatabaseComponentImpl.java b/bramble-core/src/main/java/org/briarproject/bramble/db/DatabaseComponentImpl.java index ae8b9df26..23c538c26 100644 --- a/bramble-core/src/main/java/org/briarproject/bramble/db/DatabaseComponentImpl.java +++ b/bramble-core/src/main/java/org/briarproject/bramble/db/DatabaseComponentImpl.java @@ -1099,11 +1099,7 @@ class DatabaseComponentImpl implements DatabaseComponent { T txn = unbox(transaction); if (!db.containsContact(txn, c)) throw new NoSuchContactException(); - List visible = new ArrayList<>(acked.size()); - for (MessageId m : acked) { - if (db.containsVisibleMessage(txn, c, m)) visible.add(m); - } - db.lowerAckFlag(txn, c, visible); + db.lowerAckFlag(txn, c, acked); } @Override diff --git a/bramble-core/src/test/java/org/briarproject/bramble/db/DatabaseComponentImplTest.java b/bramble-core/src/test/java/org/briarproject/bramble/db/DatabaseComponentImplTest.java index 25e85afc5..9daec1220 100644 --- a/bramble-core/src/test/java/org/briarproject/bramble/db/DatabaseComponentImplTest.java +++ b/bramble-core/src/test/java/org/briarproject/bramble/db/DatabaseComponentImplTest.java @@ -1396,14 +1396,7 @@ public class DatabaseComponentImplTest extends BrambleMockTestCase { will(returnValue(txn)); oneOf(database).containsContact(txn, contactId); will(returnValue(true)); - // First message is still visible to the contact - flag lowered - oneOf(database).containsVisibleMessage(txn, contactId, messageId); - will(returnValue(true)); - // Second message is no longer visible - flag not lowered - oneOf(database).containsVisibleMessage(txn, contactId, messageId1); - will(returnValue(false)); - oneOf(database) - .lowerAckFlag(txn, contactId, singletonList(messageId)); + oneOf(database).lowerAckFlag(txn, contactId, acked); oneOf(database).commitTransaction(txn); }}); DatabaseComponent db = createDatabaseComponent(database, eventBus,