Address review feedback for mailbox troubleshooting wizard

This commit is contained in:
Torsten Grote
2022-05-16 11:44:23 -03:00
parent 5254efb630
commit 15e0abffb0
4 changed files with 20 additions and 12 deletions

View File

@@ -143,7 +143,7 @@ public class MailboxStatusFragment extends Fragment {
title = getString(R.string.mailbox_status_problem_title);
tintRes = R.color.briar_orange_500;
showUnlinkWarning = false;
wizardButton.setVisibility(GONE);
wizardButton.setVisibility(VISIBLE);
} else {
tintRes = R.color.briar_red_500;
title = getString(R.string.mailbox_status_failure_title);

View File

@@ -206,20 +206,16 @@ class MailboxViewModel extends DbViewModel
MutableLiveData<Boolean> liveData = new MutableLiveData<>();
checkConnection(success -> {
liveData.postValue(success);
if (!success) { // force failure screen
MailboxStatus lastStatus = status.getValue();
long lastSuccess = lastStatus == null ?
-1 : lastStatus.getTimeOfLastSuccess();
long now = System.currentTimeMillis();
status.postValue(new MailboxStatus(now, lastSuccess, 999));
}
if (!success) onConnectionCheckFailure();
});
return liveData;
}
void checkConnectionFromWizard() {
checkConnection(success -> {
if (!success) onConnectionCheckFailure();
boolean isOnline = isTorActive();
// make UI move back to status fragment by changing pairingState
pairingState.postEvent(new MailboxState.IsPaired(isOnline));
});
}
@@ -234,6 +230,15 @@ class MailboxViewModel extends DbViewModel
});
}
private void onConnectionCheckFailure() {
MailboxStatus lastStatus = status.getValue();
long lastSuccess = lastStatus == null ?
-1 : lastStatus.getTimeOfLastSuccess();
long now = System.currentTimeMillis();
// force failure screen
status.postValue(new MailboxStatus(now, lastSuccess, 999));
}
@UiThread
void unlink() {
ioExecutor.execute(() -> {