From 23acd186f73367c7d2a99d8f3a7d3d09e3f9f882 Mon Sep 17 00:00:00 2001 From: akwizgran Date: Tue, 15 Jun 2021 11:47:10 +0100 Subject: [PATCH] Hold lock while calling notifyObservers(). --- .../bramble/plugin/file/RemovableDriveTaskImpl.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bramble-core/src/main/java/org/briarproject/bramble/plugin/file/RemovableDriveTaskImpl.java b/bramble-core/src/main/java/org/briarproject/bramble/plugin/file/RemovableDriveTaskImpl.java index a94393cb6..cae0546b0 100644 --- a/bramble-core/src/main/java/org/briarproject/bramble/plugin/file/RemovableDriveTaskImpl.java +++ b/bramble-core/src/main/java/org/briarproject/bramble/plugin/file/RemovableDriveTaskImpl.java @@ -94,15 +94,15 @@ abstract class RemovableDriveTaskImpl implements RemovableDriveTask { done = min(state.getDone() + done, state.getTotal()); state = new State(done, state.getTotal(), state.isFinished(), state.isSuccess()); + notifyObservers(); } - notifyObservers(); } void setSuccess(boolean success) { synchronized (lock) { state = new State(state.getDone(), state.getTotal(), true, success); + notifyObservers(); } - notifyObservers(); } @GuardedBy("lock")