Address review comments for detecting duplicate (pending) contacts

This commit is contained in:
Torsten Grote
2019-10-16 11:15:14 -03:00
parent aa0937e6aa
commit 397afbfec0
4 changed files with 13 additions and 5 deletions

View File

@@ -120,8 +120,10 @@ public class NicknameFragment extends BaseFragment {
viewModel.getAddContactResult().observe(this, result -> {
if (result == null) return;
if (result.hasError()) handleException(name, result.getException());
else showPendingContactListActivity();
if (result.hasError())
handleException(name, requireNonNull(result.getException()));
else
showPendingContactListActivity();
});
viewModel.addContact(name);
}
@@ -133,7 +135,7 @@ public class NicknameFragment extends BaseFragment {
finish();
}
private void handleException(String name, @Nullable Exception e) {
private void handleException(String name, Exception e) {
if (e instanceof ContactExistsException) {
ContactExistsException ce = (ContactExistsException) e;
handleExistingContact(name, ce.getRemoteAuthor());