Kaladaran/briar
0
0
Fork 0
mirror of https://code.briarproject.org/briar/briar.git synced 2026-02-14 11:49:04 +01:00
Code Issues Projects Releases Wiki Activity

Removed the serialisation reader's internal array of struct readers.

Browse Source
This commit is contained in:
akwizgran
2013-01-28 23:37:44 +00:00
parent 42dd7f238c
commit 3e1c41c62f
4 changed files with 5 additions and 208 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
briar-core/src/net/sf/briar/protocol/SubscriptionUpdateReader.java
View File

@@ -1,10 +1,10 @@
package net.sf.briar.protocol;
import static net.sf.briar.api.protocol.ProtocolConstants.MAX_PACKET_LENGTH;
import static net.sf.briar.api.protocol.Types.GROUP;
import static net.sf.briar.api.protocol.Types.SUBSCRIPTION_UPDATE;
import java.io.IOException;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
@@ -29,9 +29,10 @@ class SubscriptionUpdateReader implements StructReader<SubscriptionUpdate> {
r.addConsumer(counting);
r.readStructId(SUBSCRIPTION_UPDATE);
// Read the subscriptions
r.addStructReader(GROUP, groupReader);
List<Group> subs = r.readList(Group.class);
r.removeStructReader(GROUP);
List<Group> subs = new ArrayList<Group>();
r.readListStart();
while(!r.hasListEnd()) subs.add(groupReader.readStruct(r));
r.readListEnd();
// Read the version number
long version = r.readInt64();
if(version < 0L) throw new FormatException();

48
briar-core/src/net/sf/briar/serial/ReaderImpl.java
View File

@@ -12,7 +12,6 @@ import java.util.Map;
import net.sf.briar.api.Bytes;
import net.sf.briar.api.FormatException;
import net.sf.briar.api.serial.Consumer;
import net.sf.briar.api.serial.StructReader;
import net.sf.briar.api.serial.Reader;
// This class is not thread-safe
@@ -23,7 +22,6 @@ class ReaderImpl implements Reader {
private final InputStream in;
private final Collection<Consumer> consumers = new ArrayList<Consumer>(0);
private StructReader<?>[] structReaders = new StructReader<?>[] {};
private boolean hasLookahead = false, eof = false;
private byte next, nextNext;
private byte[] buf = null;
@@ -98,24 +96,6 @@ class ReaderImpl implements Reader {
if(!consumers.remove(c)) throw new IllegalArgumentException();
}
public void addStructReader(int id, StructReader<?> r) {
if(id < 0 || id > 255) throw new IllegalArgumentException();
if(structReaders.length < id + 1) {
int len = Math.min(256, Math.max(id + 1, structReaders.length * 2));
StructReader<?>[] newStructReaders = new StructReader<?>[len];
System.arraycopy(structReaders, 0, newStructReaders, 0,
structReaders.length);
structReaders = newStructReaders;
}
structReaders[id] = r;
}
public void removeStructReader(int id) {
if(id < 0 || id > structReaders.length)
throw new IllegalArgumentException();
structReaders[id] = null;
}
public boolean hasBoolean() throws IOException {
if(!hasLookahead) readLookahead(true);
if(eof) return false;
@@ -371,7 +351,6 @@ class ReaderImpl implements Reader {
}
private Object readObject() throws IOException {
if(hasStruct()) return readStruct();
if(hasBoolean()) return Boolean.valueOf(readBoolean());
if(hasUint7()) return Byte.valueOf(readUint7());
if(hasInt8()) return Byte.valueOf(readInt8());
@@ -391,21 +370,6 @@ class ReaderImpl implements Reader {
throw new FormatException();
}
private boolean hasStruct() throws IOException {
if(!hasLookahead) readLookahead(true);
if(eof) return false;
return next == Tag.STRUCT
|| (next & Tag.SHORT_STRUCT_MASK) == Tag.SHORT_STRUCT;
}
private Object readStruct() throws IOException {
if(!hasStruct()) throw new FormatException();
int id;
if(next == Tag.STRUCT) id = 0xFF & nextNext;
else id = 0xFF & next ^ Tag.SHORT_STRUCT;
return readStruct(id, Object.class);
}
private <T> T readObject(Class<T> t) throws IOException {
try {
Object o = readObject();
@@ -529,18 +493,6 @@ class ReaderImpl implements Reader {
else return false;
}
public <T> T readStruct(int id, Class<T> t) throws IOException {
if(!hasStruct(id)) throw new FormatException();
if(id < 0 || id >= structReaders.length) throw new FormatException();
StructReader<?> s = structReaders[id];
if(s == null) throw new FormatException();
try {
return t.cast(s.readStruct(this));
} catch(ClassCastException e) {
throw new FormatException();
}
}
public void readStructId(int id) throws IOException {
if(!hasStruct(id)) throw new FormatException();
consumeLookahead();