diff --git a/bramble-api/src/main/java/org/briarproject/bramble/api/FeatureFlags.java b/bramble-api/src/main/java/org/briarproject/bramble/api/FeatureFlags.java index e05c6fec5..1f03daea6 100644 --- a/bramble-api/src/main/java/org/briarproject/bramble/api/FeatureFlags.java +++ b/bramble-api/src/main/java/org/briarproject/bramble/api/FeatureFlags.java @@ -6,6 +6,4 @@ package org.briarproject.bramble.api; public interface FeatureFlags { boolean shouldEnableImageAttachments(); - - boolean shouldEnablePrivateMessageDeletion(); } diff --git a/bramble-core/src/test/java/org/briarproject/bramble/test/BrambleCoreIntegrationTestModule.java b/bramble-core/src/test/java/org/briarproject/bramble/test/BrambleCoreIntegrationTestModule.java index 0f92fbce9..840f39c39 100644 --- a/bramble-core/src/test/java/org/briarproject/bramble/test/BrambleCoreIntegrationTestModule.java +++ b/bramble-core/src/test/java/org/briarproject/bramble/test/BrambleCoreIntegrationTestModule.java @@ -18,17 +18,6 @@ public class BrambleCoreIntegrationTestModule { @Provides FeatureFlags provideFeatureFlags() { - return new FeatureFlags() { - - @Override - public boolean shouldEnableImageAttachments() { - return true; - } - - @Override - public boolean shouldEnablePrivateMessageDeletion() { - return true; - } - }; + return () -> true; } } diff --git a/briar-android/src/main/java/org/briarproject/briar/android/AppModule.java b/briar-android/src/main/java/org/briarproject/briar/android/AppModule.java index 65bdcf782..5da45a9c5 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/AppModule.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/AppModule.java @@ -235,17 +235,6 @@ public class AppModule { @Provides FeatureFlags provideFeatureFlags() { - return new FeatureFlags() { - - @Override - public boolean shouldEnableImageAttachments() { - return IS_DEBUG_BUILD; - } - - @Override - public boolean shouldEnablePrivateMessageDeletion() { - return IS_DEBUG_BUILD; - } - }; + return () -> IS_DEBUG_BUILD; } } diff --git a/briar-android/src/main/java/org/briarproject/briar/android/conversation/ConversationActivity.java b/briar-android/src/main/java/org/briarproject/briar/android/conversation/ConversationActivity.java index 52052c407..6aa6986c7 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/conversation/ConversationActivity.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/conversation/ConversationActivity.java @@ -270,9 +270,7 @@ public class ConversationActivity extends BriarActivity ConversationScrollListener scrollListener = new ConversationScrollListener(adapter, viewModel); list.getRecyclerView().addOnScrollListener(scrollListener); - if (featureFlags.shouldEnablePrivateMessageDeletion()) { - addSelectionTracker(); - } + addSelectionTracker(); textInputView = findViewById(R.id.text_input_container); if (featureFlags.shouldEnableImageAttachments()) { @@ -378,11 +376,6 @@ public class ConversationActivity extends BriarActivity MenuInflater inflater = getMenuInflater(); inflater.inflate(R.menu.conversation_actions, menu); - // Hide private message deletion action if feature is not enabled - if (!featureFlags.shouldEnablePrivateMessageDeletion()) { - menu.removeItem(R.id.action_delete_all_messages); - } - // enable introduction action if available observeOnce(viewModel.showIntroductionAction(), this, enable -> { if (enable != null && enable) { diff --git a/briar-headless/src/main/java/org/briarproject/briar/headless/HeadlessModule.kt b/briar-headless/src/main/java/org/briarproject/briar/headless/HeadlessModule.kt index adbd63546..5f622c83b 100644 --- a/briar-headless/src/main/java/org/briarproject/briar/headless/HeadlessModule.kt +++ b/briar-headless/src/main/java/org/briarproject/briar/headless/HeadlessModule.kt @@ -96,8 +96,5 @@ internal class HeadlessModule(private val appDir: File) { internal fun provideObjectMapper() = ObjectMapper() @Provides - internal fun provideFeatureFlags() = object : FeatureFlags { - override fun shouldEnableImageAttachments() = false - override fun shouldEnablePrivateMessageDeletion() = true - } + internal fun provideFeatureFlags() = FeatureFlags { false } } diff --git a/briar-headless/src/test/java/org/briarproject/briar/headless/HeadlessTestModule.kt b/briar-headless/src/test/java/org/briarproject/briar/headless/HeadlessTestModule.kt index 8ef96b5e4..e0e70fac2 100644 --- a/briar-headless/src/test/java/org/briarproject/briar/headless/HeadlessTestModule.kt +++ b/briar-headless/src/test/java/org/briarproject/briar/headless/HeadlessTestModule.kt @@ -63,8 +63,5 @@ internal class HeadlessTestModule(private val appDir: File) { internal fun provideObjectMapper() = ObjectMapper() @Provides - internal fun provideFeatureFlags() = object : FeatureFlags { - override fun shouldEnableImageAttachments() = false - override fun shouldEnablePrivateMessageDeletion() = true - } + internal fun provideFeatureFlags() = FeatureFlags { false } }