diff --git a/briar-android/artwork/il_qr_code_error_dark.svg b/briar-android/artwork/il_qr_code_error_dark.svg new file mode 100644 index 000000000..1d14a6e0d --- /dev/null +++ b/briar-android/artwork/il_qr_code_error_dark.svg @@ -0,0 +1,130 @@ + + + + + + + + + + + + + + + + + + + + + + + diff --git a/briar-android/artwork/il_qr_code_error_light.svg b/briar-android/artwork/il_qr_code_error_light.svg new file mode 100644 index 000000000..470361a40 --- /dev/null +++ b/briar-android/artwork/il_qr_code_error_light.svg @@ -0,0 +1,130 @@ + + + + + + + + + + + + + + + + + + + + + + + diff --git a/briar-android/artwork/qr_code_error.svg b/briar-android/artwork/qr_code_error.svg deleted file mode 100644 index cfd12461e..000000000 --- a/briar-android/artwork/qr_code_error.svg +++ /dev/null @@ -1,52 +0,0 @@ - -image/svg+xml - - - - - - - - - - - - - \ No newline at end of file diff --git a/briar-android/src/main/java/org/briarproject/briar/android/contact/add/nearby/AddNearbyContactErrorFragment.java b/briar-android/src/main/java/org/briarproject/briar/android/contact/add/nearby/AddNearbyContactErrorFragment.java index 34f985a1f..408fab4ec 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/contact/add/nearby/AddNearbyContactErrorFragment.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/contact/add/nearby/AddNearbyContactErrorFragment.java @@ -22,7 +22,7 @@ import androidx.fragment.app.FragmentActivity; import androidx.lifecycle.ViewModelProvider; import static android.content.Intent.FLAG_ACTIVITY_CLEAR_TOP; -import static android.view.View.GONE; +import static org.briarproject.briar.android.util.UiUtils.hideViewOnSmallScreen; import static org.briarproject.briar.android.util.UiUtils.onSingleLinkClick; @MethodsNotNullByDefault @@ -70,8 +70,11 @@ public class AddNearbyContactErrorFragment extends BaseFragment { TextView explanation = v.findViewById(R.id.errorMessage); Bundle args = getArguments(); String errorMessage = args == null ? null : args.getString(ERROR_MSG); - if (errorMessage == null) explanation.setVisibility(GONE); - else explanation.setText(args.getString(ERROR_MSG)); + if (errorMessage == null) { + explanation.setText(getString(R.string.add_contact_error_two_way)); + } else { + explanation.setText(args.getString(ERROR_MSG)); + } // make feedback link clickable TextView sendFeedback = v.findViewById(R.id.sendFeedback); @@ -100,6 +103,12 @@ public class AddNearbyContactErrorFragment extends BaseFragment { viewModel.stopListening(); } + @Override + public void onStart() { + super.onStart(); + hideViewOnSmallScreen(requireView().findViewById(R.id.errorIcon)); + } + private void triggerFeedback() { UiUtils.triggerFeedback(requireContext()); finish(); diff --git a/briar-android/src/main/res/drawable-night/il_qr_code_error.xml b/briar-android/src/main/res/drawable-night/il_qr_code_error.xml new file mode 100644 index 000000000..36cb7b1d6 --- /dev/null +++ b/briar-android/src/main/res/drawable-night/il_qr_code_error.xml @@ -0,0 +1,72 @@ + + + + + + + + + + + + + + + + + + + + diff --git a/briar-android/src/main/res/drawable/il_qr_code_error.xml b/briar-android/src/main/res/drawable/il_qr_code_error.xml new file mode 100644 index 000000000..04bc638c7 --- /dev/null +++ b/briar-android/src/main/res/drawable/il_qr_code_error.xml @@ -0,0 +1,72 @@ + + + + + + + + + + + + + + + + + + + + diff --git a/briar-android/src/main/res/drawable/qr_code_error.xml b/briar-android/src/main/res/drawable/qr_code_error.xml deleted file mode 100644 index f866e6389..000000000 --- a/briar-android/src/main/res/drawable/qr_code_error.xml +++ /dev/null @@ -1,23 +0,0 @@ - - - - - - - - \ No newline at end of file diff --git a/briar-android/src/main/res/layout/fragment_error_contact_exchange.xml b/briar-android/src/main/res/layout/fragment_error_contact_exchange.xml index 655441298..40cc0983a 100644 --- a/briar-android/src/main/res/layout/fragment_error_contact_exchange.xml +++ b/briar-android/src/main/res/layout/fragment_error_contact_exchange.xml @@ -18,7 +18,7 @@ + android:layout_margin="@dimen/margin_large"> Add Contact Nearby Both of you need to scan each other\'s QR code. + Did both of you scan each other\'s QR code? You must meet up with the person you want to add as a contact.\n\nThis will prevent anyone from impersonating you or reading your messages in future. Continue Try Again