diff --git a/briar-android/src/main/java/org/briarproject/briar/android/contact/add/remote/NicknameFragment.java b/briar-android/src/main/java/org/briarproject/briar/android/contact/add/remote/NicknameFragment.java index b084c061d..acb5da8c2 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/contact/add/remote/NicknameFragment.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/contact/add/remote/NicknameFragment.java @@ -55,6 +55,7 @@ public class NicknameFragment extends BaseFragment { private TextInputLayout contactNameLayout; private TextInputEditText contactNameInput; + private BriarButton addButton; @Override public String getUniqueTag() { @@ -91,7 +92,7 @@ public class NicknameFragment extends BaseFragment { contactNameLayout = v.findViewById(R.id.contactNameLayout); contactNameInput = v.findViewById(R.id.contactNameInput); - BriarButton addButton = v.findViewById(R.id.addButton); + addButton = v.findViewById(R.id.addButton); addButton.setOnClickListener(view -> onAddButtonClicked()); return v; @@ -112,7 +113,7 @@ public class NicknameFragment extends BaseFragment { @Nullable private String getNicknameOrNull() { Editable text = contactNameInput.getText(); - if (text == null || text.toString().trim().length() == 0) { + if (text == null || text.toString().trim().isEmpty()) { contactNameLayout.setError(getString(R.string.nickname_missing)); contactNameInput.requestFocus(); return null; @@ -129,7 +130,10 @@ public class NicknameFragment extends BaseFragment { private void onAddButtonClicked() { String name = getNicknameOrNull(); - if (name == null) return; // invalid nickname + if (name == null) { // invalid nickname + addButton.reset(); + return; + } LifecycleOwner owner = getViewLifecycleOwner(); viewModel.getAddContactResult().observe(owner, result -> { diff --git a/briar-android/src/main/java/org/briarproject/briar/android/util/BriarSnackbarBuilder.java b/briar-android/src/main/java/org/briarproject/briar/android/util/BriarSnackbarBuilder.java index 0586e5a5f..8ff4c2058 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/util/BriarSnackbarBuilder.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/util/BriarSnackbarBuilder.java @@ -26,7 +26,9 @@ public class BriarSnackbarBuilder { public Snackbar make(View view, CharSequence text, int duration) { Snackbar s = Snackbar.make(view, text, duration); - s.getView().setBackgroundResource(backgroundResId); + s.setBackgroundTint(getColor(view.getContext(), backgroundResId)); + s.setTextColor( + getColor(view.getContext(), R.color.md_theme_onSecondary)); if (onClickListener != null) { s.setActionTextColor(getColor(view.getContext(), R.color.briar_button_text_positive)); diff --git a/briar-android/src/main/java/org/briarproject/briar/android/view/BriarButton.java b/briar-android/src/main/java/org/briarproject/briar/android/view/BriarButton.java index 7247cc935..1a5b6b567 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/view/BriarButton.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/view/BriarButton.java @@ -49,7 +49,7 @@ public class BriarButton extends FrameLayout { ContextThemeWrapper wrapper = new ContextThemeWrapper(context, style); button = isInEditMode() ? new MaterialButton(context) : - new MaterialButton(wrapper); + new MaterialButton(wrapper, null, style); button.setText(text); addView(button); progressBar = findViewById(R.id.briar_button_progress_bar); diff --git a/briar-android/src/main/res/color/button_text.xml b/briar-android/src/main/res/color/button_text.xml deleted file mode 100644 index 1f1c03e9f..000000000 --- a/briar-android/src/main/res/color/button_text.xml +++ /dev/null @@ -1,9 +0,0 @@ - - - - - \ No newline at end of file diff --git a/briar-android/src/main/res/drawable-v21/button_outline.xml b/briar-android/src/main/res/drawable-v21/button_outline.xml deleted file mode 100644 index d7a4382c2..000000000 --- a/briar-android/src/main/res/drawable-v21/button_outline.xml +++ /dev/null @@ -1,7 +0,0 @@ - - - - diff --git a/briar-android/src/main/res/drawable-v21/button_outline_background.xml b/briar-android/src/main/res/drawable-v21/button_outline_background.xml deleted file mode 100644 index 960d21db4..000000000 --- a/briar-android/src/main/res/drawable-v21/button_outline_background.xml +++ /dev/null @@ -1,19 +0,0 @@ - - - - - - - - diff --git a/briar-android/src/main/res/drawable-v21/button_outline_mask.xml b/briar-android/src/main/res/drawable-v21/button_outline_mask.xml deleted file mode 100644 index 88b29c7a2..000000000 --- a/briar-android/src/main/res/drawable-v21/button_outline_mask.xml +++ /dev/null @@ -1,19 +0,0 @@ - - - - - - - - diff --git a/briar-android/src/main/res/drawable/button_outline.xml b/briar-android/src/main/res/drawable/button_outline.xml deleted file mode 100644 index 795b3fdca..000000000 --- a/briar-android/src/main/res/drawable/button_outline.xml +++ /dev/null @@ -1,16 +0,0 @@ - - - - - - - - - - \ No newline at end of file diff --git a/briar-android/src/main/res/layout/fragment_hotspot_intro.xml b/briar-android/src/main/res/layout/fragment_hotspot_intro.xml index 0789c5fc5..d8017ddda 100644 --- a/briar-android/src/main/res/layout/fragment_hotspot_intro.xml +++ b/briar-android/src/main/res/layout/fragment_hotspot_intro.xml @@ -61,7 +61,7 @@ android:layout_marginHorizontal="@dimen/margin_large" android:text="@string/hotspot_button_start_sharing" app:icon="@drawable/ic_wifi_tethering" - app:iconTint="@color/button_text" + app:iconTint="?attr/colorOnPrimary" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" diff --git a/briar-android/src/main/res/layout/fragment_hotspot_tabs.xml b/briar-android/src/main/res/layout/fragment_hotspot_tabs.xml index 9ccf1cb78..ed6ee1088 100644 --- a/briar-android/src/main/res/layout/fragment_hotspot_tabs.xml +++ b/briar-android/src/main/res/layout/fragment_hotspot_tabs.xml @@ -78,7 +78,7 @@ android:layout_marginTop="6dp" android:text="@string/hotspot_button_connected" app:icon="@drawable/ic_check_white" - app:iconTint="@color/button_text" + app:iconTint="?attr/colorOnPrimary" app:layout_constraintBottom_toTopOf="@+id/stopButton" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" diff --git a/briar-android/src/main/res/layout/fragment_mailbox_setup_download.xml b/briar-android/src/main/res/layout/fragment_mailbox_setup_download.xml index aa49a5893..b17011be0 100644 --- a/briar-android/src/main/res/layout/fragment_mailbox_setup_download.xml +++ b/briar-android/src/main/res/layout/fragment_mailbox_setup_download.xml @@ -54,7 +54,7 @@ android:layout_marginHorizontal="@dimen/margin_large" android:text="@string/mailbox_setup_button_scan" app:icon="@drawable/ic_qr_code" - app:iconTint="@color/button_text" + app:iconTint="?attr/colorOnPrimary" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" diff --git a/briar-android/src/main/res/layout/image_preview.xml b/briar-android/src/main/res/layout/image_preview.xml index 83bd2271e..93a38cdc0 100644 --- a/briar-android/src/main/res/layout/image_preview.xml +++ b/briar-android/src/main/res/layout/image_preview.xml @@ -38,13 +38,15 @@ android:layout_marginEnd="8dp" android:layout_marginRight="8dp" android:layout_marginBottom="8dp" - app:backgroundTint="@color/briar_accent" + android:contentDescription="@string/close" + app:backgroundTint="?colorSecondary" app:fabCustomSize="26dp" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintTop_toTopOf="parent" app:layout_constraintVertical_bias="0" app:maxImageSize="18dp" - app:srcCompat="@drawable/ic_close" /> + app:srcCompat="@drawable/ic_close" + app:tint="?colorOnSecondary" /> diff --git a/briar-android/src/main/res/values-night/color.xml b/briar-android/src/main/res/values-night/color.xml index c59204414..fee652a4a 100644 --- a/briar-android/src/main/res/values-night/color.xml +++ b/briar-android/src/main/res/values-night/color.xml @@ -3,7 +3,6 @@ @color/briar_night_800 @color/briar_lime_600 - @color/briar_accent @color/briar_night_950 @android:color/white @@ -18,7 +17,6 @@ @color/briar_night_800 @color/briar_night_700 - @color/briar_night_500 @color/briar_blue_400 #23cccccc @@ -33,45 +31,6 @@ @color/briar_orange_400 @color/briar_red_500_new - #3E506B - #E7EFFF - #E4FFE2 - #003915 - #3BEA75 - #00451B - #FFB4AB - #690005 - #D01B1F - #FFFFFF - #11150A #E0E4D2 - #11150A #E0E4D2 - #424936 - #C2CAB0 - #8C947C - #424936 - #000000 - #E0E4D2 - #2E3226 - #446900 - #B2F746 - #121F00 - #98DA27 - #334F00 - #D4E3FF - #071C34 - #B5C8E7 - #364862 - #66FF8E - #002109 - #30E36F - #005321 - #11150A - #363B2E - #0B1006 - #191D12 - #1D2116 - #272C1F - #32362A diff --git a/briar-android/src/main/res/values/color.xml b/briar-android/src/main/res/values/color.xml index e87d5f56b..9b4848c90 100644 --- a/briar-android/src/main/res/values/color.xml +++ b/briar-android/src/main/res/values/color.xml @@ -75,15 +75,12 @@ #b4ffffff #80ffffff - @color/briar_night_500 @color/window_background - @color/briar_accent @color/briar_blue_400 @color/briar_night_500 @color/briar_red_500 #28000000 - @android:color/secondary_text_dark @color/briar_gray_500 @color/window_background @@ -97,48 +94,10 @@ @color/briar_lime_950 @color/briar_night_700 @android:color/white + #98DA27 @color/briar_night_700 @android:color/white - #576985 - #FFFFFF - #006E2F - #FFFFFF - #4CF780 - #004E1F - #A0000E - #FFFFFF - #DC2626 - #FFFFFF - #F7FBE8 #191D12 - #F7FBE8 #191D12 - #DEE6CB - #424936 - #727A64 - #C2CAB0 - #000000 - #2E3226 - #EFF3E0 - #98DA27 - #B2F746 - #121F00 - #98DA27 - #334F00 - #D4E3FF - #071C34 - #B5C8E7 - #364862 - #66FF8E - #002109 - #30E36F - #005321 - #D8DCCA - #F7FBE8 - #FFFFFF - #F2F6E3 - #ECF0DD - #E6EAD8 - #E0E4D2 diff --git a/briar-android/src/main/res/values/themes.xml b/briar-android/src/main/res/values/themes.xml index 60cfd472a..e8e1a57b4 100644 --- a/briar-android/src/main/res/values/themes.xml +++ b/briar-android/src/main/res/values/themes.xml @@ -12,6 +12,7 @@ @color/md_theme_onBackground @color/card_background @color/md_theme_onSurface + @color/briar_red_600 #000000 @color/window_background