diff --git a/bramble-core/src/main/java/org/briarproject/bramble/db/DatabaseComponentImpl.java b/bramble-core/src/main/java/org/briarproject/bramble/db/DatabaseComponentImpl.java index 833e2167e..fae1e85d1 100644 --- a/bramble-core/src/main/java/org/briarproject/bramble/db/DatabaseComponentImpl.java +++ b/bramble-core/src/main/java/org/briarproject/bramble/db/DatabaseComponentImpl.java @@ -415,12 +415,12 @@ class DatabaseComponentImpl implements DatabaseComponent { if (small) ids = db.getSmallMessagesToSend(txn, c, maxLength, maxLatency); else ids = db.getMessagesToSend(txn, c, maxLength, maxLatency); + if (ids.isEmpty()) return null; List messages = new ArrayList<>(ids.size()); for (MessageId m : ids) { messages.add(db.getSmallMessage(txn, m)); db.updateExpiryTimeAndEta(txn, c, m, maxLatency); } - if (ids.isEmpty()) return null; db.lowerRequestedFlag(txn, c, ids); transaction.attach(new MessagesSentEvent(c, ids)); return messages; @@ -454,12 +454,12 @@ class DatabaseComponentImpl implements DatabaseComponent { throw new NoSuchContactException(); Collection ids = db.getRequestedMessagesToSend(txn, c, maxLength, maxLatency); + if (ids.isEmpty()) return null; List messages = new ArrayList<>(ids.size()); for (MessageId m : ids) { messages.add(db.getSmallMessage(txn, m)); db.updateExpiryTimeAndEta(txn, c, m, maxLatency); } - if (ids.isEmpty()) return null; db.lowerRequestedFlag(txn, c, ids); transaction.attach(new MessagesSentEvent(c, ids)); return messages;