diff --git a/briar-android/src/main/java/org/briarproject/briar/android/blog/BlogControllerImpl.java b/briar-android/src/main/java/org/briarproject/briar/android/blog/BlogControllerImpl.java index f200702ef..ae666f691 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/blog/BlogControllerImpl.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/blog/BlogControllerImpl.java @@ -26,7 +26,7 @@ import org.briarproject.briar.api.blog.BlogSharingManager; import org.briarproject.briar.api.blog.event.BlogInvitationResponseReceivedEvent; import org.briarproject.briar.api.blog.event.BlogPostAddedEvent; import org.briarproject.briar.api.sharing.InvitationResponse; -import org.briarproject.briar.api.sharing.event.ShareableLeftEvent; +import org.briarproject.briar.api.sharing.event.ContactLeftShareableEvent; import java.util.ArrayList; import java.util.Collection; @@ -110,10 +110,10 @@ class BlogControllerImpl extends BaseControllerImpl LOG.info("Blog invitation accepted"); onBlogInvitationAccepted(b.getContactId()); } - } else if (e instanceof ShareableLeftEvent) { - ShareableLeftEvent s = (ShareableLeftEvent) e; + } else if (e instanceof ContactLeftShareableEvent) { + ContactLeftShareableEvent s = (ContactLeftShareableEvent) e; if (s.getGroupId().equals(groupId)) { - LOG.info("Blog left"); + LOG.info("Blog left by contact"); onBlogLeft(s.getContactId()); } } else if (e instanceof GroupRemovedEvent) { diff --git a/briar-android/src/main/java/org/briarproject/briar/android/controller/SharingControllerImpl.java b/briar-android/src/main/java/org/briarproject/briar/android/controller/SharingControllerImpl.java index 87afdfe52..700beee63 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/controller/SharingControllerImpl.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/controller/SharingControllerImpl.java @@ -18,7 +18,6 @@ import java.util.Set; import javax.inject.Inject; -@UiThread @NotNullByDefault public class SharingControllerImpl implements SharingController, EventListener { @@ -26,8 +25,9 @@ public class SharingControllerImpl implements SharingController, EventListener { private final ConnectionRegistry connectionRegistry; @Nullable - private SharingListener listener; - private Set contacts = new HashSet<>(); + private volatile SharingListener listener; + // only access on @UiThread + private final Set contacts = new HashSet<>(); @Inject SharingControllerImpl(EventBus eventBus, diff --git a/briar-api/src/main/java/org/briarproject/briar/api/sharing/event/ShareableLeftEvent.java b/briar-api/src/main/java/org/briarproject/briar/api/sharing/event/ContactLeftShareableEvent.java similarity index 82% rename from briar-api/src/main/java/org/briarproject/briar/api/sharing/event/ShareableLeftEvent.java rename to briar-api/src/main/java/org/briarproject/briar/api/sharing/event/ContactLeftShareableEvent.java index 0548ea002..69ffbab3c 100644 --- a/briar-api/src/main/java/org/briarproject/briar/api/sharing/event/ShareableLeftEvent.java +++ b/briar-api/src/main/java/org/briarproject/briar/api/sharing/event/ContactLeftShareableEvent.java @@ -10,12 +10,12 @@ import javax.annotation.concurrent.Immutable; @Immutable @NotNullByDefault -public class ShareableLeftEvent extends Event { +public class ContactLeftShareableEvent extends Event { private final GroupId groupId; private final ContactId contactId; - public ShareableLeftEvent(GroupId groupId, ContactId contactId) { + public ContactLeftShareableEvent(GroupId groupId, ContactId contactId) { this.groupId = groupId; this.contactId = contactId; } diff --git a/briar-core/src/main/java/org/briarproject/briar/sharing/BlogSharingManagerImpl.java b/briar-core/src/main/java/org/briarproject/briar/sharing/BlogSharingManagerImpl.java index ba56908d8..68db4520d 100644 --- a/briar-core/src/main/java/org/briarproject/briar/sharing/BlogSharingManagerImpl.java +++ b/briar-core/src/main/java/org/briarproject/briar/sharing/BlogSharingManagerImpl.java @@ -258,7 +258,7 @@ class BlogSharingManagerImpl extends @Override public BlogInvitation build(BlogSharerSessionState localState, long time) { - return new BlogInvitation(localState.getGroupId(), + return new BlogInvitation(localState.getContactGroupId(), localState.getSessionId(), localState.getBlogAuthorName(), localState.getBlogPublicKey(), time, localState.getMessage()); @@ -338,7 +338,7 @@ class BlogSharingManagerImpl extends ContactId contactId = localState.getContactId(); BlogInvitationRequest request = new BlogInvitationRequest(localState.getInvitationId(), - localState.getSessionId(), localState.getGroupId(), + localState.getSessionId(), localState.getContactGroupId(), contactId, blog.getAuthor().getName(), msg, true, time, false, false, false, false); return new BlogInvitationRequestReceivedEvent(blog, contactId, diff --git a/briar-core/src/main/java/org/briarproject/briar/sharing/ForumSharingManagerImpl.java b/briar-core/src/main/java/org/briarproject/briar/sharing/ForumSharingManagerImpl.java index 84363a708..8d9255255 100644 --- a/briar-core/src/main/java/org/briarproject/briar/sharing/ForumSharingManagerImpl.java +++ b/briar-core/src/main/java/org/briarproject/briar/sharing/ForumSharingManagerImpl.java @@ -191,7 +191,7 @@ class ForumSharingManagerImpl extends @Override public ForumInvitation build(ForumSharerSessionState localState, long time) { - return new ForumInvitation(localState.getGroupId(), + return new ForumInvitation(localState.getContactGroupId(), localState.getSessionId(), localState.getForumName(), localState.getForumSalt(), time, localState.getMessage()); } @@ -268,7 +268,7 @@ class ForumSharingManagerImpl extends ContactId contactId = localState.getContactId(); ForumInvitationRequest request = new ForumInvitationRequest( localState.getInvitationId(), localState.getSessionId(), - localState.getGroupId(), contactId, forum.getName(), msg, + localState.getContactGroupId(), contactId, forum.getName(), msg, true, time, false, false, false, false); return new ForumInvitationRequestReceivedEvent(forum, contactId, request); diff --git a/briar-core/src/main/java/org/briarproject/briar/sharing/InviteeEngine.java b/briar-core/src/main/java/org/briarproject/briar/sharing/InviteeEngine.java index a8a5a16fd..92a534da6 100644 --- a/briar-core/src/main/java/org/briarproject/briar/sharing/InviteeEngine.java +++ b/briar-core/src/main/java/org/briarproject/briar/sharing/InviteeEngine.java @@ -77,20 +77,20 @@ class InviteeEngine messages = Collections.singletonList(msg); diff --git a/briar-core/src/main/java/org/briarproject/briar/sharing/SharerEngine.java b/briar-core/src/main/java/org/briarproject/briar/sharing/SharerEngine.java index 476580f91..7d5b35183 100644 --- a/briar-core/src/main/java/org/briarproject/briar/sharing/SharerEngine.java +++ b/briar-core/src/main/java/org/briarproject/briar/sharing/SharerEngine.java @@ -86,7 +86,7 @@ class SharerEngine messages = Collections.singletonList(msg); diff --git a/briar-core/src/main/java/org/briarproject/briar/sharing/SharingManagerImpl.java b/briar-core/src/main/java/org/briarproject/briar/sharing/SharingManagerImpl.java index 958900629..44ba74960 100644 --- a/briar-core/src/main/java/org/briarproject/briar/sharing/SharingManagerImpl.java +++ b/briar-core/src/main/java/org/briarproject/briar/sharing/SharingManagerImpl.java @@ -39,7 +39,7 @@ import org.briarproject.briar.api.sharing.SharingInvitationItem; import org.briarproject.briar.api.sharing.SharingManager; import org.briarproject.briar.api.sharing.event.InvitationRequestReceivedEvent; import org.briarproject.briar.api.sharing.event.InvitationResponseReceivedEvent; -import org.briarproject.briar.api.sharing.event.ShareableLeftEvent; +import org.briarproject.briar.api.sharing.event.ContactLeftShareableEvent; import org.briarproject.briar.client.ConversationClientImpl; import java.io.IOException; @@ -302,7 +302,7 @@ abstract class SharingManagerImpl