From 745515457e399474bef9c4c6e941bfa1bcf1358e Mon Sep 17 00:00:00 2001 From: Torsten Grote Date: Mon, 17 Sep 2018 12:21:16 -0300 Subject: [PATCH] Add warning to FLAG_SECURE about app locking implications --- .../briarproject/briar/android/activity/BaseActivity.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/briar-android/src/main/java/org/briarproject/briar/android/activity/BaseActivity.java b/briar-android/src/main/java/org/briarproject/briar/android/activity/BaseActivity.java index c693ccbfc..4e8dcc9ba 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/activity/BaseActivity.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/activity/BaseActivity.java @@ -68,6 +68,11 @@ public abstract class BaseActivity extends AppCompatActivity public void onCreate(@Nullable Bundle state) { super.onCreate(state); + // WARNING: When removing this or making it possible to turn it off, + // we need a solution for the app lock feature. + // When the app is locked by a timeout and FLAG_SECURE is not + // set, the app content becomes visible briefly before the + // unlock screen is shown. if (PREVENT_SCREENSHOTS) getWindow().addFlags(FLAG_SECURE); AndroidComponent applicationComponent =