Kaladaran/briar
0
0
Fork 0
mirror of https://code.briarproject.org/briar/briar.git synced 2026-02-19 06:09:55 +01:00
Code Issues Projects Releases Wiki Activity

Empty states: Address review comments

Browse Source
This commit is contained in:
Torsten Grote
2018-08-20 15:13:36 -03:00
parent 5ed0e9efec
commit 83886c78f1
4 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
briar-android/src/main/java/org/briarproject/briar/android/contactselection/BaseContactSelectorFragment.java
View File

@@ -69,7 +69,9 @@ public abstract class BaseContactSelectorFragment<I extends SelectableContactIte
list = contentView.findViewById(R.id.list); list = contentView.findViewById(R.id.list);
list.setLayoutManager(new LinearLayoutManager(getActivity())); list.setLayoutManager(new LinearLayoutManager(getActivity()));
list.setEmptyImage(R.drawable.ic_empty_state_contact_list);
list.setEmptyText(getString(R.string.no_contacts_selector)); list.setEmptyText(getString(R.string.no_contacts_selector));
list.setEmptyAction(getString(R.string.no_contacts_selector_action));
adapter = getAdapter(getContext(), this); adapter = getAdapter(getContext(), this);
list.setAdapter(adapter); list.setAdapter(adapter);

2
briar-android/src/main/java/org/briarproject/briar/android/introduction/ContactChooserFragment.java
View File

@@ -82,7 +82,7 @@ public class ContactChooserFragment extends BaseFragment {
list = contentView.findViewById(R.id.list); list = contentView.findViewById(R.id.list);
list.setLayoutManager(new LinearLayoutManager(getActivity())); list.setLayoutManager(new LinearLayoutManager(getActivity()));
list.setAdapter(adapter); list.setAdapter(adapter);
list.setEmptyText(getString(R.string.no_contacts)); list.setEmptyText(R.string.no_contacts);
contactId = new ContactId(getArguments().getInt(CONTACT_ID)); contactId = new ContactId(getArguments().getInt(CONTACT_ID));

1
briar-android/src/main/res/layout/briar_recycler_view.xml
View File

@@ -76,7 +76,6 @@
android:paddingBottom="@dimen/margin_large" android:paddingBottom="@dimen/margin_large"
android:paddingLeft="@dimen/margin_large" android:paddingLeft="@dimen/margin_large"
android:paddingRight="@dimen/margin_large" android:paddingRight="@dimen/margin_large"
android:text="@string/no_data"
android:textSize="@dimen/text_size_small" android:textSize="@dimen/text_size_small"
app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent" app:layout_constraintEnd_toEndOf="parent"

3
briar-android/src/main/res/values/strings.xml
View File

@@ -261,7 +261,8 @@
<string name="forum_share_button">Share Forum</string> <string name="forum_share_button">Share Forum</string>
<string name="contacts_selected">Contacts selected</string> <string name="contacts_selected">Contacts selected</string>
<string name="activity_share_toolbar_header">Choose Contacts</string> <string name="activity_share_toolbar_header">Choose Contacts</string>
<string name="no_contacts_selector">No contacts to show\n\nPlease come back here after adding a contact</string> <string name="no_contacts_selector">No contacts to show</string>
<string name="no_contacts_selector_action">Please come back here after adding a contact</string>
<string name="forum_shared_snackbar">Forum shared with chosen contacts</string> <string name="forum_shared_snackbar">Forum shared with chosen contacts</string>
<string name="forum_share_message">Add a message (optional)</string> <string name="forum_share_message">Add a message (optional)</string>
<string name="forum_share_error">There was an error sharing this forum.</string> <string name="forum_share_error">There was an error sharing this forum.</string>