From ce6293b1d396811477df6042575c0668b460858a Mon Sep 17 00:00:00 2001 From: Torsten Grote Date: Wed, 18 Jul 2018 09:33:37 -0300 Subject: [PATCH] Dark theme changes based on designer feedback --- .../artwork/logo_horizontal_white.svg | 64 ++------- .../artwork/navigation_drawer_header.svg | 70 ++++++++++ .../navigation_drawer_header_night.svg | 70 ++++++++++ .../android/settings/SettingsFragment.java | 15 +++ .../navigation_drawer_header.xml | 19 +++ .../navigation_item_background.xml | 5 + .../res/drawable/navigation_drawer_header.xml | 126 ++---------------- .../drawable/navigation_item_background.xml | 5 + .../src/main/res/layout/navigation_menu.xml | 39 ++++-- .../main/res/layout/preferences_category.xml | 9 +- .../main/res/layout/text_input_view_large.xml | 1 + .../src/main/res/layout/transports_list.xml | 1 - .../src/main/res/values-night/color.xml | 15 ++- briar-android/src/main/res/values/color.xml | 14 +- briar-android/src/main/res/values/styles.xml | 6 + briar-android/src/main/res/values/themes.xml | 11 ++ 16 files changed, 270 insertions(+), 200 deletions(-) create mode 100644 briar-android/artwork/navigation_drawer_header.svg create mode 100644 briar-android/artwork/navigation_drawer_header_night.svg create mode 100644 briar-android/src/main/res/drawable-night/navigation_drawer_header.xml create mode 100644 briar-android/src/main/res/drawable-night/navigation_item_background.xml create mode 100644 briar-android/src/main/res/drawable/navigation_item_background.xml diff --git a/briar-android/artwork/logo_horizontal_white.svg b/briar-android/artwork/logo_horizontal_white.svg index 8aa45874c..d3835aae6 100644 --- a/briar-android/artwork/logo_horizontal_white.svg +++ b/briar-android/artwork/logo_horizontal_white.svg @@ -14,7 +14,7 @@ x="0px" y="0px" xml:space="preserve" - inkscape:version="0.91 r13725" + inkscape:version="0.92.3 (2405546, 2018-03-11)" sodipodi:docname="logo_horizontal_white.svg" width="138" height="50"> + + +image/svg+xml \ No newline at end of file diff --git a/briar-android/artwork/navigation_drawer_header_night.svg b/briar-android/artwork/navigation_drawer_header_night.svg new file mode 100644 index 000000000..6627e299e --- /dev/null +++ b/briar-android/artwork/navigation_drawer_header_night.svg @@ -0,0 +1,70 @@ + + + +image/svg+xml \ No newline at end of file diff --git a/briar-android/src/main/java/org/briarproject/briar/android/settings/SettingsFragment.java b/briar-android/src/main/java/org/briarproject/briar/android/settings/SettingsFragment.java index 955680ff5..f5c38f23c 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/settings/SettingsFragment.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/settings/SettingsFragment.java @@ -4,17 +4,22 @@ import android.annotation.TargetApi; import android.app.AlertDialog; import android.content.Context; import android.content.Intent; +import android.graphics.drawable.ColorDrawable; import android.media.Ringtone; import android.media.RingtoneManager; import android.net.Uri; import android.os.Bundle; import android.support.annotation.StringRes; +import android.support.v4.content.ContextCompat; import android.support.v4.text.TextUtilsCompat; import android.support.v7.preference.CheckBoxPreference; import android.support.v7.preference.ListPreference; import android.support.v7.preference.Preference; import android.support.v7.preference.PreferenceFragmentCompat; import android.support.v7.preference.PreferenceGroup; +import android.view.LayoutInflater; +import android.view.View; +import android.view.ViewGroup; import android.widget.Toast; import org.acra.ACRA; @@ -216,6 +221,16 @@ public class SettingsFragment extends PreferenceFragmentCompat loadSettings(); } + @Override + public View onCreateView(LayoutInflater inflater, ViewGroup container, + Bundle savedInstanceState) { + View view = super.onCreateView(inflater, container, savedInstanceState); + ColorDrawable divider = new ColorDrawable( + ContextCompat.getColor(getContext(), R.color.divider)); + setDivider(divider); + return view; + } + @Override public void onStart() { super.onStart(); diff --git a/briar-android/src/main/res/drawable-night/navigation_drawer_header.xml b/briar-android/src/main/res/drawable-night/navigation_drawer_header.xml new file mode 100644 index 000000000..4c79711a7 --- /dev/null +++ b/briar-android/src/main/res/drawable-night/navigation_drawer_header.xml @@ -0,0 +1,19 @@ + + + + + + + \ No newline at end of file diff --git a/briar-android/src/main/res/drawable-night/navigation_item_background.xml b/briar-android/src/main/res/drawable-night/navigation_item_background.xml new file mode 100644 index 000000000..deac89913 --- /dev/null +++ b/briar-android/src/main/res/drawable-night/navigation_item_background.xml @@ -0,0 +1,5 @@ + + + + + diff --git a/briar-android/src/main/res/drawable/navigation_drawer_header.xml b/briar-android/src/main/res/drawable/navigation_drawer_header.xml index 9771b2cae..7a735dff0 100644 --- a/briar-android/src/main/res/drawable/navigation_drawer_header.xml +++ b/briar-android/src/main/res/drawable/navigation_drawer_header.xml @@ -1,129 +1,19 @@ + android:viewportWidth="146"> - + android:pathData="M 65.097656,30.699216 v 19.30078 h 9.06836 c 4.22557,0 6.474893,-2.12355 6.496093,-5.47852 0,-2.14464 -1.017672,-3.78004 -3.013671,-4.67187 v -0.041 c 1.507609,-0.9343 2.166015,-2.10331 2.166015,-3.9082 0,-2.73919 -1.848098,-5.20117 -5.861328,-5.20117 h -8.855469 z m 18.75,0 v 19.30078 h 2.271485 v -7.72852 l -0.232422,-0.23437 h 4.585937 c 2.54808,0 4.012966,0.91391 4.947266,2.88867 l 2.40039,5.07422 h 2.546878 l -2.92969,-6.03125 c -0.63702,-1.35898 -1.614284,-2.20763 -2.527344,-2.58984 v -0.043 c 2.1234,-0.55208 3.865235,-2.42042 3.865235,-4.94727 0,-3.80089 -2.951713,-5.68945 -6.476563,-5.68945 h -8.451172 z m 18.876954,0 v 19.30078 h 2.27344 v -19.30078 z m 13.41992,0 -8.49414,19.30078 h 2.48438 l 2.03906,-4.65039 -0.12695,-0.23438 h 10.57421 l -0.12695,0.23438 2.03906,4.65039 h 2.48438 l -8.47266,-19.30078 z m 13.33594,0 v 19.30078 h 2.27148 v -7.72852 l -0.23437,-0.23437 h 4.58789 c 2.54808,0 4.01296,0.91391 4.94726,2.88867 l 2.39844,5.07422 H 146 l -2.92969,-6.03125 c -0.63702,-1.35898 -1.61427,-2.20763 -2.52734,-2.58984 v -0.043 c 2.12341,-0.55208 3.86523,-2.42042 3.86523,-4.94727 0,-3.80089 -2.95171,-5.68945 -6.47656,-5.68945 h -8.45117 z m -62.322267,2.14453 h 6.560547 c 2.46315,0 3.759766,0.9967 3.759766,3.03516 0,1.71996 -0.999336,3.10156 -3.759766,3.10156 h -6.560547 l 0.234375,-0.23438 v -5.66992 z m 18.728516,0 h 6.433593 c 2.378211,0 4.14091,0.97535 4.16211,3.52344 0,2.03846 -1.634356,3.5039 -4.416016,3.5039 h -6.179687 l 0.232422,-0.23242 v -6.5625 z m 45.652341,0 h 6.4336 c 2.35698,0 4.14062,0.97535 4.14062,3.52344 0,2.03846 -1.61288,3.5039 -4.39453,3.5039 h -6.17969 l 0.23438,-0.23242 v -6.5625 z m -14.20508,0.21094 h 0.043 l 0.57227,1.93359 3.39844,7.75 0.23242,0.23242 h -8.4707 l 0.23242,-0.23242 3.39843,-7.75 0.59375,-1.93359 z m -50.197261,8.07031 h 7.007812 c 2.84536,0 4.16211,1.3153 4.16211,3.375 0,2.14464 -1.189095,3.33398 -4.140625,3.33398 h -7.029297 l 0.234375,-0.23437 v -6.24219 z"/> - + android:pathData="M 13.808594,0 c -2.06383,0 -3.766207,1.7019614 -3.766207,3.7657911 V 8.553025 h 9.276928 V 3.7657911 C 19.319315,1.7019614 17.638132,0 15.574302,0 Z m 20.638297,0 c -2.06383,0 -3.766206,1.7019614 -3.766206,3.7657911 V 29.191323 h 9.276927 V 3.7657911 C 39.957612,1.7019614 38.276429,0 36.212599,0 Z M 10.042387,20.808676 v 25.425531 c 0,2.06383 1.681101,3.765791 3.766207,3.765791 h 1.765708 c 2.06383,0 3.766207,-1.701961 3.766207,-3.765791 V 20.808676 Z m 20.638298,20.638297 v 4.787234 c 0,2.06383 1.702376,3.765791 3.766206,3.765791 h 1.765708 c 2.06383,0 3.766206,-1.701961 3.766206,-3.765791 v -4.787234 z" + android:strokeWidth="0.21276595"/> - - - - - - - + android:pathData="M 3.7657914,10.042387 C 1.7019617,10.042387 0,11.723487 0,13.808594 v 1.765708 c 0,2.063829 1.6806851,3.766206 3.7657914,3.766206 H 29.191323 v -9.298121 z m 37.6811826,0 v 9.298121 h 4.787233 c 2.06383,0 3.765792,-1.6811 3.765792,-3.766206 v -1.765708 c 0,-2.085107 -1.701962,-3.766207 -3.765792,-3.766207 z M 3.7657914,30.680684 C 1.7019617,30.680684 0,32.361784 0,34.44689 v 1.765709 c 0,2.06383 1.6806851,3.766206 3.7657914,3.766206 h 4.7872339 v -9.298121 z m 17.0428856,0 v 9.298121 h 25.42553 c 2.06383,0 3.765792,-1.702376 3.765792,-3.766206 V 34.44689 c 0,-2.085106 -1.701962,-3.766206 -3.765792,-3.766206 z" + android:strokeWidth="0.21276595"/> + \ No newline at end of file diff --git a/briar-android/src/main/res/drawable/navigation_item_background.xml b/briar-android/src/main/res/drawable/navigation_item_background.xml new file mode 100644 index 000000000..4067c8829 --- /dev/null +++ b/briar-android/src/main/res/drawable/navigation_item_background.xml @@ -0,0 +1,5 @@ + + + + + diff --git a/briar-android/src/main/res/layout/navigation_menu.xml b/briar-android/src/main/res/layout/navigation_menu.xml index 888082260..8a2162914 100644 --- a/briar-android/src/main/res/layout/navigation_menu.xml +++ b/briar-android/src/main/res/layout/navigation_menu.xml @@ -2,38 +2,59 @@ - + android:layout_height="wrap_content"> + + + app:layout_constraintBottom_toTopOf="@+id/transports" + app:layout_constraintStart_toStartOf="parent" + app:layout_constraintTop_toBottomOf="@+id/divider1" + app:layout_constraintVertical_weight="1"/> + app:layout_constraintBottom_toBottomOf="parent" + app:layout_constraintEnd_toEndOf="@+id/navigation" + app:layout_constraintStart_toStartOf="parent" + app:layout_constraintTop_toBottomOf="@+id/spacer" + tools:layout_height="75dp"/> - + diff --git a/briar-android/src/main/res/layout/preferences_category.xml b/briar-android/src/main/res/layout/preferences_category.xml index ced92b8ae..c323d8dca 100644 --- a/briar-android/src/main/res/layout/preferences_category.xml +++ b/briar-android/src/main/res/layout/preferences_category.xml @@ -1,14 +1,13 @@ \ No newline at end of file diff --git a/briar-android/src/main/res/layout/text_input_view_large.xml b/briar-android/src/main/res/layout/text_input_view_large.xml index 60155836c..4b01d23c7 100644 --- a/briar-android/src/main/res/layout/text_input_view_large.xml +++ b/briar-android/src/main/res/layout/text_input_view_large.xml @@ -18,6 +18,7 @@ android:layout_marginTop="@dimen/margin_medium" android:elevation="@dimen/cardview_default_elevation" android:minHeight="@dimen/text_input_height" + app:cardBackgroundColor="@color/card_background" app:cardCornerRadius="0dp" app:cardUseCompatPadding="false"> diff --git a/briar-android/src/main/res/layout/transports_list.xml b/briar-android/src/main/res/layout/transports_list.xml index 70ff190c6..17fd52a59 100644 --- a/briar-android/src/main/res/layout/transports_list.xml +++ b/briar-android/src/main/res/layout/transports_list.xml @@ -15,7 +15,6 @@ android:layout_height="wrap_content" android:listSelector="@android:color/transparent" android:numColumns="3" - android:padding="@dimen/margin_medium" tools:listitem="@layout/list_item_transport"/> diff --git a/briar-android/src/main/res/values-night/color.xml b/briar-android/src/main/res/values-night/color.xml index ef06c3838..2dba814d1 100644 --- a/briar-android/src/main/res/values-night/color.xml +++ b/briar-android/src/main/res/values-night/color.xml @@ -1,15 +1,20 @@ - @color/briar_blue_light2 - @color/briar_blue_light2 + @color/briar_blue_dark + @color/briar_green + + @color/briar_accent + @color/divider #ffffff - #ff303030 - @color/cardview_dark_background - #666666 + @color/briar_blue_very_dark + @color/briar_blue_dark + @color/briar_blue + #000000 + @color/briar_link #23cccccc @color/window_background diff --git a/briar-android/src/main/res/values/color.xml b/briar-android/src/main/res/values/color.xml index 5087a5666..ef56fbe47 100644 --- a/briar-android/src/main/res/values/color.xml +++ b/briar-android/src/main/res/values/color.xml @@ -1,20 +1,22 @@ #2D3E50 - #0F1720 + #222E3C + #0F1720 #4F6C8C - #5a7da3 + #5C940D #95D220 - #06B9FF + #2A93C6 #fffafafa @color/cardview_light_background + #DCDCDC #FFFFFF #e0e0e0 #99000000 @color/briar_blue - @color/briar_blue_dark + @color/briar_blue_very_dark @color/briar_blue @@ -27,8 +29,10 @@ #b4ffffff #80ffffff @color/briar_blue_light + @color/window_background @color/briar_link + @color/briar_blue_light #ff0000 #28000000 #ff0000 @@ -37,6 +41,4 @@ #eceff1 #ffffff #c1c1c1 - - #61000000 \ No newline at end of file diff --git a/briar-android/src/main/res/values/styles.xml b/briar-android/src/main/res/values/styles.xml index f679d8081..b67979db0 100644 --- a/briar-android/src/main/res/values/styles.xml +++ b/briar-android/src/main/res/values/styles.xml @@ -45,6 +45,11 @@ @dimen/text_size_medium + + diff --git a/briar-android/src/main/res/values/themes.xml b/briar-android/src/main/res/values/themes.xml index c4dc47a67..806783e3a 100644 --- a/briar-android/src/main/res/values/themes.xml +++ b/briar-android/src/main/res/values/themes.xml @@ -6,7 +6,9 @@ @color/briar_primary_dark @color/briar_accent @color/briar_text_link + @color/window_background @style/ActivityAnimation + @style/BriarDialogTheme.Neutral @style/PreferenceThemeOverlay.v14.Material @@ -28,8 +30,10 @@ @color/briar_primary_dark @color/briar_accent @style/BriarButtonFlat.Positive + @style/BriarButtonFlat.Neutral @style/BriarButtonFlat.Negative @color/briar_text_link + @color/window_background @style/DialogAnimation true @@ -39,6 +43,13 @@ false + + +