Kaladaran/briar
0
0
Fork 0
mirror of https://code.briarproject.org/briar/briar.git synced 2026-02-13 19:29:06 +01:00
Code Issues Projects Releases Wiki Activity

Addressing second round of review issues

Browse Source
This commit is contained in:
Torsten Grote
2016-10-19 09:03:48 -02:00
parent 0523c4e718
commit 8f882dc910
26 changed files with 167 additions and 164 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
briar-api/src/org/briarproject/api/blogs/Blog.java
View File

@@ -7,9 +7,9 @@ import org.briarproject.api.sharing.Shareable;
import org.briarproject.api.sync.Group;
import org.jetbrains.annotations.NotNull;
import javax.annotation.concurrent.ThreadSafe;
import javax.annotation.concurrent.Immutable;
@ThreadSafe
@Immutable
@NotNullByDefault
public class Blog extends BaseGroup implements Shareable {

4
briar-api/src/org/briarproject/api/clients/BaseGroup.java
View File

@@ -5,9 +5,9 @@ import org.briarproject.api.sync.Group;
import org.briarproject.api.sync.GroupId;
import org.jetbrains.annotations.NotNull;
import javax.annotation.concurrent.ThreadSafe;
import javax.annotation.concurrent.Immutable;
@ThreadSafe
@Immutable
@NotNullByDefault
public abstract class BaseGroup {

4
briar-api/src/org/briarproject/api/clients/NamedGroup.java
View File

@@ -4,9 +4,9 @@ import org.briarproject.api.nullsafety.NotNullByDefault;
import org.briarproject.api.sync.Group;
import org.jetbrains.annotations.NotNull;
import javax.annotation.concurrent.ThreadSafe;
import javax.annotation.concurrent.Immutable;
@ThreadSafe
@Immutable
@NotNullByDefault
public abstract class NamedGroup extends BaseGroup {

4
briar-api/src/org/briarproject/api/forum/Forum.java
View File

@@ -5,9 +5,9 @@ import org.briarproject.api.nullsafety.NotNullByDefault;
import org.briarproject.api.sharing.Shareable;
import org.briarproject.api.sync.Group;
import javax.annotation.concurrent.ThreadSafe;
import javax.annotation.concurrent.Immutable;
@ThreadSafe
@Immutable
@NotNullByDefault
public class Forum extends NamedGroup implements Shareable {

7
briar-api/src/org/briarproject/api/forum/ForumManager.java
View File

@@ -1,8 +1,10 @@
package org.briarproject.api.forum;
import org.briarproject.api.clients.MessageTracker;
import org.briarproject.api.crypto.CryptoExecutor;
import org.briarproject.api.db.DbException;
import org.briarproject.api.db.Transaction;
import org.briarproject.api.identity.LocalAuthor;
import org.briarproject.api.sync.ClientId;
import org.briarproject.api.sync.GroupId;
import org.briarproject.api.sync.MessageId;
@@ -22,8 +24,9 @@ public interface ForumManager extends MessageTracker {
void removeForum(Forum f) throws DbException;
/** Creates a local forum post. */
ForumPost createLocalPost(GroupId groupId, String text,
@Nullable MessageId parentId) throws DbException;
@CryptoExecutor
ForumPost createLocalPost(GroupId groupId, String body, long timestamp,
@Nullable MessageId parentId, LocalAuthor author);
/** Stores a local forum post. */
ForumPostHeader addLocalPost(ForumPost p) throws DbException;

4
briar-api/src/org/briarproject/api/privategroup/PrivateGroup.java
View File

@@ -6,9 +6,9 @@ import org.briarproject.api.nullsafety.NotNullByDefault;
import org.briarproject.api.sync.Group;
import org.jetbrains.annotations.NotNull;
import javax.annotation.concurrent.ThreadSafe;
import javax.annotation.concurrent.Immutable;
@ThreadSafe
@Immutable
@NotNullByDefault
public class PrivateGroup extends NamedGroup {

5
briar-api/src/org/briarproject/api/privategroup/PrivateGroupManager.java
View File

@@ -3,6 +3,7 @@ package org.briarproject.api.privategroup;
import org.briarproject.api.clients.MessageTracker;
import org.briarproject.api.db.DbException;
import org.briarproject.api.db.Transaction;
import org.briarproject.api.identity.LocalAuthor;
import org.briarproject.api.sync.ClientId;
import org.briarproject.api.sync.GroupId;
import org.briarproject.api.sync.MessageId;
@@ -21,8 +22,8 @@ public interface PrivateGroupManager extends MessageTracker {
void removePrivateGroup(GroupId g) throws DbException;
/** Creates a local group message. */
GroupMessage createLocalMessage(GroupId groupId, String text,
@Nullable MessageId parentId) throws DbException;
GroupMessage createLocalMessage(GroupId groupId, String body,
long timestamp, @Nullable MessageId parentId, LocalAuthor author);
/** Stores (and sends) a local group message. */
GroupMessageHeader addLocalMessage(GroupMessage p) throws DbException;