Kaladaran/briar
0
0
Fork 0
mirror of https://code.briarproject.org/briar/briar.git synced 2026-02-11 18:29:05 +01:00
Code Issues Projects Releases Wiki Activity

Clarify sharing state docs

Browse Source
This commit is contained in:
Torsten Grote
2023-01-20 11:13:17 -03:00
parent 429bbe1275
commit 9353b78da8
3 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
briar-api/src/main/java/org/briarproject/briar/api/privategroup/invitation/GroupInvitationManager.java
View File

@@ -85,7 +85,8 @@ public interface GroupInvitationManager extends ConversationClient {
* This indicates whether the {@link PrivateGroup} can be shared * This indicates whether the {@link PrivateGroup} can be shared
* with the contact. * with the contact.
* *
* @throws ProtocolStateException if {@link PrivateGroup} was already left. * @throws ProtocolStateException if {@link PrivateGroup}
* was already dissolved.
*/ */
SharingStatus getSharingStatus(Contact c, GroupId g) throws DbException; SharingStatus getSharingStatus(Contact c, GroupId g) throws DbException;
} }

4
briar-api/src/main/java/org/briarproject/briar/api/sharing/SharingManager.java
View File

@@ -116,7 +116,7 @@ public interface SharingManager<S extends Shareable>
* This indicates whether the {@link Shareable} can be shared * This indicates whether the {@link Shareable} can be shared
* with the contact. * with the contact.
* *
* @throws ProtocolStateException if {@link Shareable} was already left. * @throws ProtocolStateException if we already left the {@link Shareable}.
*/ */
SharingStatus getSharingStatus(GroupId g, Contact c) throws DbException; SharingStatus getSharingStatus(GroupId g, Contact c) throws DbException;
@@ -126,7 +126,7 @@ public interface SharingManager<S extends Shareable>
* This indicates whether the {@link Shareable} can be shared * This indicates whether the {@link Shareable} can be shared
* with the contact. * with the contact.
* *
* @throws ProtocolStateException if {@link Shareable} was already left. * @throws ProtocolStateException if we already left the {@link Shareable}.
*/ */
SharingStatus getSharingStatus(Transaction txn, GroupId g, Contact c) SharingStatus getSharingStatus(Transaction txn, GroupId g, Contact c)
throws DbException; throws DbException;

3
briar-core/src/main/java/org/briarproject/briar/privategroup/invitation/GroupInvitationManagerImpl.java
View File

@@ -539,7 +539,8 @@ class GroupInvitationManagerImpl extends ConversationClientImpl
if (state == START) return SharingStatus.SHAREABLE; if (state == START) return SharingStatus.SHAREABLE;
if (state == INVITED) return SharingStatus.INVITE_RECEIVED; if (state == INVITED) return SharingStatus.INVITE_RECEIVED;
if (state == JOINED) return SharingStatus.SHARING; if (state == JOINED) return SharingStatus.SHARING;
// The creator can also be a LEFT state, after re-adding a contact // Apart from the common case that the contact LEFT the group,
// the creator can also be a LEFT state, after re-adding a contact
// and re-creating the session with #recreateSession() // and re-creating the session with #recreateSession()
if (state == CreatorState.LEFT) return SharingStatus.SHARING; if (state == CreatorState.LEFT) return SharingStatus.SHARING;
if (state == DISSOLVED) throw new ProtocolStateException(); if (state == DISSOLVED) throw new ProtocolStateException();