From 9668f62c6aaa0146c68cbdf2171571e7c9793b2f Mon Sep 17 00:00:00 2001 From: Torsten Grote Date: Wed, 30 Jun 2021 16:57:32 -0300 Subject: [PATCH] Remove FIXME in test since we won't fix it this way --- .../agreement/TransportKeyAgreementIntegrationTest.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/bramble-core/src/test/java/org/briarproject/bramble/transport/agreement/TransportKeyAgreementIntegrationTest.java b/bramble-core/src/test/java/org/briarproject/bramble/transport/agreement/TransportKeyAgreementIntegrationTest.java index fef3e82e3..d16b6052c 100644 --- a/bramble-core/src/test/java/org/briarproject/bramble/transport/agreement/TransportKeyAgreementIntegrationTest.java +++ b/bramble-core/src/test/java/org/briarproject/bramble/transport/agreement/TransportKeyAgreementIntegrationTest.java @@ -233,9 +233,12 @@ public class TransportKeyAgreementIntegrationTest // but not via the new duplex transport assertTrue(alice.getKeyManager() .canSendOutgoingStreams(bobId, SIMPLEX_TRANSPORT_ID)); - // FIXME normally Alice should not be able to already send streams -// assertFalse(alice.getKeyManager() -// .canSendOutgoingStreams(bobId, newTransportId)); + // Normally, Alice should not be able to send streams already. + // However, she does already derive keys for the transport. + // The UI checks RemovableDriveManager#isTransportSupportedByContact() + // in practice to prevent sending streams that Bob can't decrypt. + assertTrue(alice.getKeyManager() + .canSendOutgoingStreams(bobId, newTransportId)); // Bob restarts and comes back with the new transport. bob = restartWithNewTransport(bob, bobDir, bobIdentity);