Removed unnecessary calls to default super constructors.

This commit is contained in:
akwizgran
2013-05-15 12:35:00 +01:00
parent 630cfde81e
commit 9e35e96ce4
17 changed files with 3 additions and 23 deletions

View File

@@ -11,7 +11,5 @@ public class TransportConfig extends Hashtable<String, String> {
super(c); super(c);
} }
public TransportConfig() { public TransportConfig() {}
super();
}
} }

View File

@@ -11,7 +11,5 @@ public class TransportProperties extends Hashtable<String, String> {
super(p); super(p);
} }
public TransportProperties() { public TransportProperties() {}
super();
}
} }

View File

@@ -4,9 +4,7 @@ public class DbException extends Exception {
private static final long serialVersionUID = 3706581789209939441L; private static final long serialVersionUID = 3706581789209939441L;
public DbException() { public DbException() {}
super();
}
public DbException(Throwable t) { public DbException(Throwable t) {
super(t); super(t);

View File

@@ -7,7 +7,6 @@ import junit.framework.TestCase;
public abstract class BriarTestCase extends TestCase { public abstract class BriarTestCase extends TestCase {
public BriarTestCase() { public BriarTestCase() {
super();
// Ensure exceptions thrown on worker threads cause tests to fail // Ensure exceptions thrown on worker threads cause tests to fail
UncaughtExceptionHandler fail = new UncaughtExceptionHandler() { UncaughtExceptionHandler fail = new UncaughtExceptionHandler() {
public void uncaughtException(Thread thread, Throwable throwable) { public void uncaughtException(Thread thread, Throwable throwable) {

View File

@@ -77,7 +77,6 @@ public class ProtocolIntegrationTest extends BriarTestCase {
private final TransportProperties transportProperties; private final TransportProperties transportProperties;
public ProtocolIntegrationTest() throws Exception { public ProtocolIntegrationTest() throws Exception {
super();
Injector i = Guice.createInjector(new TestDatabaseModule(), Injector i = Guice.createInjector(new TestDatabaseModule(),
new TestLifecycleModule(), new TestUiModule(), new TestLifecycleModule(), new TestUiModule(),
new ClockModule(), new CryptoModule(), new DatabaseModule(), new ClockModule(), new CryptoModule(), new DatabaseModule(),

View File

@@ -29,7 +29,6 @@ public class CounterModeTest extends BriarTestCase {
private final SecretKeySpec key; private final SecretKeySpec key;
public CounterModeTest() { public CounterModeTest() {
super();
Security.addProvider(new BouncyCastleProvider()); Security.addProvider(new BouncyCastleProvider());
random = new SecureRandom(); random = new SecureRandom();
keyBytes = new byte[KEY_SIZE_BYTES]; keyBytes = new byte[KEY_SIZE_BYTES];

View File

@@ -17,7 +17,6 @@ public class KeyDerivationTest extends BriarTestCase {
private final byte[] secret; private final byte[] secret;
public KeyDerivationTest() { public KeyDerivationTest() {
super();
crypto = new CryptoComponentImpl(); crypto = new CryptoComponentImpl();
secret = new byte[32]; secret = new byte[32];
new Random().nextBytes(secret); new Random().nextBytes(secret);

View File

@@ -79,7 +79,6 @@ public abstract class DatabaseComponentTest extends BriarTestCase {
protected final TemporarySecret temporarySecret; protected final TemporarySecret temporarySecret;
public DatabaseComponentTest() { public DatabaseComponentTest() {
super();
groupId = new GroupId(TestUtils.getRandomId()); groupId = new GroupId(TestUtils.getRandomId());
restrictedGroupId = new GroupId(TestUtils.getRandomId()); restrictedGroupId = new GroupId(TestUtils.getRandomId());
group = new Group(groupId, "Group name", null); group = new Group(groupId, "Group name", null);

View File

@@ -69,7 +69,6 @@ public class H2DatabaseTest extends BriarTestCase {
private final ContactId contactId; private final ContactId contactId;
public H2DatabaseTest() throws Exception { public H2DatabaseTest() throws Exception {
super();
groupId = new GroupId(TestUtils.getRandomId()); groupId = new GroupId(TestUtils.getRandomId());
group = new Group(groupId, "Group name", null); group = new Group(groupId, "Group name", null);
authorId = new AuthorId(TestUtils.getRandomId()); authorId = new AuthorId(TestUtils.getRandomId());

View File

@@ -33,7 +33,6 @@ public class PacketReaderImplTest extends BriarTestCase {
private final WriterFactory writerFactory; private final WriterFactory writerFactory;
public PacketReaderImplTest() throws Exception { public PacketReaderImplTest() throws Exception {
super();
Injector i = Guice.createInjector(new SerialModule()); Injector i = Guice.createInjector(new SerialModule());
serial = i.getInstance(SerialComponent.class); serial = i.getInstance(SerialComponent.class);
readerFactory = i.getInstance(ReaderFactory.class); readerFactory = i.getInstance(ReaderFactory.class);

View File

@@ -33,7 +33,6 @@ public class PacketWriterImplTest extends BriarTestCase {
private final WriterFactory writerFactory; private final WriterFactory writerFactory;
public PacketWriterImplTest() { public PacketWriterImplTest() {
super();
Injector i = Guice.createInjector(new TestDatabaseModule(), Injector i = Guice.createInjector(new TestDatabaseModule(),
new TestLifecycleModule(), new ClockModule(), new TestLifecycleModule(), new ClockModule(),
new CryptoModule(), new DatabaseModule(), new MessagingModule(), new CryptoModule(), new DatabaseModule(), new MessagingModule(),

View File

@@ -57,7 +57,6 @@ public class OutgoingSimplexConnectionTest extends BriarTestCase {
private final byte[] secret; private final byte[] secret;
public OutgoingSimplexConnectionTest() { public OutgoingSimplexConnectionTest() {
super();
context = new Mockery(); context = new Mockery();
db = context.mock(DatabaseComponent.class); db = context.mock(DatabaseComponent.class);
Module testModule = new AbstractModule() { Module testModule = new AbstractModule() {

View File

@@ -63,7 +63,6 @@ public class SimplexMessagingIntegrationTest extends BriarTestCase {
private Injector alice, bob; private Injector alice, bob;
public SimplexMessagingIntegrationTest() throws Exception { public SimplexMessagingIntegrationTest() throws Exception {
super();
transportId = new TransportId(TestUtils.getRandomId()); transportId = new TransportId(TestUtils.getRandomId());
// Create matching secrets for Alice and Bob // Create matching secrets for Alice and Bob
initialSecret = new byte[32]; initialSecret = new byte[32];

View File

@@ -17,7 +17,6 @@ public class ConnectionRegistryImplTest extends BriarTestCase {
private final TransportId transportId, transportId1; private final TransportId transportId, transportId1;
public ConnectionRegistryImplTest() { public ConnectionRegistryImplTest() {
super();
contactId = new ContactId(1); contactId = new ContactId(1);
contactId1 = new ContactId(2); contactId1 = new ContactId(2);
transportId = new TransportId(TestUtils.getRandomId()); transportId = new TransportId(TestUtils.getRandomId());

View File

@@ -34,7 +34,6 @@ public class IncomingEncryptionLayerTest extends BriarTestCase {
private final ErasableKey frameKey; private final ErasableKey frameKey;
public IncomingEncryptionLayerTest() { public IncomingEncryptionLayerTest() {
super();
Injector i = Guice.createInjector(new CryptoModule(), Injector i = Guice.createInjector(new CryptoModule(),
new TestLifecycleModule()); new TestLifecycleModule());
crypto = i.getInstance(CryptoComponent.class); crypto = i.getInstance(CryptoComponent.class);

View File

@@ -34,7 +34,6 @@ public class OutgoingEncryptionLayerTest extends BriarTestCase {
private final byte[] tag; private final byte[] tag;
public OutgoingEncryptionLayerTest() { public OutgoingEncryptionLayerTest() {
super();
Injector i = Guice.createInjector(new CryptoModule(), Injector i = Guice.createInjector(new CryptoModule(),
new TestLifecycleModule()); new TestLifecycleModule());
crypto = i.getInstance(CryptoComponent.class); crypto = i.getInstance(CryptoComponent.class);

View File

@@ -44,7 +44,6 @@ public class TransportIntegrationTest extends BriarTestCase {
private final ErasableKey frameKey; private final ErasableKey frameKey;
public TransportIntegrationTest() { public TransportIntegrationTest() {
super();
Module testModule = new AbstractModule() { Module testModule = new AbstractModule() {
public void configure() { public void configure() {
bind(ConnectionWriterFactory.class).to( bind(ConnectionWriterFactory.class).to(