From afc85cdf52689f060c01c3ae082d67c59ecc1b0b Mon Sep 17 00:00:00 2001 From: akwizgran Date: Wed, 15 Jan 2020 17:40:20 +0000 Subject: [PATCH] Check that server sockets are closed as expected. --- .../briarproject/bramble/plugin/tcp/AndroidLanTcpPlugin.java | 2 +- .../bramble/plugin/bluetooth/BluetoothPlugin.java | 4 ---- .../java/org/briarproject/bramble/plugin/tcp/TcpPlugin.java | 1 - .../java/org/briarproject/bramble/plugin/tor/TorPlugin.java | 1 - 4 files changed, 1 insertion(+), 7 deletions(-) diff --git a/bramble-android/src/main/java/org/briarproject/bramble/plugin/tcp/AndroidLanTcpPlugin.java b/bramble-android/src/main/java/org/briarproject/bramble/plugin/tcp/AndroidLanTcpPlugin.java index 14e18cb51..f39e8914d 100644 --- a/bramble-android/src/main/java/org/briarproject/bramble/plugin/tcp/AndroidLanTcpPlugin.java +++ b/bramble-android/src/main/java/org/briarproject/bramble/plugin/tcp/AndroidLanTcpPlugin.java @@ -147,7 +147,7 @@ class AndroidLanTcpPlugin extends LanTcpPlugin implements EventListener { } else if (addrs.isEmpty()) { LOG.info("Not connected to wifi"); socketFactory = SocketFactory.getDefault(); - // TODO: Check that socket was closed when interface went down + // Server socket was closed when wifi interface went down } else { LOG.info("Connected to wifi"); socketFactory = getSocketFactory(); diff --git a/bramble-core/src/main/java/org/briarproject/bramble/plugin/bluetooth/BluetoothPlugin.java b/bramble-core/src/main/java/org/briarproject/bramble/plugin/bluetooth/BluetoothPlugin.java index 2747ca008..8c6b9b9cd 100644 --- a/bramble-core/src/main/java/org/briarproject/bramble/plugin/bluetooth/BluetoothPlugin.java +++ b/bramble-core/src/main/java/org/briarproject/bramble/plugin/bluetooth/BluetoothPlugin.java @@ -137,9 +137,6 @@ abstract class BluetoothPlugin implements DuplexPlugin, EventListener { void onAdapterDisabled() { LOG.info("Bluetooth disabled"); - // TODO: Is this needed, or will the socket be closed automatically? - SS ss = state.clearServerSocket(); - tryToClose(ss); connectionLimiter.allConnectionsClosed(); callback.pluginStateChanged(getState()); } @@ -241,7 +238,6 @@ abstract class BluetoothPlugin implements DuplexPlugin, EventListener { conn = acceptConnection(ss); } catch (IOException e) { // This is expected when the socket is closed - // TODO: Check that this is logged at shutdown/when BT disabled LOG.info("Server socket closed"); state.clearServerSocket(); return; diff --git a/bramble-core/src/main/java/org/briarproject/bramble/plugin/tcp/TcpPlugin.java b/bramble-core/src/main/java/org/briarproject/bramble/plugin/tcp/TcpPlugin.java index 07b4bf782..279879eb5 100644 --- a/bramble-core/src/main/java/org/briarproject/bramble/plugin/tcp/TcpPlugin.java +++ b/bramble-core/src/main/java/org/briarproject/bramble/plugin/tcp/TcpPlugin.java @@ -177,7 +177,6 @@ abstract class TcpPlugin implements DuplexPlugin { s.setSoTimeout(socketTimeout); } catch (IOException e) { // This is expected when the server socket is closed - // TODO: Check that this is logged at shutdown/when LAN disabled LOG.info("Server socket closed"); state.clearServerSocket(ss); callback.pluginStateChanged(getState()); diff --git a/bramble-core/src/main/java/org/briarproject/bramble/plugin/tor/TorPlugin.java b/bramble-core/src/main/java/org/briarproject/bramble/plugin/tor/TorPlugin.java index d973075f0..0ffa6ead9 100644 --- a/bramble-core/src/main/java/org/briarproject/bramble/plugin/tor/TorPlugin.java +++ b/bramble-core/src/main/java/org/briarproject/bramble/plugin/tor/TorPlugin.java @@ -463,7 +463,6 @@ abstract class TorPlugin implements DuplexPlugin, EventHandler, EventListener { s.setSoTimeout(socketTimeout); } catch (IOException e) { // This is expected when the server socket is closed - // TODO: Check that this is logged at shutdown LOG.info("Server socket closed"); state.clearServerSocket(ss); return;