diff --git a/briar-android/src/main/java/org/briarproject/briar/android/keyagreement/ContactExchangeActivity.java b/briar-android/src/main/java/org/briarproject/briar/android/keyagreement/ContactExchangeActivity.java index 9661eb770..b6acf79c1 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/keyagreement/ContactExchangeActivity.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/keyagreement/ContactExchangeActivity.java @@ -119,13 +119,10 @@ public class ContactExchangeActivity extends KeyAgreementActivity implements return getString(R.string.authenticating_with_device); } - @Nullable @UiThread @Override - public String keyAgreementAborted(boolean remoteAborted) { - showErrorFragment(remoteAborted ? R.string.connection_aborted_remote : - R.string.connection_aborted_local); - return null; + public void keyAgreementAborted(boolean remoteAborted) { + showErrorFragment(R.string.connection_error_explanation); } @UiThread diff --git a/briar-android/src/main/java/org/briarproject/briar/android/keyagreement/ContactExchangeErrorFragment.java b/briar-android/src/main/java/org/briarproject/briar/android/keyagreement/ContactExchangeErrorFragment.java index 43ff91d56..447ec63a3 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/keyagreement/ContactExchangeErrorFragment.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/keyagreement/ContactExchangeErrorFragment.java @@ -49,9 +49,8 @@ public class ContactExchangeErrorFragment extends BaseFragment { public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) { - View v = inflater - .inflate(R.layout.fragment_error_contact_exchange, container, - false); + View v = inflater.inflate(R.layout.fragment_error_contact_exchange, + container, false); // set humanized error message TextView explanation = v.findViewById(R.id.errorMessage); diff --git a/briar-android/src/main/java/org/briarproject/briar/android/keyagreement/KeyAgreementFragment.java b/briar-android/src/main/java/org/briarproject/briar/android/keyagreement/KeyAgreementFragment.java index c599f563d..86831fdab 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/keyagreement/KeyAgreementFragment.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/keyagreement/KeyAgreementFragment.java @@ -300,9 +300,7 @@ public class KeyAgreementFragment extends BaseEventFragment private void keyAgreementAborted(boolean remoteAborted) { runOnUiThreadUnlessDestroyed(() -> { reset(); - qrCodeView.setVisibility(VISIBLE); - statusView.setVisibility(INVISIBLE); - status.setText(listener.keyAgreementAborted(remoteAborted)); + listener.keyAgreementAborted(remoteAborted); }); } @@ -361,10 +359,9 @@ public class KeyAgreementFragment extends BaseEventFragment @Nullable String keyAgreementStarted(); - // Should return a string to be displayed as status. + // Will show an error fragment. @UiThread - @Nullable - String keyAgreementAborted(boolean remoteAborted); + void keyAgreementAborted(boolean remoteAborted); // Should return a string to be displayed as status. @UiThread diff --git a/briar-android/src/main/res/values/strings.xml b/briar-android/src/main/res/values/strings.xml index 4eb8eb2e2..b886746f7 100644 --- a/briar-android/src/main/res/values/strings.xml +++ b/briar-android/src/main/res/values/strings.xml @@ -143,8 +143,6 @@ Camera error Connecting to device\u2026 Authenticating with device\u2026 - The connection was aborted. Please try again! It might help to check that you\'re both connected to the same Wi-Fi network! - The connection was aborted by your contact\'s device. Please try again! It might help to check that you\'re both connected to the same Wi-Fi network! Could not connect to your contact Please check that you\'re both connected to the same Wi-Fi network. If this problem persists, please send feedback to help us improve the app.