From bf01dd4f96cb26e2325d67a191211b62314e5b48 Mon Sep 17 00:00:00 2001 From: akwizgran Date: Mon, 19 Sep 2011 14:58:32 +0100 Subject: [PATCH] Folded ReadWriteLockDatabaseComponentTest into its parent. --- test/build.xml | 2 +- .../briar/db/DatabaseComponentImplTest.java | 16 ++++++++++++---- .../ReadWriteLockDatabaseComponentTest.java | 19 ------------------- 3 files changed, 13 insertions(+), 24 deletions(-) delete mode 100644 test/net/sf/briar/db/ReadWriteLockDatabaseComponentTest.java diff --git a/test/build.xml b/test/build.xml index 19f2412a4..c30d88014 100644 --- a/test/build.xml +++ b/test/build.xml @@ -20,8 +20,8 @@ + - diff --git a/test/net/sf/briar/db/DatabaseComponentImplTest.java b/test/net/sf/briar/db/DatabaseComponentImplTest.java index 8e114c46f..33ce3feeb 100644 --- a/test/net/sf/briar/db/DatabaseComponentImplTest.java +++ b/test/net/sf/briar/db/DatabaseComponentImplTest.java @@ -5,6 +5,7 @@ import static net.sf.briar.api.db.DatabaseComponent.MIN_FREE_SPACE; import java.util.Collections; +import net.sf.briar.api.db.DatabaseComponent; import net.sf.briar.api.db.DbException; import net.sf.briar.db.DatabaseCleaner.Callback; @@ -16,10 +17,7 @@ import org.junit.Test; * Tests that use the DatabaseCleaner.Callback interface of * DatabaseComponentImpl. */ -public abstract class DatabaseComponentImplTest extends DatabaseComponentTest { - - protected abstract DatabaseComponentImpl createDatabaseComponentImpl( - Database database, DatabaseCleaner cleaner); +public class DatabaseComponentImplTest extends DatabaseComponentTest { @Test public void testNotCleanedIfEnoughFreeSpace() throws DbException { @@ -120,4 +118,14 @@ public abstract class DatabaseComponentImplTest extends DatabaseComponentTest { context.assertIsSatisfied(); } + + protected DatabaseComponent createDatabaseComponent( + Database database, DatabaseCleaner cleaner) { + return createDatabaseComponentImpl(database, cleaner); + } + + private DatabaseComponentImpl createDatabaseComponentImpl( + Database database, DatabaseCleaner cleaner) { + return new ReadWriteLockDatabaseComponent(database, cleaner); + } } diff --git a/test/net/sf/briar/db/ReadWriteLockDatabaseComponentTest.java b/test/net/sf/briar/db/ReadWriteLockDatabaseComponentTest.java deleted file mode 100644 index b0d5291f5..000000000 --- a/test/net/sf/briar/db/ReadWriteLockDatabaseComponentTest.java +++ /dev/null @@ -1,19 +0,0 @@ -package net.sf.briar.db; - -import net.sf.briar.api.db.DatabaseComponent; - -public class ReadWriteLockDatabaseComponentTest -extends DatabaseComponentImplTest { - - @Override - protected DatabaseComponent createDatabaseComponent( - Database database, DatabaseCleaner cleaner) { - return createDatabaseComponentImpl(database, cleaner); - } - - @Override - protected DatabaseComponentImpl createDatabaseComponentImpl( - Database database, DatabaseCleaner cleaner) { - return new ReadWriteLockDatabaseComponent(database, cleaner); - } -}