Kaladaran/briar
0
0
Fork 0
mirror of https://code.briarproject.org/briar/briar.git synced 2026-02-19 22:29:53 +01:00
Code Issues Projects Releases Wiki Activity

Removed an unnecessary allocation.

Browse Source
This commit is contained in:
akwizgran
2012-02-10 16:44:18 +00:00
parent 4ca5be7c06
commit c0eb71748c
3 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
components/net/sf/briar/transport/TagEncoder.java
View File

@@ -28,13 +28,10 @@ class TagEncoder {
if(tag.length < TAG_LENGTH) throw new IllegalArgumentException(); if(tag.length < TAG_LENGTH) throw new IllegalArgumentException();
try { try {
tagCipher.init(Cipher.DECRYPT_MODE, tagKey); tagCipher.init(Cipher.DECRYPT_MODE, tagKey);
byte[] plaintext = tagCipher.doFinal(tag, 0, TAG_LENGTH); int decrypted = tagCipher.doFinal(tag, 0, TAG_LENGTH, tag);
if(plaintext.length != TAG_LENGTH) if(decrypted != TAG_LENGTH) throw new IllegalArgumentException();
throw new IllegalArgumentException();
//The plaintext should be blank //The plaintext should be blank
for(int i = 0; i < TAG_LENGTH; i++) { for(int i = 0; i < TAG_LENGTH; i++) if(tag[i] != 0) return false;
if(plaintext[i] != 0) return false;
}
return true; return true;
} catch(GeneralSecurityException e) { } catch(GeneralSecurityException e) {
// Unsuitable cipher or key // Unsuitable cipher or key

2
test/build.xml
View File

@@ -22,7 +22,6 @@
<test name='net.sf.briar.db.BasicH2Test'/> <test name='net.sf.briar.db.BasicH2Test'/>
<test name='net.sf.briar.db.DatabaseCleanerImplTest'/> <test name='net.sf.briar.db.DatabaseCleanerImplTest'/>
<test name='net.sf.briar.db.DatabaseComponentImplTest'/> <test name='net.sf.briar.db.DatabaseComponentImplTest'/>
<test name='net.sf.briar.i18n.FontManagerTest'/>
<test name='net.sf.briar.i18n.I18nTest'/> <test name='net.sf.briar.i18n.I18nTest'/>
<test name='net.sf.briar.invitation.InvitationWorkerTest'/> <test name='net.sf.briar.invitation.InvitationWorkerTest'/>
<test name='net.sf.briar.lifecycle.ShutdownManagerImplTest'/> <test name='net.sf.briar.lifecycle.ShutdownManagerImplTest'/>
@@ -78,6 +77,7 @@
</classpath> </classpath>
<jvmarg value='-Djava.library.path=../lib'/> <jvmarg value='-Djava.library.path=../lib'/>
<test name='net.sf.briar.db.H2DatabaseTest'/> <test name='net.sf.briar.db.H2DatabaseTest'/>
<test name='net.sf.briar.i18n.FontManagerTest'/>
<test name='net.sf.briar.plugins.tor.TorPluginTest'/> <test name='net.sf.briar.plugins.tor.TorPluginTest'/>
</junit> </junit>
</target> </target>

2
test/net/sf/briar/transport/FrameReadWriteTest.java
View File

@@ -89,7 +89,7 @@ public class FrameReadWriteTest extends BriarTestCase {
byte[] recoveredTag = new byte[TAG_LENGTH]; byte[] recoveredTag = new byte[TAG_LENGTH];
assertEquals(TAG_LENGTH, in.read(recoveredTag)); assertEquals(TAG_LENGTH, in.read(recoveredTag));
assertArrayEquals(tag, recoveredTag); assertArrayEquals(tag, recoveredTag);
assertTrue(TagEncoder.decodeTag(tag, tagCipher, tagKey)); assertTrue(TagEncoder.decodeTag(recoveredTag, tagCipher, tagKey));
// Read the frames back // Read the frames back
FrameReader encryptionIn = new IncomingEncryptionLayerImpl(in, FrameReader encryptionIn = new IncomingEncryptionLayerImpl(in,
tagCipher, frameCipher, tagKey, frameKey, false); tagCipher, frameCipher, tagKey, frameKey, false);