From d3f774f339f9ec24f8a0b8839b13cc661febd83e Mon Sep 17 00:00:00 2001 From: akwizgran Date: Wed, 31 Oct 2018 16:18:33 +0000 Subject: [PATCH] Avoid some unnecessary session parsing. --- .../introduction/IntroductionManagerImpl.java | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/briar-core/src/main/java/org/briarproject/briar/introduction/IntroductionManagerImpl.java b/briar-core/src/main/java/org/briarproject/briar/introduction/IntroductionManagerImpl.java index 2879957aa..c05a8f616 100644 --- a/briar-core/src/main/java/org/briarproject/briar/introduction/IntroductionManagerImpl.java +++ b/briar-core/src/main/java/org/briarproject/briar/introduction/IntroductionManagerImpl.java @@ -422,7 +422,7 @@ class IntroductionManagerImpl extends ConversationClientImpl MessageType type = meta.getMessageType(); if (type == REQUEST) { messages.add(parseInvitationRequest(txn, contactGroupId, m, - meta, status, ss.bdfSession, authorInfos)); + meta, status, meta.getSessionId(), authorInfos)); } else if (type == ACCEPT) { messages.add(parseInvitationResponse(txn, contactGroupId, m, meta, status, ss.bdfSession, authorInfos, true)); @@ -439,20 +439,9 @@ class IntroductionManagerImpl extends ConversationClientImpl private IntroductionRequest parseInvitationRequest(Transaction txn, GroupId contactGroupId, MessageId m, MessageMetadata meta, - MessageStatus status, BdfDictionary bdfSession, + MessageStatus status, SessionId sessionId, Map authorInfos) throws DbException, FormatException { - Role role = sessionParser.getRole(bdfSession); - SessionId sessionId; - if (role == INTRODUCER) { - IntroducerSession session = - sessionParser.parseIntroducerSession(bdfSession); - sessionId = session.getSessionId(); - } else if (role == INTRODUCEE) { - IntroduceeSession session = sessionParser - .parseIntroduceeSession(contactGroupId, bdfSession); - sessionId = session.getSessionId(); - } else throw new AssertionError(); Message msg = clientHelper.getMessage(txn, m); BdfList body = clientHelper.toList(msg); RequestMessage rm = messageParser.parseRequestMessage(msg, body);