diff --git a/briar-android/src/main/java/org/briarproject/briar/android/view/AuthorView.java b/briar-android/src/main/java/org/briarproject/briar/android/view/AuthorView.java index cbb3cc8d0..fa766baa4 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/view/AuthorView.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/view/AuthorView.java @@ -5,11 +5,10 @@ import android.content.res.TypedArray; import android.graphics.Typeface; import android.support.annotation.DimenRes; import android.support.annotation.UiThread; +import android.support.constraint.ConstraintLayout; import android.util.AttributeSet; import android.view.LayoutInflater; -import android.view.View; import android.widget.ImageView; -import android.widget.RelativeLayout; import android.widget.TextView; import org.briarproject.bramble.api.identity.Author; @@ -30,7 +29,7 @@ import static org.briarproject.bramble.api.identity.Author.Status.OURSELVES; import static org.briarproject.briar.android.util.UiUtils.resolveAttribute; @UiThread -public class AuthorView extends RelativeLayout { +public class AuthorView extends ConstraintLayout { public static final int NORMAL = 0; public static final int REBLOGGER = 1; @@ -133,32 +132,24 @@ public class AuthorView extends RelativeLayout { date.setVisibility(VISIBLE); setAvatarSize(R.dimen.blogs_avatar_normal_size); setTextSize(authorName, R.dimen.text_size_small); - setCenterVertical(authorName, false); - setCenterVertical(trustIndicator, false); break; case REBLOGGER: avatarIcon.setVisibility(VISIBLE); date.setVisibility(VISIBLE); setAvatarSize(R.dimen.blogs_avatar_normal_size); setTextSize(authorName, R.dimen.text_size_small); - setCenterVertical(authorName, false); - setCenterVertical(trustIndicator, false); break; case COMMENTER: avatarIcon.setVisibility(INVISIBLE); date.setVisibility(VISIBLE); setAvatarSize(R.dimen.blogs_avatar_comment_size); setTextSize(authorName, R.dimen.text_size_tiny); - setCenterVertical(authorName, false); - setCenterVertical(trustIndicator, false); break; case LIST: avatarIcon.setVisibility(INVISIBLE); date.setVisibility(GONE); setAvatarSize(R.dimen.listitem_picture_size_small); setTextSize(authorName, R.dimen.text_size_medium); - setCenterVertical(authorName, true); - setCenterVertical(trustIndicator, true); break; case RSS_FEED: avatarIcon.setVisibility(INVISIBLE); @@ -166,8 +157,6 @@ public class AuthorView extends RelativeLayout { avatar.setImageResource(R.drawable.ic_rss_feed); setAvatarSize(R.dimen.blogs_avatar_normal_size); setTextSize(authorName, R.dimen.text_size_small); - setCenterVertical(authorName, false); - setCenterVertical(trustIndicator, false); break; case RSS_FEED_REBLOGGED: avatarIcon.setVisibility(INVISIBLE); @@ -175,8 +164,6 @@ public class AuthorView extends RelativeLayout { avatar.setImageResource(R.drawable.ic_rss_feed); setAvatarSize(R.dimen.blogs_avatar_comment_size); setTextSize(authorName, R.dimen.text_size_tiny); - setCenterVertical(authorName, false); - setCenterVertical(trustIndicator, false); break; } } @@ -194,10 +181,4 @@ public class AuthorView extends RelativeLayout { v.setTextSize(COMPLEX_UNIT_PX, textSize); } - private void setCenterVertical(View v, boolean center) { - LayoutParams params = (LayoutParams) v.getLayoutParams(); - params.addRule(CENTER_VERTICAL, center ? RelativeLayout.TRUE : 0); - v.setLayoutParams(params); - } - } diff --git a/briar-android/src/main/res/layout/author_view.xml b/briar-android/src/main/res/layout/author_view.xml index 087c7dc0b..c9ca41c6d 100644 --- a/briar-android/src/main/res/layout/author_view.xml +++ b/briar-android/src/main/res/layout/author_view.xml @@ -1,7 +1,12 @@ + app:layout_constraintBottom_toBottomOf="@+id/avatar" + app:layout_constraintEnd_toEndOf="@+id/avatar"/> + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintStart_toEndOf="@+id/avatar" + app:layout_constraintTop_toTopOf="parent" + tools:text="Author View that can have a long name"/> + + - - diff --git a/briar-android/src/main/res/layout/fragment_blog_post.xml b/briar-android/src/main/res/layout/fragment_blog_post.xml index 3fdce0b1c..312d7704c 100644 --- a/briar-android/src/main/res/layout/fragment_blog_post.xml +++ b/briar-android/src/main/res/layout/fragment_blog_post.xml @@ -5,7 +5,7 @@ android:layout_height="match_parent"> diff --git a/briar-android/src/main/res/layout/list_item_blog_post.xml b/briar-android/src/main/res/layout/list_item_blog_post.xml index 9ed0d6557..c772f7979 100644 --- a/briar-android/src/main/res/layout/list_item_blog_post.xml +++ b/briar-android/src/main/res/layout/list_item_blog_post.xml @@ -30,8 +30,11 @@ android:id="@+id/authorView" android:layout_width="0dp" android:layout_height="wrap_content" - android:layout_margin="@dimen/listitem_vertical_margin" - app:layout_constraintEnd_toEndOf="parent" + android:layout_marginBottom="@dimen/listitem_horizontal_margin" + android:layout_marginEnd="@dimen/listitem_vertical_margin" + android:layout_marginStart="@dimen/listitem_vertical_margin" + android:layout_marginTop="@dimen/listitem_vertical_margin" + app:layout_constraintEnd_toStartOf="@+id/commentView" app:layout_constraintLeft_toLeftOf="parent" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toBottomOf="@+id/rebloggerView"/> diff --git a/briar-android/src/main/res/layout/list_item_group_join_notice.xml b/briar-android/src/main/res/layout/list_item_group_join_notice.xml index 08681f3b9..99f9a280d 100644 --- a/briar-android/src/main/res/layout/list_item_group_join_notice.xml +++ b/briar-android/src/main/res/layout/list_item_group_join_notice.xml @@ -21,10 +21,11 @@