diff --git a/bramble-core/src/test/java/org/briarproject/bramble/plugin/file/RemovableDriveIntegrationTestComponent.java b/bramble-core/src/test/java/org/briarproject/bramble/plugin/file/RemovableDriveIntegrationTestComponent.java index 9c5c3153d..385e140da 100644 --- a/bramble-core/src/test/java/org/briarproject/bramble/plugin/file/RemovableDriveIntegrationTestComponent.java +++ b/bramble-core/src/test/java/org/briarproject/bramble/plugin/file/RemovableDriveIntegrationTestComponent.java @@ -12,6 +12,7 @@ import org.briarproject.bramble.event.DefaultEventExecutorModule; import org.briarproject.bramble.system.DefaultWakefulIoExecutorModule; import org.briarproject.bramble.system.TimeTravelModule; import org.briarproject.bramble.test.TestDatabaseConfigModule; +import org.briarproject.bramble.test.TestFeatureFlagModule; import org.briarproject.bramble.test.TestSecureRandomModule; import javax.inject.Singleton; @@ -25,6 +26,7 @@ import dagger.Component; DefaultEventExecutorModule.class, DefaultWakefulIoExecutorModule.class, TestDatabaseConfigModule.class, + TestFeatureFlagModule.class, RemovableDriveIntegrationTestModule.class, RemovableDriveModule.class, TestSecureRandomModule.class, diff --git a/bramble-core/src/test/java/org/briarproject/bramble/plugin/file/RemovableDriveIntegrationTestModule.java b/bramble-core/src/test/java/org/briarproject/bramble/plugin/file/RemovableDriveIntegrationTestModule.java index 7b4699e10..5f3e19842 100644 --- a/bramble-core/src/test/java/org/briarproject/bramble/plugin/file/RemovableDriveIntegrationTestModule.java +++ b/bramble-core/src/test/java/org/briarproject/bramble/plugin/file/RemovableDriveIntegrationTestModule.java @@ -1,6 +1,5 @@ package org.briarproject.bramble.plugin.file; -import org.briarproject.bramble.api.FeatureFlags; import org.briarproject.bramble.api.nullsafety.NotNullByDefault; import org.briarproject.bramble.api.plugin.PluginConfig; import org.briarproject.bramble.api.plugin.TransportId; @@ -52,30 +51,4 @@ class RemovableDriveIntegrationTestModule { }; return pluginConfig; } - - @Provides - FeatureFlags provideFeatureFlags() { - return new FeatureFlags() { - - @Override - public boolean shouldEnableImageAttachments() { - return true; - } - - @Override - public boolean shouldEnableProfilePictures() { - return true; - } - - @Override - public boolean shouldEnableDisappearingMessages() { - return true; - } - - @Override - public boolean shouldEnableConnectViaBluetooth() { - return true; - } - }; - } } diff --git a/bramble-core/src/test/java/org/briarproject/bramble/test/BrambleCoreIntegrationTestModule.java b/bramble-core/src/test/java/org/briarproject/bramble/test/BrambleCoreIntegrationTestModule.java index 22dea21f6..b735dab7d 100644 --- a/bramble-core/src/test/java/org/briarproject/bramble/test/BrambleCoreIntegrationTestModule.java +++ b/bramble-core/src/test/java/org/briarproject/bramble/test/BrambleCoreIntegrationTestModule.java @@ -1,48 +1,22 @@ package org.briarproject.bramble.test; -import org.briarproject.bramble.api.FeatureFlags; import org.briarproject.bramble.battery.DefaultBatteryManagerModule; import org.briarproject.bramble.event.DefaultEventExecutorModule; import org.briarproject.bramble.system.DefaultWakefulIoExecutorModule; import org.briarproject.bramble.system.TimeTravelModule; import dagger.Module; -import dagger.Provides; @Module(includes = { DefaultBatteryManagerModule.class, DefaultEventExecutorModule.class, DefaultWakefulIoExecutorModule.class, TestDatabaseConfigModule.class, + TestFeatureFlagModule.class, TestPluginConfigModule.class, TestSecureRandomModule.class, TimeTravelModule.class }) public class BrambleCoreIntegrationTestModule { - @Provides - FeatureFlags provideFeatureFlags() { - return new FeatureFlags() { - - @Override - public boolean shouldEnableImageAttachments() { - return true; - } - - @Override - public boolean shouldEnableProfilePictures() { - return true; - } - - @Override - public boolean shouldEnableDisappearingMessages() { - return true; - } - - @Override - public boolean shouldEnableConnectViaBluetooth() { - return true; - } - }; - } } diff --git a/bramble-core/src/test/java/org/briarproject/bramble/test/TestFeatureFlagModule.java b/bramble-core/src/test/java/org/briarproject/bramble/test/TestFeatureFlagModule.java new file mode 100644 index 000000000..3bac40b0f --- /dev/null +++ b/bramble-core/src/test/java/org/briarproject/bramble/test/TestFeatureFlagModule.java @@ -0,0 +1,34 @@ +package org.briarproject.bramble.test; + +import org.briarproject.bramble.api.FeatureFlags; + +import dagger.Module; +import dagger.Provides; + +@Module +public class TestFeatureFlagModule { + @Provides + FeatureFlags provideFeatureFlags() { + return new FeatureFlags() { + @Override + public boolean shouldEnableImageAttachments() { + return true; + } + + @Override + public boolean shouldEnableProfilePictures() { + return true; + } + + @Override + public boolean shouldEnableDisappearingMessages() { + return true; + } + + @Override + public boolean shouldEnableConnectViaBluetooth() { + return true; + } + }; + } +} diff --git a/briar-headless/src/test/java/org/briarproject/briar/headless/HeadlessTestModule.kt b/briar-headless/src/test/java/org/briarproject/briar/headless/HeadlessTestModule.kt index f31caf2e3..67171a977 100644 --- a/briar-headless/src/test/java/org/briarproject/briar/headless/HeadlessTestModule.kt +++ b/briar-headless/src/test/java/org/briarproject/briar/headless/HeadlessTestModule.kt @@ -4,7 +4,6 @@ import com.fasterxml.jackson.databind.ObjectMapper import dagger.Module import dagger.Provides import org.briarproject.bramble.account.AccountModule -import org.briarproject.bramble.api.FeatureFlags import org.briarproject.bramble.api.db.DatabaseConfig import org.briarproject.bramble.api.plugin.PluginConfig import org.briarproject.bramble.api.plugin.TransportId @@ -18,6 +17,7 @@ import org.briarproject.bramble.system.ClockModule import org.briarproject.bramble.system.DefaultTaskSchedulerModule import org.briarproject.bramble.system.DefaultWakefulIoExecutorModule import org.briarproject.bramble.system.JavaSystemModule +import org.briarproject.bramble.test.TestFeatureFlagModule import org.briarproject.bramble.test.TestSecureRandomModule import org.briarproject.briar.api.test.TestAvatarCreator import org.briarproject.briar.headless.blogs.HeadlessBlogModule @@ -40,6 +40,7 @@ import javax.inject.Singleton DefaultTaskSchedulerModule::class, DefaultWakefulIoExecutorModule::class, SocksModule::class, + TestFeatureFlagModule::class, TestSecureRandomModule::class, HeadlessBlogModule::class, HeadlessContactModule::class, @@ -78,14 +79,6 @@ internal class HeadlessTestModule(private val appDir: File) { @Singleton internal fun provideObjectMapper() = ObjectMapper() - @Provides - internal fun provideFeatureFlags() = object : FeatureFlags { - override fun shouldEnableImageAttachments() = false - override fun shouldEnableProfilePictures() = false - override fun shouldEnableDisappearingMessages() = false - override fun shouldEnableConnectViaBluetooth() = false - } - @Provides internal fun provideTestAvatarCreator() = TestAvatarCreator { null } }