mirror of
https://code.briarproject.org/briar/briar.git
synced 2026-02-16 04:39:54 +01:00
Singletons that call registration methods must be eager.
This commit is contained in:
@@ -0,0 +1,11 @@
|
|||||||
|
package org.briarproject.bramble;
|
||||||
|
|
||||||
|
import org.briarproject.bramble.battery.AndroidBatteryModule;
|
||||||
|
import org.briarproject.bramble.network.AndroidNetworkModule;
|
||||||
|
|
||||||
|
public interface BrambleAndroidEagerSingletons {
|
||||||
|
|
||||||
|
void inject(AndroidBatteryModule.EagerSingletons init);
|
||||||
|
|
||||||
|
void inject(AndroidNetworkModule.EagerSingletons init);
|
||||||
|
}
|
||||||
@@ -15,4 +15,8 @@ import dagger.Module;
|
|||||||
})
|
})
|
||||||
public class BrambleAndroidModule {
|
public class BrambleAndroidModule {
|
||||||
|
|
||||||
|
public static void initEagerSingletons(BrambleAndroidEagerSingletons c) {
|
||||||
|
c.inject(new AndroidBatteryModule.EagerSingletons());
|
||||||
|
c.inject(new AndroidNetworkModule.EagerSingletons());
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -3,6 +3,7 @@ package org.briarproject.bramble.battery;
|
|||||||
import org.briarproject.bramble.api.battery.BatteryManager;
|
import org.briarproject.bramble.api.battery.BatteryManager;
|
||||||
import org.briarproject.bramble.api.lifecycle.LifecycleManager;
|
import org.briarproject.bramble.api.lifecycle.LifecycleManager;
|
||||||
|
|
||||||
|
import javax.inject.Inject;
|
||||||
import javax.inject.Singleton;
|
import javax.inject.Singleton;
|
||||||
|
|
||||||
import dagger.Module;
|
import dagger.Module;
|
||||||
@@ -11,6 +12,11 @@ import dagger.Provides;
|
|||||||
@Module
|
@Module
|
||||||
public class AndroidBatteryModule {
|
public class AndroidBatteryModule {
|
||||||
|
|
||||||
|
public static class EagerSingletons {
|
||||||
|
@Inject
|
||||||
|
BatteryManager batteryManager;
|
||||||
|
}
|
||||||
|
|
||||||
@Provides
|
@Provides
|
||||||
@Singleton
|
@Singleton
|
||||||
BatteryManager provideBatteryManager(LifecycleManager lifecycleManager,
|
BatteryManager provideBatteryManager(LifecycleManager lifecycleManager,
|
||||||
|
|||||||
@@ -3,6 +3,7 @@ package org.briarproject.bramble.network;
|
|||||||
import org.briarproject.bramble.api.lifecycle.LifecycleManager;
|
import org.briarproject.bramble.api.lifecycle.LifecycleManager;
|
||||||
import org.briarproject.bramble.api.network.NetworkManager;
|
import org.briarproject.bramble.api.network.NetworkManager;
|
||||||
|
|
||||||
|
import javax.inject.Inject;
|
||||||
import javax.inject.Singleton;
|
import javax.inject.Singleton;
|
||||||
|
|
||||||
import dagger.Module;
|
import dagger.Module;
|
||||||
@@ -11,6 +12,11 @@ import dagger.Provides;
|
|||||||
@Module
|
@Module
|
||||||
public class AndroidNetworkModule {
|
public class AndroidNetworkModule {
|
||||||
|
|
||||||
|
public static class EagerSingletons {
|
||||||
|
@Inject
|
||||||
|
NetworkManager networkManager;
|
||||||
|
}
|
||||||
|
|
||||||
@Provides
|
@Provides
|
||||||
@Singleton
|
@Singleton
|
||||||
NetworkManager provideNetworkManager(LifecycleManager lifecycleManager,
|
NetworkManager provideNetworkManager(LifecycleManager lifecycleManager,
|
||||||
|
|||||||
@@ -1,5 +1,6 @@
|
|||||||
package org.briarproject.briar.android;
|
package org.briarproject.briar.android;
|
||||||
|
|
||||||
|
import org.briarproject.bramble.BrambleAndroidModule;
|
||||||
import org.briarproject.bramble.BrambleCoreModule;
|
import org.briarproject.bramble.BrambleCoreModule;
|
||||||
import org.briarproject.briar.BriarCoreModule;
|
import org.briarproject.briar.BriarCoreModule;
|
||||||
|
|
||||||
@@ -12,6 +13,7 @@ public class BriarTestComponentApplication extends BriarApplicationImpl {
|
|||||||
// We need to load the eager singletons directly after making the
|
// We need to load the eager singletons directly after making the
|
||||||
// dependency graphs
|
// dependency graphs
|
||||||
BrambleCoreModule.initEagerSingletons(component);
|
BrambleCoreModule.initEagerSingletons(component);
|
||||||
|
BrambleAndroidModule.initEagerSingletons(component);
|
||||||
BriarCoreModule.initEagerSingletons(component);
|
BriarCoreModule.initEagerSingletons(component);
|
||||||
AndroidEagerSingletons.initEagerSingletons(component);
|
AndroidEagerSingletons.initEagerSingletons(component);
|
||||||
return component;
|
return component;
|
||||||
|
|||||||
@@ -2,6 +2,7 @@ package org.briarproject.briar.android;
|
|||||||
|
|
||||||
import android.arch.lifecycle.ViewModelProvider;
|
import android.arch.lifecycle.ViewModelProvider;
|
||||||
|
|
||||||
|
import org.briarproject.bramble.BrambleAndroidEagerSingletons;
|
||||||
import org.briarproject.bramble.BrambleAndroidModule;
|
import org.briarproject.bramble.BrambleAndroidModule;
|
||||||
import org.briarproject.bramble.BrambleCoreEagerSingletons;
|
import org.briarproject.bramble.BrambleCoreEagerSingletons;
|
||||||
import org.briarproject.bramble.BrambleCoreModule;
|
import org.briarproject.bramble.BrambleCoreModule;
|
||||||
@@ -39,11 +40,11 @@ import org.briarproject.briar.api.blog.BlogManager;
|
|||||||
import org.briarproject.briar.api.blog.BlogPostFactory;
|
import org.briarproject.briar.api.blog.BlogPostFactory;
|
||||||
import org.briarproject.briar.api.blog.BlogSharingManager;
|
import org.briarproject.briar.api.blog.BlogSharingManager;
|
||||||
import org.briarproject.briar.api.client.MessageTracker;
|
import org.briarproject.briar.api.client.MessageTracker;
|
||||||
|
import org.briarproject.briar.api.conversation.ConversationManager;
|
||||||
import org.briarproject.briar.api.feed.FeedManager;
|
import org.briarproject.briar.api.feed.FeedManager;
|
||||||
import org.briarproject.briar.api.forum.ForumManager;
|
import org.briarproject.briar.api.forum.ForumManager;
|
||||||
import org.briarproject.briar.api.forum.ForumSharingManager;
|
import org.briarproject.briar.api.forum.ForumSharingManager;
|
||||||
import org.briarproject.briar.api.introduction.IntroductionManager;
|
import org.briarproject.briar.api.introduction.IntroductionManager;
|
||||||
import org.briarproject.briar.api.conversation.ConversationManager;
|
|
||||||
import org.briarproject.briar.api.messaging.MessagingManager;
|
import org.briarproject.briar.api.messaging.MessagingManager;
|
||||||
import org.briarproject.briar.api.messaging.PrivateMessageFactory;
|
import org.briarproject.briar.api.messaging.PrivateMessageFactory;
|
||||||
import org.briarproject.briar.api.privategroup.GroupMessageFactory;
|
import org.briarproject.briar.api.privategroup.GroupMessageFactory;
|
||||||
@@ -68,7 +69,8 @@ import dagger.Component;
|
|||||||
AppModule.class
|
AppModule.class
|
||||||
})
|
})
|
||||||
public interface AndroidComponent
|
public interface AndroidComponent
|
||||||
extends BrambleCoreEagerSingletons, BriarCoreEagerSingletons {
|
extends BrambleCoreEagerSingletons, BrambleAndroidEagerSingletons,
|
||||||
|
BriarCoreEagerSingletons {
|
||||||
|
|
||||||
// Exposed objects
|
// Exposed objects
|
||||||
@CryptoExecutor
|
@CryptoExecutor
|
||||||
|
|||||||
@@ -66,10 +66,14 @@ public class AppModule {
|
|||||||
@Inject
|
@Inject
|
||||||
AndroidNotificationManager androidNotificationManager;
|
AndroidNotificationManager androidNotificationManager;
|
||||||
@Inject
|
@Inject
|
||||||
|
ScreenFilterMonitor screenFilterMonitor;
|
||||||
|
@Inject
|
||||||
NetworkUsageLogger networkUsageLogger;
|
NetworkUsageLogger networkUsageLogger;
|
||||||
@Inject
|
@Inject
|
||||||
DozeWatchdog dozeWatchdog;
|
DozeWatchdog dozeWatchdog;
|
||||||
@Inject
|
@Inject
|
||||||
|
LockManager lockManager;
|
||||||
|
@Inject
|
||||||
RecentEmoji recentEmoji;
|
RecentEmoji recentEmoji;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -15,6 +15,7 @@ import com.vanniktech.emoji.google.GoogleEmojiProvider;
|
|||||||
import org.acra.ACRA;
|
import org.acra.ACRA;
|
||||||
import org.acra.ReportingInteractionMode;
|
import org.acra.ReportingInteractionMode;
|
||||||
import org.acra.annotation.ReportsCrashes;
|
import org.acra.annotation.ReportsCrashes;
|
||||||
|
import org.briarproject.bramble.BrambleAndroidModule;
|
||||||
import org.briarproject.bramble.BrambleCoreModule;
|
import org.briarproject.bramble.BrambleCoreModule;
|
||||||
import org.briarproject.briar.BriarCoreModule;
|
import org.briarproject.briar.BriarCoreModule;
|
||||||
import org.briarproject.briar.R;
|
import org.briarproject.briar.R;
|
||||||
@@ -124,6 +125,7 @@ public class BriarApplicationImpl extends Application
|
|||||||
// We need to load the eager singletons directly after making the
|
// We need to load the eager singletons directly after making the
|
||||||
// dependency graphs
|
// dependency graphs
|
||||||
BrambleCoreModule.initEagerSingletons(androidComponent);
|
BrambleCoreModule.initEagerSingletons(androidComponent);
|
||||||
|
BrambleAndroidModule.initEagerSingletons(androidComponent);
|
||||||
BriarCoreModule.initEagerSingletons(androidComponent);
|
BriarCoreModule.initEagerSingletons(androidComponent);
|
||||||
AndroidEagerSingletons.initEagerSingletons(androidComponent);
|
AndroidEagerSingletons.initEagerSingletons(androidComponent);
|
||||||
return androidComponent;
|
return androidComponent;
|
||||||
|
|||||||
@@ -7,6 +7,7 @@ import android.preference.PreferenceManager;
|
|||||||
import com.vanniktech.emoji.EmojiManager;
|
import com.vanniktech.emoji.EmojiManager;
|
||||||
import com.vanniktech.emoji.google.GoogleEmojiProvider;
|
import com.vanniktech.emoji.google.GoogleEmojiProvider;
|
||||||
|
|
||||||
|
import org.briarproject.bramble.BrambleAndroidModule;
|
||||||
import org.briarproject.bramble.BrambleCoreModule;
|
import org.briarproject.bramble.BrambleCoreModule;
|
||||||
import org.briarproject.briar.BriarCoreModule;
|
import org.briarproject.briar.BriarCoreModule;
|
||||||
|
|
||||||
@@ -42,6 +43,7 @@ public class TestBriarApplication extends Application
|
|||||||
// We need to load the eager singletons directly after making the
|
// We need to load the eager singletons directly after making the
|
||||||
// dependency graphs
|
// dependency graphs
|
||||||
BrambleCoreModule.initEagerSingletons(applicationComponent);
|
BrambleCoreModule.initEagerSingletons(applicationComponent);
|
||||||
|
BrambleAndroidModule.initEagerSingletons(applicationComponent);
|
||||||
BriarCoreModule.initEagerSingletons(applicationComponent);
|
BriarCoreModule.initEagerSingletons(applicationComponent);
|
||||||
AndroidEagerSingletons.initEagerSingletons(applicationComponent);
|
AndroidEagerSingletons.initEagerSingletons(applicationComponent);
|
||||||
EmojiManager.install(new GoogleEmojiProvider());
|
EmojiManager.install(new GoogleEmojiProvider());
|
||||||
|
|||||||
Reference in New Issue
Block a user