Moved stream crypto to crypto component.

briar-tests/src/org/briarproject/ProtocolIntegrationTest.java

@@ -7,6 +7,7 @@ import static org.junit.Assert.assertArrayEquals;
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
 import java.io.InputStream;
+import java.io.OutputStream;
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
@@ -36,9 +37,7 @@ import org.briarproject.api.messaging.SubscriptionUpdate;
 import org.briarproject.api.messaging.TransportUpdate;
 import org.briarproject.api.messaging.UnverifiedMessage;
 import org.briarproject.api.transport.StreamContext;
-import org.briarproject.api.transport.StreamReader;
 import org.briarproject.api.transport.StreamReaderFactory;
-import org.briarproject.api.transport.StreamWriter;
 import org.briarproject.api.transport.StreamWriterFactory;
 import org.briarproject.crypto.CryptoModule;
 import org.briarproject.db.DatabaseModule;
@@ -119,10 +118,10 @@ public class ProtocolIntegrationTest extends BriarTestCase {
 		ByteArrayOutputStream out = new ByteArrayOutputStream();
 		StreamContext ctx = new StreamContext(contactId, transportId,
 				secret.clone(), 0, true);
-		StreamWriter streamWriter = streamWriterFactory.createStreamWriter(out,
+		OutputStream streamWriter = streamWriterFactory.createStreamWriter(out,
 				MAX_FRAME_LENGTH, ctx);
 		PacketWriter packetWriter = packetWriterFactory.createPacketWriter(
-				streamWriter.getOutputStream());
+				streamWriter);
 
 		packetWriter.writeAck(new Ack(messageIds));
 
@@ -140,7 +139,7 @@ public class ProtocolIntegrationTest extends BriarTestCase {
 				transportProperties, 1);
 		packetWriter.writeTransportUpdate(tu);
 
-		streamWriter.getOutputStream().flush();
+		streamWriter.flush();
 		return out.toByteArray();
 	}
 
@@ -151,10 +150,10 @@ public class ProtocolIntegrationTest extends BriarTestCase {
 		// FIXME: Check that the expected tag was received
 		StreamContext ctx = new StreamContext(contactId, transportId,
 				secret.clone(), 0, false);
-		StreamReader streamReader = streamReaderFactory.createStreamReader(in,
+		InputStream streamReader = streamReaderFactory.createStreamReader(in,
 				MAX_FRAME_LENGTH, ctx);
 		PacketReader packetReader = packetReaderFactory.createPacketReader(
-				streamReader.getInputStream());
+				streamReader);
 
 		// Read the ack
 		assertTrue(packetReader.hasAck());

briar-tests/src/org/briarproject/crypto/StreamDecrypterImplTest.java

@@ -1,4 +1,4 @@
-package org.briarproject.transport;
+package org.briarproject.crypto;
 
 import static org.briarproject.api.transport.TransportConstants.AAD_LENGTH;
 import static org.briarproject.api.transport.TransportConstants.HEADER_LENGTH;
@@ -14,13 +14,12 @@ import org.briarproject.api.FormatException;
 import org.briarproject.api.crypto.AuthenticatedCipher;
 import org.briarproject.api.crypto.CryptoComponent;
 import org.briarproject.api.crypto.SecretKey;
-import org.briarproject.crypto.CryptoModule;
 import org.junit.Test;
 
 import com.google.inject.Guice;
 import com.google.inject.Injector;
 
-public class IncomingEncryptionLayerTest extends BriarTestCase {
+public class StreamDecrypterImplTest extends BriarTestCase {
 
 	// FIXME: This is an integration test, not a unit test
 
@@ -32,7 +31,7 @@ public class IncomingEncryptionLayerTest extends BriarTestCase {
 	private final AuthenticatedCipher frameCipher;
 	private final SecretKey frameKey;
 
-	public IncomingEncryptionLayerTest() {
+	public StreamDecrypterImplTest() {
 		Injector i = Guice.createInjector(new CryptoModule(),
 				new TestLifecycleModule(), new TestSystemModule());
 		crypto = i.getInstance(CryptoComponent.class);
@@ -51,11 +50,11 @@ public class IncomingEncryptionLayerTest extends BriarTestCase {
 		System.arraycopy(frame1, 0, valid, FRAME_LENGTH, FRAME_LENGTH);
 		// Read the frames
 		ByteArrayInputStream in = new ByteArrayInputStream(valid);
-		IncomingEncryptionLayer i = new IncomingEncryptionLayer(in, frameCipher,
+		StreamDecrypterImpl i = new StreamDecrypterImpl(in, frameCipher,
 				frameKey, FRAME_LENGTH);
-		byte[] buf = new byte[FRAME_LENGTH - MAC_LENGTH];
-		assertEquals(123, i.readFrame(buf));
-		assertEquals(123, i.readFrame(buf));
+		byte[] payload = new byte[MAX_PAYLOAD_LENGTH];
+		assertEquals(123, i.readFrame(payload));
+		assertEquals(123, i.readFrame(payload));
 	}
 
 	@Test
@@ -67,10 +66,10 @@ public class IncomingEncryptionLayerTest extends BriarTestCase {
 		System.arraycopy(frame, 0, truncated, 0, FRAME_LENGTH - 1);
 		// Try to read the frame, which should fail due to truncation
 		ByteArrayInputStream in = new ByteArrayInputStream(truncated);
-		IncomingEncryptionLayer i = new IncomingEncryptionLayer(in, frameCipher,
+		StreamDecrypterImpl i = new StreamDecrypterImpl(in, frameCipher,
 				frameKey, FRAME_LENGTH);
 		try {
-			i.readFrame(new byte[FRAME_LENGTH - MAC_LENGTH]);
+			i.readFrame(new byte[MAX_PAYLOAD_LENGTH]);
 			fail();
 		} catch(FormatException expected) {}
 	}
@@ -83,10 +82,10 @@ public class IncomingEncryptionLayerTest extends BriarTestCase {
 		frame[(int) (Math.random() * FRAME_LENGTH)] ^= 1;
 		// Try to read the frame, which should fail due to modification
 		ByteArrayInputStream in = new ByteArrayInputStream(frame);
-		IncomingEncryptionLayer i = new IncomingEncryptionLayer(in, frameCipher,
+		StreamDecrypterImpl i = new StreamDecrypterImpl(in, frameCipher,
 				frameKey, FRAME_LENGTH);
 		try {
-			i.readFrame(new byte[FRAME_LENGTH - MAC_LENGTH]);
+			i.readFrame(new byte[MAX_PAYLOAD_LENGTH]);
 			fail();
 		} catch(FormatException expected) {}
 	}
@@ -97,10 +96,10 @@ public class IncomingEncryptionLayerTest extends BriarTestCase {
 		byte[] frame = generateFrame(0, FRAME_LENGTH - 1, 123, false, false);
 		// Try to read the frame, which should fail due to invalid length
 		ByteArrayInputStream in = new ByteArrayInputStream(frame);
-		IncomingEncryptionLayer i = new IncomingEncryptionLayer(in, frameCipher,
+		StreamDecrypterImpl i = new StreamDecrypterImpl(in, frameCipher,
 				frameKey, FRAME_LENGTH);
 		try {
-			i.readFrame(new byte[FRAME_LENGTH - MAC_LENGTH]);
+			i.readFrame(new byte[MAX_PAYLOAD_LENGTH]);
 			fail();
 		} catch(FormatException expected) {}
 	}
@@ -111,9 +110,9 @@ public class IncomingEncryptionLayerTest extends BriarTestCase {
 		byte[] frame = generateFrame(0, FRAME_LENGTH - 1, 123, true, false);
 		// Read the frame
 		ByteArrayInputStream in = new ByteArrayInputStream(frame);
-		IncomingEncryptionLayer i = new IncomingEncryptionLayer(in, frameCipher,
+		StreamDecrypterImpl i = new StreamDecrypterImpl(in, frameCipher,
 				frameKey, FRAME_LENGTH);
-		int length = i.readFrame(new byte[FRAME_LENGTH - MAC_LENGTH]);
+		int length = i.readFrame(new byte[MAX_PAYLOAD_LENGTH]);
 		assertEquals(123, length);
 	}
 
@@ -124,10 +123,10 @@ public class IncomingEncryptionLayerTest extends BriarTestCase {
 				false, false);
 		// Try to read the frame, which should fail due to invalid length
 		ByteArrayInputStream in = new ByteArrayInputStream(frame);
-		IncomingEncryptionLayer i = new IncomingEncryptionLayer(in, frameCipher,
+		StreamDecrypterImpl i = new StreamDecrypterImpl(in, frameCipher,
 				frameKey, FRAME_LENGTH);
 		try {
-			i.readFrame(new byte[FRAME_LENGTH - MAC_LENGTH]);
+			i.readFrame(new byte[MAX_PAYLOAD_LENGTH]);
 			fail();
 		} catch(FormatException expected) {}
 	}
@@ -138,10 +137,10 @@ public class IncomingEncryptionLayerTest extends BriarTestCase {
 		byte[] frame = generateFrame(0, FRAME_LENGTH, 123, false, true);
 		// Try to read the frame, which should fail due to bad padding
 		ByteArrayInputStream in = new ByteArrayInputStream(frame);
-		IncomingEncryptionLayer i = new IncomingEncryptionLayer(in, frameCipher,
+		StreamDecrypterImpl i = new StreamDecrypterImpl(in, frameCipher,
 				frameKey, FRAME_LENGTH);
 		try {
-			i.readFrame(new byte[FRAME_LENGTH - MAC_LENGTH]);
+			i.readFrame(new byte[MAX_PAYLOAD_LENGTH]);
 			fail();
 		} catch(FormatException expected) {}
 	}
@@ -158,12 +157,12 @@ public class IncomingEncryptionLayerTest extends BriarTestCase {
 		System.arraycopy(frame1, 0, extraFrame, FRAME_LENGTH, FRAME_LENGTH);
 		// Read the final frame, which should first read the tag
 		ByteArrayInputStream in = new ByteArrayInputStream(extraFrame);
-		IncomingEncryptionLayer i = new IncomingEncryptionLayer(in, frameCipher,
+		StreamDecrypterImpl i = new StreamDecrypterImpl(in, frameCipher,
 				frameKey, FRAME_LENGTH);
-		byte[] buf = new byte[FRAME_LENGTH - MAC_LENGTH];
-		assertEquals(MAX_PAYLOAD_LENGTH, i.readFrame(buf));
+		byte[] payload = new byte[MAX_PAYLOAD_LENGTH];
+		assertEquals(MAX_PAYLOAD_LENGTH, i.readFrame(payload));
 		// The frame after the final frame should not be read
-		assertEquals(-1, i.readFrame(buf));
+		assertEquals(-1, i.readFrame(payload));
 	}
 
 	private byte[] generateFrame(long frameNumber, int frameLength,

briar-tests/src/org/briarproject/crypto/StreamEncrypterImplTest.java

@@ -1,4 +1,4 @@
-package org.briarproject.transport;
+package org.briarproject.crypto;
 
 import static org.briarproject.api.transport.TransportConstants.AAD_LENGTH;
 import static org.briarproject.api.transport.TransportConstants.HEADER_LENGTH;
@@ -15,13 +15,12 @@ import org.briarproject.TestSystemModule;
 import org.briarproject.api.crypto.AuthenticatedCipher;
 import org.briarproject.api.crypto.CryptoComponent;
 import org.briarproject.api.crypto.SecretKey;
-import org.briarproject.crypto.CryptoModule;
 import org.junit.Test;
 
 import com.google.inject.Guice;
 import com.google.inject.Injector;
 
-public class OutgoingEncryptionLayerTest extends BriarTestCase {
+public class StreamEncrypterImplTest extends BriarTestCase {
 
 	// FIXME: This is an integration test, not a unit test
 
@@ -30,7 +29,7 @@ public class OutgoingEncryptionLayerTest extends BriarTestCase {
 	private final CryptoComponent crypto;
 	private final AuthenticatedCipher frameCipher;
 
-	public OutgoingEncryptionLayerTest() {
+	public StreamEncrypterImplTest() {
 		Injector i = Guice.createInjector(new CryptoModule(),
 				new TestLifecycleModule(), new TestSystemModule());
 		crypto = i.getInstance(CryptoComponent.class);
@@ -52,9 +51,9 @@ public class OutgoingEncryptionLayerTest extends BriarTestCase {
 		frameCipher.doFinal(plaintext, 0, plaintext.length, ciphertext, 0);
 		// Check that the actual ciphertext matches what's expected
 		ByteArrayOutputStream out = new ByteArrayOutputStream();
-		OutgoingEncryptionLayer o = new OutgoingEncryptionLayer(out,
+		StreamEncrypterImpl o = new StreamEncrypterImpl(out,
 				frameCipher, frameKey, FRAME_LENGTH, null);
-		o.writeFrame(new byte[FRAME_LENGTH - MAC_LENGTH], payloadLength, false);
+		o.writeFrame(new byte[payloadLength], payloadLength, false);
 		byte[] actual = out.toByteArray();
 		assertEquals(FRAME_LENGTH, actual.length);
 		for(int i = 0; i < FRAME_LENGTH; i++)
@@ -78,9 +77,9 @@ public class OutgoingEncryptionLayerTest extends BriarTestCase {
 		frameCipher.doFinal(plaintext, 0, plaintext.length, ciphertext, 0);
 		// Check that the actual tag and ciphertext match what's expected
 		ByteArrayOutputStream out = new ByteArrayOutputStream();
-		OutgoingEncryptionLayer o = new OutgoingEncryptionLayer(out,
+		StreamEncrypterImpl o = new StreamEncrypterImpl(out,
 				frameCipher, frameKey, FRAME_LENGTH, tag);
-		o.writeFrame(new byte[FRAME_LENGTH - MAC_LENGTH], payloadLength, false);
+		o.writeFrame(new byte[payloadLength], payloadLength, false);
 		byte[] actual = out.toByteArray();
 		assertEquals(TAG_LENGTH + FRAME_LENGTH, actual.length);
 		for(int i = 0; i < TAG_LENGTH; i++) assertEquals(tag[i], actual[i]);
@@ -94,7 +93,7 @@ public class OutgoingEncryptionLayerTest extends BriarTestCase {
 		new Random().nextBytes(tag);
 		ByteArrayOutputStream out = new ByteArrayOutputStream();
 		// Initiator's constructor
-		OutgoingEncryptionLayer o = new OutgoingEncryptionLayer(out,
+		StreamEncrypterImpl o = new StreamEncrypterImpl(out,
 				frameCipher, crypto.generateSecretKey(), FRAME_LENGTH, tag);
 		// Write an empty final frame without having written any other frames
 		o.writeFrame(new byte[FRAME_LENGTH - MAC_LENGTH], 0, true);

briar-tests/src/org/briarproject/messaging/SimplexMessagingIntegrationTest.java

@@ -9,6 +9,8 @@ import static org.briarproject.api.transport.TransportConstants.TAG_LENGTH;
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
 import java.io.File;
+import java.io.InputStream;
+import java.io.OutputStream;
 import java.util.Random;
 
 import org.briarproject.BriarTestCase;
@@ -39,9 +41,7 @@ import org.briarproject.api.messaging.PacketWriter;
 import org.briarproject.api.messaging.PacketWriterFactory;
 import org.briarproject.api.transport.Endpoint;
 import org.briarproject.api.transport.StreamContext;
-import org.briarproject.api.transport.StreamReader;
 import org.briarproject.api.transport.StreamReaderFactory;
-import org.briarproject.api.transport.StreamWriter;
 import org.briarproject.api.transport.StreamWriterFactory;
 import org.briarproject.api.transport.TagRecogniser;
 import org.briarproject.crypto.CryptoModule;
@@ -136,26 +136,27 @@ public class SimplexMessagingIntegrationTest extends BriarTestCase {
 		Message message = messageFactory.createAnonymousMessage(null, group,
 				contentType, timestamp, body);
 		db.addLocalMessage(message);
+		// Get a stream context
+		StreamContext ctx = keyManager.getStreamContext(contactId, transportId);
+		assertNotNull(ctx);
 		// Create a stream writer
 		ByteArrayOutputStream out = new ByteArrayOutputStream();
 		StreamWriterFactory streamWriterFactory =
 				alice.getInstance(StreamWriterFactory.class);
-		StreamContext ctx = keyManager.getStreamContext(contactId, transportId);
-		assertNotNull(ctx);
-		StreamWriter streamWriter = streamWriterFactory.createStreamWriter(out,
+		OutputStream streamWriter = streamWriterFactory.createStreamWriter(out,
 				MAX_FRAME_LENGTH, ctx);
 		// Create an outgoing messaging session
 		EventBus eventBus = alice.getInstance(EventBus.class);
 		PacketWriterFactory packetWriterFactory =
 				alice.getInstance(PacketWriterFactory.class);
 		PacketWriter packetWriter = packetWriterFactory.createPacketWriter(
-				streamWriter.getOutputStream());
+				streamWriter);
 		MessagingSession session = new SimplexOutgoingSession(db,
 				new ImmediateExecutor(), eventBus, contactId, transportId,
 				MAX_LATENCY, packetWriter);
 		// Write whatever needs to be written
 		session.run();
-		streamWriter.getOutputStream().close();
+		streamWriter.close();
 		// Clean up
 		keyManager.stop();
 		db.close();
@@ -204,7 +205,7 @@ public class SimplexMessagingIntegrationTest extends BriarTestCase {
 		// Create a stream reader
 		StreamReaderFactory streamReaderFactory =
 				bob.getInstance(StreamReaderFactory.class);
-		StreamReader streamReader = streamReaderFactory.createStreamReader(in,
+		InputStream streamReader = streamReaderFactory.createStreamReader(in,
 				MAX_FRAME_LENGTH, ctx);
 		// Create an incoming messaging session
 		EventBus eventBus = bob.getInstance(EventBus.class);
@@ -213,7 +214,7 @@ public class SimplexMessagingIntegrationTest extends BriarTestCase {
 		PacketReaderFactory packetReaderFactory =
 				bob.getInstance(PacketReaderFactory.class);
 		PacketReader packetReader = packetReaderFactory.createPacketReader(
-				streamReader.getInputStream());
+				streamReader);
 		MessagingSession session = new IncomingSession(db,
 				new ImmediateExecutor(), new ImmediateExecutor(), eventBus,
 				messageVerifier, contactId, transportId, packetReader);
@@ -221,7 +222,7 @@ public class SimplexMessagingIntegrationTest extends BriarTestCase {
 		assertFalse(listener.messageAdded);
 		// Read whatever needs to be read
 		session.run();
-		streamReader.getInputStream().close();
+		streamReader.close();
 		// The private message from Alice should have been added
 		assertTrue(listener.messageAdded);
 		// Clean up

briar-tests/src/org/briarproject/transport/StreamReaderImplTest.java

@@ -4,6 +4,7 @@ import static org.briarproject.api.transport.TransportConstants.HEADER_LENGTH;
 import static org.briarproject.api.transport.TransportConstants.MAC_LENGTH;
 
 import org.briarproject.BriarTestCase;
+import org.briarproject.api.crypto.StreamDecrypter;
 import org.jmock.Expectations;
 import org.jmock.Mockery;
 import org.junit.Test;
@@ -17,18 +18,18 @@ public class StreamReaderImplTest extends BriarTestCase {
 	@Test
 	public void testEmptyFramesAreSkipped() throws Exception {
 		Mockery context = new Mockery();
-		final FrameReader reader = context.mock(FrameReader.class);
+		final StreamDecrypter decrypter = context.mock(StreamDecrypter.class);
 		context.checking(new Expectations() {{
-			oneOf(reader).readFrame(with(any(byte[].class)));
+			oneOf(decrypter).readFrame(with(any(byte[].class)));
 			will(returnValue(0)); // Empty frame
-			oneOf(reader).readFrame(with(any(byte[].class)));
+			oneOf(decrypter).readFrame(with(any(byte[].class)));
 			will(returnValue(2)); // Non-empty frame with two payload bytes
-			oneOf(reader).readFrame(with(any(byte[].class)));
+			oneOf(decrypter).readFrame(with(any(byte[].class)));
 			will(returnValue(0)); // Empty frame
-			oneOf(reader).readFrame(with(any(byte[].class)));
+			oneOf(decrypter).readFrame(with(any(byte[].class)));
 			will(returnValue(-1)); // No more frames
 		}});
-		StreamReaderImpl r = new StreamReaderImpl(reader, FRAME_LENGTH);
+		StreamReaderImpl r = new StreamReaderImpl(decrypter, FRAME_LENGTH);
 		assertEquals(0, r.read()); // Skip the first empty frame, read a byte
 		assertEquals(0, r.read()); // Read another byte
 		assertEquals(-1, r.read()); // Skip the second empty frame, reach EOF
@@ -40,18 +41,18 @@ public class StreamReaderImplTest extends BriarTestCase {
 	@Test
 	public void testEmptyFramesAreSkippedWithBuffer() throws Exception {
 		Mockery context = new Mockery();
-		final FrameReader reader = context.mock(FrameReader.class);
+		final StreamDecrypter decrypter = context.mock(StreamDecrypter.class);
 		context.checking(new Expectations() {{
-			oneOf(reader).readFrame(with(any(byte[].class)));
+			oneOf(decrypter).readFrame(with(any(byte[].class)));
 			will(returnValue(0)); // Empty frame
-			oneOf(reader).readFrame(with(any(byte[].class)));
+			oneOf(decrypter).readFrame(with(any(byte[].class)));
 			will(returnValue(2)); // Non-empty frame with two payload bytes
-			oneOf(reader).readFrame(with(any(byte[].class)));
+			oneOf(decrypter).readFrame(with(any(byte[].class)));
 			will(returnValue(0)); // Empty frame
-			oneOf(reader).readFrame(with(any(byte[].class)));
+			oneOf(decrypter).readFrame(with(any(byte[].class)));
 			will(returnValue(-1)); // No more frames
 		}});
-		StreamReaderImpl r = new StreamReaderImpl(reader, FRAME_LENGTH);
+		StreamReaderImpl r = new StreamReaderImpl(decrypter, FRAME_LENGTH);
 		byte[] buf = new byte[MAX_PAYLOAD_LENGTH];
 		// Skip the first empty frame, read the two payload bytes
 		assertEquals(2, r.read(buf));
@@ -66,14 +67,14 @@ public class StreamReaderImplTest extends BriarTestCase {
 	@Test
 	public void testMultipleReadsPerFrame() throws Exception {
 		Mockery context = new Mockery();
-		final FrameReader reader = context.mock(FrameReader.class);
+		final StreamDecrypter decrypter = context.mock(StreamDecrypter.class);
 		context.checking(new Expectations() {{
-			oneOf(reader).readFrame(with(any(byte[].class)));
+			oneOf(decrypter).readFrame(with(any(byte[].class)));
 			will(returnValue(MAX_PAYLOAD_LENGTH)); // Nice long frame
-			oneOf(reader).readFrame(with(any(byte[].class)));
+			oneOf(decrypter).readFrame(with(any(byte[].class)));
 			will(returnValue(-1)); // No more frames
 		}});
-		StreamReaderImpl r = new StreamReaderImpl(reader, FRAME_LENGTH);
+		StreamReaderImpl r = new StreamReaderImpl(decrypter, FRAME_LENGTH);
 		byte[] buf = new byte[MAX_PAYLOAD_LENGTH / 2];
 		// Read the first half of the payload
 		assertEquals(MAX_PAYLOAD_LENGTH / 2, r.read(buf));
@@ -88,14 +89,14 @@ public class StreamReaderImplTest extends BriarTestCase {
 	@Test
 	public void testMultipleReadsPerFrameWithOffsets() throws Exception {
 		Mockery context = new Mockery();
-		final FrameReader reader = context.mock(FrameReader.class);
+		final StreamDecrypter decrypter = context.mock(StreamDecrypter.class);
 		context.checking(new Expectations() {{
-			oneOf(reader).readFrame(with(any(byte[].class)));
+			oneOf(decrypter).readFrame(with(any(byte[].class)));
 			will(returnValue(MAX_PAYLOAD_LENGTH)); // Nice long frame
-			oneOf(reader).readFrame(with(any(byte[].class)));
+			oneOf(decrypter).readFrame(with(any(byte[].class)));
 			will(returnValue(-1)); // No more frames
 		}});
-		StreamReaderImpl r = new StreamReaderImpl(reader, FRAME_LENGTH);
+		StreamReaderImpl r = new StreamReaderImpl(decrypter, FRAME_LENGTH);
 		byte[] buf = new byte[MAX_PAYLOAD_LENGTH];
 		// Read the first half of the payload
 		assertEquals(MAX_PAYLOAD_LENGTH / 2, r.read(buf, MAX_PAYLOAD_LENGTH / 2,

briar-tests/src/org/briarproject/transport/StreamWriterImplTest.java

@@ -4,6 +4,7 @@ import static org.briarproject.api.transport.TransportConstants.HEADER_LENGTH;
 import static org.briarproject.api.transport.TransportConstants.MAC_LENGTH;
 
 import org.briarproject.BriarTestCase;
+import org.briarproject.api.crypto.StreamEncrypter;
 import org.jmock.Expectations;
 import org.jmock.Mockery;
 import org.junit.Test;
@@ -17,15 +18,15 @@ public class StreamWriterImplTest extends BriarTestCase {
 	@Test
 	public void testCloseWithoutWritingWritesFinalFrame() throws Exception {
 		Mockery context = new Mockery();
-		final FrameWriter writer = context.mock(FrameWriter.class);
+		final StreamEncrypter encrypter = context.mock(StreamEncrypter.class);
 		context.checking(new Expectations() {{
 			// Write an empty final frame
-			oneOf(writer).writeFrame(with(any(byte[].class)), with(0),
+			oneOf(encrypter).writeFrame(with(any(byte[].class)), with(0),
 					with(true));
 			// Flush the stream
-			oneOf(writer).flush();
+			oneOf(encrypter).flush();
 		}});
-		StreamWriterImpl w = new StreamWriterImpl(writer, FRAME_LENGTH);
+		StreamWriterImpl w = new StreamWriterImpl(encrypter, FRAME_LENGTH);
 		w.close();
 		context.assertIsSatisfied();
 	}
@@ -34,14 +35,14 @@ public class StreamWriterImplTest extends BriarTestCase {
 	public void testFlushWithoutBufferedDataWritesFrameAndFlushes()
 			throws Exception {
 		Mockery context = new Mockery();
-		final FrameWriter writer = context.mock(FrameWriter.class);
-		StreamWriterImpl w = new StreamWriterImpl(writer, FRAME_LENGTH);
+		final StreamEncrypter encrypter = context.mock(StreamEncrypter.class);
+		StreamWriterImpl w = new StreamWriterImpl(encrypter, FRAME_LENGTH);
 		context.checking(new Expectations() {{
 			// Write a non-final frame with an empty payload
-			oneOf(writer).writeFrame(with(any(byte[].class)), with(0),
+			oneOf(encrypter).writeFrame(with(any(byte[].class)), with(0),
 					with(false));
 			// Flush the stream
-			oneOf(writer).flush();
+			oneOf(encrypter).flush();
 		}});
 		w.flush();
 		context.assertIsSatisfied();
@@ -49,9 +50,9 @@ public class StreamWriterImplTest extends BriarTestCase {
 		// Clean up
 		context.checking(new Expectations() {{
 			// Closing the writer writes a final frame and flushes again
-			oneOf(writer).writeFrame(with(any(byte[].class)), with(0),
+			oneOf(encrypter).writeFrame(with(any(byte[].class)), with(0),
 					with(true));
-			oneOf(writer).flush();
+			oneOf(encrypter).flush();
 		}});
 		w.close();
 		context.assertIsSatisfied();
@@ -61,14 +62,14 @@ public class StreamWriterImplTest extends BriarTestCase {
 	public void testFlushWithBufferedDataWritesFrameAndFlushes()
 			throws Exception {
 		Mockery context = new Mockery();
-		final FrameWriter writer = context.mock(FrameWriter.class);
-		StreamWriterImpl w = new StreamWriterImpl(writer, FRAME_LENGTH);
+		final StreamEncrypter encrypter = context.mock(StreamEncrypter.class);
+		StreamWriterImpl w = new StreamWriterImpl(encrypter, FRAME_LENGTH);
 		context.checking(new Expectations() {{
 			// Write a non-final frame with one payload byte
-			oneOf(writer).writeFrame(with(any(byte[].class)), with(1),
+			oneOf(encrypter).writeFrame(with(any(byte[].class)), with(1),
 					with(false));
 			// Flush the stream
-			oneOf(writer).flush();
+			oneOf(encrypter).flush();
 		}});
 		w.write(0);
 		w.flush();
@@ -77,9 +78,9 @@ public class StreamWriterImplTest extends BriarTestCase {
 		// Clean up
 		context.checking(new Expectations() {{
 			// Closing the writer writes a final frame and flushes again
-			oneOf(writer).writeFrame(with(any(byte[].class)), with(0),
+			oneOf(encrypter).writeFrame(with(any(byte[].class)), with(0),
 					with(true));
-			oneOf(writer).flush();
+			oneOf(encrypter).flush();
 		}});
 		w.close();
 		context.assertIsSatisfied();
@@ -88,11 +89,11 @@ public class StreamWriterImplTest extends BriarTestCase {
 	@Test
 	public void testSingleByteWritesWriteFullFrame() throws Exception {
 		Mockery context = new Mockery();
-		final FrameWriter writer = context.mock(FrameWriter.class);
-		StreamWriterImpl w = new StreamWriterImpl(writer, FRAME_LENGTH);
+		final StreamEncrypter encrypter = context.mock(StreamEncrypter.class);
+		StreamWriterImpl w = new StreamWriterImpl(encrypter, FRAME_LENGTH);
 		context.checking(new Expectations() {{
 			// Write a full non-final frame
-			oneOf(writer).writeFrame(with(any(byte[].class)),
+			oneOf(encrypter).writeFrame(with(any(byte[].class)),
 					with(MAX_PAYLOAD_LENGTH), with(false));
 		}});
 		for(int i = 0; i < MAX_PAYLOAD_LENGTH; i++) {
@@ -103,9 +104,9 @@ public class StreamWriterImplTest extends BriarTestCase {
 		// Clean up
 		context.checking(new Expectations() {{
 			// Closing the writer writes a final frame and flushes again
-			oneOf(writer).writeFrame(with(any(byte[].class)), with(0),
+			oneOf(encrypter).writeFrame(with(any(byte[].class)), with(0),
 					with(true));
-			oneOf(writer).flush();
+			oneOf(encrypter).flush();
 		}});
 		w.close();
 		context.assertIsSatisfied();
@@ -114,11 +115,11 @@ public class StreamWriterImplTest extends BriarTestCase {
 	@Test
 	public void testMultiByteWritesWriteFullFrames() throws Exception {
 		Mockery context = new Mockery();
-		final FrameWriter writer = context.mock(FrameWriter.class);
-		StreamWriterImpl w = new StreamWriterImpl(writer, FRAME_LENGTH);
+		final StreamEncrypter encrypter = context.mock(StreamEncrypter.class);
+		StreamWriterImpl w = new StreamWriterImpl(encrypter, FRAME_LENGTH);
 		context.checking(new Expectations() {{
 			// Write two full non-final frames
-			exactly(2).of(writer).writeFrame(with(any(byte[].class)),
+			exactly(2).of(encrypter).writeFrame(with(any(byte[].class)),
 					with(MAX_PAYLOAD_LENGTH), with(false));
 		}});
 		// Sanity check
@@ -134,9 +135,9 @@ public class StreamWriterImplTest extends BriarTestCase {
 		// Clean up
 		context.checking(new Expectations() {{
 			// Closing the writer writes a final frame and flushes again
-			oneOf(writer).writeFrame(with(any(byte[].class)), with(0),
+			oneOf(encrypter).writeFrame(with(any(byte[].class)), with(0),
 					with(true));
-			oneOf(writer).flush();
+			oneOf(encrypter).flush();
 		}});
 		w.close();
 		context.assertIsSatisfied();
@@ -145,17 +146,17 @@ public class StreamWriterImplTest extends BriarTestCase {
 	@Test
 	public void testLargeMultiByteWriteWritesFullFrames() throws Exception {
 		Mockery context = new Mockery();
-		final FrameWriter writer = context.mock(FrameWriter.class);
-		StreamWriterImpl w = new StreamWriterImpl(writer, FRAME_LENGTH);
+		final StreamEncrypter encrypter = context.mock(StreamEncrypter.class);
+		StreamWriterImpl w = new StreamWriterImpl(encrypter, FRAME_LENGTH);
 		context.checking(new Expectations() {{
 			// Write two full non-final frames
-			exactly(2).of(writer).writeFrame(with(any(byte[].class)),
+			exactly(2).of(encrypter).writeFrame(with(any(byte[].class)),
 					with(MAX_PAYLOAD_LENGTH), with(false));
 			// Write a final frame with a one-byte payload
-			oneOf(writer).writeFrame(with(any(byte[].class)), with(1),
+			oneOf(encrypter).writeFrame(with(any(byte[].class)), with(1),
 					with(true));
 			// Flush the stream
-			oneOf(writer).flush();
+			oneOf(encrypter).flush();
 		}});
 		// Write two full payloads using one large multi-byte write
 		byte[] b = new byte[MAX_PAYLOAD_LENGTH * 2 + 1];

briar-tests/src/org/briarproject/transport/TestStreamDecrypter.java

@@ -0,0 +1,44 @@
+package org.briarproject.transport;
+
+import static org.briarproject.api.transport.TransportConstants.HEADER_LENGTH;
+import static org.briarproject.api.transport.TransportConstants.MAC_LENGTH;
+
+import java.io.EOFException;
+import java.io.IOException;
+import java.io.InputStream;
+
+import org.briarproject.api.FormatException;
+import org.briarproject.api.crypto.StreamDecrypter;
+import org.briarproject.util.ByteUtils;
+
+class TestStreamDecrypter implements StreamDecrypter {
+
+	private final InputStream in;
+	private final byte[] frame;
+
+	TestStreamDecrypter(InputStream in, int frameLength) {
+		this.in = in;
+		frame = new byte[frameLength];
+	}
+
+	public int readFrame(byte[] payload) throws IOException {
+		int offset = 0;
+		while(offset < HEADER_LENGTH) {
+			int read = in.read(frame, offset, HEADER_LENGTH - offset);
+			if(read == -1) throw new EOFException();
+			offset += read;
+		}
+		boolean finalFrame = (frame[0] & 0x80) == 0x80;
+		int payloadLength = ByteUtils.readUint16(frame, 0) & 0x7FFF;
+		while(offset < frame.length) {
+			int read = in.read(frame, offset, frame.length - offset);
+			if(read == -1) break;
+			offset += read;
+		}
+		if(!finalFrame && offset < frame.length) throw new EOFException();
+		if(offset < HEADER_LENGTH + payloadLength + MAC_LENGTH)
+			throw new FormatException();
+		System.arraycopy(frame, HEADER_LENGTH, payload, 0, payloadLength);
+		return payloadLength;
+	}
+}

briar-tests/src/org/briarproject/transport/TestStreamEncrypter.java

@@ -0,0 +1,44 @@
+package org.briarproject.transport;
+
+import static org.briarproject.api.transport.TransportConstants.HEADER_LENGTH;
+import static org.briarproject.api.transport.TransportConstants.MAC_LENGTH;
+
+import java.io.IOException;
+import java.io.OutputStream;
+
+import org.briarproject.api.crypto.StreamEncrypter;
+import org.briarproject.util.ByteUtils;
+
+class TestStreamEncrypter implements StreamEncrypter {
+
+	private final OutputStream out;
+	private final byte[] tag, frame;
+
+	private boolean writeTag = true;
+
+	TestStreamEncrypter(OutputStream out, int frameLength, byte[] tag) {
+		this.out = out;
+		this.tag = tag;
+		frame = new byte[frameLength];
+	}
+
+	public void writeFrame(byte[] payload, int payloadLength,
+			boolean finalFrame) throws IOException {
+		if(writeTag) {
+			out.write(tag);
+			writeTag = false;
+		}
+		ByteUtils.writeUint16(payloadLength, frame, 0);
+		if(finalFrame) frame[0] |= 0x80;
+		System.arraycopy(payload, 0, frame, HEADER_LENGTH, payloadLength);
+		for(int i = HEADER_LENGTH + payloadLength; i < frame.length; i++)
+			frame[i] = 0;
+		if(finalFrame)
+			out.write(frame, 0, HEADER_LENGTH + payloadLength + MAC_LENGTH);
+		else out.write(frame, 0, frame.length);
+	}
+
+	public void flush() throws IOException {
+		out.flush();
+	}
+}

briar-tests/src/org/briarproject/transport/TransportIntegrationTest.java

@@ -11,48 +11,18 @@ import java.io.OutputStream;
 import java.util.Random;
 
 import org.briarproject.BriarTestCase;
-import org.briarproject.TestLifecycleModule;
-import org.briarproject.TestSystemModule;
-import org.briarproject.api.crypto.AuthenticatedCipher;
-import org.briarproject.api.crypto.CryptoComponent;
-import org.briarproject.api.crypto.SecretKey;
-import org.briarproject.api.transport.StreamWriterFactory;
-import org.briarproject.crypto.CryptoModule;
+import org.briarproject.api.crypto.StreamDecrypter;
+import org.briarproject.api.crypto.StreamEncrypter;
 import org.junit.Test;
 
-import com.google.inject.AbstractModule;
-import com.google.inject.Guice;
-import com.google.inject.Injector;
-import com.google.inject.Module;
-
 public class TransportIntegrationTest extends BriarTestCase {
 
 	private final int FRAME_LENGTH = 2048;
 
-	private final CryptoComponent crypto;
-	private final AuthenticatedCipher frameCipher;
 	private final Random random;
-	private final byte[] secret;
-	private final SecretKey tagKey, frameKey;
 
 	public TransportIntegrationTest() {
-		Module testModule = new AbstractModule() {
-			@Override
-			public void configure() {
-				bind(StreamWriterFactory.class).to(
-						StreamWriterFactoryImpl.class);
-			}
-		};
-		Injector i = Guice.createInjector(testModule, new CryptoModule(),
-				new TestLifecycleModule(), new TestSystemModule());
-		crypto = i.getInstance(CryptoComponent.class);
-		frameCipher = crypto.getFrameCipher();
 		random = new Random();
-		// Since we're sending frames to ourselves, we only need outgoing keys
-		secret = new byte[32];
-		random.nextBytes(secret);
-		tagKey = crypto.deriveTagKey(secret, true);
-		frameKey = crypto.deriveFrameKey(secret, 0, true);
 	}
 
 	@Test
@@ -66,27 +36,24 @@ public class TransportIntegrationTest extends BriarTestCase {
 	}
 
 	private void testWriteAndRead(boolean initiator) throws Exception {
-		// Encode the tag
+		// Generate a random tag
 		byte[] tag = new byte[TAG_LENGTH];
-		crypto.encodeTag(tag, tagKey, 0);
-		// Generate two random frames
-		byte[] frame = new byte[1234];
-		random.nextBytes(frame);
-		byte[] frame1 = new byte[321];
-		random.nextBytes(frame1);
-		// Copy the frame key - the copy will be erased
-		SecretKey frameCopy = frameKey.copy();
+		random.nextBytes(tag);
+		// Generate two frames with random payloads
+		byte[] payload1 = new byte[1234];
+		random.nextBytes(payload1);
+		byte[] payload2 = new byte[321];
+		random.nextBytes(payload2);
 		// Write the tag and the frames
 		ByteArrayOutputStream out = new ByteArrayOutputStream();
-		FrameWriter frameWriter = new OutgoingEncryptionLayer(out,
-				frameCipher, frameCopy, FRAME_LENGTH, tag);
-		StreamWriterImpl streamWriter = new StreamWriterImpl(frameWriter,
+		StreamEncrypter encrypter = new TestStreamEncrypter(out, FRAME_LENGTH,
+				tag);
+		OutputStream streamWriter = new StreamWriterImpl(encrypter,
 				FRAME_LENGTH);
-		OutputStream out1 = streamWriter.getOutputStream();
-		out1.write(frame);
-		out1.flush();
-		out1.write(frame1);
-		out1.flush();
+		streamWriter.write(payload1);
+		streamWriter.flush();
+		streamWriter.write(payload2);
+		streamWriter.flush();
 		byte[] output = out.toByteArray();
 		assertEquals(TAG_LENGTH + FRAME_LENGTH * 2, output.length);
 		// Read the tag back
@@ -95,17 +62,15 @@ public class TransportIntegrationTest extends BriarTestCase {
 		read(in, recoveredTag);
 		assertArrayEquals(tag, recoveredTag);
 		// Read the frames back
-		FrameReader frameReader = new IncomingEncryptionLayer(in, frameCipher,
-				frameKey, FRAME_LENGTH);
-		StreamReaderImpl streamReader = new StreamReaderImpl(frameReader,
+		StreamDecrypter decrypter = new TestStreamDecrypter(in, FRAME_LENGTH);
+		InputStream streamReader = new StreamReaderImpl(decrypter,
 				FRAME_LENGTH);
-		InputStream in1 = streamReader.getInputStream();
-		byte[] recoveredFrame = new byte[frame.length];
-		read(in1, recoveredFrame);
-		assertArrayEquals(frame, recoveredFrame);
-		byte[] recoveredFrame1 = new byte[frame1.length];
-		read(in1, recoveredFrame1);
-		assertArrayEquals(frame1, recoveredFrame1);
+		byte[] recoveredPayload1 = new byte[payload1.length];
+		read(streamReader, recoveredPayload1);
+		assertArrayEquals(payload1, recoveredPayload1);
+		byte[] recoveredPayload2 = new byte[payload2.length];
+		read(streamReader, recoveredPayload2);
+		assertArrayEquals(payload2, recoveredPayload2);
 		streamWriter.close();
 		streamReader.close();
 	}