From f663bf86672f3fa77d3c395aa54b3932e5d41a56 Mon Sep 17 00:00:00 2001 From: akwizgran Date: Fri, 5 Jun 2020 12:05:21 +0100 Subject: [PATCH] Remove unused parameter. --- .../plugin/bluetooth/AndroidBluetoothTransportConnection.java | 2 +- .../bramble/plugin/bluetooth/BluetoothConnectionLimiter.java | 4 +--- .../plugin/bluetooth/BluetoothConnectionLimiterImpl.java | 4 +--- .../plugin/bluetooth/JavaBluetoothTransportConnection.java | 2 +- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/bramble-android/src/main/java/org/briarproject/bramble/plugin/bluetooth/AndroidBluetoothTransportConnection.java b/bramble-android/src/main/java/org/briarproject/bramble/plugin/bluetooth/AndroidBluetoothTransportConnection.java index 20876a814..bf6b3d69f 100644 --- a/bramble-android/src/main/java/org/briarproject/bramble/plugin/bluetooth/AndroidBluetoothTransportConnection.java +++ b/bramble-android/src/main/java/org/briarproject/bramble/plugin/bluetooth/AndroidBluetoothTransportConnection.java @@ -50,7 +50,7 @@ class AndroidBluetoothTransportConnection try { socket.close(); } finally { - connectionLimiter.connectionClosed(this, exception); + connectionLimiter.connectionClosed(this); } } } diff --git a/bramble-core/src/main/java/org/briarproject/bramble/plugin/bluetooth/BluetoothConnectionLimiter.java b/bramble-core/src/main/java/org/briarproject/bramble/plugin/bluetooth/BluetoothConnectionLimiter.java index e72b6779a..b3d76bb5e 100644 --- a/bramble-core/src/main/java/org/briarproject/bramble/plugin/bluetooth/BluetoothConnectionLimiter.java +++ b/bramble-core/src/main/java/org/briarproject/bramble/plugin/bluetooth/BluetoothConnectionLimiter.java @@ -36,10 +36,8 @@ interface BluetoothConnectionLimiter { /** * Informs the limiter that the given connection has been closed. - * - * @param exception True if the connection was closed due to an exception. */ - void connectionClosed(DuplexTransportConnection conn, boolean exception); + void connectionClosed(DuplexTransportConnection conn); /** * Informs the limiter that all connections have been closed. diff --git a/bramble-core/src/main/java/org/briarproject/bramble/plugin/bluetooth/BluetoothConnectionLimiterImpl.java b/bramble-core/src/main/java/org/briarproject/bramble/plugin/bluetooth/BluetoothConnectionLimiterImpl.java index ff1e43b2d..7e5713cd6 100644 --- a/bramble-core/src/main/java/org/briarproject/bramble/plugin/bluetooth/BluetoothConnectionLimiterImpl.java +++ b/bramble-core/src/main/java/org/briarproject/bramble/plugin/bluetooth/BluetoothConnectionLimiterImpl.java @@ -90,10 +90,8 @@ class BluetoothConnectionLimiterImpl implements BluetoothConnectionLimiter { } @Override - public void connectionClosed(DuplexTransportConnection conn, - boolean exception) { + public void connectionClosed(DuplexTransportConnection conn) { synchronized (lock) { - if (exception) LOG.info("Connection failed"); countStableConnections(clock.currentTimeMillis()); Iterator it = connections.iterator(); while (it.hasNext()) { diff --git a/bramble-java/src/main/java/org/briarproject/bramble/plugin/bluetooth/JavaBluetoothTransportConnection.java b/bramble-java/src/main/java/org/briarproject/bramble/plugin/bluetooth/JavaBluetoothTransportConnection.java index 12e7630e8..319d9af76 100644 --- a/bramble-java/src/main/java/org/briarproject/bramble/plugin/bluetooth/JavaBluetoothTransportConnection.java +++ b/bramble-java/src/main/java/org/briarproject/bramble/plugin/bluetooth/JavaBluetoothTransportConnection.java @@ -45,7 +45,7 @@ class JavaBluetoothTransportConnection try { stream.close(); } finally { - connectionLimiter.connectionClosed(this, exception); + connectionLimiter.connectionClosed(this); } } }