From fd2d5c91732a9ed9b74eaf6727422e0a8760ee43 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20K=C3=BCrten?= Date: Tue, 24 Jan 2023 14:48:03 +0100 Subject: [PATCH] Add comment about NetworkInfo#isConnected() --- .../briarproject/bramble/network/AndroidNetworkManager.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/bramble-android/src/main/java/org/briarproject/bramble/network/AndroidNetworkManager.java b/bramble-android/src/main/java/org/briarproject/bramble/network/AndroidNetworkManager.java index 3deb3a2a9..b19b1feb6 100644 --- a/bramble-android/src/main/java/org/briarproject/bramble/network/AndroidNetworkManager.java +++ b/bramble-android/src/main/java/org/briarproject/bramble/network/AndroidNetworkManager.java @@ -118,6 +118,11 @@ class AndroidNetworkManager implements NetworkManager, Service { try { NetworkInfo net = connectivityManager.getActiveNetworkInfo(); boolean connected = net != null && net.isConnected(); + // Research into Android's behavior to check network connectivity + // (https://code.briarproject.org/briar/public-mesh-research/-/issues/19) + // has shown that NetworkInfo#isConnected() returns true if the device + // is connected to any Wifi, independent of whether any specific IP + // address can be reached using it or any domain names can be resolved. boolean wifi = false, ipv6Only = false; if (connected) { wifi = net.getType() == TYPE_WIFI;