akwizgran
cbdeb0ad32
Replace unused injected field with a mock.
2016-11-21 16:41:01 +00:00
akwizgran
dbbeb37485
Merge branch '757-remove-deviceid-code' into 'master'
...
Remove Device ID
Closes #757
See merge request !423
2016-11-18 15:54:28 +00:00
Torsten Grote
1697c2af04
Remove Device ID
2016-11-18 12:30:25 -02:00
Torsten Grote
98cb077dd9
Migrate all custom signature code to new methods and add test
2016-11-18 12:19:03 -02:00
Torsten Grote
c86d971166
Require a label for signing
...
This adds a sign() and a verify() method to the CryptoComponent
that take a mandatory label argument to ensure that signatures can't be
repurposed.
2016-11-18 11:05:19 -02:00
Torsten Grote
303fcc9ece
Merge branch 'validator-unit-tests' into 'master'
...
Unit tests for some validators
See merge request !413
2016-11-16 17:44:08 +00:00
akwizgran
e2bbe7429b
Moved some boilerplate into a field.
2016-11-16 17:00:53 +00:00
akwizgran
eaf17c054f
Moved common fields to superclass.
2016-11-16 16:39:30 +00:00
akwizgran
ec1f4dccdb
Added third group visibility state.
2016-11-16 15:40:51 +00:00
akwizgran
8c3b598ab2
Unit tests for ForumSharingValidator.
2016-11-16 15:35:27 +00:00
akwizgran
bd3bba6e8a
Unit tests for ForumPostValidator.
2016-11-16 14:36:22 +00:00
akwizgran
11fcad89c6
Unit tests for BdfMessageValidator.
2016-11-16 14:32:22 +00:00
akwizgran
52eb261a11
Unit tests for PrivateMessageValidator.
2016-11-16 11:49:49 +00:00
akwizgran
aa210fc555
Factor MessageTracker out of BdfIncomingMessageHook.
2016-11-11 16:59:10 +00:00
akwizgran
138a6e11a7
Merge branch '346-smaller-qr-codes' into 'master'
...
Encode transport properties more compactly in QR codes
The [original BQP spec](https://code.briarproject.org/akwizgran/briar/wikis/BQP ) described a compact encoding for transport properties, with the goal of making the QR code as small as possible. At some point during the implementation, I asked @str4d to use TransportIds and TransportProperties instead, as described in the [current spec](https://code.briarproject.org/akwizgran/briar-spec/blob/master/protocols/BQP.md ). That was a mistake.
Using the original format reduces the payload from 60 to 34 bytes (43% smaller) for Bluetooth only, and from 96 to 49 bytes (49% smaller) for Bluetooth and LAN. This makes it easier to scan codes from low-resolution screens using fixed-focus and/or low-resolution cameras. Using this branch I can exchange codes between the Sony Xperia Tipo (320x480 screen, fixed focus, 640x480 preview size) and the Huawei Ascend Y300 (480x800 screen, infinity focus, 1280x720 preview size).
This also removes an obstacle to implementing #558 , as TransportIds are no longer included in QR codes.
Closes #346 .
See merge request !394
2016-11-08 17:32:26 +00:00
akwizgran
d2a3804cfe
Added null safety annotations to plugin interfaces.
2016-11-08 16:59:56 +00:00
Torsten Grote
e96b3a8c68
Use namespaced strings for client IDs
2016-11-08 11:17:52 -02:00
akwizgran
04d4ecad05
Encode transport properties more compactly in QR codes.
2016-11-08 11:28:44 +00:00
Torsten Grote
719a53dc94
Address review comments
2016-11-04 12:58:12 -02:00
Torsten Grote
c36f5c795b
Address review comments for TransportKeyManagerImplTest
2016-11-04 11:04:44 -02:00
Torsten Grote
f52186ac8c
Add unit tests for KeyManagerImpl and create TransportKeyManager
...
interface and a factory for that.
2016-11-04 10:54:56 -02:00
Torsten Grote
b34b4623ed
Replace transaction.setComplete() by database.commitTransaction()
2016-11-02 13:04:31 -02:00
akwizgran
36f087c512
Merge branch '724-unit-tests-for-clienthelperimpl' into 'master'
...
Add Unit Tests for ClientHelper
Closes #724
See merge request !379
2016-11-02 11:04:07 +00:00
akwizgran
4d8a84a48d
Don't throw IllegalStateException if BDF input is incomplete.
2016-11-01 17:38:23 +00:00
akwizgran
2650f3114e
Merge branch '518-limit-the-depth-of-nested-bdf-structures' into 'master'
...
Limit the depth of nested BDF structures
Closes #518
See merge request !375
2016-11-01 17:30:50 +00:00
Torsten Grote
dfdde9799f
Add Unit Tests for ClientHelper
2016-11-01 15:28:28 -02:00
akwizgran
114a2dc8f2
Merge branch '427-local-author-caching' into 'master'
...
Cache the local author and load before the db latch is released
Closes #427 , #588
See merge request !354
2016-11-01 17:21:14 +00:00
akwizgran
642fa7df18
Removed unused field, renamed nickname methods.
2016-11-01 17:17:40 +00:00
akwizgran
c85767d2a0
Nickname is all one word.
2016-11-01 17:12:30 +00:00
Torsten Grote
55af1b954e
Limit the depth of nested BDF structures
2016-11-01 14:52:00 -02:00
Ernir Erlingsson
eaa393a7ed
added a cache to the IdentityManager, changed its signature, modified when and where the author is stored
...
made the author creation single-threaded again in the LifecycleManager, removed redundant code
2016-11-01 12:51:49 +01:00
akwizgran
19080ad957
Merge branch '723-unit-tests-for-contactmanagerimpl' into 'master'
...
Add Unit tests for ContactManager
Closes #723
See merge request !376
2016-11-01 11:50:47 +00:00
Torsten Grote
7eeeb5f1ed
Add Unit tests for ContactManager
2016-11-01 09:40:05 -02:00
Torsten Grote
9e553ef9c8
Update blog backend to match current usage
2016-11-01 08:34:29 -02:00
Torsten Grote
8dc529cc3f
Move validator's signature verification into ClientHelper
2016-10-31 10:08:26 -02:00
akwizgran
d25f4d1fbe
Merge branch 'string-truncation' into 'master'
...
Truncate all messages to valid length before sending
See merge request !358
2016-10-25 15:52:35 +00:00
akwizgran
82eea6bb77
Throw FormatException if BdfList index is out of bounds.
2016-10-19 18:11:31 +01:00
akwizgran
08b191d72e
Fixed a typo in a comment in a test. URGENT STUFF!
2016-10-19 15:04:24 +01:00
akwizgran
06335c2c30
Truncate all messages to valid length before sending.
2016-10-19 14:49:09 +01:00
Torsten Grote
6e04664915
Print stack trace for uncaught exceptions during tests for easier debugging
2016-10-14 08:44:47 -03:00
Torsten Grote
7f2db71160
Address review comments
2016-10-10 10:46:30 -03:00
Torsten Grote
d661fa0661
Fix IntroductionManager unit tests
2016-10-05 18:51:03 -03:00
Torsten Grote
a727a0817e
Store message count, unread count and timestamp of latest message
...
in group metadata to be able to speed up group listings.
Closes #584 , #586 , #585
2016-10-05 12:34:37 -03:00
Torsten Grote
6ece398a21
Create PrivateGroupManager Facade and stub implementation
2016-09-30 12:05:35 -03:00
akwizgran
fd6719301a
Merge branch '556-thread-safety-blocking-issues' into 'master'
...
Forum controller thread safety and tree safety
This branch solves the concurrent forum issues by code restructure and refactoring.
Closes #556
Closes #552
See merge request !262
2016-09-29 09:30:51 +00:00
Ernir Erlingsson
92f2e7b0fc
merge with master and fixes after comments
2016-09-29 01:30:13 +02:00
akwizgran
7e806c8cf2
Merge branch '679-own-personal-blogs-can-be-removed' into 'master'
...
Prevent personal blogs from being removed
This also adds unit tests to prevent regressions like this in the future.
Closes #679
See merge request !330
2016-09-28 16:22:46 +00:00
Torsten Grote
d058172429
When a message is shared, share its transitive dependencies
...
Like other recursive operations on the dependency graph, this is
not done in a single transaction to prevent an attacker from creating
arbitrary large transactions.
So at startup, the `ValidationManager` finds and resumes any
unfinished operations, by looking for shared messages with unshared
dependencies.
2016-09-28 13:17:11 -03:00
Torsten Grote
1f0b305139
Prevent personal blogs from being removed
...
This also adds unit tests to prevent regressions like this in the
future.
2016-09-28 13:12:20 -03:00
Torsten Grote
8fb820c967
Merge branch 'check-if-listfiles-returns-null' into 'master'
...
Check whether File#listFiles() returns null
The docs say this can happen if there's an I/O error. Also fixed a throw-in-finally-block warning and renamed an IoUtils method to make its contract clearer.
See merge request !328
2016-09-27 16:17:09 +00:00