Use ACTION_GET_CONTENT to show more content providers.

bramble-android/build.gradle

@@ -8,15 +8,11 @@ android {
 	compileSdkVersion 30
 	buildToolsVersion '30.0.2'
 
-	packagingOptions {
-		doNotStrip '**/*.so'
-	}
-
 	defaultConfig {
 		minSdkVersion 16
 		targetSdkVersion 29
-		versionCode 10218
+		versionCode 10216
-		versionName "1.2.18"
+		versionName "1.2.16"
 		consumerProguardFiles 'proguard-rules.txt'
 
 		testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"

bramble-android/src/main/java/org/briarproject/bramble/plugin/bluetooth/AndroidBluetoothPlugin.java

@@ -175,11 +175,6 @@ class AndroidBluetoothPlugin
 		} catch (IOException e) {
 			IoUtils.tryToClose(s, LOG, WARNING);
 			throw e;
-		} catch (NullPointerException e) {
-			// BluetoothSocket#connect() may throw an NPE under unknown
-			// circumstances
-			IoUtils.tryToClose(s, LOG, WARNING);
-			throw new IOException(e);
 		}
 	}
 

bramble-android/src/main/java/org/briarproject/bramble/util/AndroidUtils.java

@@ -114,8 +114,12 @@ public class AndroidUtils {
 
 	/**
 	 * Returns an array of supported content types for image attachments.
+	 * GIFs can't be compressed on API < 24 so they're not supported.
+	 * <p>
+	 * TODO: Remove this restriction when large message support is added
 	 */
 	public static String[] getSupportedImageContentTypes() {
-		return new String[] {"image/jpeg", "image/png", "image/gif"};
+		if (SDK_INT < 24) return new String[] {"image/jpeg", "image/png"};
+		else return new String[] {"image/jpeg", "image/png", "image/gif"};
 	}
 }

bramble-core/src/main/resources/bridges

@@ -2,11 +2,12 @@ Bridge obfs4 192.95.36.142:443 CDF2E852BF539B82BD10E27E9115A31734E378C2 cert=qUV
 Bridge obfs4 38.229.1.78:80 C8CBDB2464FC9804A69531437BCF2BE31FDD2EE4 cert=Hmyfd2ev46gGY7NoVxA9ngrPF2zCZtzskRTzoWXbxNkzeVnGFPWmrTtILRyqCTjHR+s9dg iat-mode=1
 Bridge obfs4 37.218.245.14:38224 D9A82D2F9C2F65A18407B1D2B764F130847F8B5D cert=bjRaMrr1BRiAW8IE9U5z27fQaYgOhX1UCmOpg2pFpoMvo6ZgQMzLsaTzzQNTlm7hNcb+Sg iat-mode=0
 Bridge obfs4 85.31.186.98:443 011F2599C0E9B27EE74B353155E244813763C3E5 cert=ayq0XzCwhpdysn5o0EyDUbmSOx3X/oTEbzDMvczHOdBJKlvIdHHLJGkZARtT4dcBFArPPg iat-mode=0
-Bridge obfs4 144.217.20.138:80 FB70B257C162BF1038CA669D568D76F5B7F0BABB cert=vYIV5MgrghGQvZPIi1tJwnzorMgqgmlKaB77Y3Z9Q/v94wZBOAXkW+fdx4aSxLVnKO+xNw iat-mode=0
+Bridge obfs4 85.31.186.26:443 91A6354697E6B02A386312F68D82CF86824D3606 cert=PBwr+S8JTVZo6MPdHnkTwXJPILWADLqfMGoVvhZClMq/Urndyd42BwX9YFJHZnBB3H0XCw iat-mode=0
 Bridge obfs4 193.11.166.194:27015 2D82C2E354D531A68469ADF7F878FA6060C6BACA cert=4TLQPJrTSaDffMK7Nbao6LC7G9OW/NHkUwIdjLSS3KYf0Nv4/nQiiI8dY2TcsQx01NniOg iat-mode=0
 Bridge obfs4 193.11.166.194:27020 86AC7B8D430DAC4117E9F42C9EAED18133863AAF cert=0LDeJH4JzMDtkJJrFphJCiPqKx7loozKN7VNfuukMGfHO0Z8OGdzHVkhVAOfo1mUdv9cMg iat-mode=0
 Bridge obfs4 193.11.166.194:27025 1AE2C08904527FEA90C4C4F8C1083EA59FBC6FAF cert=ItvYZzW5tn6v3G4UnQa6Qz04Npro6e81AP70YujmK/KXwDFPTs3aHXcHp4n8Vt6w/bv8cA iat-mode=0
 Bridge obfs4 209.148.46.65:443 74FAD13168806246602538555B5521A0383A1875 cert=ssH+9rP8dG2NLDN2XuFw63hIO/9MNNinLmxQDpVa+7kTOa9/m+tGWT1SmSYpQ9uTBGa6Hw iat-mode=0
+Bridge obfs4 146.57.248.225:22 10A6CD36A537FCE513A322361547444B393989F0 cert=K1gDtDAIcUfeLqbstggjIw2rtgIKqdIhUlHp82XRqNSq/mtAjp1BIC9vHKJ2FAEpGssTPw iat-mode=0
 Bridge obfs4 45.145.95.6:27015 C5B7CD6946FF10C5B3E89691A7D3F2C122D2117C cert=TD7PbUO0/0k6xYHMPW3vJxICfkMZNdkRrb63Zhl5j9dW3iRGiCx0A7mPhe5T2EDzQ35+Zw iat-mode=0
 Bridge obfs4 51.222.13.177:80 5EDAC3B810E12B01F6FD8050D2FD3E277B289A08 cert=2uplIpLQ0q9+0qMFrK5pkaYRDOe460LL9WHBvatgkuRr/SL31wBOEupaMMJ6koRE6Ld0ew iat-mode=0
 Bridge obfs4 78.46.188.239:37356 5A2D2F4158D0453E00C7C176978D3F41D69C45DB cert=3c0SwxpOisbohNxEc4tb875RVW8eOu1opRTVXJhafaKA/PNNtI7ElQIVOVZg1AdL5bxGCw iat-mode=0

bramble-java/build.gradle

@@ -16,7 +16,7 @@ dependencies {
 	implementation fileTree(dir: 'libs', include: '*.jar')
 	implementation 'net.java.dev.jna:jna:4.5.2'
 	implementation 'net.java.dev.jna:jna-platform:4.5.2'
-	tor 'org.briarproject:tor:0.3.5.13-1@zip'
+	tor 'org.briarproject:tor:0.3.5.13@zip'
 	tor 'org.briarproject:obfs4proxy:0.0.12-dev-40245c4a@zip'
 
 	annotationProcessor 'com.google.dagger:dagger-compiler:2.24'

bramble-java/src/main/java/org/briarproject/bramble/plugin/tor/UnixTorPluginFactory.java

@@ -25,7 +25,6 @@ import javax.annotation.concurrent.Immutable;
 import javax.inject.Inject;
 import javax.net.SocketFactory;
 
-import static java.util.logging.Level.INFO;
 import static java.util.logging.Logger.getLogger;
 import static org.briarproject.bramble.util.OsUtils.isLinux;
 
@@ -97,15 +96,8 @@ public class UnixTorPluginFactory implements DuplexPluginFactory {
 		String architecture = null;
 		if (isLinux()) {
 			String arch = System.getProperty("os.arch");
-			if (LOG.isLoggable(INFO)) {
-				LOG.info("System's os.arch is " + arch);
-			}
 			if (arch.equals("amd64")) {
 				architecture = "linux-x86_64";
-			} else if (arch.equals("aarch64")) {
-				architecture = "linux-aarch64";
-			} else if (arch.equals("arm")) {
-				architecture = "linux-armhf";
 			}
 		}
 		if (architecture == null) {
@@ -113,10 +105,6 @@ public class UnixTorPluginFactory implements DuplexPluginFactory {
 			return null;
 		}
 
-		if (LOG.isLoggable(INFO)) {
-			LOG.info("The selected architecture for Tor is " + architecture);
-		}
-
 		Backoff backoff = backoffFactory.createBackoff(MIN_POLLING_INTERVAL,
 				MAX_POLLING_INTERVAL, BACKOFF_BASE);
 		TorRendezvousCrypto torRendezvousCrypto = new TorRendezvousCryptoImpl();

bramble-java/witness.gradle

@@ -24,7 +24,7 @@ dependencyVerification {
         'org.apache.ant:ant:1.9.4:ant-1.9.4.jar:649ae0730251de07b8913f49286d46bba7b92d47c5f332610aa426c4f02161d8',
         'org.beanshell:bsh:1.3.0:bsh-1.3.0.jar:9b04edc75d19db54f1b4e8b5355e9364384c6cf71eb0a1b9724c159d779879f8',
         'org.briarproject:obfs4proxy:0.0.12-dev-40245c4a:obfs4proxy-0.0.12-dev-40245c4a.zip:172029e7058b3a83ac93ac4991a44bf76e16ce8d46f558f5836d57da3cb3a766',
-        'org.briarproject:tor:0.3.5.13-1:tor-0.3.5.13-1.zip:ef35c16bf8dc1f4c75ed71d9f55e4514f383d124ec96b859aca647c990927c99',
+        'org.briarproject:tor:0.3.5.13:tor-0.3.5.13.zip:1c5f0b821ee2aadb0ea04aa96caab3ca0a08370cce8de81c2dfe04d172f8a2a0',
         'org.checkerframework:checker-compat-qual:2.5.3:checker-compat-qual-2.5.3.jar:d76b9afea61c7c082908023f0cbc1427fab9abd2df915c8b8a3e7a509bccbc6d',
         'org.checkerframework:checker-qual:2.5.2:checker-qual-2.5.2.jar:64b02691c8b9d4e7700f8ee2e742dce7ea2c6e81e662b7522c9ee3bf568c040a',
         'org.codehaus.mojo:animal-sniffer-annotations:1.17:animal-sniffer-annotations-1.17.jar:92654f493ecfec52082e76354f0ebf87648dc3d5cec2e3c3cdb947c016747a53',

briar-android/build.gradle

@@ -19,15 +19,11 @@ android {
 	compileSdkVersion 30
 	buildToolsVersion '30.0.2'
 
-	packagingOptions {
-		doNotStrip '**/*.so'
-	}
-
 	defaultConfig {
 		minSdkVersion 16
 		targetSdkVersion 29
-		versionCode 10218
+		versionCode 10216
-		versionName "1.2.18"
+		versionName "1.2.16"
 		applicationId "org.briarproject.briar.android"
 
 		vectorDrawables.useSupportLibrary = true

briar-android/src/main/AndroidManifest.xml

@@ -27,10 +27,7 @@
 	<uses-permission android:name="android.permission.USE_FINGERPRINT" />
 	<uses-permission android:name="android.permission.VIBRATE" />
 	<uses-permission android:name="android.permission.WAKE_LOCK" />
-	<uses-permission
+	<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
-		android:name="android.permission.WRITE_EXTERNAL_STORAGE"
-		android:maxSdkVersion="18"
-		tools:ignore="ScopedStorage" />
 
 	<uses-permission-sdk-23 android:name="android.permission.ACCESS_FINE_LOCATION" />
 	<uses-permission-sdk-23 android:name="android.permission.REQUEST_IGNORE_BATTERY_OPTIMIZATIONS" />
@@ -41,7 +38,6 @@
 		android:name="org.briarproject.briar.android.BriarApplicationImpl"
 		android:allowBackup="false"
 		android:banner="@mipmap/tv_banner"
-		android:fullBackupContent="@xml/backup_rules"
 		android:icon="@mipmap/ic_launcher_round"
 		android:label="@string/app_name"
 		android:logo="@mipmap/ic_launcher_round"

briar-android/src/main/java/org/briarproject/briar/android/AppModule.java

@@ -30,10 +30,8 @@ import org.briarproject.bramble.util.StringUtils;
 import org.briarproject.briar.android.account.DozeHelperModule;
 import org.briarproject.briar.android.account.LockManagerImpl;
 import org.briarproject.briar.android.account.SetupModule;
-import org.briarproject.briar.android.blog.BlogModule;
 import org.briarproject.briar.android.contact.ContactListModule;
 import org.briarproject.briar.android.forum.ForumModule;
-import org.briarproject.briar.android.introduction.IntroductionModule;
 import org.briarproject.briar.android.keyagreement.ContactExchangeModule;
 import org.briarproject.briar.android.logging.LoggingModule;
 import org.briarproject.briar.android.login.LoginModule;
@@ -84,9 +82,7 @@ import static org.briarproject.briar.android.TestingConstants.IS_DEBUG_BUILD;
 		SettingsModule.class,
 		DevReportModule.class,
 		ContactListModule.class,
-		IntroductionModule.class,
 		// below need to be within same scope as ViewModelProvider.Factory
-		BlogModule.class,
 		ForumModule.class,
 		GroupListModule.class,
 		GroupConversationModule.class,

briar-android/src/main/java/org/briarproject/briar/android/activity/ActivityComponent.java

@@ -11,8 +11,10 @@ import org.briarproject.briar.android.account.SetupActivity;
 import org.briarproject.briar.android.account.UnlockActivity;
 import org.briarproject.briar.android.blog.BlogActivity;
 import org.briarproject.briar.android.blog.BlogFragment;
+import org.briarproject.briar.android.blog.BlogModule;
 import org.briarproject.briar.android.blog.BlogPostFragment;
 import org.briarproject.briar.android.blog.FeedFragment;
+import org.briarproject.briar.android.blog.FeedPostFragment;
 import org.briarproject.briar.android.blog.ReblogActivity;
 import org.briarproject.briar.android.blog.ReblogFragment;
 import org.briarproject.briar.android.blog.RssFeedImportActivity;
@@ -83,6 +85,7 @@ import dagger.Component;
 @ActivityScope
 @Component(modules = {
 		ActivityModule.class,
+		BlogModule.class,
 		CreateGroupModule.class,
 		GroupInvitationModule.class,
 		GroupMemberModule.class,
@@ -149,6 +152,8 @@ public interface ActivityComponent {
 
 	void inject(BlogPostFragment fragment);
 
+	void inject(FeedPostFragment fragment);
+
 	void inject(ReblogFragment fragment);
 
 	void inject(ReblogActivity activity);

briar-android/src/main/java/org/briarproject/briar/android/attachment/AttachmentRetrieverImpl.java

@@ -28,12 +28,9 @@ import javax.inject.Inject;
 import androidx.lifecycle.LiveData;
 import androidx.lifecycle.MutableLiveData;
 
-import static java.util.Arrays.asList;
 import static java.util.Objects.requireNonNull;
-import static java.util.logging.Level.INFO;
 import static java.util.logging.Level.WARNING;
 import static java.util.logging.Logger.getLogger;
-import static org.briarproject.bramble.util.AndroidUtils.getSupportedImageContentTypes;
 import static org.briarproject.bramble.util.IoUtils.tryToClose;
 import static org.briarproject.bramble.util.LogUtils.logException;
 import static org.briarproject.briar.android.attachment.AttachmentItem.State.AVAILABLE;
@@ -89,17 +86,7 @@ class AttachmentRetrieverImpl implements AttachmentRetriever {
 		List<AttachmentHeader> headers = messageHeader.getAttachmentHeaders();
 		List<LiveData<AttachmentItem>> items = new ArrayList<>(headers.size());
 		boolean needsSize = headers.size() == 1;
-		List<String> supported = asList(getSupportedImageContentTypes());
 		for (AttachmentHeader h : headers) {
-			// Fail early if we don't support the content type
-			if (!supported.contains(h.getContentType())) {
-				if (LOG.isLoggable(INFO)) {
-					LOG.info("Unsupported content type " + h.getContentType());
-				}
-				AttachmentItem item = new AttachmentItem(h, "", ERROR);
-				items.add(new MutableLiveData<>(item));
-				continue;
-			}
 			// try cache for existing item live data
 			MutableLiveData<AttachmentItem> liveData =
 					itemsWithSize.get(h.getMessageId());

briar-android/src/main/java/org/briarproject/briar/android/blog/BaseController.java

@@ -0,0 +1,48 @@
+package org.briarproject.briar.android.blog;
+
+import org.briarproject.bramble.api.db.DbException;
+import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
+import org.briarproject.bramble.api.sync.GroupId;
+import org.briarproject.bramble.api.sync.MessageId;
+import org.briarproject.briar.android.controller.handler.ExceptionHandler;
+import org.briarproject.briar.android.controller.handler.ResultExceptionHandler;
+import org.briarproject.briar.api.blog.BlogPostHeader;
+
+import java.util.Collection;
+
+import javax.annotation.Nullable;
+
+import androidx.annotation.UiThread;
+
+@NotNullByDefault
+interface BaseController {
+
+	@UiThread
+	void onStart();
+
+	@UiThread
+	void onStop();
+
+	void loadBlogPosts(GroupId g,
+			ResultExceptionHandler<Collection<BlogPostItem>, DbException> handler);
+
+	void loadBlogPost(BlogPostHeader header,
+			ResultExceptionHandler<BlogPostItem, DbException> handler);
+
+	void loadBlogPost(GroupId g, MessageId m,
+			ResultExceptionHandler<BlogPostItem, DbException> handler);
+
+	void repeatPost(BlogPostItem item, @Nullable String comment,
+			ExceptionHandler<DbException> handler);
+
+	@NotNullByDefault
+	interface BlogListener {
+
+		@UiThread
+		void onBlogPostAdded(BlogPostHeader header, boolean local);
+
+		@UiThread
+		void onBlogRemoved();
+	}
+
+}

briar-android/src/main/java/org/briarproject/briar/android/blog/BaseControllerImpl.java

@@ -0,0 +1,209 @@
+package org.briarproject.briar.android.blog;
+
+import org.briarproject.bramble.api.db.DatabaseExecutor;
+import org.briarproject.bramble.api.db.DbException;
+import org.briarproject.bramble.api.event.EventBus;
+import org.briarproject.bramble.api.event.EventListener;
+import org.briarproject.bramble.api.identity.IdentityManager;
+import org.briarproject.bramble.api.identity.LocalAuthor;
+import org.briarproject.bramble.api.lifecycle.LifecycleManager;
+import org.briarproject.bramble.api.nullsafety.MethodsNotNullByDefault;
+import org.briarproject.bramble.api.nullsafety.ParametersNotNullByDefault;
+import org.briarproject.bramble.api.sync.GroupId;
+import org.briarproject.bramble.api.sync.MessageId;
+import org.briarproject.briar.android.controller.DbControllerImpl;
+import org.briarproject.briar.android.controller.handler.ExceptionHandler;
+import org.briarproject.briar.android.controller.handler.ResultExceptionHandler;
+import org.briarproject.briar.api.android.AndroidNotificationManager;
+import org.briarproject.briar.api.blog.Blog;
+import org.briarproject.briar.api.blog.BlogCommentHeader;
+import org.briarproject.briar.api.blog.BlogManager;
+import org.briarproject.briar.api.blog.BlogPostHeader;
+import org.briarproject.briar.util.HtmlUtils;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.Executor;
+import java.util.logging.Logger;
+
+import javax.annotation.Nullable;
+
+import androidx.annotation.CallSuper;
+
+import static java.util.logging.Level.WARNING;
+import static org.briarproject.bramble.util.LogUtils.logDuration;
+import static org.briarproject.bramble.util.LogUtils.logException;
+import static org.briarproject.bramble.util.LogUtils.now;
+import static org.briarproject.briar.util.HtmlUtils.ARTICLE;
+
+@MethodsNotNullByDefault
+@ParametersNotNullByDefault
+abstract class BaseControllerImpl extends DbControllerImpl
+		implements BaseController, EventListener {
+
+	private static final Logger LOG =
+			Logger.getLogger(BaseControllerImpl.class.getName());
+
+	protected final EventBus eventBus;
+	protected final AndroidNotificationManager notificationManager;
+	protected final IdentityManager identityManager;
+	protected final BlogManager blogManager;
+
+	private final Map<MessageId, String> textCache = new ConcurrentHashMap<>();
+	private final Map<MessageId, BlogPostHeader> headerCache =
+			new ConcurrentHashMap<>();
+
+	BaseControllerImpl(@DatabaseExecutor Executor dbExecutor,
+			LifecycleManager lifecycleManager, EventBus eventBus,
+			AndroidNotificationManager notificationManager,
+			IdentityManager identityManager, BlogManager blogManager) {
+		super(dbExecutor, lifecycleManager);
+		this.eventBus = eventBus;
+		this.notificationManager = notificationManager;
+		this.identityManager = identityManager;
+		this.blogManager = blogManager;
+	}
+
+	@Override
+	@CallSuper
+	public void onStart() {
+		eventBus.addListener(this);
+	}
+
+	@Override
+	@CallSuper
+	public void onStop() {
+		eventBus.removeListener(this);
+	}
+
+	@Override
+	public void loadBlogPosts(GroupId groupId,
+			ResultExceptionHandler<Collection<BlogPostItem>, DbException> handler) {
+		runOnDbThread(() -> {
+			try {
+				Collection<BlogPostItem> items = loadItems(groupId);
+				handler.onResult(items);
+			} catch (DbException e) {
+				logException(LOG, WARNING, e);
+				handler.onException(e);
+			}
+		});
+	}
+
+	Collection<BlogPostItem> loadItems(GroupId groupId) throws DbException {
+		long start = now();
+		Collection<BlogPostHeader> headers =
+				blogManager.getPostHeaders(groupId);
+		logDuration(LOG, "Loading headers", start);
+		Collection<BlogPostItem> items = new ArrayList<>(headers.size());
+		start = now();
+		for (BlogPostHeader h : headers) {
+			headerCache.put(h.getId(), h);
+			BlogPostItem item = getItem(h);
+			items.add(item);
+		}
+		logDuration(LOG, "Loading bodies", start);
+		return items;
+	}
+
+	@Override
+	public void loadBlogPost(BlogPostHeader header,
+			ResultExceptionHandler<BlogPostItem, DbException> handler) {
+
+		String text = textCache.get(header.getId());
+		if (text != null) {
+			LOG.info("Loaded text from cache");
+			handler.onResult(new BlogPostItem(header, text));
+			return;
+		}
+		runOnDbThread(() -> {
+			try {
+				long start = now();
+				BlogPostItem item = getItem(header);
+				logDuration(LOG, "Loading text", start);
+				handler.onResult(item);
+			} catch (DbException e) {
+				logException(LOG, WARNING, e);
+				handler.onException(e);
+			}
+		});
+	}
+
+	@Override
+	public void loadBlogPost(GroupId g, MessageId m,
+			ResultExceptionHandler<BlogPostItem, DbException> handler) {
+
+		BlogPostHeader header = headerCache.get(m);
+		if (header != null) {
+			LOG.info("Loaded header from cache");
+			loadBlogPost(header, handler);
+			return;
+		}
+		runOnDbThread(() -> {
+			try {
+				long start = now();
+				BlogPostHeader header1 = getPostHeader(g, m);
+				BlogPostItem item = getItem(header1);
+				logDuration(LOG, "Loading post", start);
+				handler.onResult(item);
+			} catch (DbException e) {
+				logException(LOG, WARNING, e);
+				handler.onException(e);
+			}
+		});
+	}
+
+	@Override
+	public void repeatPost(BlogPostItem item, @Nullable String comment,
+			ExceptionHandler<DbException> handler) {
+		runOnDbThread(() -> {
+			try {
+				LocalAuthor a = identityManager.getLocalAuthor();
+				Blog b = blogManager.getPersonalBlog(a);
+				BlogPostHeader h = item.getHeader();
+				blogManager.addLocalComment(a, b.getId(), comment, h);
+			} catch (DbException e) {
+				logException(LOG, WARNING, e);
+				handler.onException(e);
+			}
+		});
+	}
+
+	private BlogPostHeader getPostHeader(GroupId g, MessageId m)
+			throws DbException {
+		BlogPostHeader header = headerCache.get(m);
+		if (header == null) {
+			header = blogManager.getPostHeader(g, m);
+			headerCache.put(m, header);
+		}
+		return header;
+	}
+
+	@DatabaseExecutor
+	private BlogPostItem getItem(BlogPostHeader h) throws DbException {
+		String text;
+		if (h instanceof BlogCommentHeader) {
+			BlogCommentHeader c = (BlogCommentHeader) h;
+			BlogCommentItem item = new BlogCommentItem(c);
+			text = getPostText(item.getPostHeader().getId());
+			item.setText(text);
+			return item;
+		} else {
+			text = getPostText(h.getId());
+			return new BlogPostItem(h, text);
+		}
+	}
+
+	@DatabaseExecutor
+	private String getPostText(MessageId m) throws DbException {
+		String text = textCache.get(m);
+		if (text == null) {
+			text = HtmlUtils.clean(blogManager.getPostText(m), ARTICLE);
+			textCache.put(m, text);
+		}
+		return text;
+	}
+
+}

briar-android/src/main/java/org/briarproject/briar/android/blog/BasePostFragment.java

@@ -0,0 +1,121 @@
+package org.briarproject.briar.android.blog;
+
+import android.content.Intent;
+import android.os.Bundle;
+import android.os.Handler;
+import android.os.Looper;
+import android.view.LayoutInflater;
+import android.view.View;
+import android.view.ViewGroup;
+import android.widget.ProgressBar;
+
+import org.briarproject.bramble.api.nullsafety.MethodsNotNullByDefault;
+import org.briarproject.bramble.api.nullsafety.ParametersNotNullByDefault;
+import org.briarproject.bramble.api.sync.MessageId;
+import org.briarproject.briar.R;
+import org.briarproject.briar.android.fragment.BaseFragment;
+
+import java.util.logging.Logger;
+
+import javax.annotation.Nullable;
+
+import androidx.annotation.CallSuper;
+import androidx.annotation.UiThread;
+
+import static android.content.Intent.FLAG_ACTIVITY_CLEAR_TOP;
+import static android.view.View.INVISIBLE;
+import static android.view.View.VISIBLE;
+import static java.util.logging.Logger.getLogger;
+import static org.briarproject.briar.android.activity.BriarActivity.GROUP_ID;
+import static org.briarproject.briar.android.util.UiUtils.MIN_DATE_RESOLUTION;
+
+@UiThread
+@MethodsNotNullByDefault
+@ParametersNotNullByDefault
+abstract class BasePostFragment extends BaseFragment {
+
+	static final String POST_ID = "briar.POST_ID";
+
+	private static final Logger LOG =
+			getLogger(BasePostFragment.class.getName());
+
+	private final Handler handler = new Handler(Looper.getMainLooper());
+
+	protected MessageId postId;
+	private ProgressBar progressBar;
+	private BlogPostViewHolder ui;
+	private BlogPostItem post;
+	private Runnable refresher;
+
+	@CallSuper
+	@Nullable
+	@Override
+	public View onCreateView(LayoutInflater inflater,
+			@Nullable ViewGroup container,
+			@Nullable Bundle savedInstanceState) {
+		// retrieve MessageId of blog post from arguments
+		byte[] p = requireArguments().getByteArray(POST_ID);
+		if (p == null) throw new IllegalStateException("No post ID in args");
+		postId = new MessageId(p);
+
+		View view = inflater.inflate(R.layout.fragment_blog_post, container,
+				false);
+		progressBar = view.findViewById(R.id.progressBar);
+		progressBar.setVisibility(VISIBLE);
+		ui = new BlogPostViewHolder(view, true, new OnBlogPostClickListener() {
+			@Override
+			public void onBlogPostClick(BlogPostItem post) {
+				// We're already there
+			}
+
+			@Override
+			public void onAuthorClick(BlogPostItem post) {
+				if (getContext() == null) return;
+				Intent i = new Intent(getContext(), BlogActivity.class);
+				i.putExtra(GROUP_ID, post.getGroupId().getBytes());
+				i.setFlags(FLAG_ACTIVITY_CLEAR_TOP);
+				getContext().startActivity(i);
+			}
+		}, getFragmentManager());
+		return view;
+	}
+
+	@CallSuper
+	@Override
+	public void onStart() {
+		super.onStart();
+		startPeriodicUpdate();
+	}
+
+	@CallSuper
+	@Override
+	public void onStop() {
+		super.onStop();
+		stopPeriodicUpdate();
+	}
+
+	@UiThread
+	protected void onBlogPostLoaded(BlogPostItem post) {
+		progressBar.setVisibility(INVISIBLE);
+		this.post = post;
+		ui.bindItem(post);
+	}
+
+	private void startPeriodicUpdate() {
+		refresher = () -> {
+			LOG.info("Updating Content...");
+			ui.updateDate(post.getTimestamp());
+			handler.postDelayed(refresher, MIN_DATE_RESOLUTION);
+		};
+		LOG.info("Adding Handler Callback");
+		handler.postDelayed(refresher, MIN_DATE_RESOLUTION);
+	}
+
+	private void stopPeriodicUpdate() {
+		if (refresher != null) {
+			LOG.info("Removing Handler Callback");
+			handler.removeCallbacks(refresher);
+		}
+	}
+
+}

briar-android/src/main/java/org/briarproject/briar/android/blog/BaseViewModel.java

@@ -1,199 +0,0 @@
-package org.briarproject.briar.android.blog;
-
-import android.app.Application;
-
-import org.briarproject.bramble.api.db.DatabaseExecutor;
-import org.briarproject.bramble.api.db.DbException;
-import org.briarproject.bramble.api.db.Transaction;
-import org.briarproject.bramble.api.db.TransactionManager;
-import org.briarproject.bramble.api.event.EventBus;
-import org.briarproject.bramble.api.event.EventListener;
-import org.briarproject.bramble.api.identity.IdentityManager;
-import org.briarproject.bramble.api.identity.LocalAuthor;
-import org.briarproject.bramble.api.lifecycle.LifecycleManager;
-import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
-import org.briarproject.bramble.api.sync.GroupId;
-import org.briarproject.bramble.api.sync.MessageId;
-import org.briarproject.bramble.api.system.AndroidExecutor;
-import org.briarproject.briar.android.viewmodel.DbViewModel;
-import org.briarproject.briar.android.viewmodel.LiveResult;
-import org.briarproject.briar.api.android.AndroidNotificationManager;
-import org.briarproject.briar.api.blog.Blog;
-import org.briarproject.briar.api.blog.BlogCommentHeader;
-import org.briarproject.briar.api.blog.BlogManager;
-import org.briarproject.briar.api.blog.BlogPostHeader;
-import org.briarproject.briar.util.HtmlUtils;
-
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.List;
-import java.util.concurrent.Executor;
-import java.util.logging.Logger;
-
-import javax.annotation.Nullable;
-
-import androidx.annotation.UiThread;
-import androidx.lifecycle.LiveData;
-import androidx.lifecycle.MutableLiveData;
-
-import static java.util.logging.Level.WARNING;
-import static java.util.logging.Logger.getLogger;
-import static org.briarproject.bramble.util.LogUtils.logDuration;
-import static org.briarproject.bramble.util.LogUtils.logException;
-import static org.briarproject.bramble.util.LogUtils.now;
-import static org.briarproject.briar.util.HtmlUtils.ARTICLE;
-
-@NotNullByDefault
-abstract class BaseViewModel extends DbViewModel implements EventListener {
-
-	private static final Logger LOG = getLogger(BaseViewModel.class.getName());
-
-	private final EventBus eventBus;
-	protected final IdentityManager identityManager;
-	protected final AndroidNotificationManager notificationManager;
-	protected final BlogManager blogManager;
-
-	protected final MutableLiveData<LiveResult<ListUpdate>> blogPosts =
-			new MutableLiveData<>();
-
-	BaseViewModel(Application application,
-			@DatabaseExecutor Executor dbExecutor,
-			LifecycleManager lifecycleManager,
-			TransactionManager db,
-			AndroidExecutor androidExecutor,
-			EventBus eventBus,
-			IdentityManager identityManager,
-			AndroidNotificationManager notificationManager,
-			BlogManager blogManager) {
-		super(application, dbExecutor, lifecycleManager, db, androidExecutor);
-		this.eventBus = eventBus;
-		this.identityManager = identityManager;
-		this.notificationManager = notificationManager;
-		this.blogManager = blogManager;
-		eventBus.addListener(this);
-	}
-
-	@Override
-	protected void onCleared() {
-		super.onCleared();
-		eventBus.removeListener(this);
-	}
-
-	@DatabaseExecutor
-	protected List<BlogPostItem> loadBlogPosts(Transaction txn, GroupId groupId)
-			throws DbException {
-		long start = now();
-		List<BlogPostHeader> headers =
-				blogManager.getPostHeaders(txn, groupId);
-		logDuration(LOG, "Loading headers", start);
-		List<BlogPostItem> items = new ArrayList<>(headers.size());
-		start = now();
-		for (BlogPostHeader h : headers) {
-			BlogPostItem item = getItem(txn, h);
-			items.add(item);
-		}
-		logDuration(LOG, "Loading bodies", start);
-		return items;
-	}
-
-	@DatabaseExecutor
-	protected BlogPostItem getItem(Transaction txn, BlogPostHeader h)
-			throws DbException {
-		String text;
-		if (h instanceof BlogCommentHeader) {
-			BlogCommentHeader c = (BlogCommentHeader) h;
-			BlogCommentItem item = new BlogCommentItem(c);
-			text = getPostText(txn, item.getPostHeader().getId());
-			item.setText(text);
-			return item;
-		} else {
-			text = getPostText(txn, h.getId());
-			return new BlogPostItem(h, text);
-		}
-	}
-
-	@DatabaseExecutor
-	private String getPostText(Transaction txn, MessageId m)
-			throws DbException {
-		return HtmlUtils.clean(blogManager.getPostText(txn, m), ARTICLE);
-	}
-
-	LiveData<LiveResult<BlogPostItem>> loadBlogPost(GroupId g, MessageId m) {
-		MutableLiveData<LiveResult<BlogPostItem>> result =
-				new MutableLiveData<>();
-		runOnDbThread(true, txn -> {
-			long start = now();
-			BlogPostHeader header = blogManager.getPostHeader(txn, g, m);
-			BlogPostItem item = getItem(txn, header);
-			logDuration(LOG, "Loading post", start);
-			result.postValue(new LiveResult<>(item));
-		}, e -> {
-			logException(LOG, WARNING, e);
-			result.postValue(new LiveResult<>(e));
-		});
-		return result;
-	}
-
-	protected void onBlogPostAdded(BlogPostHeader header, boolean local) {
-		runOnDbThread(true, txn -> {
-			BlogPostItem item = getItem(txn, header);
-			txn.attach(() -> onBlogPostItemAdded(item, local));
-		}, this::handleException);
-	}
-
-	@UiThread
-	private void onBlogPostItemAdded(BlogPostItem item, boolean local) {
-		List<BlogPostItem> items = addListItem(getBlogPostItems(), item);
-		if (items != null) {
-			Collections.sort(items);
-			blogPosts.setValue(new LiveResult<>(new ListUpdate(local, items)));
-		}
-	}
-
-	void repeatPost(BlogPostItem item, @Nullable String comment) {
-		runOnDbThread(() -> {
-			try {
-				LocalAuthor a = identityManager.getLocalAuthor();
-				Blog b = blogManager.getPersonalBlog(a);
-				BlogPostHeader h = item.getHeader();
-				blogManager.addLocalComment(a, b.getId(), comment, h);
-			} catch (DbException e) {
-				handleException(e);
-			}
-		});
-	}
-
-	LiveData<LiveResult<ListUpdate>> getBlogPosts() {
-		return blogPosts;
-	}
-
-	@UiThread
-	protected List<BlogPostItem> getBlogPostItems() {
-		LiveResult<ListUpdate> value = blogPosts.getValue();
-		if (value == null) return null;
-		ListUpdate result = value.getResultOrNull();
-		return result == null ? null : result.getItems();
-	}
-
-	static class ListUpdate {
-
-		@Nullable
-		private final Boolean postAddedWasLocal;
-		private final List<BlogPostItem> items;
-
-		ListUpdate(@Nullable Boolean postAddedWasLocal,
-				List<BlogPostItem> items) {
-			this.postAddedWasLocal = postAddedWasLocal;
-			this.items = items;
-		}
-
-		@Nullable
-		public Boolean getPostAddedWasLocal() {
-			return postAddedWasLocal;
-		}
-
-		public List<BlogPostItem> getItems() {
-			return items;
-		}
-	}
-}

briar-android/src/main/java/org/briarproject/briar/android/blog/BlogActivity.java

@@ -16,9 +16,6 @@ import javax.annotation.Nullable;
 import javax.inject.Inject;
 
 import androidx.appcompat.widget.Toolbar;
-import androidx.lifecycle.ViewModelProvider;
-
-import static java.util.Objects.requireNonNull;
 
 @MethodsNotNullByDefault
 @ParametersNotNullByDefault
@@ -26,16 +23,7 @@ public class BlogActivity extends BriarActivity
 		implements BaseFragmentListener {
 
 	@Inject
-	ViewModelProvider.Factory viewModelFactory;
+	BlogController blogController;
-
-	private BlogViewModel viewModel;
-
-	@Override
-	public void injectActivity(ActivityComponent component) {
-		component.inject(this);
-		viewModel = new ViewModelProvider(this, viewModelFactory)
-				.get(BlogViewModel.class);
-	}
 
 	@Override
 	public void onCreate(@Nullable Bundle state) {
@@ -43,36 +31,32 @@ public class BlogActivity extends BriarActivity
 
 		// GroupId from Intent
 		Intent i = getIntent();
-		GroupId groupId =
+		byte[] b = i.getByteArrayExtra(GROUP_ID);
-				new GroupId(requireNonNull(i.getByteArrayExtra(GROUP_ID)));
+		if (b == null) throw new IllegalStateException("No group ID in intent");
-		viewModel.setGroupId(groupId);
+		GroupId groupId = new GroupId(b);
+		blogController.setGroupId(groupId);
 
 		setContentView(R.layout.activity_fragment_container_toolbar);
 		Toolbar toolbar = setUpCustomToolbar(false);
 
 		// Open Sharing Status on Toolbar click
-		toolbar.setOnClickListener(v -> {
+		if (toolbar != null) {
-			Intent i1 = new Intent(BlogActivity.this,
+			toolbar.setOnClickListener(v -> {
-					BlogSharingStatusActivity.class);
+				Intent i1 = new Intent(BlogActivity.this,
-			i1.putExtra(GROUP_ID, groupId.getBytes());
+						BlogSharingStatusActivity.class);
-			startActivity(i1);
+				i1.putExtra(GROUP_ID, groupId.getBytes());
-		});
+				startActivity(i1);
-
+			});
-		viewModel.getBlog().observe(this, blog ->
+		}
-				setTitle(blog.getBlog().getAuthor().getName())
-		);
-		viewModel.getSharingInfo().observe(this, info ->
-				setToolbarSubTitle(info.total, info.online)
-		);
 
 		if (state == null) {
 			showInitialFragment(BlogFragment.newInstance(groupId));
 		}
 	}
 
-	private void setToolbarSubTitle(int total, int online) {
+	@Override
-		requireNonNull(getSupportActionBar())
+	public void injectActivity(ActivityComponent component) {
-				.setSubtitle(getString(R.string.shared_with, total, online));
+		component.inject(this);
 	}
 
 }

briar-android/src/main/java/org/briarproject/briar/android/blog/BlogCommentItem.java

@@ -8,9 +8,7 @@ import java.util.Collections;
 import java.util.Comparator;
 import java.util.List;
 
-import javax.annotation.concurrent.NotThreadSafe;
+// This class is not thread-safe
-
-@NotThreadSafe
 class BlogCommentItem extends BlogPostItem {
 
 	private static final BlogCommentComparator COMPARATOR =

briar-android/src/main/java/org/briarproject/briar/android/blog/BlogController.java

@@ -0,0 +1,46 @@
+package org.briarproject.briar.android.blog;
+
+import org.briarproject.bramble.api.contact.ContactId;
+import org.briarproject.bramble.api.db.DbException;
+import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
+import org.briarproject.bramble.api.sync.GroupId;
+import org.briarproject.bramble.api.sync.MessageId;
+import org.briarproject.briar.android.controller.handler.ResultExceptionHandler;
+
+import java.util.Collection;
+
+import androidx.annotation.UiThread;
+
+@NotNullByDefault
+public interface BlogController extends BaseController {
+
+	void setGroupId(GroupId g);
+
+	@UiThread
+	void setBlogSharingListener(BlogSharingListener listener);
+
+	@UiThread
+	void unsetBlogSharingListener(BlogSharingListener listener);
+
+	void loadBlogPosts(
+			ResultExceptionHandler<Collection<BlogPostItem>, DbException> handler);
+
+	void loadBlogPost(MessageId m,
+			ResultExceptionHandler<BlogPostItem, DbException> handler);
+
+	void loadBlog(ResultExceptionHandler<BlogItem, DbException> handler);
+
+	void deleteBlog(ResultExceptionHandler<Void, DbException> handler);
+
+	void loadSharingContacts(
+			ResultExceptionHandler<Collection<ContactId>, DbException> handler);
+
+	interface BlogSharingListener extends BlogListener {
+		@UiThread
+		void onBlogInvitationAccepted(ContactId c);
+
+		@UiThread
+		void onBlogLeft(ContactId c);
+	}
+
+}

briar-android/src/main/java/org/briarproject/briar/android/blog/BlogControllerImpl.java

@@ -1,24 +1,24 @@
 package org.briarproject.briar.android.blog;
 
-import android.app.Application;
+import android.app.Activity;
 
 import org.briarproject.bramble.api.contact.Contact;
 import org.briarproject.bramble.api.contact.ContactId;
 import org.briarproject.bramble.api.db.DatabaseExecutor;
 import org.briarproject.bramble.api.db.DbException;
-import org.briarproject.bramble.api.db.TransactionManager;
 import org.briarproject.bramble.api.event.Event;
 import org.briarproject.bramble.api.event.EventBus;
+import org.briarproject.bramble.api.event.EventListener;
 import org.briarproject.bramble.api.identity.IdentityManager;
 import org.briarproject.bramble.api.identity.LocalAuthor;
 import org.briarproject.bramble.api.lifecycle.LifecycleManager;
 import org.briarproject.bramble.api.nullsafety.MethodsNotNullByDefault;
 import org.briarproject.bramble.api.nullsafety.ParametersNotNullByDefault;
 import org.briarproject.bramble.api.sync.GroupId;
+import org.briarproject.bramble.api.sync.MessageId;
 import org.briarproject.bramble.api.sync.event.GroupRemovedEvent;
-import org.briarproject.bramble.api.system.AndroidExecutor;
+import org.briarproject.briar.android.controller.ActivityLifecycleController;
-import org.briarproject.briar.android.sharing.SharingController;
+import org.briarproject.briar.android.controller.handler.ResultExceptionHandler;
-import org.briarproject.briar.android.sharing.SharingController.SharingInfo;
 import org.briarproject.briar.api.android.AndroidNotificationManager;
 import org.briarproject.briar.api.blog.Blog;
 import org.briarproject.briar.api.blog.BlogInvitationResponse;
@@ -35,54 +35,85 @@ import java.util.logging.Logger;
 
 import javax.inject.Inject;
 
-import androidx.annotation.UiThread;
+import androidx.annotation.Nullable;
-import androidx.lifecycle.LiveData;
-import androidx.lifecycle.MutableLiveData;
 
-import static java.util.logging.Logger.getLogger;
+import static java.util.logging.Level.WARNING;
 import static org.briarproject.bramble.util.LogUtils.logDuration;
+import static org.briarproject.bramble.util.LogUtils.logException;
 import static org.briarproject.bramble.util.LogUtils.now;
 
 @MethodsNotNullByDefault
 @ParametersNotNullByDefault
-class BlogViewModel extends BaseViewModel {
+class BlogControllerImpl extends BaseControllerImpl
+		implements ActivityLifecycleController, BlogController, EventListener {
 
-	private static final Logger LOG = getLogger(BlogViewModel.class.getName());
+	private static final Logger LOG =
+			Logger.getLogger(BlogControllerImpl.class.getName());
 
 	private final BlogSharingManager blogSharingManager;
-	private final SharingController sharingController;
 
-	private volatile GroupId groupId;
+	// UI thread
+	@Nullable
+	private BlogSharingListener listener;
 
-	private final MutableLiveData<BlogItem> blog = new MutableLiveData<>();
+	private volatile GroupId groupId = null;
-	private final MutableLiveData<Boolean> blogRemoved =
-			new MutableLiveData<>();
 
 	@Inject
-	BlogViewModel(Application application,
+	BlogControllerImpl(@DatabaseExecutor Executor dbExecutor,
-			@DatabaseExecutor Executor dbExecutor,
+			LifecycleManager lifecycleManager, EventBus eventBus,
-			LifecycleManager lifecycleManager,
-			TransactionManager db,
-			AndroidExecutor androidExecutor,
-			EventBus eventBus,
-			IdentityManager identityManager,
 			AndroidNotificationManager notificationManager,
-			BlogManager blogManager,
+			IdentityManager identityManager, BlogManager blogManager,
-			BlogSharingManager blogSharingManager,
+			BlogSharingManager blogSharingManager) {
-			SharingController sharingController) {
+		super(dbExecutor, lifecycleManager, eventBus, notificationManager,
-		super(application, dbExecutor, lifecycleManager, db, androidExecutor,
+				identityManager, blogManager);
-				eventBus, identityManager, notificationManager, blogManager);
 		this.blogSharingManager = blogSharingManager;
-		this.sharingController = sharingController;
+	}
+
+	@Override
+	public void onActivityCreate(Activity activity) {
+	}
+
+	@Override
+	public void onActivityStart() {
+		super.onStart();
+		notificationManager.blockNotification(groupId);
+		notificationManager.clearBlogPostNotification(groupId);
+	}
+
+	@Override
+	public void onActivityStop() {
+		super.onStop();
+		notificationManager.unblockNotification(groupId);
+	}
+
+	@Override
+	public void onActivityDestroy() {
+	}
+
+	@Override
+	public void setGroupId(GroupId g) {
+		groupId = g;
+	}
+
+	@Override
+	public void setBlogSharingListener(BlogSharingListener listener) {
+		this.listener = listener;
+	}
+
+	@Override
+	public void unsetBlogSharingListener(BlogSharingListener listener) {
+		if (this.listener == listener) this.listener = null;
 	}
 
 	@Override
 	public void eventOccurred(Event e) {
+		if (groupId == null || listener == null)
+			throw new IllegalStateException();
 		if (e instanceof BlogPostAddedEvent) {
 			BlogPostAddedEvent b = (BlogPostAddedEvent) e;
 			if (b.getGroupId().equals(groupId)) {
 				LOG.info("Blog post added");
-				onBlogPostAdded(b.getHeader(), b.isLocal());
+				listener.onBlogPostAdded(b.getHeader(), b.isLocal());
 			}
 		} else if (e instanceof BlogInvitationResponseReceivedEvent) {
 			BlogInvitationResponseReceivedEvent b =
@@ -90,36 +121,41 @@ class BlogViewModel extends BaseViewModel {
 			BlogInvitationResponse r = b.getMessageHeader();
 			if (r.getShareableId().equals(groupId) && r.wasAccepted()) {
 				LOG.info("Blog invitation accepted");
-				sharingController.add(b.getContactId());
+				listener.onBlogInvitationAccepted(b.getContactId());
 			}
 		} else if (e instanceof ContactLeftShareableEvent) {
 			ContactLeftShareableEvent s = (ContactLeftShareableEvent) e;
 			if (s.getGroupId().equals(groupId)) {
 				LOG.info("Blog left by contact");
-				sharingController.remove(s.getContactId());
+				listener.onBlogLeft(s.getContactId());
 			}
 		} else if (e instanceof GroupRemovedEvent) {
 			GroupRemovedEvent g = (GroupRemovedEvent) e;
 			if (g.getGroup().getId().equals(groupId)) {
 				LOG.info("Blog removed");
-				blogRemoved.setValue(true);
+				listener.onBlogRemoved();
 			}
 		}
 	}
 
-	/**
+	@Override
-	 * Set this before calling any other methods.
+	public void loadBlogPosts(
-	 */
+			ResultExceptionHandler<Collection<BlogPostItem>, DbException> handler) {
-	@UiThread
+		if (groupId == null) throw new IllegalStateException();
-	public void setGroupId(GroupId groupId) {
+		loadBlogPosts(groupId, handler);
-		if (this.groupId == groupId) return; // configuration change
-		this.groupId = groupId;
-		loadBlog(groupId);
-		loadBlogPosts(groupId);
-		loadSharingContacts(groupId);
 	}
 
-	private void loadBlog(GroupId groupId) {
+	@Override
+	public void loadBlogPost(MessageId m,
+			ResultExceptionHandler<BlogPostItem, DbException> handler) {
+		if (groupId == null) throw new IllegalStateException();
+		loadBlogPost(groupId, m, handler);
+	}
+
+	@Override
+	public void loadBlog(
+			ResultExceptionHandler<BlogItem, DbException> handler) {
+		if (groupId == null) throw new IllegalStateException();
 		runOnDbThread(() -> {
 			try {
 				long start = now();
@@ -127,65 +163,50 @@ class BlogViewModel extends BaseViewModel {
 				Blog b = blogManager.getBlog(groupId);
 				boolean ours = a.getId().equals(b.getAuthor().getId());
 				boolean removable = blogManager.canBeRemoved(b);
-				blog.postValue(new BlogItem(b, ours, removable));
+				BlogItem blog = new BlogItem(b, ours, removable);
 				logDuration(LOG, "Loading blog", start);
+				handler.onResult(blog);
 			} catch (DbException e) {
-				handleException(e);
+				logException(LOG, WARNING, e);
+				handler.onException(e);
 			}
 		});
 	}
 
-	void blockAndClearNotifications() {
+	@Override
-		notificationManager.blockNotification(groupId);
+	public void deleteBlog(ResultExceptionHandler<Void, DbException> handler) {
-		notificationManager.clearBlogPostNotification(groupId);
+		if (groupId == null) throw new IllegalStateException();
-	}
-
-	void unblockNotifications() {
-		notificationManager.unblockNotification(groupId);
-	}
-
-	private void loadBlogPosts(GroupId groupId) {
-		loadList(txn -> new ListUpdate(null, loadBlogPosts(txn, groupId)),
-				blogPosts::setValue);
-	}
-
-	private void loadSharingContacts(GroupId groupId) {
-		runOnDbThread(true, txn -> {
-			Collection<Contact> contacts =
-					blogSharingManager.getSharedWith(txn, groupId);
-			txn.attach(() -> onSharingContactsLoaded(contacts));
-		}, this::handleException);
-	}
-
-	@UiThread
-	private void onSharingContactsLoaded(Collection<Contact> contacts) {
-		Collection<ContactId> contactIds = new ArrayList<>(contacts.size());
-		for (Contact c : contacts) contactIds.add(c.getId());
-		sharingController.addAll(contactIds);
-	}
-
-	void deleteBlog() {
 		runOnDbThread(() -> {
 			try {
 				long start = now();
 				Blog b = blogManager.getBlog(groupId);
 				blogManager.removeBlog(b);
 				logDuration(LOG, "Removing blog", start);
+				handler.onResult(null);
 			} catch (DbException e) {
-				handleException(e);
+				logException(LOG, WARNING, e);
+				handler.onException(e);
 			}
 		});
 	}
 
-	LiveData<BlogItem> getBlog() {
+	@Override
-		return blog;
+	public void loadSharingContacts(
+			ResultExceptionHandler<Collection<ContactId>, DbException> handler) {
+		if (groupId == null) throw new IllegalStateException();
+		runOnDbThread(() -> {
+			try {
+				Collection<Contact> contacts =
+						blogSharingManager.getSharedWith(groupId);
+				Collection<ContactId> contactIds =
+						new ArrayList<>(contacts.size());
+				for (Contact c : contacts) contactIds.add(c.getId());
+				handler.onResult(contactIds);
+			} catch (DbException e) {
+				logException(LOG, WARNING, e);
+				handler.onException(e);
+			}
+		});
 	}
 
-	LiveData<Boolean> getBlogRemoved() {
-		return blogRemoved;
-	}
-
-	LiveData<SharingInfo> getSharingInfo() {
-		return sharingController.getSharingInfo();
-	}
 }

briar-android/src/main/java/org/briarproject/briar/android/blog/BlogFragment.java

@@ -1,7 +1,9 @@
 package org.briarproject.briar.android.blog;
 
+import android.content.DialogInterface;
 import android.content.Intent;
 import android.os.Bundle;
+import android.os.Parcelable;
 import android.view.LayoutInflater;
 import android.view.Menu;
 import android.view.MenuInflater;
@@ -10,25 +12,33 @@ import android.view.View;
 import android.view.ViewGroup;
 import android.widget.Toast;
 
+import org.briarproject.bramble.api.contact.ContactId;
+import org.briarproject.bramble.api.db.DbException;
+import org.briarproject.bramble.api.identity.Author;
 import org.briarproject.bramble.api.nullsafety.MethodsNotNullByDefault;
 import org.briarproject.bramble.api.nullsafety.ParametersNotNullByDefault;
 import org.briarproject.bramble.api.sync.GroupId;
 import org.briarproject.briar.R;
 import org.briarproject.briar.android.activity.ActivityComponent;
-import org.briarproject.briar.android.blog.BaseViewModel.ListUpdate;
+import org.briarproject.briar.android.activity.BriarActivity;
+import org.briarproject.briar.android.blog.BlogController.BlogSharingListener;
+import org.briarproject.briar.android.controller.SharingController;
+import org.briarproject.briar.android.controller.handler.UiResultExceptionHandler;
 import org.briarproject.briar.android.fragment.BaseFragment;
 import org.briarproject.briar.android.sharing.BlogSharingStatusActivity;
 import org.briarproject.briar.android.sharing.ShareBlogActivity;
 import org.briarproject.briar.android.util.BriarSnackbarBuilder;
 import org.briarproject.briar.android.view.BriarRecyclerView;
-import org.briarproject.briar.android.widget.LinkDialogFragment;
+import org.briarproject.briar.api.blog.BlogPostHeader;
+
+import java.util.Collection;
 
 import javax.inject.Inject;
 
 import androidx.annotation.Nullable;
 import androidx.annotation.UiThread;
+import androidx.appcompat.app.ActionBar;
 import androidx.appcompat.app.AlertDialog;
-import androidx.lifecycle.ViewModelProvider;
 import androidx.recyclerview.widget.LinearLayoutManager;
 import androidx.recyclerview.widget.RecyclerView.LayoutManager;
 
@@ -39,22 +49,30 @@ import static com.google.android.material.snackbar.Snackbar.LENGTH_LONG;
 import static org.briarproject.briar.android.activity.BriarActivity.GROUP_ID;
 import static org.briarproject.briar.android.activity.RequestCodes.REQUEST_SHARE_BLOG;
 import static org.briarproject.briar.android.activity.RequestCodes.REQUEST_WRITE_BLOG_POST;
+import static org.briarproject.briar.android.controller.SharingController.SharingListener;
 
 @UiThread
 @MethodsNotNullByDefault
 @ParametersNotNullByDefault
 public class BlogFragment extends BaseFragment
-		implements OnBlogPostClickListener {
+		implements BlogSharingListener, SharingListener,
+		OnBlogPostClickListener {
 
 	private final static String TAG = BlogFragment.class.getName();
 
 	@Inject
-	ViewModelProvider.Factory viewModelFactory;
+	BlogController blogController;
+	@Inject
+	SharingController sharingController;
+	@Nullable
+	private Parcelable layoutManagerState;
 
 	private GroupId groupId;
-	private BlogViewModel viewModel;
+	private BlogPostAdapter adapter;
-	private final BlogPostAdapter adapter = new BlogPostAdapter(false, this);
+	private LayoutManager layoutManager;
 	private BriarRecyclerView list;
+	private MenuItem writeButton, deleteButton;
+	private boolean isMyBlog = false, canDeleteBlog = false;
 
 	static BlogFragment newInstance(GroupId groupId) {
 		BlogFragment f = new BlogFragment();
@@ -69,8 +87,8 @@ public class BlogFragment extends BaseFragment
 	@Override
 	public void injectFragment(ActivityComponent component) {
 		component.inject(this);
-		viewModel = new ViewModelProvider(requireActivity(), viewModelFactory)
+		blogController.setBlogSharingListener(this);
-				.get(BlogViewModel.class);
+		sharingController.setSharingListener(this);
 	}
 
 	@Nullable
@@ -85,75 +103,95 @@ public class BlogFragment extends BaseFragment
 
 		View v = inflater.inflate(R.layout.fragment_blog, container, false);
 
+		adapter = new BlogPostAdapter(requireActivity(), this,
+				getFragmentManager());
 		list = v.findViewById(R.id.postList);
-		LayoutManager layoutManager = new LinearLayoutManager(getActivity());
+		layoutManager = new LinearLayoutManager(getActivity());
 		list.setLayoutManager(layoutManager);
 		list.setAdapter(adapter);
 		list.showProgressBar();
 		list.setEmptyText(getString(R.string.blogs_other_blog_empty_state));
 
-		viewModel.getBlogPosts().observe(getViewLifecycleOwner(), result ->
+		if (savedInstanceState != null) {
-				result.onError(this::handleException)
+			layoutManagerState =
-						.onSuccess(this::onBlogPostsLoaded)
+					savedInstanceState.getParcelable("layoutManager");
-		);
+		}
-		viewModel.getBlogRemoved().observe(getViewLifecycleOwner(), removed -> {
+
-			if (removed) finish();
-		});
 		return v;
 	}
 
 	@Override
 	public void onStart() {
 		super.onStart();
-		viewModel.blockAndClearNotifications();
+		sharingController.onStart();
+		loadBlog();
+		loadSharedContacts();
+		loadBlogPosts(false);
 		list.startPeriodicUpdate();
 	}
 
 	@Override
 	public void onStop() {
 		super.onStop();
-		viewModel.unblockNotifications();
+		sharingController.onStop();
 		list.stopPeriodicUpdate();
 	}
 
+	@Override
+	public void onDestroy() {
+		super.onDestroy();
+		blogController.unsetBlogSharingListener(this);
+		sharingController.unsetSharingListener(this);
+	}
+
+	@Override
+	public void onSaveInstanceState(Bundle outState) {
+		super.onSaveInstanceState(outState);
+		if (layoutManager != null) {
+			layoutManagerState = layoutManager.onSaveInstanceState();
+			outState.putParcelable("layoutManager", layoutManagerState);
+		}
+	}
+
 	@Override
 	public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
 		inflater.inflate(R.menu.blogs_blog_actions, menu);
-		MenuItem writeButton = menu.findItem(R.id.action_write_blog_post);
+		writeButton = menu.findItem(R.id.action_write_blog_post);
-		MenuItem deleteButton = menu.findItem(R.id.action_blog_delete);
+		if (isMyBlog) writeButton.setVisible(true);
-		viewModel.getBlog().observe(getViewLifecycleOwner(), blog -> {
+		deleteButton = menu.findItem(R.id.action_blog_delete);
-			if (blog.isOurs()) writeButton.setVisible(true);
+		if (canDeleteBlog) deleteButton.setEnabled(true);
-			if (blog.canBeRemoved()) deleteButton.setEnabled(true);
+
-		});
 		super.onCreateOptionsMenu(menu, inflater);
 	}
 
 	@Override
 	public boolean onOptionsItemSelected(MenuItem item) {
-		int itemId = item.getItemId();
+		switch (item.getItemId()) {
-		if (itemId == R.id.action_write_blog_post) {
+			case R.id.action_write_blog_post:
-			Intent i = new Intent(getActivity(), WriteBlogPostActivity.class);
+				Intent i = new Intent(getActivity(),
-			i.putExtra(GROUP_ID, groupId.getBytes());
+						WriteBlogPostActivity.class);
-			startActivityForResult(i, REQUEST_WRITE_BLOG_POST);
+				i.putExtra(GROUP_ID, groupId.getBytes());
-			return true;
+				startActivityForResult(i, REQUEST_WRITE_BLOG_POST);
-		} else if (itemId == R.id.action_blog_share) {
+				return true;
-			Intent i = new Intent(getActivity(), ShareBlogActivity.class);
+			case R.id.action_blog_share:
-			i.setFlags(FLAG_ACTIVITY_CLEAR_TOP);
+				Intent i2 = new Intent(getActivity(), ShareBlogActivity.class);
-			i.putExtra(GROUP_ID, groupId.getBytes());
+				i2.setFlags(FLAG_ACTIVITY_CLEAR_TOP);
-			startActivityForResult(i, REQUEST_SHARE_BLOG);
+				i2.putExtra(GROUP_ID, groupId.getBytes());
-			return true;
+				startActivityForResult(i2, REQUEST_SHARE_BLOG);
-		} else if (itemId == R.id.action_blog_sharing_status) {
+				return true;
-			Intent i =
+			case R.id.action_blog_sharing_status:
-					new Intent(getActivity(), BlogSharingStatusActivity.class);
+				Intent i3 = new Intent(getActivity(),
-			i.setFlags(FLAG_ACTIVITY_CLEAR_TOP);
+						BlogSharingStatusActivity.class);
-			i.putExtra(GROUP_ID, groupId.getBytes());
+				i3.setFlags(FLAG_ACTIVITY_CLEAR_TOP);
-			startActivity(i);
+				i3.putExtra(GROUP_ID, groupId.getBytes());
-			return true;
+				startActivity(i3);
-		} else if (itemId == R.id.action_blog_delete) {
+				return true;
-			showDeleteDialog();
+			case R.id.action_blog_delete:
-			return true;
+				showDeleteDialog();
+				return true;
+			default:
+				return super.onOptionsItemSelected(item);
 		}
-		return super.onOptionsItemSelected(item);
 	}
 
 	@Override
@@ -163,6 +201,7 @@ public class BlogFragment extends BaseFragment
 
 		if (request == REQUEST_WRITE_BLOG_POST && result == RESULT_OK) {
 			displaySnackbar(R.string.blogs_blog_post_created, true);
+			loadBlogPosts(true);
 		} else if (request == REQUEST_SHARE_BLOG && result == RESULT_OK) {
 			displaySnackbar(R.string.blogs_sharing_snackbar, false);
 		}
@@ -173,25 +212,35 @@ public class BlogFragment extends BaseFragment
 		return TAG;
 	}
 
-	private void onBlogPostsLoaded(ListUpdate update) {
+	@Override
-		adapter.submitList(update.getItems(), () -> {
+	public void onBlogPostAdded(BlogPostHeader header, boolean local) {
-			Boolean wasLocal = update.getPostAddedWasLocal();
+		blogController.loadBlogPost(header,
-			if (wasLocal != null && wasLocal) {
+				new UiResultExceptionHandler<BlogPostItem, DbException>(
-				list.scrollToPosition(0);
+						this) {
-				displaySnackbar(R.string.blogs_blog_post_created,
+					@Override
-						false);
+					public void onResultUi(BlogPostItem post) {
-			} else if (wasLocal != null) {
+						adapter.add(post);
-				displaySnackbar(R.string.blogs_blog_post_received,
+						if (local) {
-						true);
+							list.scrollToPosition(0);
-			}
+							displaySnackbar(R.string.blogs_blog_post_created,
-			list.showData();
+									false);
-		});
+						} else {
+							displaySnackbar(R.string.blogs_blog_post_received,
+									true);
+						}
+					}
+
+					@Override
+					public void onExceptionUi(DbException exception) {
+						handleException(exception);
+					}
+				}
+		);
 	}
 
 	@Override
 	public void onBlogPostClick(BlogPostItem post) {
-		BlogPostFragment f =
+		BlogPostFragment f = BlogPostFragment.newInstance(post.getId());
-				BlogPostFragment.newInstance(groupId, post.getId(), false);
 		showNextFragment(f);
 	}
 
@@ -207,10 +256,111 @@ public class BlogFragment extends BaseFragment
 		getContext().startActivity(i);
 	}
 
+	private void loadBlogPosts(boolean reload) {
+		blogController.loadBlogPosts(
+				new UiResultExceptionHandler<Collection<BlogPostItem>,
+						DbException>(this) {
+					@Override
+					public void onResultUi(Collection<BlogPostItem> posts) {
+						if (posts.isEmpty()) {
+							list.showData();
+						} else {
+							adapter.addAll(posts);
+							if (reload || layoutManagerState == null) {
+								list.scrollToPosition(0);
+							} else {
+								layoutManager.onRestoreInstanceState(
+										layoutManagerState);
+							}
+						}
+					}
+
+					@Override
+					public void onExceptionUi(DbException exception) {
+						handleException(exception);
+					}
+				});
+	}
+
+	private void loadBlog() {
+		blogController.loadBlog(
+				new UiResultExceptionHandler<BlogItem, DbException>(this) {
+					@Override
+					public void onResultUi(BlogItem blog) {
+						setToolbarTitle(blog.getBlog().getAuthor());
+						if (blog.isOurs())
+							showWriteButton();
+						if (blog.canBeRemoved())
+							enableDeleteButton();
+					}
+
+					@Override
+					public void onExceptionUi(DbException exception) {
+						handleException(exception);
+					}
+				});
+	}
+
+	private void setToolbarTitle(Author a) {
+		getActivity().setTitle(a.getName());
+	}
+
+	private void loadSharedContacts() {
+		blogController.loadSharingContacts(
+				new UiResultExceptionHandler<Collection<ContactId>,
+						DbException>(this) {
+					@Override
+					public void onResultUi(Collection<ContactId> contacts) {
+						sharingController.addAll(contacts);
+						int online = sharingController.getOnlineCount();
+						setToolbarSubTitle(contacts.size(), online);
+					}
+
+					@Override
+					public void onExceptionUi(DbException exception) {
+						handleException(exception);
+					}
+				});
+	}
+
 	@Override
-	public void onLinkClick(String url) {
+	public void onBlogInvitationAccepted(ContactId c) {
-		LinkDialogFragment f = LinkDialogFragment.newInstance(url);
+		sharingController.add(c);
-		f.show(getParentFragmentManager(), f.getUniqueTag());
+		setToolbarSubTitle(sharingController.getTotalCount(),
+				sharingController.getOnlineCount());
+	}
+
+	@Override
+	public void onBlogLeft(ContactId c) {
+		sharingController.remove(c);
+		setToolbarSubTitle(sharingController.getTotalCount(),
+				sharingController.getOnlineCount());
+	}
+
+	@Override
+	public void onSharingInfoUpdated(int total, int online) {
+		setToolbarSubTitle(total, online);
+	}
+
+	private void setToolbarSubTitle(int total, int online) {
+		ActionBar actionBar =
+				((BriarActivity) getActivity()).getSupportActionBar();
+		if (actionBar != null) {
+			actionBar.setSubtitle(
+					getString(R.string.shared_with, total, online));
+		}
+	}
+
+	private void showWriteButton() {
+		isMyBlog = true;
+		if (writeButton != null)
+			writeButton.setVisible(true);
+	}
+
+	private void enableDeleteButton() {
+		canDeleteBlog = true;
+		if (deleteButton != null)
+			deleteButton.setEnabled(true);
 	}
 
 	private void displaySnackbar(int stringId, boolean scroll) {
@@ -223,21 +373,38 @@ public class BlogFragment extends BaseFragment
 	}
 
 	private void showDeleteDialog() {
-		AlertDialog.Builder builder = new AlertDialog.Builder(requireContext(),
+		DialogInterface.OnClickListener okListener =
+				(dialog, which) -> deleteBlog();
+		AlertDialog.Builder builder = new AlertDialog.Builder(getActivity(),
 				R.style.BriarDialogTheme);
 		builder.setTitle(getString(R.string.blogs_remove_blog));
 		builder.setMessage(
 				getString(R.string.blogs_remove_blog_dialog_message));
 		builder.setPositiveButton(R.string.cancel, null);
-		builder.setNegativeButton(R.string.blogs_remove_blog_ok,
+		builder.setNegativeButton(R.string.blogs_remove_blog_ok, okListener);
-				(dialog, which) -> deleteBlog());
 		builder.show();
 	}
 
 	private void deleteBlog() {
-		viewModel.deleteBlog();
+		blogController.deleteBlog(
-		Toast.makeText(getActivity(), R.string.blogs_blog_removed, LENGTH_SHORT)
+				new UiResultExceptionHandler<Void, DbException>(this) {
-				.show();
+					@Override
+					public void onResultUi(Void result) {
+						Toast.makeText(getActivity(),
+								R.string.blogs_blog_removed, LENGTH_SHORT)
+								.show();
+						finish();
+					}
+
+					@Override
+					public void onExceptionUi(DbException exception) {
+						handleException(exception);
+					}
+				});
+	}
+
+	@Override
+	public void onBlogRemoved() {
 		finish();
 	}
 

briar-android/src/main/java/org/briarproject/briar/android/blog/BlogModule.java

@@ -1,23 +1,35 @@
 package org.briarproject.briar.android.blog;
 
-import org.briarproject.briar.android.viewmodel.ViewModelKey;
+import org.briarproject.briar.android.activity.ActivityScope;
+import org.briarproject.briar.android.activity.BaseActivity;
+import org.briarproject.briar.android.controller.SharingController;
+import org.briarproject.briar.android.controller.SharingControllerImpl;
 
-import androidx.lifecycle.ViewModel;
-import dagger.Binds;
 import dagger.Module;
-import dagger.multibindings.IntoMap;
+import dagger.Provides;
 
 @Module
-public interface BlogModule {
+public class BlogModule {
 
-	@Binds
+	@ActivityScope
-	@IntoMap
+	@Provides
-	@ViewModelKey(FeedViewModel.class)
+	BlogController provideBlogController(BaseActivity activity,
-	ViewModel bindFeedViewModel(FeedViewModel feedViewModel);
+			BlogControllerImpl blogController) {
+		activity.addLifecycleController(blogController);
+		return blogController;
+	}
 
-	@Binds
+	@ActivityScope
-	@IntoMap
+	@Provides
-	@ViewModelKey(BlogViewModel.class)
+	FeedController provideFeedController(FeedControllerImpl feedController) {
-	ViewModel bindBlogViewModel(BlogViewModel blogViewModel);
+		return feedController;
+	}
+
+	@ActivityScope
+	@Provides
+	SharingController provideSharingController(
+			SharingControllerImpl sharingController) {
+		return sharingController;
+	}
 
 }

briar-android/src/main/java/org/briarproject/briar/android/blog/BlogPostAdapter.java

@@ -1,5 +1,6 @@
 package org.briarproject.briar.android.blog;
 
+import android.content.Context;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
@@ -7,44 +8,52 @@ import android.view.ViewGroup;
 import org.briarproject.bramble.api.nullsafety.MethodsNotNullByDefault;
 import org.briarproject.bramble.api.nullsafety.ParametersNotNullByDefault;
 import org.briarproject.briar.R;
+import org.briarproject.briar.android.util.BriarAdapter;
 
-import androidx.recyclerview.widget.DiffUtil;
+import androidx.annotation.Nullable;
-import androidx.recyclerview.widget.ListAdapter;
+import androidx.fragment.app.FragmentManager;
 
 @MethodsNotNullByDefault
 @ParametersNotNullByDefault
-class BlogPostAdapter extends ListAdapter<BlogPostItem, BlogPostViewHolder> {
+class BlogPostAdapter extends BriarAdapter<BlogPostItem, BlogPostViewHolder> {
 
-	private final boolean authorClickable;
 	private final OnBlogPostClickListener listener;
+	@Nullable
+	private final FragmentManager fragmentManager;
 
-	BlogPostAdapter(boolean authorClickable, OnBlogPostClickListener listener) {
+	BlogPostAdapter(Context ctx, OnBlogPostClickListener listener,
-		super(new DiffUtil.ItemCallback<BlogPostItem>() {
+			@Nullable FragmentManager fragmentManager) {
-			@Override
+		super(ctx, BlogPostItem.class);
-			public boolean areItemsTheSame(BlogPostItem a, BlogPostItem b) {
-				return a.getId().equals(b.getId());
-			}
-
-			@Override
-			public boolean areContentsTheSame(BlogPostItem a, BlogPostItem b) {
-				return a.isRead() == b.isRead();
-			}
-		});
-		this.authorClickable = authorClickable;
 		this.listener = listener;
+		this.fragmentManager = fragmentManager;
 	}
 
 	@Override
 	public BlogPostViewHolder onCreateViewHolder(ViewGroup parent,
 			int viewType) {
-		View v = LayoutInflater.from(parent.getContext()).inflate(
+		View v = LayoutInflater.from(ctx).inflate(
 				R.layout.list_item_blog_post, parent, false);
-		return new BlogPostViewHolder(v, false, listener, authorClickable);
+		return new BlogPostViewHolder(v, false, listener, fragmentManager);
 	}
 
 	@Override
 	public void onBindViewHolder(BlogPostViewHolder ui, int position) {
-		ui.bindItem(getItem(position));
+		ui.bindItem(getItemAt(position));
+	}
+
+	@Override
+	public int compare(BlogPostItem a, BlogPostItem b) {
+		return a.compareTo(b);
+	}
+
+	@Override
+	public boolean areContentsTheSame(BlogPostItem a, BlogPostItem b) {
+		return a.isRead() == b.isRead();
+	}
+
+	@Override
+	public boolean areItemsTheSame(BlogPostItem a, BlogPostItem b) {
+		return a.getId().equals(b.getId());
 	}
 
 }

briar-android/src/main/java/org/briarproject/briar/android/blog/BlogPostFragment.java

@@ -1,163 +1,76 @@
 package org.briarproject.briar.android.blog;
 
-import android.content.Intent;
 import android.os.Bundle;
-import android.os.Handler;
-import android.os.Looper;
-import android.view.LayoutInflater;
-import android.view.View;
-import android.view.ViewGroup;
-import android.widget.ProgressBar;
 
+import org.briarproject.bramble.api.db.DbException;
 import org.briarproject.bramble.api.nullsafety.MethodsNotNullByDefault;
 import org.briarproject.bramble.api.nullsafety.ParametersNotNullByDefault;
-import org.briarproject.bramble.api.sync.GroupId;
 import org.briarproject.bramble.api.sync.MessageId;
-import org.briarproject.briar.R;
 import org.briarproject.briar.android.activity.ActivityComponent;
-import org.briarproject.briar.android.fragment.BaseFragment;
+import org.briarproject.briar.android.blog.BaseController.BlogListener;
-import org.briarproject.briar.android.widget.LinkDialogFragment;
+import org.briarproject.briar.android.controller.handler.UiResultExceptionHandler;
+import org.briarproject.briar.api.blog.BlogPostHeader;
 
-import java.util.logging.Logger;
-
-import javax.annotation.Nullable;
 import javax.inject.Inject;
 
 import androidx.annotation.UiThread;
-import androidx.lifecycle.LifecycleOwner;
-import androidx.lifecycle.ViewModelProvider;
-
-import static android.content.Intent.FLAG_ACTIVITY_CLEAR_TOP;
-import static android.view.View.INVISIBLE;
-import static android.view.View.VISIBLE;
-import static java.util.Objects.requireNonNull;
-import static java.util.logging.Logger.getLogger;
-import static org.briarproject.briar.android.activity.BriarActivity.GROUP_ID;
-import static org.briarproject.briar.android.util.UiUtils.MIN_DATE_RESOLUTION;
 
+@UiThread
 @MethodsNotNullByDefault
 @ParametersNotNullByDefault
-public class BlogPostFragment extends BaseFragment
+public class BlogPostFragment extends BasePostFragment implements BlogListener {
-		implements OnBlogPostClickListener {
 
 	private static final String TAG = BlogPostFragment.class.getName();
-	private static final Logger LOG = getLogger(TAG);
-
-	static final String POST_ID = "briar.POST_ID";
-	static final String IS_FEED = "briar.IS_FEED";
-
-	protected BlogViewModel viewModel;
-	private final Handler handler = new Handler(Looper.getMainLooper());
-
-	private ProgressBar progressBar;
-	private BlogPostViewHolder ui;
-	private BlogPostItem post;
-	private Runnable refresher;
 
 	@Inject
-	ViewModelProvider.Factory viewModelFactory;
+	BlogController blogController;
 
-	static BlogPostFragment newInstance(GroupId blogId, MessageId postId,
+	static BlogPostFragment newInstance(MessageId postId) {
-			boolean isFeed) {
 		BlogPostFragment f = new BlogPostFragment();
+
 		Bundle bundle = new Bundle();
-		bundle.putByteArray(GROUP_ID, blogId.getBytes());
 		bundle.putByteArray(POST_ID, postId.getBytes());
-		bundle.putBoolean(IS_FEED, isFeed);
+
 		f.setArguments(bundle);
 		return f;
 	}
 
-	@Override
-	public void injectFragment(ActivityComponent component) {
-		component.inject(this);
-		viewModel = new ViewModelProvider(requireActivity(), viewModelFactory)
-				.get(BlogViewModel.class);
-	}
-
-	@Nullable
-	@Override
-	public View onCreateView(LayoutInflater inflater,
-			@Nullable ViewGroup container,
-			@Nullable Bundle savedInstanceState) {
-		Bundle args = requireArguments();
-		GroupId groupId =
-				new GroupId(requireNonNull(args.getByteArray(GROUP_ID)));
-		MessageId postId =
-				new MessageId(requireNonNull(args.getByteArray(POST_ID)));
-		boolean isFeed = args.getBoolean(IS_FEED);
-
-		View view = inflater.inflate(R.layout.fragment_blog_post, container,
-				false);
-		progressBar = view.findViewById(R.id.progressBar);
-		progressBar.setVisibility(VISIBLE);
-		ui = new BlogPostViewHolder(view, true, this, isFeed);
-		LifecycleOwner owner = getViewLifecycleOwner();
-		viewModel.loadBlogPost(groupId, postId).observe(owner, result ->
-				result.onError(this::handleException)
-						.onSuccess(this::onBlogPostLoaded)
-		);
-		return view;
-	}
-
-	@Override
-	public void onStart() {
-		super.onStart();
-		startPeriodicUpdate();
-	}
-
-	@Override
-	public void onStop() {
-		super.onStop();
-		stopPeriodicUpdate();
-	}
-
-	@UiThread
-	private void onBlogPostLoaded(BlogPostItem post) {
-		progressBar.setVisibility(INVISIBLE);
-		this.post = post;
-		ui.bindItem(post);
-	}
-
-	@Override
-	public void onBlogPostClick(BlogPostItem post) {
-		// We're already there
-	}
-
-	@Override
-	public void onAuthorClick(BlogPostItem post) {
-		Intent i = new Intent(requireContext(), BlogActivity.class);
-		i.putExtra(GROUP_ID, post.getGroupId().getBytes());
-		i.setFlags(FLAG_ACTIVITY_CLEAR_TOP);
-		requireContext().startActivity(i);
-	}
-
-	@Override
-	public void onLinkClick(String url) {
-		LinkDialogFragment f = LinkDialogFragment.newInstance(url);
-		f.show(getParentFragmentManager(), f.getUniqueTag());
-	}
-
-	private void startPeriodicUpdate() {
-		refresher = () -> {
-			LOG.info("Updating Content...");
-			ui.updateDate(post.getTimestamp());
-			handler.postDelayed(refresher, MIN_DATE_RESOLUTION);
-		};
-		LOG.info("Adding Handler Callback");
-		handler.postDelayed(refresher, MIN_DATE_RESOLUTION);
-	}
-
-	private void stopPeriodicUpdate() {
-		if (refresher != null) {
-			LOG.info("Removing Handler Callback");
-			handler.removeCallbacks(refresher);
-		}
-	}
-
 	@Override
 	public String getUniqueTag() {
 		return TAG;
 	}
 
+	@Override
+	public void injectFragment(ActivityComponent component) {
+		component.inject(this);
+	}
+
+	@Override
+	public void onStart() {
+		super.onStart();
+		blogController.loadBlogPost(postId,
+				new UiResultExceptionHandler<BlogPostItem, DbException>(
+						this) {
+					@Override
+					public void onResultUi(BlogPostItem post) {
+						onBlogPostLoaded(post);
+					}
+
+					@Override
+					public void onExceptionUi(DbException exception) {
+						handleException(exception);
+					}
+				});
+	}
+
+	@Override
+	public void onBlogPostAdded(BlogPostHeader header, boolean local) {
+		// doesn't matter here
+	}
+
+	@Override
+	public void onBlogRemoved() {
+		finish();
+	}
+
 }

briar-android/src/main/java/org/briarproject/briar/android/blog/BlogPostItem.java

@@ -17,7 +17,7 @@ public class BlogPostItem implements Comparable<BlogPostItem> {
 	private final BlogPostHeader header;
 	@Nullable
 	protected String text;
-	private final boolean read;
+	private boolean read;
 
 	BlogPostItem(BlogPostHeader header, @Nullable String text) {
 		this.header = header;
@@ -74,6 +74,9 @@ public class BlogPostItem implements Comparable<BlogPostItem> {
 
 	protected static int compare(BlogPostHeader h1, BlogPostHeader h2) {
 		// The newest post comes first
-		return Long.compare(h2.getTimeReceived(), h1.getTimeReceived());
+		long aTime = h1.getTimeReceived(), bTime = h2.getTimeReceived();
+		if (aTime > bTime) return -1;
+		if (aTime < bTime) return 1;
+		return 0;
 	}
 }

briar-android/src/main/java/org/briarproject/briar/android/blog/BlogPostViewHolder.java

@@ -9,7 +9,6 @@ import android.view.ViewGroup;
 import android.widget.ImageButton;
 import android.widget.TextView;
 
-import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.bramble.api.sync.MessageId;
 import org.briarproject.briar.R;
 import org.briarproject.briar.android.view.AuthorView;
@@ -18,24 +17,23 @@ import org.briarproject.briar.api.blog.BlogPostHeader;
 
 import javax.annotation.Nullable;
 
+import androidx.annotation.NonNull;
 import androidx.annotation.UiThread;
 import androidx.core.view.ViewCompat;
+import androidx.fragment.app.FragmentManager;
 import androidx.recyclerview.widget.RecyclerView;
 
 import static android.view.View.GONE;
 import static android.view.View.VISIBLE;
 import static org.briarproject.briar.android.activity.BriarActivity.GROUP_ID;
-import static org.briarproject.briar.android.blog.BlogPostFragment.POST_ID;
+import static org.briarproject.briar.android.blog.BasePostFragment.POST_ID;
 import static org.briarproject.briar.android.util.UiUtils.TEASER_LENGTH;
 import static org.briarproject.briar.android.util.UiUtils.getSpanned;
 import static org.briarproject.briar.android.util.UiUtils.getTeaser;
 import static org.briarproject.briar.android.util.UiUtils.makeLinksClickable;
-import static org.briarproject.briar.android.view.AuthorView.COMMENTER;
+import static org.briarproject.briar.api.blog.MessageType.POST;
-import static org.briarproject.briar.android.view.AuthorView.REBLOGGER;
-import static org.briarproject.briar.android.view.AuthorView.RSS_FEED_REBLOGGED;
 
 @UiThread
-@NotNullByDefault
 class BlogPostViewHolder extends RecyclerView.ViewHolder {
 
 	private final Context ctx;
@@ -45,16 +43,20 @@ class BlogPostViewHolder extends RecyclerView.ViewHolder {
 	private final ImageButton reblogButton;
 	private final TextView text;
 	private final ViewGroup commentContainer;
-	private final boolean fullText, authorClickable;
+	private final boolean fullText;
 
+	@NonNull
 	private final OnBlogPostClickListener listener;
+	@Nullable
+	private final FragmentManager fragmentManager;
 
 	BlogPostViewHolder(View v, boolean fullText,
-			OnBlogPostClickListener listener, boolean authorClickable) {
+			@NonNull OnBlogPostClickListener listener,
+			@Nullable FragmentManager fragmentManager) {
 		super(v);
 		this.fullText = fullText;
 		this.listener = listener;
-		this.authorClickable = authorClickable;
+		this.fragmentManager = fragmentManager;
 
 		ctx = v.getContext();
 		layout = v.findViewById(R.id.postLayout);
@@ -65,6 +67,10 @@ class BlogPostViewHolder extends RecyclerView.ViewHolder {
 		commentContainer = v.findViewById(R.id.commentContainer);
 	}
 
+	void setVisibility(int visibility) {
+		layout.setVisibility(visibility);
+	}
+
 	void hideReblogButton() {
 		reblogButton.setVisibility(GONE);
 	}
@@ -97,7 +103,7 @@ class BlogPostViewHolder extends RecyclerView.ViewHolder {
 		author.setPersona(
 				item.isRssFeed() ? AuthorView.RSS_FEED : AuthorView.NORMAL);
 		// TODO make author clickable more often #624
-		if (authorClickable) {
+		if (!fullText && item.getHeader().getType() == POST) {
 			author.setAuthorClickable(v -> listener.onAuthorClick(item));
 		} else {
 			author.setAuthorNotClickable();
@@ -108,7 +114,7 @@ class BlogPostViewHolder extends RecyclerView.ViewHolder {
 		if (fullText) {
 			text.setText(postText);
 			text.setTextIsSelectable(true);
-			makeLinksClickable(text, listener::onLinkClick);
+			makeLinksClickable(text, fragmentManager);
 		} else {
 			text.setTextIsSelectable(false);
 			if (postText.length() > TEASER_LENGTH)
@@ -141,16 +147,17 @@ class BlogPostViewHolder extends RecyclerView.ViewHolder {
 			reblogger.setAuthorClickable(v -> listener.onAuthorClick(item));
 		}
 		reblogger.setVisibility(VISIBLE);
-		reblogger.setPersona(REBLOGGER);
+		reblogger.setPersona(AuthorView.REBLOGGER);
 
 		author.setPersona(item.getHeader().getRootPost().isRssFeed() ?
-				RSS_FEED_REBLOGGED : COMMENTER);
+				AuthorView.RSS_FEED_REBLOGGED :
+				AuthorView.COMMENTER);
 
 		// comments
-		// TODO use nested RecyclerView instead like we do for Image Attachments
 		for (BlogCommentHeader c : item.getComments()) {
-			View v = LayoutInflater.from(ctx).inflate(
+			View v = LayoutInflater.from(ctx)
-					R.layout.list_item_blog_comment, commentContainer, false);
+					.inflate(R.layout.list_item_blog_comment,
+							commentContainer, false);
 
 			AuthorView author = v.findViewById(R.id.authorView);
 			TextView text = v.findViewById(R.id.textView);

briar-android/src/main/java/org/briarproject/briar/android/blog/FeedController.java

@@ -0,0 +1,32 @@
+package org.briarproject.briar.android.blog;
+
+import org.briarproject.bramble.api.db.DbException;
+import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
+import org.briarproject.briar.android.controller.handler.ResultExceptionHandler;
+import org.briarproject.briar.api.blog.Blog;
+
+import java.util.Collection;
+
+import androidx.annotation.UiThread;
+
+@NotNullByDefault
+public interface FeedController extends BaseController {
+
+	void loadBlogPosts(
+			ResultExceptionHandler<Collection<BlogPostItem>, DbException> handler);
+
+	void loadPersonalBlog(ResultExceptionHandler<Blog, DbException> handler);
+
+	@UiThread
+	void setFeedListener(FeedListener listener);
+
+	@UiThread
+	void unsetFeedListener(FeedListener listener);
+
+	@NotNullByDefault
+	interface FeedListener extends BlogListener {
+
+		@UiThread
+		void onBlogAdded();
+	}
+}

briar-android/src/main/java/org/briarproject/briar/android/blog/FeedControllerImpl.java

@@ -0,0 +1,143 @@
+package org.briarproject.briar.android.blog;
+
+import org.briarproject.bramble.api.db.DatabaseExecutor;
+import org.briarproject.bramble.api.db.DbException;
+import org.briarproject.bramble.api.db.NoSuchGroupException;
+import org.briarproject.bramble.api.db.NoSuchMessageException;
+import org.briarproject.bramble.api.event.Event;
+import org.briarproject.bramble.api.event.EventBus;
+import org.briarproject.bramble.api.identity.Author;
+import org.briarproject.bramble.api.identity.IdentityManager;
+import org.briarproject.bramble.api.lifecycle.LifecycleManager;
+import org.briarproject.bramble.api.nullsafety.MethodsNotNullByDefault;
+import org.briarproject.bramble.api.nullsafety.ParametersNotNullByDefault;
+import org.briarproject.bramble.api.sync.event.GroupAddedEvent;
+import org.briarproject.bramble.api.sync.event.GroupRemovedEvent;
+import org.briarproject.briar.android.controller.handler.ResultExceptionHandler;
+import org.briarproject.briar.api.android.AndroidNotificationManager;
+import org.briarproject.briar.api.blog.Blog;
+import org.briarproject.briar.api.blog.BlogManager;
+import org.briarproject.briar.api.blog.event.BlogPostAddedEvent;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.concurrent.Executor;
+import java.util.logging.Logger;
+
+import javax.inject.Inject;
+
+import androidx.annotation.Nullable;
+
+import static java.util.logging.Level.WARNING;
+import static org.briarproject.bramble.util.LogUtils.logDuration;
+import static org.briarproject.bramble.util.LogUtils.logException;
+import static org.briarproject.bramble.util.LogUtils.now;
+import static org.briarproject.briar.api.blog.BlogManager.CLIENT_ID;
+
+@MethodsNotNullByDefault
+@ParametersNotNullByDefault
+class FeedControllerImpl extends BaseControllerImpl implements FeedController {
+
+	private static final Logger LOG =
+			Logger.getLogger(FeedControllerImpl.class.getName());
+
+	// UI thread
+	@Nullable
+	private FeedListener listener;
+
+	@Inject
+	FeedControllerImpl(@DatabaseExecutor Executor dbExecutor,
+			LifecycleManager lifecycleManager, EventBus eventBus,
+			AndroidNotificationManager notificationManager,
+			IdentityManager identityManager, BlogManager blogManager) {
+		super(dbExecutor, lifecycleManager, eventBus, notificationManager,
+				identityManager, blogManager);
+	}
+
+	@Override
+	public void onStart() {
+		super.onStart();
+		if (listener == null) throw new IllegalStateException();
+		notificationManager.blockAllBlogPostNotifications();
+		notificationManager.clearAllBlogPostNotifications();
+	}
+
+	@Override
+	public void onStop() {
+		super.onStop();
+		notificationManager.unblockAllBlogPostNotifications();
+	}
+
+	@Override
+	public void setFeedListener(FeedListener listener) {
+		this.listener = listener;
+	}
+
+	@Override
+	public void unsetFeedListener(FeedListener listener) {
+		if (this.listener == listener) this.listener = null;
+	}
+
+	@Override
+	public void eventOccurred(Event e) {
+		if (listener == null) throw new IllegalStateException();
+		if (e instanceof BlogPostAddedEvent) {
+			BlogPostAddedEvent b = (BlogPostAddedEvent) e;
+			LOG.info("Blog post added");
+			listener.onBlogPostAdded(b.getHeader(), b.isLocal());
+		} else if (e instanceof GroupAddedEvent) {
+			GroupAddedEvent g = (GroupAddedEvent) e;
+			if (g.getGroup().getClientId().equals(CLIENT_ID)) {
+				LOG.info("Blog added");
+				listener.onBlogAdded();
+			}
+		} else if (e instanceof GroupRemovedEvent) {
+			GroupRemovedEvent g = (GroupRemovedEvent) e;
+			if (g.getGroup().getClientId().equals(CLIENT_ID)) {
+				LOG.info("Blog removed");
+				listener.onBlogRemoved();
+			}
+		}
+	}
+
+	@Override
+	public void loadBlogPosts(
+			ResultExceptionHandler<Collection<BlogPostItem>, DbException> handler) {
+		runOnDbThread(() -> {
+			try {
+				long start = now();
+				Collection<BlogPostItem> posts = new ArrayList<>();
+				for (Blog b : blogManager.getBlogs()) {
+					try {
+						posts.addAll(loadItems(b.getId()));
+					} catch (NoSuchGroupException | NoSuchMessageException e) {
+						logException(LOG, WARNING, e);
+					}
+				}
+				logDuration(LOG, "Loading all posts", start);
+				handler.onResult(posts);
+			} catch (DbException e) {
+				logException(LOG, WARNING, e);
+				handler.onException(e);
+			}
+		});
+	}
+
+	@Override
+	public void loadPersonalBlog(
+			ResultExceptionHandler<Blog, DbException> handler) {
+		runOnDbThread(() -> {
+			try {
+				long start = now();
+				Author a = identityManager.getLocalAuthor();
+				Blog b = blogManager.getPersonalBlog(a);
+				logDuration(LOG, "Loading personal blog", start);
+				handler.onResult(b);
+			} catch (DbException e) {
+				logException(LOG, WARNING, e);
+				handler.onException(e);
+			}
+		});
+	}
+
+}

briar-android/src/main/java/org/briarproject/briar/android/blog/FeedFragment.java

@@ -2,6 +2,7 @@ package org.briarproject.briar.android.blog;
 
 import android.content.Intent;
 import android.os.Bundle;
+import android.os.Parcelable;
 import android.view.LayoutInflater;
 import android.view.Menu;
 import android.view.MenuInflater;
@@ -9,41 +10,53 @@ import android.view.MenuItem;
 import android.view.View;
 import android.view.ViewGroup;
 
+import org.briarproject.bramble.api.db.DbException;
 import org.briarproject.bramble.api.nullsafety.MethodsNotNullByDefault;
 import org.briarproject.bramble.api.nullsafety.ParametersNotNullByDefault;
 import org.briarproject.briar.R;
 import org.briarproject.briar.android.activity.ActivityComponent;
-import org.briarproject.briar.android.blog.BaseViewModel.ListUpdate;
+import org.briarproject.briar.android.blog.FeedController.FeedListener;
+import org.briarproject.briar.android.controller.handler.UiResultExceptionHandler;
 import org.briarproject.briar.android.fragment.BaseFragment;
 import org.briarproject.briar.android.util.BriarSnackbarBuilder;
 import org.briarproject.briar.android.view.BriarRecyclerView;
-import org.briarproject.briar.android.widget.LinkDialogFragment;
 import org.briarproject.briar.api.blog.Blog;
+import org.briarproject.briar.api.blog.BlogPostHeader;
+
+import java.util.Collection;
+import java.util.logging.Logger;
 
 import javax.inject.Inject;
 
 import androidx.annotation.Nullable;
-import androidx.lifecycle.ViewModelProvider;
+import androidx.annotation.UiThread;
 import androidx.recyclerview.widget.LinearLayoutManager;
 
+import static android.app.Activity.RESULT_OK;
 import static android.content.Intent.FLAG_ACTIVITY_CLEAR_TOP;
 import static com.google.android.material.snackbar.Snackbar.LENGTH_LONG;
 import static org.briarproject.briar.android.activity.BriarActivity.GROUP_ID;
+import static org.briarproject.briar.android.activity.RequestCodes.REQUEST_WRITE_BLOG_POST;
 
+@UiThread
 @MethodsNotNullByDefault
 @ParametersNotNullByDefault
-public class FeedFragment extends BaseFragment
+public class FeedFragment extends BaseFragment implements
-		implements OnBlogPostClickListener {
+		OnBlogPostClickListener, FeedListener {
 
 	public final static String TAG = FeedFragment.class.getName();
+	private static final Logger LOG = Logger.getLogger(TAG);
 
 	@Inject
-	ViewModelProvider.Factory viewModelFactory;
+	FeedController feedController;
 
-	private FeedViewModel viewModel;
+	private BlogPostAdapter adapter;
-	private final BlogPostAdapter adapter = new BlogPostAdapter(true, this);
 	private LinearLayoutManager layoutManager;
 	private BriarRecyclerView list;
+	@Nullable
+	private Blog personalBlog;
+	@Nullable
+	private Parcelable layoutManagerState;
 
 	public static FeedFragment newInstance() {
 		FeedFragment f = new FeedFragment();
@@ -57,8 +70,7 @@ public class FeedFragment extends BaseFragment
 	@Override
 	public void injectFragment(ActivityComponent component) {
 		component.inject(this);
-		viewModel = new ViewModelProvider(this, viewModelFactory)
+		feedController.setFeedListener(this);
-				.get(FeedViewModel.class);
 	}
 
 	@Nullable
@@ -70,6 +82,9 @@ public class FeedFragment extends BaseFragment
 
 		View v = inflater.inflate(R.layout.fragment_blog, container, false);
 
+		adapter =
+				new BlogPostAdapter(getActivity(), this, getFragmentManager());
+
 		layoutManager = new LinearLayoutManager(getActivity());
 		list = v.findViewById(R.id.postList);
 		list.setLayoutManager(layoutManager);
@@ -78,38 +93,103 @@ public class FeedFragment extends BaseFragment
 		list.setEmptyText(R.string.blogs_feed_empty_state);
 		list.setEmptyAction(R.string.blogs_feed_empty_state_action);
 
-		viewModel.getBlogPosts().observe(getViewLifecycleOwner(), result ->
+		if (savedInstanceState != null) {
-				result.onError(this::handleException)
+			layoutManagerState =
-						.onSuccess(this::onBlogPostsLoaded)
+					savedInstanceState.getParcelable("layoutManager");
-		);
+		}
 
 		return v;
 	}
 
+	@Override
+	public void onActivityResult(int requestCode, int resultCode,
+			@Nullable Intent data) {
+		super.onActivityResult(requestCode, resultCode, data);
+
+		// The BlogPostAddedEvent arrives when the controller is not listening
+		if (requestCode == REQUEST_WRITE_BLOG_POST && resultCode == RESULT_OK) {
+			showSnackBar(R.string.blogs_blog_post_created);
+		}
+	}
+
 	@Override
 	public void onStart() {
 		super.onStart();
-		viewModel.blockAndClearAllBlogPostNotifications();
+		feedController.onStart();
 		list.startPeriodicUpdate();
+		loadPersonalBlog();
+		loadBlogPosts(false);
 	}
 
 	@Override
 	public void onStop() {
 		super.onStop();
-		viewModel.unblockAllBlogPostNotifications();
+		feedController.onStop();
+		adapter.clear();
+		list.showProgressBar();
 		list.stopPeriodicUpdate();
+		// TODO save list position in database/preferences?
 	}
 
-	private void onBlogPostsLoaded(ListUpdate update) {
+	@Override
-		adapter.submitList(update.getItems(), () -> {
+	public void onDestroy() {
-			Boolean wasLocal = update.getPostAddedWasLocal();
+		super.onDestroy();
-			if (wasLocal != null && wasLocal) {
+		feedController.unsetFeedListener(this);
-				showSnackBar(R.string.blogs_blog_post_created);
+	}
-			} else if (wasLocal != null) {
+
-				showSnackBar(R.string.blogs_blog_post_received);
+	@Override
-			}
+	public void onSaveInstanceState(Bundle outState) {
-			list.showData();
+		super.onSaveInstanceState(outState);
-		});
+		if (layoutManager != null) {
+			layoutManagerState = layoutManager.onSaveInstanceState();
+			outState.putParcelable("layoutManager", layoutManagerState);
+		}
+	}
+
+	private void loadPersonalBlog() {
+		feedController.loadPersonalBlog(
+				new UiResultExceptionHandler<Blog, DbException>(this) {
+					@Override
+					public void onResultUi(Blog b) {
+						personalBlog = b;
+					}
+
+					@Override
+					public void onExceptionUi(DbException exception) {
+						handleException(exception);
+					}
+				});
+	}
+
+	private void loadBlogPosts(boolean clear) {
+		int revision = adapter.getRevision();
+		feedController.loadBlogPosts(
+				new UiResultExceptionHandler<Collection<BlogPostItem>, DbException>(
+						this) {
+					@Override
+					public void onResultUi(Collection<BlogPostItem> posts) {
+						if (revision == adapter.getRevision()) {
+							adapter.incrementRevision();
+							if (clear) adapter.setItems(posts);
+							else adapter.addAll(posts);
+							if (posts.isEmpty()) list.showData();
+							if (layoutManagerState == null) {
+								list.scrollToPosition(0);  // Scroll to the top
+							} else {
+								layoutManager.onRestoreInstanceState(
+										layoutManagerState);
+							}
+						} else {
+							LOG.info("Concurrent update, reloading");
+							loadBlogPosts(clear);
+						}
+					}
+
+					@Override
+					public void onExceptionUi(DbException exception) {
+						handleException(exception);
+					}
+				});
 	}
 
 	@Override
@@ -120,48 +200,67 @@ public class FeedFragment extends BaseFragment
 
 	@Override
 	public boolean onOptionsItemSelected(MenuItem item) {
-		int itemId = item.getItemId();
+		if (personalBlog == null) return false;
-		if (itemId == R.id.action_write_blog_post) {
+		switch (item.getItemId()) {
-			Blog personalBlog = viewModel.getPersonalBlog().getValue();
+			case R.id.action_write_blog_post:
-			if (personalBlog == null) return false;
+				Intent i1 =
-			Intent i = new Intent(getActivity(), WriteBlogPostActivity.class);
+						new Intent(getActivity(), WriteBlogPostActivity.class);
-			i.putExtra(GROUP_ID, personalBlog.getId().getBytes());
+				i1.putExtra(GROUP_ID, personalBlog.getId().getBytes());
-			startActivity(i);
+				startActivityForResult(i1, REQUEST_WRITE_BLOG_POST);
-			return true;
+				return true;
-		} else if (itemId == R.id.action_rss_feeds_import) {
+			case R.id.action_rss_feeds_import:
-			Intent i = new Intent(getActivity(), RssFeedImportActivity.class);
+				Intent i2 =
-			startActivity(i);
+						new Intent(getActivity(), RssFeedImportActivity.class);
-			return true;
+				startActivity(i2);
-		} else if (itemId == R.id.action_rss_feeds_manage) {
+				return true;
-			Blog personalBlog = viewModel.getPersonalBlog().getValue();
+			case R.id.action_rss_feeds_manage:
-			if (personalBlog == null) return false;
+				Intent i3 =
-			Intent i = new Intent(getActivity(), RssFeedManageActivity.class);
+						new Intent(getActivity(), RssFeedManageActivity.class);
-			i.putExtra(GROUP_ID, personalBlog.getId().getBytes());
+				i3.putExtra(GROUP_ID, personalBlog.getId().getBytes());
-			startActivity(i);
+				startActivity(i3);
-			return true;
+				return true;
+			default:
+				return super.onOptionsItemSelected(item);
 		}
-		return super.onOptionsItemSelected(item);
+	}
+
+	@Override
+	public void onBlogPostAdded(BlogPostHeader header, boolean local) {
+		feedController.loadBlogPost(header,
+				new UiResultExceptionHandler<BlogPostItem, DbException>(
+						this) {
+					@Override
+					public void onResultUi(BlogPostItem post) {
+						adapter.incrementRevision();
+						adapter.add(post);
+						if (local) {
+							showSnackBar(R.string.blogs_blog_post_created);
+						} else {
+							showSnackBar(R.string.blogs_blog_post_received);
+						}
+					}
+
+					@Override
+					public void onExceptionUi(DbException exception) {
+						handleException(exception);
+					}
+				}
+		);
 	}
 
 	@Override
 	public void onBlogPostClick(BlogPostItem post) {
-		BaseFragment f = BlogPostFragment
+		FeedPostFragment f =
-				.newInstance(post.getGroupId(), post.getId(), true);
+				FeedPostFragment.newInstance(post.getGroupId(), post.getId());
 		showNextFragment(f);
 	}
 
 	@Override
 	public void onAuthorClick(BlogPostItem post) {
-		Intent i = new Intent(requireContext(), BlogActivity.class);
+		Intent i = new Intent(getContext(), BlogActivity.class);
 		i.putExtra(GROUP_ID, post.getGroupId().getBytes());
 		i.setFlags(FLAG_ACTIVITY_CLEAR_TOP);
-		requireContext().startActivity(i);
+		getContext().startActivity(i);
-	}
-
-	@Override
-	public void onLinkClick(String url) {
-		LinkDialogFragment f = LinkDialogFragment.newInstance(url);
-		f.show(getParentFragmentManager(), f.getUniqueTag());
 	}
 
 	@Override
@@ -184,4 +283,14 @@ public class FeedFragment extends BaseFragment
 		sb.make(list, stringRes, LENGTH_LONG).show();
 	}
 
+	@Override
+	public void onBlogAdded() {
+		loadBlogPosts(false);
+	}
+
+	@Override
+	public void onBlogRemoved() {
+		loadBlogPosts(true);
+	}
+
 }

briar-android/src/main/java/org/briarproject/briar/android/blog/FeedPostFragment.java

@@ -0,0 +1,87 @@
+package org.briarproject.briar.android.blog;
+
+import android.os.Bundle;
+import android.view.LayoutInflater;
+import android.view.View;
+import android.view.ViewGroup;
+
+import org.briarproject.bramble.api.db.DbException;
+import org.briarproject.bramble.api.nullsafety.MethodsNotNullByDefault;
+import org.briarproject.bramble.api.nullsafety.ParametersNotNullByDefault;
+import org.briarproject.bramble.api.sync.GroupId;
+import org.briarproject.bramble.api.sync.MessageId;
+import org.briarproject.briar.android.activity.ActivityComponent;
+import org.briarproject.briar.android.controller.handler.UiResultExceptionHandler;
+
+import javax.annotation.Nullable;
+import javax.inject.Inject;
+
+import androidx.annotation.UiThread;
+
+import static org.briarproject.briar.android.activity.BriarActivity.GROUP_ID;
+
+@UiThread
+@MethodsNotNullByDefault
+@ParametersNotNullByDefault
+public class FeedPostFragment extends BasePostFragment {
+
+	private static final String TAG = FeedPostFragment.class.getName();
+
+	private GroupId blogId;
+
+	@Inject
+	FeedController feedController;
+
+	static FeedPostFragment newInstance(GroupId blogId, MessageId postId) {
+		FeedPostFragment f = new FeedPostFragment();
+
+		Bundle bundle = new Bundle();
+		bundle.putByteArray(GROUP_ID, blogId.getBytes());
+		bundle.putByteArray(POST_ID, postId.getBytes());
+
+		f.setArguments(bundle);
+		return f;
+	}
+
+	@Override
+	public void injectFragment(ActivityComponent component) {
+		component.inject(this);
+	}
+
+	@Nullable
+	@Override
+	public View onCreateView(LayoutInflater inflater,
+			@Nullable ViewGroup container,
+			@Nullable Bundle savedInstanceState) {
+		Bundle args = requireArguments();
+		byte[] b = args.getByteArray(GROUP_ID);
+		if (b == null) throw new IllegalStateException("No group ID in args");
+		blogId = new GroupId(b);
+
+		return super.onCreateView(inflater, container, savedInstanceState);
+	}
+
+	@Override
+	public String getUniqueTag() {
+		return TAG;
+	}
+
+	@Override
+	public void onStart() {
+		super.onStart();
+		feedController.loadBlogPost(blogId, postId,
+				new UiResultExceptionHandler<BlogPostItem, DbException>(
+						this) {
+					@Override
+					public void onResultUi(BlogPostItem post) {
+						onBlogPostLoaded(post);
+					}
+
+					@Override
+					public void onExceptionUi(DbException exception) {
+						handleException(exception);
+					}
+				});
+	}
+
+}

briar-android/src/main/java/org/briarproject/briar/android/blog/FeedViewModel.java

@@ -1,134 +0,0 @@
-package org.briarproject.briar.android.blog;
-
-import android.app.Application;
-
-import org.briarproject.bramble.api.db.DatabaseExecutor;
-import org.briarproject.bramble.api.db.DbException;
-import org.briarproject.bramble.api.db.Transaction;
-import org.briarproject.bramble.api.db.TransactionManager;
-import org.briarproject.bramble.api.event.Event;
-import org.briarproject.bramble.api.event.EventBus;
-import org.briarproject.bramble.api.identity.Author;
-import org.briarproject.bramble.api.identity.IdentityManager;
-import org.briarproject.bramble.api.lifecycle.LifecycleManager;
-import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
-import org.briarproject.bramble.api.sync.GroupId;
-import org.briarproject.bramble.api.sync.event.GroupRemovedEvent;
-import org.briarproject.bramble.api.system.AndroidExecutor;
-import org.briarproject.briar.android.viewmodel.LiveResult;
-import org.briarproject.briar.api.android.AndroidNotificationManager;
-import org.briarproject.briar.api.blog.Blog;
-import org.briarproject.briar.api.blog.BlogManager;
-import org.briarproject.briar.api.blog.event.BlogPostAddedEvent;
-
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.List;
-import java.util.concurrent.Executor;
-import java.util.logging.Logger;
-
-import javax.inject.Inject;
-
-import androidx.annotation.UiThread;
-import androidx.lifecycle.LiveData;
-import androidx.lifecycle.MutableLiveData;
-
-import static java.util.logging.Logger.getLogger;
-import static org.briarproject.bramble.util.LogUtils.logDuration;
-import static org.briarproject.bramble.util.LogUtils.now;
-import static org.briarproject.briar.api.blog.BlogManager.CLIENT_ID;
-
-@NotNullByDefault
-class FeedViewModel extends BaseViewModel {
-
-	private static final Logger LOG = getLogger(FeedViewModel.class.getName());
-
-	private final MutableLiveData<Blog> personalBlog = new MutableLiveData<>();
-
-	@Inject
-	FeedViewModel(Application application,
-			@DatabaseExecutor Executor dbExecutor,
-			LifecycleManager lifecycleManager,
-			TransactionManager db,
-			AndroidExecutor androidExecutor,
-			EventBus eventBus,
-			IdentityManager identityManager,
-			AndroidNotificationManager notificationManager,
-			BlogManager blogManager) {
-		super(application, dbExecutor, lifecycleManager, db, androidExecutor,
-				eventBus, identityManager, notificationManager, blogManager);
-		loadPersonalBlog();
-		loadAllBlogPosts();
-	}
-
-	@Override
-	public void eventOccurred(Event e) {
-		if (e instanceof BlogPostAddedEvent) {
-			BlogPostAddedEvent b = (BlogPostAddedEvent) e;
-			LOG.info("Blog post added");
-			onBlogPostAdded(b.getHeader(), b.isLocal());
-		}
-		if (e instanceof GroupRemovedEvent) {
-			GroupRemovedEvent g = (GroupRemovedEvent) e;
-			if (g.getGroup().getClientId().equals(CLIENT_ID)) {
-				LOG.info("Blog removed");
-				onBlogRemoved(g.getGroup().getId());
-			}
-		}
-	}
-
-	void blockAndClearAllBlogPostNotifications() {
-		notificationManager.blockAllBlogPostNotifications();
-		notificationManager.clearAllBlogPostNotifications();
-	}
-
-	void unblockAllBlogPostNotifications() {
-		notificationManager.unblockAllBlogPostNotifications();
-	}
-
-	private void loadPersonalBlog() {
-		runOnDbThread(() -> {
-			try {
-				long start = now();
-				Author a = identityManager.getLocalAuthor();
-				Blog b = blogManager.getPersonalBlog(a);
-				logDuration(LOG, "Loading personal blog", start);
-				personalBlog.postValue(b);
-			} catch (DbException e) {
-				handleException(e);
-			}
-		});
-	}
-
-	LiveData<Blog> getPersonalBlog() {
-		return personalBlog;
-	}
-
-	private void loadAllBlogPosts() {
-		loadList(this::loadAllBlogPosts, blogPosts::setValue);
-	}
-
-	@DatabaseExecutor
-	private ListUpdate loadAllBlogPosts(Transaction txn)
-			throws DbException {
-		long start = now();
-		List<BlogPostItem> posts = new ArrayList<>();
-		for (GroupId g : blogManager.getBlogIds(txn)) {
-			posts.addAll(loadBlogPosts(txn, g));
-		}
-		Collections.sort(posts);
-		logDuration(LOG, "Loading all posts", start);
-		return new ListUpdate(null, posts);
-	}
-
-	@UiThread
-	private void onBlogRemoved(GroupId g) {
-		List<BlogPostItem> items = removeListItems(getBlogPostItems(),
-				item -> item.getGroupId().equals(g)
-		);
-		if (items != null) {
-			blogPosts.setValue(new LiveResult<>(new ListUpdate(null, items)));
-		}
-	}
-
-}

briar-android/src/main/java/org/briarproject/briar/android/blog/OnBlogPostClickListener.java

@@ -5,6 +5,4 @@ interface OnBlogPostClickListener {
 	void onBlogPostClick(BlogPostItem post);
 
 	void onAuthorClick(BlogPostItem post);
-
-	void onLinkClick(String url);
 }

briar-android/src/main/java/org/briarproject/briar/android/blog/ReblogActivity.java

@@ -11,7 +11,7 @@ import org.briarproject.briar.android.activity.ActivityComponent;
 import org.briarproject.briar.android.activity.BriarActivity;
 import org.briarproject.briar.android.fragment.BaseFragment.BaseFragmentListener;
 
-import static org.briarproject.briar.android.blog.BlogPostFragment.POST_ID;
+import static org.briarproject.briar.android.blog.BasePostFragment.POST_ID;
 
 public class ReblogActivity extends BriarActivity implements
 		BaseFragmentListener {
@@ -39,11 +39,13 @@ public class ReblogActivity extends BriarActivity implements
 
 	@Override
 	public boolean onOptionsItemSelected(MenuItem item) {
-		if (item.getItemId() == android.R.id.home) {
+		switch (item.getItemId()) {
-			onBackPressed();
+			case android.R.id.home:
-			return true;
+				onBackPressed();
+				return true;
+			default:
+				return super.onOptionsItemSelected(item);
 		}
-		return super.onOptionsItemSelected(item);
 	}
 
 	@Override

briar-android/src/main/java/org/briarproject/briar/android/blog/ReblogFragment.java

@@ -7,17 +7,19 @@ import android.view.ViewGroup;
 import android.widget.ProgressBar;
 import android.widget.ScrollView;
 
+import org.briarproject.bramble.api.db.DbException;
 import org.briarproject.bramble.api.nullsafety.MethodsNotNullByDefault;
 import org.briarproject.bramble.api.nullsafety.ParametersNotNullByDefault;
 import org.briarproject.bramble.api.sync.GroupId;
 import org.briarproject.bramble.api.sync.MessageId;
 import org.briarproject.briar.R;
 import org.briarproject.briar.android.activity.ActivityComponent;
+import org.briarproject.briar.android.controller.handler.UiExceptionHandler;
+import org.briarproject.briar.android.controller.handler.UiResultExceptionHandler;
 import org.briarproject.briar.android.fragment.BaseFragment;
 import org.briarproject.briar.android.view.TextInputView;
 import org.briarproject.briar.android.view.TextSendController;
 import org.briarproject.briar.android.view.TextSendController.SendListener;
-import org.briarproject.briar.android.widget.LinkDialogFragment;
 import org.briarproject.briar.api.attachment.AttachmentHeader;
 
 import java.util.List;
@@ -25,15 +27,13 @@ import java.util.List;
 import javax.annotation.Nullable;
 import javax.inject.Inject;
 
-import androidx.lifecycle.ViewModelProvider;
-
 import static android.view.View.FOCUS_DOWN;
 import static android.view.View.GONE;
 import static android.view.View.INVISIBLE;
 import static android.view.View.VISIBLE;
 import static java.util.Objects.requireNonNull;
 import static org.briarproject.briar.android.activity.BriarActivity.GROUP_ID;
-import static org.briarproject.briar.android.blog.BlogPostFragment.POST_ID;
+import static org.briarproject.briar.android.blog.BasePostFragment.POST_ID;
 import static org.briarproject.briar.api.blog.BlogConstants.MAX_BLOG_POST_TEXT_LENGTH;
 
 @MethodsNotNullByDefault
@@ -42,13 +42,12 @@ public class ReblogFragment extends BaseFragment implements SendListener {
 
 	public static final String TAG = ReblogFragment.class.getName();
 
-	@Inject
-	ViewModelProvider.Factory viewModelFactory;
-
-	private BlogViewModel viewModel;
 	private ViewHolder ui;
 	private BlogPostItem item;
 
+	@Inject
+	FeedController feedController;
+
 	static ReblogFragment newInstance(GroupId groupId, MessageId messageId) {
 		ReblogFragment f = new ReblogFragment();
 
@@ -68,8 +67,6 @@ public class ReblogFragment extends BaseFragment implements SendListener {
 	@Override
 	public void injectFragment(ActivityComponent component) {
 		component.inject(this);
-		viewModel = new ViewModelProvider(requireActivity(), viewModelFactory)
-				.get(BlogViewModel.class);
 	}
 
 	@Override
@@ -93,20 +90,30 @@ public class ReblogFragment extends BaseFragment implements SendListener {
 		ui.input.setMaxTextLength(MAX_BLOG_POST_TEXT_LENGTH);
 		showProgressBar();
 
-		viewModel.loadBlogPost(blogId, postId).observe(getViewLifecycleOwner(),
+		feedController.loadBlogPost(blogId, postId,
-				result -> result.onError(this::handleException)
+				new UiResultExceptionHandler<BlogPostItem, DbException>(
-						.onSuccess(this::bindViewHolder)
+						this) {
-		);
+					@Override
+					public void onResultUi(BlogPostItem result) {
+						item = result;
+						bindViewHolder();
+					}
+
+					@Override
+					public void onExceptionUi(DbException exception) {
+						handleException(exception);
+					}
+				});
 
 		return v;
 	}
 
-	private void bindViewHolder(BlogPostItem item) {
+	private void bindViewHolder() {
-		this.item = item;
+		if (item == null) return;
 
 		hideProgressBar();
 
-		ui.post.bindItem(this.item);
+		ui.post.bindItem(item);
 		ui.post.hideReblogButton();
 
 		ui.input.setReady(true);
@@ -117,7 +124,13 @@ public class ReblogFragment extends BaseFragment implements SendListener {
 	public void onSendClick(@Nullable String text,
 			List<AttachmentHeader> headers) {
 		ui.input.hideSoftKeyboard();
-		viewModel.repeatPost(item, text);
+		feedController.repeatPost(item, text,
+				new UiExceptionHandler<DbException>(this) {
+					@Override
+					public void onExceptionUi(DbException exception) {
+						handleException(exception);
+					}
+				});
 		finish();
 	}
 
@@ -131,7 +144,7 @@ public class ReblogFragment extends BaseFragment implements SendListener {
 		ui.input.setVisibility(VISIBLE);
 	}
 
-	private class ViewHolder implements OnBlogPostClickListener {
+	private class ViewHolder {
 
 		private final ScrollView scrollView;
 		private final ProgressBar progressBar;
@@ -142,25 +155,18 @@ public class ReblogFragment extends BaseFragment implements SendListener {
 			scrollView = v.findViewById(R.id.scrollView);
 			progressBar = v.findViewById(R.id.progressBar);
 			post = new BlogPostViewHolder(v.findViewById(R.id.postLayout),
-					true, this, false);
+					true, new OnBlogPostClickListener() {
+				@Override
+				public void onBlogPostClick(BlogPostItem post) {
+					// do nothing
+				}
+
+				@Override
+				public void onAuthorClick(BlogPostItem post) {
+					// probably don't want to allow author clicks here
+				}
+			}, getFragmentManager());
 			input = v.findViewById(R.id.inputText);
 		}
-
-		@Override
-		public void onBlogPostClick(BlogPostItem post) {
-			// do nothing
-		}
-
-		@Override
-		public void onAuthorClick(BlogPostItem post) {
-			// probably don't want to allow author clicks here
-		}
-
-		@Override
-		public void onLinkClick(String url) {
-			LinkDialogFragment f = LinkDialogFragment.newInstance(url);
-			f.show(getParentFragmentManager(), f.getUniqueTag());
-		}
 	}
-
 }

briar-android/src/main/java/org/briarproject/briar/android/contact/BaseContactListAdapter.java

@@ -1,6 +1,7 @@
 package org.briarproject.briar.android.contact;
 
 import android.content.Context;
+import android.view.View;
 
 import org.briarproject.briar.android.util.BriarAdapter;
 
@@ -44,4 +45,8 @@ public abstract class BaseContactListAdapter<I extends ContactItem, VH extends C
 		return true;
 	}
 
+	public interface OnContactClickListener<I> {
+		void onItemClick(View view, I item);
+	}
+
 }

briar-android/src/main/java/org/briarproject/briar/android/contact/ContactItemViewHolder.java

@@ -7,6 +7,7 @@ import android.widget.TextView;
 
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.briar.R;
+import org.briarproject.briar.android.contact.BaseContactListAdapter.OnContactClickListener;
 
 import javax.annotation.Nullable;
 

briar-android/src/main/java/org/briarproject/briar/android/contact/ContactListAdapter.java

@@ -7,6 +7,7 @@ import android.view.ViewGroup;
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.bramble.api.nullsafety.NullSafety;
 import org.briarproject.briar.R;
+import org.briarproject.briar.android.contact.BaseContactListAdapter.OnContactClickListener;
 
 import androidx.recyclerview.widget.DiffUtil.ItemCallback;
 import androidx.recyclerview.widget.ListAdapter;
@@ -15,6 +16,9 @@ import androidx.recyclerview.widget.ListAdapter;
 public class ContactListAdapter extends
 		ListAdapter<ContactListItem, ContactListItemViewHolder> {
 
+	// TODO: using the click listener interface from BaseContactListAdapter on
+	// purpose here because it is entangled with ContactListItemViewHolder. At
+	// some point we probably want to change that.
 	protected final OnContactClickListener<ContactListItem> listener;
 
 	public ContactListAdapter(

briar-android/src/main/java/org/briarproject/briar/android/contact/ContactListFragment.java

@@ -15,6 +15,7 @@ import org.briarproject.bramble.api.nullsafety.MethodsNotNullByDefault;
 import org.briarproject.bramble.api.nullsafety.ParametersNotNullByDefault;
 import org.briarproject.briar.R;
 import org.briarproject.briar.android.activity.ActivityComponent;
+import org.briarproject.briar.android.contact.BaseContactListAdapter.OnContactClickListener;
 import org.briarproject.briar.android.contact.add.remote.AddContactActivity;
 import org.briarproject.briar.android.contact.add.remote.PendingContactListActivity;
 import org.briarproject.briar.android.conversation.ConversationActivity;
@@ -100,6 +101,8 @@ public class ContactListFragment extends BaseFragment
 				.observe(getViewLifecycleOwner(), result -> {
 					result.onError(this::handleException).onSuccess(items -> {
 						adapter.submitList(items);
+						// TODO remove when BriarRecyclerView was adapted
+						list.showData();
 					});
 				});
 		viewModel.getHasPendingContacts()

briar-android/src/main/java/org/briarproject/briar/android/contact/ContactListItemViewHolder.java

@@ -5,6 +5,7 @@ import android.widget.TextView;
 
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.briar.R;
+import org.briarproject.briar.android.contact.BaseContactListAdapter.OnContactClickListener;
 
 import java.util.Locale;
 

briar-android/src/main/java/org/briarproject/briar/android/contact/ContactListViewModel.java

@@ -3,41 +3,70 @@ package org.briarproject.briar.android.contact;
 import android.app.Application;
 
 import org.briarproject.bramble.api.connection.ConnectionRegistry;
+import org.briarproject.bramble.api.contact.Contact;
+import org.briarproject.bramble.api.contact.ContactId;
 import org.briarproject.bramble.api.contact.ContactManager;
+import org.briarproject.bramble.api.contact.event.ContactAddedEvent;
+import org.briarproject.bramble.api.contact.event.ContactRemovedEvent;
 import org.briarproject.bramble.api.contact.event.PendingContactAddedEvent;
 import org.briarproject.bramble.api.contact.event.PendingContactRemovedEvent;
 import org.briarproject.bramble.api.db.DatabaseExecutor;
 import org.briarproject.bramble.api.db.DbException;
+import org.briarproject.bramble.api.db.Transaction;
 import org.briarproject.bramble.api.db.TransactionManager;
 import org.briarproject.bramble.api.event.Event;
 import org.briarproject.bramble.api.event.EventBus;
+import org.briarproject.bramble.api.event.EventListener;
 import org.briarproject.bramble.api.lifecycle.LifecycleManager;
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
+import org.briarproject.bramble.api.plugin.event.ContactConnectedEvent;
+import org.briarproject.bramble.api.plugin.event.ContactDisconnectedEvent;
 import org.briarproject.bramble.api.system.AndroidExecutor;
+import org.briarproject.briar.android.viewmodel.DbViewModel;
+import org.briarproject.briar.android.viewmodel.LiveResult;
 import org.briarproject.briar.api.android.AndroidNotificationManager;
+import org.briarproject.briar.api.avatar.event.AvatarUpdatedEvent;
+import org.briarproject.briar.api.client.MessageTracker;
 import org.briarproject.briar.api.conversation.ConversationManager;
+import org.briarproject.briar.api.conversation.ConversationMessageHeader;
+import org.briarproject.briar.api.conversation.event.ConversationMessageReceivedEvent;
+import org.briarproject.briar.api.identity.AuthorInfo;
 import org.briarproject.briar.api.identity.AuthorManager;
 
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
 import java.util.concurrent.Executor;
 import java.util.logging.Logger;
 
 import javax.inject.Inject;
 
+import androidx.arch.core.util.Function;
 import androidx.lifecycle.LiveData;
 import androidx.lifecycle.MutableLiveData;
 
 import static java.util.logging.Level.WARNING;
 import static java.util.logging.Logger.getLogger;
+import static org.briarproject.bramble.util.LogUtils.logDuration;
 import static org.briarproject.bramble.util.LogUtils.logException;
+import static org.briarproject.bramble.util.LogUtils.now;
 
 @NotNullByDefault
-class ContactListViewModel extends ContactsViewModel {
+class ContactListViewModel extends DbViewModel implements EventListener {
 
 	private static final Logger LOG =
 			getLogger(ContactListViewModel.class.getName());
 
+	private final ContactManager contactManager;
+	private final AuthorManager authorManager;
+	private final ConversationManager conversationManager;
+	private final ConnectionRegistry connectionRegistry;
+	private final EventBus eventBus;
 	private final AndroidNotificationManager notificationManager;
 
+	private final MutableLiveData<LiveResult<List<ContactListItem>>>
+			contactListItems = new MutableLiveData<>();
+
 	private final MutableLiveData<Boolean> hasPendingContacts =
 			new MutableLiveData<>();
 
@@ -50,25 +79,99 @@ class ContactListViewModel extends ContactsViewModel {
 			ConversationManager conversationManager,
 			ConnectionRegistry connectionRegistry, EventBus eventBus,
 			AndroidNotificationManager notificationManager) {
-		super(application, dbExecutor, lifecycleManager, db, androidExecutor,
+		super(application, dbExecutor, lifecycleManager, db, androidExecutor);
-				contactManager, authorManager, conversationManager,
+		this.contactManager = contactManager;
-				connectionRegistry, eventBus);
+		this.authorManager = authorManager;
+		this.conversationManager = conversationManager;
+		this.connectionRegistry = connectionRegistry;
+		this.eventBus = eventBus;
 		this.notificationManager = notificationManager;
+		this.eventBus.addListener(this);
+	}
+
+	@Override
+	protected void onCleared() {
+		super.onCleared();
+		eventBus.removeListener(this);
+	}
+
+	void loadContacts() {
+		loadList(this::loadContacts, contactListItems::setValue);
+	}
+
+	private List<ContactListItem> loadContacts(Transaction txn)
+			throws DbException {
+		long start = now();
+		List<ContactListItem> contacts = new ArrayList<>();
+		for (Contact c : contactManager.getContacts(txn)) {
+			ContactId id = c.getId();
+			AuthorInfo authorInfo = authorManager.getAuthorInfo(txn, c);
+			MessageTracker.GroupCount count =
+					conversationManager.getGroupCount(txn, id);
+			boolean connected = connectionRegistry.isConnected(c.getId());
+			contacts.add(new ContactListItem(c, authorInfo, connected, count));
+		}
+		Collections.sort(contacts);
+		logDuration(LOG, "Full load", start);
+		return contacts;
 	}
 
 	@Override
 	public void eventOccurred(Event e) {
-		super.eventOccurred(e);
+		if (e instanceof ContactAddedEvent) {
-		if (e instanceof PendingContactAddedEvent ||
+			LOG.info("Contact added, reloading");
+			loadContacts();
+		} else if (e instanceof ContactConnectedEvent) {
+			updateItem(((ContactConnectedEvent) e).getContactId(),
+					item -> new ContactListItem(item, true), false);
+		} else if (e instanceof ContactDisconnectedEvent) {
+			updateItem(((ContactDisconnectedEvent) e).getContactId(),
+					item -> new ContactListItem(item, false), false);
+		} else if (e instanceof ContactRemovedEvent) {
+			LOG.info("Contact removed, removing item");
+			removeItem(((ContactRemovedEvent) e).getContactId());
+		} else if (e instanceof ConversationMessageReceivedEvent) {
+			LOG.info("Conversation message received, updating item");
+			ConversationMessageReceivedEvent<?> p =
+					(ConversationMessageReceivedEvent<?>) e;
+			ConversationMessageHeader h = p.getMessageHeader();
+			updateItem(p.getContactId(), item -> new ContactListItem(item, h),
+					true);
+		} else if (e instanceof PendingContactAddedEvent ||
 				e instanceof PendingContactRemovedEvent) {
 			checkForPendingContacts();
+		} else if (e instanceof AvatarUpdatedEvent) {
+			AvatarUpdatedEvent a = (AvatarUpdatedEvent) e;
+			updateItem(a.getContactId(), item -> new ContactListItem(item,
+					a.getAttachmentHeader()), false);
 		}
 	}
 
+	LiveData<LiveResult<List<ContactListItem>>> getContactListItems() {
+		return contactListItems;
+	}
+
 	LiveData<Boolean> getHasPendingContacts() {
 		return hasPendingContacts;
 	}
 
+	private void updateItem(ContactId c,
+			Function<ContactListItem, ContactListItem> replacer, boolean sort) {
+		List<ContactListItem> list = updateListItems(contactListItems,
+				itemToTest -> itemToTest.getContact().getId().equals(c),
+				replacer);
+		if (list == null) return;
+		if (sort) Collections.sort(list);
+		contactListItems.setValue(new LiveResult<>(list));
+	}
+
+	private void removeItem(ContactId c) {
+		List<ContactListItem> list = removeListItems(contactListItems,
+				itemToTest -> itemToTest.getContact().getId().equals(c));
+		if (list == null) return;
+		contactListItems.setValue(new LiveResult<>(list));
+	}
+
 	void checkForPendingContacts() {
 		runOnDbThread(() -> {
 			try {

briar-android/src/main/java/org/briarproject/briar/android/contact/ContactsViewModel.java

@@ -1,168 +0,0 @@
-package org.briarproject.briar.android.contact;
-
-import android.app.Application;
-
-import org.briarproject.bramble.api.connection.ConnectionRegistry;
-import org.briarproject.bramble.api.contact.Contact;
-import org.briarproject.bramble.api.contact.ContactId;
-import org.briarproject.bramble.api.contact.ContactManager;
-import org.briarproject.bramble.api.contact.event.ContactAddedEvent;
-import org.briarproject.bramble.api.contact.event.ContactRemovedEvent;
-import org.briarproject.bramble.api.db.DatabaseExecutor;
-import org.briarproject.bramble.api.db.DbException;
-import org.briarproject.bramble.api.db.Transaction;
-import org.briarproject.bramble.api.db.TransactionManager;
-import org.briarproject.bramble.api.event.Event;
-import org.briarproject.bramble.api.event.EventBus;
-import org.briarproject.bramble.api.event.EventListener;
-import org.briarproject.bramble.api.lifecycle.LifecycleManager;
-import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
-import org.briarproject.bramble.api.plugin.event.ContactConnectedEvent;
-import org.briarproject.bramble.api.plugin.event.ContactDisconnectedEvent;
-import org.briarproject.bramble.api.system.AndroidExecutor;
-import org.briarproject.briar.android.viewmodel.DbViewModel;
-import org.briarproject.briar.android.viewmodel.LiveResult;
-import org.briarproject.briar.api.avatar.event.AvatarUpdatedEvent;
-import org.briarproject.briar.api.client.MessageTracker;
-import org.briarproject.briar.api.conversation.ConversationManager;
-import org.briarproject.briar.api.conversation.ConversationMessageHeader;
-import org.briarproject.briar.api.conversation.event.ConversationMessageReceivedEvent;
-import org.briarproject.briar.api.identity.AuthorInfo;
-import org.briarproject.briar.api.identity.AuthorManager;
-
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.List;
-import java.util.concurrent.Executor;
-import java.util.logging.Logger;
-
-import javax.inject.Inject;
-
-import androidx.annotation.UiThread;
-import androidx.arch.core.util.Function;
-import androidx.lifecycle.LiveData;
-import androidx.lifecycle.MutableLiveData;
-
-import static java.util.logging.Logger.getLogger;
-import static org.briarproject.bramble.util.LogUtils.logDuration;
-import static org.briarproject.bramble.util.LogUtils.now;
-
-@NotNullByDefault
-public class ContactsViewModel extends DbViewModel implements EventListener {
-
-	private static final Logger LOG =
-			getLogger(ContactsViewModel.class.getName());
-
-	protected final ContactManager contactManager;
-	private final AuthorManager authorManager;
-	private final ConversationManager conversationManager;
-	private final ConnectionRegistry connectionRegistry;
-	private final EventBus eventBus;
-
-	private final MutableLiveData<LiveResult<List<ContactListItem>>>
-			contactListItems = new MutableLiveData<>();
-
-	@Inject
-	public ContactsViewModel(Application application,
-			@DatabaseExecutor Executor dbExecutor,
-			LifecycleManager lifecycleManager, TransactionManager db,
-			AndroidExecutor androidExecutor, ContactManager contactManager,
-			AuthorManager authorManager,
-			ConversationManager conversationManager,
-			ConnectionRegistry connectionRegistry, EventBus eventBus) {
-		super(application, dbExecutor, lifecycleManager, db, androidExecutor);
-		this.contactManager = contactManager;
-		this.authorManager = authorManager;
-		this.conversationManager = conversationManager;
-		this.connectionRegistry = connectionRegistry;
-		this.eventBus = eventBus;
-		this.eventBus.addListener(this);
-	}
-
-	@Override
-	protected void onCleared() {
-		super.onCleared();
-		eventBus.removeListener(this);
-	}
-
-	protected void loadContacts() {
-		loadList(this::loadContacts, contactListItems::setValue);
-	}
-
-	private List<ContactListItem> loadContacts(Transaction txn)
-			throws DbException {
-		long start = now();
-		List<ContactListItem> contacts = new ArrayList<>();
-		for (Contact c : contactManager.getContacts(txn)) {
-			ContactId id = c.getId();
-			if (!displayContact(id)) {
-				continue;
-			}
-			AuthorInfo authorInfo = authorManager.getAuthorInfo(txn, c);
-			MessageTracker.GroupCount count =
-					conversationManager.getGroupCount(txn, id);
-			boolean connected = connectionRegistry.isConnected(c.getId());
-			contacts.add(new ContactListItem(c, authorInfo, connected, count));
-		}
-		Collections.sort(contacts);
-		logDuration(LOG, "Full load", start);
-		return contacts;
-	}
-
-	/**
-	 * Override this method to display only a subset of contacts.
-	 */
-	protected boolean displayContact(ContactId contactId) {
-		return true;
-	}
-
-	@Override
-	public void eventOccurred(Event e) {
-		if (e instanceof ContactAddedEvent) {
-			LOG.info("Contact added, reloading");
-			loadContacts();
-		} else if (e instanceof ContactConnectedEvent) {
-			updateItem(((ContactConnectedEvent) e).getContactId(),
-					item -> new ContactListItem(item, true), false);
-		} else if (e instanceof ContactDisconnectedEvent) {
-			updateItem(((ContactDisconnectedEvent) e).getContactId(),
-					item -> new ContactListItem(item, false), false);
-		} else if (e instanceof ContactRemovedEvent) {
-			LOG.info("Contact removed, removing item");
-			removeItem(((ContactRemovedEvent) e).getContactId());
-		} else if (e instanceof ConversationMessageReceivedEvent) {
-			LOG.info("Conversation message received, updating item");
-			ConversationMessageReceivedEvent<?> p =
-					(ConversationMessageReceivedEvent<?>) e;
-			ConversationMessageHeader h = p.getMessageHeader();
-			updateItem(p.getContactId(), item -> new ContactListItem(item, h),
-					true);
-		} else if (e instanceof AvatarUpdatedEvent) {
-			AvatarUpdatedEvent a = (AvatarUpdatedEvent) e;
-			updateItem(a.getContactId(), item -> new ContactListItem(item,
-					a.getAttachmentHeader()), false);
-		}
-	}
-
-	public LiveData<LiveResult<List<ContactListItem>>> getContactListItems() {
-		return contactListItems;
-	}
-
-	@UiThread
-	private void updateItem(ContactId c,
-			Function<ContactListItem, ContactListItem> replacer, boolean sort) {
-		List<ContactListItem> list = updateListItems(getList(contactListItems),
-				itemToTest -> itemToTest.getContact().getId().equals(c),
-				replacer);
-		if (list == null) return;
-		if (sort) Collections.sort(list);
-		contactListItems.setValue(new LiveResult<>(list));
-	}
-
-	@UiThread
-	private void removeItem(ContactId c) {
-		removeAndUpdateListItems(contactListItems,
-				itemToTest -> itemToTest.getContact().getId().equals(c));
-	}
-
-}

briar-android/src/main/java/org/briarproject/briar/android/contact/LegacyContactListAdapter.java

@@ -0,0 +1,50 @@
+package org.briarproject.briar.android.contact;
+
+import android.content.Context;
+import android.view.LayoutInflater;
+import android.view.View;
+import android.view.ViewGroup;
+
+import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
+import org.briarproject.briar.R;
+
+@NotNullByDefault
+public class LegacyContactListAdapter extends
+		BaseContactListAdapter<ContactListItem, ContactListItemViewHolder> {
+
+	public LegacyContactListAdapter(Context context,
+			OnContactClickListener<ContactListItem> listener) {
+		super(context, ContactListItem.class, listener);
+	}
+
+	@Override
+	public ContactListItemViewHolder onCreateViewHolder(ViewGroup viewGroup,
+			int i) {
+		View v = LayoutInflater.from(viewGroup.getContext()).inflate(
+				R.layout.list_item_contact, viewGroup, false);
+
+		return new ContactListItemViewHolder(v);
+	}
+
+	@Override
+	public boolean areContentsTheSame(ContactListItem c1, ContactListItem c2) {
+		// check for all properties that influence visual
+		// representation of contact
+		if (c1.isEmpty() != c2.isEmpty()) {
+			return false;
+		}
+		if (c1.getUnreadCount() != c2.getUnreadCount()) {
+			return false;
+		}
+		if (c1.getTimestamp() != c2.getTimestamp()) {
+			return false;
+		}
+		return c1.isConnected() == c2.isConnected();
+	}
+
+	@Override
+	public int compare(ContactListItem c1, ContactListItem c2) {
+		return Long.compare(c2.getTimestamp(), c1.getTimestamp());
+	}
+
+}

briar-android/src/main/java/org/briarproject/briar/android/contact/OnContactClickListener.java

@@ -1,9 +0,0 @@
-package org.briarproject.briar.android.contact;
-
-import android.view.View;
-
-public interface OnContactClickListener<I> {
-
-	void onItemClick(View view, I item);
-
-}

briar-android/src/main/java/org/briarproject/briar/android/contactselection/BaseContactSelectorAdapter.java

@@ -6,7 +6,6 @@ import org.briarproject.bramble.api.contact.ContactId;
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.briar.android.contact.BaseContactListAdapter;
 import org.briarproject.briar.android.contact.ContactItemViewHolder;
-import org.briarproject.briar.android.contact.OnContactClickListener;
 
 import java.util.ArrayList;
 import java.util.Collection;

briar-android/src/main/java/org/briarproject/briar/android/contactselection/BaseContactSelectorFragment.java

@@ -12,8 +12,8 @@ import org.briarproject.bramble.api.nullsafety.MethodsNotNullByDefault;
 import org.briarproject.bramble.api.nullsafety.ParametersNotNullByDefault;
 import org.briarproject.bramble.api.sync.GroupId;
 import org.briarproject.briar.R;
+import org.briarproject.briar.android.contact.BaseContactListAdapter.OnContactClickListener;
 import org.briarproject.briar.android.contact.ContactItemViewHolder;
-import org.briarproject.briar.android.contact.OnContactClickListener;
 import org.briarproject.briar.android.controller.handler.UiResultExceptionHandler;
 import org.briarproject.briar.android.fragment.BaseFragment;
 import org.briarproject.briar.android.view.BriarRecyclerView;

briar-android/src/main/java/org/briarproject/briar/android/contactselection/BaseSelectableContactHolder.java

@@ -6,8 +6,8 @@ import android.widget.TextView;
 
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.briar.R;
+import org.briarproject.briar.android.contact.BaseContactListAdapter.OnContactClickListener;
 import org.briarproject.briar.android.contact.ContactItemViewHolder;
-import org.briarproject.briar.android.contact.OnContactClickListener;
 
 import javax.annotation.Nullable;
 

briar-android/src/main/java/org/briarproject/briar/android/contactselection/ContactSelectorAdapter.java

@@ -7,7 +7,6 @@ import android.view.ViewGroup;
 
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.briar.R;
-import org.briarproject.briar.android.contact.OnContactClickListener;
 
 @NotNullByDefault
 class ContactSelectorAdapter extends

briar-android/src/main/java/org/briarproject/briar/android/contactselection/ContactSelectorFragment.java

@@ -8,7 +8,7 @@ import android.view.MenuItem;
 import org.briarproject.bramble.api.nullsafety.MethodsNotNullByDefault;
 import org.briarproject.bramble.api.nullsafety.ParametersNotNullByDefault;
 import org.briarproject.briar.R;
-import org.briarproject.briar.android.contact.OnContactClickListener;
+import org.briarproject.briar.android.contact.BaseContactListAdapter.OnContactClickListener;
 
 @MethodsNotNullByDefault
 @ParametersNotNullByDefault

briar-android/src/main/java/org/briarproject/briar/android/contactselection/SelectableContactHolder.java

@@ -3,7 +3,7 @@ package org.briarproject.briar.android.contactselection;
 import android.view.View;
 
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
-import org.briarproject.briar.android.contact.OnContactClickListener;
+import org.briarproject.briar.android.contact.BaseContactListAdapter.OnContactClickListener;
 
 import javax.annotation.Nullable;
 

briar-android/src/main/java/org/briarproject/briar/android/controller/SharingController.java

@@ -0,0 +1,77 @@
+package org.briarproject.briar.android.controller;
+
+import org.briarproject.bramble.api.contact.ContactId;
+import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
+
+import java.util.Collection;
+
+import androidx.annotation.UiThread;
+
+@Deprecated
+@NotNullByDefault
+public interface SharingController {
+
+	/**
+	 * Sets the listener that is called when contacts go on or offline.
+	 */
+	@UiThread
+	void setSharingListener(SharingListener listener);
+
+	/**
+	 * Unsets the listener.
+	 */
+	@UiThread
+	void unsetSharingListener(SharingListener listener);
+
+	/**
+	 * Call this when your lifecycle starts,
+	 * so the listener will be called when information changes.
+	 */
+	@UiThread
+	void onStart();
+
+	/**
+	 * Call this when your lifecycle stops,
+	 * so that the controller knows it can stops listening to events.
+	 */
+	@UiThread
+	void onStop();
+
+	/**
+	 * Adds one contact to be tracked.
+	 */
+	@UiThread
+	void add(ContactId c);
+
+	/**
+	 * Adds a collection of contacts to be tracked.
+	 */
+	@UiThread
+	void addAll(Collection<ContactId> contacts);
+
+	/**
+	 * Call this when the contact identified by c is no longer sharing
+	 * the given group identified by GroupId g.
+	 */
+	@UiThread
+	void remove(ContactId c);
+
+	/**
+	 * Returns the number of online contacts.
+	 */
+	@UiThread
+	int getOnlineCount();
+
+	/**
+	 * Returns the total number of contacts that have been added.
+	 */
+	@UiThread
+	int getTotalCount();
+
+	interface SharingListener {
+
+		@UiThread
+		void onSharingInfoUpdated(int total, int online);
+	}
+
+}

briar-android/src/main/java/org/briarproject/briar/android/controller/SharingControllerImpl.java

@@ -0,0 +1,109 @@
+package org.briarproject.briar.android.controller;
+
+import org.briarproject.bramble.api.connection.ConnectionRegistry;
+import org.briarproject.bramble.api.contact.ContactId;
+import org.briarproject.bramble.api.event.Event;
+import org.briarproject.bramble.api.event.EventBus;
+import org.briarproject.bramble.api.event.EventListener;
+import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
+import org.briarproject.bramble.api.plugin.event.ContactConnectedEvent;
+import org.briarproject.bramble.api.plugin.event.ContactDisconnectedEvent;
+
+import java.util.Collection;
+import java.util.HashSet;
+import java.util.Set;
+
+import javax.annotation.Nullable;
+import javax.inject.Inject;
+
+import androidx.annotation.UiThread;
+
+@Deprecated
+@NotNullByDefault
+public class SharingControllerImpl implements SharingController, EventListener {
+
+	private final EventBus eventBus;
+	private final ConnectionRegistry connectionRegistry;
+
+	// UI thread
+	private final Set<ContactId> contacts = new HashSet<>();
+
+	// UI thread
+	@Nullable
+	private SharingListener listener;
+
+	@Inject
+	SharingControllerImpl(EventBus eventBus,
+			ConnectionRegistry connectionRegistry) {
+		this.eventBus = eventBus;
+		this.connectionRegistry = connectionRegistry;
+	}
+
+	@Override
+	public void setSharingListener(SharingListener listener) {
+		this.listener = listener;
+	}
+
+	@Override
+	public void unsetSharingListener(SharingListener listener) {
+		if (this.listener == listener) this.listener = null;
+	}
+
+	@Override
+	public void onStart() {
+		eventBus.addListener(this);
+	}
+
+	@Override
+	public void onStop() {
+		eventBus.removeListener(this);
+	}
+
+	@Override
+	public void eventOccurred(Event e) {
+		if (e instanceof ContactConnectedEvent) {
+			setConnected(((ContactConnectedEvent) e).getContactId());
+		} else if (e instanceof ContactDisconnectedEvent) {
+			setConnected(((ContactDisconnectedEvent) e).getContactId());
+		}
+	}
+
+	@UiThread
+	private void setConnected(ContactId c) {
+		if (listener == null) throw new IllegalStateException();
+		if (contacts.contains(c)) {
+			int online = getOnlineCount();
+			listener.onSharingInfoUpdated(contacts.size(), online);
+		}
+	}
+
+	@Override
+	public void addAll(Collection<ContactId> c) {
+		contacts.addAll(c);
+	}
+
+	@Override
+	public void add(ContactId c) {
+		contacts.add(c);
+	}
+
+	@Override
+	public void remove(ContactId c) {
+		contacts.remove(c);
+	}
+
+	@Override
+	public int getOnlineCount() {
+		int online = 0;
+		for (ContactId c : contacts) {
+			if (connectionRegistry.isConnected(c)) online++;
+		}
+		return online;
+	}
+
+	@Override
+	public int getTotalCount() {
+		return contacts.size();
+	}
+
+}

briar-android/src/main/java/org/briarproject/briar/android/conversation/ImageActivity.java

@@ -24,7 +24,10 @@ import org.briarproject.briar.android.attachment.AttachmentItem;
 import org.briarproject.briar.android.util.BriarSnackbarBuilder;
 import org.briarproject.briar.android.view.PullDownLayout;
 
+import java.text.SimpleDateFormat;
+import java.util.Date;
 import java.util.List;
+import java.util.Locale;
 
 import javax.inject.Inject;
 
@@ -290,10 +293,13 @@ public class ImageActivity extends BriarActivity
 
 	@RequiresApi(api = 19)
 	private Intent getCreationIntent() {
+		SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss",
+				Locale.getDefault());
+		String fileName = sdf.format(new Date());
 		Intent intent = new Intent(ACTION_CREATE_DOCUMENT);
 		intent.addCategory(CATEGORY_OPENABLE);
 		intent.setType(getVisibleAttachment().getMimeType());
-		intent.putExtra(EXTRA_TITLE, viewModel.getFileName());
+		intent.putExtra(EXTRA_TITLE, fileName);
 		return intent;
 	}
 

briar-android/src/main/java/org/briarproject/briar/android/conversation/ImageViewModel.java

@@ -225,8 +225,8 @@ public class ImageViewModel extends DbViewModel implements EventListener {
 		});
 	}
 
-	String getFileName() {
+	private String getFileName() {
-		SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd",
+		SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss",
 				Locale.getDefault());
 		return sdf.format(new Date());
 	}

briar-android/src/main/java/org/briarproject/briar/android/forum/ForumListViewModel.java

@@ -145,7 +145,7 @@ class ForumListViewModel extends DbViewModel implements EventListener {
 
 	@UiThread
 	private void onForumPostReceived(GroupId g, ForumPostHeader header) {
-		List<ForumListItem> list = updateListItems(getList(forumItems),
+		List<ForumListItem> list = updateListItems(forumItems,
 				itemToTest -> itemToTest.getForum().getId().equals(g),
 				itemToUpdate -> new ForumListItem(itemToUpdate, header));
 		if (list == null) return;
@@ -156,9 +156,11 @@ class ForumListViewModel extends DbViewModel implements EventListener {
 
 	@UiThread
 	private void onGroupRemoved(GroupId groupId) {
-		removeAndUpdateListItems(forumItems, i ->
+		List<ForumListItem> list = removeListItems(forumItems, i ->
 				i.getForum().getId().equals(groupId)
 		);
+		if (list == null) return;
+		forumItems.setValue(new LiveResult<>(list));
 	}
 
 	void loadForumInvitations() {

briar-android/src/main/java/org/briarproject/briar/android/introduction/ContactChooserFragment.java

@@ -5,41 +5,74 @@ import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
 
+import org.briarproject.bramble.api.connection.ConnectionRegistry;
+import org.briarproject.bramble.api.contact.Contact;
+import org.briarproject.bramble.api.contact.ContactId;
+import org.briarproject.bramble.api.contact.ContactManager;
+import org.briarproject.bramble.api.db.DbException;
 import org.briarproject.bramble.api.nullsafety.MethodsNotNullByDefault;
 import org.briarproject.bramble.api.nullsafety.ParametersNotNullByDefault;
 import org.briarproject.briar.R;
 import org.briarproject.briar.android.activity.ActivityComponent;
-import org.briarproject.briar.android.contact.ContactListAdapter;
+import org.briarproject.briar.android.contact.BaseContactListAdapter.OnContactClickListener;
 import org.briarproject.briar.android.contact.ContactListItem;
-import org.briarproject.briar.android.contact.OnContactClickListener;
+import org.briarproject.briar.android.contact.LegacyContactListAdapter;
 import org.briarproject.briar.android.fragment.BaseFragment;
 import org.briarproject.briar.android.view.BriarRecyclerView;
+import org.briarproject.briar.api.client.MessageTracker.GroupCount;
+import org.briarproject.briar.api.conversation.ConversationManager;
+import org.briarproject.briar.api.identity.AuthorInfo;
+import org.briarproject.briar.api.identity.AuthorManager;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.logging.Logger;
 
 import javax.inject.Inject;
 
 import androidx.annotation.Nullable;
-import androidx.lifecycle.ViewModelProvider;
+import androidx.annotation.UiThread;
 import androidx.recyclerview.widget.LinearLayoutManager;
 
+import static java.util.logging.Level.WARNING;
+import static org.briarproject.bramble.util.LogUtils.logException;
+import static org.briarproject.briar.android.conversation.ConversationActivity.CONTACT_ID;
+
+@UiThread
 @MethodsNotNullByDefault
 @ParametersNotNullByDefault
-public class ContactChooserFragment extends BaseFragment
+public class ContactChooserFragment extends BaseFragment {
-		implements OnContactClickListener<ContactListItem> {
 
-	private static final String TAG = ContactChooserFragment.class.getName();
+	public static final String TAG = ContactChooserFragment.class.getName();
+	private static final Logger LOG = Logger.getLogger(TAG);
 
-	@Inject
-	ViewModelProvider.Factory viewModelFactory;
-
-	private IntroductionViewModel viewModel;
-	private final ContactListAdapter adapter = new ContactListAdapter(this);
 	private BriarRecyclerView list;
+	private LegacyContactListAdapter adapter;
+	private ContactId contactId;
+
+	// Fields that are accessed from background threads must be volatile
+	private volatile Contact c1;
+	@Inject
+	volatile ContactManager contactManager;
+	@Inject
+	volatile AuthorManager authorManager;
+	@Inject
+	volatile ConversationManager conversationManager;
+	@Inject
+	volatile ConnectionRegistry connectionRegistry;
+
+	public static ContactChooserFragment newInstance(ContactId id) {
+		Bundle args = new Bundle();
+
+		ContactChooserFragment fragment = new ContactChooserFragment();
+		args.putInt(CONTACT_ID, id.getInt());
+		fragment.setArguments(args);
+		return fragment;
+	}
 
 	@Override
 	public void injectFragment(ActivityComponent component) {
 		component.inject(this);
-		viewModel = new ViewModelProvider(requireActivity(), viewModelFactory)
-				.get(IntroductionViewModel.class);
 	}
 
 	@Override
@@ -47,20 +80,23 @@ public class ContactChooserFragment extends BaseFragment
 			@Nullable ViewGroup container,
 			@Nullable Bundle savedInstanceState) {
 
-		// change toolbar text (relevant when navigating back to this fragment)
-		requireActivity().setTitle(R.string.introduction_activity_title);
-
 		View contentView = inflater.inflate(R.layout.list, container, false);
 
+		OnContactClickListener<ContactListItem> onContactClickListener =
+				(view, item) -> {
+					if (c1 == null) throw new IllegalStateException();
+					Contact c2 = item.getContact();
+					showMessageScreen(c1, c2);
+				};
+		adapter = new LegacyContactListAdapter(requireActivity(),
+				onContactClickListener);
+
 		list = contentView.findViewById(R.id.list);
 		list.setLayoutManager(new LinearLayoutManager(getActivity()));
 		list.setAdapter(adapter);
 		list.setEmptyText(R.string.no_contacts);
 
-		viewModel.getContactListItems().observe(getViewLifecycleOwner(),
+		contactId = new ContactId(requireArguments().getInt(CONTACT_ID));
-				result -> result.onError(this::handleException)
-						.onSuccess(adapter::submitList)
-		);
 
 		return contentView;
 	}
@@ -68,13 +104,14 @@ public class ContactChooserFragment extends BaseFragment
 	@Override
 	public void onStart() {
 		super.onStart();
-		list.startPeriodicUpdate();
+		loadContacts();
 	}
 
 	@Override
 	public void onStop() {
 		super.onStop();
-		list.stopPeriodicUpdate();
+		adapter.clear();
+		list.showProgressBar();
 	}
 
 	@Override
@@ -82,9 +119,43 @@ public class ContactChooserFragment extends BaseFragment
 		return TAG;
 	}
 
-	@Override
+	private void loadContacts() {
-	public void onItemClick(View view, ContactListItem item) {
+		listener.runOnDbThread(() -> {
-		viewModel.setSecondContactId(item.getContact().getId());
+			try {
-		viewModel.triggerContactSelected();
+				List<ContactListItem> contacts = new ArrayList<>();
+				for (Contact c : contactManager.getContacts()) {
+					if (c.getId().equals(contactId)) {
+						c1 = c;
+					} else {
+						AuthorInfo authorInfo = authorManager.getAuthorInfo(c);
+						ContactId id = c.getId();
+						GroupCount count =
+								conversationManager.getGroupCount(id);
+						boolean connected =
+								connectionRegistry.isConnected(c.getId());
+						contacts.add(new ContactListItem(c, authorInfo,
+								connected, count));
+					}
+				}
+				displayContacts(contacts);
+			} catch (DbException e) {
+				logException(LOG, WARNING, e);
+			}
+		});
 	}
+
+	private void displayContacts(List<ContactListItem> contacts) {
+		runOnUiThreadUnlessDestroyed(() -> {
+			if (contacts.isEmpty()) list.showData();
+			else adapter.addAll(contacts);
+		});
+	}
+
+	private void showMessageScreen(Contact c1, Contact c2) {
+		IntroductionMessageFragment messageFragment =
+				IntroductionMessageFragment
+						.newInstance(c1.getId().getInt(), c2.getId().getInt());
+		showNextFragment(messageFragment);
+	}
+
 }

briar-android/src/main/java/org/briarproject/briar/android/introduction/IntroductionActivity.java

@@ -9,67 +9,30 @@ import org.briarproject.briar.android.activity.ActivityComponent;
 import org.briarproject.briar.android.activity.BriarActivity;
 import org.briarproject.briar.android.fragment.BaseFragment.BaseFragmentListener;
 
-import javax.inject.Inject;
-
-import androidx.annotation.NonNull;
-import androidx.lifecycle.ViewModelProvider;
-
 import static org.briarproject.briar.android.conversation.ConversationActivity.CONTACT_ID;
 
 public class IntroductionActivity extends BriarActivity
 		implements BaseFragmentListener {
 
-	@Inject
-	ViewModelProvider.Factory viewModelFactory;
-
-	private IntroductionViewModel viewModel;
-
-	@Override
-	public void injectActivity(ActivityComponent component) {
-		component.inject(this);
-		viewModel = new ViewModelProvider(this, viewModelFactory)
-				.get(IntroductionViewModel.class);
-	}
-
-	private static final String BUNDLE_CONTACT2 = "contact2";
-
 	@Override
 	public void onCreate(Bundle savedInstanceState) {
 		super.onCreate(savedInstanceState);
 
 		Intent intent = getIntent();
-		int contactId1 = intent.getIntExtra(CONTACT_ID, -1);
+		int id = intent.getIntExtra(CONTACT_ID, -1);
-		if (contactId1 == -1)
+		if (id == -1) throw new IllegalStateException("No ContactId");
-			throw new IllegalStateException("No ContactId");
+		ContactId contactId = new ContactId(id);
-		ContactId firstContactId = new ContactId(contactId1);
-
-		viewModel.setFirstContactId(firstContactId);
 
 		setContentView(R.layout.activity_fragment_container);
 
 		if (savedInstanceState == null) {
-			showInitialFragment(new ContactChooserFragment());
+			showInitialFragment(ContactChooserFragment.newInstance(contactId));
-		} else {
-			int contactId2 = savedInstanceState.getInt(BUNDLE_CONTACT2);
-			ContactId secondContactId = new ContactId(contactId2);
-			viewModel.setSecondContactId(secondContactId);
 		}
-
-		viewModel.getSecondContactSelected().observeEvent(this, e -> {
-			IntroductionMessageFragment fragment =
-					new IntroductionMessageFragment();
-			showNextFragment(fragment);
-		});
 	}
 
 	@Override
-	public void onSaveInstanceState(@NonNull Bundle outState) {
+	public void injectActivity(ActivityComponent component) {
-		super.onSaveInstanceState(outState);
+		component.inject(this);
-
-		ContactId secondContactId = viewModel.getSecondContactId();
-		if (secondContactId != null) {
-			outState.putInt(BUNDLE_CONTACT2, secondContactId.getInt());
-		}
 	}
 
 }

briar-android/src/main/java/org/briarproject/briar/android/introduction/IntroductionInfo.java

@@ -1,28 +0,0 @@
-package org.briarproject.briar.android.introduction;
-
-import org.briarproject.briar.android.contact.ContactItem;
-
-class IntroductionInfo {
-	private final ContactItem c1;
-	private final ContactItem c2;
-	private final boolean possible;
-
-	IntroductionInfo(ContactItem c1, ContactItem c2,
-			boolean possible) {
-		this.c1 = c1;
-		this.c2 = c2;
-		this.possible = possible;
-	}
-
-	ContactItem getContact1() {
-		return c1;
-	}
-
-	ContactItem getContact2() {
-		return c2;
-	}
-
-	boolean isPossible() {
-		return possible;
-	}
-}

briar-android/src/main/java/org/briarproject/briar/android/introduction/IntroductionMessageFragment.java

@@ -1,5 +1,6 @@
 package org.briarproject.briar.android.introduction;
 
+import android.content.Context;
 import android.os.Bundle;
 import android.view.LayoutInflater;
 import android.view.MenuItem;
@@ -7,7 +8,12 @@ import android.view.View;
 import android.view.ViewGroup;
 import android.widget.ProgressBar;
 import android.widget.TextView;
+import android.widget.Toast;
 
+import org.briarproject.bramble.api.contact.Contact;
+import org.briarproject.bramble.api.contact.ContactId;
+import org.briarproject.bramble.api.contact.ContactManager;
+import org.briarproject.bramble.api.db.DbException;
 import org.briarproject.bramble.api.nullsafety.MethodsNotNullByDefault;
 import org.briarproject.bramble.api.nullsafety.ParametersNotNullByDefault;
 import org.briarproject.briar.R;
@@ -18,19 +24,25 @@ import org.briarproject.briar.android.view.TextInputView;
 import org.briarproject.briar.android.view.TextSendController;
 import org.briarproject.briar.android.view.TextSendController.SendListener;
 import org.briarproject.briar.api.attachment.AttachmentHeader;
+import org.briarproject.briar.api.identity.AuthorInfo;
+import org.briarproject.briar.api.identity.AuthorManager;
+import org.briarproject.briar.api.introduction.IntroductionManager;
 
 import java.util.List;
+import java.util.logging.Logger;
 
 import javax.inject.Inject;
 
 import androidx.annotation.Nullable;
-import androidx.fragment.app.FragmentActivity;
+import androidx.appcompat.app.ActionBar;
-import androidx.lifecycle.ViewModelProvider;
 import de.hdodenhof.circleimageview.CircleImageView;
 
 import static android.app.Activity.RESULT_OK;
 import static android.view.View.GONE;
 import static android.view.View.VISIBLE;
+import static android.widget.Toast.LENGTH_SHORT;
+import static java.util.logging.Level.WARNING;
+import static org.briarproject.bramble.util.LogUtils.logException;
 import static org.briarproject.briar.android.util.UiUtils.getContactDisplayName;
 import static org.briarproject.briar.android.util.UiUtils.hideSoftKeyboard;
 import static org.briarproject.briar.android.view.AuthorView.setAvatar;
@@ -41,21 +53,45 @@ import static org.briarproject.briar.api.introduction.IntroductionConstants.MAX_
 public class IntroductionMessageFragment extends BaseFragment
 		implements SendListener {
 
-	private static final String TAG =
+	public static final String TAG =
 			IntroductionMessageFragment.class.getName();
+	private static final Logger LOG = Logger.getLogger(TAG);
 
-	@Inject
+	private final static String CONTACT_ID_1 = "contact1";
-	ViewModelProvider.Factory viewModelFactory;
+	private final static String CONTACT_ID_2 = "contact2";
-
-	private IntroductionViewModel viewModel;
 
+	private IntroductionActivity introductionActivity;
 	private ViewHolder ui;
+	private Contact contact1, contact2;
+
+	// Fields that are accessed from background threads must be volatile
+	@Inject
+	protected volatile ContactManager contactManager;
+	@Inject
+	protected volatile AuthorManager authorManager;
+	@Inject
+	protected volatile IntroductionManager introductionManager;
+
+	public static IntroductionMessageFragment newInstance(int contactId1,
+			int contactId2) {
+		Bundle args = new Bundle();
+		args.putInt(CONTACT_ID_1, contactId1);
+		args.putInt(CONTACT_ID_2, contactId2);
+		IntroductionMessageFragment fragment =
+				new IntroductionMessageFragment();
+		fragment.setArguments(args);
+		return fragment;
+	}
+
+	@Override
+	public void onAttach(Context context) {
+		super.onAttach(context);
+		introductionActivity = (IntroductionActivity) context;
+	}
 
 	@Override
 	public void injectFragment(ActivityComponent component) {
 		component.inject(this);
-		viewModel = new ViewModelProvider(requireActivity(), viewModelFactory)
-				.get(IntroductionViewModel.class);
 	}
 
 	@Override
@@ -64,7 +100,18 @@ public class IntroductionMessageFragment extends BaseFragment
 			@Nullable Bundle savedInstanceState) {
 
 		// change toolbar text
-		requireActivity().setTitle(R.string.introduction_message_title);
+		ActionBar actionBar = introductionActivity.getSupportActionBar();
+		if (actionBar != null) {
+			actionBar.setTitle(R.string.introduction_message_title);
+		}
+
+		// get contact IDs from fragment arguments
+		Bundle args = requireArguments();
+		int contactId1 = args.getInt(CONTACT_ID_1, -1);
+		int contactId2 = args.getInt(CONTACT_ID_2, -1);
+		if (contactId1 == -1 || contactId2 == -1) {
+			throw new AssertionError("Use newInstance() to instantiate");
+		}
 
 		// inflate view
 		View v = inflater.inflate(R.layout.introduction_message, container,
@@ -76,44 +123,69 @@ public class IntroductionMessageFragment extends BaseFragment
 		ui.message.setMaxTextLength(MAX_INTRODUCTION_TEXT_LENGTH);
 		ui.message.setReady(false);
 
-		viewModel.getIntroductionInfo().observe(getViewLifecycleOwner(), ii -> {
+		// get contacts and then show view
-			if (ii == null) {
+		prepareToSetUpViews(contactId1, contactId2);
-				return;
-			}
-			setUpViews(ii.getContact1(), ii.getContact2(),
-					ii.isPossible());
-		});
 
 		return v;
 	}
 
+	@Override
+	public void onStart() {
+		super.onStart();
+	}
+
 	@Override
 	public String getUniqueTag() {
 		return TAG;
 	}
 
+	private void prepareToSetUpViews(int contactId1, int contactId2) {
+		introductionActivity.runOnDbThread(() -> {
+			try {
+				Contact contact1 =
+						contactManager.getContact(new ContactId(contactId1));
+				Contact contact2 =
+						contactManager.getContact(new ContactId(contactId2));
+				AuthorInfo a1 = authorManager.getAuthorInfo(contact1);
+				AuthorInfo a2 = authorManager.getAuthorInfo(contact2);
+				boolean possible =
+						introductionManager.canIntroduce(contact1, contact2);
+				ContactItem c1 = new ContactItem(contact1, a1);
+				ContactItem c2 = new ContactItem(contact2, a2);
+				setUpViews(c1, c2, possible);
+			} catch (DbException e) {
+				logException(LOG, WARNING, e);
+			}
+		});
+	}
+
 	private void setUpViews(ContactItem c1, ContactItem c2, boolean possible) {
-		// set avatars
+		introductionActivity.runOnUiThreadUnlessDestroyed(() -> {
-		setAvatar(ui.avatar1, c1);
+			contact1 = c1.getContact();
-		setAvatar(ui.avatar2, c2);
+			contact2 = c2.getContact();
 
-		// set contact names
+			// set avatars
-		ui.contactName1.setText(getContactDisplayName(c1.getContact()));
+			setAvatar(ui.avatar1, c1);
-		ui.contactName2.setText(getContactDisplayName(c2.getContact()));
+			setAvatar(ui.avatar2, c2);
 
-		// hide progress bar
+			// set contact names
-		ui.progressBar.setVisibility(GONE);
+			ui.contactName1.setText(getContactDisplayName(c1.getContact()));
+			ui.contactName2.setText(getContactDisplayName(c2.getContact()));
 
-		if (possible) {
+			// hide progress bar
-			// show views
+			ui.progressBar.setVisibility(GONE);
-			ui.notPossible.setVisibility(GONE);
+
-			ui.message.setVisibility(VISIBLE);
+			if (possible) {
-			ui.message.setReady(true);
+				// show views
-			ui.message.showSoftKeyboard();
+				ui.notPossible.setVisibility(GONE);
-		} else {
+				ui.message.setVisibility(VISIBLE);
-			ui.notPossible.setVisibility(VISIBLE);
+				ui.message.setReady(true);
-			ui.message.setVisibility(GONE);
+				ui.message.showSoftKeyboard();
-		}
+			} else {
+				ui.notPossible.setVisibility(VISIBLE);
+				ui.message.setVisibility(GONE);
+			}
+		});
 	}
 
 	@Override
@@ -121,7 +193,7 @@ public class IntroductionMessageFragment extends BaseFragment
 		switch (item.getItemId()) {
 			case android.R.id.home:
 				hideSoftKeyboard(ui.message);
-				requireActivity().onBackPressed();
+				introductionActivity.onBackPressed();
 				return true;
 			default:
 				return super.onOptionsItemSelected(item);
@@ -134,13 +206,32 @@ public class IntroductionMessageFragment extends BaseFragment
 		// disable button to prevent accidental double invitations
 		ui.message.setReady(false);
 
-		viewModel.makeIntroduction(text);
+		makeIntroduction(contact1, contact2, text);
 
 		// don't wait for the introduction to be made before finishing activity
 		hideSoftKeyboard(ui.message);
-		FragmentActivity activity = requireActivity();
+		introductionActivity.setResult(RESULT_OK);
-		activity.setResult(RESULT_OK);
+		introductionActivity.supportFinishAfterTransition();
-		activity.supportFinishAfterTransition();
+	}
+
+	private void makeIntroduction(Contact c1, Contact c2,
+			@Nullable String text) {
+		introductionActivity.runOnDbThread(() -> {
+			// actually make the introduction
+			try {
+				long timestamp = System.currentTimeMillis();
+				introductionManager.makeIntroduction(c1, c2, text, timestamp);
+			} catch (DbException e) {
+				logException(LOG, WARNING, e);
+				introductionError();
+			}
+		});
+	}
+
+	private void introductionError() {
+		introductionActivity.runOnUiThreadUnlessDestroyed(
+				() -> Toast.makeText(introductionActivity,
+						R.string.introduction_error, LENGTH_SHORT).show());
 	}
 
 	private static class ViewHolder {

briar-android/src/main/java/org/briarproject/briar/android/introduction/IntroductionModule.java

@@ -1,19 +0,0 @@
-package org.briarproject.briar.android.introduction;
-
-import org.briarproject.briar.android.viewmodel.ViewModelKey;
-
-import androidx.lifecycle.ViewModel;
-import dagger.Binds;
-import dagger.Module;
-import dagger.multibindings.IntoMap;
-
-@Module
-public abstract class IntroductionModule {
-
-	@Binds
-	@IntoMap
-	@ViewModelKey(IntroductionViewModel.class)
-	abstract ViewModel bindIntroductionViewModel(
-			IntroductionViewModel introductionViewModel);
-
-}

briar-android/src/main/java/org/briarproject/briar/android/introduction/IntroductionViewModel.java

@@ -1,181 +0,0 @@
-package org.briarproject.briar.android.introduction;
-
-import android.app.Application;
-import android.widget.Toast;
-
-import org.briarproject.bramble.api.connection.ConnectionRegistry;
-import org.briarproject.bramble.api.contact.Contact;
-import org.briarproject.bramble.api.contact.ContactId;
-import org.briarproject.bramble.api.contact.ContactManager;
-import org.briarproject.bramble.api.db.DatabaseExecutor;
-import org.briarproject.bramble.api.db.DbException;
-import org.briarproject.bramble.api.db.TransactionManager;
-import org.briarproject.bramble.api.event.EventBus;
-import org.briarproject.bramble.api.lifecycle.LifecycleManager;
-import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
-import org.briarproject.bramble.api.system.AndroidExecutor;
-import org.briarproject.briar.R;
-import org.briarproject.briar.android.contact.ContactItem;
-import org.briarproject.briar.android.contact.ContactsViewModel;
-import org.briarproject.briar.android.viewmodel.LiveEvent;
-import org.briarproject.briar.android.viewmodel.MutableLiveEvent;
-import org.briarproject.briar.api.conversation.ConversationManager;
-import org.briarproject.briar.api.identity.AuthorInfo;
-import org.briarproject.briar.api.identity.AuthorManager;
-import org.briarproject.briar.api.introduction.IntroductionManager;
-
-import java.util.concurrent.Executor;
-import java.util.logging.Logger;
-
-import javax.inject.Inject;
-
-import androidx.annotation.Nullable;
-import androidx.lifecycle.LiveData;
-import androidx.lifecycle.MutableLiveData;
-
-import static android.widget.Toast.LENGTH_SHORT;
-import static java.util.Objects.requireNonNull;
-import static java.util.logging.Level.WARNING;
-import static java.util.logging.Logger.getLogger;
-import static org.briarproject.bramble.util.LogUtils.logException;
-
-@NotNullByDefault
-class IntroductionViewModel extends ContactsViewModel {
-
-	private static final Logger LOG =
-			getLogger(IntroductionViewModel.class.getName());
-
-	private final ContactManager contactManager;
-	private final AuthorManager authorManager;
-	private final IntroductionManager introductionManager;
-
-	@Inject
-	IntroductionViewModel(Application application,
-			@DatabaseExecutor Executor dbExecutor,
-			LifecycleManager lifecycleManager, TransactionManager db,
-			AndroidExecutor androidExecutor, ContactManager contactManager,
-			AuthorManager authorManager,
-			ConversationManager conversationManager,
-			ConnectionRegistry connectionRegistry, EventBus eventBus,
-			IntroductionManager introductionManager) {
-		super(application, dbExecutor, lifecycleManager, db, androidExecutor,
-				contactManager, authorManager, conversationManager,
-				connectionRegistry, eventBus);
-		this.contactManager = contactManager;
-		this.authorManager = authorManager;
-		this.introductionManager = introductionManager;
-	}
-
-	/*
-	 * This is the contact from whose conversation we started the introduction
-	 * using the menu item.
-	 */
-	@Nullable
-	private ContactId firstContactId;
-	/*
-	 * This is the contact we selected from the list of contacts as a second
-	 * contact for the introduction.
-	 */
-	@Nullable
-	private ContactId secondContactId;
-
-	private final MutableLiveEvent<Boolean> secondContactSelected =
-			new MutableLiveEvent<>();
-
-	private final MutableLiveData<IntroductionInfo> introductionInfo =
-			new MutableLiveData<>();
-
-	void setFirstContactId(ContactId contactId) {
-		this.firstContactId = contactId;
-		loadContacts();
-	}
-
-	@Nullable
-	ContactId getSecondContactId() {
-		return secondContactId;
-	}
-
-	void setSecondContactId(ContactId contactId) {
-		secondContactId = contactId;
-		// Setting this to null here so that IntroductionMessageFragment can
-		// tell whether the correct value has been loaded from the database when
-		// selecting a second contact repeatedly.
-		introductionInfo.setValue(null);
-		loadIntroductionInfo();
-	}
-
-	/**
-	 * Trigger the event that the second contact has been selected from the
-	 * contact list by the user.
-	 */
-	void triggerContactSelected() {
-		secondContactSelected.setEvent(true);
-	}
-
-	/**
-	 * This event will be triggered once the second contact has been selected
-	 * from the list of contacts displayed. It is not fired when the second
-	 * contact gets restored from the saved instance state.
-	 */
-	LiveEvent<Boolean> getSecondContactSelected() {
-		return secondContactSelected;
-	}
-
-	/**
-	 * Holder for the introduction info object with data about both contacts
-	 * and whether the introduction is possible. May wrap null if the data
-	 * is not available yet. This happens when it is reset by selecting a
-	 * contact with the same view model instance more than once.
-	 */
-	LiveData<IntroductionInfo> getIntroductionInfo() {
-		return introductionInfo;
-	}
-
-	@Override
-	protected boolean displayContact(ContactId contactId) {
-		return !requireNonNull(firstContactId).equals(contactId);
-	}
-
-	private void loadIntroductionInfo() {
-		final ContactId firstContactId = requireNonNull(this.firstContactId);
-		final ContactId secondContactId = requireNonNull(this.secondContactId);
-		runOnDbThread(() -> {
-			try {
-				Contact firstContact =
-						contactManager.getContact(firstContactId);
-				Contact secondContact =
-						contactManager.getContact(secondContactId);
-				AuthorInfo a1 = authorManager.getAuthorInfo(firstContact);
-				AuthorInfo a2 = authorManager.getAuthorInfo(secondContact);
-				boolean possible = introductionManager
-						.canIntroduce(firstContact, secondContact);
-				ContactItem c1 = new ContactItem(firstContact, a1);
-				ContactItem c2 = new ContactItem(secondContact, a2);
-				introductionInfo.postValue(
-						new IntroductionInfo(c1, c2, possible));
-			} catch (DbException e) {
-				logException(LOG, WARNING, e);
-			}
-		});
-	}
-
-	void makeIntroduction(@Nullable String text) {
-		final IntroductionInfo info =
-				requireNonNull(introductionInfo.getValue());
-		runOnDbThread(() -> {
-			// actually make the introduction
-			try {
-				long timestamp = System.currentTimeMillis();
-				introductionManager.makeIntroduction(
-						info.getContact1().getContact(),
-						info.getContact2().getContact(), text, timestamp);
-			} catch (DbException e) {
-				logException(LOG, WARNING, e);
-				androidExecutor.runOnUiThread(() -> Toast.makeText(
-						getApplication(), R.string.introduction_error,
-						LENGTH_SHORT).show());
-			}
-		});
-	}
-
-}

briar-android/src/main/java/org/briarproject/briar/android/privategroup/list/GroupListViewModel.java

@@ -2,6 +2,7 @@ package org.briarproject.briar.android.privategroup.list;
 
 import android.app.Application;
 
+import org.briarproject.bramble.api.contact.ContactManager;
 import org.briarproject.bramble.api.db.DatabaseExecutor;
 import org.briarproject.bramble.api.db.DbException;
 import org.briarproject.bramble.api.db.Transaction;
@@ -172,7 +173,7 @@ class GroupListViewModel extends DbViewModel implements EventListener {
 	@UiThread
 	private void onGroupMessageAdded(GroupMessageHeader header) {
 		GroupId g = header.getGroupId();
-		List<GroupItem> list = updateListItems(getList(groupItems),
+		List<GroupItem> list = updateListItems(groupItems,
 				itemToTest -> itemToTest.getId().equals(g),
 				itemToUpdate -> new GroupItem(itemToUpdate, header));
 		if (list == null) return;
@@ -183,7 +184,7 @@ class GroupListViewModel extends DbViewModel implements EventListener {
 
 	@UiThread
 	private void onGroupDissolved(GroupId groupId) {
-		List<GroupItem> list = updateListItems(getList(groupItems),
+		List<GroupItem> list = updateListItems(groupItems,
 				itemToTest -> itemToTest.getId().equals(groupId),
 				itemToUpdate -> new GroupItem(itemToUpdate, true));
 		if (list == null) return;
@@ -192,7 +193,10 @@ class GroupListViewModel extends DbViewModel implements EventListener {
 
 	@UiThread
 	private void onGroupRemoved(GroupId groupId) {
-		removeAndUpdateListItems(groupItems, i -> i.getId().equals(groupId));
+		List<GroupItem> list =
+				removeListItems(groupItems, i -> i.getId().equals(groupId));
+		if (list == null) return;
+		groupItems.setValue(new LiveResult<>(list));
 	}
 
 	void removeGroup(GroupId g) {

briar-android/src/main/java/org/briarproject/briar/android/privategroup/reveal/RevealContactsFragment.java

@@ -8,7 +8,7 @@ import org.briarproject.bramble.api.nullsafety.MethodsNotNullByDefault;
 import org.briarproject.bramble.api.nullsafety.ParametersNotNullByDefault;
 import org.briarproject.bramble.api.sync.GroupId;
 import org.briarproject.briar.android.activity.ActivityComponent;
-import org.briarproject.briar.android.contact.OnContactClickListener;
+import org.briarproject.briar.android.contact.BaseContactListAdapter.OnContactClickListener;
 import org.briarproject.briar.android.contactselection.BaseContactSelectorFragment;
 import org.briarproject.briar.android.contactselection.ContactSelectorController;
 

briar-android/src/main/java/org/briarproject/briar/android/privategroup/reveal/RevealableContactAdapter.java

@@ -8,7 +8,6 @@ import android.view.ViewGroup;
 import org.briarproject.bramble.api.contact.ContactId;
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.briar.R;
-import org.briarproject.briar.android.contact.OnContactClickListener;
 import org.briarproject.briar.android.contactselection.BaseContactSelectorAdapter;
 
 import java.util.ArrayList;

briar-android/src/main/java/org/briarproject/briar/android/privategroup/reveal/RevealableContactViewHolder.java

@@ -5,7 +5,7 @@ import android.widget.ImageView;
 
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.briar.R;
-import org.briarproject.briar.android.contact.OnContactClickListener;
+import org.briarproject.briar.android.contact.BaseContactListAdapter.OnContactClickListener;
 import org.briarproject.briar.android.contactselection.BaseSelectableContactHolder;
 
 import javax.annotation.Nullable;

briar-android/src/main/java/org/briarproject/briar/android/util/UiUtils.java

@@ -34,6 +34,7 @@ import org.briarproject.bramble.api.nullsafety.ParametersNotNullByDefault;
 import org.briarproject.briar.R;
 import org.briarproject.briar.android.reporting.FeedbackActivity;
 import org.briarproject.briar.android.view.ArticleMovementMethod;
+import org.briarproject.briar.android.widget.LinkDialogFragment;
 
 import java.util.Locale;
 
@@ -48,8 +49,8 @@ import androidx.appcompat.app.AlertDialog;
 import androidx.core.content.ContextCompat;
 import androidx.core.hardware.fingerprint.FingerprintManagerCompat;
 import androidx.core.text.HtmlCompat;
-import androidx.core.util.Consumer;
 import androidx.fragment.app.FragmentActivity;
+import androidx.fragment.app.FragmentManager;
 import androidx.lifecycle.LifecycleOwner;
 import androidx.lifecycle.LiveData;
 import androidx.lifecycle.Observer;
@@ -58,7 +59,6 @@ import androidx.vectordrawable.graphics.drawable.VectorDrawableCompat;
 import static android.content.Context.KEYGUARD_SERVICE;
 import static android.content.Context.POWER_SERVICE;
 import static android.content.Intent.ACTION_GET_CONTENT;
-import static android.content.Intent.ACTION_OPEN_DOCUMENT;
 import static android.content.Intent.CATEGORY_DEFAULT;
 import static android.content.Intent.CATEGORY_OPENABLE;
 import static android.content.Intent.EXTRA_ALLOW_MULTIPLE;
@@ -197,7 +197,8 @@ public class UiUtils {
 	}
 
 	public static void makeLinksClickable(TextView v,
-			Consumer<String> onLinkClicked) {
+			@Nullable FragmentManager fm) {
+		if (fm == null) return;
 		SpannableStringBuilder ssb = new SpannableStringBuilder(v.getText());
 		URLSpan[] spans = ssb.getSpans(0, ssb.length(), URLSpan.class);
 		for (URLSpan span : spans) {
@@ -208,7 +209,8 @@ public class UiUtils {
 			ClickableSpan cSpan = new ClickableSpan() {
 				@Override
 				public void onClick(View v2) {
-					onLinkClicked.accept(url);
+					LinkDialogFragment f = LinkDialogFragment.newInstance(url);
+					f.show(fm, f.getUniqueTag());
 				}
 			};
 			ssb.setSpan(cSpan, start, end, 0);
@@ -255,8 +257,9 @@ public class UiUtils {
 	}
 
 	public static Intent createSelectImageIntent(boolean allowMultiple) {
-		Intent intent = new Intent(SDK_INT >= 19 ?
+		// ACTION_GET_CONTENT returns more content providers than
-				ACTION_OPEN_DOCUMENT : ACTION_GET_CONTENT);
+		// ACTION_OPEN_DOCUMENT (https://stackoverflow.com/questions/27568139/)
+		Intent intent = new Intent(ACTION_GET_CONTENT);
 		intent.setType("image/*");
 		intent.addCategory(CATEGORY_OPENABLE);
 		if (SDK_INT >= 19)

briar-android/src/main/java/org/briarproject/briar/android/view/BriarRecyclerView.java

@@ -52,8 +52,7 @@ public class BriarRecyclerView extends FrameLayout {
 				R.styleable.BriarRecyclerView);
 		isScrollingToEnd = attributes
 				.getBoolean(R.styleable.BriarRecyclerView_scrollToEnd, true);
-		int drawableRes = attributes
+		int drawableRes = attributes.getResourceId(R.styleable.BriarRecyclerView_emptyImage, -1);
-				.getResourceId(R.styleable.BriarRecyclerView_emptyImage, -1);
 		if (drawableRes != -1) setEmptyImage(drawableRes);
 		String emtpyText =
 				attributes.getString(R.styleable.BriarRecyclerView_emptyText);
@@ -88,30 +87,10 @@ public class BriarRecyclerView extends FrameLayout {
 		}
 
 		emptyObserver = new RecyclerView.AdapterDataObserver() {
-
-			@Override
-			public void onChanged() {
-				super.onChanged();
-				showData();
-			}
-
-			@Override
-			public void onItemRangeChanged(int positionStart, int itemCount) {
-				super.onItemRangeChanged(positionStart, itemCount);
-				if (itemCount > 0) showData();
-			}
-
-			@Override
-			public void onItemRangeMoved(int fromPosition, int toPosition,
-					int itemCount) {
-				super.onItemRangeMoved(fromPosition, toPosition, itemCount);
-				if (itemCount > 0) showData();
-			}
-
 			@Override
 			public void onItemRangeInserted(int positionStart, int itemCount) {
 				super.onItemRangeInserted(positionStart, itemCount);
-				showData();
+				if (itemCount > 0) showData();
 			}
 
 			@Override

briar-android/src/main/java/org/briarproject/briar/android/viewmodel/DbViewModel.java

@@ -1,7 +1,6 @@
 package org.briarproject.briar.android.viewmodel;
 
 import android.app.Application;
-import android.widget.Toast;
 
 import org.briarproject.bramble.api.db.DatabaseExecutor;
 import org.briarproject.bramble.api.db.DbCallable;
@@ -12,10 +11,8 @@ import org.briarproject.bramble.api.db.TransactionManager;
 import org.briarproject.bramble.api.lifecycle.LifecycleManager;
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.bramble.api.system.AndroidExecutor;
-import org.briarproject.bramble.util.StringUtils;
 
 import java.util.ArrayList;
-import java.util.Collection;
 import java.util.List;
 import java.util.ListIterator;
 import java.util.concurrent.Executor;
@@ -23,7 +20,6 @@ import java.util.logging.Logger;
 
 import javax.annotation.concurrent.Immutable;
 
-import androidx.annotation.AnyThread;
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.annotation.UiThread;
@@ -31,10 +27,8 @@ import androidx.arch.core.util.Function;
 import androidx.core.util.Consumer;
 import androidx.lifecycle.AndroidViewModel;
 import androidx.lifecycle.LiveData;
-import androidx.lifecycle.MutableLiveData;
 import androidx.recyclerview.widget.RecyclerView;
 
-import static android.widget.Toast.LENGTH_LONG;
 import static java.util.logging.Level.WARNING;
 import static java.util.logging.Logger.getLogger;
 import static org.briarproject.bramble.util.LogUtils.logException;
@@ -49,7 +43,7 @@ public abstract class DbViewModel extends AndroidViewModel {
 	private final Executor dbExecutor;
 	private final LifecycleManager lifecycleManager;
 	private final TransactionManager db;
-	protected final AndroidExecutor androidExecutor;
+	private final AndroidExecutor androidExecutor;
 
 	public DbViewModel(
 			@NonNull Application application,
@@ -120,11 +114,9 @@ public abstract class DbViewModel extends AndroidViewModel {
 	 * This method ensures that those operations can be processed on the
 	 * UiThread in the correct order so that the removed message will not be
 	 * re-added when the re-load completes.
-	 *
-	 * TODO: Rename this method and update javadoc, as it's not restricted to
-	 *  lists
 	 */
-	protected <T> void loadList(DbCallable<T, DbException> task,
+	protected <T extends List<?>> void loadList(
+			DbCallable<T, DbException> task,
 			UiConsumer<LiveResult<T>> uiConsumer) {
 		dbExecutor.execute(() -> {
 			try {
@@ -151,46 +143,25 @@ public abstract class DbViewModel extends AndroidViewModel {
 	}
 
 	/**
-	 * Creates a copy of the given list and adds the given item to the copy.
+	 * Creates a copy of the list available in the given LiveData
+	 * and replaces items where the given test function returns true.
 	 *
-	 * @return an updated copy of the list, or null if the list is null
+	 * @return a copy of the list in the LiveData with item(s) replaced
+	 * or null when the
+	 * <ul>
+	 * <li> LiveData does not have a value
+	 * <li> LiveResult in the LiveData has an error
+	 * <li> test function did return false for all items in the list
+	 * </ul>
 	 */
 	@Nullable
-	protected <T> List<T> addListItem(@Nullable List<T> list, T item) {
+	protected <T> List<T> updateListItems(
-		if (list == null) return null;
+			LiveData<LiveResult<List<T>>> liveData, Function<T, Boolean> test,
-		List<T> copy = new ArrayList<>(list);
+			Function<T, T> replacer) {
-		copy.add(item);
+		List<T> items = getListCopy(liveData);
-		return copy;
+		if (items == null) return null;
-	}
 
-	/**
+		ListIterator<T> iterator = items.listIterator();
-	 * Creates a copy of the given list and adds the given items to the copy.
-	 *
-	 * @return an updated copy of the list, or null if the list is null
-	 */
-	@Nullable
-	protected <T> List<T> addListItems(@Nullable List<T> list,
-			Collection<T> items) {
-		if (list == null) return null;
-		List<T> copy = new ArrayList<>(list);
-		copy.addAll(items);
-		return copy;
-	}
-
-	/**
-	 * Creates a copy of the given list, replacing items where the given test
-	 * function returns true.
-	 *
-	 * @return an updated copy of the list, or null if either the list is null
-	 * or the test function returns false for all items
-	 */
-	@Nullable
-	protected <T> List<T> updateListItems(@Nullable List<T> list,
-			Function<T, Boolean> test, Function<T, T> replacer) {
-		if (list == null) return null;
-		List<T> copy = new ArrayList<>(list);
-
-		ListIterator<T> iterator = copy.listIterator();
 		boolean changed = false;
 		while (iterator.hasNext()) {
 			T item = iterator.next();
@@ -199,23 +170,28 @@ public abstract class DbViewModel extends AndroidViewModel {
 				iterator.set(replacer.apply(item));
 			}
 		}
-		return changed ? copy : null;
+		return changed ? items : null;
 	}
 
 	/**
-	 * Creates a copy of the given list, removing items from it where the given
+	 * Creates a copy of the list available in the given LiveData
-	 * test function returns true.
+	 * and removes the items from it where the given test function returns true.
 	 *
-	 * @return an updated copy of the list, or null if either the list is null
+	 * @return a copy of the list in the LiveData with item(s) removed
-	 * or the test function returns false for all items
+	 * or null when the
+	 * <ul>
+	 * <li> LiveData does not have a value
+	 * <li> LiveResult in the LiveData has an error
+	 * <li> test function did return false for all items in the list
+	 * </ul>
 	 */
 	@Nullable
-	protected <T> List<T> removeListItems(@Nullable List<T> list,
+	protected <T> List<T> removeListItems(
-			Function<T, Boolean> test) {
+			LiveData<LiveResult<List<T>>> liveData, Function<T, Boolean> test) {
-		if (list == null) return null;
+		List<T> items = getListCopy(liveData);
-		List<T> copy = new ArrayList<>(list);
+		if (items == null) return null;
 
-		ListIterator<T> iterator = copy.listIterator();
+		ListIterator<T> iterator = items.listIterator();
 		boolean changed = false;
 		while (iterator.hasNext()) {
 			T item = iterator.next();
@@ -224,58 +200,21 @@ public abstract class DbViewModel extends AndroidViewModel {
 				iterator.remove();
 			}
 		}
-		return changed ? copy : null;
+		return changed ? items : null;
 	}
 
 	/**
-	 * Updates the given LiveData with a copy of its list
+	 * Retrieves a copy of the list of items from the given LiveData
-	 * with the items removed where the given test function returns true.
+	 * or null if it is not available.
-	 * <p>
+	 * The list copy can be safely mutated.
-	 * Nothing is updated, if the
-	 * <ul>
-	 * <li> LiveData does not have a value
-	 * <li> LiveResult in the LiveData has an error
-	 * <li> test function returned false for all items in the list
-	 * </ul>
-	 */
-	@UiThread
-	protected <T> void removeAndUpdateListItems(
-			MutableLiveData<LiveResult<List<T>>> liveData,
-			Function<T, Boolean> test) {
-		List<T> copy = removeListItems(getList(liveData), test);
-		if (copy != null) liveData.setValue(new LiveResult<>(copy));
-	}
-
-	/**
-	 * Returns the list of items from the given LiveData, or null if no list is
-	 * available.
 	 */
 	@Nullable
-	protected <T> List<T> getList(LiveData<LiveResult<List<T>>> liveData) {
+	private <T> List<T> getListCopy(LiveData<LiveResult<List<T>>> liveData) {
 		LiveResult<List<T>> value = liveData.getValue();
 		if (value == null) return null;
-		return value.getResultOrNull();
+		List<T> list = value.getResultOrNull();
-	}
+		if (list == null) return null;
-
+		return new ArrayList<>(list);
-	/**
-	 * Logs the exception and shows a Toast to the user.
-	 * <p>
-	 * Errors that are likely or expected to happen should not use this method
-	 * and show proper error states in UI.
-	 */
-	@AnyThread
-	protected void handleException(Exception e) {
-		logException(LOG, WARNING, e);
-		androidExecutor.runOnUiThread(() -> {
-			String msg = "Error: " + e.getClass().getSimpleName();
-			if (!StringUtils.isNullOrEmpty(e.getMessage())) {
-				msg += " " + e.getMessage();
-			}
-			if (e.getCause() != null) {
-				msg += " caused by " + e.getCause().getClass().getSimpleName();
-			}
-			Toast.makeText(getApplication(), msg, LENGTH_LONG).show();
-		});
 	}
 
 }

briar-android/src/main/res/anim/fade_in.xml

@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
-<alpha xmlns:android="http://schemas.android.com/apk/res/android"
+<alpha
-	android:duration="@integer/animationSpeed"
+	xmlns:android="http://schemas.android.com/apk/res/android"
+	android:duration="@android:integer/config_longAnimTime"
 	android:fromAlpha="0.0"
 	android:interpolator="@android:interpolator/decelerate_quad"
-	android:toAlpha="1.0" />
+	android:toAlpha="1.0"/>

briar-android/src/main/res/anim/fade_out.xml

@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
-<alpha xmlns:android="http://schemas.android.com/apk/res/android"
+<alpha
-	android:duration="@integer/animationSpeed"
+	xmlns:android="http://schemas.android.com/apk/res/android"
+	android:duration="@android:integer/config_mediumAnimTime"
 	android:fromAlpha="1.0"
 	android:interpolator="@android:interpolator/accelerate_quad"
-	android:toAlpha="0.0" />
+	android:toAlpha="0.0"/>

briar-android/src/main/res/anim/screen_new_in.xml

@@ -1,11 +1,12 @@
 <?xml version="1.0" encoding="utf-8"?>
-<set xmlns:android="http://schemas.android.com/apk/res/android">
+<set
+	xmlns:android="http://schemas.android.com/apk/res/android">
 
 	<!-- slide in from right -->
 	<translate
-		android:duration="@integer/animationSpeed"
+		android:duration="@android:integer/config_mediumAnimTime"
 		android:fromXDelta="100%p"
 		android:interpolator="@android:interpolator/decelerate_quad"
-		android:toXDelta="0" />
+		android:toXDelta="0"/>
 
 </set>

briar-android/src/main/res/anim/screen_new_out.xml

@@ -1,11 +1,12 @@
 <?xml version="1.0" encoding="utf-8"?>
-<set xmlns:android="http://schemas.android.com/apk/res/android">
+<set
+	xmlns:android="http://schemas.android.com/apk/res/android">
 
 	<!-- slide out to right -->
 	<translate
-		android:duration="@integer/animationSpeed"
+		android:duration="@android:integer/config_mediumAnimTime"
 		android:fromXDelta="0"
 		android:interpolator="@android:interpolator/accelerate_quad"
-		android:toXDelta="100%p" />
+		android:toXDelta="100%p"/>
 
 </set>

briar-android/src/main/res/anim/screen_old_in.xml

@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
-<alpha xmlns:android="http://schemas.android.com/apk/res/android"
+<alpha
-	android:duration="@integer/animationSpeed"
+	xmlns:android="http://schemas.android.com/apk/res/android"
+	android:duration="@android:integer/config_mediumAnimTime"
 	android:fromAlpha="0.0"
 	android:interpolator="@android:interpolator/decelerate_quad"
-	android:toAlpha="1.0" />
+	android:toAlpha="1.0"/>

briar-android/src/main/res/anim/screen_old_out.xml

@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
-<alpha xmlns:android="http://schemas.android.com/apk/res/android"
+<alpha
-	android:duration="@integer/animationSpeed"
+	xmlns:android="http://schemas.android.com/apk/res/android"
+	android:duration="@android:integer/config_mediumAnimTime"
 	android:fromAlpha="1.0"
 	android:interpolator="@android:interpolator/accelerate_quad"
-	android:toAlpha="0.0" />
+	android:toAlpha="0.0"/>

briar-android/src/main/res/anim/step_next_in.xml

@@ -4,7 +4,7 @@
 
 	<!-- slide in from right -->
 	<translate
-		android:duration="@integer/animationSpeed"
+		android:duration="@android:integer/config_mediumAnimTime"
 		android:fromXDelta="100%p"
 		android:interpolator="@android:interpolator/decelerate_quad"
 		android:toXDelta="0"/>

briar-android/src/main/res/anim/step_next_out.xml

@@ -1,11 +1,12 @@
 <?xml version="1.0" encoding="utf-8"?>
-<set xmlns:android="http://schemas.android.com/apk/res/android">
+<set
+	xmlns:android="http://schemas.android.com/apk/res/android">
 
 	<!-- slide out to right -->
 	<translate
-		android:duration="@integer/animationSpeed"
+		android:duration="@android:integer/config_mediumAnimTime"
 		android:fromXDelta="0"
 		android:interpolator="@android:interpolator/accelerate_quad"
-		android:toXDelta="100%p" />
+		android:toXDelta="100%p"/>
 
 </set>

briar-android/src/main/res/anim/step_previous_in.xml

@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
-<alpha xmlns:android="http://schemas.android.com/apk/res/android"
+<alpha
-	android:duration="@integer/animationSpeed"
+	xmlns:android="http://schemas.android.com/apk/res/android"
+	android:duration="@android:integer/config_mediumAnimTime"
 	android:fromAlpha="0.0"
 	android:interpolator="@android:interpolator/decelerate_quad"
-	android:toAlpha="1.0" />
+	android:toAlpha="1.0"/>

briar-android/src/main/res/anim/step_previous_out.xml

@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
-<alpha xmlns:android="http://schemas.android.com/apk/res/android"
+<alpha
-	android:duration="@integer/animationSpeed"
+	xmlns:android="http://schemas.android.com/apk/res/android"
+	android:duration="@android:integer/config_mediumAnimTime"
 	android:fromAlpha="1.0"
 	android:interpolator="@android:interpolator/accelerate_quad"
-	android:toAlpha="0.0" />
+	android:toAlpha="0.0"/>

briar-android/src/main/res/values/attrs.xml

@@ -1,8 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
 
-	<integer name="animationSpeed">@android:integer/config_mediumAnimTime</integer>
-
 	<declare-styleable name="BriarRecyclerView">
 		<attr name="scrollToEnd" format="boolean" />
 		<attr name="emptyImage" format="integer" />

briar-android/src/main/res/xml/backup_rules.xml

@@ -1,18 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<full-backup-content>
-	<!-- docs: https://developer.android.com/guide/topics/data/autobackup#XMLSyntax -->
-	<exclude
-		domain="root"
-		path="." />
-	<!-- the previous entry should exclude things recursively, but we add more just to be sure -->
-	<exclude
-		domain="root"
-		path="app_db" />
-	<exclude
-		domain="root"
-		path="app_key" />
-	<!-- we don't use domain=file (getFilesDir()), but ApplicationInfo#dataDir -->
-	<exclude
-		domain="sharedpref"
-		path="." />
-</full-backup-content>

briar-api/src/main/java/org/briarproject/briar/api/attachment/MediaConstants.java

@@ -11,7 +11,7 @@ public interface MediaConstants {
 	/**
 	 * The maximum length of an attachment's content type in UTF-8 bytes.
 	 */
-	int MAX_CONTENT_TYPE_BYTES = 80;
+	int MAX_CONTENT_TYPE_BYTES = 50;
 
 	/**
 	 * The maximum allowed size of image attachments.

briar-api/src/main/java/org/briarproject/briar/api/blog/BlogManager.java

@@ -10,7 +10,6 @@ import org.briarproject.bramble.api.sync.GroupId;
 import org.briarproject.bramble.api.sync.MessageId;
 
 import java.util.Collection;
-import java.util.List;
 
 import javax.annotation.Nullable;
 
@@ -99,38 +98,21 @@ public interface BlogManager {
 	 */
 	Collection<Blog> getBlogs() throws DbException;
 
-	/**
-	 * Returns the group IDs of all blogs to which the user subscribes.
-	 */
-	Collection<GroupId> getBlogIds(Transaction txn) throws DbException;
-
 	/**
 	 * Returns the header of the blog post with the given ID.
 	 */
-	BlogPostHeader getPostHeader(Transaction txn, GroupId g, MessageId m)
+	BlogPostHeader getPostHeader(GroupId g, MessageId m) throws DbException;
-			throws DbException;
 
 	/**
 	 * Returns the text of the blog post with the given ID.
 	 */
 	String getPostText(MessageId m) throws DbException;
 
-	/**
-	 * Returns the text of the blog post with the given ID.
-	 */
-	String getPostText(Transaction txn, MessageId m) throws DbException;
-
 	/**
 	 * Returns the headers of all posts in the given blog.
 	 */
 	Collection<BlogPostHeader> getPostHeaders(GroupId g) throws DbException;
 
-	/**
-	 * Returns the headers of all posts in the given blog.
-	 */
-	List<BlogPostHeader> getPostHeaders(Transaction txn, GroupId g)
-			throws DbException;
-
 	/**
 	 * Marks a blog post as read or unread.
 	 */

briar-api/src/main/java/org/briarproject/briar/api/messaging/MessagingConstants.java

@@ -7,17 +7,7 @@ public interface MessagingConstants {
 	/**
 	 * The maximum length of a private message's text in UTF-8 bytes.
 	 */
-	int MAX_PRIVATE_MESSAGE_TEXT_LENGTH = MAX_MESSAGE_BODY_LENGTH - 2048;
+	int MAX_PRIVATE_MESSAGE_TEXT_LENGTH = MAX_MESSAGE_BODY_LENGTH - 1024;
-
-	/**
-	 * The maximum length of an incoming private message's text in UTF-8 bytes.
-	 * This is higher than MAX_PRIVATE_MESSAGE_TEXT_LENGTH for compatibility
-	 * with older peers.
-	 * <p>
-	 * TODO: Remove after a reasonable migration period (added 2021-03-12).
-	 */
-	int MAX_PRIVATE_MESSAGE_INCOMING_TEXT_LENGTH =
-			MAX_MESSAGE_BODY_LENGTH - 1024;
 
 	/**
 	 * The maximum number of attachments per private message.

briar-core/src/main/java/org/briarproject/briar/blog/BlogManagerImpl.java

@@ -446,22 +446,19 @@ class BlogManagerImpl extends BdfIncomingMessageHook implements BlogManager,
 	}
 
 	@Override
-	public Collection<GroupId> getBlogIds(Transaction txn) throws DbException {
+	public BlogPostHeader getPostHeader(GroupId g, MessageId m)
-		List<GroupId> groupIds = new ArrayList<>();
-		Collection<Group> groups = db.getGroups(txn, CLIENT_ID, MAJOR_VERSION);
-		for (Group g : groups) groupIds.add(g.getId());
-		return groupIds;
-	}
-
-	@Override
-	public BlogPostHeader getPostHeader(Transaction txn, GroupId g, MessageId m)
 			throws DbException {
+		Transaction txn = db.startTransaction(true);
 		try {
 			BdfDictionary meta =
 					clientHelper.getMessageMetadataAsDictionary(txn, m);
-			return getPostHeaderFromMetadata(txn, g, m, meta);
+			BlogPostHeader h = getPostHeaderFromMetadata(txn, g, m, meta);
+			db.commitTransaction(txn);
+			return h;
 		} catch (FormatException e) {
 			throw new DbException(e);
+		} finally {
+			db.endTransaction(txn);
 		}
 	}
 
@@ -474,15 +471,6 @@ class BlogManagerImpl extends BdfIncomingMessageHook implements BlogManager,
 		}
 	}
 
-	@Override
-	public String getPostText(Transaction txn, MessageId m) throws DbException {
-		try {
-			return getPostText(clientHelper.getMessageAsList(txn, m));
-		} catch (FormatException e) {
-			throw new DbException(e);
-		}
-	}
-
 	private String getPostText(BdfList message) throws FormatException {
 		MessageType type = MessageType.valueOf(message.getLong(0).intValue());
 		if (type == POST) {
@@ -500,12 +488,7 @@ class BlogManagerImpl extends BdfIncomingMessageHook implements BlogManager,
 	@Override
 	public Collection<BlogPostHeader> getPostHeaders(GroupId g)
 			throws DbException {
-		return db.transactionWithResult(true, txn -> getPostHeaders(txn, g));
-	}
 
-	@Override
-	public List<BlogPostHeader> getPostHeaders(Transaction txn, GroupId g)
-			throws DbException {
 		// Query for posts and comments only
 		BdfDictionary query1 = BdfDictionary.of(
 				new BdfEntry(KEY_TYPE, POST.getInt())
@@ -514,7 +497,8 @@ class BlogManagerImpl extends BdfIncomingMessageHook implements BlogManager,
 				new BdfEntry(KEY_TYPE, COMMENT.getInt())
 		);
 
-		List<BlogPostHeader> headers = new ArrayList<>();
+		Collection<BlogPostHeader> headers = new ArrayList<>();
+		Transaction txn = db.startTransaction(true);
 		try {
 			Map<MessageId, BdfDictionary> metadata1 =
 					clientHelper.getMessageMetadataAsDictionary(txn, g, query1);
@@ -544,10 +528,13 @@ class BlogManagerImpl extends BdfIncomingMessageHook implements BlogManager,
 						entry.getKey(), meta, authorInfos);
 				headers.add(h);
 			}
+			db.commitTransaction(txn);
+			return headers;
 		} catch (FormatException e) {
 			throw new DbException(e);
+		} finally {
+			db.endTransaction(txn);
 		}
-		return headers;
 	}
 
 	@Override

briar-core/src/main/java/org/briarproject/briar/messaging/PrivateMessageValidator.java

@@ -32,7 +32,7 @@ import static org.briarproject.briar.api.attachment.MediaConstants.MAX_CONTENT_T
 import static org.briarproject.briar.api.attachment.MediaConstants.MSG_KEY_CONTENT_TYPE;
 import static org.briarproject.briar.api.attachment.MediaConstants.MSG_KEY_DESCRIPTOR_LENGTH;
 import static org.briarproject.briar.api.messaging.MessagingConstants.MAX_ATTACHMENTS_PER_MESSAGE;
-import static org.briarproject.briar.api.messaging.MessagingConstants.MAX_PRIVATE_MESSAGE_INCOMING_TEXT_LENGTH;
+import static org.briarproject.briar.api.messaging.MessagingConstants.MAX_PRIVATE_MESSAGE_TEXT_LENGTH;
 import static org.briarproject.briar.client.MessageTrackerConstants.MSG_KEY_READ;
 import static org.briarproject.briar.messaging.MessageTypes.ATTACHMENT;
 import static org.briarproject.briar.messaging.MessageTypes.PRIVATE_MESSAGE;
@@ -103,7 +103,7 @@ class PrivateMessageValidator implements MessageValidator {
 		// Private message text
 		checkSize(body, 1);
 		String text = body.getString(0);
-		checkLength(text, 0, MAX_PRIVATE_MESSAGE_INCOMING_TEXT_LENGTH);
+		checkLength(text, 0, MAX_PRIVATE_MESSAGE_TEXT_LENGTH);
 		// Return the metadata
 		BdfDictionary meta = new BdfDictionary();
 		meta.put(MSG_KEY_TIMESTAMP, m.getTimestamp());
@@ -117,7 +117,7 @@ class PrivateMessageValidator implements MessageValidator {
 		// Message type, optional private message text, attachment headers
 		checkSize(body, 3);
 		String text = body.getOptionalString(1);
-		checkLength(text, 0, MAX_PRIVATE_MESSAGE_INCOMING_TEXT_LENGTH);
+		checkLength(text, 0, MAX_PRIVATE_MESSAGE_TEXT_LENGTH);
 		BdfList headers = body.getList(2);
 		if (text == null) checkSize(headers, 1, MAX_ATTACHMENTS_PER_MESSAGE);
 		else checkSize(headers, 0, MAX_ATTACHMENTS_PER_MESSAGE);

briar-core/src/test/java/org/briarproject/briar/messaging/MessageSizeIntegrationTest.java

@@ -1,14 +1,10 @@
 package org.briarproject.briar.messaging;
 
 import org.briarproject.bramble.api.UniqueId;
-import org.briarproject.bramble.api.client.ClientHelper;
 import org.briarproject.bramble.api.crypto.CryptoComponent;
-import org.briarproject.bramble.api.data.BdfList;
 import org.briarproject.bramble.api.identity.AuthorFactory;
 import org.briarproject.bramble.api.identity.LocalAuthor;
 import org.briarproject.bramble.api.sync.GroupId;
-import org.briarproject.bramble.api.sync.Message;
-import org.briarproject.bramble.api.sync.MessageFactory;
 import org.briarproject.bramble.api.sync.MessageId;
 import org.briarproject.briar.api.attachment.AttachmentHeader;
 import org.briarproject.briar.api.forum.ForumPost;
@@ -18,8 +14,6 @@ import org.briarproject.briar.api.messaging.PrivateMessageFactory;
 import org.briarproject.briar.test.BriarTestCase;
 import org.junit.Test;
 
-import java.io.ByteArrayInputStream;
-import java.io.ByteArrayOutputStream;
 import java.util.ArrayList;
 import java.util.List;
 
@@ -28,16 +22,12 @@ import javax.inject.Inject;
 import static org.briarproject.bramble.api.identity.AuthorConstants.MAX_AUTHOR_NAME_LENGTH;
 import static org.briarproject.bramble.api.identity.AuthorConstants.MAX_PUBLIC_KEY_LENGTH;
 import static org.briarproject.bramble.api.record.Record.MAX_RECORD_PAYLOAD_BYTES;
-import static org.briarproject.bramble.test.TestUtils.getRandomBytes;
 import static org.briarproject.bramble.test.TestUtils.getRandomId;
-import static org.briarproject.bramble.util.IoUtils.copyAndClose;
 import static org.briarproject.bramble.util.StringUtils.getRandomString;
 import static org.briarproject.briar.api.attachment.MediaConstants.MAX_CONTENT_TYPE_BYTES;
-import static org.briarproject.briar.api.attachment.MediaConstants.MAX_IMAGE_SIZE;
 import static org.briarproject.briar.api.forum.ForumConstants.MAX_FORUM_POST_TEXT_LENGTH;
 import static org.briarproject.briar.api.messaging.MessagingConstants.MAX_ATTACHMENTS_PER_MESSAGE;
 import static org.briarproject.briar.api.messaging.MessagingConstants.MAX_PRIVATE_MESSAGE_TEXT_LENGTH;
-import static org.briarproject.briar.messaging.MessageTypes.ATTACHMENT;
 import static org.junit.Assert.assertTrue;
 
 public class MessageSizeIntegrationTest extends BriarTestCase {
@@ -50,10 +40,6 @@ public class MessageSizeIntegrationTest extends BriarTestCase {
 	PrivateMessageFactory privateMessageFactory;
 	@Inject
 	ForumPostFactory forumPostFactory;
-	@Inject
-	ClientHelper clientHelper;
-	@Inject
-	MessageFactory messageFactory;
 
 	public MessageSizeIntegrationTest() {
 		MessageSizeIntegrationTestComponent component =
@@ -101,32 +87,6 @@ public class MessageSizeIntegrationTest extends BriarTestCase {
 		assertTrue(length <= MAX_RECORD_PAYLOAD_BYTES);
 	}
 
-	@Test
-	public void testAttachmentFitsIntoRecord() throws Exception {
-		// Create a maximum-length attachment
-		String contentType = getRandomString(MAX_CONTENT_TYPE_BYTES);
-		byte[] data = getRandomBytes(MAX_IMAGE_SIZE);
-
-		ByteArrayInputStream dataIn = new ByteArrayInputStream(data);
-		ByteArrayOutputStream bodyOut = new ByteArrayOutputStream();
-		byte[] descriptor =
-				clientHelper.toByteArray(BdfList.of(ATTACHMENT, contentType));
-		bodyOut.write(descriptor);
-		copyAndClose(dataIn, bodyOut);
-		byte[] body = bodyOut.toByteArray();
-
-		GroupId groupId = new GroupId(getRandomId());
-		long timestamp = Long.MAX_VALUE;
-		Message message =
-				messageFactory.createMessage(groupId, timestamp, body);
-
-		// Check the size of the serialised message
-		int length = message.getRawLength();
-		assertTrue(length > UniqueId.LENGTH + 8
-				+ 1 + MAX_CONTENT_TYPE_BYTES + MAX_IMAGE_SIZE);
-		assertTrue(length <= MAX_RECORD_PAYLOAD_BYTES);
-	}
-
 	@Test
 	public void testForumPostFitsIntoRecord() throws Exception {
 		// Create a maximum-length author

briar-core/src/test/java/org/briarproject/briar/messaging/PrivateMessageValidatorTest.java

@@ -31,7 +31,7 @@ import static org.briarproject.briar.api.attachment.MediaConstants.MAX_CONTENT_T
 import static org.briarproject.briar.api.attachment.MediaConstants.MSG_KEY_CONTENT_TYPE;
 import static org.briarproject.briar.api.attachment.MediaConstants.MSG_KEY_DESCRIPTOR_LENGTH;
 import static org.briarproject.briar.api.messaging.MessagingConstants.MAX_ATTACHMENTS_PER_MESSAGE;
-import static org.briarproject.briar.api.messaging.MessagingConstants.MAX_PRIVATE_MESSAGE_INCOMING_TEXT_LENGTH;
+import static org.briarproject.briar.api.messaging.MessagingConstants.MAX_PRIVATE_MESSAGE_TEXT_LENGTH;
 import static org.briarproject.briar.client.MessageTrackerConstants.MSG_KEY_READ;
 import static org.briarproject.briar.messaging.MessageTypes.ATTACHMENT;
 import static org.briarproject.briar.messaging.MessageTypes.PRIVATE_MESSAGE;
@@ -55,7 +55,7 @@ public class PrivateMessageValidatorTest extends BrambleMockTestCase {
 	private final Message message = getMessage(group.getId());
 	private final long now = message.getTimestamp() + 1000;
 	private final String text =
-			getRandomString(MAX_PRIVATE_MESSAGE_INCOMING_TEXT_LENGTH);
+			getRandomString(MAX_PRIVATE_MESSAGE_TEXT_LENGTH);
 	private final BdfList attachmentHeader = getAttachmentHeader();
 	private final MessageId attachmentId = new MessageId(getRandomId());
 	private final String contentType = getRandomString(MAX_CONTENT_TYPE_BYTES);
@@ -132,7 +132,7 @@ public class PrivateMessageValidatorTest extends BrambleMockTestCase {
 	@Test(expected = InvalidMessageException.class)
 	public void testRejectsTooLongTextForLegacyMessage() throws Exception {
 		String invalidText =
-				getRandomString(MAX_PRIVATE_MESSAGE_INCOMING_TEXT_LENGTH + 1);
+				getRandomString(MAX_PRIVATE_MESSAGE_TEXT_LENGTH + 1);
 
 		testRejectsLegacyMessage(BdfList.of(invalidText));
 	}
@@ -190,7 +190,7 @@ public class PrivateMessageValidatorTest extends BrambleMockTestCase {
 	@Test(expected = InvalidMessageException.class)
 	public void testRejectsTooLongTextForPrivateMessage() throws Exception {
 		String invalidText =
-				getRandomString(MAX_PRIVATE_MESSAGE_INCOMING_TEXT_LENGTH + 1);
+				getRandomString(MAX_PRIVATE_MESSAGE_TEXT_LENGTH + 1);
 
 		testRejectsPrivateMessage(
 				BdfList.of(PRIVATE_MESSAGE, invalidText, new BdfList()));

briar-headless/README.md

@@ -11,11 +11,9 @@ The REST API peer comes as a `jar` file
 and needs a Java Runtime Environment (JRE) that supports at least Java 8.
 It currently works only on GNU/Linux operating systems.
 
-To build the `jar` file, you need to specify the combination of architecture and platform:
+To build the `jar` file, you can do this:
 
-    $ ./gradlew --configure-on-demand briar-headless:x86LinuxJar
+    $ ./gradlew --configure-on-demand briar-headless:jar
-    $ ./gradlew --configure-on-demand briar-headless:aarch64LinuxJar
-    $ ./gradlew --configure-on-demand briar-headless:armhfLinuxJar
 
 You can start the peer (and its API server) like this:
 

briar-headless/build.gradle

@@ -44,32 +44,18 @@ dependencies {
 	kaptTest "com.google.dagger:dagger-compiler:$daggerVersion"
 }
 
-void jarFactory(Jar jarTask, jarArchitecture) {
+jar {
-	jarTask.doFirst {
+	manifest {
-		println 'Building ' + jarArchitecture + ' version has started'
-	}
-	jarTask.manifest {
 		attributes(
 				'Main-Class': 'org.briarproject.briar.headless.MainKt'
 		)
 	}
-	jarTask.setArchiveClassifier(jarArchitecture)
+	from {
-	jarTask.from {
 		configurations.runtimeClasspath.collect { it.isDirectory() ? it : zipTree(it) }
 	}
-			{
+	doLast() {
-				String[] architectures = ["linux-aarch64", "linux-armhf", "linux-x86_64"]
-				for (String arch : architectures) {
-					if (arch != jarArchitecture) {
-						exclude "obfs4proxy_" + arch + ".zip"
-						exclude "tor_" + arch + ".zip"
-					}
-				}
-			}
-	jarTask.with jar
-	jarTask.doLast {
 		// Rename the original jar
-		File jar = jarTask.archivePath
+		File jar = project.jar.archivePath
 		String srcPath = jar.toString().replaceFirst('\\.jar$', '.unsorted.jar')
 		File srcFile = new File(srcPath)
 		jar.renameTo(srcFile)
@@ -94,22 +80,9 @@ void jarFactory(Jar jarTask, jarArchitecture) {
 		}
 		destStream.close()
 		srcJarFile.close()
-		println 'Building ' + jarArchitecture + ' version has finished'
 	}
 }
 
-task aarch64LinuxJar(type: Jar) {
-	jarFactory(it, 'linux-aarch64')
-}
-
-task armhfLinuxJar(type: Jar) {
-	jarFactory(it, 'linux-armhf')
-}
-
-task x86LinuxJar(type: Jar) {
-	jarFactory(it, 'linux-x86_64')
-}
-
 // At the moment for non-Android projects we need to explicitly mark the code generated by kapt
 // as 'generated source code' for correct highlighting and resolve in IDE.
 idea {

briar-headless/src/main/java/org/briarproject/briar/headless/blogs/BlogControllerImpl.kt

@@ -3,15 +3,12 @@ package org.briarproject.briar.headless.blogs
 import com.fasterxml.jackson.databind.ObjectMapper
 import io.javalin.http.BadRequestResponse
 import io.javalin.http.Context
-import org.briarproject.bramble.api.db.DbException
-import org.briarproject.bramble.api.db.TransactionManager
 import org.briarproject.bramble.api.identity.IdentityManager
 import org.briarproject.bramble.api.system.Clock
 import org.briarproject.bramble.util.StringUtils.utf8IsTooLong
 import org.briarproject.briar.api.blog.BlogConstants.MAX_BLOG_POST_TEXT_LENGTH
 import org.briarproject.briar.api.blog.BlogManager
 import org.briarproject.briar.api.blog.BlogPostFactory
-import org.briarproject.briar.api.blog.BlogPostHeader
 import org.briarproject.briar.headless.getFromJson
 import javax.annotation.concurrent.Immutable
 import javax.inject.Inject
@@ -24,7 +21,6 @@ internal class BlogControllerImpl
 constructor(
     private val blogManager: BlogManager,
     private val blogPostFactory: BlogPostFactory,
-    private val db: TransactionManager,
     private val identityManager: IdentityManager,
     private val objectMapper: ObjectMapper,
     private val clock: Clock
@@ -49,10 +45,8 @@ constructor(
         val blog = blogManager.getPersonalBlog(author)
         val now = clock.currentTimeMillis()
         val post = blogPostFactory.createBlogPost(blog.id, now, null, author, text)
-        val header = db.transactionWithResult<BlogPostHeader, DbException>(true) { txn ->
+        blogManager.addLocalPost(post)
-            blogManager.addLocalPost(txn, post)
+        val header = blogManager.getPostHeader(blog.id, post.message.id)
-            return@transactionWithResult blogManager.getPostHeader(txn, blog.id, post.message.id)
-        }
         return ctx.json(header.output(text))
     }
 

briar-headless/src/test/java/org/briarproject/briar/headless/ControllerTest.kt

@@ -7,7 +7,6 @@ import io.mockk.mockk
 import org.briarproject.bramble.api.connection.ConnectionRegistry
 import org.briarproject.bramble.api.contact.Contact
 import org.briarproject.bramble.api.contact.ContactManager
-import org.briarproject.bramble.api.db.TransactionManager
 import org.briarproject.bramble.api.identity.Author
 import org.briarproject.bramble.api.identity.IdentityManager
 import org.briarproject.bramble.api.identity.LocalAuthor
@@ -25,7 +24,6 @@ import javax.servlet.http.HttpServletResponse
 
 abstract class ControllerTest {
 
-    protected val db = mockk<TransactionManager>()
     protected val contactManager = mockk<ContactManager>()
     protected val conversationManager = mockk<ConversationManager>()
     protected val identityManager = mockk<IdentityManager>()

briar-headless/src/test/java/org/briarproject/briar/headless/blogs/BlogControllerTest.kt

@@ -6,22 +6,14 @@ import io.mockk.Runs
 import io.mockk.every
 import io.mockk.just
 import io.mockk.mockk
-import io.mockk.slot
+import org.briarproject.briar.api.identity.AuthorInfo
-import org.briarproject.bramble.api.db.DbCallable
+import org.briarproject.briar.api.identity.AuthorInfo.Status.OURSELVES
-import org.briarproject.bramble.api.db.DbException
-import org.briarproject.bramble.api.db.Transaction
 import org.briarproject.bramble.api.sync.MessageId
 import org.briarproject.bramble.identity.output
 import org.briarproject.bramble.util.StringUtils.getRandomString
-import org.briarproject.briar.api.blog.Blog
+import org.briarproject.briar.api.blog.*
 import org.briarproject.briar.api.blog.BlogConstants.MAX_BLOG_POST_TEXT_LENGTH
-import org.briarproject.briar.api.blog.BlogManager
-import org.briarproject.briar.api.blog.BlogPost
-import org.briarproject.briar.api.blog.BlogPostFactory
-import org.briarproject.briar.api.blog.BlogPostHeader
 import org.briarproject.briar.api.blog.MessageType.POST
-import org.briarproject.briar.api.identity.AuthorInfo
-import org.briarproject.briar.api.identity.AuthorInfo.Status.OURSELVES
 import org.briarproject.briar.headless.ControllerTest
 import org.junit.jupiter.api.Assertions.assertThrows
 import org.junit.jupiter.api.Test
@@ -32,7 +24,7 @@ internal class BlogControllerTest : ControllerTest() {
     private val blogPostFactory = mockk<BlogPostFactory>()
 
     private val controller =
-        BlogControllerImpl(blogManager, blogPostFactory, db, identityManager, objectMapper, clock)
+        BlogControllerImpl(blogManager, blogPostFactory, identityManager, objectMapper, clock)
 
     private val blog = Blog(group, author, false)
     private val parentId: MessageId? = null
@@ -54,8 +46,6 @@ internal class BlogControllerTest : ControllerTest() {
     @Test
     fun testCreate() {
         val post = BlogPost(message, null, localAuthor)
-        val dbSlot = slot<DbCallable<BlogPostHeader, DbException>>()
-        val txn = Transaction(Object(), true)
 
         every { ctx.body() } returns """{"text": "$text"}"""
         every { identityManager.localAuthor } returns localAuthor
@@ -70,13 +60,8 @@ internal class BlogControllerTest : ControllerTest() {
                 text
             )
         } returns post
-        every { db.transactionWithResult(true, capture(dbSlot)) } answers {
+        every { blogManager.addLocalPost(post) } just Runs
-            dbSlot.captured.call(txn)
+        every { blogManager.getPostHeader(post.message.groupId, post.message.id) } returns header
-        }
-        every { blogManager.addLocalPost(txn, post) } just Runs
-        every {
-            blogManager.getPostHeader(txn, post.message.groupId, post.message.id)
-        } returns header
         every { ctx.json(header.output(text)) } returns ctx
 
         controller.createPost(ctx)