Try printing db table sizes on startup

bramble-android/build.gradle

@@ -15,8 +15,8 @@ android {
 	defaultConfig {
 		minSdkVersion 16
 		targetSdkVersion 30
-		versionCode 10408
+		versionCode 10406
-		versionName "1.4.8"
+		versionName "1.4.6"
 		consumerProguardFiles 'proguard-rules.txt'
 
 		testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"

bramble-android/src/main/java/org/briarproject/bramble/network/AndroidNetworkManager.java

@@ -11,10 +11,7 @@ import android.net.LinkAddress;
 import android.net.LinkProperties;
 import android.net.Network;
 import android.net.NetworkInfo;
-import android.net.wifi.WifiInfo;
-import android.net.wifi.WifiManager;
 
-import org.briarproject.bramble.api.Cancellable;
 import org.briarproject.bramble.api.event.EventBus;
 import org.briarproject.bramble.api.event.EventExecutor;
 import org.briarproject.bramble.api.lifecycle.Service;
@@ -24,6 +21,7 @@ import org.briarproject.bramble.api.network.event.NetworkStatusEvent;
 import org.briarproject.bramble.api.nullsafety.MethodsNotNullByDefault;
 import org.briarproject.bramble.api.nullsafety.ParametersNotNullByDefault;
 import org.briarproject.bramble.api.system.TaskScheduler;
+import org.briarproject.bramble.api.system.TaskScheduler.Cancellable;
 
 import java.net.Inet4Address;
 import java.net.InetAddress;
@@ -40,7 +38,6 @@ import javax.annotation.Nullable;
 import javax.inject.Inject;
 
 import static android.content.Context.CONNECTIVITY_SERVICE;
-import static android.content.Context.WIFI_SERVICE;
 import static android.content.Intent.ACTION_SCREEN_OFF;
 import static android.content.Intent.ACTION_SCREEN_ON;
 import static android.net.ConnectivityManager.CONNECTIVITY_ACTION;
@@ -114,37 +111,15 @@ class AndroidNetworkManager implements NetworkManager, Service {
 
 	@Override
 	public NetworkStatus getNetworkStatus() {
-		// https://issuetracker.google.com/issues/175055271
+		NetworkInfo net = connectivityManager.getActiveNetworkInfo();
-		try {
+		boolean connected = net != null && net.isConnected();
-			NetworkInfo net = connectivityManager.getActiveNetworkInfo();
+		boolean wifi = false, ipv6Only = false;
-			boolean connected = net != null && net.isConnected();
+		if (connected) {
-			boolean wifi = false, ipv6Only = false;
+			wifi = net.getType() == TYPE_WIFI;
-			if (connected) {
+			if (SDK_INT >= 23) ipv6Only = isActiveNetworkIpv6Only();
-				wifi = net.getType() == TYPE_WIFI;
+			else ipv6Only = areAllAvailableNetworksIpv6Only();
-				if (SDK_INT >= 23) ipv6Only = isActiveNetworkIpv6Only();
-				else ipv6Only = areAllAvailableNetworksIpv6Only();
-			}
-			return new NetworkStatus(connected, wifi, ipv6Only);
-		} catch (SecurityException e) {
-			logException(LOG, WARNING, e);
-			// Without the ConnectivityManager we can't detect whether we have
-			// internet access. Assume we do, which is probably less harmful
-			// than assuming we don't. Likewise, assume the connection is
-			// IPv6-only. Fall back to the WifiManager to detect whether we
-			// have a wifi connection.
-			LOG.info("ConnectivityManager is broken, guessing connectivity");
-			boolean connected = true, wifi = false, ipv6Only = true;
-			WifiManager wm = (WifiManager) app.getSystemService(WIFI_SERVICE);
-			if (wm != null) {
-				WifiInfo info = wm.getConnectionInfo();
-				if (info != null && info.getIpAddress() != 0) {
-					LOG.info("Connected to wifi");
-					wifi = true;
-					ipv6Only = false;
-				}
-			}
-			return new NetworkStatus(connected, wifi, ipv6Only);
 		}
+		return new NetworkStatus(connected, wifi, ipv6Only);
 	}
 
 	/**
@@ -155,29 +130,23 @@ class AndroidNetworkManager implements NetworkManager, Service {
 	 */
 	@TargetApi(23)
 	private boolean isActiveNetworkIpv6Only() {
-		// https://issuetracker.google.com/issues/175055271
+		Network net = connectivityManager.getActiveNetwork();
-		try {
+		if (net == null) {
-			Network net = connectivityManager.getActiveNetwork();
+			LOG.info("No active network");
-			if (net == null) {
-				LOG.info("No active network");
-				return false;
-			}
-			LinkProperties props = connectivityManager.getLinkProperties(net);
-			if (props == null) {
-				LOG.info("No link properties for active network");
-				return false;
-			}
-			boolean hasIpv6Unicast = false;
-			for (LinkAddress linkAddress : props.getLinkAddresses()) {
-				InetAddress addr = linkAddress.getAddress();
-				if (addr instanceof Inet4Address) return false;
-				if (!addr.isMulticastAddress()) hasIpv6Unicast = true;
-			}
-			return hasIpv6Unicast;
-		} catch (SecurityException e) {
-			logException(LOG, WARNING, e);
 			return false;
 		}
+		LinkProperties props = connectivityManager.getLinkProperties(net);
+		if (props == null) {
+			LOG.info("No link properties for active network");
+			return false;
+		}
+		boolean hasIpv6Unicast = false;
+		for (LinkAddress linkAddress : props.getLinkAddresses()) {
+			InetAddress addr = linkAddress.getAddress();
+			if (addr instanceof Inet4Address) return false;
+			if (!addr.isMulticastAddress()) hasIpv6Unicast = true;
+		}
+		return hasIpv6Unicast;
 	}
 
 	/**

bramble-android/src/main/java/org/briarproject/bramble/plugin/file/AndroidRemovableDrivePlugin.java

@@ -32,22 +32,13 @@ class AndroidRemovableDrivePlugin extends RemovableDrivePlugin {
 	InputStream openInputStream(TransportProperties p) throws IOException {
 		String uri = p.get(PROP_URI);
 		if (isNullOrEmpty(uri)) throw new IllegalArgumentException();
-		try {
+		return app.getContentResolver().openInputStream(Uri.parse(uri));
-			return app.getContentResolver().openInputStream(Uri.parse(uri));
-		} catch (SecurityException e) {
-			throw new IOException(e);
-		}
 	}
 
 	@Override
 	OutputStream openOutputStream(TransportProperties p) throws IOException {
 		String uri = p.get(PROP_URI);
 		if (isNullOrEmpty(uri)) throw new IllegalArgumentException();
-		try {
+		return app.getContentResolver().openOutputStream(Uri.parse(uri), "wt");
-			return app.getContentResolver()
-					.openOutputStream(Uri.parse(uri), "wt");
-		} catch (SecurityException e) {
-			throw new IOException(e);
-		}
 	}
 }

bramble-android/src/main/java/org/briarproject/bramble/plugin/tcp/AndroidLanTcpPlugin.java

@@ -175,24 +175,16 @@ class AndroidLanTcpPlugin extends LanTcpPlugin {
 	@TargetApi(21)
 	@Nullable
 	private InetAddress getWifiClientIpv6Address() {
-		// https://issuetracker.google.com/issues/175055271
+		for (Network net : connectivityManager.getAllNetworks()) {
-		try {
+			NetworkCapabilities caps =
-			for (Network net : connectivityManager.getAllNetworks()) {
+					connectivityManager.getNetworkCapabilities(net);
-				NetworkCapabilities caps =
+			if (caps == null || !caps.hasTransport(TRANSPORT_WIFI)) continue;
-						connectivityManager.getNetworkCapabilities(net);
+			LinkProperties props = connectivityManager.getLinkProperties(net);
-				if (caps == null || !caps.hasTransport(TRANSPORT_WIFI)) {
+			if (props == null) continue;
-					continue;
+			for (LinkAddress linkAddress : props.getLinkAddresses()) {
-				}
+				InetAddress addr = linkAddress.getAddress();
-				LinkProperties props =
+				if (isIpv6LinkLocalAddress(addr)) return addr;
-						connectivityManager.getLinkProperties(net);
-				if (props == null) continue;
-				for (LinkAddress linkAddress : props.getLinkAddresses()) {
-					InetAddress addr = linkAddress.getAddress();
-					if (isIpv6LinkLocalAddress(addr)) return addr;
-				}
 			}
-		} catch (SecurityException e) {
-			logException(LOG, WARNING, e);
 		}
 		return null;
 	}
@@ -235,17 +227,12 @@ class AndroidLanTcpPlugin extends LanTcpPlugin {
 	// network's socket factory may try to connect via another network
 	private SocketFactory getSocketFactory() {
 		if (SDK_INT < 21) return SocketFactory.getDefault();
-		// https://issuetracker.google.com/issues/175055271
+		for (Network net : connectivityManager.getAllNetworks()) {
-		try {
+			NetworkCapabilities caps =
-			for (Network net : connectivityManager.getAllNetworks()) {
+					connectivityManager.getNetworkCapabilities(net);
-				NetworkCapabilities caps =
+			if (caps != null && caps.hasTransport(TRANSPORT_WIFI)) {
-						connectivityManager.getNetworkCapabilities(net);
+				return net.getSocketFactory();
-				if (caps != null && caps.hasTransport(TRANSPORT_WIFI)) {
-					return net.getSocketFactory();
-				}
 			}
-		} catch (SecurityException e) {
-			logException(LOG, WARNING, e);
 		}
 		LOG.warning("Could not find suitable socket factory");
 		return SocketFactory.getDefault();

bramble-android/src/main/java/org/briarproject/bramble/plugin/tor/AndroidTorPluginFactory.java

@@ -11,35 +11,62 @@ import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.bramble.api.plugin.Backoff;
 import org.briarproject.bramble.api.plugin.BackoffFactory;
 import org.briarproject.bramble.api.plugin.PluginCallback;
+import org.briarproject.bramble.api.plugin.TorConstants;
 import org.briarproject.bramble.api.plugin.TorControlPort;
 import org.briarproject.bramble.api.plugin.TorDirectory;
 import org.briarproject.bramble.api.plugin.TorSocksPort;
+import org.briarproject.bramble.api.plugin.TransportId;
+import org.briarproject.bramble.api.plugin.duplex.DuplexPlugin;
+import org.briarproject.bramble.api.plugin.duplex.DuplexPluginFactory;
 import org.briarproject.bramble.api.system.AndroidWakeLockManager;
 import org.briarproject.bramble.api.system.Clock;
 import org.briarproject.bramble.api.system.LocationUtils;
 import org.briarproject.bramble.api.system.ResourceProvider;
 import org.briarproject.bramble.api.system.WakefulIoExecutor;
+import org.briarproject.bramble.util.AndroidUtils;
 
 import java.io.File;
 import java.util.concurrent.Executor;
+import java.util.logging.Logger;
 
-import javax.annotation.Nullable;
 import javax.annotation.concurrent.Immutable;
 import javax.inject.Inject;
 import javax.net.SocketFactory;
 
-import static org.briarproject.bramble.util.AndroidUtils.getSupportedArchitectures;
-
 @Immutable
 @NotNullByDefault
-public class AndroidTorPluginFactory extends TorPluginFactory {
+public class AndroidTorPluginFactory implements DuplexPluginFactory {
 
+	private static final Logger LOG =
+			Logger.getLogger(AndroidTorPluginFactory.class.getName());
+
+	private static final int MAX_LATENCY = 30 * 1000; // 30 seconds
+	private static final int MAX_IDLE_TIME = 30 * 1000; // 30 seconds
+	private static final int MIN_POLLING_INTERVAL = 60 * 1000; // 1 minute
+	private static final int MAX_POLLING_INTERVAL = 10 * 60 * 1000; // 10 mins
+	private static final double BACKOFF_BASE = 1.2;
+
+	private final Executor ioExecutor, wakefulIoExecutor;
 	private final Application app;
+	private final NetworkManager networkManager;
+	private final LocationUtils locationUtils;
+	private final EventBus eventBus;
+	private final SocketFactory torSocketFactory;
+	private final BackoffFactory backoffFactory;
+	private final ResourceProvider resourceProvider;
+	private final CircumventionProvider circumventionProvider;
+	private final BatteryManager batteryManager;
 	private final AndroidWakeLockManager wakeLockManager;
+	private final Clock clock;
+	private final File torDirectory;
+	private int torSocksPort;
+	private int torControlPort;
+	private final CryptoComponent crypto;
 
 	@Inject
 	AndroidTorPluginFactory(@IoExecutor Executor ioExecutor,
 			@WakefulIoExecutor Executor wakefulIoExecutor,
+			Application app,
 			NetworkManager networkManager,
 			LocationUtils locationUtils,
 			EventBus eventBus,
@@ -48,43 +75,80 @@ public class AndroidTorPluginFactory extends TorPluginFactory {
 			ResourceProvider resourceProvider,
 			CircumventionProvider circumventionProvider,
 			BatteryManager batteryManager,
+			AndroidWakeLockManager wakeLockManager,
 			Clock clock,
-			CryptoComponent crypto,
 			@TorDirectory File torDirectory,
 			@TorSocksPort int torSocksPort,
 			@TorControlPort int torControlPort,
-			Application app,
+			CryptoComponent crypto) {
-			AndroidWakeLockManager wakeLockManager) {
+		this.ioExecutor = ioExecutor;
-		super(ioExecutor, wakefulIoExecutor, networkManager, locationUtils,
+		this.wakefulIoExecutor = wakefulIoExecutor;
-				eventBus, torSocketFactory, backoffFactory, resourceProvider,
-				circumventionProvider, batteryManager, clock, crypto,
-				torDirectory, torSocksPort, torControlPort);
 		this.app = app;
+		this.networkManager = networkManager;
+		this.locationUtils = locationUtils;
+		this.eventBus = eventBus;
+		this.torSocketFactory = torSocketFactory;
+		this.backoffFactory = backoffFactory;
+		this.resourceProvider = resourceProvider;
+		this.circumventionProvider = circumventionProvider;
+		this.batteryManager = batteryManager;
 		this.wakeLockManager = wakeLockManager;
+		this.clock = clock;
+		this.torDirectory = torDirectory;
+		this.torSocksPort = torSocksPort;
+		this.torControlPort = torControlPort;
+		this.crypto = crypto;
 	}
 
-	@Nullable
 	@Override
-	String getArchitectureForTorBinary() {
+	public TransportId getId() {
-		for (String abi : getSupportedArchitectures()) {
+		return TorConstants.ID;
-			if (abi.startsWith("x86_64")) return "x86_64_pie";
+	}
-			else if (abi.startsWith("x86")) return "x86_pie";
+
-			else if (abi.startsWith("arm64")) return "arm64_pie";
+	@Override
-			else if (abi.startsWith("armeabi")) return "arm_pie";
+	public long getMaxLatency() {
+		return MAX_LATENCY;
+	}
+
+	@Override
+	public DuplexPlugin createPlugin(PluginCallback callback) {
+
+		// Check that we have a Tor binary for this architecture
+		String architecture = null;
+		for (String abi : AndroidUtils.getSupportedArchitectures()) {
+			if (abi.startsWith("x86_64")) {
+				architecture = "x86_64";
+				break;
+			} else if (abi.startsWith("x86")) {
+				architecture = "x86";
+				break;
+			} else if (abi.startsWith("arm64")) {
+				architecture = "arm64";
+				break;
+			} else if (abi.startsWith("armeabi")) {
+				architecture = "arm";
+				break;
+			}
 		}
-		return null;
+		if (architecture == null) {
-	}
+			LOG.info("Tor is not supported on this architecture");
+			return null;
+		}
+		// Use position-independent executable
+		architecture += "_pie";
 
-	@Override
+		Backoff backoff = backoffFactory.createBackoff(MIN_POLLING_INTERVAL,
-	TorPlugin createPluginInstance(Backoff backoff,
+				MAX_POLLING_INTERVAL, BACKOFF_BASE);
-			TorRendezvousCrypto torRendezvousCrypto, PluginCallback callback,
+		TorRendezvousCrypto torRendezvousCrypto =
-			String architecture) {
+				new TorRendezvousCryptoImpl(crypto);
-		return new AndroidTorPlugin(ioExecutor,
+		AndroidTorPlugin plugin = new AndroidTorPlugin(ioExecutor,
 				wakefulIoExecutor, app, networkManager, locationUtils,
 				torSocketFactory, clock, resourceProvider,
 				circumventionProvider, batteryManager, wakeLockManager,
 				backoff, torRendezvousCrypto, callback, architecture,
 				MAX_LATENCY, MAX_IDLE_TIME, torDirectory, torSocksPort,
 				torControlPort);
+		eventBus.addListener(plugin);
+		return plugin;
 	}
 }

bramble-android/src/main/java/org/briarproject/bramble/system/AndroidTaskScheduler.java

@@ -8,7 +8,6 @@ import android.content.Intent;
 import android.os.Process;
 import android.os.SystemClock;
 
-import org.briarproject.bramble.api.Cancellable;
 import org.briarproject.bramble.api.lifecycle.Service;
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.bramble.api.system.AlarmListener;
@@ -117,12 +116,10 @@ class AndroidTaskScheduler implements TaskScheduler, Service, AlarmListener {
 		long dueMillis = now + MILLISECONDS.convert(delay, unit);
 		Runnable wakeful = () ->
 				wakeLockManager.executeWakefully(task, executor, "TaskHandoff");
-		// Acquire the lock before scheduling the check to ensure the check
+		Future<?> check = scheduleCheckForDueTasks(delay, unit);
-		// doesn't access the task queue before the task has been added
+		ScheduledTask s = new ScheduledTask(wakeful, dueMillis, check,
-		ScheduledTask s;
+				cancelled);
 		synchronized (lock) {
-			Future<?> check = scheduleCheckForDueTasks(delay, unit);
-			s = new ScheduledTask(wakeful, dueMillis, check, cancelled);
 			tasks.add(s);
 		}
 		return s;
@@ -139,7 +136,6 @@ class AndroidTaskScheduler implements TaskScheduler, Service, AlarmListener {
 		return schedule(wrapped, executor, delay, unit, cancelled);
 	}
 
-	@GuardedBy("lock")
 	private Future<?> scheduleCheckForDueTasks(long delay, TimeUnit unit) {
 		Runnable wakeful = () -> wakeLockManager.runWakefully(
 				this::runDueTasks, "TaskScheduler");
@@ -210,7 +206,7 @@ class AndroidTaskScheduler implements TaskScheduler, Service, AlarmListener {
 		private final Future<?> check;
 		private final AtomicBoolean cancelled;
 
-		private ScheduledTask(Runnable task, long dueMillis,
+		public ScheduledTask(Runnable task, long dueMillis,
 				Future<?> check, AtomicBoolean cancelled) {
 			this.task = task;
 			this.dueMillis = dueMillis;

bramble-android/src/main/java/org/briarproject/bramble/util/AndroidUtils.java

@@ -4,7 +4,6 @@ import android.annotation.SuppressLint;
 import android.bluetooth.BluetoothAdapter;
 import android.content.Context;
 import android.os.Build;
-import android.os.Looper;
 import android.provider.Settings;
 
 import org.briarproject.bramble.api.Pair;
@@ -135,8 +134,4 @@ public class AndroidUtils {
 			return null;
 		}
 	}
-
-	public static boolean isUiThread() {
-		return Looper.myLooper() == Looper.getMainLooper();
-	}
 }

bramble-api/src/main/java/org/briarproject/bramble/api/Cancellable.java

@@ -1,6 +0,0 @@
-package org.briarproject.bramble.api;
-
-public interface Cancellable {
-
-	void cancel();
-}

bramble-api/src/main/java/org/briarproject/bramble/api/client/ClientHelper.java

@@ -9,8 +9,7 @@ import org.briarproject.bramble.api.data.BdfList;
 import org.briarproject.bramble.api.db.DbException;
 import org.briarproject.bramble.api.db.Transaction;
 import org.briarproject.bramble.api.identity.Author;
-import org.briarproject.bramble.api.mailbox.MailboxUpdate;
+import org.briarproject.bramble.api.mailbox.MailboxPropertiesUpdate;
-import org.briarproject.bramble.api.mailbox.MailboxVersion;
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.bramble.api.plugin.TransportId;
 import org.briarproject.bramble.api.properties.TransportProperties;
@@ -20,9 +19,10 @@ import org.briarproject.bramble.api.sync.MessageId;
 
 import java.security.GeneralSecurityException;
 import java.util.Collection;
-import java.util.List;
 import java.util.Map;
 
+import javax.annotation.Nullable;
+
 @NotNullByDefault
 public interface ClientHelper {
 
@@ -127,17 +127,16 @@ public interface ClientHelper {
 			BdfDictionary properties) throws FormatException;
 
 	/**
-	 * Parse and validate the elements of a Mailbox update message.
+	 * Parse and validate the property dictionary of a Mailbox property update
+	 * message.
 	 *
-	 * @return the parsed update message
+	 * @return the properties for using the Mailbox, or null if there is no
-	 * @throws FormatException if the message elements are invalid
+	 * Mailbox available
+	 * @throws FormatException if the properties are not valid
 	 */
-	MailboxUpdate parseAndValidateMailboxUpdate(BdfList clientSupports,
+	@Nullable
-			BdfList serverSupports, BdfDictionary properties)
+	MailboxPropertiesUpdate parseAndValidateMailboxPropertiesUpdate(
-			throws FormatException;
+			BdfDictionary properties) throws FormatException;
-
-	List<MailboxVersion> parseMailboxVersionList(BdfList bdfList)
-			throws FormatException;
 
 	/**
 	 * Retrieves the contact ID from the group metadata of the given contact

bramble-api/src/main/java/org/briarproject/bramble/api/db/DatabaseComponent.java

@@ -33,18 +33,11 @@ import java.util.List;
 import java.util.Map;
 
 import javax.annotation.Nullable;
-import javax.annotation.concurrent.ThreadSafe;
 
 /**
  * Encapsulates the database implementation and exposes high-level operations
  * to other components.
- * <p>
- * With the exception of the {@link #open(SecretKey, MigrationListener)} and
- * {@link #close()} methods, which must not be called concurrently, the
- * database can be accessed from any thread. See {@link TransactionManager}
- * for locking behaviour.
  */
-@ThreadSafe
 @NotNullByDefault
 public interface DatabaseComponent extends TransactionManager {
 
@@ -200,15 +193,26 @@ public interface DatabaseComponent extends TransactionManager {
 			throws DbException;
 
 	/**
-	 * Returns a batch of messages for the given contact, for transmission over
+	 * Returns a batch of messages for the given contact, with a total length
-	 * a transport with the given maximum latency. The total length of the
+	 * less than or equal to the given length, for transmission over a
-	 * messages, including record headers, will be no more than the given
+	 * transport with the given maximum latency. Returns null if there are no
-	 * capacity. Returns null if there are no sendable messages that would fit
+	 * sendable messages that fit in the given length.
-	 * in the given capacity.
 	 */
 	@Nullable
 	Collection<Message> generateBatch(Transaction txn, ContactId c,
-			long capacity, long maxLatency) throws DbException;
+			int maxLength, long maxLatency) throws DbException;
+
+	/**
+	 * Returns a batch of messages for the given contact containing the
+	 * messages with the given IDs, for transmission over a transport with
+	 * the given maximum latency.
+	 * <p/>
+	 * If any of the given messages are not in the database or are not visible
+	 * to the contact, they are omitted from the batch without throwing an
+	 * exception.
+	 */
+	Collection<Message> generateBatch(Transaction txn, ContactId c,
+			Collection<MessageId> ids, long maxLatency) throws DbException;
 
 	/**
 	 * Returns an offer for the given contact for transmission over a
@@ -228,16 +232,15 @@ public interface DatabaseComponent extends TransactionManager {
 			throws DbException;
 
 	/**
-	 * Returns a batch of messages for the given contact, for transmission over
+	 * Returns a batch of messages for the given contact, with a total length
-	 * a transport with the given maximum latency. Only messages that have been
+	 * less than or equal to the given length, for transmission over a
-	 * requested by the contact are returned. The total length of the messages,
+	 * transport with the given maximum latency. Only messages that have been
-	 * including record headers, will be no more than the given capacity.
+	 * requested by the contact are returned. Returns null if there are no
-	 * Returns null if there are no sendable messages that have been requested
+	 * sendable messages that fit in the given length.
-	 * by the contact and would fit in the given capacity.
 	 */
 	@Nullable
 	Collection<Message> generateRequestedBatch(Transaction txn, ContactId c,
-			long capacity, long maxLatency) throws DbException;
+			int maxLength, long maxLatency) throws DbException;
 
 	/**
 	 * Returns the contact with the given ID.
@@ -341,30 +344,6 @@ public interface DatabaseComponent extends TransactionManager {
 	Collection<MessageId> getMessageIds(Transaction txn, GroupId g,
 			Metadata query) throws DbException;
 
-	/**
-	 * Returns the IDs of some messages received from the given contact that
-	 * need to be acknowledged, up to the given number of messages.
-	 * <p/>
-	 * Read-only.
-	 */
-	Collection<MessageId> getMessagesToAck(Transaction txn, ContactId c,
-			int maxMessages) throws DbException;
-
-	/**
-	 * Returns the IDs of some messages that are eligible to be sent to the
-	 * given contact over a transport with the given maximum latency. The total
-	 * length of the messages including record headers will be no more than the
-	 * given capacity.
-	 * <p/>
-	 * Unlike {@link #getUnackedMessagesToSend(Transaction, ContactId)} this
-	 * method does not return messages that have already been sent unless they
-	 * are due for retransmission.
-	 * <p/>
-	 * Read-only.
-	 */
-	Collection<MessageId> getMessagesToSend(Transaction txn, ContactId c,
-			long capacity, long maxLatency) throws DbException;
-
 	/**
 	 * Returns the IDs of any messages that need to be validated.
 	 * <p/>
@@ -481,30 +460,15 @@ public interface DatabaseComponent extends TransactionManager {
 	MessageStatus getMessageStatus(Transaction txn, ContactId c, MessageId m)
 			throws DbException;
 
-	/**
-	 * Returns the message with the given ID for transmission to the given
-	 * contact over a transport with the given maximum latency. Returns null
-	 * if the message is no longer visible to the contact.
-	 *
-	 * @param markAsSent True if the message should be marked as sent.
-	 * If false it can be marked as sent by calling
-	 * {@link #setMessagesSent(Transaction, ContactId, Collection, long)}.
-	 */
-	@Nullable
-	Message getMessageToSend(Transaction txn, ContactId c, MessageId m,
-			long maxLatency, boolean markAsSent) throws DbException;
-
 	/**
 	 * Returns the IDs of all messages that are eligible to be sent to the
-	 * given contact.
+	 * given contact, together with their raw lengths. This may include
-	 * <p>
+	 * messages that have already been sent and are not yet due for
-	 * Unlike {@link #getMessagesToSend(Transaction, ContactId, long, long)}
+	 * retransmission.
-	 * this method may return messages that have already been sent and are
-	 * not yet due for retransmission.
 	 * <p/>
 	 * Read-only.
 	 */
-	Collection<MessageId> getUnackedMessagesToSend(Transaction txn,
+	Map<MessageId, Integer> getUnackedMessagesToSend(Transaction txn,
 			ContactId c) throws DbException;
 
 	/**
@@ -684,13 +648,6 @@ public interface DatabaseComponent extends TransactionManager {
 	void removeTransportKeys(Transaction txn, TransportId t, KeySetId k)
 			throws DbException;
 
-	/**
-	 * Records an ack for the given messages as having been sent to the given
-	 * contact.
-	 */
-	void setAckSent(Transaction txn, ContactId c, Collection<MessageId> acked)
-			throws DbException;
-
 	/**
 	 * Sets the cleanup timer duration for the given message. This does not
 	 * start the message's cleanup timer.
@@ -737,13 +694,6 @@ public interface DatabaseComponent extends TransactionManager {
 	void setMessageState(Transaction txn, MessageId m, MessageState state)
 			throws DbException;
 
-	/**
-	 * Records the given messages as having been sent to the given contact
-	 * over a transport with the given maximum latency.
-	 */
-	void setMessagesSent(Transaction txn, ContactId c,
-			Collection<MessageId> sent, long maxLatency) throws DbException;
-
 	/**
 	 * Adds dependencies for a message
 	 */
@@ -796,4 +746,6 @@ public interface DatabaseComponent extends TransactionManager {
 	 */
 	void updateTransportKeys(Transaction txn, Collection<TransportKeySet> keys)
 			throws DbException;
+
+	void printStats(Transaction txn) throws DbException;
 }

bramble-api/src/main/java/org/briarproject/bramble/api/db/DatabaseExecutor.java

@@ -18,10 +18,6 @@ import static java.lang.annotation.RetentionPolicy.RUNTIME;
  * submitted, tasks are not run concurrently, and submitting a task will never
  * block. Tasks must not run indefinitely. Tasks submitted during shutdown are
  * discarded.
- * <p>
- * It is not mandatory to use this executor for database tasks. The database
- * can be accessed from any thread, but this executor's guarantee that tasks
- * are run in the order they're submitted may be useful in some cases.
  */
 @Qualifier
 @Target({FIELD, METHOD, PARAMETER})

bramble-api/src/main/java/org/briarproject/bramble/api/db/Transaction.java

@@ -45,9 +45,6 @@ public class Transaction {
 	/**
 	 * Attaches an event to be broadcast when the transaction has been
 	 * committed. The event will be broadcast on the {@link EventExecutor}.
-	 * Events and {@link #attach(Runnable) tasks} are submitted to the
-	 * {@link EventExecutor} in the order they were attached to the
-	 * transaction.
 	 */
 	public void attach(Event e) {
 		if (actions == null) actions = new ArrayList<>();
@@ -57,9 +54,6 @@ public class Transaction {
 	/**
 	 * Attaches a task to be executed when the transaction has been
 	 * committed. The task will be run on the {@link EventExecutor}.
-	 * {@link #attach(Event) Events} and tasks are submitted to the
-	 * {@link EventExecutor} in the order they were attached to the
-	 * transaction.
 	 */
 	public void attach(Runnable r) {
 		if (actions == null) actions = new ArrayList<>();

bramble-api/src/main/java/org/briarproject/bramble/api/db/TransactionManager.java

@@ -1,95 +1,51 @@
 package org.briarproject.bramble.api.db;
 
-import org.briarproject.bramble.api.event.EventExecutor;
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 
 import javax.annotation.Nullable;
-import javax.annotation.concurrent.ThreadSafe;
 
-/**
- * An interface for managing database transactions.
- * <p>
- * Read-only transactions may access the database concurrently. Read-write
- * transactions access the database exclusively, so starting a read-only or
- * read-write transaction will block until there are no read-write
- * transactions in progress.
- * <p>
- * Failing to {@link #endTransaction(Transaction) end} a transaction will
- * prevent other callers from accessing the database, so it is recommended to
- * use the {@link #transaction(boolean, DbRunnable)},
- * {@link #transactionWithResult(boolean, DbCallable)} and
- * {@link #transactionWithNullableResult(boolean, NullableDbCallable)} methods
- * where possible, which handle committing or aborting the transaction on the
- * caller's behalf.
- * <p>
- * Transactions are not reentrant, i.e. it is not permitted to start a
- * transaction on a thread that already has a transaction in progress.
- */
-@ThreadSafe
 @NotNullByDefault
 public interface TransactionManager {
 
 	/**
-	 * Starts a new transaction and returns an object representing it. This
+	 * Starts a new transaction and returns an object representing it.
-	 * method acquires the database lock, which is held until
+	 * <p/>
-	 * {@link #endTransaction(Transaction)} is called.
+	 * This method acquires locks, so it must not be called while holding a
+	 * lock.
 	 *
-	 * @param readOnly True if the transaction will only be used for reading,
+	 * @param readOnly true if the transaction will only be used for reading.
-	 * in which case the database lock can be shared with other read-only
-	 * transactions.
 	 */
 	Transaction startTransaction(boolean readOnly) throws DbException;
 
 	/**
 	 * Commits a transaction to the database.
-	 * {@link #endTransaction(Transaction)} must be called to release the
-	 * database lock.
 	 */
 	void commitTransaction(Transaction txn) throws DbException;
 
 	/**
-	 * Ends a transaction. If the transaction has not been committed by
+	 * Ends a transaction. If the transaction has not been committed,
-	 * calling {@link #commitTransaction(Transaction)}, it is aborted and the
+	 * it will be aborted. If the transaction has been committed,
-	 * database lock is released.
+	 * any events attached to the transaction are broadcast.
-	 * <p>
+	 * The database lock will be released in either case.
-	 * If the transaction has been committed, any
-	 * {@link Transaction#attach events} attached to the transaction are
-	 * broadcast and any {@link Transaction#attach(Runnable) tasks} attached
-	 * to the transaction are submitted to the {@link EventExecutor}. The
-	 * database lock is then released.
 	 */
 	void endTransaction(Transaction txn);
 
 	/**
-	 * Runs the given task within a transaction. The database lock is held
+	 * Runs the given task within a transaction.
-	 * while running the task.
-	 *
-	 * @param readOnly True if the transaction will only be used for reading,
-	 * in which case the database lock can be shared with other read-only
-	 * transactions.
 	 */
 	<E extends Exception> void transaction(boolean readOnly,
 			DbRunnable<E> task) throws DbException, E;
 
 	/**
 	 * Runs the given task within a transaction and returns the result of the
-	 * task. The database lock is held while running the task.
+	 * task.
-	 *
-	 * @param readOnly True if the transaction will only be used for reading,
-	 * in which case the database lock can be shared with other read-only
-	 * transactions.
 	 */
 	<R, E extends Exception> R transactionWithResult(boolean readOnly,
 			DbCallable<R, E> task) throws DbException, E;
 
 	/**
 	 * Runs the given task within a transaction and returns the result of the
-	 * task, which may be null. The database lock is held while running the
+	 * task, which may be null.
-	 * task.
-	 *
-	 * @param readOnly True if the transaction will only be used for reading,
-	 * in which case the database lock can be shared with other read-only
-	 * transactions.
 	 */
 	@Nullable
 	<R, E extends Exception> R transactionWithNullableResult(boolean readOnly,

bramble-api/src/main/java/org/briarproject/bramble/api/mailbox/MailboxConstants.java

@@ -1,37 +0,0 @@
-package org.briarproject.bramble.api.mailbox;
-
-import static java.util.concurrent.TimeUnit.HOURS;
-import static org.briarproject.bramble.api.transport.TransportConstants.MAX_FRAME_LENGTH;
-import static org.briarproject.bramble.api.transport.TransportConstants.MAX_PAYLOAD_LENGTH;
-import static org.briarproject.bramble.api.transport.TransportConstants.STREAM_HEADER_LENGTH;
-import static org.briarproject.bramble.api.transport.TransportConstants.TAG_LENGTH;
-
-public interface MailboxConstants {
-
-	/**
-	 * The maximum length of a file that can be uploaded to or downloaded from
-	 * a mailbox.
-	 */
-	int MAX_FILE_BYTES = 1024 * 1024;
-
-	/**
-	 * The maximum length of the plaintext payload of a file, such that the
-	 * ciphertext is no more than {@link #MAX_FILE_BYTES}.
-	 */
-	int MAX_FILE_PAYLOAD_BYTES =
-			(MAX_FILE_BYTES - TAG_LENGTH - STREAM_HEADER_LENGTH)
-					/ MAX_FRAME_LENGTH * MAX_PAYLOAD_LENGTH;
-
-	/**
-	 * The number of connection failures
-	 * that indicate a problem with the mailbox.
-	 */
-	int PROBLEM_NUM_CONNECTION_FAILURES = 5;
-
-	/**
-	 * The time in milliseconds since the last connection success
-	 * that need to pass to indicates a problem with the mailbox.
-	 */
-	long PROBLEM_MS_SINCE_LAST_SUCCESS = HOURS.toMillis(1);
-
-}

bramble-api/src/main/java/org/briarproject/bramble/api/mailbox/MailboxManager.java

@@ -2,8 +2,6 @@ package org.briarproject.bramble.api.mailbox;
 
 import org.briarproject.bramble.api.db.DbException;
 import org.briarproject.bramble.api.db.Transaction;
-import org.briarproject.bramble.api.lifecycle.IoExecutor;
-import org.briarproject.bramble.api.mailbox.event.OwnMailboxConnectionStatusEvent;
 
 import javax.annotation.Nullable;
 
@@ -43,14 +41,4 @@ public interface MailboxManager {
 	 */
 	boolean checkConnection();
 
-	/**
-	 * Unpairs the owner's mailbox and tries to wipe it.
-	 * As this makes a network call, it should be run on the {@link IoExecutor}.
-	 *
-	 * @return true if we could wipe the mailbox, false if we couldn't.
-	 * It is advised to inform the user to wipe the mailbox themselves,
-	 * if we failed to wipe it.
-	 */
-	@IoExecutor
-	boolean unPair() throws DbException;
 }

bramble-api/src/main/java/org/briarproject/bramble/api/mailbox/MailboxProperties.java

@@ -4,7 +4,6 @@ import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 
 import java.util.List;
 
-import javax.annotation.Nullable;
 import javax.annotation.concurrent.Immutable;
 
 @Immutable
@@ -15,36 +14,13 @@ public class MailboxProperties {
 	private final MailboxAuthToken authToken;
 	private final boolean owner;
 	private final List<MailboxVersion> serverSupports;
-	@Nullable
-	private final MailboxFolderId inboxId; // Null for own mailbox
-	@Nullable
-	private final MailboxFolderId outboxId; // Null for own mailbox
 
-	/**
-	 * Constructor for properties used by the mailbox's owner.
-	 */
 	public MailboxProperties(String baseUrl, MailboxAuthToken authToken,
-			List<MailboxVersion> serverSupports) {
+			boolean owner, List<MailboxVersion> serverSupports) {
 		this.baseUrl = baseUrl;
 		this.authToken = authToken;
-		this.owner = true;
+		this.owner = owner;
 		this.serverSupports = serverSupports;
-		this.inboxId = null;
-		this.outboxId = null;
-	}
-
-	/**
-	 * Constructor for properties used by a contact of the mailbox's owner.
-	 */
-	public MailboxProperties(String baseUrl, MailboxAuthToken authToken,
-			List<MailboxVersion> serverSupports, MailboxFolderId inboxId,
-			MailboxFolderId outboxId) {
-		this.baseUrl = baseUrl;
-		this.authToken = authToken;
-		this.owner = false;
-		this.serverSupports = serverSupports;
-		this.inboxId = inboxId;
-		this.outboxId = outboxId;
 	}
 
 	public String getBaseUrl() {
@@ -67,14 +43,4 @@ public class MailboxProperties {
 	public List<MailboxVersion> getServerSupports() {
 		return serverSupports;
 	}
-
-	@Nullable
-	public MailboxFolderId getInboxId() {
-		return inboxId;
-	}
-
-	@Nullable
-	public MailboxFolderId getOutboxId() {
-		return outboxId;
-	}
 }

bramble-api/src/main/java/org/briarproject/bramble/api/mailbox/MailboxPropertiesUpdate.java

@@ -0,0 +1,41 @@
+package org.briarproject.bramble.api.mailbox;
+
+import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
+
+import javax.annotation.concurrent.Immutable;
+
+@Immutable
+@NotNullByDefault
+public class MailboxPropertiesUpdate {
+
+	private final String onion;
+	private final MailboxAuthToken authToken;
+	private final MailboxFolderId inboxId;
+	private final MailboxFolderId outboxId;
+
+	public MailboxPropertiesUpdate(String onion,
+			MailboxAuthToken authToken, MailboxFolderId inboxId,
+			MailboxFolderId outboxId) {
+		this.onion = onion;
+		this.authToken = authToken;
+		this.inboxId = inboxId;
+		this.outboxId = outboxId;
+	}
+
+	public String getOnion() {
+		return onion;
+	}
+
+	public MailboxAuthToken getAuthToken() {
+		return authToken;
+	}
+
+	public MailboxFolderId getInboxId() {
+		return inboxId;
+	}
+
+	public MailboxFolderId getOutboxId() {
+		return outboxId;
+	}
+
+}

bramble-api/src/main/java/org/briarproject/bramble/api/mailbox/MailboxPropertyManager.java

@@ -9,31 +9,31 @@ import org.briarproject.bramble.api.sync.ClientId;
 import javax.annotation.Nullable;
 
 @NotNullByDefault
-public interface MailboxUpdateManager {
+public interface MailboxPropertyManager {
 
 	/**
-	 * The unique ID of the mailbox update (properties) client.
+	 * The unique ID of the mailbox property client.
 	 */
 	ClientId CLIENT_ID =
 			new ClientId("org.briarproject.bramble.mailbox.properties");
 
 	/**
-	 * The current major version of the mailbox update (properties) client.
+	 * The current major version of the mailbox property client.
 	 */
-	int MAJOR_VERSION = 2;
+	int MAJOR_VERSION = 0;
 
 	/**
-	 * The current minor version of the mailbox update (properties) client.
+	 * The current minor version of the mailbox property client.
 	 */
 	int MINOR_VERSION = 0;
 
 	/**
-	 * The number of properties required for an update message with a mailbox.
+	 * The number of properties required for a (non-empty) update message.
 	 */
 	int PROP_COUNT = 4;
 
 	/**
-	 * The required properties of an update message with a mailbox.
+	 * The required properties of a non-empty update message.
 	 */
 	String PROP_KEY_ONION = "onion";
 	String PROP_KEY_AUTHTOKEN = "authToken";
@@ -57,16 +57,11 @@ public interface MailboxUpdateManager {
 	 */
 	String MSG_KEY_LOCAL = "local";
 
-	/**
+	@Nullable
-	 * Key in the client's local group for storing the clientSupports list that
+	MailboxPropertiesUpdate getLocalProperties(Transaction txn, ContactId c)
-	 * was last sent out.
-	 */
-	String GROUP_KEY_SENT_CLIENT_SUPPORTS = "sentClientSupports";
-
-	MailboxUpdate getLocalUpdate(Transaction txn, ContactId c)
 			throws DbException;
 
 	@Nullable
-	MailboxUpdate getRemoteUpdate(Transaction txn, ContactId c)
+	MailboxPropertiesUpdate getRemoteProperties(Transaction txn, ContactId c)
 			throws DbException;
 }

bramble-api/src/main/java/org/briarproject/bramble/api/mailbox/MailboxSettingsManager.java

@@ -7,8 +7,6 @@ import org.briarproject.bramble.api.db.Transaction;
 import org.briarproject.bramble.api.lifecycle.LifecycleManager;
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 
-import java.util.List;
-
 import javax.annotation.Nullable;
 
 @NotNullByDefault
@@ -28,8 +26,6 @@ public interface MailboxSettingsManager {
 	void setOwnMailboxProperties(Transaction txn, MailboxProperties p)
 			throws DbException;
 
-	void removeOwnMailboxProperties(Transaction txn) throws DbException;
-
 	MailboxStatus getOwnMailboxStatus(Transaction txn) throws DbException;
 
 	void recordSuccessfulConnection(Transaction txn, long now)
@@ -51,8 +47,7 @@ public interface MailboxSettingsManager {
 		 * @param txn A read-write transaction
 		 * @param ownOnion Our new mailbox's onion (56 base32 chars)
 		 */
-		void mailboxPaired(Transaction txn, String ownOnion,
+		void mailboxPaired(Transaction txn, String ownOnion)
-				List<MailboxVersion> serverSupports)
 				throws DbException;
 
 		/**

bramble-api/src/main/java/org/briarproject/bramble/api/mailbox/MailboxStatus.java

@@ -4,9 +4,6 @@ import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 
 import javax.annotation.concurrent.Immutable;
 
-import static org.briarproject.bramble.api.mailbox.MailboxConstants.PROBLEM_MS_SINCE_LAST_SUCCESS;
-import static org.briarproject.bramble.api.mailbox.MailboxConstants.PROBLEM_NUM_CONNECTION_FAILURES;
-
 @Immutable
 @NotNullByDefault
 public class MailboxStatus {
@@ -59,12 +56,4 @@ public class MailboxStatus {
 	public int getAttemptsSinceSuccess() {
 		return attemptsSinceSuccess;
 	}
-
-	/**
-	 * @return true if this status indicates a problem with the mailbox.
-	 */
-	public boolean hasProblem(long now) {
-		return attemptsSinceSuccess >= PROBLEM_NUM_CONNECTION_FAILURES &&
-				(now - lastSuccess) >= PROBLEM_MS_SINCE_LAST_SUCCESS;
-	}
 }

bramble-api/src/main/java/org/briarproject/bramble/api/mailbox/MailboxUpdate.java

@@ -1,31 +0,0 @@
-package org.briarproject.bramble.api.mailbox;
-
-import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
-
-import java.util.List;
-
-import javax.annotation.concurrent.Immutable;
-
-@Immutable
-@NotNullByDefault
-public class MailboxUpdate {
-	private final boolean hasMailbox;
-	private final List<MailboxVersion> clientSupports;
-
-	public MailboxUpdate(List<MailboxVersion> clientSupports) {
-		this(clientSupports, false);
-	}
-
-	MailboxUpdate(List<MailboxVersion> clientSupports, boolean hasMailbox) {
-		this.clientSupports = clientSupports;
-		this.hasMailbox = hasMailbox;
-	}
-
-	public List<MailboxVersion> getClientSupports() {
-		return clientSupports;
-	}
-
-	public boolean hasMailbox() {
-		return hasMailbox;
-	}
-}

bramble-api/src/main/java/org/briarproject/bramble/api/mailbox/MailboxUpdateWithMailbox.java

@@ -1,30 +0,0 @@
-package org.briarproject.bramble.api.mailbox;
-
-import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
-
-import java.util.List;
-
-import javax.annotation.concurrent.Immutable;
-
-@Immutable
-@NotNullByDefault
-public class MailboxUpdateWithMailbox extends MailboxUpdate {
-
-	private final MailboxProperties properties;
-
-	public MailboxUpdateWithMailbox(List<MailboxVersion> clientSupports,
-			MailboxProperties properties) {
-		super(clientSupports, true);
-		if (properties.isOwner()) throw new IllegalArgumentException();
-		this.properties = properties;
-	}
-
-	public MailboxUpdateWithMailbox(MailboxUpdateWithMailbox o,
-			List<MailboxVersion> newClientSupports) {
-		this(newClientSupports, o.getMailboxProperties());
-	}
-
-	public MailboxProperties getMailboxProperties() {
-		return properties;
-	}
-}

bramble-api/src/main/java/org/briarproject/bramble/api/mailbox/OwnMailboxConnectionStatusEvent.java

@@ -1,8 +1,6 @@
-package org.briarproject.bramble.api.mailbox.event;
+package org.briarproject.bramble.api.mailbox;
 
 import org.briarproject.bramble.api.event.Event;
-import org.briarproject.bramble.api.mailbox.MailboxSettingsManager;
-import org.briarproject.bramble.api.mailbox.MailboxStatus;
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 
 import javax.annotation.concurrent.Immutable;

bramble-api/src/main/java/org/briarproject/bramble/api/mailbox/RemoteMailboxPropertiesUpdateEvent.java

@@ -0,0 +1,36 @@
+package org.briarproject.bramble.api.mailbox;
+
+import org.briarproject.bramble.api.contact.ContactId;
+import org.briarproject.bramble.api.event.Event;
+import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
+
+import javax.annotation.Nullable;
+import javax.annotation.concurrent.Immutable;
+
+/**
+ * An event that is broadcast when {@link MailboxPropertiesUpdate} are received
+ * from a contact.
+ */
+@Immutable
+@NotNullByDefault
+public class RemoteMailboxPropertiesUpdateEvent extends Event {
+
+	private final ContactId contactId;
+	@Nullable
+	private final MailboxPropertiesUpdate mailboxPropertiesUpdate;
+
+	public RemoteMailboxPropertiesUpdateEvent(ContactId contactId,
+			@Nullable MailboxPropertiesUpdate mailboxPropertiesUpdate) {
+		this.contactId = contactId;
+		this.mailboxPropertiesUpdate = mailboxPropertiesUpdate;
+	}
+
+	public ContactId getContact() {
+		return contactId;
+	}
+
+	@Nullable
+	public MailboxPropertiesUpdate getMailboxPropertiesUpdate() {
+		return mailboxPropertiesUpdate;
+	}
+}

bramble-api/src/main/java/org/briarproject/bramble/api/mailbox/event/MailboxProblemEvent.java

@@ -1,19 +0,0 @@
-package org.briarproject.bramble.api.mailbox.event;
-
-import org.briarproject.bramble.api.event.Event;
-import org.briarproject.bramble.api.mailbox.MailboxSettingsManager;
-import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
-
-import javax.annotation.concurrent.Immutable;
-
-/**
- * An event that is broadcast by {@link MailboxSettingsManager} when
- * recording a connection failure for own Mailbox
- * that has persistent for long enough for the mailbox owner to become active
- * and fix the problem with the mailbox.
- */
-@Immutable
-@NotNullByDefault
-public class MailboxProblemEvent extends Event {
-
-}

bramble-api/src/main/java/org/briarproject/bramble/api/mailbox/event/RemoteMailboxUpdateEvent.java

@@ -1,34 +0,0 @@
-package org.briarproject.bramble.api.mailbox.event;
-
-import org.briarproject.bramble.api.contact.ContactId;
-import org.briarproject.bramble.api.event.Event;
-import org.briarproject.bramble.api.mailbox.MailboxUpdate;
-import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
-
-import javax.annotation.concurrent.Immutable;
-
-/**
- * An event that is broadcast when {@link MailboxUpdate} are received
- * from a contact.
- */
-@Immutable
-@NotNullByDefault
-public class RemoteMailboxUpdateEvent extends Event {
-
-	private final ContactId contactId;
-	private final MailboxUpdate mailboxUpdate;
-
-	public RemoteMailboxUpdateEvent(ContactId contactId,
-			MailboxUpdate mailboxUpdate) {
-		this.contactId = contactId;
-		this.mailboxUpdate = mailboxUpdate;
-	}
-
-	public ContactId getContact() {
-		return contactId;
-	}
-
-	public MailboxUpdate getMailboxUpdate() {
-		return mailboxUpdate;
-	}
-}

bramble-api/src/main/java/org/briarproject/bramble/api/plugin/TorConstants.java

@@ -1,7 +1,5 @@
 package org.briarproject.bramble.api.plugin;
 
-import static java.util.concurrent.TimeUnit.SECONDS;
-
 public interface TorConstants {
 
 	TransportId ID = new TransportId("org.briarproject.bramble.tor");
@@ -12,9 +10,8 @@ public interface TorConstants {
 	int DEFAULT_SOCKS_PORT = 59050;
 	int DEFAULT_CONTROL_PORT = 59051;
 
-	int CONNECT_TO_PROXY_TIMEOUT = (int) SECONDS.toMillis(5);
+	int CONNECT_TO_PROXY_TIMEOUT = 5000; // Milliseconds
-	int EXTRA_CONNECT_TIMEOUT = (int) SECONDS.toMillis(120);
+	int EXTRA_SOCKET_TIMEOUT = 30000; // Milliseconds
-	int EXTRA_SOCKET_TIMEOUT = (int) SECONDS.toMillis(30);
 
 	// Local settings (not shared with contacts)
 	String PREF_TOR_NETWORK = "network2";

bramble-api/src/main/java/org/briarproject/bramble/api/record/RecordWriter.java

@@ -12,6 +12,4 @@ public interface RecordWriter {
 	void flush() throws IOException;
 
 	void close() throws IOException;
-
-	long getBytesWritten();
 }

bramble-api/src/main/java/org/briarproject/bramble/api/sync/DeferredSendHandler.java

@@ -1,15 +0,0 @@
-package org.briarproject.bramble.api.sync;
-
-import java.util.Collection;
-
-/**
- * An interface for holding the IDs of messages sent and acked during an
- * outgoing {@link SyncSession} so they can be recorded in the DB as sent
- * or acked at some later time.
- */
-public interface DeferredSendHandler {
-
-	void onAckSent(Collection<MessageId> acked);
-
-	void onMessageSent(MessageId sent);
-}

bramble-api/src/main/java/org/briarproject/bramble/api/sync/SyncRecordWriter.java

@@ -20,6 +20,4 @@ public interface SyncRecordWriter {
 	void writePriority(Priority p) throws IOException;
 
 	void flush() throws IOException;
-
-	long getBytesWritten();
 }

bramble-api/src/main/java/org/briarproject/bramble/api/system/TaskScheduler.java

@@ -1,6 +1,5 @@
 package org.briarproject.bramble.api.system;
 
-import org.briarproject.bramble.api.Cancellable;
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 
 import java.util.concurrent.Executor;
@@ -17,8 +16,6 @@ public interface TaskScheduler {
 	 * <p>
 	 * If the platform supports wake locks, a wake lock will be held while
 	 * submitting and running the task.
-	 *
-	 * @return A {@link Cancellable} for cancelling the task.
 	 */
 	Cancellable schedule(Runnable task, Executor executor, long delay,
 			TimeUnit unit);
@@ -30,11 +27,17 @@ public interface TaskScheduler {
 	 * <p>
 	 * If the platform supports wake locks, a wake lock will be held while
 	 * submitting and running the task.
-	 *
-	 * @return A {@link Cancellable} for cancelling all future executions of
-	 * the task.
 	 */
 	Cancellable scheduleWithFixedDelay(Runnable task, Executor executor,
 			long delay, long interval, TimeUnit unit);
 
+	interface Cancellable {
+
+		/**
+		 * Cancels the task if it has not already started running. If the task
+		 * is {@link #scheduleWithFixedDelay(Runnable, Executor, long, long, TimeUnit) periodic},
+		 * all future executions of the task are cancelled.
+		 */
+		void cancel();
+	}
 }

bramble-api/src/test/java/org/briarproject/bramble/test/TestUtils.java

@@ -20,12 +20,8 @@ import org.briarproject.bramble.api.identity.Author;
 import org.briarproject.bramble.api.identity.AuthorId;
 import org.briarproject.bramble.api.identity.Identity;
 import org.briarproject.bramble.api.identity.LocalAuthor;
-import org.briarproject.bramble.api.mailbox.MailboxAuthToken;
-import org.briarproject.bramble.api.mailbox.MailboxFolderId;
 import org.briarproject.bramble.api.mailbox.MailboxProperties;
-import org.briarproject.bramble.api.mailbox.MailboxUpdate;
+import org.briarproject.bramble.api.mailbox.MailboxPropertiesUpdate;
-import org.briarproject.bramble.api.mailbox.MailboxUpdateWithMailbox;
-import org.briarproject.bramble.api.mailbox.MailboxVersion;
 import org.briarproject.bramble.api.plugin.TransportId;
 import org.briarproject.bramble.api.properties.TransportProperties;
 import org.briarproject.bramble.api.sync.ClientId;
@@ -226,19 +222,6 @@ public class TestUtils {
 				getAgreementPublicKey(), verified);
 	}
 
-	public static MailboxProperties getMailboxProperties(boolean owner,
-			List<MailboxVersion> serverSupports) {
-		String baseUrl = "http://" + getRandomString(56) + ".onion"; // TODO
-		MailboxAuthToken authToken = new MailboxAuthToken(getRandomId());
-		if (owner) {
-			return new MailboxProperties(baseUrl, authToken, serverSupports);
-		}
-		MailboxFolderId inboxId = new MailboxFolderId(getRandomId());
-		MailboxFolderId outboxId = new MailboxFolderId(getRandomId());
-		return new MailboxProperties(baseUrl, authToken, serverSupports,
-				inboxId, outboxId);
-	}
-
 	public static void writeBytes(File file, byte[] bytes)
 			throws IOException {
 		FileOutputStream outputStream = new FileOutputStream(file);
@@ -291,30 +274,26 @@ public class TestUtils {
 		return Math.sqrt(getVariance(samples));
 	}
 
-	public static boolean isOptionalTestEnabled(Class<?> testClass) {
+	public static boolean isOptionalTestEnabled(Class testClass) {
 		String optionalTests = System.getenv("OPTIONAL_TESTS");
 		return optionalTests != null &&
 				asList(optionalTests.split(",")).contains(testClass.getName());
 	}
 
-	public static boolean mailboxUpdateEqual(@Nullable MailboxUpdate a,
+	public static boolean mailboxPropertiesUpdateEqual(
-			@Nullable MailboxUpdate b) {
+			@Nullable MailboxPropertiesUpdate a,
+			@Nullable MailboxPropertiesUpdate b) {
 		if (a == null || b == null) {
 			return a == b;
 		}
-		if (!a.hasMailbox() && !b.hasMailbox()) {
+		return a.getOnion().equals(b.getOnion()) &&
-			return a.getClientSupports().equals(b.getClientSupports());
+				a.getAuthToken().equals(b.getAuthToken()) &&
-		} else if (a.hasMailbox() && b.hasMailbox()) {
+				a.getInboxId().equals(b.getInboxId()) &&
-			MailboxUpdateWithMailbox am = (MailboxUpdateWithMailbox) a;
+				a.getOutboxId().equals(b.getOutboxId());
-			MailboxUpdateWithMailbox bm = (MailboxUpdateWithMailbox) b;
-			return am.getClientSupports().equals(bm.getClientSupports()) &&
-					mailboxPropertiesEqual(am.getMailboxProperties(),
-							bm.getMailboxProperties());
-		}
-		return false;
 	}
 
-	public static boolean mailboxPropertiesEqual(@Nullable MailboxProperties a,
+	public static boolean mailboxPropertiesEqual(
+			@Nullable MailboxProperties a,
 			@Nullable MailboxProperties b) {
 		if (a == null || b == null) {
 			return a == b;

bramble-core/build.gradle

@@ -16,7 +16,7 @@ dependencies {
 	implementation 'org.bitlet:weupnp:0.1.4'
 	implementation 'net.i2p.crypto:eddsa:0.2.0'
 	implementation 'org.whispersystems:curve25519-java:0.5.0'
-	implementation 'org.briarproject:jtorctl:0.4'
+	implementation 'org.briarproject:jtorctl:0.3'
 
 	//noinspection GradleDependency
 	implementation "com.squareup.okhttp3:okhttp:$okhttp_version"

bramble-core/src/main/java/org/briarproject/bramble/client/ClientHelperImpl.java

@@ -25,10 +25,7 @@ import org.briarproject.bramble.api.identity.Author;
 import org.briarproject.bramble.api.identity.AuthorFactory;
 import org.briarproject.bramble.api.mailbox.MailboxAuthToken;
 import org.briarproject.bramble.api.mailbox.MailboxFolderId;
-import org.briarproject.bramble.api.mailbox.MailboxProperties;
+import org.briarproject.bramble.api.mailbox.MailboxPropertiesUpdate;
-import org.briarproject.bramble.api.mailbox.MailboxUpdate;
-import org.briarproject.bramble.api.mailbox.MailboxUpdateWithMailbox;
-import org.briarproject.bramble.api.mailbox.MailboxVersion;
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.bramble.api.plugin.TransportId;
 import org.briarproject.bramble.api.properties.TransportProperties;
@@ -42,13 +39,12 @@ import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
 import java.security.GeneralSecurityException;
-import java.util.ArrayList;
 import java.util.Collection;
 import java.util.HashMap;
-import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
 
+import javax.annotation.Nullable;
 import javax.annotation.concurrent.Immutable;
 import javax.inject.Inject;
 
@@ -56,12 +52,12 @@ import static org.briarproject.bramble.api.client.ContactGroupConstants.GROUP_KE
 import static org.briarproject.bramble.api.identity.Author.FORMAT_VERSION;
 import static org.briarproject.bramble.api.identity.AuthorConstants.MAX_AUTHOR_NAME_LENGTH;
 import static org.briarproject.bramble.api.identity.AuthorConstants.MAX_PUBLIC_KEY_LENGTH;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.PROP_COUNT;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.PROP_COUNT;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.PROP_KEY_AUTHTOKEN;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.PROP_KEY_AUTHTOKEN;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.PROP_KEY_INBOXID;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.PROP_KEY_INBOXID;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.PROP_KEY_ONION;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.PROP_KEY_ONION;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.PROP_KEY_OUTBOXID;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.PROP_KEY_OUTBOXID;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.PROP_ONION_LENGTH;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.PROP_ONION_LENGTH;
 import static org.briarproject.bramble.api.properties.TransportPropertyConstants.MAX_PROPERTIES_PER_TRANSPORT;
 import static org.briarproject.bramble.api.properties.TransportPropertyConstants.MAX_PROPERTY_LENGTH;
 import static org.briarproject.bramble.util.ValidationUtils.checkLength;
@@ -416,28 +412,11 @@ class ClientHelperImpl implements ClientHelper {
 	}
 
 	@Override
-	public MailboxUpdate parseAndValidateMailboxUpdate(BdfList clientSupports,
+	@Nullable
-			BdfList serverSupports, BdfDictionary properties)
+	public MailboxPropertiesUpdate parseAndValidateMailboxPropertiesUpdate(
-			throws FormatException {
+			BdfDictionary properties) throws FormatException {
-		List<MailboxVersion> clientSupportsList =
-				parseMailboxVersionList(clientSupports);
-		List<MailboxVersion> serverSupportsList =
-				parseMailboxVersionList(serverSupports);
-
-		// We must always learn what Mailbox API version(s) the client supports
-		if (clientSupports.isEmpty()) {
-			throw new FormatException();
-		}
 		if (properties.isEmpty()) {
-			// No mailbox -- cannot claim to support any API versions!
+			return null;
-			if (!serverSupports.isEmpty()) {
-				throw new FormatException();
-			}
-			return new MailboxUpdate(clientSupportsList);
-		}
-		// Mailbox must be accompanied by the Mailbox API version(s) it supports
-		if (serverSupports.isEmpty()) {
-			throw new FormatException();
 		}
 		// Accepting more props than we need, for forward compatibility
 		if (properties.size() < PROP_COUNT) {
@@ -456,26 +435,9 @@ class ClientHelperImpl implements ClientHelper {
 		checkLength(inboxId, UniqueId.LENGTH);
 		byte[] outboxId = properties.getRaw(PROP_KEY_OUTBOXID);
 		checkLength(outboxId, UniqueId.LENGTH);
-		String baseUrl = "http://" + onion + ".onion"; // TODO
+		return new MailboxPropertiesUpdate(onion,
-		MailboxProperties props = new MailboxProperties(baseUrl,
+				new MailboxAuthToken(authToken), new MailboxFolderId(inboxId),
-				new MailboxAuthToken(authToken), serverSupportsList,
+				new MailboxFolderId(outboxId));
-				new MailboxFolderId(inboxId), new MailboxFolderId(outboxId));
-		return new MailboxUpdateWithMailbox(clientSupportsList, props);
-	}
-
-	@Override
-	public List<MailboxVersion> parseMailboxVersionList(BdfList bdfList)
-			throws FormatException {
-		List<MailboxVersion> list = new ArrayList<>();
-		for (int i = 0; i < bdfList.size(); i++) {
-			BdfList element = bdfList.getList(i);
-			if (element.size() != 2) {
-				throw new FormatException();
-			}
-			list.add(new MailboxVersion(element.getLong(0).intValue(),
-					element.getLong(1).intValue()));
-		}
-		return list;
 	}
 
 	@Override

bramble-core/src/main/java/org/briarproject/bramble/db/Database.java

@@ -406,12 +406,6 @@ interface Database<T> {
 	Collection<MessageId> getMessageIds(T txn, GroupId g, Metadata query)
 			throws DbException;
 
-	/**
-	 * Returns the length of the given message in bytes, including the
-	 * message header.
-	 */
-	int getMessageLength(T txn, MessageId m) throws DbException;
-
 	/**
 	 * Returns the metadata for all delivered messages in the given group.
 	 * <p/>
@@ -502,8 +496,7 @@ interface Database<T> {
 
 	/**
 	 * Returns the IDs of some messages that are eligible to be sent to the
-	 * given contact. The total length of the messages including record headers
+	 * given contact, up to the given total length.
-	 * will be no more than the given capacity.
 	 * <p/>
 	 * Unlike {@link #getUnackedMessagesToSend(Object, ContactId)} this method
 	 * does not return messages that have already been sent unless they are
@@ -511,20 +504,20 @@ interface Database<T> {
 	 * <p/>
 	 * Read-only.
 	 */
-	Collection<MessageId> getMessagesToSend(T txn, ContactId c, long capacity,
+	Collection<MessageId> getMessagesToSend(T txn, ContactId c, int maxLength,
 			long maxLatency) throws DbException;
 
 	/**
 	 * Returns the IDs of all messages that are eligible to be sent to the
-	 * given contact.
+	 * given contact, together with their raw lengths.
 	 * <p/>
-	 * Unlike {@link #getMessagesToSend(Object, ContactId, long, long)} this
+	 * Unlike {@link #getMessagesToSend(Object, ContactId, int, long)} this
 	 * method may return messages that have already been sent and are not yet
 	 * due for retransmission.
 	 * <p/>
 	 * Read-only.
 	 */
-	Collection<MessageId> getUnackedMessagesToSend(T txn, ContactId c)
+	Map<MessageId, Integer> getUnackedMessagesToSend(T txn, ContactId c)
 			throws DbException;
 
 	/**
@@ -605,14 +598,13 @@ interface Database<T> {
 
 	/**
 	 * Returns the IDs of some messages that are eligible to be sent to the
-	 * given contact and have been requested by the contact. The total length
+	 * given contact and have been requested by the contact, up to the given
-	 * of the messages including record headers will be no more than the given
+	 * total length.
-	 * capacity.
 	 * <p/>
 	 * Read-only.
 	 */
 	Collection<MessageId> getRequestedMessagesToSend(T txn, ContactId c,
-			long capacity, long maxLatency) throws DbException;
+			int maxLength, long maxLatency) throws DbException;
 
 	/**
 	 * Returns all settings in the given namespace.
@@ -870,4 +862,6 @@ interface Database<T> {
 	 * Stores the given transport keys, deleting any keys they have replaced.
 	 */
 	void updateTransportKeys(T txn, TransportKeySet ks) throws DbException;
+
+	void printStats(T txn) throws DbException;
 }

bramble-core/src/main/java/org/briarproject/bramble/db/DatabaseComponentImpl.java

@@ -75,6 +75,7 @@ import org.briarproject.bramble.api.transport.TransportKeys;
 
 import java.util.ArrayList;
 import java.util.Collection;
+import java.util.Collections;
 import java.util.List;
 import java.util.Map;
 import java.util.concurrent.Executor;
@@ -86,7 +87,6 @@ import javax.annotation.Nullable;
 import javax.annotation.concurrent.ThreadSafe;
 import javax.inject.Inject;
 
-import static java.util.Collections.singletonList;
 import static java.util.logging.Level.WARNING;
 import static java.util.logging.Logger.getLogger;
 import static org.briarproject.bramble.api.sync.Group.Visibility.INVISIBLE;
@@ -424,14 +424,13 @@ class DatabaseComponentImpl<T> implements DatabaseComponent {
 	@Nullable
 	@Override
 	public Collection<Message> generateBatch(Transaction transaction,
-			ContactId c, long capacity, long maxLatency) throws DbException {
+			ContactId c, int maxLength, long maxLatency) throws DbException {
 		if (transaction.isReadOnly()) throw new IllegalArgumentException();
 		T txn = unbox(transaction);
 		if (!db.containsContact(txn, c))
 			throw new NoSuchContactException();
 		Collection<MessageId> ids =
-				db.getMessagesToSend(txn, c, capacity, maxLatency);
+				db.getMessagesToSend(txn, c, maxLength, maxLatency);
-		if (ids.isEmpty()) return null;
 		long totalLength = 0;
 		List<Message> messages = new ArrayList<>(ids.size());
 		for (MessageId m : ids) {
@@ -440,11 +439,38 @@ class DatabaseComponentImpl<T> implements DatabaseComponent {
 			messages.add(message);
 			db.updateRetransmissionData(txn, c, m, maxLatency);
 		}
+		if (ids.isEmpty()) return null;
 		db.lowerRequestedFlag(txn, c, ids);
 		transaction.attach(new MessagesSentEvent(c, ids, totalLength));
 		return messages;
 	}
 
+	@Override
+	public Collection<Message> generateBatch(Transaction transaction,
+			ContactId c, Collection<MessageId> ids, long maxLatency)
+			throws DbException {
+		if (transaction.isReadOnly()) throw new IllegalArgumentException();
+		T txn = unbox(transaction);
+		if (!db.containsContact(txn, c))
+			throw new NoSuchContactException();
+		long totalLength = 0;
+		List<Message> messages = new ArrayList<>(ids.size());
+		List<MessageId> sentIds = new ArrayList<>(ids.size());
+		for (MessageId m : ids) {
+			if (db.containsVisibleMessage(txn, c, m)) {
+				Message message = db.getMessage(txn, m);
+				totalLength += message.getRawLength();
+				messages.add(message);
+				sentIds.add(m);
+				db.updateRetransmissionData(txn, c, m, maxLatency);
+			}
+		}
+		if (messages.isEmpty()) return messages;
+		db.lowerRequestedFlag(txn, c, sentIds);
+		transaction.attach(new MessagesSentEvent(c, sentIds, totalLength));
+		return messages;
+	}
+
 	@Nullable
 	@Override
 	public Offer generateOffer(Transaction transaction, ContactId c,
@@ -479,14 +505,13 @@ class DatabaseComponentImpl<T> implements DatabaseComponent {
 	@Nullable
 	@Override
 	public Collection<Message> generateRequestedBatch(Transaction transaction,
-			ContactId c, long capacity, long maxLatency) throws DbException {
+			ContactId c, int maxLength, long maxLatency) throws DbException {
 		if (transaction.isReadOnly()) throw new IllegalArgumentException();
 		T txn = unbox(transaction);
 		if (!db.containsContact(txn, c))
 			throw new NoSuchContactException();
 		Collection<MessageId> ids =
-				db.getRequestedMessagesToSend(txn, c, capacity, maxLatency);
+				db.getRequestedMessagesToSend(txn, c, maxLength, maxLatency);
-		if (ids.isEmpty()) return null;
 		long totalLength = 0;
 		List<Message> messages = new ArrayList<>(ids.size());
 		for (MessageId m : ids) {
@@ -495,6 +520,7 @@ class DatabaseComponentImpl<T> implements DatabaseComponent {
 			messages.add(message);
 			db.updateRetransmissionData(txn, c, m, maxLatency);
 		}
+		if (ids.isEmpty()) return null;
 		db.lowerRequestedFlag(txn, c, ids);
 		transaction.attach(new MessagesSentEvent(c, ids, totalLength));
 		return messages;
@@ -609,24 +635,6 @@ class DatabaseComponentImpl<T> implements DatabaseComponent {
 		return db.getMessageIds(txn, g, query);
 	}
 
-	@Override
-	public Collection<MessageId> getMessagesToAck(Transaction transaction,
-			ContactId c, int maxMessages) throws DbException {
-		T txn = unbox(transaction);
-		if (!db.containsContact(txn, c))
-			throw new NoSuchContactException();
-		return db.getMessagesToAck(txn, c, maxMessages);
-	}
-
-	@Override
-	public Collection<MessageId> getMessagesToSend(Transaction transaction,
-			ContactId c, long capacity, long maxLatency) throws DbException {
-		T txn = unbox(transaction);
-		if (!db.containsContact(txn, c))
-			throw new NoSuchContactException();
-		return db.getMessagesToSend(txn, c, capacity, maxLatency);
-	}
-
 	@Override
 	public Collection<MessageId> getMessagesToValidate(Transaction transaction)
 			throws DbException {
@@ -732,29 +740,10 @@ class DatabaseComponentImpl<T> implements DatabaseComponent {
 		return status;
 	}
 
-	@Nullable
 	@Override
-	public Message getMessageToSend(Transaction transaction, ContactId c,
+	public Map<MessageId, Integer> getUnackedMessagesToSend(
-			MessageId m, long maxLatency, boolean markAsSent)
+			Transaction transaction,
-			throws DbException {
+			ContactId c) throws DbException {
-		if (transaction.isReadOnly()) throw new IllegalArgumentException();
-		T txn = unbox(transaction);
-		if (!db.containsContact(txn, c))
-			throw new NoSuchContactException();
-		if (!db.containsVisibleMessage(txn, c, m)) return null;
-		Message message = db.getMessage(txn, m);
-		if (markAsSent) {
-			db.updateRetransmissionData(txn, c, m, maxLatency);
-			db.lowerRequestedFlag(txn, c, singletonList(m));
-			transaction.attach(new MessagesSentEvent(c, singletonList(m),
-					message.getRawLength()));
-		}
-		return message;
-	}
-
-	@Override
-	public Collection<MessageId> getUnackedMessagesToSend(
-			Transaction transaction, ContactId c) throws DbException {
 		T txn = unbox(transaction);
 		if (!db.containsContact(txn, c))
 			throw new NoSuchContactException();
@@ -1080,20 +1069,6 @@ class DatabaseComponentImpl<T> implements DatabaseComponent {
 		db.removeTransportKeys(txn, t, k);
 	}
 
-	@Override
-	public void setAckSent(Transaction transaction, ContactId c,
-			Collection<MessageId> acked) throws DbException {
-		if (transaction.isReadOnly()) throw new IllegalArgumentException();
-		T txn = unbox(transaction);
-		if (!db.containsContact(txn, c))
-			throw new NoSuchContactException();
-		List<MessageId> visible = new ArrayList<>(acked.size());
-		for (MessageId m : acked) {
-			if (db.containsVisibleMessage(txn, c, m)) visible.add(m);
-		}
-		db.lowerAckFlag(txn, c, visible);
-	}
-
 	@Override
 	public void setCleanupTimerDuration(Transaction transaction, MessageId m,
 			long duration) throws DbException {
@@ -1140,7 +1115,7 @@ class DatabaseComponentImpl<T> implements DatabaseComponent {
 		if (old == INVISIBLE) db.addGroupVisibility(txn, c, g, v == SHARED);
 		else if (v == INVISIBLE) db.removeGroupVisibility(txn, c, g);
 		else db.setGroupVisibility(txn, c, g, v == SHARED);
-		List<ContactId> affected = singletonList(c);
+		List<ContactId> affected = Collections.singletonList(c);
 		transaction.attach(new GroupVisibilityUpdatedEvent(affected));
 	}
 
@@ -1188,28 +1163,6 @@ class DatabaseComponentImpl<T> implements DatabaseComponent {
 		transaction.attach(new MessageStateChangedEvent(m, false, state));
 	}
 
-	@Override
-	public void setMessagesSent(Transaction transaction, ContactId c,
-			Collection<MessageId> sent, long maxLatency) throws DbException {
-		if (transaction.isReadOnly()) throw new IllegalArgumentException();
-		T txn = unbox(transaction);
-		if (!db.containsContact(txn, c))
-			throw new NoSuchContactException();
-		long totalLength = 0;
-		List<MessageId> visible = new ArrayList<>(sent.size());
-		for (MessageId m : sent) {
-			if (db.containsVisibleMessage(txn, c, m)) {
-				visible.add(m);
-				totalLength += db.getMessageLength(txn, m);
-				db.updateRetransmissionData(txn, c, m, maxLatency);
-			}
-		}
-		db.lowerRequestedFlag(txn, c, visible);
-		if (!visible.isEmpty()) {
-			transaction.attach(new MessagesSentEvent(c, visible, totalLength));
-		}
-	}
-
 	@Override
 	public void addMessageDependencies(Transaction transaction,
 			Message dependent, Collection<MessageId> dependencies)
@@ -1303,6 +1256,12 @@ class DatabaseComponentImpl<T> implements DatabaseComponent {
 		}
 	}
 
+	@Override
+	public void printStats(Transaction transaction) throws DbException {
+		T txn = unbox(transaction);
+		db.printStats(txn);
+	}
+
 	private class CommitActionVisitor implements Visitor {
 
 		@Override

bramble-core/src/main/java/org/briarproject/bramble/db/H2Database.java

@@ -13,8 +13,12 @@ import org.briarproject.bramble.util.StringUtils;
 import java.io.File;
 import java.sql.Connection;
 import java.sql.DriverManager;
+import java.sql.PreparedStatement;
+import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.sql.Statement;
+import java.util.ArrayList;
+import java.util.List;
 import java.util.Properties;
 import java.util.logging.Logger;
 
@@ -26,6 +30,7 @@ import static java.util.logging.Level.WARNING;
 import static java.util.logging.Logger.getLogger;
 import static org.briarproject.bramble.db.JdbcUtils.tryToClose;
 import static org.briarproject.bramble.util.IoUtils.isNonEmptyDirectory;
+import static org.briarproject.bramble.util.LogUtils.logException;
 import static org.briarproject.bramble.util.LogUtils.logFileOrDir;
 
 /**
@@ -101,6 +106,73 @@ class H2Database extends JdbcDatabase {
 		}
 	}
 
+	@Override
+	public void printStats(Connection txn) throws DbException {
+		List<String> names = printNames(txn);
+		for (String table : names) {
+			tryPrintStats(txn, table);
+		}
+	}
+
+	private List<String> printNames(Connection txn) throws DbException {
+		List<String> names = new ArrayList<>();
+		PreparedStatement ps = null;
+		ResultSet rs = null;
+		try {
+			String sql =
+					"SELECT table_catalog, table_schema, table_name FROM INFORMATION_SCHEMA.TABLES";
+			ps = txn.prepareStatement(sql);
+			rs = ps.executeQuery();
+			while (rs.next()) {
+				String catalog = rs.getString(1);
+				String schema = rs.getString(2);
+				String name = rs.getString(3);
+				LOG.info(
+						String.format("Table %s %s %s", catalog, schema, name));
+				names.add(schema + "." + name);
+			}
+			rs.close();
+			ps.close();
+		} catch (SQLException e) {
+			tryToClose(rs, LOG, WARNING);
+			tryToClose(ps, LOG, WARNING);
+			throw new DbException(e);
+		}
+		return names;
+	}
+
+	private void tryPrintStats(Connection txn, String table) {
+		try {
+			printStats(txn, table);
+		} catch (DbException e) {
+			logException(LOG, WARNING, e);
+		}
+	}
+
+	private void printStats(Connection txn, String table) throws DbException {
+		PreparedStatement ps = null;
+		ResultSet rs = null;
+		try {
+			String sql = "CALL DISK_SPACE_USED(?)";
+			ps = txn.prepareStatement(sql);
+			ps.setString(1, table);
+			rs = ps.executeQuery();
+			if (!rs.next()) {
+				rs.close();
+				ps.close();
+			}
+			long size = rs.getLong(1);
+			if (rs.next()) throw new DbStateException();
+			rs.close();
+			ps.close();
+			LOG.info(String.format("Size of table %s: %d", table, size));
+		} catch (SQLException e) {
+			tryToClose(rs, LOG, WARNING);
+			tryToClose(ps, LOG, WARNING);
+			throw new DbException(e);
+		}
+	}
+
 	@Override
 	protected Connection createConnection() throws DbException, SQLException {
 		SecretKey key = this.key;

bramble-core/src/main/java/org/briarproject/bramble/db/HyperSqlDatabase.java

@@ -93,6 +93,11 @@ class HyperSqlDatabase extends JdbcDatabase {
 		}
 	}
 
+	@Override
+	public void printStats(Connection txn) throws DbException {
+		// Not implemented
+	}
+
 	@Override
 	protected Connection createConnection() throws DbException, SQLException {
 		SecretKey key = this.key;

bramble-core/src/main/java/org/briarproject/bramble/db/JdbcDatabase.java

@@ -51,6 +51,7 @@ import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.HashSet;
+import java.util.LinkedHashMap;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
@@ -69,14 +70,12 @@ import static java.sql.Types.BOOLEAN;
 import static java.sql.Types.INTEGER;
 import static java.sql.Types.VARCHAR;
 import static java.util.Arrays.asList;
-import static java.util.logging.Level.FINE;
 import static java.util.logging.Level.INFO;
 import static java.util.logging.Level.WARNING;
 import static java.util.logging.Logger.getLogger;
 import static org.briarproject.bramble.api.db.DatabaseComponent.NO_CLEANUP_DEADLINE;
 import static org.briarproject.bramble.api.db.DatabaseComponent.TIMER_NOT_STARTED;
 import static org.briarproject.bramble.api.db.Metadata.REMOVE;
-import static org.briarproject.bramble.api.record.Record.RECORD_HEADER_BYTES;
 import static org.briarproject.bramble.api.sync.Group.Visibility.INVISIBLE;
 import static org.briarproject.bramble.api.sync.Group.Visibility.SHARED;
 import static org.briarproject.bramble.api.sync.Group.Visibility.VISIBLE;
@@ -103,11 +102,6 @@ abstract class JdbcDatabase implements Database<Connection> {
 	// Package access for testing
 	static final int CODE_SCHEMA_VERSION = 50;
 
-	/**
-	 * The maximum number of idle connections to keep open.
-	 */
-	private static final int MAX_CONNECTION_POOL_SIZE = 1;
-
 	// Time period offsets for incoming transport keys
 	private static final int OFFSET_PREV = -1;
 	private static final int OFFSET_CURR = 0;
@@ -369,7 +363,7 @@ abstract class JdbcDatabase implements Database<Connection> {
 	private final Condition connectionsChanged = connectionsLock.newCondition();
 
 	@GuardedBy("connectionsLock")
-	private final LinkedList<Connection> connectionPool = new LinkedList<>();
+	private final LinkedList<Connection> connections = new LinkedList<>();
 
 	@GuardedBy("connectionsLock")
 	private int openConnections = 0;
@@ -577,8 +571,7 @@ abstract class JdbcDatabase implements Database<Connection> {
 		connectionsLock.lock();
 		try {
 			if (closed) throw new DbClosedException();
-			txn = connectionPool.poll();
+			txn = connections.poll();
-			logConnectionCounts();
 		} finally {
 			connectionsLock.unlock();
 		}
@@ -589,14 +582,7 @@ abstract class JdbcDatabase implements Database<Connection> {
 				txn.setAutoCommit(false);
 				connectionsLock.lock();
 				try {
-					// The DB may have been closed since the check above
-					if (closed) {
-						tryToClose(txn, LOG, WARNING);
-						throw new DbClosedException();
-					}
 					openConnections++;
-					logConnectionCounts();
-					connectionsChanged.signalAll();
 				} finally {
 					connectionsLock.unlock();
 				}
@@ -607,91 +593,67 @@ abstract class JdbcDatabase implements Database<Connection> {
 		return txn;
 	}
 
-	@GuardedBy("connectionsLock")
-	private void logConnectionCounts() {
-		if (LOG.isLoggable(FINE)) {
-			LOG.fine(openConnections + " connections open, "
-					+ connectionPool.size() + " in pool");
-		}
-	}
-
 	@Override
 	public void abortTransaction(Connection txn) {
-		// The transaction may have been aborted due to an earlier exception,
-		// so close the connection rather than returning it to the pool
 		try {
 			txn.rollback();
+			connectionsLock.lock();
+			try {
+				connections.add(txn);
+				connectionsChanged.signalAll();
+			} finally {
+				connectionsLock.unlock();
+			}
 		} catch (SQLException e) {
+			// Try to close the connection
 			logException(LOG, WARNING, e);
-		}
+			tryToClose(txn, LOG, WARNING);
-		closeConnection(txn);
+			// Whatever happens, allow the database to close
-	}
+			connectionsLock.lock();
-
+			try {
-	private void closeConnection(Connection txn) {
+				openConnections--;
-		tryToClose(txn, LOG, WARNING);
+				connectionsChanged.signalAll();
-		connectionsLock.lock();
+			} finally {
-		try {
+				connectionsLock.unlock();
-			openConnections--;
+			}
-			logConnectionCounts();
-			connectionsChanged.signalAll();
-		} finally {
-			connectionsLock.unlock();
 		}
 	}
 
 	@Override
 	public void commitTransaction(Connection txn) throws DbException {
-		// If the transaction commits successfully then return the connection
-		// to the pool, otherwise close it
 		try {
 			txn.commit();
-			returnConnectionToPool(txn);
 		} catch (SQLException e) {
-			logException(LOG, WARNING, e);
-			closeConnection(txn);
 			throw new DbException(e);
 		}
-	}
-
-	private void returnConnectionToPool(Connection txn) {
-		boolean shouldClose;
 		connectionsLock.lock();
 		try {
-			shouldClose = connectionPool.size() >= MAX_CONNECTION_POOL_SIZE;
+			connections.add(txn);
-			if (shouldClose) openConnections--;
-			else connectionPool.add(txn);
-			logConnectionCounts();
 			connectionsChanged.signalAll();
 		} finally {
 			connectionsLock.unlock();
 		}
-		if (shouldClose) tryToClose(txn, LOG, WARNING);
 	}
 
-	void closeAllConnections() {
+	void closeAllConnections() throws SQLException {
 		boolean interrupted = false;
 		connectionsLock.lock();
 		try {
 			closed = true;
-			for (Connection c : connectionPool) tryToClose(c, LOG, WARNING);
+			for (Connection c : connections) c.close();
-			openConnections -= connectionPool.size();
+			openConnections -= connections.size();
-			connectionPool.clear();
+			connections.clear();
 			while (openConnections > 0) {
-				if (LOG.isLoggable(INFO)) {
-					LOG.info("Waiting for " + openConnections
-							+ " connections to be closed");
-				}
 				try {
 					connectionsChanged.await();
 				} catch (InterruptedException e) {
 					LOG.warning("Interrupted while closing connections");
 					interrupted = true;
 				}
-				for (Connection c : connectionPool) tryToClose(c, LOG, WARNING);
+				for (Connection c : connections) c.close();
-				openConnections -= connectionPool.size();
+				openConnections -= connections.size();
-				connectionPool.clear();
+				connections.clear();
 			}
-			LOG.info("All connections closed");
 		} finally {
 			connectionsLock.unlock();
 		}
@@ -1917,31 +1879,6 @@ abstract class JdbcDatabase implements Database<Connection> {
 		}
 	}
 
-	@Override
-	public int getMessageLength(Connection txn, MessageId m)
-			throws DbException {
-		PreparedStatement ps = null;
-		ResultSet rs = null;
-		try {
-			String sql = "SELECT length from messages"
-					+ " WHERE messageId = ? AND state = ?";
-			ps = txn.prepareStatement(sql);
-			ps.setBytes(1, m.getBytes());
-			ps.setInt(2, DELIVERED.getValue());
-			rs = ps.executeQuery();
-			if (!rs.next()) throw new DbStateException();
-			int length = rs.getInt(1);
-			if (rs.next()) throw new DbStateException();
-			rs.close();
-			ps.close();
-			return length;
-		} catch (SQLException e) {
-			tryToClose(rs, LOG, WARNING);
-			tryToClose(ps, LOG, WARNING);
-			throw new DbException(e);
-		}
-	}
-
 	@Override
 	public Map<MessageId, Metadata> getMessageMetadata(Connection txn,
 			GroupId g) throws DbException {
@@ -2290,8 +2227,8 @@ abstract class JdbcDatabase implements Database<Connection> {
 	}
 
 	@Override
-	public Collection<MessageId> getMessagesToSend(Connection txn,
+	public Collection<MessageId> getMessagesToSend(Connection txn, ContactId c,
-			ContactId c, long capacity, long maxLatency) throws DbException {
+			int maxLength, long maxLatency) throws DbException {
 		long now = clock.currentTimeMillis();
 		PreparedStatement ps = null;
 		ResultSet rs = null;
@@ -2311,11 +2248,12 @@ abstract class JdbcDatabase implements Database<Connection> {
 			ps.setLong(4, maxLatency);
 			rs = ps.executeQuery();
 			List<MessageId> ids = new ArrayList<>();
+			int total = 0;
 			while (rs.next()) {
 				int length = rs.getInt(1);
-				if (capacity < RECORD_HEADER_BYTES + length) break;
+				if (total + length > maxLength) break;
 				ids.add(new MessageId(rs.getBytes(2)));
-				capacity -= RECORD_HEADER_BYTES + length;
+				total += length;
 			}
 			rs.close();
 			ps.close();
@@ -2328,12 +2266,12 @@ abstract class JdbcDatabase implements Database<Connection> {
 	}
 
 	@Override
-	public Collection<MessageId> getUnackedMessagesToSend(Connection txn,
+	public Map<MessageId, Integer> getUnackedMessagesToSend(Connection txn,
 			ContactId c) throws DbException {
 		PreparedStatement ps = null;
 		ResultSet rs = null;
 		try {
-			String sql = "SELECT messageId FROM statuses"
+			String sql = "SELECT length, messageId FROM statuses"
 					+ " WHERE contactId = ? AND state = ?"
 					+ " AND groupShared = TRUE AND messageShared = TRUE"
 					+ " AND deleted = FALSE AND seen = FALSE"
@@ -2342,11 +2280,15 @@ abstract class JdbcDatabase implements Database<Connection> {
 			ps.setInt(1, c.getInt());
 			ps.setInt(2, DELIVERED.getValue());
 			rs = ps.executeQuery();
-			List<MessageId> ids = new ArrayList<>();
+			Map<MessageId, Integer> results = new LinkedHashMap<>();
-			while (rs.next()) ids.add(new MessageId(rs.getBytes(1)));
+			while (rs.next()) {
+				int length = rs.getInt(1);
+				MessageId id = new MessageId(rs.getBytes(2));
+				results.put(id, length);
+			}
 			rs.close();
 			ps.close();
-			return ids;
+			return results;
 		} catch (SQLException e) {
 			tryToClose(rs, LOG, WARNING);
 			tryToClose(ps, LOG, WARNING);
@@ -2459,7 +2401,6 @@ abstract class JdbcDatabase implements Database<Connection> {
 				MessageId m = new MessageId(rs.getBytes(1));
 				GroupId g = new GroupId(rs.getBytes(2));
 				Collection<MessageId> messageIds = ids.get(g);
-				//noinspection Java8MapApi
 				if (messageIds == null) {
 					messageIds = new ArrayList<>();
 					ids.put(g, messageIds);
@@ -2586,7 +2527,7 @@ abstract class JdbcDatabase implements Database<Connection> {
 
 	@Override
 	public Collection<MessageId> getRequestedMessagesToSend(Connection txn,
-			ContactId c, long capacity, long maxLatency) throws DbException {
+			ContactId c, int maxLength, long maxLatency) throws DbException {
 		long now = clock.currentTimeMillis();
 		PreparedStatement ps = null;
 		ResultSet rs = null;
@@ -2606,11 +2547,12 @@ abstract class JdbcDatabase implements Database<Connection> {
 			ps.setLong(4, maxLatency);
 			rs = ps.executeQuery();
 			List<MessageId> ids = new ArrayList<>();
+			int total = 0;
 			while (rs.next()) {
 				int length = rs.getInt(1);
-				if (capacity < RECORD_HEADER_BYTES + length) break;
+				if (total + length > maxLength) break;
 				ids.add(new MessageId(rs.getBytes(2)));
-				capacity -= RECORD_HEADER_BYTES + length;
+				total += length;
 			}
 			rs.close();
 			ps.close();
@@ -2764,7 +2706,6 @@ abstract class JdbcDatabase implements Database<Connection> {
 				ContactId c = new ContactId(rs.getInt(1));
 				TransportId t = new TransportId(rs.getString(2));
 				Collection<TransportId> transportIds = ids.get(c);
-				//noinspection Java8MapApi
 				if (transportIds == null) {
 					transportIds = new ArrayList<>();
 					ids.put(c, transportIds);

bramble-core/src/main/java/org/briarproject/bramble/io/TimeoutMonitorImpl.java

@@ -1,10 +1,10 @@
 package org.briarproject.bramble.io;
 
-import org.briarproject.bramble.api.Cancellable;
 import org.briarproject.bramble.api.io.TimeoutMonitor;
 import org.briarproject.bramble.api.lifecycle.IoExecutor;
 import org.briarproject.bramble.api.system.Clock;
 import org.briarproject.bramble.api.system.TaskScheduler;
+import org.briarproject.bramble.api.system.TaskScheduler.Cancellable;
 import org.briarproject.bramble.api.system.Wakeful;
 
 import java.io.IOException;

bramble-core/src/main/java/org/briarproject/bramble/mailbox/ApiCall.java

@@ -1,21 +0,0 @@
-package org.briarproject.bramble.mailbox;
-
-import org.briarproject.bramble.api.lifecycle.IoExecutor;
-import org.briarproject.bramble.mailbox.MailboxApi.TolerableFailureException;
-
-/**
- * An interface for calling an API endpoint with the option to retry the call.
- */
-interface ApiCall {
-
-	/**
-	 * This method makes a synchronous call to an API endpoint and returns
-	 * true if the call should be retried, in which case the method may be
-	 * called again on the same {@link ApiCall} instance after a delay.
-	 *
-	 * @return True if the API call needs to be retried, or false if the API
-	 * call succeeded or {@link TolerableFailureException failed tolerably}.
-	 */
-	@IoExecutor
-	boolean callApi();
-}

bramble-core/src/main/java/org/briarproject/bramble/mailbox/ConnectivityChecker.java

@@ -1,32 +0,0 @@
-package org.briarproject.bramble.mailbox;
-
-import org.briarproject.bramble.api.mailbox.MailboxProperties;
-import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
-
-import javax.annotation.concurrent.ThreadSafe;
-
-/**
- * An interface for checking whether a mailbox is reachable.
- */
-@ThreadSafe
-@NotNullByDefault
-interface ConnectivityChecker {
-
-	/**
-	 * Destroys the checker. Any current connectivity check is cancelled.
-	 */
-	void destroy();
-
-	/**
-	 * Starts a connectivity check if needed and calls the given observer when
-	 * the check succeeds. If a check is already running then the observer is
-	 * called when the check succeeds. If a connectivity check has recently
-	 * succeeded then the observer is called immediately.
-	 */
-	void checkConnectivity(MailboxProperties properties,
-			ConnectivityObserver o);
-
-	interface ConnectivityObserver {
-		void onConnectivityCheckSucceeded();
-	}
-}

bramble-core/src/main/java/org/briarproject/bramble/mailbox/ConnectivityCheckerImpl.java

@@ -1,111 +0,0 @@
-package org.briarproject.bramble.mailbox;
-
-import org.briarproject.bramble.api.Cancellable;
-import org.briarproject.bramble.api.mailbox.MailboxProperties;
-import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
-import org.briarproject.bramble.api.system.Clock;
-
-import java.util.ArrayList;
-import java.util.List;
-
-import javax.annotation.Nullable;
-import javax.annotation.concurrent.GuardedBy;
-import javax.annotation.concurrent.ThreadSafe;
-
-@ThreadSafe
-@NotNullByDefault
-abstract class ConnectivityCheckerImpl implements ConnectivityChecker {
-
-	/**
-	 * If no more than this much time has elapsed since the last connectivity
-	 * check succeeded, consider the result to be fresh and don't check again.
-	 * <p>
-	 * Package access for testing.
-	 */
-	static final long CONNECTIVITY_CHECK_FRESHNESS_MS = 10_000;
-
-	private final Object lock = new Object();
-
-	protected final Clock clock;
-	private final MailboxApiCaller mailboxApiCaller;
-
-	@GuardedBy("lock")
-	private boolean destroyed = false;
-
-	@GuardedBy("lock")
-	@Nullable
-	private Cancellable connectivityCheck = null;
-
-	@GuardedBy("lock")
-	private long lastConnectivityCheckSucceeded = 0;
-
-	@GuardedBy("lock")
-	private final List<ConnectivityObserver> connectivityObservers =
-			new ArrayList<>();
-
-	/**
-	 * Creates an {@link ApiCall} for checking whether the mailbox is
-	 * reachable. The {@link ApiCall} should call
-	 * {@link #onConnectivityCheckSucceeded(long)} if the check succeeds.
-	 */
-	abstract ApiCall createConnectivityCheckTask(MailboxProperties properties);
-
-	ConnectivityCheckerImpl(Clock clock, MailboxApiCaller mailboxApiCaller) {
-		this.clock = clock;
-		this.mailboxApiCaller = mailboxApiCaller;
-	}
-
-	@Override
-	public void destroy() {
-		synchronized (lock) {
-			destroyed = true;
-			connectivityObservers.clear();
-			if (connectivityCheck != null) {
-				connectivityCheck.cancel();
-				connectivityCheck = null;
-			}
-		}
-	}
-
-	@Override
-	public void checkConnectivity(MailboxProperties properties,
-			ConnectivityObserver o) {
-		boolean callNow = false;
-		synchronized (lock) {
-			if (destroyed) return;
-			if (connectivityCheck == null) {
-				// No connectivity check is running
-				long now = clock.currentTimeMillis();
-				if (now - lastConnectivityCheckSucceeded
-						> CONNECTIVITY_CHECK_FRESHNESS_MS) {
-					// The last connectivity check is stale, start a new one
-					connectivityObservers.add(o);
-					ApiCall task =
-							createConnectivityCheckTask(properties);
-					connectivityCheck = mailboxApiCaller.retryWithBackoff(task);
-				} else {
-					// The last connectivity check is fresh
-					callNow = true;
-				}
-			} else {
-				// A connectivity check is running, wait for it to succeed
-				connectivityObservers.add(o);
-			}
-		}
-		if (callNow) o.onConnectivityCheckSucceeded();
-	}
-
-	protected void onConnectivityCheckSucceeded(long now) {
-		List<ConnectivityObserver> observers;
-		synchronized (lock) {
-			if (destroyed) return;
-			connectivityCheck = null;
-			lastConnectivityCheckSucceeded = now;
-			observers = new ArrayList<>(connectivityObservers);
-			connectivityObservers.clear();
-		}
-		for (ConnectivityObserver o : observers) {
-			o.onConnectivityCheckSucceeded();
-		}
-	}
-}

bramble-core/src/main/java/org/briarproject/bramble/mailbox/ContactMailboxConnectivityChecker.java

@@ -1,39 +0,0 @@
-package org.briarproject.bramble.mailbox;
-
-import org.briarproject.bramble.api.mailbox.MailboxProperties;
-import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
-import org.briarproject.bramble.api.system.Clock;
-import org.briarproject.bramble.mailbox.MailboxApi.ApiException;
-
-import java.io.IOException;
-
-import javax.annotation.concurrent.ThreadSafe;
-
-@ThreadSafe
-@NotNullByDefault
-class ContactMailboxConnectivityChecker extends ConnectivityCheckerImpl {
-
-	private final MailboxApi mailboxApi;
-
-	ContactMailboxConnectivityChecker(Clock clock,
-			MailboxApiCaller mailboxApiCaller, MailboxApi mailboxApi) {
-		super(clock, mailboxApiCaller);
-		this.mailboxApi = mailboxApi;
-	}
-
-	@Override
-	ApiCall createConnectivityCheckTask(MailboxProperties properties) {
-		if (properties.isOwner()) throw new IllegalArgumentException();
-		return new SimpleApiCall() {
-			@Override
-			void tryToCallApi() throws IOException, ApiException {
-				if (!mailboxApi.checkStatus(properties)) {
-					throw new ApiException();
-				}
-				// Call the observers and cache the result
-				onConnectivityCheckSucceeded(clock.currentTimeMillis());
-			}
-		};
-	}
-
-}

bramble-core/src/main/java/org/briarproject/bramble/mailbox/MailboxApi.java

@@ -7,9 +7,6 @@ import org.briarproject.bramble.api.mailbox.MailboxAuthToken;
 import org.briarproject.bramble.api.mailbox.MailboxFileId;
 import org.briarproject.bramble.api.mailbox.MailboxFolderId;
 import org.briarproject.bramble.api.mailbox.MailboxProperties;
-import org.briarproject.bramble.api.mailbox.MailboxUpdateManager;
-import org.briarproject.bramble.api.mailbox.MailboxVersion;
-import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 
 import java.io.File;
 import java.io.IOException;
@@ -19,21 +16,8 @@ import java.util.List;
 import javax.annotation.Nonnull;
 import javax.annotation.concurrent.Immutable;
 
-import static java.util.Collections.singletonList;
-
-@NotNullByDefault
 interface MailboxApi {
 
-	/**
-	 * Mailbox API versions that we support as a client. This is reported to our
-	 * contacts by {@link MailboxUpdateManager}.
-	 */
-	List<MailboxVersion> CLIENT_SUPPORTS = singletonList(
-			new MailboxVersion(1, 0));
-
-	List<MailboxVersion> getServerSupports(MailboxProperties properties)
-			throws IOException, ApiException;
-
 	/**
 	 * Sets up the mailbox with the setup token.
 	 *

bramble-core/src/main/java/org/briarproject/bramble/mailbox/MailboxApiCaller.java

@@ -1,32 +0,0 @@
-package org.briarproject.bramble.mailbox;
-
-import org.briarproject.bramble.api.Cancellable;
-import org.briarproject.bramble.api.lifecycle.IoExecutor;
-import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
-
-import static java.util.concurrent.TimeUnit.DAYS;
-import static java.util.concurrent.TimeUnit.MINUTES;
-
-@NotNullByDefault
-interface MailboxApiCaller {
-
-	/**
-	 * The minimum interval between retries in milliseconds.
-	 */
-	long MIN_RETRY_INTERVAL_MS = MINUTES.toMillis(1);
-
-	/**
-	 * The maximum interval between retries in milliseconds.
-	 */
-	long MAX_RETRY_INTERVAL_MS = DAYS.toMillis(1);
-
-	/**
-	 * Asynchronously calls the given API call on the {@link IoExecutor},
-	 * automatically retrying at increasing intervals until the API call
-	 * returns false or retries are cancelled.
-	 *
-	 * @return A {@link Cancellable} that can be used to cancel any future
-	 * retries.
-	 */
-	Cancellable retryWithBackoff(ApiCall apiCall);
-}

bramble-core/src/main/java/org/briarproject/bramble/mailbox/MailboxApiCallerImpl.java

@@ -1,98 +0,0 @@
-package org.briarproject.bramble.mailbox;
-
-import org.briarproject.bramble.api.Cancellable;
-import org.briarproject.bramble.api.lifecycle.IoExecutor;
-import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
-import org.briarproject.bramble.api.system.TaskScheduler;
-
-import java.util.concurrent.Executor;
-
-import javax.annotation.Nullable;
-import javax.annotation.concurrent.GuardedBy;
-import javax.annotation.concurrent.Immutable;
-import javax.inject.Inject;
-
-import static java.lang.Math.min;
-import static java.util.concurrent.TimeUnit.MILLISECONDS;
-
-@Immutable
-@NotNullByDefault
-class MailboxApiCallerImpl implements MailboxApiCaller {
-
-	private final TaskScheduler taskScheduler;
-	private final Executor ioExecutor;
-
-	@Inject
-	MailboxApiCallerImpl(TaskScheduler taskScheduler,
-			@IoExecutor Executor ioExecutor) {
-		this.taskScheduler = taskScheduler;
-		this.ioExecutor = ioExecutor;
-	}
-
-	@Override
-	public Cancellable retryWithBackoff(ApiCall apiCall) {
-		Task task = new Task(apiCall);
-		task.start();
-		return task;
-	}
-
-	private class Task implements Cancellable {
-
-		private final ApiCall apiCall;
-		private final Object lock = new Object();
-
-		@GuardedBy("lock")
-		@Nullable
-		private Cancellable scheduledTask = null;
-
-		@GuardedBy("lock")
-		private boolean cancelled = false;
-
-		@GuardedBy("lock")
-		private long retryIntervalMs = MIN_RETRY_INTERVAL_MS;
-
-		private Task(ApiCall apiCall) {
-			this.apiCall = apiCall;
-		}
-
-		private void start() {
-			synchronized (lock) {
-				if (cancelled) throw new AssertionError();
-				ioExecutor.execute(this::callApi);
-			}
-		}
-
-		@IoExecutor
-		private void callApi() {
-			synchronized (lock) {
-				if (cancelled) return;
-			}
-			// The call returns true if we should retry
-			if (apiCall.callApi()) {
-				synchronized (lock) {
-					if (cancelled) return;
-					scheduledTask = taskScheduler.schedule(this::callApi,
-							ioExecutor, retryIntervalMs, MILLISECONDS);
-					// Increase the retry interval each time we retry
-					retryIntervalMs =
-							min(MAX_RETRY_INTERVAL_MS, retryIntervalMs * 2);
-				}
-			} else {
-				synchronized (lock) {
-					scheduledTask = null;
-				}
-			}
-		}
-
-		@Override
-		public void cancel() {
-			Cancellable scheduledTask;
-			synchronized (lock) {
-				cancelled = true;
-				scheduledTask = this.scheduledTask;
-				this.scheduledTask = null;
-			}
-			if (scheduledTask != null) scheduledTask.cancel();
-		}
-	}
-}

bramble-core/src/main/java/org/briarproject/bramble/mailbox/MailboxApiImpl.java

@@ -56,23 +56,6 @@ class MailboxApiImpl implements MailboxApi {
 		this.httpClientProvider = httpClientProvider;
 	}
 
-	@Override
-	public List<MailboxVersion> getServerSupports(MailboxProperties properties)
-			throws IOException, ApiException {
-		if (!properties.isOwner()) throw new IllegalArgumentException();
-		Response response = sendGetRequest(properties, "/versions");
-		if (response.code() != 200) throw new ApiException();
-
-		ResponseBody body = response.body();
-		if (body == null) throw new ApiException();
-		try {
-			JsonNode node = mapper.readTree(body.string());
-			return parseServerSupports(node);
-		} catch (JacksonException e) {
-			throw new ApiException();
-		}
-	}
-
 	@Override
 	public MailboxProperties setup(MailboxProperties properties)
 			throws IOException, ApiException {
@@ -93,40 +76,36 @@ class MailboxApiImpl implements MailboxApi {
 			if (tokenNode == null) {
 				throw new ApiException();
 			}
+			List<MailboxVersion> serverSupports = new ArrayList<>();
+			ArrayNode serverSupportsNode = getArray(node, "serverSupports");
+			for (JsonNode versionNode : serverSupportsNode) {
+				if (!versionNode.isObject()) throw new ApiException();
+				ObjectNode objectNode = (ObjectNode) versionNode;
+				JsonNode majorNode = objectNode.get("major");
+				JsonNode minorNode = objectNode.get("minor");
+				if (majorNode == null || !majorNode.isNumber()) {
+					throw new ApiException();
+				}
+				if (minorNode == null || !minorNode.isNumber()) {
+					throw new ApiException();
+				}
+				int major = majorNode.asInt();
+				int minor = minorNode.asInt();
+				if (major < 0 || minor < 0) throw new ApiException();
+				serverSupports.add(new MailboxVersion(major, minor));
+			}
 			return new MailboxProperties(properties.getBaseUrl(),
 					MailboxAuthToken.fromString(tokenNode.textValue()),
-					parseServerSupports(node));
+					true, serverSupports);
 		} catch (JacksonException | InvalidMailboxIdException e) {
 			throw new ApiException();
 		}
 	}
 
-	private List<MailboxVersion> parseServerSupports(JsonNode node)
-			throws ApiException {
-		List<MailboxVersion> serverSupports = new ArrayList<>();
-		ArrayNode serverSupportsNode = getArray(node, "serverSupports");
-		for (JsonNode versionNode : serverSupportsNode) {
-			if (!versionNode.isObject()) throw new ApiException();
-			ObjectNode objectNode = (ObjectNode) versionNode;
-			JsonNode majorNode = objectNode.get("major");
-			JsonNode minorNode = objectNode.get("minor");
-			if (majorNode == null || !majorNode.isNumber()) {
-				throw new ApiException();
-			}
-			if (minorNode == null || !minorNode.isNumber()) {
-				throw new ApiException();
-			}
-			int major = majorNode.asInt();
-			int minor = minorNode.asInt();
-			if (major < 0 || minor < 0) throw new ApiException();
-			serverSupports.add(new MailboxVersion(major, minor));
-		}
-		return serverSupports;
-	}
-
 	@Override
 	public boolean checkStatus(MailboxProperties properties)
 			throws IOException, ApiException {
+		if (!properties.isOwner()) throw new IllegalArgumentException();
 		Response response = sendGetRequest(properties, "/status");
 		if (response.code() == 401) throw new ApiException();
 		return response.isSuccessful();

bramble-core/src/main/java/org/briarproject/bramble/mailbox/MailboxManagerImpl.java

@@ -102,55 +102,23 @@ class MailboxManagerImpl implements MailboxManager {
 		try {
 			MailboxProperties props = db.transactionWithNullableResult(true,
 					mailboxSettingsManager::getOwnMailboxProperties);
-			if (props == null) throw new DbException();
 			success = api.checkStatus(props);
-		} catch (DbException e) {
+		} catch (DbException | IOException | MailboxApi.ApiException e) {
-			logException(LOG, WARNING, e);
-			// we don't treat this is a failure to record
-			return false;
-		} catch (IOException | MailboxApi.ApiException e) {
-			// we record this as a failure
 			success = false;
 			logException(LOG, WARNING, e);
 		}
-		try {
+		if (success) {
-			recordCheckResult(success);
+			try {
-		} catch (DbException e) {
+				// we are only recording successful connections here
-			logException(LOG, WARNING, e);
+				// as those update the UI and failures might be false negatives
+				db.transaction(false, txn ->
+						mailboxSettingsManager.recordSuccessfulConnection(txn,
+								clock.currentTimeMillis()));
+			} catch (DbException e) {
+				logException(LOG, WARNING, e);
+			}
 		}
 		return success;
 	}
 
-	private void recordCheckResult(boolean success) throws DbException {
-		long now = clock.currentTimeMillis();
-		db.transaction(false, txn -> {
-			if (success) {
-				mailboxSettingsManager.recordSuccessfulConnection(txn, now);
-			} else {
-				mailboxSettingsManager.recordFailedConnectionAttempt(txn, now);
-			}
-		});
-	}
-
-	@Override
-	public boolean unPair() throws DbException {
-		MailboxProperties properties = db.transactionWithNullableResult(true,
-				mailboxSettingsManager::getOwnMailboxProperties);
-		if (properties == null) {
-			// no more mailbox, that's strange but possible if called in quick
-			// succession, so let's return true this time
-			return true;
-		}
-		boolean wasWiped;
-		try {
-			api.wipeMailbox(properties);
-			wasWiped = true;
-		} catch (IOException | MailboxApi.ApiException e) {
-			logException(LOG, WARNING, e);
-			wasWiped = false;
-		}
-		db.transaction(false,
-				mailboxSettingsManager::removeOwnMailboxProperties);
-		return wasWiped;
-	}
 }

bramble-core/src/main/java/org/briarproject/bramble/mailbox/MailboxModule.java

@@ -1,39 +1,34 @@
 package org.briarproject.bramble.mailbox;
 
-import org.briarproject.bramble.api.FeatureFlags;
 import org.briarproject.bramble.api.client.ClientHelper;
 import org.briarproject.bramble.api.contact.ContactManager;
 import org.briarproject.bramble.api.data.MetadataEncoder;
 import org.briarproject.bramble.api.lifecycle.LifecycleManager;
 import org.briarproject.bramble.api.mailbox.MailboxManager;
+import org.briarproject.bramble.api.mailbox.MailboxPropertyManager;
 import org.briarproject.bramble.api.mailbox.MailboxSettingsManager;
-import org.briarproject.bramble.api.mailbox.MailboxUpdateManager;
-import org.briarproject.bramble.api.mailbox.MailboxVersion;
 import org.briarproject.bramble.api.sync.validation.ValidationManager;
 import org.briarproject.bramble.api.system.Clock;
 import org.briarproject.bramble.api.versioning.ClientVersioningManager;
 
-import java.util.List;
-
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
 import dagger.Module;
 import dagger.Provides;
 
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.CLIENT_ID;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.CLIENT_ID;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.MAJOR_VERSION;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.MAJOR_VERSION;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.MINOR_VERSION;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.MINOR_VERSION;
-import static org.briarproject.bramble.mailbox.MailboxApi.CLIENT_SUPPORTS;
 
 @Module
 public class MailboxModule {
 
 	public static class EagerSingletons {
 		@Inject
-		MailboxUpdateValidator mailboxUpdateValidator;
+		MailboxPropertyValidator mailboxPropertyValidator;
 		@Inject
-		MailboxUpdateManager mailboxUpdateManager;
+		MailboxPropertyManager mailboxPropertyManager;
 	}
 
 	@Provides
@@ -61,44 +56,31 @@ public class MailboxModule {
 
 	@Provides
 	@Singleton
-	MailboxUpdateValidator provideMailboxUpdateValidator(
+	MailboxPropertyValidator provideMailboxPropertyValidator(
-			ValidationManager validationManager,
+			ValidationManager validationManager, ClientHelper clientHelper,
-			ClientHelper clientHelper,
+			MetadataEncoder metadataEncoder, Clock clock) {
-			MetadataEncoder metadataEncoder,
+		MailboxPropertyValidator validator = new MailboxPropertyValidator(
-			Clock clock,
-			FeatureFlags featureFlags) {
-		MailboxUpdateValidator validator = new MailboxUpdateValidator(
 				clientHelper, metadataEncoder, clock);
-		if (featureFlags.shouldEnableMailbox()) {
+		validationManager.registerMessageValidator(CLIENT_ID, MAJOR_VERSION,
-			validationManager.registerMessageValidator(CLIENT_ID,
+				validator);
-					MAJOR_VERSION, validator);
-		}
 		return validator;
 	}
 
-	@Provides
-	List<MailboxVersion> provideClientSupports() {
-		return CLIENT_SUPPORTS;
-	}
-
 	@Provides
 	@Singleton
-	MailboxUpdateManager provideMailboxUpdateManager(
+	MailboxPropertyManager provideMailboxPropertyManager(
-			FeatureFlags featureFlags,
 			LifecycleManager lifecycleManager,
 			ValidationManager validationManager, ContactManager contactManager,
 			ClientVersioningManager clientVersioningManager,
 			MailboxSettingsManager mailboxSettingsManager,
-			MailboxUpdateManagerImpl mailboxUpdateManager) {
+			MailboxPropertyManagerImpl mailboxPropertyManager) {
-		if (featureFlags.shouldEnableMailbox()) {
+		lifecycleManager.registerOpenDatabaseHook(mailboxPropertyManager);
-			lifecycleManager.registerOpenDatabaseHook(mailboxUpdateManager);
+		validationManager.registerIncomingMessageHook(CLIENT_ID, MAJOR_VERSION,
-			validationManager.registerIncomingMessageHook(CLIENT_ID,
+				mailboxPropertyManager);
-					MAJOR_VERSION, mailboxUpdateManager);
+		contactManager.registerContactHook(mailboxPropertyManager);
-			contactManager.registerContactHook(mailboxUpdateManager);
+		clientVersioningManager.registerClient(CLIENT_ID, MAJOR_VERSION,
-			clientVersioningManager.registerClient(CLIENT_ID, MAJOR_VERSION,
+				MINOR_VERSION, mailboxPropertyManager);
-					MINOR_VERSION, mailboxUpdateManager);
+		mailboxSettingsManager.registerMailboxHook(mailboxPropertyManager);
-			mailboxSettingsManager.registerMailboxHook(mailboxUpdateManager);
+		return mailboxPropertyManager;
-		}
-		return mailboxUpdateManager;
 	}
 }

bramble-core/src/main/java/org/briarproject/bramble/mailbox/MailboxPairingTaskFactoryImpl.java

@@ -4,8 +4,8 @@ import org.briarproject.bramble.api.crypto.CryptoComponent;
 import org.briarproject.bramble.api.db.DatabaseComponent;
 import org.briarproject.bramble.api.event.EventExecutor;
 import org.briarproject.bramble.api.mailbox.MailboxPairingTask;
+import org.briarproject.bramble.api.mailbox.MailboxPropertyManager;
 import org.briarproject.bramble.api.mailbox.MailboxSettingsManager;
-import org.briarproject.bramble.api.mailbox.MailboxUpdateManager;
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.bramble.api.system.Clock;
 
@@ -24,7 +24,7 @@ class MailboxPairingTaskFactoryImpl implements MailboxPairingTaskFactory {
 	private final Clock clock;
 	private final MailboxApi api;
 	private final MailboxSettingsManager mailboxSettingsManager;
-	private final MailboxUpdateManager mailboxUpdateManager;
+	private final MailboxPropertyManager mailboxPropertyManager;
 
 	@Inject
 	MailboxPairingTaskFactoryImpl(
@@ -34,20 +34,20 @@ class MailboxPairingTaskFactoryImpl implements MailboxPairingTaskFactory {
 			Clock clock,
 			MailboxApi api,
 			MailboxSettingsManager mailboxSettingsManager,
-			MailboxUpdateManager mailboxUpdateManager) {
+			MailboxPropertyManager mailboxPropertyManager) {
 		this.eventExecutor = eventExecutor;
 		this.db = db;
 		this.crypto = crypto;
 		this.clock = clock;
 		this.api = api;
 		this.mailboxSettingsManager = mailboxSettingsManager;
-		this.mailboxUpdateManager = mailboxUpdateManager;
+		this.mailboxPropertyManager = mailboxPropertyManager;
 	}
 
 	@Override
 	public MailboxPairingTask createPairingTask(String qrCodePayload) {
 		return new MailboxPairingTaskImpl(qrCodePayload, eventExecutor, db,
 				crypto, clock, api, mailboxSettingsManager,
-				mailboxUpdateManager);
+				mailboxPropertyManager);
 	}
 }

bramble-core/src/main/java/org/briarproject/bramble/mailbox/MailboxPairingTaskImpl.java

@@ -11,9 +11,9 @@ import org.briarproject.bramble.api.mailbox.MailboxAuthToken;
 import org.briarproject.bramble.api.mailbox.MailboxPairingState;
 import org.briarproject.bramble.api.mailbox.MailboxPairingTask;
 import org.briarproject.bramble.api.mailbox.MailboxProperties;
+import org.briarproject.bramble.api.mailbox.MailboxPropertiesUpdate;
+import org.briarproject.bramble.api.mailbox.MailboxPropertyManager;
 import org.briarproject.bramble.api.mailbox.MailboxSettingsManager;
-import org.briarproject.bramble.api.mailbox.MailboxUpdate;
-import org.briarproject.bramble.api.mailbox.MailboxUpdateManager;
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.bramble.api.system.Clock;
 import org.briarproject.bramble.mailbox.MailboxApi.ApiException;
@@ -51,7 +51,7 @@ class MailboxPairingTaskImpl implements MailboxPairingTask {
 	private final Clock clock;
 	private final MailboxApi api;
 	private final MailboxSettingsManager mailboxSettingsManager;
-	private final MailboxUpdateManager mailboxUpdateManager;
+	private final MailboxPropertyManager mailboxPropertyManager;
 
 	private final Object lock = new Object();
 	@GuardedBy("lock")
@@ -68,7 +68,7 @@ class MailboxPairingTaskImpl implements MailboxPairingTask {
 			Clock clock,
 			MailboxApi api,
 			MailboxSettingsManager mailboxSettingsManager,
-			MailboxUpdateManager mailboxUpdateManager) {
+			MailboxPropertyManager mailboxPropertyManager) {
 		this.payload = payload;
 		this.eventExecutor = eventExecutor;
 		this.db = db;
@@ -76,7 +76,7 @@ class MailboxPairingTaskImpl implements MailboxPairingTask {
 		this.clock = clock;
 		this.api = api;
 		this.mailboxSettingsManager = mailboxSettingsManager;
-		this.mailboxUpdateManager = mailboxUpdateManager;
+		this.mailboxPropertyManager = mailboxPropertyManager;
 		state = new MailboxPairingState.QrCodeReceived();
 	}
 
@@ -125,9 +125,9 @@ class MailboxPairingTaskImpl implements MailboxPairingTask {
 			// timers for contacts who doesn't have their own mailbox. This way,
 			// data stranded on our old mailbox will be re-uploaded to our new.
 			for (Contact c : db.getContacts(txn)) {
-				MailboxUpdate update = mailboxUpdateManager.getRemoteUpdate(
+				MailboxPropertiesUpdate remoteProps = mailboxPropertyManager
-						txn, c.getId());
+						.getRemoteProperties(txn, c.getId());
-				if (update == null || !update.hasMailbox()) {
+				if (remoteProps == null) {
 					db.resetUnackedMessagesToSend(txn, c.getId());
 				}
 			}
@@ -177,10 +177,11 @@ class MailboxPairingTaskImpl implements MailboxPairingTask {
 		LOG.info("QR code is valid");
 		byte[] onionPubKey = Arrays.copyOfRange(bytes, 1, 33);
 		String onion = crypto.encodeOnion(onionPubKey);
-		String baseUrl = "http://" + onion + ".onion"; // TODO
+		String baseUrl = "http://" + onion + ".onion";
 		byte[] tokenBytes = Arrays.copyOfRange(bytes, 33, 65);
 		MailboxAuthToken setupToken = new MailboxAuthToken(tokenBytes);
-		return new MailboxProperties(baseUrl, setupToken, new ArrayList<>());
+		return new MailboxProperties(baseUrl, setupToken, true,
+				new ArrayList<>());
 	}
 
 }

bramble-core/src/main/java/org/briarproject/bramble/mailbox/MailboxPropertyManagerImpl.java

@@ -8,7 +8,6 @@ import org.briarproject.bramble.api.contact.ContactId;
 import org.briarproject.bramble.api.contact.ContactManager.ContactHook;
 import org.briarproject.bramble.api.crypto.CryptoComponent;
 import org.briarproject.bramble.api.data.BdfDictionary;
-import org.briarproject.bramble.api.data.BdfEntry;
 import org.briarproject.bramble.api.data.BdfList;
 import org.briarproject.bramble.api.data.MetadataParser;
 import org.briarproject.bramble.api.db.DatabaseComponent;
@@ -19,13 +18,11 @@ import org.briarproject.bramble.api.lifecycle.LifecycleManager.OpenDatabaseHook;
 import org.briarproject.bramble.api.mailbox.MailboxAuthToken;
 import org.briarproject.bramble.api.mailbox.MailboxFolderId;
 import org.briarproject.bramble.api.mailbox.MailboxProperties;
+import org.briarproject.bramble.api.mailbox.MailboxPropertiesUpdate;
+import org.briarproject.bramble.api.mailbox.MailboxPropertyManager;
 import org.briarproject.bramble.api.mailbox.MailboxSettingsManager;
 import org.briarproject.bramble.api.mailbox.MailboxSettingsManager.MailboxHook;
-import org.briarproject.bramble.api.mailbox.MailboxUpdate;
+import org.briarproject.bramble.api.mailbox.RemoteMailboxPropertiesUpdateEvent;
-import org.briarproject.bramble.api.mailbox.MailboxUpdateManager;
-import org.briarproject.bramble.api.mailbox.MailboxUpdateWithMailbox;
-import org.briarproject.bramble.api.mailbox.MailboxVersion;
-import org.briarproject.bramble.api.mailbox.event.RemoteMailboxUpdateEvent;
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.bramble.api.sync.Group;
 import org.briarproject.bramble.api.sync.Group.Visibility;
@@ -38,7 +35,6 @@ import org.briarproject.bramble.api.system.Clock;
 import org.briarproject.bramble.api.versioning.ClientVersioningManager;
 import org.briarproject.bramble.api.versioning.ClientVersioningManager.ClientVersioningHook;
 
-import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
 
@@ -48,11 +44,10 @@ import javax.inject.Inject;
 import static org.briarproject.bramble.api.sync.validation.IncomingMessageHook.DeliveryAction.ACCEPT_DO_NOT_SHARE;
 
 @NotNullByDefault
-class MailboxUpdateManagerImpl implements MailboxUpdateManager,
+class MailboxPropertyManagerImpl implements MailboxPropertyManager,
 		OpenDatabaseHook, ContactHook, ClientVersioningHook,
 		IncomingMessageHook, MailboxHook {
 
-	private final List<MailboxVersion> clientSupports;
 	private final DatabaseComponent db;
 	private final ClientHelper clientHelper;
 	private final ClientVersioningManager clientVersioningManager;
@@ -64,14 +59,12 @@ class MailboxUpdateManagerImpl implements MailboxUpdateManager,
 	private final Group localGroup;
 
 	@Inject
-	MailboxUpdateManagerImpl(List<MailboxVersion> clientSupports,
+	MailboxPropertyManagerImpl(DatabaseComponent db, ClientHelper clientHelper,
-			DatabaseComponent db, ClientHelper clientHelper,
 			ClientVersioningManager clientVersioningManager,
 			MetadataParser metadataParser,
 			ContactGroupFactory contactGroupFactory, Clock clock,
 			MailboxSettingsManager mailboxSettingsManager,
 			CryptoComponent crypto) {
-		this.clientSupports = clientSupports;
 		this.db = db;
 		this.clientHelper = clientHelper;
 		this.clientVersioningManager = clientVersioningManager;
@@ -87,46 +80,12 @@ class MailboxUpdateManagerImpl implements MailboxUpdateManager,
 	@Override
 	public void onDatabaseOpened(Transaction txn) throws DbException {
 		if (db.containsGroup(txn, localGroup.getId())) {
-			try {
+			return;
-				BdfDictionary meta = clientHelper.getGroupMetadataAsDictionary(
-						txn, localGroup.getId());
-				BdfList sent = meta.getList(GROUP_KEY_SENT_CLIENT_SUPPORTS);
-				if (clientHelper.parseMailboxVersionList(sent)
-						.equals(clientSupports)) {
-					return;
-				}
-			} catch (FormatException e) {
-				throw new DbException();
-			}
-			// Our current clientSupports list has changed compared to what we
-			// last sent out.
-			for (Contact c : db.getContacts(txn)) {
-				MailboxUpdate latest = getLocalUpdate(txn, c.getId());
-				MailboxUpdate updated;
-				if (latest.hasMailbox()) {
-					updated = new MailboxUpdateWithMailbox(
-							(MailboxUpdateWithMailbox) latest, clientSupports);
-				} else {
-					updated = new MailboxUpdate(clientSupports);
-				}
-				Group g = getContactGroup(c);
-				storeMessageReplaceLatest(txn, g.getId(), updated);
-			}
-		} else {
-			db.addGroup(txn, localGroup);
-			// Set things up for any pre-existing contacts
-			for (Contact c : db.getContacts(txn)) {
-				addingContact(txn, c);
-			}
 		}
-
+		db.addGroup(txn, localGroup);
-		try {
+		// Set things up for any pre-existing contacts
-			BdfDictionary meta = BdfDictionary.of(new BdfEntry(
+		for (Contact c : db.getContacts(txn)) {
-					GROUP_KEY_SENT_CLIENT_SUPPORTS,
+			addingContact(txn, c);
-					encodeSupportsList(clientSupports)));
-			clientHelper.mergeGroupMetadata(txn, localGroup.getId(), meta);
-		} catch (FormatException e) {
-			throw new DbException();
 		}
 	}
 
@@ -141,15 +100,11 @@ class MailboxUpdateManagerImpl implements MailboxUpdateManager,
 		db.setGroupVisibility(txn, c.getId(), g.getId(), client);
 		// Attach the contact ID to the group
 		clientHelper.setContactId(txn, g.getId(), c.getId());
+		// If we are paired, create and send props to the newly added contact
 		MailboxProperties ownProps =
 				mailboxSettingsManager.getOwnMailboxProperties(txn);
 		if (ownProps != null) {
-			// We are paired, create and send props to the newly added contact
+			createAndSendProperties(txn, c, ownProps.getOnion());
-			createAndSendUpdateWithMailbox(txn, c, ownProps.getServerSupports(),
-					ownProps.getOnion());
-		} else {
-			// Not paired, but we still want to get our clientSupports sent
-			sendUpdateNoMailbox(txn, c);
 		}
 	}
 
@@ -159,17 +114,17 @@ class MailboxUpdateManagerImpl implements MailboxUpdateManager,
 	}
 
 	@Override
-	public void mailboxPaired(Transaction txn, String ownOnion,
+	public void mailboxPaired(Transaction txn, String ownOnion)
-			List<MailboxVersion> serverSupports) throws DbException {
+			throws DbException {
 		for (Contact c : db.getContacts(txn)) {
-			createAndSendUpdateWithMailbox(txn, c, serverSupports, ownOnion);
+			createAndSendProperties(txn, c, ownOnion);
 		}
 	}
 
 	@Override
 	public void mailboxUnpaired(Transaction txn) throws DbException {
 		for (Contact c : db.getContacts(txn)) {
-			sendUpdateNoMailbox(txn, c);
+			sendEmptyProperties(txn, c);
 		}
 	}
 
@@ -201,8 +156,8 @@ class MailboxUpdateManagerImpl implements MailboxUpdateManager,
 			}
 			ContactId c = clientHelper.getContactId(txn, m.getGroupId());
 			BdfList body = clientHelper.getMessageAsList(txn, m.getId());
-			MailboxUpdate u = parseUpdate(body);
+			MailboxPropertiesUpdate p = parseProperties(body);
-			txn.attach(new RemoteMailboxUpdateEvent(c, u));
+			txn.attach(new RemoteMailboxPropertiesUpdateEvent(c, p));
 			// Reset message retransmission timers for the contact. Avoiding
 			// messages getting stranded:
 			// - on our mailbox, if they now have a mailbox but didn't before
@@ -216,82 +171,70 @@ class MailboxUpdateManagerImpl implements MailboxUpdateManager,
 	}
 
 	@Override
-	public MailboxUpdate getLocalUpdate(Transaction txn, ContactId c)
+	@Nullable
-			throws DbException {
+	public MailboxPropertiesUpdate getLocalProperties(Transaction txn,
-		MailboxUpdate local = getUpdate(txn, db.getContact(txn, c), true);
+			ContactId c) throws DbException {
-		// An update (with or without mailbox) is created when contact is added
+		return getProperties(txn, db.getContact(txn, c), true);
-		if (local == null) {
-			throw new DbException();
-		}
-		return local;
 	}
 
 	@Override
 	@Nullable
-	public MailboxUpdate getRemoteUpdate(Transaction txn, ContactId c)
+	public MailboxPropertiesUpdate getRemoteProperties(Transaction txn,
-			throws DbException {
+			ContactId c) throws DbException {
-		return getUpdate(txn, db.getContact(txn, c), false);
+		return getProperties(txn, db.getContact(txn, c), false);
 	}
 
 	/**
 	 * Creates and sends an update message to the given contact. The message
-	 * holds our own mailbox's onion, generated unique properties, and lists of
+	 * holds our own mailbox's onion, and generated unique properties. All of
-	 * supported Mailbox API version(s). All of which the contact needs to
+	 * which the contact needs to communicate with our Mailbox.
-	 * communicate with our Mailbox.
 	 */
-	private void createAndSendUpdateWithMailbox(Transaction txn, Contact c,
+	private void createAndSendProperties(Transaction txn,
-			List<MailboxVersion> serverSupports, String ownOnion)
+			Contact c, String ownOnion) throws DbException {
-			throws DbException {
+		MailboxPropertiesUpdate p = new MailboxPropertiesUpdate(ownOnion,
-		String baseUrl = "http://" + ownOnion + ".onion"; // TODO
-		MailboxProperties properties = new MailboxProperties(baseUrl,
 				new MailboxAuthToken(crypto.generateUniqueId().getBytes()),
-				serverSupports,
 				new MailboxFolderId(crypto.generateUniqueId().getBytes()),
 				new MailboxFolderId(crypto.generateUniqueId().getBytes()));
-		MailboxUpdate u =
-				new MailboxUpdateWithMailbox(clientSupports, properties);
 		Group g = getContactGroup(c);
-		storeMessageReplaceLatest(txn, g.getId(), u);
+		storeMessageReplaceLatest(txn, g.getId(), p);
 	}
 
 	/**
-	 * Sends an update message with empty properties to the given contact. The
+	 * Sends an empty update message to the given contact. The empty update
-	 * empty update indicates for the receiving contact that we don't have any
+	 * indicates for the receiving contact that we no longer have a Mailbox that
-	 * Mailbox that they can use. It still includes the list of Mailbox API
+	 * they can use.
-	 * version(s) that we support as a client.
 	 */
-	private void sendUpdateNoMailbox(Transaction txn, Contact c)
+	private void sendEmptyProperties(Transaction txn, Contact c)
 			throws DbException {
 		Group g = getContactGroup(c);
-		MailboxUpdate u = new MailboxUpdate(clientSupports);
+		storeMessageReplaceLatest(txn, g.getId(), null);
-		storeMessageReplaceLatest(txn, g.getId(), u);
 	}
 
 	@Nullable
-	private MailboxUpdate getUpdate(Transaction txn, Contact c, boolean local)
+	private MailboxPropertiesUpdate getProperties(Transaction txn,
-			throws DbException {
+			Contact c, boolean local) throws DbException {
-		MailboxUpdate u = null;
+		MailboxPropertiesUpdate p = null;
 		Group g = getContactGroup(c);
 		try {
 			LatestUpdate latest = findLatest(txn, g.getId(), local);
 			if (latest != null) {
 				BdfList body =
 						clientHelper.getMessageAsList(txn, latest.messageId);
-				u = parseUpdate(body);
+				p = parseProperties(body);
 			}
 		} catch (FormatException e) {
 			throw new DbException(e);
 		}
-		return u;
+		return p;
 	}
 
 	private void storeMessageReplaceLatest(Transaction txn, GroupId g,
-			MailboxUpdate u) throws DbException {
+			@Nullable MailboxPropertiesUpdate p) throws DbException {
 		try {
 			LatestUpdate latest = findLatest(txn, g, true);
 			long version = latest == null ? 1 : latest.version + 1;
 			Message m = clientHelper.createMessage(g, clock.currentTimeMillis(),
-					encodeProperties(version, u));
+					encodeProperties(version, p));
 			BdfDictionary meta = new BdfDictionary();
 			meta.put(MSG_KEY_VERSION, version);
 			meta.put(MSG_KEY_LOCAL, true);
@@ -323,36 +266,23 @@ class MailboxUpdateManagerImpl implements MailboxUpdateManager,
 		return null;
 	}
 
-	private BdfList encodeProperties(long version, MailboxUpdate u) {
+	private BdfList encodeProperties(long version,
+			@Nullable MailboxPropertiesUpdate p) {
 		BdfDictionary dict = new BdfDictionary();
-		BdfList serverSupports = new BdfList();
+		if (p != null) {
-		if (u.hasMailbox()) {
+			dict.put(PROP_KEY_ONION, p.getOnion());
-			MailboxUpdateWithMailbox um = (MailboxUpdateWithMailbox) u;
+			dict.put(PROP_KEY_AUTHTOKEN, p.getAuthToken().getBytes());
-			MailboxProperties properties = um.getMailboxProperties();
+			dict.put(PROP_KEY_INBOXID, p.getInboxId().getBytes());
-			serverSupports = encodeSupportsList(properties.getServerSupports());
+			dict.put(PROP_KEY_OUTBOXID, p.getOutboxId().getBytes());
-			dict.put(PROP_KEY_ONION, properties.getOnion());
-			dict.put(PROP_KEY_AUTHTOKEN, properties.getAuthToken());
-			dict.put(PROP_KEY_INBOXID, properties.getInboxId());
-			dict.put(PROP_KEY_OUTBOXID, properties.getOutboxId());
 		}
-		return BdfList.of(version, encodeSupportsList(u.getClientSupports()),
+		return BdfList.of(version, dict);
-				serverSupports, dict);
 	}
 
-	private BdfList encodeSupportsList(List<MailboxVersion> supportsList) {
+	@Nullable
-		BdfList supports = new BdfList();
+	private MailboxPropertiesUpdate parseProperties(BdfList body)
-		for (MailboxVersion version : supportsList) {
+			throws FormatException {
-			supports.add(BdfList.of(version.getMajor(), version.getMinor()));
+		BdfDictionary dict = body.getDictionary(1);
-		}
+		return clientHelper.parseAndValidateMailboxPropertiesUpdate(dict);
-		return supports;
-	}
-
-	private MailboxUpdate parseUpdate(BdfList body) throws FormatException {
-		BdfList clientSupports = body.getList(1);
-		BdfList serverSupports = body.getList(2);
-		BdfDictionary dict = body.getDictionary(3);
-		return clientHelper.parseAndValidateMailboxUpdate(clientSupports,
-				serverSupports, dict);
 	}
 
 	private Group getContactGroup(Contact c) {

bramble-core/src/main/java/org/briarproject/bramble/mailbox/MailboxPropertyValidator.java

@@ -15,15 +15,15 @@ import org.briarproject.bramble.api.system.Clock;
 
 import javax.annotation.concurrent.Immutable;
 
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.MSG_KEY_LOCAL;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.MSG_KEY_LOCAL;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.MSG_KEY_VERSION;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.MSG_KEY_VERSION;
 import static org.briarproject.bramble.util.ValidationUtils.checkSize;
 
 @Immutable
 @NotNullByDefault
-class MailboxUpdateValidator extends BdfMessageValidator {
+class MailboxPropertyValidator extends BdfMessageValidator {
 
-	MailboxUpdateValidator(ClientHelper clientHelper,
+	MailboxPropertyValidator(ClientHelper clientHelper,
 			MetadataEncoder metadataEncoder, Clock clock) {
 		super(clientHelper, metadataEncoder, clock);
 	}
@@ -31,19 +31,14 @@ class MailboxUpdateValidator extends BdfMessageValidator {
 	@Override
 	protected BdfMessageContext validateMessage(Message m, Group g,
 			BdfList body) throws InvalidMessageException, FormatException {
-		// Version, Properties, clientSupports, serverSupports
+		// Version, properties
-		checkSize(body, 4);
+		checkSize(body, 2);
 		// Version
 		long version = body.getLong(0);
 		if (version < 0) throw new FormatException();
-		// clientSupports
-		BdfList clientSupports = body.getList(1);
-		// serverSupports
-		BdfList serverSupports = body.getList(2);
 		// Properties
-		BdfDictionary dictionary = body.getDictionary(3);
+		BdfDictionary dictionary = body.getDictionary(1);
-		clientHelper.parseAndValidateMailboxUpdate(clientSupports,
+		clientHelper.parseAndValidateMailboxPropertiesUpdate(dictionary);
-				serverSupports, dictionary);
 		// Return the metadata
 		BdfDictionary meta = new BdfDictionary();
 		meta.put(MSG_KEY_VERSION, version);

bramble-core/src/main/java/org/briarproject/bramble/mailbox/MailboxSettingsManagerImpl.java

@@ -9,8 +9,7 @@ import org.briarproject.bramble.api.mailbox.MailboxProperties;
 import org.briarproject.bramble.api.mailbox.MailboxSettingsManager;
 import org.briarproject.bramble.api.mailbox.MailboxStatus;
 import org.briarproject.bramble.api.mailbox.MailboxVersion;
-import org.briarproject.bramble.api.mailbox.event.MailboxProblemEvent;
+import org.briarproject.bramble.api.mailbox.OwnMailboxConnectionStatusEvent;
-import org.briarproject.bramble.api.mailbox.event.OwnMailboxConnectionStatusEvent;
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.bramble.api.settings.Settings;
 import org.briarproject.bramble.api.settings.SettingsManager;
@@ -31,7 +30,6 @@ class MailboxSettingsManagerImpl implements MailboxSettingsManager {
 
 	// Package access for testing
 	static final String SETTINGS_NAMESPACE = "mailbox";
-	// TODO: This currently stores the base URL, not the 56-char onion address
 	static final String SETTINGS_KEY_ONION = "onion";
 	static final String SETTINGS_KEY_TOKEN = "token";
 	static final String SETTINGS_KEY_SERVER_SUPPORTS = "serverSupports";
@@ -62,6 +60,7 @@ class MailboxSettingsManagerImpl implements MailboxSettingsManager {
 		if (isNullOrEmpty(onion) || isNullOrEmpty(token)) return null;
 		int[] ints = s.getIntArray(SETTINGS_KEY_SERVER_SUPPORTS);
 		// We know we were paired, so we must have proper serverSupports
+		// TODO is throwing sensible? But it's done like that below on "parse error"
 		if (ints == null || ints.length == 0 || ints.length % 2 != 0) {
 			throw new DbException();
 		}
@@ -71,7 +70,7 @@ class MailboxSettingsManagerImpl implements MailboxSettingsManager {
 		}
 		try {
 			MailboxAuthToken tokenId = MailboxAuthToken.fromString(token);
-			return new MailboxProperties(onion, tokenId, serverSupports);
+			return new MailboxProperties(onion, tokenId, true, serverSupports);
 		} catch (InvalidMailboxIdException e) {
 			throw new DbException(e);
 		}
@@ -93,18 +92,7 @@ class MailboxSettingsManagerImpl implements MailboxSettingsManager {
 		s.putIntArray(SETTINGS_KEY_SERVER_SUPPORTS, ints);
 		settingsManager.mergeSettings(txn, s, SETTINGS_NAMESPACE);
 		for (MailboxHook hook : hooks) {
-			hook.mailboxPaired(txn, p.getOnion(), p.getServerSupports());
+			hook.mailboxPaired(txn, p.getOnion());
-		}
-	}
-
-	@Override
-	public void removeOwnMailboxProperties(Transaction txn) throws DbException {
-		Settings s = new Settings();
-		s.put(SETTINGS_KEY_ONION, "");
-		s.put(SETTINGS_KEY_TOKEN, "");
-		settingsManager.mergeSettings(txn, s, SETTINGS_NAMESPACE);
-		for (MailboxHook hook : hooks) {
-			hook.mailboxUnpaired(txn);
 		}
 	}
 
@@ -143,7 +131,6 @@ class MailboxSettingsManagerImpl implements MailboxSettingsManager {
 		settingsManager.mergeSettings(txn, newSettings, SETTINGS_NAMESPACE);
 		MailboxStatus status = new MailboxStatus(now, lastSuccess, newAttempts);
 		txn.attach(new OwnMailboxConnectionStatusEvent(status));
-		if (status.hasProblem(now)) txn.attach(new MailboxProblemEvent());
 	}
 
 	@Override

bramble-core/src/main/java/org/briarproject/bramble/mailbox/OwnMailboxConnectivityChecker.java

@@ -1,75 +0,0 @@
-package org.briarproject.bramble.mailbox;
-
-import org.briarproject.bramble.api.db.DbException;
-import org.briarproject.bramble.api.db.TransactionManager;
-import org.briarproject.bramble.api.mailbox.MailboxProperties;
-import org.briarproject.bramble.api.mailbox.MailboxSettingsManager;
-import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
-import org.briarproject.bramble.api.system.Clock;
-import org.briarproject.bramble.mailbox.MailboxApi.ApiException;
-
-import java.io.IOException;
-import java.util.logging.Logger;
-
-import javax.annotation.concurrent.ThreadSafe;
-
-import static java.util.logging.Level.WARNING;
-import static java.util.logging.Logger.getLogger;
-import static org.briarproject.bramble.util.LogUtils.logException;
-
-@ThreadSafe
-@NotNullByDefault
-class OwnMailboxConnectivityChecker extends ConnectivityCheckerImpl {
-
-	private static final Logger LOG =
-			getLogger(OwnMailboxConnectivityChecker.class.getName());
-
-	private final MailboxApi mailboxApi;
-	private final TransactionManager db;
-	private final MailboxSettingsManager mailboxSettingsManager;
-
-	OwnMailboxConnectivityChecker(Clock clock,
-			MailboxApiCaller mailboxApiCaller,
-			MailboxApi mailboxApi,
-			TransactionManager db,
-			MailboxSettingsManager mailboxSettingsManager) {
-		super(clock, mailboxApiCaller);
-		this.mailboxApi = mailboxApi;
-		this.db = db;
-		this.mailboxSettingsManager = mailboxSettingsManager;
-	}
-
-	@Override
-	ApiCall createConnectivityCheckTask(MailboxProperties properties) {
-		if (!properties.isOwner()) throw new IllegalArgumentException();
-		return () -> {
-			try {
-				return checkConnectivityAndStoreResult(properties);
-			} catch (DbException e) {
-				logException(LOG, WARNING, e);
-				return true; // Retry
-			}
-		};
-	}
-
-	private boolean checkConnectivityAndStoreResult(
-			MailboxProperties properties) throws DbException {
-		try {
-			if (!mailboxApi.checkStatus(properties)) throw new ApiException();
-			LOG.info("Own mailbox is reachable");
-			long now = clock.currentTimeMillis();
-			db.transaction(false, txn -> mailboxSettingsManager
-					.recordSuccessfulConnection(txn, now));
-			// Call the observers and cache the result
-			onConnectivityCheckSucceeded(now);
-			return false; // Don't retry
-		} catch (IOException | ApiException e) {
-			LOG.warning("Own mailbox is unreachable");
-			logException(LOG, WARNING, e);
-			long now = clock.currentTimeMillis();
-			db.transaction(false, txn -> mailboxSettingsManager
-					.recordFailedConnectionAttempt(txn, now));
-		}
-		return true; // Retry
-	}
-}

bramble-core/src/main/java/org/briarproject/bramble/mailbox/SimpleApiCall.java

@@ -1,39 +0,0 @@
-package org.briarproject.bramble.mailbox;
-
-import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
-import org.briarproject.bramble.mailbox.MailboxApi.ApiException;
-import org.briarproject.bramble.mailbox.MailboxApi.TolerableFailureException;
-
-import java.io.IOException;
-import java.util.logging.Logger;
-
-import static java.util.logging.Level.INFO;
-import static java.util.logging.Level.WARNING;
-import static java.util.logging.Logger.getLogger;
-import static org.briarproject.bramble.util.LogUtils.logException;
-
-/**
- * Convenience class for making simple API calls that don't return values.
- */
-@NotNullByDefault
-public abstract class SimpleApiCall implements ApiCall {
-
-	private static final Logger LOG = getLogger(SimpleApiCall.class.getName());
-
-	abstract void tryToCallApi()
-			throws IOException, ApiException, TolerableFailureException;
-
-	@Override
-	public boolean callApi() {
-		try {
-			tryToCallApi();
-			return false; // Succeeded, don't retry
-		} catch (IOException | ApiException e) {
-			logException(LOG, WARNING, e);
-			return true; // Failed, retry with backoff
-		} catch (TolerableFailureException e) {
-			logException(LOG, INFO, e);
-			return false; // Failed tolerably, don't retry
-		}
-	}
-}

bramble-core/src/main/java/org/briarproject/bramble/plugin/PollerImpl.java

@@ -1,6 +1,5 @@
 package org.briarproject.bramble.plugin;
 
-import org.briarproject.bramble.api.Cancellable;
 import org.briarproject.bramble.api.Pair;
 import org.briarproject.bramble.api.connection.ConnectionManager;
 import org.briarproject.bramble.api.connection.ConnectionRegistry;
@@ -28,6 +27,7 @@ import org.briarproject.bramble.api.properties.TransportProperties;
 import org.briarproject.bramble.api.properties.TransportPropertyManager;
 import org.briarproject.bramble.api.system.Clock;
 import org.briarproject.bramble.api.system.TaskScheduler;
+import org.briarproject.bramble.api.system.TaskScheduler.Cancellable;
 import org.briarproject.bramble.api.system.Wakeful;
 import org.briarproject.bramble.api.system.WakefulIoExecutor;
 

bramble-core/src/main/java/org/briarproject/bramble/plugin/tor/TorPlugin.java

@@ -2,7 +2,6 @@ package org.briarproject.bramble.plugin.tor;
 
 import net.freehaven.tor.control.EventHandler;
 import net.freehaven.tor.control.TorControlConnection;
-import net.freehaven.tor.control.TorNotRunningException;
 
 import org.briarproject.bramble.PoliteExecutor;
 import org.briarproject.bramble.api.Pair;
@@ -322,8 +321,6 @@ abstract class TorPlugin implements DuplexPlugin, EventHandler, EventListener {
 				LOG.info("Tor has already built a circuit");
 				state.getAndSetCircuitBuilt(true);
 			}
-		} catch (TorNotRunningException e) {
-			throw new RuntimeException(e);
 		} catch (IOException e) {
 			throw new PluginException(e);
 		}
@@ -495,8 +492,6 @@ abstract class TorPlugin implements DuplexPlugin, EventHandler, EventListener {
 			} else {
 				response = controlConnection.addOnion(privKey, portLines);
 			}
-		} catch (TorNotRunningException e) {
-			throw new RuntimeException(e);
 		} catch (IOException e) {
 			logException(LOG, WARNING, e);
 			return;
@@ -545,38 +540,30 @@ abstract class TorPlugin implements DuplexPlugin, EventHandler, EventListener {
 
 	protected void enableNetwork(boolean enable) throws IOException {
 		state.enableNetwork(enable);
-		try {
+		controlConnection.setConf("DisableNetwork", enable ? "0" : "1");
-			controlConnection.setConf("DisableNetwork", enable ? "0" : "1");
-		} catch (TorNotRunningException e) {
-			throw new RuntimeException(e);
-		}
 	}
 
 	private void enableBridges(boolean enable, List<BridgeType> bridgeTypes)
 			throws IOException {
-		try {
+		if (enable) {
-			if (enable) {
+			Collection<String> conf = new ArrayList<>();
-				Collection<String> conf = new ArrayList<>();
+			conf.add("UseBridges 1");
-				conf.add("UseBridges 1");
+			File obfs4File = getObfs4ExecutableFile();
-				File obfs4File = getObfs4ExecutableFile();
+			if (bridgeTypes.contains(MEEK)) {
-				if (bridgeTypes.contains(MEEK)) {
+				conf.add("ClientTransportPlugin meek_lite exec " +
-					conf.add("ClientTransportPlugin meek_lite exec " +
+						obfs4File.getAbsolutePath());
-							obfs4File.getAbsolutePath());
-				}
-				if (bridgeTypes.contains(DEFAULT_OBFS4) ||
-						bridgeTypes.contains(NON_DEFAULT_OBFS4)) {
-					conf.add("ClientTransportPlugin obfs4 exec " +
-							obfs4File.getAbsolutePath());
-				}
-				for (BridgeType bridgeType : bridgeTypes) {
-					conf.addAll(circumventionProvider.getBridges(bridgeType));
-				}
-				controlConnection.setConf(conf);
-			} else {
-				controlConnection.setConf("UseBridges", "0");
 			}
-		} catch (TorNotRunningException e) {
+			if (bridgeTypes.contains(DEFAULT_OBFS4) ||
-			throw new RuntimeException(e);
+					bridgeTypes.contains(NON_DEFAULT_OBFS4)) {
+				conf.add("ClientTransportPlugin obfs4 exec " +
+						obfs4File.getAbsolutePath());
+			}
+			for (BridgeType bridgeType : bridgeTypes) {
+				conf.addAll(circumventionProvider.getBridges(bridgeType));
+			}
+			controlConnection.setConf(conf);
+		} else {
+			controlConnection.setConf("UseBridges", "0");
 		}
 	}
 
@@ -590,8 +577,6 @@ abstract class TorPlugin implements DuplexPlugin, EventHandler, EventListener {
 				controlConnection.setConf("DisableNetwork", "1");
 				controlConnection.shutdownTor("TERM");
 				controlSocket.close();
-			} catch (TorNotRunningException e) {
-				throw new RuntimeException(e);
 			} catch (IOException e) {
 				logException(LOG, WARNING, e);
 			}
@@ -723,11 +708,7 @@ abstract class TorPlugin implements DuplexPlugin, EventHandler, EventListener {
 			});
 			Map<Integer, String> portLines =
 					singletonMap(80, "127.0.0.1:" + port);
-			try {
+			controlConnection.addOnion(blob, portLines);
-				controlConnection.addOnion(blob, portLines);
-			} catch (TorNotRunningException e) {
-				throw new RuntimeException(e);
-			}
 			return new RendezvousEndpoint() {
 
 				@Override
@@ -737,11 +718,7 @@ abstract class TorPlugin implements DuplexPlugin, EventHandler, EventListener {
 
 				@Override
 				public void close() throws IOException {
-					try {
+					controlConnection.delOnion(localOnion);
-						controlConnection.delOnion(localOnion);
-					} catch (TorNotRunningException e) {
-						throw new RuntimeException(e);
-					}
 					tryToClose(ss, LOG, WARNING);
 				}
 			};
@@ -769,8 +746,18 @@ abstract class TorPlugin implements DuplexPlugin, EventHandler, EventListener {
 	public void orConnStatus(String status, String orName) {
 		if (LOG.isLoggable(INFO)) LOG.info("OR connection " + status);
 
-		if (status.equals("CONNECTED")) state.onOrConnectionConnected();
+		//noinspection IfCanBeSwitch
+		if (status.equals("LAUNCHED")) state.onOrConnectionLaunched();
+		else if (status.equals("FAILED")) state.onOrConnectionFailed();
+		else if (status.equals("CONNECTED")) state.onOrConnectionConnected();
 		else if (status.equals("CLOSED")) state.onOrConnectionClosed();
+
+		if ((status.equals("FAILED") || status.equals("CLOSED")) &&
+				state.getNumOrConnections() == 0) {
+			// Check whether we've lost connectivity
+			updateConnectionStatus(networkManager.getNetworkStatus(),
+					batteryManager.isCharging());
+		}
 	}
 
 	@Override
@@ -784,6 +771,9 @@ abstract class TorPlugin implements DuplexPlugin, EventHandler, EventListener {
 	@Override
 	public void message(String severity, String msg) {
 		if (LOG.isLoggable(INFO)) LOG.info(severity + " " + msg);
+		if (msg.startsWith("Switching to guard context")) {
+			state.onSwitchingGuardContext();
+		}
 	}
 
 	@Override
@@ -865,6 +855,11 @@ abstract class TorPlugin implements DuplexPlugin, EventHandler, EventListener {
 			if (s.getNamespace().equals(ID.getString())) {
 				LOG.info("Tor settings updated");
 				settings = s.getSettings();
+				// Works around a bug introduced in Tor 0.3.4.8.
+				// https://trac.torproject.org/projects/tor/ticket/28027
+				// Could be replaced with callback.transportDisabled()
+				// when fixed.
+				disableNetwork();
 				updateConnectionStatus(networkManager.getNetworkStatus(),
 						batteryManager.isCharging());
 			}
@@ -877,6 +872,16 @@ abstract class TorPlugin implements DuplexPlugin, EventHandler, EventListener {
 		}
 	}
 
+	private void disableNetwork() {
+		connectionStatusExecutor.execute(() -> {
+			try {
+				if (state.isTorRunning()) enableNetwork(false);
+			} catch (IOException ex) {
+				logException(LOG, WARNING, ex);
+			}
+		});
+	}
+
 	private void updateConnectionStatus(NetworkStatus status,
 			boolean charging) {
 		connectionStatusExecutor.execute(() -> {
@@ -973,20 +978,12 @@ abstract class TorPlugin implements DuplexPlugin, EventHandler, EventListener {
 	}
 
 	private void enableConnectionPadding(boolean enable) throws IOException {
-		try {
+		controlConnection.setConf("ConnectionPadding", enable ? "1" : "0");
-			controlConnection.setConf("ConnectionPadding", enable ? "1" : "0");
-		} catch (TorNotRunningException e) {
-			throw new RuntimeException(e);
-		}
 	}
 
 	private void useIpv6(boolean ipv6Only) throws IOException {
-		try {
+		controlConnection.setConf("ClientUseIPv4", ipv6Only ? "0" : "1");
-			controlConnection.setConf("ClientUseIPv4", ipv6Only ? "0" : "1");
+		controlConnection.setConf("ClientUseIPv6", ipv6Only ? "1" : "0");
-			controlConnection.setConf("ClientUseIPv6", ipv6Only ? "1" : "0");
-		} catch (TorNotRunningException e) {
-			throw new RuntimeException(e);
-		}
 	}
 
 	@ThreadSafe
@@ -1010,14 +1007,13 @@ abstract class TorPlugin implements DuplexPlugin, EventHandler, EventListener {
 		private ServerSocket serverSocket = null;
 
 		@GuardedBy("this")
-		private int orConnectionsConnected = 0;
+		private int orConnectionsPending = 0, orConnectionsConnected = 0;
 
 		private synchronized void setStarted() {
 			started = true;
 			callback.pluginStateChanged(getState());
 		}
 
-		@SuppressWarnings("BooleanMethodIsAlwaysInverted")
 		private synchronized boolean isTorRunning() {
 			return started && !stopped;
 		}
@@ -1075,38 +1071,63 @@ abstract class TorPlugin implements DuplexPlugin, EventHandler, EventListener {
 			if (reasonsDisabled != 0) return DISABLED;
 			if (!networkInitialised) return ENABLING;
 			if (!networkEnabled) return INACTIVE;
-			return bootstrapped && circuitBuilt && orConnectionsConnected > 0
+			return bootstrapped && circuitBuilt ? ACTIVE : ENABLING;
-					? ACTIVE : ENABLING;
 		}
 
 		private synchronized int getReasonsDisabled() {
 			return getState() == DISABLED ? reasonsDisabled : 0;
 		}
 
+		private synchronized void onOrConnectionLaunched() {
+			orConnectionsPending++;
+			logOrConnections();
+		}
+
+		private synchronized void onOrConnectionFailed() {
+			orConnectionsPending--;
+			if (orConnectionsPending < 0) {
+				LOG.warning("Count was zero before connection failed");
+				orConnectionsPending = 0;
+			}
+			logOrConnections();
+		}
+
 		private synchronized void onOrConnectionConnected() {
-			int oldConnected = orConnectionsConnected;
+			orConnectionsPending--;
+			if (orConnectionsPending < 0) {
+				LOG.warning("Count was zero before connection connected");
+				orConnectionsPending = 0;
+			}
 			orConnectionsConnected++;
 			logOrConnections();
-			if (oldConnected == 0) callback.pluginStateChanged(getState());
 		}
 
 		private synchronized void onOrConnectionClosed() {
-			int oldConnected = orConnectionsConnected;
 			orConnectionsConnected--;
 			if (orConnectionsConnected < 0) {
 				LOG.warning("Count was zero before connection closed");
 				orConnectionsConnected = 0;
 			}
 			logOrConnections();
-			if (orConnectionsConnected == 0 && oldConnected != 0) {
+		}
-				callback.pluginStateChanged(getState());
+
-			}
+		private synchronized void onSwitchingGuardContext() {
+			// Tor doesn't seem to report events for connections belonging to
+			// the old guard context, so we have to reset the counters
+			orConnectionsPending = 0;
+			orConnectionsConnected = 0;
+			logOrConnections();
+		}
+
+		private synchronized int getNumOrConnections() {
+			return orConnectionsPending + orConnectionsConnected;
 		}
 
 		@GuardedBy("this")
 		private void logOrConnections() {
 			if (LOG.isLoggable(INFO)) {
-				LOG.info(orConnectionsConnected + " OR connections connected");
+				LOG.info("OR connections: " + orConnectionsPending
+						+ " pending, " + orConnectionsConnected + " connected");
 			}
 		}
 	}

bramble-core/src/main/java/org/briarproject/bramble/plugin/tor/TorPluginFactory.java

@@ -1,134 +0,0 @@
-package org.briarproject.bramble.plugin.tor;
-
-import org.briarproject.bramble.api.battery.BatteryManager;
-import org.briarproject.bramble.api.crypto.CryptoComponent;
-import org.briarproject.bramble.api.event.EventBus;
-import org.briarproject.bramble.api.lifecycle.IoExecutor;
-import org.briarproject.bramble.api.network.NetworkManager;
-import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
-import org.briarproject.bramble.api.plugin.Backoff;
-import org.briarproject.bramble.api.plugin.BackoffFactory;
-import org.briarproject.bramble.api.plugin.PluginCallback;
-import org.briarproject.bramble.api.plugin.TorConstants;
-import org.briarproject.bramble.api.plugin.TorControlPort;
-import org.briarproject.bramble.api.plugin.TorDirectory;
-import org.briarproject.bramble.api.plugin.TorSocksPort;
-import org.briarproject.bramble.api.plugin.TransportId;
-import org.briarproject.bramble.api.plugin.duplex.DuplexPlugin;
-import org.briarproject.bramble.api.plugin.duplex.DuplexPluginFactory;
-import org.briarproject.bramble.api.system.Clock;
-import org.briarproject.bramble.api.system.LocationUtils;
-import org.briarproject.bramble.api.system.ResourceProvider;
-import org.briarproject.bramble.api.system.WakefulIoExecutor;
-
-import java.io.File;
-import java.util.concurrent.Executor;
-import java.util.logging.Logger;
-
-import javax.annotation.Nullable;
-import javax.annotation.concurrent.Immutable;
-import javax.net.SocketFactory;
-
-import static java.util.logging.Level.INFO;
-import static java.util.logging.Logger.getLogger;
-
-@Immutable
-@NotNullByDefault
-abstract class TorPluginFactory implements DuplexPluginFactory {
-
-	protected static final Logger LOG =
-			getLogger(TorPluginFactory.class.getName());
-
-	protected static final int MAX_LATENCY = 30 * 1000; // 30 seconds
-	protected static final int MAX_IDLE_TIME = 30 * 1000; // 30 seconds
-	private static final int MIN_POLLING_INTERVAL = 60 * 1000; // 1 minute
-	private static final int MAX_POLLING_INTERVAL = 10 * 60 * 1000; // 10 mins
-	private static final double BACKOFF_BASE = 1.2;
-
-	protected final Executor ioExecutor, wakefulIoExecutor;
-	protected final NetworkManager networkManager;
-	protected final LocationUtils locationUtils;
-	protected final EventBus eventBus;
-	protected final SocketFactory torSocketFactory;
-	protected final BackoffFactory backoffFactory;
-	protected final ResourceProvider resourceProvider;
-	protected final CircumventionProvider circumventionProvider;
-	protected final BatteryManager batteryManager;
-	protected final Clock clock;
-	protected final CryptoComponent crypto;
-	protected final File torDirectory;
-	protected final int torSocksPort;
-	protected final int torControlPort;
-
-	TorPluginFactory(@IoExecutor Executor ioExecutor,
-			@WakefulIoExecutor Executor wakefulIoExecutor,
-			NetworkManager networkManager,
-			LocationUtils locationUtils,
-			EventBus eventBus,
-			SocketFactory torSocketFactory,
-			BackoffFactory backoffFactory,
-			ResourceProvider resourceProvider,
-			CircumventionProvider circumventionProvider,
-			BatteryManager batteryManager,
-			Clock clock,
-			CryptoComponent crypto,
-			@TorDirectory File torDirectory,
-			@TorSocksPort int torSocksPort,
-			@TorControlPort int torControlPort) {
-		this.ioExecutor = ioExecutor;
-		this.wakefulIoExecutor = wakefulIoExecutor;
-		this.networkManager = networkManager;
-		this.locationUtils = locationUtils;
-		this.eventBus = eventBus;
-		this.torSocketFactory = torSocketFactory;
-		this.backoffFactory = backoffFactory;
-		this.resourceProvider = resourceProvider;
-		this.circumventionProvider = circumventionProvider;
-		this.batteryManager = batteryManager;
-		this.clock = clock;
-		this.crypto = crypto;
-		this.torDirectory = torDirectory;
-		this.torSocksPort = torSocksPort;
-		this.torControlPort = torControlPort;
-	}
-
-	@Nullable
-	abstract String getArchitectureForTorBinary();
-
-	abstract TorPlugin createPluginInstance(Backoff backoff,
-			TorRendezvousCrypto torRendezvousCrypto, PluginCallback callback,
-			String architecture);
-
-	@Override
-	public TransportId getId() {
-		return TorConstants.ID;
-	}
-
-	@Override
-	public long getMaxLatency() {
-		return MAX_LATENCY;
-	}
-
-	@Override
-	public DuplexPlugin createPlugin(PluginCallback callback) {
-		// Check that we have a Tor binary for this architecture
-		String architecture = getArchitectureForTorBinary();
-		if (architecture == null) {
-			LOG.warning("Tor is not supported on this architecture");
-			return null;
-		}
-
-		if (LOG.isLoggable(INFO)) {
-			LOG.info("The selected architecture for Tor is " + architecture);
-		}
-
-		Backoff backoff = backoffFactory.createBackoff(MIN_POLLING_INTERVAL,
-				MAX_POLLING_INTERVAL, BACKOFF_BASE);
-		TorRendezvousCrypto torRendezvousCrypto =
-				new TorRendezvousCryptoImpl(crypto);
-		TorPlugin plugin = createPluginInstance(backoff, torRendezvousCrypto,
-				callback, architecture);
-		eventBus.addListener(plugin);
-		return plugin;
-	}
-}

bramble-core/src/main/java/org/briarproject/bramble/record/RecordWriterImpl.java

@@ -19,8 +19,6 @@ class RecordWriterImpl implements RecordWriter {
 	private final OutputStream out;
 	private final byte[] header = new byte[RECORD_HEADER_BYTES];
 
-	private long bytesWritten = 0;
-
 	RecordWriterImpl(OutputStream out) {
 		this.out = out;
 	}
@@ -33,7 +31,6 @@ class RecordWriterImpl implements RecordWriter {
 		ByteUtils.writeUint16(payload.length, header, 2);
 		out.write(header);
 		out.write(payload);
-		bytesWritten += RECORD_HEADER_BYTES + payload.length;
 	}
 
 	@Override
@@ -45,9 +42,4 @@ class RecordWriterImpl implements RecordWriter {
 	public void close() throws IOException {
 		out.close();
 	}
-
-	@Override
-	public long getBytesWritten() {
-		return bytesWritten;
-	}
 }

bramble-core/src/main/java/org/briarproject/bramble/rendezvous/RendezvousPollerImpl.java

@@ -1,7 +1,6 @@
 package org.briarproject.bramble.rendezvous;
 
 import org.briarproject.bramble.PoliteExecutor;
-import org.briarproject.bramble.api.Cancellable;
 import org.briarproject.bramble.api.Pair;
 import org.briarproject.bramble.api.connection.ConnectionManager;
 import org.briarproject.bramble.api.contact.PendingContact;
@@ -43,6 +42,7 @@ import org.briarproject.bramble.api.rendezvous.event.RendezvousConnectionOpenedE
 import org.briarproject.bramble.api.rendezvous.event.RendezvousPollEvent;
 import org.briarproject.bramble.api.system.Clock;
 import org.briarproject.bramble.api.system.TaskScheduler;
+import org.briarproject.bramble.api.system.TaskScheduler.Cancellable;
 import org.briarproject.bramble.api.system.Wakeful;
 
 import java.security.GeneralSecurityException;

bramble-core/src/main/java/org/briarproject/bramble/socks/SocksModule.java

@@ -10,7 +10,6 @@ import dagger.Module;
 import dagger.Provides;
 
 import static org.briarproject.bramble.api.plugin.TorConstants.CONNECT_TO_PROXY_TIMEOUT;
-import static org.briarproject.bramble.api.plugin.TorConstants.EXTRA_CONNECT_TIMEOUT;
 import static org.briarproject.bramble.api.plugin.TorConstants.EXTRA_SOCKET_TIMEOUT;
 
 @Module
@@ -21,6 +20,6 @@ public class SocksModule {
 		InetSocketAddress proxy = new InetSocketAddress("127.0.0.1",
 				torSocksPort);
 		return new SocksSocketFactory(proxy, CONNECT_TO_PROXY_TIMEOUT,
-				EXTRA_CONNECT_TIMEOUT, EXTRA_SOCKET_TIMEOUT);
+				EXTRA_SOCKET_TIMEOUT);
 	}
 }

bramble-core/src/main/java/org/briarproject/bramble/socks/SocksSocket.java

@@ -26,18 +26,15 @@ class SocksSocket extends Socket {
 			"Address type not supported"
 	};
 
-	@SuppressWarnings("MismatchedReadAndWriteOfArray")
 	private static final byte[] UNSPECIFIED_ADDRESS = new byte[4];
 
 	private final SocketAddress proxy;
-	private final int connectToProxyTimeout;
+	private final int connectToProxyTimeout, extraSocketTimeout;
-	private final int extraConnectTimeout, extraSocketTimeout;
 
 	SocksSocket(SocketAddress proxy, int connectToProxyTimeout,
-			int extraConnectTimeout, int extraSocketTimeout) {
+			int extraSocketTimeout) {
 		this.proxy = proxy;
 		this.connectToProxyTimeout = connectToProxyTimeout;
-		this.extraConnectTimeout = extraConnectTimeout;
 		this.extraSocketTimeout = extraSocketTimeout;
 	}
 
@@ -69,7 +66,7 @@ class SocksSocket extends Socket {
 
 		// Use the supplied timeout temporarily, plus any configured extra
 		int oldTimeout = getSoTimeout();
-		setSoTimeout(timeout + extraConnectTimeout);
+		setSoTimeout(timeout + extraSocketTimeout);
 
 		// Connect to the endpoint via the proxy
 		sendConnectRequest(out, host, port);

bramble-core/src/main/java/org/briarproject/bramble/socks/SocksSocketFactory.java

@@ -11,21 +11,18 @@ import javax.net.SocketFactory;
 class SocksSocketFactory extends SocketFactory {
 
 	private final SocketAddress proxy;
-	private final int connectToProxyTimeout;
+	private final int connectToProxyTimeout, extraSocketTimeout;
-	private final int extraConnectTimeout, extraSocketTimeout;
 
 	SocksSocketFactory(SocketAddress proxy, int connectToProxyTimeout,
-			int extraConnectTimeout, int extraSocketTimeout) {
+			int extraSocketTimeout) {
 		this.proxy = proxy;
 		this.connectToProxyTimeout = connectToProxyTimeout;
-		this.extraConnectTimeout = extraConnectTimeout;
 		this.extraSocketTimeout = extraSocketTimeout;
 	}
 
 	@Override
 	public Socket createSocket() {
-		return new SocksSocket(proxy, connectToProxyTimeout,
+		return new SocksSocket(proxy, connectToProxyTimeout, extraSocketTimeout);
-				extraConnectTimeout, extraSocketTimeout);
 	}
 
 	@Override

bramble-core/src/main/java/org/briarproject/bramble/sync/DuplexOutgoingSession.java

@@ -13,13 +13,11 @@ import org.briarproject.bramble.api.lifecycle.event.LifecycleEvent;
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.bramble.api.plugin.TransportId;
 import org.briarproject.bramble.api.plugin.event.TransportInactiveEvent;
-import org.briarproject.bramble.api.record.Record;
 import org.briarproject.bramble.api.sync.Ack;
 import org.briarproject.bramble.api.sync.Message;
 import org.briarproject.bramble.api.sync.Offer;
 import org.briarproject.bramble.api.sync.Priority;
 import org.briarproject.bramble.api.sync.Request;
-import org.briarproject.bramble.api.sync.SyncConstants;
 import org.briarproject.bramble.api.sync.SyncRecordWriter;
 import org.briarproject.bramble.api.sync.SyncSession;
 import org.briarproject.bramble.api.sync.Versions;
@@ -49,9 +47,8 @@ import static java.util.logging.Level.INFO;
 import static java.util.logging.Level.WARNING;
 import static java.util.logging.Logger.getLogger;
 import static org.briarproject.bramble.api.lifecycle.LifecycleManager.LifecycleState.STOPPING;
-import static org.briarproject.bramble.api.record.Record.RECORD_HEADER_BYTES;
+import static org.briarproject.bramble.api.record.Record.MAX_RECORD_PAYLOAD_BYTES;
 import static org.briarproject.bramble.api.sync.SyncConstants.MAX_MESSAGE_IDS;
-import static org.briarproject.bramble.api.sync.SyncConstants.MAX_MESSAGE_LENGTH;
 import static org.briarproject.bramble.api.sync.SyncConstants.SUPPORTED_VERSIONS;
 import static org.briarproject.bramble.util.LogUtils.logException;
 
@@ -74,16 +71,6 @@ class DuplexOutgoingSession implements SyncSession, EventListener {
 			NEXT_SEND_TIME_DECREASED = () -> {
 	};
 
-	/**
-	 * The batch capacity must be at least {@link Record#RECORD_HEADER_BYTES}
-	 * + {@link SyncConstants#MAX_MESSAGE_LENGTH} to ensure that maximum-size
-	 * messages can be selected for transmission. Larger batches will mean
-	 * fewer round-trips between the DB and the output stream, but each
-	 * round-trip will block the DB for longer.
-	 */
-	private static final int BATCH_CAPACITY =
-			(RECORD_HEADER_BYTES + MAX_MESSAGE_LENGTH) * 2;
-
 	private final DatabaseComponent db;
 	private final Executor dbExecutor;
 	private final EventBus eventBus;
@@ -309,7 +296,8 @@ class DuplexOutgoingSession implements SyncSession, EventListener {
 						db.transactionWithNullableResult(false, txn -> {
 							Collection<Message> batch =
 									db.generateRequestedBatch(txn, contactId,
-											BATCH_CAPACITY, maxLatency);
+											MAX_RECORD_PAYLOAD_BYTES,
+											maxLatency);
 							setNextSendTime(db.getNextSendTime(txn, contactId));
 							return batch;
 						});

bramble-core/src/main/java/org/briarproject/bramble/sync/EagerSimplexOutgoingSession.java

@@ -1,66 +0,0 @@
-package org.briarproject.bramble.sync;
-
-import org.briarproject.bramble.api.contact.ContactId;
-import org.briarproject.bramble.api.db.DatabaseComponent;
-import org.briarproject.bramble.api.db.DbException;
-import org.briarproject.bramble.api.event.EventBus;
-import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
-import org.briarproject.bramble.api.plugin.TransportId;
-import org.briarproject.bramble.api.sync.Message;
-import org.briarproject.bramble.api.sync.MessageId;
-import org.briarproject.bramble.api.sync.SyncRecordWriter;
-import org.briarproject.bramble.api.transport.StreamWriter;
-
-import java.io.IOException;
-import java.util.Collection;
-import java.util.logging.Logger;
-
-import javax.annotation.concurrent.ThreadSafe;
-
-import static java.util.logging.Level.INFO;
-import static java.util.logging.Logger.getLogger;
-
-/**
- * A {@link SimplexOutgoingSession} that sends messages eagerly, ie
- * regardless of whether they're due for retransmission.
- */
-@ThreadSafe
-@NotNullByDefault
-class EagerSimplexOutgoingSession extends SimplexOutgoingSession {
-
-	private static final Logger LOG =
-			getLogger(EagerSimplexOutgoingSession.class.getName());
-
-	EagerSimplexOutgoingSession(DatabaseComponent db,
-			EventBus eventBus,
-			ContactId contactId,
-			TransportId transportId,
-			long maxLatency,
-			StreamWriter streamWriter,
-			SyncRecordWriter recordWriter) {
-		super(db, eventBus, contactId, transportId, maxLatency, streamWriter,
-				recordWriter);
-	}
-
-	@Override
-	void sendMessages() throws DbException, IOException {
-		for (MessageId m : loadUnackedMessageIdsToSend()) {
-			if (isInterrupted()) break;
-			Message message = db.transactionWithNullableResult(false, txn ->
-					db.getMessageToSend(txn, contactId, m, maxLatency, true));
-			if (message == null) continue; // No longer shared
-			recordWriter.writeMessage(message);
-			LOG.info("Sent message");
-		}
-	}
-
-	private Collection<MessageId> loadUnackedMessageIdsToSend()
-			throws DbException {
-		Collection<MessageId> ids = db.transactionWithResult(true, txn ->
-				db.getUnackedMessagesToSend(txn, contactId));
-		if (LOG.isLoggable(INFO)) {
-			LOG.info(ids.size() + " unacked messages to send");
-		}
-		return ids;
-	}
-}

bramble-core/src/main/java/org/briarproject/bramble/sync/MailboxOutgoingSession.java

@@ -1,117 +0,0 @@
-package org.briarproject.bramble.sync;
-
-import org.briarproject.bramble.api.contact.ContactId;
-import org.briarproject.bramble.api.db.DatabaseComponent;
-import org.briarproject.bramble.api.db.DbException;
-import org.briarproject.bramble.api.event.EventBus;
-import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
-import org.briarproject.bramble.api.plugin.TransportId;
-import org.briarproject.bramble.api.sync.Ack;
-import org.briarproject.bramble.api.sync.DeferredSendHandler;
-import org.briarproject.bramble.api.sync.Message;
-import org.briarproject.bramble.api.sync.MessageId;
-import org.briarproject.bramble.api.sync.SyncRecordWriter;
-import org.briarproject.bramble.api.transport.StreamWriter;
-
-import java.io.IOException;
-import java.util.Collection;
-import java.util.logging.Logger;
-
-import javax.annotation.concurrent.ThreadSafe;
-
-import static java.lang.Math.min;
-import static java.util.Collections.emptyList;
-import static java.util.logging.Level.INFO;
-import static java.util.logging.Logger.getLogger;
-import static org.briarproject.bramble.api.record.Record.RECORD_HEADER_BYTES;
-import static org.briarproject.bramble.api.sync.SyncConstants.MAX_MESSAGE_IDS;
-import static org.briarproject.bramble.api.sync.SyncConstants.MESSAGE_HEADER_LENGTH;
-
-/**
- * A {@link SimplexOutgoingSession} for sending and acking messages via a
- * mailbox. The session uses a {@link DeferredSendHandler} to record the IDs
- * of the messages sent and acked during the session so that they can be
- * recorded in the DB as sent or acked after the file has been successfully
- * uploaded to the mailbox.
- */
-@ThreadSafe
-@NotNullByDefault
-class MailboxOutgoingSession extends SimplexOutgoingSession {
-
-	private static final Logger LOG =
-			getLogger(MailboxOutgoingSession.class.getName());
-
-	private final DeferredSendHandler deferredSendHandler;
-	private final long initialCapacity;
-
-	MailboxOutgoingSession(DatabaseComponent db,
-			EventBus eventBus,
-			ContactId contactId,
-			TransportId transportId,
-			long maxLatency,
-			StreamWriter streamWriter,
-			SyncRecordWriter recordWriter,
-			DeferredSendHandler deferredSendHandler,
-			long capacity) {
-		super(db, eventBus, contactId, transportId, maxLatency, streamWriter,
-				recordWriter);
-		this.deferredSendHandler = deferredSendHandler;
-		this.initialCapacity = capacity;
-	}
-
-	@Override
-	void sendAcks() throws DbException, IOException {
-		while (!isInterrupted()) {
-			Collection<MessageId> idsToAck = loadMessageIdsToAck();
-			if (idsToAck.isEmpty()) break;
-			recordWriter.writeAck(new Ack(idsToAck));
-			deferredSendHandler.onAckSent(idsToAck);
-			LOG.info("Sent ack");
-		}
-	}
-
-	private Collection<MessageId> loadMessageIdsToAck() throws DbException {
-		long idCapacity = (getRemainingCapacity() - RECORD_HEADER_BYTES)
-				/ MessageId.LENGTH;
-		if (idCapacity <= 0) return emptyList(); // Out of capacity
-		int maxMessageIds = (int) min(idCapacity, MAX_MESSAGE_IDS);
-		Collection<MessageId> ids = db.transactionWithResult(true, txn ->
-				db.getMessagesToAck(txn, contactId, maxMessageIds));
-		if (LOG.isLoggable(INFO)) {
-			LOG.info(ids.size() + " messages to ack");
-		}
-		return ids;
-	}
-
-	private long getRemainingCapacity() {
-		return initialCapacity - recordWriter.getBytesWritten();
-	}
-
-	@Override
-	void sendMessages() throws DbException, IOException {
-		for (MessageId m : loadMessageIdsToSend()) {
-			if (isInterrupted()) break;
-			// Defer marking the message as sent
-			Message message = db.transactionWithNullableResult(true, txn ->
-					db.getMessageToSend(txn, contactId, m, maxLatency, false));
-			if (message == null) continue; // No longer shared
-			recordWriter.writeMessage(message);
-			deferredSendHandler.onMessageSent(m);
-			LOG.info("Sent message");
-		}
-	}
-
-	private Collection<MessageId> loadMessageIdsToSend() throws DbException {
-		long capacity = getRemainingCapacity();
-		if (capacity < RECORD_HEADER_BYTES + MESSAGE_HEADER_LENGTH) {
-			return emptyList(); // Out of capacity
-		}
-		Collection<MessageId> ids = db.transactionWithResult(true, txn ->
-				db.getMessagesToSend(txn, contactId, capacity, maxLatency));
-		if (LOG.isLoggable(INFO)) {
-			LOG.info(ids.size() + " messages to send");
-		}
-		return ids;
-	}
-
-}

bramble-core/src/main/java/org/briarproject/bramble/sync/SimplexOutgoingSession.java

@@ -3,6 +3,7 @@ package org.briarproject.bramble.sync;
 import org.briarproject.bramble.api.contact.ContactId;
 import org.briarproject.bramble.api.contact.event.ContactRemovedEvent;
 import org.briarproject.bramble.api.db.DatabaseComponent;
+import org.briarproject.bramble.api.db.DatabaseExecutor;
 import org.briarproject.bramble.api.db.DbException;
 import org.briarproject.bramble.api.event.Event;
 import org.briarproject.bramble.api.event.EventBus;
@@ -12,10 +13,9 @@ import org.briarproject.bramble.api.lifecycle.event.LifecycleEvent;
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.bramble.api.plugin.TransportId;
 import org.briarproject.bramble.api.plugin.event.TransportInactiveEvent;
-import org.briarproject.bramble.api.record.Record;
 import org.briarproject.bramble.api.sync.Ack;
 import org.briarproject.bramble.api.sync.Message;
-import org.briarproject.bramble.api.sync.SyncConstants;
+import org.briarproject.bramble.api.sync.MessageId;
 import org.briarproject.bramble.api.sync.SyncRecordWriter;
 import org.briarproject.bramble.api.sync.SyncSession;
 import org.briarproject.bramble.api.sync.Versions;
@@ -23,7 +23,15 @@ import org.briarproject.bramble.api.sync.event.CloseSyncConnectionsEvent;
 import org.briarproject.bramble.api.transport.StreamWriter;
 
 import java.io.IOException;
+import java.util.ArrayList;
 import java.util.Collection;
+import java.util.Iterator;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.Executor;
+import java.util.concurrent.LinkedBlockingQueue;
+import java.util.concurrent.atomic.AtomicInteger;
 import java.util.logging.Logger;
 
 import javax.annotation.concurrent.ThreadSafe;
@@ -32,9 +40,8 @@ import static java.util.logging.Level.INFO;
 import static java.util.logging.Level.WARNING;
 import static java.util.logging.Logger.getLogger;
 import static org.briarproject.bramble.api.lifecycle.LifecycleManager.LifecycleState.STOPPING;
-import static org.briarproject.bramble.api.record.Record.RECORD_HEADER_BYTES;
+import static org.briarproject.bramble.api.record.Record.MAX_RECORD_PAYLOAD_BYTES;
 import static org.briarproject.bramble.api.sync.SyncConstants.MAX_MESSAGE_IDS;
-import static org.briarproject.bramble.api.sync.SyncConstants.MAX_MESSAGE_LENGTH;
 import static org.briarproject.bramble.api.sync.SyncConstants.SUPPORTED_VERSIONS;
 import static org.briarproject.bramble.util.LogUtils.logException;
 
@@ -50,40 +57,38 @@ class SimplexOutgoingSession implements SyncSession, EventListener {
 	private static final Logger LOG =
 			getLogger(SimplexOutgoingSession.class.getName());
 
-	/**
+	private static final ThrowingRunnable<IOException> CLOSE = () -> {
-	 * The batch capacity must be at least {@link Record#RECORD_HEADER_BYTES}
+	};
-	 * + {@link SyncConstants#MAX_MESSAGE_LENGTH} to ensure that maximum-size
-	 * messages can be selected for transmission. Larger batches will mean
-	 * fewer round-trips between the DB and the output stream, but each
-	 * round-trip will block the DB for longer.
-	 */
-	static final int BATCH_CAPACITY =
-			(RECORD_HEADER_BYTES + MAX_MESSAGE_LENGTH) * 2;
 
-	protected final DatabaseComponent db;
+	private final DatabaseComponent db;
-	protected final EventBus eventBus;
+	private final Executor dbExecutor;
-	protected final ContactId contactId;
+	private final EventBus eventBus;
-	protected final TransportId transportId;
+	private final ContactId contactId;
-	protected final long maxLatency;
+	private final TransportId transportId;
-	protected final StreamWriter streamWriter;
+	private final long maxLatency;
-	protected final SyncRecordWriter recordWriter;
+	private final boolean eager;
+	private final StreamWriter streamWriter;
+	private final SyncRecordWriter recordWriter;
+	private final AtomicInteger outstandingQueries;
+	private final BlockingQueue<ThrowingRunnable<IOException>> writerTasks;
 
 	private volatile boolean interrupted = false;
 
-	SimplexOutgoingSession(DatabaseComponent db,
+	SimplexOutgoingSession(DatabaseComponent db, Executor dbExecutor,
-			EventBus eventBus,
+			EventBus eventBus, ContactId contactId, TransportId transportId,
-			ContactId contactId,
+			long maxLatency, boolean eager, StreamWriter streamWriter,
-			TransportId transportId,
-			long maxLatency,
-			StreamWriter streamWriter,
 			SyncRecordWriter recordWriter) {
 		this.db = db;
+		this.dbExecutor = dbExecutor;
 		this.eventBus = eventBus;
 		this.contactId = contactId;
 		this.transportId = transportId;
 		this.maxLatency = maxLatency;
+		this.eager = eager;
 		this.streamWriter = streamWriter;
 		this.recordWriter = recordWriter;
+		outstandingQueries = new AtomicInteger(2); // One per type of record
+		writerTasks = new LinkedBlockingQueue<>();
 	}
 
 	@IoExecutor
@@ -93,13 +98,22 @@ class SimplexOutgoingSession implements SyncSession, EventListener {
 		try {
 			// Send our supported protocol versions
 			recordWriter.writeVersions(new Versions(SUPPORTED_VERSIONS));
+			// Start a query for each type of record
+			dbExecutor.execute(this::generateAck);
+			if (eager) dbExecutor.execute(this::loadUnackedMessageIds);
+			else dbExecutor.execute(this::generateBatch);
+			// Write records until interrupted or no more records to write
 			try {
-				sendAcks();
+				while (!interrupted) {
-				sendMessages();
+					ThrowingRunnable<IOException> task = writerTasks.take();
-			} catch (DbException e) {
+					if (task == CLOSE) break;
-				logException(LOG, WARNING, e);
+					task.run();
+				}
+				streamWriter.sendEndOfStream();
+			} catch (InterruptedException e) {
+				LOG.info("Interrupted while waiting for a record to write");
+				Thread.currentThread().interrupt();
 			}
-			streamWriter.sendEndOfStream();
 		} finally {
 			eventBus.removeListener(this);
 		}
@@ -108,10 +122,11 @@ class SimplexOutgoingSession implements SyncSession, EventListener {
 	@Override
 	public void interrupt() {
 		interrupted = true;
+		writerTasks.add(CLOSE);
 	}
 
-	boolean isInterrupted() {
+	private void decrementOutstandingQueries() {
-		return interrupted;
+		if (outstandingQueries.decrementAndGet() == 0) writerTasks.add(CLOSE);
 	}
 
 	@Override
@@ -131,33 +146,110 @@ class SimplexOutgoingSession implements SyncSession, EventListener {
 		}
 	}
 
-	void sendAcks() throws DbException, IOException {
+	@DatabaseExecutor
-		while (!isInterrupted()) if (!generateAndSendAck()) break;
+	private void loadUnackedMessageIds() {
+		if (interrupted) return;
+		try {
+			Map<MessageId, Integer> ids = db.transactionWithResult(true, txn ->
+					db.getUnackedMessagesToSend(txn, contactId));
+			if (LOG.isLoggable(INFO)) {
+				LOG.info(ids.size() + " unacked messages to send");
+			}
+			if (ids.isEmpty()) decrementOutstandingQueries();
+			else dbExecutor.execute(() -> generateEagerBatch(ids));
+		} catch (DbException e) {
+			logException(LOG, WARNING, e);
+			interrupt();
+		}
 	}
 
-	private boolean generateAndSendAck() throws DbException, IOException {
+	@DatabaseExecutor
-		Ack a = db.transactionWithNullableResult(false, txn ->
+	private void generateEagerBatch(Map<MessageId, Integer> ids) {
-				db.generateAck(txn, contactId, MAX_MESSAGE_IDS));
+		if (interrupted) return;
-		if (LOG.isLoggable(INFO))
+		// Take some message IDs from `ids` to form a batch
-			LOG.info("Generated ack: " + (a != null));
+		Collection<MessageId> batchIds = new ArrayList<>();
-		if (a == null) return false; // No more acks to send
+		long totalLength = 0;
-		recordWriter.writeAck(a);
+		Iterator<Entry<MessageId, Integer>> it = ids.entrySet().iterator();
+		while (it.hasNext()) {
+			// Check whether the next message will fit in the batch
+			Entry<MessageId, Integer> e = it.next();
+			int length = e.getValue();
+			if (totalLength + length > MAX_RECORD_PAYLOAD_BYTES) break;
+			// Add the message to the batch
+			it.remove();
+			batchIds.add(e.getKey());
+			totalLength += length;
+		}
+		if (batchIds.isEmpty()) throw new AssertionError();
+		try {
+			Collection<Message> batch =
+					db.transactionWithResult(false, txn ->
+							db.generateBatch(txn, contactId, batchIds,
+									maxLatency));
+			writerTasks.add(() -> writeEagerBatch(batch, ids));
+		} catch (DbException e) {
+			logException(LOG, WARNING, e);
+			interrupt();
+		}
+	}
+
+	@IoExecutor
+	private void writeEagerBatch(Collection<Message> batch,
+			Map<MessageId, Integer> ids) throws IOException {
+		if (interrupted) return;
+		for (Message m : batch) recordWriter.writeMessage(m);
+		LOG.info("Sent eager batch");
+		if (ids.isEmpty()) decrementOutstandingQueries();
+		else dbExecutor.execute(() -> generateEagerBatch(ids));
+	}
+
+	@DatabaseExecutor
+	private void generateAck() {
+		if (interrupted) return;
+		try {
+			Ack a = db.transactionWithNullableResult(false, txn ->
+					db.generateAck(txn, contactId, MAX_MESSAGE_IDS));
+			if (LOG.isLoggable(INFO))
+				LOG.info("Generated ack: " + (a != null));
+			if (a == null) decrementOutstandingQueries();
+			else writerTasks.add(() -> writeAck(a));
+		} catch (DbException e) {
+			logException(LOG, WARNING, e);
+			interrupt();
+		}
+	}
+
+	@IoExecutor
+	private void writeAck(Ack ack) throws IOException {
+		if (interrupted) return;
+		recordWriter.writeAck(ack);
 		LOG.info("Sent ack");
-		return true;
+		dbExecutor.execute(this::generateAck);
 	}
 
-	void sendMessages() throws DbException, IOException {
+	@DatabaseExecutor
-		while (!isInterrupted()) if (!generateAndSendBatch()) break;
+	private void generateBatch() {
+		if (interrupted) return;
+		try {
+			Collection<Message> b =
+					db.transactionWithNullableResult(false, txn ->
+							db.generateBatch(txn, contactId,
+									MAX_RECORD_PAYLOAD_BYTES, maxLatency));
+			if (LOG.isLoggable(INFO))
+				LOG.info("Generated batch: " + (b != null));
+			if (b == null) decrementOutstandingQueries();
+			else writerTasks.add(() -> writeBatch(b));
+		} catch (DbException e) {
+			logException(LOG, WARNING, e);
+			interrupt();
+		}
 	}
 
-	private boolean generateAndSendBatch() throws DbException, IOException {
+	@IoExecutor
-		Collection<Message> b = db.transactionWithNullableResult(false, txn ->
+	private void writeBatch(Collection<Message> batch) throws IOException {
-				db.generateBatch(txn, contactId, BATCH_CAPACITY, maxLatency));
+		if (interrupted) return;
-		if (LOG.isLoggable(INFO))
+		for (Message m : batch) recordWriter.writeMessage(m);
-			LOG.info("Generated batch: " + (b != null));
-		if (b == null) return false; // No more messages to send
-		for (Message m : b) recordWriter.writeMessage(m);
 		LOG.info("Sent batch");
-		return true;
+		dbExecutor.execute(this::generateBatch);
 	}
 }

bramble-core/src/main/java/org/briarproject/bramble/sync/SyncRecordWriterImpl.java

@@ -85,9 +85,4 @@ class SyncRecordWriterImpl implements SyncRecordWriter {
 	public void flush() throws IOException {
 		writer.flush();
 	}
-
-	@Override
-	public long getBytesWritten() {
-		return writer.getBytesWritten();
-	}
 }

bramble-core/src/main/java/org/briarproject/bramble/sync/SyncSessionFactoryImpl.java

@@ -64,13 +64,8 @@ class SyncSessionFactoryImpl implements SyncSessionFactory {
 		OutputStream out = streamWriter.getOutputStream();
 		SyncRecordWriter recordWriter =
 				recordWriterFactory.createRecordWriter(out);
-		if (eager) {
+		return new SimplexOutgoingSession(db, dbExecutor, eventBus, c, t,
-			return new EagerSimplexOutgoingSession(db, eventBus, c, t,
+				maxLatency, eager, streamWriter, recordWriter);
-					maxLatency, streamWriter, recordWriter);
-		} else {
-			return new SimplexOutgoingSession(db, eventBus, c, t,
-					maxLatency, streamWriter, recordWriter);
-		}
 	}
 
 	@Override

bramble-core/src/main/java/org/briarproject/bramble/sync/validation/ValidationManagerImpl.java

@@ -233,9 +233,6 @@ class ValidationManagerImpl implements ValidationManager, Service,
 		if (v == null) {
 			if (LOG.isLoggable(WARNING)) LOG.warning("No validator for " + cv);
 		} else {
-			if (LOG.isLoggable(INFO)) {
-				LOG.info("Validating message for " + cv.getClientId());
-			}
 			try {
 				MessageContext context = v.validateMessage(m, g);
 				storeMessageContextAsync(m, g.getClientId(),
@@ -326,9 +323,6 @@ class ValidationManagerImpl implements ValidationManager, Service,
 		ClientMajorVersion cv = new ClientMajorVersion(c, majorVersion);
 		IncomingMessageHook hook = hooks.get(cv);
 		if (hook == null) return ACCEPT_DO_NOT_SHARE;
-		if (LOG.isLoggable(INFO)) {
-			LOG.info("Delivering message for " + c);
-		}
 		try {
 			return hook.incomingMessage(txn, m, meta);
 		} catch (DbException e) {

bramble-core/src/main/java/org/briarproject/bramble/system/TaskSchedulerImpl.java

@@ -1,6 +1,5 @@
 package org.briarproject.bramble.system;
 
-import org.briarproject.bramble.api.Cancellable;
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.bramble.api.system.TaskScheduler;
 

bramble-core/src/main/resources/bridges

@@ -8,23 +8,19 @@ d Bridge obfs4 193.11.166.194:27015 2D82C2E354D531A68469ADF7F878FA6060C6BACA cer
 d Bridge obfs4 193.11.166.194:27020 86AC7B8D430DAC4117E9F42C9EAED18133863AAF cert=0LDeJH4JzMDtkJJrFphJCiPqKx7loozKN7VNfuukMGfHO0Z8OGdzHVkhVAOfo1mUdv9cMg iat-mode=0
 d Bridge obfs4 193.11.166.194:27025 1AE2C08904527FEA90C4C4F8C1083EA59FBC6FAF cert=ItvYZzW5tn6v3G4UnQa6Qz04Npro6e81AP70YujmK/KXwDFPTs3aHXcHp4n8Vt6w/bv8cA iat-mode=0
 d Bridge obfs4 209.148.46.65:443 74FAD13168806246602538555B5521A0383A1875 cert=ssH+9rP8dG2NLDN2XuFw63hIO/9MNNinLmxQDpVa+7kTOa9/m+tGWT1SmSYpQ9uTBGa6Hw iat-mode=0
-d Bridge obfs4 146.57.248.225:22 10A6CD36A537FCE513A322361547444B393989F0 cert=K1gDtDAIcUfeLqbstggjIw2rtgIKqdIhUlHp82XRqNSq/mtAjp1BIC9vHKJ2FAEpGssTPw iat-mode=0
-d Bridge obfs4 45.145.95.6:27015 C5B7CD6946FF10C5B3E89691A7D3F2C122D2117C cert=TD7PbUO0/0k6xYHMPW3vJxICfkMZNdkRrb63Zhl5j9dW3iRGiCx0A7mPhe5T2EDzQ35+Zw iat-mode=0
 d Bridge obfs4 51.222.13.177:80 5EDAC3B810E12B01F6FD8050D2FD3E277B289A08 cert=2uplIpLQ0q9+0qMFrK5pkaYRDOe460LL9WHBvatgkuRr/SL31wBOEupaMMJ6koRE6Ld0ew iat-mode=0
 n Bridge obfs4 46.226.107.197:10300 A38FD6BDFD902882F5F5B9B7CCC95602A20B0BC4 cert=t8tA9q2AeGlmp/dO6oW9bkY5RqqmvqjArCEM9wjJoDnk6XtnaejkF0JTA7VamdyOzcvuBg iat-mode=0
 n Bridge obfs4 185.181.11.86:443 A961609729E7FDF520B4E81F1F1B8FA1045285C3 cert=e5faG9Zk4Ni+e7z2YgGfevyKPQlMvkVGi4ublSsHYjaBovKeNXpOhbeFxzbZZoAzxAoGUQ iat-mode=0
 n Bridge obfs4 85.242.211.221:8042 A36A938DD7FDB8BACC846BA326EE0BA0D89A9252 cert=1AN6Pt1eFca3Y/WYD2TGAU3Al9cO4eouXE9SX63s66Z/ks3tVmgQ5GeXi1B5DOvx6Il7Zw iat-mode=0
+n Bridge obfs4 172.105.22.69:80 CBD17B33192A879433AB37C9E142541BD3459ABD cert=rk5YmpKypLsjlS4tjkYaZNBweYMa5tWQRhZ8Q2WRleNOgrhSceKo59BA8kp6kVfaMPXnSw iat-mode=0
+n Bridge obfs4 46.128.93.192:7346 5D28B8E1D117B8720D56A8513CF32509DCA1D84F cert=ED6tZP50eF0vno09F5gFvoWTMdcWFEX2FtwXOUYRevjzKg30/y701f61Vycnh6HO9gkaMw iat-mode=0
 n Bridge obfs4 74.104.165.202:9002 EF432018A6AA5D970B2F84E39CD30A147030141C cert=PhppfUusY85dHGvWtGTybZ1fED4DtbHmALkNMIOIYrAz1B4xN7/2a5gyiZe1epju1BOHVg iat-mode=0
 n Bridge obfs4 70.34.242.31:443 7F026956402CDFF4BCBA8E11EE9C50E3FE0A2B72 cert=hP/KU7JATSfWH3HwS5Er/YLT0J+bRO3+s2fWx2yirrgf37EyrWvm/BQshoNje8WfUm6CBw iat-mode=0
+n Bridge obfs4 192.3.163.88:57145 DEB62DE9643E5956CA4FA78035B48C9BBABE7F29 cert=RMz2z9uVVrioUhx0A8xUmiftRe2RpcXiqIuDfisdIomcHDf82nzfn83X/ixGUiA4rLCAdw iat-mode=0
 n Bridge obfs4 93.95.226.151:41185 460B0CFFC0CF1D965F3DE064E08BA1915E7C916A cert=inluPzp5Jp5OzZar1eQb4dcQ/YlAj/v0kHAUCoCr3rmLt03+pVuVTjoH4mRy4+acXpn+Gw iat-mode=0
 n Bridge obfs4 120.29.217.52:5223 40FE3DB9800272F9CDC76422F8ED7883280EE96D cert=/71PS4l8c/XJ4DIItlH9xMqNvPFg2RUTrHvPlQWh48u5et8h/yyyjCcYphUadDsfBWpaGQ iat-mode=0
-n Bridge obfs4 83.97.179.29:1199 D83068BFAA28E71DB024B786E1E803BE14257127 cert=IduGtt05tM59Xmvo0oVNWgIRgY4OGPJjFP+y2oa6RMDHQBL/GRyFOOgX70iiazNAIJNkPw iat-mode=0
+v Bridge 5.45.96.40:9001 8723B591712AAA03FB92000370BD356AB4997FA7
-n Bridge obfs4 207.181.244.13:40132 37FE8D782F5DD2BAEEDAAB8257B701344676B6DD cert=f5Hbfn3ToMzH170cV8DfLly3vRynveidfOfDcbradIDtbLDX15V2yQ8eEH2CPKQJmQR2Hg iat-mode=0
-n Bridge obfs4 76.255.201.112:8888 96CF36C2ECCFB7376AB6BE905BECD2C2AE8AEFCD cert=+q0pjaiM0JMqHL/BKqCRD+pjflaw/S406eUDF7CnFgamvQW3l2HVLJhQ6uX9P8zff0PLGg iat-mode=0
-n Bridge obfs4 65.108.159.114:14174 E1AD374BA9F34BD98862D128AC54D40C7DC138AE cert=YMkxMSBN2OOd99AkJpFaEUyKkdqZgJt9oVJEgO1QnT37n/Vc2yR4nhx4k4VkPLfEP1f4eg iat-mode=0
-n Bridge obfs4 185.177.207.138:8443 53716FE26F23C8C6A71A2BC5D9D8DC64747278C7 cert=6jcYVilMEzxdsWghSrQFpYYJlkkir/GPIXw/EnddUK3S8ToVpMG8u1SwMOEdEs735RrMHw iat-mode=0
-n Bridge obfs4 176.123.2.253:1933 B855D141CE6C4DE0F7EA4AAED83EBA8373FA8191 cert=1rOoSaRagc6PPR//paIl+ukv1N+xWKCdBXMFxK0k/moEwH0lk5bURBrUDzIX35fVzaiicQ iat-mode=0
 v Bridge 135.181.113.164:54444 74AF4CCA614C454B7D3E81FF8BACD78CEBC7D7DE
-v Bridge 92.243.15.235:9001 477EAD3C04036B48235F1F27FC91420A286A4B7F
+v Bridge 152.44.197.85:10507 FF07DF6B4720DA4C50F1A025662D50916D6223F6
-v Bridge 77.96.91.103:443 ED000A75B79A58F1D83A4D1675C2A9395B71BE8E
+v Bridge 209.216.78.21:443 C870D381E7264CDB83BAEEBF074804808CCCDB8D
 m Bridge meek_lite 192.0.2.2:2 97700DFE9F483596DDA6264C4D7DF7641E1E39CE url=https://meek.azureedge.net/ front=ajax.aspnetcdn.com

bramble-core/src/test/java/org/briarproject/bramble/client/ClientHelperImplTest.java

@@ -21,10 +21,9 @@ import org.briarproject.bramble.api.db.Metadata;
 import org.briarproject.bramble.api.db.Transaction;
 import org.briarproject.bramble.api.identity.Author;
 import org.briarproject.bramble.api.identity.AuthorFactory;
-import org.briarproject.bramble.api.mailbox.MailboxProperties;
+import org.briarproject.bramble.api.mailbox.MailboxAuthToken;
-import org.briarproject.bramble.api.mailbox.MailboxUpdate;
+import org.briarproject.bramble.api.mailbox.MailboxFolderId;
-import org.briarproject.bramble.api.mailbox.MailboxUpdateWithMailbox;
+import org.briarproject.bramble.api.mailbox.MailboxPropertiesUpdate;
-import org.briarproject.bramble.api.mailbox.MailboxVersion;
 import org.briarproject.bramble.api.sync.GroupId;
 import org.briarproject.bramble.api.sync.Message;
 import org.briarproject.bramble.api.sync.MessageFactory;
@@ -42,26 +41,24 @@ import java.util.HashMap;
 import java.util.Map;
 import java.util.Random;
 
-import static java.util.Collections.singletonList;
 import static org.briarproject.bramble.api.identity.AuthorConstants.MAX_AUTHOR_NAME_LENGTH;
 import static org.briarproject.bramble.api.identity.AuthorConstants.MAX_PUBLIC_KEY_LENGTH;
 import static org.briarproject.bramble.api.identity.AuthorConstants.MAX_SIGNATURE_LENGTH;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.PROP_KEY_AUTHTOKEN;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.PROP_KEY_AUTHTOKEN;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.PROP_KEY_INBOXID;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.PROP_KEY_INBOXID;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.PROP_KEY_ONION;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.PROP_KEY_ONION;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.PROP_KEY_OUTBOXID;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.PROP_KEY_OUTBOXID;
 import static org.briarproject.bramble.test.TestUtils.getAuthor;
-import static org.briarproject.bramble.test.TestUtils.getMailboxProperties;
 import static org.briarproject.bramble.test.TestUtils.getMessage;
 import static org.briarproject.bramble.test.TestUtils.getRandomBytes;
 import static org.briarproject.bramble.test.TestUtils.getRandomId;
 import static org.briarproject.bramble.test.TestUtils.getSignaturePrivateKey;
 import static org.briarproject.bramble.test.TestUtils.getSignaturePublicKey;
-import static org.briarproject.bramble.test.TestUtils.mailboxUpdateEqual;
+import static org.briarproject.bramble.test.TestUtils.mailboxPropertiesUpdateEqual;
 import static org.briarproject.bramble.util.StringUtils.getRandomString;
 import static org.junit.Assert.assertArrayEquals;
 import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
@@ -98,31 +95,25 @@ public class ClientHelperImplTest extends BrambleMockTestCase {
 			messageFactory, bdfReaderFactory, bdfWriterFactory, metadataParser,
 			metadataEncoder, cryptoComponent, authorFactory);
 
-	private final MailboxUpdateWithMailbox validMailboxUpdateWithMailbox;
+	private final MailboxPropertiesUpdate validMailboxPropsUpdate;
-	private final BdfList emptyClientSupports;
-	private final BdfList someClientSupports;
-	private final BdfList emptyServerSupports;
-	private final BdfList someServerSupports;
 
 	public ClientHelperImplTest() {
-		emptyClientSupports = new BdfList();
+		validMailboxPropsUpdate = new MailboxPropertiesUpdate(
-		someClientSupports = BdfList.of(BdfList.of(1, 0));
+				"pg6mmjiyjmcrsslvykfwnntlaru7p5svn6y2ymmju6nubxndf4pscryd",
-		emptyServerSupports = new BdfList();
+				new MailboxAuthToken(getRandomId()),
-		someServerSupports = BdfList.of(BdfList.of(1, 0));
+				new MailboxFolderId(getRandomId()),
-		validMailboxUpdateWithMailbox = new MailboxUpdateWithMailbox(
+				new MailboxFolderId(getRandomId()));
-				singletonList(new MailboxVersion(1, 0)),
-				getMailboxProperties(false,
-						singletonList(new MailboxVersion(1, 0))));
 	}
 
-	private BdfDictionary getValidMailboxUpdateWithMailboxDict() {
+	private BdfDictionary getValidMailboxPropsUpdateDict() {
 		BdfDictionary dict = new BdfDictionary();
-		MailboxProperties properties =
+		dict.put(PROP_KEY_ONION, validMailboxPropsUpdate.getOnion());
-				validMailboxUpdateWithMailbox.getMailboxProperties();
+		dict.put(PROP_KEY_AUTHTOKEN, validMailboxPropsUpdate.getAuthToken()
-		dict.put(PROP_KEY_ONION, properties.getOnion());
+				.getBytes());
-		dict.put(PROP_KEY_AUTHTOKEN, properties.getAuthToken());
+		dict.put(PROP_KEY_INBOXID, validMailboxPropsUpdate.getInboxId()
-		dict.put(PROP_KEY_INBOXID, properties.getInboxId());
+				.getBytes());
-		dict.put(PROP_KEY_OUTBOXID, properties.getOutboxId());
+		dict.put(PROP_KEY_OUTBOXID, validMailboxPropsUpdate.getOutboxId()
+				.getBytes());
 		return dict;
 	}
 
@@ -555,151 +546,94 @@ public class ClientHelperImplTest extends BrambleMockTestCase {
 		}});
 	}
 
-	@Test(expected = FormatException.class)
+	@Test
-	public void testRejectsMailboxUpdateWithEmptyClientSupports()
+	public void testParseEmptyMailboxPropsUpdate() throws Exception {
-			throws Exception {
 		BdfDictionary emptyPropsDict = new BdfDictionary();
-		clientHelper.parseAndValidateMailboxUpdate(emptyClientSupports,
+		MailboxPropertiesUpdate parsedProps = clientHelper
-				emptyServerSupports, emptyPropsDict
+				.parseAndValidateMailboxPropertiesUpdate(emptyPropsDict);
-		);
+		assertNull(parsedProps);
 	}
 
 	@Test
-	public void testParseMailboxUpdateNoMailbox() throws Exception {
+	public void testParseValidMailboxPropsUpdate() throws Exception {
-		BdfDictionary emptyPropsDict = new BdfDictionary();
+		MailboxPropertiesUpdate parsedProps = clientHelper
-		MailboxUpdate parsedUpdate = clientHelper.parseAndValidateMailboxUpdate(
+				.parseAndValidateMailboxPropertiesUpdate(
-				someClientSupports, emptyServerSupports, emptyPropsDict);
+						getValidMailboxPropsUpdateDict());
-		assertFalse(parsedUpdate.hasMailbox());
+		assertTrue(mailboxPropertiesUpdateEqual(validMailboxPropsUpdate,
+				parsedProps));
 	}
 
 	@Test(expected = FormatException.class)
-	public void testRejectsMailboxUpdateNoMailboxWithSomeServerSupports()
+	public void testRejectsMailboxPropsUpdateOnionNotDecodable()
 			throws Exception {
-		BdfDictionary emptyPropsDict = new BdfDictionary();
+		BdfDictionary propsDict = getValidMailboxPropsUpdateDict();
-		clientHelper.parseAndValidateMailboxUpdate(someClientSupports,
-				someServerSupports, emptyPropsDict);
-	}
-
-	@Test(expected = FormatException.class)
-	public void testRejectsMailboxUpdateShortSupports() throws Exception {
-		clientHelper.parseAndValidateMailboxUpdate(BdfList.of(BdfList.of(1)),
-				emptyServerSupports, new BdfDictionary());
-	}
-
-	@Test(expected = FormatException.class)
-	public void testRejectsMailboxUpdateLongSupports() throws Exception {
-		clientHelper.parseAndValidateMailboxUpdate(
-				BdfList.of(BdfList.of(1, 0, 0)), emptyServerSupports,
-				new BdfDictionary());
-	}
-
-	@Test(expected = FormatException.class)
-	public void testRejectsMailboxUpdateNonIntSupports() throws Exception {
-		clientHelper.parseAndValidateMailboxUpdate(
-				BdfList.of(BdfList.of(1, "0")), emptyServerSupports,
-				new BdfDictionary()
-		);
-	}
-
-	@Test(expected = FormatException.class)
-	public void testRejectsMailboxUpdateNonListSupports() throws Exception {
-		clientHelper.parseAndValidateMailboxUpdate(
-				BdfList.of("non-list"), emptyServerSupports,
-				new BdfDictionary());
-	}
-
-	@Test
-	public void testParseValidMailboxUpdateWithMailbox() throws Exception {
-		MailboxUpdate parsedUpdate = clientHelper.parseAndValidateMailboxUpdate(
-				someClientSupports, someServerSupports,
-				getValidMailboxUpdateWithMailboxDict());
-		assertTrue(
-				mailboxUpdateEqual(validMailboxUpdateWithMailbox,
-						parsedUpdate));
-	}
-
-	@Test(expected = FormatException.class)
-	public void rejectsMailboxUpdateWithEmptyServerSupports() throws Exception {
-		clientHelper.parseAndValidateMailboxUpdate(someClientSupports,
-				emptyServerSupports, getValidMailboxUpdateWithMailboxDict());
-	}
-
-	@Test(expected = FormatException.class)
-	public void testRejectsMailboxUpdateOnionNotDecodable() throws Exception {
-		BdfDictionary propsDict = getValidMailboxUpdateWithMailboxDict();
 		String badOnion = "!" + propsDict.getString(PROP_KEY_ONION)
 				.substring(1);
 		propsDict.put(PROP_KEY_ONION, badOnion);
-		clientHelper.parseAndValidateMailboxUpdate(someClientSupports,
+		clientHelper.parseAndValidateMailboxPropertiesUpdate(propsDict);
-				emptyServerSupports, propsDict);
 	}
 
 	@Test(expected = FormatException.class)
-	public void testRejectsMailboxUpdateOnionWrongLength() throws Exception {
+	public void testRejectsMailboxPropsUpdateOnionWrongLength()
-		BdfDictionary propsDict = getValidMailboxUpdateWithMailboxDict();
+			throws Exception {
+		BdfDictionary propsDict = getValidMailboxPropsUpdateDict();
 		String tooLongOnion = propsDict.getString(PROP_KEY_ONION) + "!";
 		propsDict.put(PROP_KEY_ONION, tooLongOnion);
-		clientHelper.parseAndValidateMailboxUpdate(someClientSupports,
+		clientHelper.parseAndValidateMailboxPropertiesUpdate(propsDict);
-				emptyServerSupports, propsDict
-		);
 	}
 
 	@Test(expected = FormatException.class)
-	public void testRejectsMailboxUpdateInboxIdWrongLength() throws Exception {
+	public void testRejectsMailboxPropsUpdateInboxIdWrongLength()
-		BdfDictionary propsDict = getValidMailboxUpdateWithMailboxDict();
-		propsDict.put(PROP_KEY_INBOXID, getRandomBytes(UniqueId.LENGTH + 1));
-		clientHelper.parseAndValidateMailboxUpdate(someClientSupports,
-				someServerSupports, propsDict);
-	}
-
-	@Test(expected = FormatException.class)
-	public void testRejectsMailboxUpdateOutboxIdWrongLength() throws Exception {
-		BdfDictionary propsDict = getValidMailboxUpdateWithMailboxDict();
-		propsDict.put(PROP_KEY_OUTBOXID, getRandomBytes(UniqueId.LENGTH + 1));
-		clientHelper.parseAndValidateMailboxUpdate(someClientSupports,
-				someServerSupports, propsDict);
-	}
-
-	@Test(expected = FormatException.class)
-	public void testRejectsMailboxUpdateAuthTokenWrongLength()
 			throws Exception {
-		BdfDictionary propsDict = getValidMailboxUpdateWithMailboxDict();
+		BdfDictionary propsDict = getValidMailboxPropsUpdateDict();
+		propsDict.put(PROP_KEY_INBOXID, getRandomBytes(UniqueId.LENGTH + 1));
+		clientHelper.parseAndValidateMailboxPropertiesUpdate(propsDict);
+	}
+
+	@Test(expected = FormatException.class)
+	public void testRejectsMailboxPropsUpdateOutboxIdWrongLength()
+			throws Exception {
+		BdfDictionary propsDict = getValidMailboxPropsUpdateDict();
+		propsDict.put(PROP_KEY_OUTBOXID, getRandomBytes(UniqueId.LENGTH + 1));
+		clientHelper.parseAndValidateMailboxPropertiesUpdate(propsDict);
+	}
+
+	@Test(expected = FormatException.class)
+	public void testRejectsMailboxPropsUpdateAuthTokenWrongLength()
+			throws Exception {
+		BdfDictionary propsDict = getValidMailboxPropsUpdateDict();
 		propsDict.put(PROP_KEY_AUTHTOKEN, getRandomBytes(UniqueId.LENGTH + 1));
-		clientHelper.parseAndValidateMailboxUpdate(someClientSupports,
+		clientHelper.parseAndValidateMailboxPropertiesUpdate(propsDict);
-				someServerSupports, propsDict);
 	}
 
 	@Test(expected = FormatException.class)
-	public void testRejectsMailboxUpdateMissingOnion() throws Exception {
+	public void testRejectsMailboxPropsUpdateMissingOnion() throws Exception {
-		BdfDictionary propsDict = getValidMailboxUpdateWithMailboxDict();
+		BdfDictionary propsDict = getValidMailboxPropsUpdateDict();
 		propsDict.remove(PROP_KEY_ONION);
-		clientHelper.parseAndValidateMailboxUpdate(someClientSupports,
+		clientHelper.parseAndValidateMailboxPropertiesUpdate(propsDict);
-				someServerSupports, propsDict
-		);
 	}
 
 	@Test(expected = FormatException.class)
-	public void testRejectsMailboxUpdateMissingAuthToken() throws Exception {
+	public void testRejectsMailboxPropsUpdateMissingAuthToken()
-		BdfDictionary propsDict = getValidMailboxUpdateWithMailboxDict();
+			throws Exception {
+		BdfDictionary propsDict = getValidMailboxPropsUpdateDict();
 		propsDict.remove(PROP_KEY_AUTHTOKEN);
-		clientHelper.parseAndValidateMailboxUpdate(someClientSupports,
+		clientHelper.parseAndValidateMailboxPropertiesUpdate(propsDict);
-				someServerSupports, propsDict);
 	}
 
 	@Test(expected = FormatException.class)
-	public void testRejectsMailboxUpdateMissingInboxId() throws Exception {
+	public void testRejectsMailboxPropsUpdateMissingInboxId() throws Exception {
-		BdfDictionary propsDict = getValidMailboxUpdateWithMailboxDict();
+		BdfDictionary propsDict = getValidMailboxPropsUpdateDict();
 		propsDict.remove(PROP_KEY_INBOXID);
-		clientHelper.parseAndValidateMailboxUpdate(someClientSupports,
+		clientHelper.parseAndValidateMailboxPropertiesUpdate(propsDict);
-				someServerSupports, propsDict);
 	}
 
 	@Test(expected = FormatException.class)
-	public void testRejectsMailboxUpdateMissingOutboxId() throws Exception {
+	public void testRejectsMailboxPropsUpdateMissingOutboxId()
-		BdfDictionary propsDict = getValidMailboxUpdateWithMailboxDict();
+			throws Exception {
+		BdfDictionary propsDict = getValidMailboxPropsUpdateDict();
 		propsDict.remove(PROP_KEY_OUTBOXID);
-		clientHelper.parseAndValidateMailboxUpdate(someClientSupports,
+		clientHelper.parseAndValidateMailboxPropertiesUpdate(propsDict);
-				someServerSupports, propsDict);
 	}
 
 }

bramble-core/src/test/java/org/briarproject/bramble/db/DatabaseComponentImplTest.java

@@ -72,7 +72,6 @@ import static java.util.Collections.emptyMap;
 import static java.util.Collections.singletonList;
 import static java.util.concurrent.TimeUnit.HOURS;
 import static org.briarproject.bramble.api.db.DatabaseComponent.TIMER_NOT_STARTED;
-import static org.briarproject.bramble.api.record.Record.RECORD_HEADER_BYTES;
 import static org.briarproject.bramble.api.sync.Group.Visibility.INVISIBLE;
 import static org.briarproject.bramble.api.sync.Group.Visibility.SHARED;
 import static org.briarproject.bramble.api.sync.Group.Visibility.VISIBLE;
@@ -95,15 +94,11 @@ import static org.briarproject.bramble.test.TestUtils.getTransportId;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
 public class DatabaseComponentImplTest extends BrambleMockTestCase {
 
-	private static final int BATCH_CAPACITY =
-			(RECORD_HEADER_BYTES + MAX_MESSAGE_LENGTH) * 2;
-
 	@SuppressWarnings("unchecked")
 	private final Database<Object> database = context.mock(Database.class);
 	private final ShutdownManager shutdownManager =
@@ -303,11 +298,11 @@ public class DatabaseComponentImplTest extends BrambleMockTestCase {
 			throws Exception {
 		context.checking(new Expectations() {{
 			// Check whether the contact is in the DB (which it's not)
-			exactly(25).of(database).startTransaction();
+			exactly(19).of(database).startTransaction();
 			will(returnValue(txn));
-			exactly(25).of(database).containsContact(txn, contactId);
+			exactly(19).of(database).containsContact(txn, contactId);
 			will(returnValue(false));
-			exactly(25).of(database).abortTransaction(txn);
+			exactly(19).of(database).abortTransaction(txn);
 		}});
 		DatabaseComponent db = createDatabaseComponent(database, eventBus,
 				eventExecutor, shutdownManager);
@@ -361,39 +356,6 @@ public class DatabaseComponentImplTest extends BrambleMockTestCase {
 			// Expected
 		}
 
-		try {
-			db.transaction(false, transaction ->
-					db.getMessageToSend(transaction, contactId, messageId, 123,
-							true));
-			fail();
-		} catch (NoSuchContactException expected) {
-			// Expected
-		}
-
-		try {
-			db.transaction(true, transaction ->
-					db.getMessagesToAck(transaction, contactId, 123));
-			fail();
-		} catch (NoSuchContactException expected) {
-			// Expected
-		}
-
-		try {
-			db.transaction(true, transaction ->
-					db.getMessagesToSend(transaction, contactId, 123, 456));
-			fail();
-		} catch (NoSuchContactException expected) {
-			// Expected
-		}
-
-		try {
-			db.transaction(true, transaction ->
-					db.getUnackedMessagesToSend(transaction, contactId));
-			fail();
-		} catch (NoSuchContactException expected) {
-			// Expected
-		}
-
 		try {
 			db.transaction(true, transaction ->
 					db.getUnackedMessageBytesToSend(transaction, contactId));
@@ -477,15 +439,6 @@ public class DatabaseComponentImplTest extends BrambleMockTestCase {
 			// Expected
 		}
 
-		try {
-			db.transaction(false, transaction ->
-					db.setAckSent(transaction, contactId,
-							singletonList(messageId)));
-			fail();
-		} catch (NoSuchContactException expected) {
-			// Expected
-		}
-
 		try {
 			db.transaction(false, transaction ->
 					db.setContactAlias(transaction, contactId, alias));
@@ -503,15 +456,6 @@ public class DatabaseComponentImplTest extends BrambleMockTestCase {
 			// Expected
 		}
 
-		try {
-			db.transaction(false, transaction ->
-					db.setMessagesSent(transaction, contactId,
-							singletonList(messageId), 123));
-			fail();
-		} catch (NoSuchContactException expected) {
-			// Expected
-		}
-
 		try {
 			db.transaction(false, transaction ->
 					db.setSyncVersions(transaction, contactId, emptyList()));
@@ -974,14 +918,12 @@ public class DatabaseComponentImplTest extends BrambleMockTestCase {
 			oneOf(database).containsContact(txn, contactId);
 			will(returnValue(true));
 			oneOf(database).getMessagesToSend(txn, contactId,
-					BATCH_CAPACITY, maxLatency);
+					MAX_MESSAGE_LENGTH * 2, maxLatency);
 			will(returnValue(ids));
-			// First message
 			oneOf(database).getMessage(txn, messageId);
 			will(returnValue(message));
 			oneOf(database).updateRetransmissionData(txn, contactId, messageId,
 					maxLatency);
-			// Second message
 			oneOf(database).getMessage(txn, messageId1);
 			will(returnValue(message1));
 			oneOf(database).updateRetransmissionData(txn, contactId, messageId1,
@@ -995,7 +937,7 @@ public class DatabaseComponentImplTest extends BrambleMockTestCase {
 
 		db.transaction(false, transaction ->
 				assertEquals(messages, db.generateBatch(transaction, contactId,
-						BATCH_CAPACITY, maxLatency)));
+						MAX_MESSAGE_LENGTH * 2, maxLatency)));
 	}
 
 	@Test
@@ -1059,14 +1001,12 @@ public class DatabaseComponentImplTest extends BrambleMockTestCase {
 			oneOf(database).containsContact(txn, contactId);
 			will(returnValue(true));
 			oneOf(database).getRequestedMessagesToSend(txn, contactId,
-					BATCH_CAPACITY, maxLatency);
+					MAX_MESSAGE_LENGTH * 2, maxLatency);
 			will(returnValue(ids));
-			// First message
 			oneOf(database).getMessage(txn, messageId);
 			will(returnValue(message));
 			oneOf(database).updateRetransmissionData(txn, contactId,
 					messageId, maxLatency);
-			// Second message
 			oneOf(database).getMessage(txn, messageId1);
 			will(returnValue(message1));
 			oneOf(database).updateRetransmissionData(txn, contactId,
@@ -1080,73 +1020,7 @@ public class DatabaseComponentImplTest extends BrambleMockTestCase {
 
 		db.transaction(false, transaction ->
 				assertEquals(messages, db.generateRequestedBatch(transaction,
-						contactId, BATCH_CAPACITY, maxLatency)));
+						contactId, MAX_MESSAGE_LENGTH * 2, maxLatency)));
-	}
-
-	@Test
-	public void testGetMessageToSendMessageNotVisible() throws Exception {
-		context.checking(new Expectations() {{
-			oneOf(database).startTransaction();
-			will(returnValue(txn));
-			oneOf(database).containsContact(txn, contactId);
-			will(returnValue(true));
-			oneOf(database).containsVisibleMessage(txn, contactId, messageId);
-			will(returnValue(false));
-			oneOf(database).commitTransaction(txn);
-		}});
-		DatabaseComponent db = createDatabaseComponent(database, eventBus,
-				eventExecutor, shutdownManager);
-
-		db.transaction(false, transaction ->
-				assertNull(db.getMessageToSend(transaction, contactId,
-						messageId, maxLatency, false)));
-	}
-
-	@Test
-	public void testGetMessageToSendMessageNotMarkedAsSent() throws Exception {
-		context.checking(new Expectations() {{
-			oneOf(database).startTransaction();
-			will(returnValue(txn));
-			oneOf(database).containsContact(txn, contactId);
-			will(returnValue(true));
-			oneOf(database).containsVisibleMessage(txn, contactId, messageId);
-			will(returnValue(true));
-			oneOf(database).getMessage(txn, messageId);
-			will(returnValue(message));
-			oneOf(database).commitTransaction(txn);
-		}});
-		DatabaseComponent db = createDatabaseComponent(database, eventBus,
-				eventExecutor, shutdownManager);
-
-		db.transaction(false, transaction ->
-				assertEquals(message, db.getMessageToSend(transaction,
-						contactId, messageId, maxLatency, false)));
-	}
-
-	@Test
-	public void testGetMessageToSendMessageMarkedAsSent() throws Exception {
-		context.checking(new Expectations() {{
-			oneOf(database).startTransaction();
-			will(returnValue(txn));
-			oneOf(database).containsContact(txn, contactId);
-			will(returnValue(true));
-			oneOf(database).containsVisibleMessage(txn, contactId, messageId);
-			will(returnValue(true));
-			oneOf(database).getMessage(txn, messageId);
-			will(returnValue(message));
-			oneOf(database).updateRetransmissionData(txn, contactId, messageId,
-					maxLatency);
-			oneOf(database).lowerRequestedFlag(txn, contactId,
-					singletonList(messageId));
-			oneOf(database).commitTransaction(txn);
-			oneOf(eventBus).broadcast(with(any(MessagesSentEvent.class)));
-		}});
-		DatabaseComponent db = createDatabaseComponent(database, eventBus,
-				eventExecutor, shutdownManager);
-
-		db.transaction(false, transaction ->
-				assertEquals(message, db.getMessageToSend(transaction,
-						contactId, messageId, maxLatency, true)));
 	}
 
 	@Test
@@ -1371,62 +1245,6 @@ public class DatabaseComponentImplTest extends BrambleMockTestCase {
 				db.receiveRequest(transaction, contactId, r));
 	}
 
-	@Test
-	public void testSetAckSent() throws Exception {
-		Collection<MessageId> acked = asList(messageId, messageId1);
-		context.checking(new Expectations() {{
-			oneOf(database).startTransaction();
-			will(returnValue(txn));
-			oneOf(database).containsContact(txn, contactId);
-			will(returnValue(true));
-			// First message is still visible to the contact - flag lowered
-			oneOf(database).containsVisibleMessage(txn, contactId, messageId);
-			will(returnValue(true));
-			// Second message is no longer visible - flag not lowered
-			oneOf(database).containsVisibleMessage(txn, contactId, messageId1);
-			will(returnValue(false));
-			oneOf(database)
-					.lowerAckFlag(txn, contactId, singletonList(messageId));
-			oneOf(database).commitTransaction(txn);
-		}});
-		DatabaseComponent db = createDatabaseComponent(database, eventBus,
-				eventExecutor, shutdownManager);
-
-		db.transaction(false, transaction ->
-				db.setAckSent(transaction, contactId, acked));
-	}
-
-	@Test
-	public void testSetMessagesSent() throws Exception {
-		long maxLatency = 123456;
-		Collection<MessageId> sent = asList(messageId, messageId1);
-		context.checking(new Expectations() {{
-			oneOf(database).startTransaction();
-			will(returnValue(txn));
-			oneOf(database).containsContact(txn, contactId);
-			will(returnValue(true));
-			// First message is still visible to the contact - mark as sent
-			oneOf(database).containsVisibleMessage(txn, contactId, messageId);
-			will(returnValue(true));
-			oneOf(database).getMessageLength(txn, messageId);
-			will(returnValue(message.getRawLength()));
-			oneOf(database).updateRetransmissionData(txn, contactId, messageId,
-					maxLatency);
-			// Second message is no longer visible - don't mark as sent
-			oneOf(database).containsVisibleMessage(txn, contactId, messageId1);
-			will(returnValue(false));
-			oneOf(database).lowerRequestedFlag(txn, contactId,
-					singletonList(messageId));
-			oneOf(database).commitTransaction(txn);
-			oneOf(eventBus).broadcast(with(any(MessagesSentEvent.class)));
-		}});
-		DatabaseComponent db = createDatabaseComponent(database, eventBus,
-				eventExecutor, shutdownManager);
-
-		db.transaction(false, transaction ->
-				db.setMessagesSent(transaction, contactId, sent, maxLatency));
-	}
-
 	@Test
 	public void testChangingVisibilityFromInvisibleToVisibleCallsListeners()
 			throws Exception {

bramble-core/src/test/java/org/briarproject/bramble/db/DatabasePerformanceTest.java

@@ -33,9 +33,7 @@ import java.util.Random;
 import java.util.logging.Logger;
 
 import static java.util.logging.Level.OFF;
-import static org.briarproject.bramble.api.record.Record.RECORD_HEADER_BYTES;
 import static org.briarproject.bramble.api.sync.SyncConstants.MAX_MESSAGE_IDS;
-import static org.briarproject.bramble.api.sync.SyncConstants.MAX_MESSAGE_LENGTH;
 import static org.briarproject.bramble.api.sync.validation.MessageState.DELIVERED;
 import static org.briarproject.bramble.test.TestUtils.deleteTestDirectory;
 import static org.briarproject.bramble.test.TestUtils.getAuthor;
@@ -99,9 +97,6 @@ public abstract class DatabasePerformanceTest extends BrambleTestCase {
 	// All our transports use a maximum latency of 30 seconds
 	private static final int MAX_LATENCY = 30 * 1000;
 
-	private static final int BATCH_CAPACITY =
-			(RECORD_HEADER_BYTES + MAX_MESSAGE_LENGTH) * 2;
-
 	protected final File testDir = getTestDirectory();
 	private final File resultsFile = new File(getTestName() + ".tsv");
 	protected final Random random = new Random();
@@ -476,7 +471,7 @@ public abstract class DatabasePerformanceTest extends BrambleTestCase {
 		benchmark(name, db -> {
 			Connection txn = db.startTransaction();
 			db.getMessagesToSend(txn, pickRandom(contacts).getId(),
-					BATCH_CAPACITY, MAX_LATENCY);
+					MAX_MESSAGE_IDS, MAX_LATENCY);
 			db.commitTransaction(txn);
 		});
 	}
@@ -527,7 +522,7 @@ public abstract class DatabasePerformanceTest extends BrambleTestCase {
 		benchmark(name, db -> {
 			Connection txn = db.startTransaction();
 			db.getRequestedMessagesToSend(txn, pickRandom(contacts).getId(),
-					BATCH_CAPACITY, MAX_LATENCY);
+					MAX_MESSAGE_IDS, MAX_LATENCY);
 			db.commitTransaction(txn);
 		});
 	}

bramble-core/src/test/java/org/briarproject/bramble/db/JdbcDatabaseTest.java

@@ -57,6 +57,7 @@ import java.util.concurrent.atomic.AtomicLong;
 
 import static java.util.Arrays.asList;
 import static java.util.Collections.emptyList;
+import static java.util.Collections.singleton;
 import static java.util.Collections.singletonList;
 import static java.util.Collections.singletonMap;
 import static java.util.concurrent.TimeUnit.SECONDS;
@@ -64,7 +65,6 @@ import static org.briarproject.bramble.api.db.DatabaseComponent.NO_CLEANUP_DEADL
 import static org.briarproject.bramble.api.db.DatabaseComponent.TIMER_NOT_STARTED;
 import static org.briarproject.bramble.api.db.Metadata.REMOVE;
 import static org.briarproject.bramble.api.identity.AuthorConstants.MAX_AUTHOR_NAME_LENGTH;
-import static org.briarproject.bramble.api.record.Record.RECORD_HEADER_BYTES;
 import static org.briarproject.bramble.api.sync.Group.Visibility.INVISIBLE;
 import static org.briarproject.bramble.api.sync.Group.Visibility.SHARED;
 import static org.briarproject.bramble.api.sync.Group.Visibility.VISIBLE;
@@ -350,14 +350,14 @@ public abstract class JdbcDatabaseTest extends BrambleTestCase {
 		// The message is sendable, but too large to send
 		assertOneMessageToSendLazily(db, txn);
 		assertOneMessageToSendEagerly(db, txn);
-		long capacity = RECORD_HEADER_BYTES + message.getRawLength() - 1;
 		Collection<MessageId> ids =
-				db.getMessagesToSend(txn, contactId, capacity, MAX_LATENCY);
+				db.getMessagesToSend(txn, contactId, message.getRawLength() - 1,
+						MAX_LATENCY);
 		assertTrue(ids.isEmpty());
 
 		// The message is just the right size to send
-		capacity = RECORD_HEADER_BYTES + message.getRawLength();
+		ids = db.getMessagesToSend(txn, contactId, message.getRawLength(),
-		ids = db.getMessagesToSend(txn, contactId, capacity, MAX_LATENCY);
+				MAX_LATENCY);
 		assertEquals(singletonList(messageId), ids);
 
 		db.commitTransaction(txn);
@@ -396,15 +396,16 @@ public abstract class JdbcDatabaseTest extends BrambleTestCase {
 		Collection<MessageId> ids = db.getMessagesToAck(txn, contactId, 1234);
 		assertEquals(asList(messageId, messageId1), ids);
 
-		// Lower the ack flag
+		// Remove both message IDs
 		db.lowerAckFlag(txn, contactId, asList(messageId, messageId1));
 
-		// No message IDs should be returned
+		// Both message IDs should have been removed
 		assertFalse(
 				db.containsAnythingToSend(txn, contactId, MAX_LATENCY, false));
 		assertFalse(
 				db.containsAnythingToSend(txn, contactId, MAX_LATENCY, true));
-		assertEquals(emptyList(), db.getMessagesToAck(txn, contactId, 1234));
+		assertEquals(emptyList(), db.getMessagesToAck(txn,
+				contactId, 1234));
 
 		// Raise the ack flag again
 		db.raiseAckFlag(txn, contactId, messageId);
@@ -2602,7 +2603,7 @@ public abstract class JdbcDatabaseTest extends BrambleTestCase {
 			Connection txn) throws Exception {
 		assertFalse(
 				db.containsAnythingToSend(txn, contactId, MAX_LATENCY, true));
-		Collection<MessageId> unacked =
+		Map<MessageId, Integer> unacked =
 				db.getUnackedMessagesToSend(txn, contactId);
 		assertTrue(unacked.isEmpty());
 		assertEquals(0, db.getUnackedMessageBytesToSend(txn, contactId));
@@ -2612,9 +2613,10 @@ public abstract class JdbcDatabaseTest extends BrambleTestCase {
 			Connection txn) throws Exception {
 		assertTrue(
 				db.containsAnythingToSend(txn, contactId, MAX_LATENCY, true));
-		Collection<MessageId> unacked =
+		Map<MessageId, Integer> unacked =
 				db.getUnackedMessagesToSend(txn, contactId);
-		assertEquals(singletonList(messageId), unacked);
+		assertEquals(singleton(messageId), unacked.keySet());
+		assertEquals(message.getRawLength(), unacked.get(messageId).intValue());
 		assertEquals(message.getRawLength(),
 				db.getUnackedMessageBytesToSend(txn, contactId));
 	}

bramble-core/src/test/java/org/briarproject/bramble/mailbox/ConnectivityCheckerImplTest.java

@@ -1,201 +0,0 @@
-package org.briarproject.bramble.mailbox;
-
-import org.briarproject.bramble.api.Cancellable;
-import org.briarproject.bramble.api.mailbox.MailboxProperties;
-import org.briarproject.bramble.api.system.Clock;
-import org.briarproject.bramble.mailbox.ConnectivityChecker.ConnectivityObserver;
-import org.briarproject.bramble.test.BrambleMockTestCase;
-import org.jmock.Expectations;
-import org.junit.Test;
-
-import javax.annotation.Nonnull;
-
-import static org.briarproject.bramble.mailbox.ConnectivityCheckerImpl.CONNECTIVITY_CHECK_FRESHNESS_MS;
-import static org.briarproject.bramble.mailbox.MailboxApi.CLIENT_SUPPORTS;
-import static org.briarproject.bramble.test.TestUtils.getMailboxProperties;
-
-public class ConnectivityCheckerImplTest extends BrambleMockTestCase {
-
-	private final Clock clock = context.mock(Clock.class);
-	private final MailboxApiCaller mailboxApiCaller =
-			context.mock(MailboxApiCaller.class);
-	private final ApiCall apiCall = context.mock(ApiCall.class);
-	private final Cancellable task = context.mock(Cancellable.class);
-	private final ConnectivityObserver observer1 =
-			context.mock(ConnectivityObserver.class, "1");
-	private final ConnectivityObserver observer2 =
-			context.mock(ConnectivityObserver.class, "2");
-
-	private final MailboxProperties properties =
-			getMailboxProperties(true, CLIENT_SUPPORTS);
-	private final long now = System.currentTimeMillis();
-
-	@Test
-	public void testFirstObserverStartsCheck() {
-		ConnectivityCheckerImpl checker = createChecker();
-
-		// When checkConnectivity() is called a check should be started
-		context.checking(new Expectations() {{
-			oneOf(clock).currentTimeMillis();
-			will(returnValue(now));
-			oneOf(mailboxApiCaller).retryWithBackoff(apiCall);
-			will(returnValue(task));
-		}});
-
-		checker.checkConnectivity(properties, observer1);
-
-		// When the check succeeds the observer should be called
-		context.checking(new Expectations() {{
-			oneOf(observer1).onConnectivityCheckSucceeded();
-		}});
-
-		checker.onConnectivityCheckSucceeded(now);
-
-		// The observer should not be called again when subsequent checks
-		// succeed
-		checker.onConnectivityCheckSucceeded(now);
-	}
-
-	@Test
-	public void testObserverIsAddedToExistingCheck() {
-		ConnectivityCheckerImpl checker = createChecker();
-
-		// When checkConnectivity() is called a check should be started
-		context.checking(new Expectations() {{
-			oneOf(clock).currentTimeMillis();
-			will(returnValue(now));
-			oneOf(mailboxApiCaller).retryWithBackoff(apiCall);
-			will(returnValue(task));
-		}});
-
-		checker.checkConnectivity(properties, observer1);
-
-		// When checkConnectivity() is called again before the first check
-		// succeeds, the observer should be added to the existing check
-		checker.checkConnectivity(properties, observer2);
-
-		// When the check succeeds both observers should be called
-		context.checking(new Expectations() {{
-			oneOf(observer1).onConnectivityCheckSucceeded();
-			oneOf(observer2).onConnectivityCheckSucceeded();
-		}});
-
-		checker.onConnectivityCheckSucceeded(now);
-
-		// The observers should not be called again when subsequent checks
-		// succeed
-		checker.onConnectivityCheckSucceeded(now);
-	}
-
-	@Test
-	public void testFreshResultIsReused() {
-		ConnectivityCheckerImpl checker = createChecker();
-
-		// When checkConnectivity() is called a check should be started
-		context.checking(new Expectations() {{
-			oneOf(clock).currentTimeMillis();
-			will(returnValue(now));
-			oneOf(mailboxApiCaller).retryWithBackoff(apiCall);
-			will(returnValue(task));
-		}});
-
-		checker.checkConnectivity(properties, observer1);
-
-		// When the check succeeds the observer should be called
-		context.checking(new Expectations() {{
-			oneOf(observer1).onConnectivityCheckSucceeded();
-		}});
-
-		checker.onConnectivityCheckSucceeded(now);
-
-		// When checkConnectivity() is called again within
-		// CONNECTIVITY_CHECK_FRESHNESS_MS the observer should be called with
-		// the result of the recent check
-		context.checking(new Expectations() {{
-			oneOf(clock).currentTimeMillis();
-			will(returnValue(now + CONNECTIVITY_CHECK_FRESHNESS_MS));
-			oneOf(observer2).onConnectivityCheckSucceeded();
-		}});
-
-		checker.checkConnectivity(properties, observer2);
-	}
-
-	@Test
-	public void testStaleResultIsNotReused() {
-		ConnectivityCheckerImpl checker = createChecker();
-
-		// When checkConnectivity() is called a check should be started
-		context.checking(new Expectations() {{
-			oneOf(clock).currentTimeMillis();
-			will(returnValue(now));
-			oneOf(mailboxApiCaller).retryWithBackoff(apiCall);
-			will(returnValue(task));
-		}});
-
-		checker.checkConnectivity(properties, observer1);
-
-		// When the check succeeds the observer should be called
-		context.checking(new Expectations() {{
-			oneOf(observer1).onConnectivityCheckSucceeded();
-		}});
-
-		checker.onConnectivityCheckSucceeded(now);
-
-		// When checkConnectivity() is called again after more than
-		// CONNECTIVITY_CHECK_FRESHNESS_MS another check should be started
-		context.checking(new Expectations() {{
-			oneOf(clock).currentTimeMillis();
-			will(returnValue(now + CONNECTIVITY_CHECK_FRESHNESS_MS + 1));
-			oneOf(mailboxApiCaller).retryWithBackoff(apiCall);
-			will(returnValue(task));
-		}});
-
-		checker.checkConnectivity(properties, observer2);
-
-		// When the check succeeds the observer should be called
-		context.checking(new Expectations() {{
-			oneOf(observer2).onConnectivityCheckSucceeded();
-		}});
-
-		checker.onConnectivityCheckSucceeded(
-				now + CONNECTIVITY_CHECK_FRESHNESS_MS + 1);
-	}
-
-	@Test
-	public void testCheckIsCancelledWhenCheckerIsDestroyed() {
-		ConnectivityCheckerImpl checker = createChecker();
-
-		// When checkConnectivity() is called a check should be started
-		context.checking(new Expectations() {{
-			oneOf(clock).currentTimeMillis();
-			will(returnValue(now));
-			oneOf(mailboxApiCaller).retryWithBackoff(apiCall);
-			will(returnValue(task));
-		}});
-
-		checker.checkConnectivity(properties, observer1);
-
-		// When the checker is destroyed the check should be cancelled
-		context.checking(new Expectations() {{
-			oneOf(task).cancel();
-		}});
-
-		checker.destroy();
-
-		// If the check runs anyway (cancellation came too late) the observer
-		// should not be called
-		checker.onConnectivityCheckSucceeded(now);
-	}
-
-	private ConnectivityCheckerImpl createChecker() {
-
-		return new ConnectivityCheckerImpl(clock, mailboxApiCaller) {
-			@Override
-			@Nonnull
-			protected ApiCall createConnectivityCheckTask(
-					@Nonnull MailboxProperties properties) {
-				return apiCall;
-			}
-		};
-	}
-}

bramble-core/src/test/java/org/briarproject/bramble/mailbox/ContactMailboxConnectivityCheckerTest.java

@@ -1,98 +0,0 @@
-package org.briarproject.bramble.mailbox;
-
-import org.briarproject.bramble.api.Cancellable;
-import org.briarproject.bramble.api.mailbox.MailboxProperties;
-import org.briarproject.bramble.api.system.Clock;
-import org.briarproject.bramble.mailbox.ConnectivityChecker.ConnectivityObserver;
-import org.briarproject.bramble.test.BrambleMockTestCase;
-import org.briarproject.bramble.test.CaptureArgumentAction;
-import org.jmock.Expectations;
-import org.jmock.lib.action.DoAllAction;
-import org.junit.Test;
-
-import java.io.IOException;
-import java.util.concurrent.atomic.AtomicReference;
-
-import static org.briarproject.bramble.mailbox.MailboxApi.CLIENT_SUPPORTS;
-import static org.briarproject.bramble.test.TestUtils.getMailboxProperties;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertTrue;
-
-public class ContactMailboxConnectivityCheckerTest extends BrambleMockTestCase {
-
-	private final Clock clock = context.mock(Clock.class);
-	private final MailboxApiCaller mailboxApiCaller =
-			context.mock(MailboxApiCaller.class);
-	private final MailboxApi mailboxApi = context.mock(MailboxApi.class);
-	private final Cancellable task = context.mock(Cancellable.class);
-	private final ConnectivityObserver observer =
-			context.mock(ConnectivityObserver.class);
-
-	private final MailboxProperties properties =
-			getMailboxProperties(false, CLIENT_SUPPORTS);
-	private final long now = System.currentTimeMillis();
-
-	@Test
-	public void testObserverIsCalledWhenCheckSucceeds() throws Exception {
-		ContactMailboxConnectivityChecker checker = createChecker();
-		AtomicReference<ApiCall> apiCall = new AtomicReference<>(null);
-
-		// When checkConnectivity() is called a check should be started
-		context.checking(new Expectations() {{
-			oneOf(clock).currentTimeMillis();
-			will(returnValue(now));
-			oneOf(mailboxApiCaller).retryWithBackoff(with(any(ApiCall.class)));
-			will(new DoAllAction(
-					new CaptureArgumentAction<>(apiCall, ApiCall.class, 0),
-					returnValue(task)
-			));
-		}});
-
-		checker.checkConnectivity(properties, observer);
-
-		// When the check succeeds the observer should be called
-		context.checking(new Expectations() {{
-			oneOf(mailboxApi).checkStatus(properties);
-			will(returnValue(true));
-			oneOf(clock).currentTimeMillis();
-			will(returnValue(now));
-			oneOf(observer).onConnectivityCheckSucceeded();
-		}});
-
-		// The call should not be retried
-		assertFalse(apiCall.get().callApi());
-	}
-
-	@Test
-	public void testObserverIsNotCalledWhenCheckFails() throws Exception {
-		ContactMailboxConnectivityChecker checker = createChecker();
-		AtomicReference<ApiCall> apiCall = new AtomicReference<>(null);
-
-		// When checkConnectivity() is called a check should be started
-		context.checking(new Expectations() {{
-			oneOf(clock).currentTimeMillis();
-			will(returnValue(now));
-			oneOf(mailboxApiCaller).retryWithBackoff(with(any(ApiCall.class)));
-			will(new DoAllAction(
-					new CaptureArgumentAction<>(apiCall, ApiCall.class, 0),
-					returnValue(task)
-			));
-		}});
-
-		checker.checkConnectivity(properties, observer);
-
-		// When the check fails, the observer should not be called
-		context.checking(new Expectations() {{
-			oneOf(mailboxApi).checkStatus(properties);
-			will(throwException(new IOException()));
-		}});
-
-		// The call should be retried
-		assertTrue(apiCall.get().callApi());
-	}
-
-	private ContactMailboxConnectivityChecker createChecker() {
-		return new ContactMailboxConnectivityChecker(clock, mailboxApiCaller,
-				mailboxApi);
-	}
-}

bramble-core/src/test/java/org/briarproject/bramble/mailbox/MailboxApiCallerImplTest.java

@@ -1,135 +0,0 @@
-package org.briarproject.bramble.mailbox;
-
-import org.briarproject.bramble.api.Cancellable;
-import org.briarproject.bramble.api.system.TaskScheduler;
-import org.briarproject.bramble.test.BrambleMockTestCase;
-import org.briarproject.bramble.test.CaptureArgumentAction;
-import org.jmock.Expectations;
-import org.jmock.lib.action.DoAllAction;
-import org.junit.Test;
-
-import java.util.ArrayList;
-import java.util.List;
-import java.util.concurrent.Executor;
-import java.util.concurrent.atomic.AtomicReference;
-
-import static java.util.concurrent.TimeUnit.MILLISECONDS;
-import static org.briarproject.bramble.mailbox.MailboxApiCaller.MAX_RETRY_INTERVAL_MS;
-import static org.briarproject.bramble.mailbox.MailboxApiCaller.MIN_RETRY_INTERVAL_MS;
-
-public class MailboxApiCallerImplTest extends BrambleMockTestCase {
-
-	private final TaskScheduler taskScheduler =
-			context.mock(TaskScheduler.class);
-	private final Executor ioExecutor = context.mock(Executor.class);
-	private final ApiCall apiCall = context.mock(ApiCall.class);
-	private final Cancellable scheduledTask = context.mock(Cancellable.class);
-
-	private final MailboxApiCallerImpl caller =
-			new MailboxApiCallerImpl(taskScheduler, ioExecutor);
-
-	@Test
-	public void testSubmitsTaskImmediately() {
-		// Calling retryWithBackoff() should schedule the first try immediately
-		AtomicReference<Runnable> runnable = new AtomicReference<>(null);
-		context.checking(new Expectations() {{
-			oneOf(ioExecutor).execute(with(any(Runnable.class)));
-			will(new CaptureArgumentAction<>(runnable, Runnable.class, 0));
-		}});
-
-		caller.retryWithBackoff(apiCall);
-
-		// When the task runs, the API call should be called. The call
-		// returns false, so no retries should be scheduled
-		context.checking(new Expectations() {{
-			oneOf(apiCall).callApi();
-			will(returnValue(false));
-		}});
-
-		runnable.get().run();
-	}
-
-	@Test
-	public void testDoesNotRetryTaskIfCancelled() {
-		// Calling retryWithBackoff() should schedule the first try immediately
-		AtomicReference<Runnable> runnable = new AtomicReference<>(null);
-		context.checking(new Expectations() {{
-			oneOf(ioExecutor).execute(with(any(Runnable.class)));
-			will(new CaptureArgumentAction<>(runnable, Runnable.class, 0));
-		}});
-
-		Cancellable returned = caller.retryWithBackoff(apiCall);
-
-		// When the task runs, the API call should be called. The call
-		// returns true, so a retry should be scheduled
-		context.checking(new Expectations() {{
-			oneOf(apiCall).callApi();
-			will(returnValue(true));
-			oneOf(taskScheduler).schedule(with(any(Runnable.class)),
-					with(ioExecutor), with(MIN_RETRY_INTERVAL_MS),
-					with(MILLISECONDS));
-			will(new DoAllAction(
-					new CaptureArgumentAction<>(runnable, Runnable.class, 0),
-					returnValue(scheduledTask)
-			));
-		}});
-
-		runnable.get().run();
-
-		// When the Cancellable returned by retryWithBackoff() is cancelled,
-		// the scheduled task should be cancelled
-		context.checking(new Expectations() {{
-			oneOf(scheduledTask).cancel();
-		}});
-
-		returned.cancel();
-
-		// Cancelling again should have no effect
-		returned.cancel();
-
-		// If the scheduled task runs anyway (cancellation came too late),
-		// the API call should not be called and no further tries should be
-		// scheduled
-		runnable.get().run();
-	}
-
-	@Test
-	public void testDoublesRetryIntervalUntilMaximumIsReached() {
-		// The expected retry intervals increase from the min to the max
-		List<Long> expectedIntervals = new ArrayList<>();
-		for (long interval = MIN_RETRY_INTERVAL_MS;
-				interval <= MAX_RETRY_INTERVAL_MS; interval *= 2) {
-			expectedIntervals.add(interval);
-		}
-		// Once the interval reaches the maximum it should be capped
-		expectedIntervals.add(MAX_RETRY_INTERVAL_MS);
-		expectedIntervals.add(MAX_RETRY_INTERVAL_MS);
-
-		// Calling retryWithBackoff() should schedule the first try immediately
-		AtomicReference<Runnable> runnable = new AtomicReference<>(null);
-		context.checking(new Expectations() {{
-			oneOf(ioExecutor).execute(with(any(Runnable.class)));
-			will(new CaptureArgumentAction<>(runnable, Runnable.class, 0));
-		}});
-
-		caller.retryWithBackoff(apiCall);
-
-		// Each time the task runs, the API call returns true, so a retry
-		// should be scheduled with a longer interval
-		for (long interval : expectedIntervals) {
-			context.checking(new Expectations() {{
-				oneOf(apiCall).callApi();
-				will(returnValue(true));
-				oneOf(taskScheduler).schedule(with(any(Runnable.class)),
-						with(ioExecutor), with(interval), with(MILLISECONDS));
-				will(new DoAllAction(
-						new CaptureArgumentAction<>(
-								runnable, Runnable.class, 0),
-						returnValue(scheduledTask)
-				));
-			}});
-
-			runnable.get().run();
-		}
-	}
-}

bramble-core/src/test/java/org/briarproject/bramble/mailbox/MailboxApiTest.java

@@ -9,7 +9,6 @@ import org.briarproject.bramble.api.mailbox.MailboxFileId;
 import org.briarproject.bramble.api.mailbox.MailboxFolderId;
 import org.briarproject.bramble.api.mailbox.MailboxId;
 import org.briarproject.bramble.api.mailbox.MailboxProperties;
-import org.briarproject.bramble.api.mailbox.MailboxVersion;
 import org.briarproject.bramble.mailbox.MailboxApi.ApiException;
 import org.briarproject.bramble.mailbox.MailboxApi.MailboxContact;
 import org.briarproject.bramble.mailbox.MailboxApi.MailboxFile;
@@ -35,9 +34,7 @@ import okio.Buffer;
 
 import static java.util.Collections.singletonList;
 import static java.util.concurrent.TimeUnit.MILLISECONDS;
-import static org.briarproject.bramble.mailbox.MailboxApi.CLIENT_SUPPORTS;
 import static org.briarproject.bramble.test.TestUtils.getContactId;
-import static org.briarproject.bramble.test.TestUtils.getMailboxProperties;
 import static org.briarproject.bramble.test.TestUtils.getRandomBytes;
 import static org.briarproject.bramble.test.TestUtils.getRandomId;
 import static org.briarproject.bramble.test.TestUtils.mailboxPropertiesEqual;
@@ -82,94 +79,6 @@ public class MailboxApiTest extends BrambleTestCase {
 	private final MailboxContact mailboxContact = new MailboxContact(
 			contactId, contactToken, contactInboxId, contactOutboxId);
 
-	@Test
-	public void testGetServerSupports() throws Exception {
-		String validVersions = "[ {\"major\":1,\"minor\":0} ]";
-		String validResponse = makeVersionsResponse(validVersions);
-		String invalidResponse = "{\"foo\":\"bar\"}";
-		String invalidVersionsResponse = makeVersionsResponse("42");
-		String invalidVersionsResponse2 = makeVersionsResponse("[ 1,0 ]");
-		String invalidVersionsResponse3 =
-				makeVersionsResponse("[ {\"major\":1, \"minor\":-1} ]");
-
-		MockWebServer server = new MockWebServer();
-		server.enqueue(new MockResponse().setBody(validResponse));
-		server.enqueue(new MockResponse().setBody(invalidResponse));
-		server.enqueue(new MockResponse().setResponseCode(401));
-		server.enqueue(new MockResponse().setResponseCode(500));
-		server.enqueue(new MockResponse().setBody(invalidVersionsResponse));
-		server.enqueue(new MockResponse().setBody(invalidVersionsResponse2));
-		server.enqueue(new MockResponse().setBody(invalidVersionsResponse3));
-		server.start();
-		String baseUrl = getBaseUrl(server);
-		List<MailboxVersion> versions = singletonList(new MailboxVersion(1, 0));
-		MailboxProperties properties =
-				new MailboxProperties(baseUrl, token, new ArrayList<>());
-		MailboxProperties properties2 =
-				new MailboxProperties(baseUrl, token2, new ArrayList<>());
-
-		RecordedRequest request;
-
-		// valid response with valid token
-		assertEquals(versions, api.getServerSupports(properties));
-		request = server.takeRequest();
-		assertEquals("/versions", request.getPath());
-		assertEquals("GET", request.getMethod());
-		assertToken(request, token);
-
-		// invalid response
-		assertThrows(ApiException.class,
-				() -> api.getServerSupports(properties));
-		request = server.takeRequest();
-		assertEquals("/versions", request.getPath());
-		assertEquals("GET", request.getMethod());
-		assertToken(request, token);
-
-		// 401 response
-		assertThrows(ApiException.class,
-				() -> api.getServerSupports(properties2));
-		request = server.takeRequest();
-		assertEquals("/versions", request.getPath());
-		assertEquals("GET", request.getMethod());
-		assertToken(request, token2);
-
-		// 500 response
-		assertThrows(ApiException.class,
-				() -> api.getServerSupports(properties));
-		request = server.takeRequest();
-		assertEquals("/versions", request.getPath());
-		assertEquals("GET", request.getMethod());
-		assertToken(request, token);
-
-		// invalid non-array serverSupports response
-		assertThrows(ApiException.class,
-				() -> api.getServerSupports(properties));
-		request = server.takeRequest();
-		assertEquals("/versions", request.getPath());
-		assertEquals("GET", request.getMethod());
-		assertToken(request, token);
-
-		// invalid non-object in serverSupports array response
-		assertThrows(ApiException.class,
-				() -> api.getServerSupports(properties));
-		request = server.takeRequest();
-		assertEquals("/versions", request.getPath());
-		assertEquals("GET", request.getMethod());
-		assertToken(request, token);
-
-		// invalid negative minor version in serverSupports response
-		assertThrows(ApiException.class,
-				() -> api.getServerSupports(properties));
-		request = server.takeRequest();
-		assertEquals("/versions", request.getPath());
-		assertEquals("GET", request.getMethod());
-		assertToken(request, token);
-	}
-
-	private String makeVersionsResponse(String versions) {
-		return "{\"serverSupports\":" + versions + "}";
-	}
-
 	@Test
 	public void testSetup() throws Exception {
 		String validVersions = "[ {\"major\":1,\"minor\":0} ]";
@@ -201,9 +110,9 @@ public class MailboxApiTest extends BrambleTestCase {
 		server.start();
 		String baseUrl = getBaseUrl(server);
 		MailboxProperties properties =
-				new MailboxProperties(baseUrl, token, new ArrayList<>());
+				new MailboxProperties(baseUrl, token, true, new ArrayList<>());
 		MailboxProperties properties2 =
-				new MailboxProperties(baseUrl, token2, new ArrayList<>());
+				new MailboxProperties(baseUrl, token2, true, new ArrayList<>());
 
 		// valid response with valid token
 		mailboxPropertiesEqual(properties2, api.setup(properties));
@@ -284,7 +193,7 @@ public class MailboxApiTest extends BrambleTestCase {
 	@Test
 	public void testSetupOnlyForOwner() {
 		MailboxProperties properties =
-				getMailboxProperties(false, CLIENT_SUPPORTS);
+				new MailboxProperties("", token, false, new ArrayList<>());
 		assertThrows(
 				IllegalArgumentException.class,
 				() -> api.setup(properties)
@@ -300,9 +209,9 @@ public class MailboxApiTest extends BrambleTestCase {
 		server.start();
 		String baseUrl = getBaseUrl(server);
 		MailboxProperties properties =
-				new MailboxProperties(baseUrl, token, new ArrayList<>());
+				new MailboxProperties(baseUrl, token, true, new ArrayList<>());
 		MailboxProperties properties2 =
-				new MailboxProperties(baseUrl, token2, new ArrayList<>());
+				new MailboxProperties(baseUrl, token2, true, new ArrayList<>());
 
 		assertTrue(api.checkStatus(properties));
 		RecordedRequest request1 = server.takeRequest();
@@ -320,6 +229,16 @@ public class MailboxApiTest extends BrambleTestCase {
 		assertToken(request3, token);
 	}
 
+	@Test
+	public void testStatusOnlyForOwner() {
+		MailboxProperties properties =
+				new MailboxProperties("", token, false, new ArrayList<>());
+		assertThrows(
+				IllegalArgumentException.class,
+				() -> api.checkStatus(properties)
+		);
+	}
+
 	@Test
 	public void testWipe() throws Exception {
 		MockWebServer server = new MockWebServer();
@@ -330,9 +249,9 @@ public class MailboxApiTest extends BrambleTestCase {
 		server.start();
 		String baseUrl = getBaseUrl(server);
 		MailboxProperties properties =
-				new MailboxProperties(baseUrl, token, new ArrayList<>());
+				new MailboxProperties(baseUrl, token, true, new ArrayList<>());
 		MailboxProperties properties2 =
-				new MailboxProperties(baseUrl, token2, new ArrayList<>());
+				new MailboxProperties(baseUrl, token2, true, new ArrayList<>());
 
 		api.wipeMailbox(properties);
 		RecordedRequest request1 = server.takeRequest();
@@ -362,7 +281,7 @@ public class MailboxApiTest extends BrambleTestCase {
 	@Test
 	public void testWipeOnlyForOwner() {
 		MailboxProperties properties =
-				getMailboxProperties(false, CLIENT_SUPPORTS);
+				new MailboxProperties("", token, false, new ArrayList<>());
 		assertThrows(IllegalArgumentException.class, () ->
 				api.wipeMailbox(properties));
 	}
@@ -376,7 +295,7 @@ public class MailboxApiTest extends BrambleTestCase {
 		server.start();
 		String baseUrl = getBaseUrl(server);
 		MailboxProperties properties =
-				new MailboxProperties(baseUrl, token, new ArrayList<>());
+				new MailboxProperties(baseUrl, token, true, new ArrayList<>());
 
 		// contact gets added as expected
 		api.addContact(properties, mailboxContact);
@@ -408,7 +327,7 @@ public class MailboxApiTest extends BrambleTestCase {
 	@Test
 	public void testAddContactOnlyForOwner() {
 		MailboxProperties properties =
-				getMailboxProperties(false, CLIENT_SUPPORTS);
+				new MailboxProperties("", token, false, new ArrayList<>());
 		assertThrows(IllegalArgumentException.class, () ->
 				api.addContact(properties, mailboxContact));
 	}
@@ -423,7 +342,7 @@ public class MailboxApiTest extends BrambleTestCase {
 		server.start();
 		String baseUrl = getBaseUrl(server);
 		MailboxProperties properties =
-				new MailboxProperties(baseUrl, token, new ArrayList<>());
+				new MailboxProperties(baseUrl, token, true, new ArrayList<>());
 
 		// contact gets deleted as expected
 		api.deleteContact(properties, contactId);
@@ -460,7 +379,7 @@ public class MailboxApiTest extends BrambleTestCase {
 	@Test
 	public void testDeleteContactOnlyForOwner() {
 		MailboxProperties properties =
-				getMailboxProperties(false, CLIENT_SUPPORTS);
+				new MailboxProperties("", token, false, new ArrayList<>());
 		assertThrows(IllegalArgumentException.class, () ->
 				api.deleteContact(properties, contactId));
 	}
@@ -487,7 +406,7 @@ public class MailboxApiTest extends BrambleTestCase {
 		server.start();
 		String baseUrl = getBaseUrl(server);
 		MailboxProperties properties =
-				new MailboxProperties(baseUrl, token, new ArrayList<>());
+				new MailboxProperties(baseUrl, token, true, new ArrayList<>());
 
 		// valid response with two contacts
 		assertEquals(singletonList(contactId), api.getContacts(properties));
@@ -552,7 +471,7 @@ public class MailboxApiTest extends BrambleTestCase {
 	@Test
 	public void testGetContactsOnlyForOwner() {
 		MailboxProperties properties =
-				getMailboxProperties(false, CLIENT_SUPPORTS);
+				new MailboxProperties("", token, false, new ArrayList<>());
 		assertThrows(
 				IllegalArgumentException.class,
 				() -> api.getContacts(properties)
@@ -572,7 +491,7 @@ public class MailboxApiTest extends BrambleTestCase {
 		server.start();
 		String baseUrl = getBaseUrl(server);
 		MailboxProperties properties =
-				new MailboxProperties(baseUrl, token, new ArrayList<>());
+				new MailboxProperties(baseUrl, token, true, new ArrayList<>());
 
 		// file gets uploaded as expected
 		api.addFile(properties, contactInboxId, file);
@@ -631,7 +550,7 @@ public class MailboxApiTest extends BrambleTestCase {
 		server.start();
 		String baseUrl = getBaseUrl(server);
 		MailboxProperties properties =
-				new MailboxProperties(baseUrl, token, new ArrayList<>());
+				new MailboxProperties(baseUrl, token, true, new ArrayList<>());
 
 		// valid response with one file
 		List<MailboxFile> received1 = api.getFiles(properties, contactInboxId);
@@ -727,7 +646,7 @@ public class MailboxApiTest extends BrambleTestCase {
 		server.start();
 		String baseUrl = getBaseUrl(server);
 		MailboxProperties properties =
-				new MailboxProperties(baseUrl, token, new ArrayList<>());
+				new MailboxProperties(baseUrl, token, true, new ArrayList<>());
 
 		// file gets downloaded as expected
 		api.getFile(properties, contactOutboxId, name, file1);
@@ -771,7 +690,7 @@ public class MailboxApiTest extends BrambleTestCase {
 		server.start();
 		String baseUrl = getBaseUrl(server);
 		MailboxProperties properties =
-				new MailboxProperties(baseUrl, token, new ArrayList<>());
+				new MailboxProperties(baseUrl, token, true, new ArrayList<>());
 
 		// file gets deleted as expected
 		api.deleteFile(properties, contactInboxId, name);
@@ -835,7 +754,7 @@ public class MailboxApiTest extends BrambleTestCase {
 		server.start();
 		String baseUrl = getBaseUrl(server);
 		MailboxProperties properties =
-				new MailboxProperties(baseUrl, token, new ArrayList<>());
+				new MailboxProperties(baseUrl, token, true, new ArrayList<>());
 
 		// valid response with one folders
 		assertEquals(singletonList(id1), api.getFolders(properties));
@@ -904,7 +823,7 @@ public class MailboxApiTest extends BrambleTestCase {
 	@Test
 	public void testGetFoldersOnlyForOwner() {
 		MailboxProperties properties =
-				getMailboxProperties(false, CLIENT_SUPPORTS);
+				new MailboxProperties("", token, false, new ArrayList<>());
 		assertThrows(IllegalArgumentException.class, () ->
 				api.getFolders(properties));
 	}

bramble-core/src/test/java/org/briarproject/bramble/mailbox/MailboxIntegrationTest.java

@@ -91,7 +91,7 @@ public class MailboxIntegrationTest extends BrambleTestCase {
 
 		if (ownerProperties != null) return;
 		MailboxProperties setupProperties = new MailboxProperties(
-				URL_BASE, SETUP_TOKEN, new ArrayList<>());
+				URL_BASE, SETUP_TOKEN, true, new ArrayList<>());
 		ownerProperties = api.setup(setupProperties);
 	}
 
@@ -108,29 +108,13 @@ public class MailboxIntegrationTest extends BrambleTestCase {
 
 		// new setup doesn't work as mailbox is stopping
 		MailboxProperties setupProperties = new MailboxProperties(
-				URL_BASE, SETUP_TOKEN, new ArrayList<>());
+				URL_BASE, SETUP_TOKEN, true, new ArrayList<>());
 		assertThrows(ApiException.class, () -> api.setup(setupProperties));
 	}
 
 	@Test
 	public void testStatus() throws Exception {
-		// Owner calls status endpoint
 		assertTrue(api.checkStatus(ownerProperties));
-
-		// Owner adds contact
-		ContactId contactId = new ContactId(1);
-		MailboxContact contact = getMailboxContact(contactId);
-		MailboxProperties contactProperties = new MailboxProperties(
-				ownerProperties.getBaseUrl(), contact.token,
-				new ArrayList<>(), contact.inboxId, contact.outboxId);
-		api.addContact(ownerProperties, contact);
-
-		// Contact calls status endpoint
-		assertTrue(api.checkStatus(contactProperties));
-
-		// Owner deletes contact again to leave clean state for other tests
-		api.deleteContact(ownerProperties, contactId);
-		assertEquals(emptyList(), api.getContacts(ownerProperties));
 	}
 
 	@Test
@@ -167,8 +151,8 @@ public class MailboxIntegrationTest extends BrambleTestCase {
 		ContactId contactId = new ContactId(1);
 		MailboxContact contact = getMailboxContact(contactId);
 		MailboxProperties contactProperties = new MailboxProperties(
-				ownerProperties.getBaseUrl(), contact.token,
+				ownerProperties.getBaseUrl(), contact.token, false,
-				new ArrayList<>(), contact.inboxId, contact.outboxId);
+				new ArrayList<>());
 		api.addContact(ownerProperties, contact);
 
 		// upload a file for our contact

bramble-core/src/test/java/org/briarproject/bramble/mailbox/MailboxPairingTaskImplTest.java

@@ -9,11 +9,9 @@ import org.briarproject.bramble.api.mailbox.MailboxAuthToken;
 import org.briarproject.bramble.api.mailbox.MailboxPairingState;
 import org.briarproject.bramble.api.mailbox.MailboxPairingTask;
 import org.briarproject.bramble.api.mailbox.MailboxProperties;
+import org.briarproject.bramble.api.mailbox.MailboxPropertyManager;
 import org.briarproject.bramble.api.mailbox.MailboxSettingsManager;
-import org.briarproject.bramble.api.mailbox.MailboxUpdate;
+import org.briarproject.bramble.api.mailbox.OwnMailboxConnectionStatusEvent;
-import org.briarproject.bramble.api.mailbox.MailboxUpdateManager;
-import org.briarproject.bramble.api.mailbox.MailboxVersion;
-import org.briarproject.bramble.api.mailbox.event.OwnMailboxConnectionStatusEvent;
 import org.briarproject.bramble.api.system.Clock;
 import org.briarproject.bramble.test.BrambleMockTestCase;
 import org.briarproject.bramble.test.DbExpectations;
@@ -26,10 +24,10 @@ import java.io.IOException;
 import java.nio.ByteBuffer;
 import java.nio.charset.Charset;
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.concurrent.Executor;
 import java.util.concurrent.atomic.AtomicInteger;
 
-import static java.util.Collections.singletonList;
 import static org.briarproject.bramble.test.TestUtils.getContact;
 import static org.briarproject.bramble.test.TestUtils.getRandomBytes;
 import static org.briarproject.bramble.test.TestUtils.getRandomId;
@@ -49,15 +47,15 @@ public class MailboxPairingTaskImplTest extends BrambleMockTestCase {
 	private final MailboxApi api = context.mock(MailboxApi.class);
 	private final MailboxSettingsManager mailboxSettingsManager =
 			context.mock(MailboxSettingsManager.class);
-	private final MailboxUpdateManager mailboxUpdateManager =
+	private final MailboxPropertyManager mailboxPropertyManager =
-			context.mock(MailboxUpdateManager.class);
+			context.mock(MailboxPropertyManager.class);
 	private final MailboxPairingTaskFactory factory =
 			new MailboxPairingTaskFactoryImpl(executor, db, crypto, clock, api,
-					mailboxSettingsManager, mailboxUpdateManager);
+					mailboxSettingsManager, mailboxPropertyManager);
 
 	private final String onion = getRandomString(56);
 	private final byte[] onionBytes = getRandomBytes(32);
-	private final String baseUrl = "http://" + onion + ".onion"; // TODO
+	private final String onionAddress = "http://" + onion + ".onion";
 	private final MailboxAuthToken setupToken =
 			new MailboxAuthToken(getRandomId());
 	private final MailboxAuthToken ownerToken =
@@ -65,9 +63,9 @@ public class MailboxPairingTaskImplTest extends BrambleMockTestCase {
 	private final String validPayload = getValidPayload();
 	private final long time = System.currentTimeMillis();
 	private final MailboxProperties setupProperties = new MailboxProperties(
-			baseUrl, setupToken, new ArrayList<>());
+			onionAddress, setupToken, true, new ArrayList<>());
 	private final MailboxProperties ownerProperties = new MailboxProperties(
-			baseUrl, ownerToken, new ArrayList<>());
+			onionAddress, ownerToken, true, new ArrayList<>());
 
 	@Test
 	public void testInitialQrCodeReceivedState() {
@@ -107,18 +105,16 @@ public class MailboxPairingTaskImplTest extends BrambleMockTestCase {
 		}});
 		Contact contact1 = getContact();
 		Transaction txn = new Transaction(null, false);
-		MailboxUpdate updateNoMailbox = new MailboxUpdate(
-				singletonList(new MailboxVersion(47, 11)));
 		context.checking(new DbExpectations() {{
 			oneOf(db).transaction(with(false), withDbRunnable(txn));
 			oneOf(mailboxSettingsManager).setOwnMailboxProperties(
 					with(txn), with(matches(ownerProperties)));
 			oneOf(mailboxSettingsManager).recordSuccessfulConnection(txn, time);
 			oneOf(db).getContacts(txn);
-			will(returnValue(singletonList(contact1)));
+			will(returnValue(Collections.singletonList(contact1)));
-			oneOf(mailboxUpdateManager).getRemoteUpdate(txn,
+			oneOf(mailboxPropertyManager).getRemoteProperties(txn,
 					contact1.getId());
-			will(returnValue(updateNoMailbox));
+			will(returnValue(null));
 			oneOf(db).resetUnackedMessagesToSend(txn, contact1.getId());
 		}});
 

bramble-core/src/test/java/org/briarproject/bramble/mailbox/MailboxPropertyManagerImplTest.java

@@ -11,12 +11,12 @@ import org.briarproject.bramble.api.data.MetadataParser;
 import org.briarproject.bramble.api.db.DatabaseComponent;
 import org.briarproject.bramble.api.db.Metadata;
 import org.briarproject.bramble.api.db.Transaction;
+import org.briarproject.bramble.api.mailbox.MailboxAuthToken;
+import org.briarproject.bramble.api.mailbox.MailboxFolderId;
 import org.briarproject.bramble.api.mailbox.MailboxProperties;
+import org.briarproject.bramble.api.mailbox.MailboxPropertiesUpdate;
 import org.briarproject.bramble.api.mailbox.MailboxSettingsManager;
-import org.briarproject.bramble.api.mailbox.MailboxUpdate;
+import org.briarproject.bramble.api.mailbox.RemoteMailboxPropertiesUpdateEvent;
-import org.briarproject.bramble.api.mailbox.MailboxUpdateWithMailbox;
-import org.briarproject.bramble.api.mailbox.MailboxVersion;
-import org.briarproject.bramble.api.mailbox.event.RemoteMailboxUpdateEvent;
 import org.briarproject.bramble.api.sync.Group;
 import org.briarproject.bramble.api.sync.GroupId;
 import org.briarproject.bramble.api.sync.Message;
@@ -27,36 +27,34 @@ import org.briarproject.bramble.test.BrambleMockTestCase;
 import org.jmock.Expectations;
 import org.junit.Test;
 
+import java.util.ArrayList;
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.Random;
 
 import static java.util.Collections.singletonList;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.CLIENT_ID;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.CLIENT_ID;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.GROUP_KEY_SENT_CLIENT_SUPPORTS;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.MAJOR_VERSION;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.MAJOR_VERSION;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.MSG_KEY_LOCAL;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.MSG_KEY_LOCAL;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.MSG_KEY_VERSION;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.MSG_KEY_VERSION;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.PROP_KEY_AUTHTOKEN;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.PROP_KEY_AUTHTOKEN;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.PROP_KEY_INBOXID;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.PROP_KEY_INBOXID;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.PROP_KEY_ONION;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.PROP_KEY_ONION;
+import static org.briarproject.bramble.api.mailbox.MailboxPropertyManager.PROP_KEY_OUTBOXID;
-import static org.briarproject.bramble.api.mailbox.MailboxUpdateManager.PROP_KEY_OUTBOXID;
 import static org.briarproject.bramble.api.sync.Group.Visibility.SHARED;
 import static org.briarproject.bramble.api.sync.validation.IncomingMessageHook.DeliveryAction.ACCEPT_DO_NOT_SHARE;
 import static org.briarproject.bramble.test.TestUtils.getContact;
 import static org.briarproject.bramble.test.TestUtils.getGroup;
-import static org.briarproject.bramble.test.TestUtils.getMailboxProperties;
 import static org.briarproject.bramble.test.TestUtils.getMessage;
 import static org.briarproject.bramble.test.TestUtils.getRandomId;
 import static org.briarproject.bramble.test.TestUtils.hasEvent;
-import static org.briarproject.bramble.test.TestUtils.mailboxUpdateEqual;
+import static org.briarproject.bramble.test.TestUtils.mailboxPropertiesUpdateEqual;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
 
-public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
+public class MailboxPropertyManagerImplTest extends BrambleMockTestCase {
 
 	private final DatabaseComponent db = context.mock(DatabaseComponent.class);
 	private final ClientHelper clientHelper = context.mock(ClientHelper.class);
@@ -74,62 +72,32 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 	private final Group localGroup = getGroup(CLIENT_ID, MAJOR_VERSION);
 	private final BdfDictionary propsDict;
 	private final BdfDictionary emptyPropsDict = new BdfDictionary();
-	private final List<MailboxVersion> someClientSupportsList;
+	private final MailboxPropertiesUpdate props;
-	private final BdfList someClientSupports;
-	private final List<MailboxVersion> newerClientSupportsList;
-	private final BdfList newerClientSupports;
-	private final List<MailboxVersion> someServerSupportsList;
-	private final BdfList someServerSupports;
-	private final BdfList emptyServerSupports = new BdfList();
-	private final MailboxProperties updateProps;
-	private final MailboxUpdateWithMailbox updateWithMailbox;
-	private final MailboxUpdate updateNoMailbox;
 	private final MailboxProperties ownProps;
 
-	public MailboxUpdateManagerImplTest() {
+	public MailboxPropertyManagerImplTest() {
-		Random rnd = new Random();
+		ownProps = new MailboxProperties("http://bar.onion",
-		someClientSupportsList = singletonList(new MailboxVersion(
+				new MailboxAuthToken(getRandomId()), true, new ArrayList<>());
-				rnd.nextInt(), rnd.nextInt()));
+		props = new MailboxPropertiesUpdate(ownProps.getOnion(),
-		someClientSupports = BdfList.of(BdfList.of(
+				new MailboxAuthToken(getRandomId()),
-				someClientSupportsList.get(0).getMajor(),
+				new MailboxFolderId(getRandomId()),
-				someClientSupportsList.get(0).getMinor()));
+				new MailboxFolderId(getRandomId()));
-		newerClientSupportsList = singletonList(new MailboxVersion(
-				someClientSupportsList.get(0).getMajor(),
-				someClientSupportsList.get(0).getMinor() + 1));
-		newerClientSupports = BdfList.of(BdfList.of(
-				newerClientSupportsList.get(0).getMajor(),
-				newerClientSupportsList.get(0).getMinor()));
-
-		someServerSupportsList = singletonList(new MailboxVersion(
-				rnd.nextInt(), rnd.nextInt()));
-		someServerSupports = BdfList.of(BdfList.of(
-				someServerSupportsList.get(0).getMajor(),
-				someServerSupportsList.get(0).getMinor()));
-
-		updateNoMailbox = new MailboxUpdate(someClientSupportsList);
-
-		updateProps = getMailboxProperties(false, someServerSupportsList);
-		ownProps = new MailboxProperties(updateProps.getBaseUrl(),
-				updateProps.getAuthToken(), someServerSupportsList);
-		updateWithMailbox = new MailboxUpdateWithMailbox(someClientSupportsList,
-				updateProps);
 		propsDict = new BdfDictionary();
-		propsDict.put(PROP_KEY_ONION, updateProps.getOnion());
+		propsDict.put(PROP_KEY_ONION, props.getOnion());
-		propsDict.put(PROP_KEY_AUTHTOKEN, updateProps.getAuthToken());
+		propsDict.put(PROP_KEY_AUTHTOKEN, props.getAuthToken().getBytes());
-		propsDict.put(PROP_KEY_INBOXID, updateProps.getInboxId());
+		propsDict.put(PROP_KEY_INBOXID, props.getInboxId().getBytes());
-		propsDict.put(PROP_KEY_OUTBOXID, updateProps.getOutboxId());
+		propsDict.put(PROP_KEY_OUTBOXID, props.getOutboxId().getBytes());
 	}
 
-	private MailboxUpdateManagerImpl createInstance(
+	private MailboxPropertyManagerImpl createInstance() {
-			List<MailboxVersion> clientSupports) {
 		context.checking(new Expectations() {{
 			oneOf(contactGroupFactory).createLocalGroup(CLIENT_ID,
 					MAJOR_VERSION);
 			will(returnValue(localGroup));
 		}});
-		return new MailboxUpdateManagerImpl(clientSupports, db,
+		return new MailboxPropertyManagerImpl(db, clientHelper,
-				clientHelper, clientVersioningManager, metadataParser,
+				clientVersioningManager, metadataParser, contactGroupFactory,
-				contactGroupFactory, clock, mailboxSettingsManager, crypto);
+				clock, mailboxSettingsManager, crypto);
 	}
 
 	@Test
@@ -137,10 +105,6 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 		Transaction txn = new Transaction(null, false);
 		Contact contact = getContact();
 		Group contactGroup = getGroup(CLIENT_ID, MAJOR_VERSION);
-		Map<MessageId, BdfDictionary> messageMetadata = new LinkedHashMap<>();
-		BdfDictionary sentDict = BdfDictionary.of(new BdfEntry(
-				GROUP_KEY_SENT_CLIENT_SUPPORTS,
-				someClientSupports));
 
 		context.checking(new Expectations() {{
 			oneOf(db).containsGroup(txn, localGroup.getId());
@@ -148,8 +112,6 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 			oneOf(db).addGroup(txn, localGroup);
 			oneOf(db).getContacts(txn);
 			will(returnValue(singletonList(contact)));
-
-			// addingContact()
 			oneOf(contactGroupFactory).createContactGroup(CLIENT_ID,
 					MAJOR_VERSION, contact);
 			will(returnValue(contactGroup));
@@ -163,20 +125,9 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 					contact.getId());
 			oneOf(mailboxSettingsManager).getOwnMailboxProperties(txn);
 			will(returnValue(null));
-			oneOf(contactGroupFactory).createContactGroup(CLIENT_ID,
-					MAJOR_VERSION, contact);
-			will(returnValue(contactGroup));
-			oneOf(clientHelper).getMessageMetadataAsDictionary(txn,
-					contactGroup.getId());
-			will(returnValue(messageMetadata));
-			expectStoreMessage(txn, contactGroup.getId(), 1, someClientSupports,
-					emptyServerSupports, emptyPropsDict, true);
-
-			oneOf(clientHelper).mergeGroupMetadata(txn, localGroup.getId(),
-					sentDict);
 		}});
 
-		MailboxUpdateManagerImpl t = createInstance(someClientSupportsList);
+		MailboxPropertyManagerImpl t = createInstance();
 		t.onDatabaseOpened(txn);
 	}
 
@@ -187,9 +138,6 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 		Contact contact = getContact();
 		Group contactGroup = getGroup(CLIENT_ID, MAJOR_VERSION);
 		Map<MessageId, BdfDictionary> messageMetadata = new LinkedHashMap<>();
-		BdfDictionary sentDict = BdfDictionary.of(new BdfEntry(
-				GROUP_KEY_SENT_CLIENT_SUPPORTS,
-				someClientSupports));
 
 		context.checking(new Expectations() {{
 			oneOf(db).containsGroup(txn, localGroup.getId());
@@ -197,8 +145,6 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 			oneOf(db).addGroup(txn, localGroup);
 			oneOf(db).getContacts(txn);
 			will(returnValue(singletonList(contact)));
-
-			// addingContact()
 			oneOf(contactGroupFactory).createContactGroup(CLIENT_ID,
 					MAJOR_VERSION, contact);
 			will(returnValue(contactGroup));
@@ -213,201 +159,35 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 			oneOf(mailboxSettingsManager).getOwnMailboxProperties(txn);
 			will(returnValue(ownProps));
 			oneOf(crypto).generateUniqueId();
-			will(returnValue(updateProps.getAuthToken()));
+			will(returnValue(props.getAuthToken()));
 			oneOf(crypto).generateUniqueId();
-			will(returnValue(updateProps.getInboxId()));
+			will(returnValue(props.getInboxId()));
 			oneOf(crypto).generateUniqueId();
-			will(returnValue(updateProps.getOutboxId()));
+			will(returnValue(props.getOutboxId()));
 			oneOf(contactGroupFactory).createContactGroup(CLIENT_ID,
 					MAJOR_VERSION, contact);
 			will(returnValue(contactGroup));
 			oneOf(clientHelper).getMessageMetadataAsDictionary(txn,
 					contactGroup.getId());
 			will(returnValue(messageMetadata));
-			expectStoreMessage(txn, contactGroup.getId(), 1, someClientSupports,
+			expectStoreMessage(txn, contactGroup.getId(), propsDict, 1, true);
-					someServerSupports, propsDict, true);
-
-			oneOf(clientHelper).mergeGroupMetadata(txn, localGroup.getId(),
-					sentDict);
 		}});
 
-		MailboxUpdateManagerImpl t = createInstance(someClientSupportsList);
+		MailboxPropertyManagerImpl t = createInstance();
 		t.onDatabaseOpened(txn);
 	}
 
 	@Test
-	public void testUnchangedClientSupportsOnSecondStartup() throws Exception {
+	public void testDoesNotCreateGroupsAtStartupIfAlreadyCreated()
-		Transaction txn = new Transaction(null, false);
-
-		Contact contact = getContact();
-		Group contactGroup = getGroup(CLIENT_ID, MAJOR_VERSION);
-
-		Map<MessageId, BdfDictionary> emptyMessageMetadata =
-				new LinkedHashMap<>();
-		BdfDictionary sentDict = BdfDictionary.of(new BdfEntry(
-				GROUP_KEY_SENT_CLIENT_SUPPORTS,
-				someClientSupports));
-
-		context.checking(new Expectations() {{
-			oneOf(db).containsGroup(txn, localGroup.getId());
-			will(returnValue(false));
-			oneOf(db).addGroup(txn, localGroup);
-			oneOf(db).getContacts(txn);
-			will(returnValue(singletonList(contact)));
-
-			// addingContact()
-			oneOf(contactGroupFactory).createContactGroup(CLIENT_ID,
-					MAJOR_VERSION, contact);
-			will(returnValue(contactGroup));
-			oneOf(db).addGroup(txn, contactGroup);
-			oneOf(clientVersioningManager).getClientVisibility(txn,
-					contact.getId(), CLIENT_ID, MAJOR_VERSION);
-			will(returnValue(SHARED));
-			oneOf(db).setGroupVisibility(txn, contact.getId(),
-					contactGroup.getId(), SHARED);
-			oneOf(clientHelper).setContactId(txn, contactGroup.getId(),
-					contact.getId());
-			oneOf(mailboxSettingsManager).getOwnMailboxProperties(txn);
-			will(returnValue(null));
-			oneOf(contactGroupFactory).createContactGroup(CLIENT_ID,
-					MAJOR_VERSION, contact);
-			will(returnValue(contactGroup));
-			oneOf(clientHelper).getMessageMetadataAsDictionary(txn,
-					contactGroup.getId());
-			will(returnValue(emptyMessageMetadata));
-			expectStoreMessage(txn, contactGroup.getId(), 1, someClientSupports,
-					emptyServerSupports, emptyPropsDict, true);
-
-			oneOf(clientHelper).mergeGroupMetadata(txn, localGroup.getId(),
-					sentDict);
-		}});
-
-		MailboxUpdateManagerImpl t = createInstance(someClientSupportsList);
-		t.onDatabaseOpened(txn);
-
-		context.checking(new Expectations() {{
-			oneOf(db).containsGroup(txn, localGroup.getId());
-			will(returnValue(true));
-			oneOf(clientHelper).getGroupMetadataAsDictionary(txn,
-					localGroup.getId());
-			will(returnValue(sentDict));
-			oneOf(clientHelper).parseMailboxVersionList(someClientSupports);
-			will(returnValue(someClientSupportsList));
-		}});
-
-		t = createInstance(someClientSupportsList);
-		t.onDatabaseOpened(txn);
-	}
-
-	@Test
-	public void testSendsUpdateWhenClientSupportsChangedOnSecondStartup()
 			throws Exception {
 		Transaction txn = new Transaction(null, false);
 
-		Contact contact = getContact();
-		Group contactGroup = getGroup(CLIENT_ID, MAJOR_VERSION);
-
-		Map<MessageId, BdfDictionary> emptyMessageMetadata =
-				new LinkedHashMap<>();
-		BdfDictionary sentDict = BdfDictionary.of(new BdfEntry(
-				GROUP_KEY_SENT_CLIENT_SUPPORTS,
-				someClientSupports));
-
-		context.checking(new Expectations() {{
-			oneOf(db).containsGroup(txn, localGroup.getId());
-			will(returnValue(false));
-			oneOf(db).addGroup(txn, localGroup);
-			oneOf(db).getContacts(txn);
-			will(returnValue(singletonList(contact)));
-
-			// addingContact()
-			oneOf(contactGroupFactory).createContactGroup(CLIENT_ID,
-					MAJOR_VERSION, contact);
-			will(returnValue(contactGroup));
-			oneOf(db).addGroup(txn, contactGroup);
-			oneOf(clientVersioningManager).getClientVisibility(txn,
-					contact.getId(), CLIENT_ID, MAJOR_VERSION);
-			will(returnValue(SHARED));
-			oneOf(db).setGroupVisibility(txn, contact.getId(),
-					contactGroup.getId(), SHARED);
-			oneOf(clientHelper).setContactId(txn, contactGroup.getId(),
-					contact.getId());
-			oneOf(mailboxSettingsManager).getOwnMailboxProperties(txn);
-			will(returnValue(null));
-			oneOf(contactGroupFactory).createContactGroup(CLIENT_ID,
-					MAJOR_VERSION, contact);
-			will(returnValue(contactGroup));
-			oneOf(clientHelper).getMessageMetadataAsDictionary(txn,
-					contactGroup.getId());
-			will(returnValue(emptyMessageMetadata));
-			expectStoreMessage(txn, contactGroup.getId(), 1, someClientSupports,
-					emptyServerSupports, emptyPropsDict, true);
-
-			oneOf(clientHelper).mergeGroupMetadata(txn, localGroup.getId(),
-					sentDict);
-		}});
-
-		MailboxUpdateManagerImpl t = createInstance(someClientSupportsList);
-		t.onDatabaseOpened(txn);
-
-		BdfDictionary metaDictionary = BdfDictionary.of(
-				new BdfEntry(MSG_KEY_VERSION, 1),
-				new BdfEntry(MSG_KEY_LOCAL, true)
-		);
-		Map<MessageId, BdfDictionary> messageMetadata = new LinkedHashMap<>();
-		MessageId messageId = new MessageId(getRandomId());
-		messageMetadata.put(messageId, metaDictionary);
-		BdfList body = BdfList.of(1, someClientSupports, someServerSupports,
-				propsDict);
-		BdfDictionary newerSentDict = BdfDictionary.of(new BdfEntry(
-				GROUP_KEY_SENT_CLIENT_SUPPORTS,
-				newerClientSupports));
-
 		context.checking(new Expectations() {{
 			oneOf(db).containsGroup(txn, localGroup.getId());
 			will(returnValue(true));
-
-			// Find out that we are now on newerClientSupportsList
-			oneOf(clientHelper).getGroupMetadataAsDictionary(txn,
-					localGroup.getId());
-			will(returnValue(sentDict));
-			oneOf(clientHelper).parseMailboxVersionList(someClientSupports);
-			will(returnValue(someClientSupportsList));
-
-			oneOf(db).getContacts(txn);
-			will(returnValue(singletonList(contact)));
-			oneOf(db).getContact(txn, contact.getId());
-			will(returnValue(contact));
-
-			// getLocalUpdate()
-			oneOf(contactGroupFactory).createContactGroup(CLIENT_ID,
-					MAJOR_VERSION, contact);
-			will(returnValue(contactGroup));
-			oneOf(clientHelper).getMessageMetadataAsDictionary(txn,
-					contactGroup.getId());
-			will(returnValue(messageMetadata));
-			oneOf(clientHelper).getMessageAsList(txn, messageId);
-			will(returnValue(body));
-			oneOf(clientHelper).parseAndValidateMailboxUpdate(
-					someClientSupports, someServerSupports, propsDict);
-			will(returnValue(updateWithMailbox));
-			oneOf(contactGroupFactory).createContactGroup(CLIENT_ID,
-					MAJOR_VERSION, contact);
-			will(returnValue(contactGroup));
-
-			// storeMessageReplaceLatest()
-			oneOf(clientHelper).getMessageMetadataAsDictionary(txn,
-					contactGroup.getId());
-			will(returnValue(messageMetadata));
-			expectStoreMessage(txn, contactGroup.getId(), 2,
-					newerClientSupports, someServerSupports, propsDict, true);
-			oneOf(db).removeMessage(txn, messageId);
-
-			oneOf(clientHelper).mergeGroupMetadata(txn, localGroup.getId(),
-					newerSentDict);
 		}});
 
-		t = createInstance(newerClientSupportsList);
+		MailboxPropertyManagerImpl t = createInstance();
 		t.onDatabaseOpened(txn);
 	}
 
@@ -417,7 +197,6 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 		Transaction txn = new Transaction(null, false);
 		Contact contact = getContact();
 		Group contactGroup = getGroup(CLIENT_ID, MAJOR_VERSION);
-		Map<MessageId, BdfDictionary> messageMetadata = new LinkedHashMap<>();
 
 		context.checking(new Expectations() {{
 			// Create the group and share it with the contact
@@ -434,17 +213,9 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 					contact.getId());
 			oneOf(mailboxSettingsManager).getOwnMailboxProperties(txn);
 			will(returnValue(null));
-			oneOf(contactGroupFactory).createContactGroup(CLIENT_ID,
-					MAJOR_VERSION, contact);
-			will(returnValue(contactGroup));
-			oneOf(clientHelper).getMessageMetadataAsDictionary(txn,
-					contactGroup.getId());
-			will(returnValue(messageMetadata));
-			expectStoreMessage(txn, contactGroup.getId(), 1, someClientSupports,
-					emptyServerSupports, emptyPropsDict, true);
 		}});
 
-		MailboxUpdateManagerImpl t = createInstance(someClientSupportsList);
+		MailboxPropertyManagerImpl t = createInstance();
 		t.addingContact(txn, contact);
 	}
 
@@ -472,22 +243,21 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 			oneOf(mailboxSettingsManager).getOwnMailboxProperties(txn);
 			will(returnValue(ownProps));
 			oneOf(crypto).generateUniqueId();
-			will(returnValue(updateProps.getAuthToken()));
+			will(returnValue(props.getAuthToken()));
 			oneOf(crypto).generateUniqueId();
-			will(returnValue(updateProps.getInboxId()));
+			will(returnValue(props.getInboxId()));
 			oneOf(crypto).generateUniqueId();
-			will(returnValue(updateProps.getOutboxId()));
+			will(returnValue(props.getOutboxId()));
 			oneOf(contactGroupFactory).createContactGroup(CLIENT_ID,
 					MAJOR_VERSION, contact);
 			will(returnValue(contactGroup));
 			oneOf(clientHelper).getMessageMetadataAsDictionary(txn,
 					contactGroup.getId());
 			will(returnValue(messageMetadata));
-			expectStoreMessage(txn, contactGroup.getId(), 1, someClientSupports,
+			expectStoreMessage(txn, contactGroup.getId(), propsDict, 1, true);
-					someServerSupports, propsDict, true);
 		}});
 
-		MailboxUpdateManagerImpl t = createInstance(someClientSupportsList);
+		MailboxPropertyManagerImpl t = createInstance();
 		t.addingContact(txn, contact);
 	}
 
@@ -504,7 +274,7 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 			oneOf(db).removeGroup(txn, contactGroup);
 		}});
 
-		MailboxUpdateManagerImpl t = createInstance(someClientSupportsList);
+		MailboxPropertyManagerImpl t = createInstance();
 		t.removingContact(txn, contact);
 	}
 
@@ -515,8 +285,7 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 		Contact contact = getContact();
 		GroupId contactGroupId = new GroupId(getRandomId());
 		Message message = getMessage(contactGroupId);
-		BdfList body = BdfList.of(1, someClientSupports, someServerSupports,
+		BdfList body = BdfList.of(1, propsDict);
-				propsDict);
 		Metadata meta = new Metadata();
 		BdfDictionary metaDictionary = BdfDictionary.of(
 				new BdfEntry(MSG_KEY_VERSION, 1),
@@ -540,16 +309,16 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 			will(returnValue(contact.getId()));
 			oneOf(clientHelper).getMessageAsList(txn, message.getId());
 			will(returnValue(body));
-			oneOf(clientHelper).parseAndValidateMailboxUpdate(
+			oneOf(clientHelper).parseAndValidateMailboxPropertiesUpdate(
-					someClientSupports, someServerSupports, propsDict);
+					propsDict);
-			will(returnValue(updateWithMailbox));
+			will(returnValue(props));
 			oneOf(db).resetUnackedMessagesToSend(txn, contact.getId());
 		}});
 
-		MailboxUpdateManagerImpl t = createInstance(someClientSupportsList);
+		MailboxPropertyManagerImpl t = createInstance();
 		assertEquals(ACCEPT_DO_NOT_SHARE,
 				t.incomingMessage(txn, message, meta));
-		assertTrue(hasEvent(txn, RemoteMailboxUpdateEvent.class));
+		assertTrue(hasEvent(txn, RemoteMailboxPropertiesUpdateEvent.class));
 	}
 
 	@Test
@@ -559,8 +328,7 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 		Contact contact = getContact();
 		GroupId contactGroupId = new GroupId(getRandomId());
 		Message message = getMessage(contactGroupId);
-		BdfList body = BdfList.of(1, someClientSupports, someServerSupports,
+		BdfList body = BdfList.of(1, propsDict);
-				propsDict);
 		Metadata meta = new Metadata();
 		BdfDictionary metaDictionary = BdfDictionary.of(
 				new BdfEntry(MSG_KEY_VERSION, 2),
@@ -592,16 +360,16 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 			will(returnValue(contact.getId()));
 			oneOf(clientHelper).getMessageAsList(txn, message.getId());
 			will(returnValue(body));
-			oneOf(clientHelper).parseAndValidateMailboxUpdate(
+			oneOf(clientHelper).parseAndValidateMailboxPropertiesUpdate(
-					someClientSupports, someServerSupports, propsDict);
+					propsDict);
-			will(returnValue(updateWithMailbox));
+			will(returnValue(props));
 			oneOf(db).resetUnackedMessagesToSend(txn, contact.getId());
 		}});
 
-		MailboxUpdateManagerImpl t = createInstance(someClientSupportsList);
+		MailboxPropertyManagerImpl t = createInstance();
 		assertEquals(ACCEPT_DO_NOT_SHARE,
 				t.incomingMessage(txn, message, meta));
-		assertTrue(hasEvent(txn, RemoteMailboxUpdateEvent.class));
+		assertTrue(hasEvent(txn, RemoteMailboxPropertiesUpdateEvent.class));
 	}
 
 	@Test
@@ -632,14 +400,14 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 			oneOf(db).deleteMessageMetadata(txn, message.getId());
 		}});
 
-		MailboxUpdateManagerImpl t = createInstance(someClientSupportsList);
+		MailboxPropertyManagerImpl t = createInstance();
 		assertEquals(ACCEPT_DO_NOT_SHARE,
 				t.incomingMessage(txn, message, meta));
-		assertFalse(hasEvent(txn, RemoteMailboxUpdateEvent.class));
+		assertFalse(hasEvent(txn, RemoteMailboxPropertiesUpdateEvent.class));
 	}
 
 	@Test
-	public void testCreatesAndStoresLocalUpdateWithNewVersionOnPairing()
+	public void testCreatesAndStoresLocalPropertiesWithNewVersionOnPairing()
 			throws Exception {
 		Contact contact = getContact();
 		List<Contact> contacts = singletonList(contact);
@@ -662,28 +430,27 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 			oneOf(db).getContacts(txn);
 			will(returnValue(contacts));
 			oneOf(crypto).generateUniqueId();
-			will(returnValue(updateProps.getAuthToken()));
+			will(returnValue(props.getAuthToken()));
 			oneOf(crypto).generateUniqueId();
-			will(returnValue(updateProps.getInboxId()));
+			will(returnValue(props.getInboxId()));
 			oneOf(crypto).generateUniqueId();
-			will(returnValue(updateProps.getOutboxId()));
+			will(returnValue(props.getOutboxId()));
 			oneOf(contactGroupFactory).createContactGroup(CLIENT_ID,
 					MAJOR_VERSION, contact);
 			will(returnValue(contactGroup));
 			oneOf(clientHelper).getMessageMetadataAsDictionary(txn,
 					contactGroup.getId());
 			will(returnValue(messageMetadata));
-			expectStoreMessage(txn, contactGroup.getId(), 2, someClientSupports,
+			expectStoreMessage(txn, contactGroup.getId(), propsDict, 2, true);
-					someServerSupports, propsDict, true);
 			oneOf(db).removeMessage(txn, latestId);
 		}});
 
-		MailboxUpdateManagerImpl t = createInstance(someClientSupportsList);
+		MailboxPropertyManagerImpl t = createInstance();
-		t.mailboxPaired(txn, ownProps.getOnion(), someServerSupportsList);
+		t.mailboxPaired(txn, ownProps.getOnion());
 	}
 
 	@Test
-	public void testStoresLocalUpdateNoMailboxWithNewVersionOnUnpairing()
+	public void testStoresEmptyLocalPropertiesWithNewVersionOnUnpairing()
 			throws Exception {
 		Contact contact = getContact();
 		List<Contact> contacts = singletonList(contact);
@@ -711,17 +478,18 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 			oneOf(clientHelper).getMessageMetadataAsDictionary(txn,
 					contactGroup.getId());
 			will(returnValue(messageMetadata));
-			expectStoreMessage(txn, contactGroup.getId(), 2, someClientSupports,
+			expectStoreMessage(txn, contactGroup.getId(), emptyPropsDict,
-					emptyServerSupports, emptyPropsDict, true);
+					2, true);
 			oneOf(db).removeMessage(txn, latestId);
 		}});
 
-		MailboxUpdateManagerImpl t = createInstance(someClientSupportsList);
+		MailboxPropertyManagerImpl t = createInstance();
 		t.mailboxUnpaired(txn);
 	}
 
 	@Test
-	public void testGetRemoteUpdate() throws Exception {
+	public void testGetRemoteProperties()
+			throws Exception {
 		Transaction txn = new Transaction(null, false);
 		Contact contact = getContact();
 		Group contactGroup = getGroup(CLIENT_ID, MAJOR_VERSION);
@@ -730,34 +498,34 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 				new BdfEntry(MSG_KEY_LOCAL, false)
 		);
 		Map<MessageId, BdfDictionary> messageMetadata = new LinkedHashMap<>();
-		MessageId messageId = new MessageId(getRandomId());
+		MessageId fooUpdateId = new MessageId(getRandomId());
-		messageMetadata.put(messageId, metaDictionary);
+		messageMetadata.put(fooUpdateId, metaDictionary);
-		BdfList body = BdfList.of(1, someClientSupports, someServerSupports,
+		BdfList fooUpdate = BdfList.of(1, propsDict);
-				propsDict);
 
 		context.checking(new Expectations() {{
 			oneOf(db).getContact(txn, contact.getId());
 			will(returnValue(contact));
-			oneOf(contactGroupFactory)
+			oneOf(contactGroupFactory).createContactGroup(CLIENT_ID,
-					.createContactGroup(CLIENT_ID, MAJOR_VERSION, contact);
+					MAJOR_VERSION, contact);
 			will(returnValue(contactGroup));
 			oneOf(clientHelper).getMessageMetadataAsDictionary(txn,
 					contactGroup.getId());
 			will(returnValue(messageMetadata));
-			oneOf(clientHelper).getMessageAsList(txn, messageId);
+			oneOf(clientHelper).getMessageAsList(txn, fooUpdateId);
-			will(returnValue(body));
+			will(returnValue(fooUpdate));
-			oneOf(clientHelper).parseAndValidateMailboxUpdate(
+			oneOf(clientHelper).parseAndValidateMailboxPropertiesUpdate(
-					someClientSupports, someServerSupports, propsDict);
+					propsDict);
-			will(returnValue(updateWithMailbox));
+			will(returnValue(props));
 		}});
 
-		MailboxUpdateManagerImpl t = createInstance(someClientSupportsList);
+		MailboxPropertyManagerImpl t = createInstance();
-		MailboxUpdate remote = t.getRemoteUpdate(txn, contact.getId());
+		MailboxPropertiesUpdate remote =
-		assertTrue(mailboxUpdateEqual(remote, updateWithMailbox));
+				t.getRemoteProperties(txn, contact.getId());
+		assertTrue(mailboxPropertiesUpdateEqual(remote, props));
 	}
 
 	@Test
-	public void testGetRemoteUpdateReturnsNullBecauseNoUpdate()
+	public void testGetRemotePropertiesReturnsNullBecauseNoUpdate()
 			throws Exception {
 		Transaction txn = new Transaction(null, false);
 		Contact contact = getContact();
@@ -776,12 +544,13 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 			will(returnValue(emptyMessageMetadata));
 		}});
 
-		MailboxUpdateManagerImpl t = createInstance(someClientSupportsList);
+		MailboxPropertyManagerImpl t = createInstance();
-		assertNull(t.getRemoteUpdate(txn, contact.getId()));
+		assertNull(t.getRemoteProperties(txn, contact.getId()));
 	}
 
 	@Test
-	public void testGetRemoteUpdateNoMailbox() throws Exception {
+	public void testGetRemotePropertiesReturnsNullBecauseEmptyUpdate()
+			throws Exception {
 		Transaction txn = new Transaction(null, false);
 		Contact contact = getContact();
 		Group contactGroup = getGroup(CLIENT_ID, MAJOR_VERSION);
@@ -790,10 +559,9 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 				new BdfEntry(MSG_KEY_LOCAL, false)
 		);
 		Map<MessageId, BdfDictionary> messageMetadata = new LinkedHashMap<>();
-		MessageId messageId = new MessageId(getRandomId());
+		MessageId fooUpdateId = new MessageId(getRandomId());
-		messageMetadata.put(messageId, metaDictionary);
+		messageMetadata.put(fooUpdateId, metaDictionary);
-		BdfList body = BdfList.of(1, someClientSupports, emptyServerSupports,
+		BdfList fooUpdate = BdfList.of(1, emptyPropsDict);
-				emptyPropsDict);
 
 		context.checking(new Expectations() {{
 			oneOf(db).getContact(txn, contact.getId());
@@ -804,20 +572,20 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 			oneOf(clientHelper).getMessageMetadataAsDictionary(txn,
 					contactGroup.getId());
 			will(returnValue(messageMetadata));
-			oneOf(clientHelper).getMessageAsList(txn, messageId);
+			oneOf(clientHelper).getMessageAsList(txn, fooUpdateId);
-			will(returnValue(body));
+			will(returnValue(fooUpdate));
-			oneOf(clientHelper).parseAndValidateMailboxUpdate(
+			oneOf(clientHelper).parseAndValidateMailboxPropertiesUpdate(
-					someClientSupports, emptyServerSupports, emptyPropsDict);
+					emptyPropsDict);
-			will(returnValue(updateNoMailbox));
+			will(returnValue(null));
 		}});
 
-		MailboxUpdateManagerImpl t = createInstance(someClientSupportsList);
+		MailboxPropertyManagerImpl t = createInstance();
-		MailboxUpdate remote = t.getRemoteUpdate(txn, contact.getId());
+		assertNull(t.getRemoteProperties(txn, contact.getId()));
-		assertTrue(mailboxUpdateEqual(remote, updateNoMailbox));
 	}
 
 	@Test
-	public void testGetLocalUpdate() throws Exception {
+	public void testGetLocalProperties()
+			throws Exception {
 		Transaction txn = new Transaction(null, false);
 		Contact contact = getContact();
 		Group contactGroup = getGroup(CLIENT_ID, MAJOR_VERSION);
@@ -826,10 +594,9 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 				new BdfEntry(MSG_KEY_LOCAL, true)
 		);
 		Map<MessageId, BdfDictionary> messageMetadata = new LinkedHashMap<>();
-		MessageId messageId = new MessageId(getRandomId());
+		MessageId fooUpdateId = new MessageId(getRandomId());
-		messageMetadata.put(messageId, metaDictionary);
+		messageMetadata.put(fooUpdateId, metaDictionary);
-		BdfList body = BdfList.of(1, someClientSupports, someServerSupports,
+		BdfList fooUpdate = BdfList.of(1, propsDict);
-				propsDict);
 
 		context.checking(new Expectations() {{
 			oneOf(db).getContact(txn, contact.getId());
@@ -840,20 +607,46 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 			oneOf(clientHelper).getMessageMetadataAsDictionary(txn,
 					contactGroup.getId());
 			will(returnValue(messageMetadata));
-			oneOf(clientHelper).getMessageAsList(txn, messageId);
+			oneOf(clientHelper).getMessageAsList(txn, fooUpdateId);
-			will(returnValue(body));
+			will(returnValue(fooUpdate));
-			oneOf(clientHelper).parseAndValidateMailboxUpdate(
+			oneOf(clientHelper).parseAndValidateMailboxPropertiesUpdate(
-					someClientSupports, someServerSupports, propsDict);
+					propsDict);
-			will(returnValue(updateWithMailbox));
+			will(returnValue(props));
 		}});
 
-		MailboxUpdateManagerImpl t = createInstance(someClientSupportsList);
+		MailboxPropertyManagerImpl t = createInstance();
-		MailboxUpdate local = t.getLocalUpdate(txn, contact.getId());
+		MailboxPropertiesUpdate local =
-		assertTrue(mailboxUpdateEqual(local, updateWithMailbox));
+				t.getLocalProperties(txn, contact.getId());
+		assertTrue(mailboxPropertiesUpdateEqual(local, props));
 	}
 
 	@Test
-	public void testGetLocalUpdateNoMailbox() throws Exception {
+	public void testGetLocalPropertiesReturnsNullBecauseNoUpdate()
+			throws Exception {
+		Transaction txn = new Transaction(null, false);
+		Contact contact = getContact();
+		Group contactGroup = getGroup(CLIENT_ID, MAJOR_VERSION);
+		Map<MessageId, BdfDictionary> emptyMessageMetadata =
+				new LinkedHashMap<>();
+
+		context.checking(new Expectations() {{
+			oneOf(db).getContact(txn, contact.getId());
+			will(returnValue(contact));
+			oneOf(contactGroupFactory).createContactGroup(CLIENT_ID,
+					MAJOR_VERSION, contact);
+			will(returnValue(contactGroup));
+			oneOf(clientHelper).getMessageMetadataAsDictionary(txn,
+					contactGroup.getId());
+			will(returnValue(emptyMessageMetadata));
+		}});
+
+		MailboxPropertyManagerImpl t = createInstance();
+		assertNull(t.getLocalProperties(txn, contact.getId()));
+	}
+
+	@Test
+	public void testGetLocalPropertiesReturnsNullBecauseEmptyUpdate()
+			throws Exception {
 		Transaction txn = new Transaction(null, false);
 		Contact contact = getContact();
 		Group contactGroup = getGroup(CLIENT_ID, MAJOR_VERSION);
@@ -862,10 +655,9 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 				new BdfEntry(MSG_KEY_LOCAL, true)
 		);
 		Map<MessageId, BdfDictionary> messageMetadata = new LinkedHashMap<>();
-		MessageId messageId = new MessageId(getRandomId());
+		MessageId fooUpdateId = new MessageId(getRandomId());
-		messageMetadata.put(messageId, metaDictionary);
+		messageMetadata.put(fooUpdateId, metaDictionary);
-		BdfList body = BdfList.of(1, someClientSupports, emptyServerSupports,
+		BdfList fooUpdate = BdfList.of(1, emptyPropsDict);
-				emptyPropsDict);
 
 		context.checking(new Expectations() {{
 			oneOf(db).getContact(txn, contact.getId());
@@ -876,24 +668,21 @@ public class MailboxUpdateManagerImplTest extends BrambleMockTestCase {
 			oneOf(clientHelper).getMessageMetadataAsDictionary(txn,
 					contactGroup.getId());
 			will(returnValue(messageMetadata));
-			oneOf(clientHelper).getMessageAsList(txn, messageId);
+			oneOf(clientHelper).getMessageAsList(txn, fooUpdateId);
-			will(returnValue(body));
+			will(returnValue(fooUpdate));
-			oneOf(clientHelper).parseAndValidateMailboxUpdate(
+			oneOf(clientHelper).parseAndValidateMailboxPropertiesUpdate(
-					someClientSupports, emptyServerSupports, emptyPropsDict);
+					emptyPropsDict);
-			will(returnValue(updateNoMailbox));
+			will(returnValue(null));
 		}});
 
-		MailboxUpdateManagerImpl t = createInstance(someClientSupportsList);
+		MailboxPropertyManagerImpl t = createInstance();
-		MailboxUpdate local = t.getLocalUpdate(txn, contact.getId());
+		assertNull(t.getLocalProperties(txn, contact.getId()));
-		assertTrue(mailboxUpdateEqual(local, updateNoMailbox));
 	}
 
 	private void expectStoreMessage(Transaction txn, GroupId g,
-			long version, BdfList clientSupports, BdfList serverSupports,
+			BdfDictionary properties, long version, boolean local)
-			BdfDictionary properties, boolean local)
 			throws Exception {
-		BdfList body = BdfList.of(version, clientSupports, serverSupports,
+		BdfList body = BdfList.of(version, properties);
-				properties);
 		Message message = getMessage(g);
 		long timestamp = message.getTimestamp();
 		BdfDictionary meta = BdfDictionary.of(

bramble-core/src/test/java/org/briarproject/bramble/mailbox/MailboxPropertyValidatorTest.java

@@ -0,0 +1,99 @@
+package org.briarproject.bramble.mailbox;
+
+import org.briarproject.bramble.api.FormatException;
+import org.briarproject.bramble.api.client.ClientHelper;
+import org.briarproject.bramble.api.data.BdfDictionary;
+import org.briarproject.bramble.api.data.BdfEntry;
+import org.briarproject.bramble.api.data.BdfList;
+import org.briarproject.bramble.api.data.MetadataEncoder;
+import org.briarproject.bramble.api.mailbox.MailboxAuthToken;
+import org.briarproject.bramble.api.mailbox.MailboxFolderId;
+import org.briarproject.bramble.api.mailbox.MailboxPropertiesUpdate;
+import org.briarproject.bramble.api.mailbox.MailboxPropertyManager;
+import org.briarproject.bramble.api.sync.Group;
+import org.briarproject.bramble.api.sync.Message;
+import org.briarproject.bramble.api.system.Clock;
+import org.briarproject.bramble.test.BrambleMockTestCase;
+import org.jmock.Expectations;
+import org.junit.Test;
+
+import java.io.IOException;
+
+import static org.briarproject.bramble.test.TestUtils.getGroup;
+import static org.briarproject.bramble.test.TestUtils.getMessage;
+import static org.briarproject.bramble.test.TestUtils.getRandomId;
+import static org.junit.Assert.assertEquals;
+
+public class MailboxPropertyValidatorTest extends BrambleMockTestCase {
+
+	private final ClientHelper clientHelper = context.mock(ClientHelper.class);
+
+	private final BdfDictionary bdfDict;
+	private final MailboxPropertiesUpdate mailboxProps;
+	private final Group group;
+	private final Message message;
+	private final MailboxPropertyValidator mpv;
+
+	public MailboxPropertyValidatorTest() {
+		// Just dummies, clientHelper is mocked so our test is a bit shallow;
+		//  not testing
+		//  {@link ClientHelper#parseAndValidateMailboxPropertiesUpdate(BdfDictionary)}
+		bdfDict = BdfDictionary.of(new BdfEntry("foo", "bar"));
+		mailboxProps = new MailboxPropertiesUpdate("baz",
+				new MailboxAuthToken(getRandomId()),
+				new MailboxFolderId(getRandomId()),
+				new MailboxFolderId(getRandomId()));
+
+		group = getGroup(MailboxPropertyManager.CLIENT_ID,
+				MailboxPropertyManager.MAJOR_VERSION);
+		message = getMessage(group.getId());
+
+		MetadataEncoder metadataEncoder = context.mock(MetadataEncoder.class);
+		Clock clock = context.mock(Clock.class);
+		mpv = new MailboxPropertyValidator(clientHelper, metadataEncoder,
+				clock);
+	}
+
+	@Test
+	public void testValidateMessageBody() throws IOException {
+		BdfList body = BdfList.of(4, bdfDict);
+
+		context.checking(new Expectations() {{
+			oneOf(clientHelper).parseAndValidateMailboxPropertiesUpdate(
+					bdfDict);
+			will(returnValue(mailboxProps));
+		}});
+
+		BdfDictionary result =
+				mpv.validateMessage(message, group, body).getDictionary();
+		assertEquals(4, result.getLong("version").longValue());
+	}
+
+	@Test(expected = FormatException.class)
+	public void testValidateWrongVersionValue() throws IOException {
+		BdfList body = BdfList.of(-1, bdfDict);
+		mpv.validateMessage(message, group, body);
+	}
+
+	@Test(expected = FormatException.class)
+	public void testValidateWrongVersionType() throws IOException {
+		BdfList body = BdfList.of(bdfDict, bdfDict);
+		mpv.validateMessage(message, group, body);
+	}
+
+	@Test
+	public void testEmptyPropertiesReturnsNull() throws IOException {
+		BdfDictionary emptyBdfDict = new BdfDictionary();
+		BdfList body = BdfList.of(42, emptyBdfDict);
+
+		context.checking(new Expectations() {{
+			oneOf(clientHelper).parseAndValidateMailboxPropertiesUpdate(
+					emptyBdfDict);
+			will(returnValue(null));
+		}});
+
+		BdfDictionary result =
+				mpv.validateMessage(message, group, body).getDictionary();
+		assertEquals(42, result.getLong("version").longValue());
+	}
+}

bramble-core/src/test/java/org/briarproject/bramble/mailbox/MailboxSettingsManagerImplTest.java

@@ -7,7 +7,7 @@ import org.briarproject.bramble.api.mailbox.MailboxProperties;
 import org.briarproject.bramble.api.mailbox.MailboxSettingsManager;
 import org.briarproject.bramble.api.mailbox.MailboxStatus;
 import org.briarproject.bramble.api.mailbox.MailboxVersion;
-import org.briarproject.bramble.api.mailbox.event.OwnMailboxConnectionStatusEvent;
+import org.briarproject.bramble.api.mailbox.OwnMailboxConnectionStatusEvent;
 import org.briarproject.bramble.api.settings.Settings;
 import org.briarproject.bramble.api.settings.SettingsManager;
 import org.briarproject.bramble.test.BrambleMockTestCase;
@@ -97,7 +97,7 @@ public class MailboxSettingsManagerImplTest extends BrambleMockTestCase {
 		expectedSettings.put(SETTINGS_KEY_TOKEN, token.toString());
 		expectedSettings.putIntArray(SETTINGS_KEY_SERVER_SUPPORTS,
 				serverSupportsInts);
-		MailboxProperties properties = new MailboxProperties(onion, token,
+		MailboxProperties properties = new MailboxProperties(onion, token, true,
 				serverSupports);
 
 		context.checking(new Expectations() {{

bramble-core/src/test/java/org/briarproject/bramble/mailbox/MailboxUpdateValidatorTest.java

@@ -1,116 +0,0 @@
-package org.briarproject.bramble.mailbox;
-
-import org.briarproject.bramble.api.FormatException;
-import org.briarproject.bramble.api.client.ClientHelper;
-import org.briarproject.bramble.api.data.BdfDictionary;
-import org.briarproject.bramble.api.data.BdfEntry;
-import org.briarproject.bramble.api.data.BdfList;
-import org.briarproject.bramble.api.data.MetadataEncoder;
-import org.briarproject.bramble.api.mailbox.MailboxProperties;
-import org.briarproject.bramble.api.mailbox.MailboxUpdate;
-import org.briarproject.bramble.api.mailbox.MailboxUpdateManager;
-import org.briarproject.bramble.api.mailbox.MailboxUpdateWithMailbox;
-import org.briarproject.bramble.api.mailbox.MailboxVersion;
-import org.briarproject.bramble.api.sync.Group;
-import org.briarproject.bramble.api.sync.Message;
-import org.briarproject.bramble.api.system.Clock;
-import org.briarproject.bramble.test.BrambleMockTestCase;
-import org.jmock.Expectations;
-import org.junit.Test;
-
-import java.io.IOException;
-import java.util.List;
-
-import static java.util.Collections.singletonList;
-import static org.briarproject.bramble.test.TestUtils.getGroup;
-import static org.briarproject.bramble.test.TestUtils.getMailboxProperties;
-import static org.briarproject.bramble.test.TestUtils.getMessage;
-import static org.junit.Assert.assertEquals;
-
-public class MailboxUpdateValidatorTest extends BrambleMockTestCase {
-
-	private final ClientHelper clientHelper = context.mock(ClientHelper.class);
-
-	private final BdfDictionary bdfDict;
-	private final BdfList emptyServerSupports;
-	private final BdfList someClientSupports;
-	private final BdfList someServerSupports;
-	private final MailboxUpdateWithMailbox updateMailbox;
-	private final MailboxUpdate updateNoMailbox;
-	private final Group group;
-	private final Message message;
-	private final MailboxUpdateValidator muv;
-
-	public MailboxUpdateValidatorTest() {
-		// Just dummies, clientHelper is mocked so our test is a bit shallow;
-		//  not testing
-		//  {@link ClientHelper#parseAndValidateMailboxUpdate(BdfList, BdfList, BdfDictionary)}
-		emptyServerSupports = new BdfList();
-		someClientSupports = BdfList.of(BdfList.of(1, 0));
-		List<MailboxVersion> someClientSupportsList =
-				singletonList(new MailboxVersion(1, 0));
-		someServerSupports = BdfList.of(BdfList.of(1, 0));
-		bdfDict = BdfDictionary.of(new BdfEntry("foo", "bar"));
-
-		MailboxProperties props = getMailboxProperties(false,
-				singletonList(new MailboxVersion(1, 0)));
-		updateMailbox = new MailboxUpdateWithMailbox(
-				singletonList(new MailboxVersion(1, 0)), props);
-		updateNoMailbox = new MailboxUpdate(someClientSupportsList);
-
-
-		group = getGroup(MailboxUpdateManager.CLIENT_ID,
-				MailboxUpdateManager.MAJOR_VERSION);
-		message = getMessage(group.getId());
-
-		MetadataEncoder metadataEncoder = context.mock(MetadataEncoder.class);
-		Clock clock = context.mock(Clock.class);
-		muv = new MailboxUpdateValidator(clientHelper, metadataEncoder,
-				clock);
-	}
-
-	@Test
-	public void testValidateMessageBody() throws IOException {
-		BdfList body =
-				BdfList.of(4, someClientSupports, someServerSupports, bdfDict);
-
-		context.checking(new Expectations() {{
-			oneOf(clientHelper).parseAndValidateMailboxUpdate(
-					someClientSupports, someServerSupports, bdfDict);
-			will(returnValue(updateMailbox));
-		}});
-
-		BdfDictionary result =
-				muv.validateMessage(message, group, body).getDictionary();
-		assertEquals(4, result.getLong("version").longValue());
-	}
-
-	@Test(expected = FormatException.class)
-	public void testValidateWrongVersionValue() throws IOException {
-		BdfList body = BdfList.of(-1, bdfDict);
-		muv.validateMessage(message, group, body);
-	}
-
-	@Test(expected = FormatException.class)
-	public void testValidateWrongVersionType() throws IOException {
-		BdfList body = BdfList.of(bdfDict, bdfDict);
-		muv.validateMessage(message, group, body);
-	}
-
-	@Test
-	public void testEmptyProperties() throws IOException {
-		BdfDictionary emptyBdfDict = new BdfDictionary();
-		BdfList body = BdfList.of(42, someClientSupports, emptyServerSupports,
-				emptyBdfDict);
-
-		context.checking(new Expectations() {{
-			oneOf(clientHelper).parseAndValidateMailboxUpdate(
-					someClientSupports, emptyServerSupports, emptyBdfDict);
-			will(returnValue(updateNoMailbox));
-		}});
-
-		BdfDictionary result =
-				muv.validateMessage(message, group, body).getDictionary();
-		assertEquals(42, result.getLong("version").longValue());
-	}
-}

bramble-core/src/test/java/org/briarproject/bramble/mailbox/OwnMailboxConnectivityCheckerTest.java

@@ -1,117 +0,0 @@
-package org.briarproject.bramble.mailbox;
-
-import org.briarproject.bramble.api.Cancellable;
-import org.briarproject.bramble.api.db.Transaction;
-import org.briarproject.bramble.api.db.TransactionManager;
-import org.briarproject.bramble.api.mailbox.MailboxProperties;
-import org.briarproject.bramble.api.mailbox.MailboxSettingsManager;
-import org.briarproject.bramble.api.system.Clock;
-import org.briarproject.bramble.mailbox.ConnectivityChecker.ConnectivityObserver;
-import org.briarproject.bramble.test.BrambleMockTestCase;
-import org.briarproject.bramble.test.CaptureArgumentAction;
-import org.briarproject.bramble.test.DbExpectations;
-import org.jmock.Expectations;
-import org.jmock.lib.action.DoAllAction;
-import org.junit.Test;
-
-import java.io.IOException;
-import java.util.concurrent.atomic.AtomicReference;
-
-import static org.briarproject.bramble.mailbox.MailboxApi.CLIENT_SUPPORTS;
-import static org.briarproject.bramble.test.TestUtils.getMailboxProperties;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertTrue;
-
-public class OwnMailboxConnectivityCheckerTest extends BrambleMockTestCase {
-
-	private final Clock clock = context.mock(Clock.class);
-	private final MailboxApiCaller mailboxApiCaller =
-			context.mock(MailboxApiCaller.class);
-	private final MailboxApi mailboxApi = context.mock(MailboxApi.class);
-	private final TransactionManager db =
-			context.mock(TransactionManager.class);
-	private final MailboxSettingsManager mailboxSettingsManager =
-			context.mock(MailboxSettingsManager.class);
-	private final Cancellable task = context.mock(Cancellable.class);
-	private final ConnectivityObserver observer =
-			context.mock(ConnectivityObserver.class);
-
-	private final MailboxProperties properties =
-			getMailboxProperties(true, CLIENT_SUPPORTS);
-	private final long now = System.currentTimeMillis();
-
-	@Test
-	public void testObserverIsCalledWhenCheckSucceeds() throws Exception {
-		OwnMailboxConnectivityChecker checker = createChecker();
-		AtomicReference<ApiCall> apiCall = new AtomicReference<>(null);
-		Transaction txn = new Transaction(null, false);
-
-		// When checkConnectivity() is called a check should be started
-		context.checking(new Expectations() {{
-			oneOf(clock).currentTimeMillis();
-			will(returnValue(now));
-			oneOf(mailboxApiCaller).retryWithBackoff(with(any(ApiCall.class)));
-			will(new DoAllAction(
-					new CaptureArgumentAction<>(apiCall, ApiCall.class, 0),
-					returnValue(task)
-			));
-		}});
-
-		checker.checkConnectivity(properties, observer);
-
-		// When the check succeeds, the success should be recorded in the DB
-		// and the observer should be called
-		context.checking(new DbExpectations() {{
-			oneOf(mailboxApi).checkStatus(properties);
-			will(returnValue(true));
-			oneOf(clock).currentTimeMillis();
-			will(returnValue(now));
-			oneOf(db).transaction(with(false), withDbRunnable(txn));
-			oneOf(mailboxSettingsManager).recordSuccessfulConnection(txn, now);
-			oneOf(observer).onConnectivityCheckSucceeded();
-		}});
-
-		// The call should not be retried
-		assertFalse(apiCall.get().callApi());
-	}
-
-	@Test
-	public void testObserverIsNotCalledWhenCheckFails() throws Exception {
-		OwnMailboxConnectivityChecker checker = createChecker();
-		AtomicReference<ApiCall> apiCall = new AtomicReference<>(null);
-		Transaction txn = new Transaction(null, false);
-
-		// When checkConnectivity() is called a check should be started
-		context.checking(new Expectations() {{
-			oneOf(clock).currentTimeMillis();
-			will(returnValue(now));
-			oneOf(mailboxApiCaller).retryWithBackoff(with(any(ApiCall.class)));
-			will(new DoAllAction(
-					new CaptureArgumentAction<>(apiCall, ApiCall.class, 0),
-					returnValue(task)
-			));
-		}});
-
-		checker.checkConnectivity(properties, observer);
-
-		// When the check fails, the failure should be recorded in the DB and
-		// the observer should not be called
-		context.checking(new DbExpectations() {{
-			oneOf(mailboxApi).checkStatus(properties);
-			will(throwException(new IOException()));
-			oneOf(clock).currentTimeMillis();
-			will(returnValue(now));
-			oneOf(db).transaction(with(false), withDbRunnable(txn));
-			oneOf(mailboxSettingsManager)
-					.recordFailedConnectionAttempt(txn, now);
-		}});
-
-		// The call should be retried
-		assertTrue(apiCall.get().callApi());
-	}
-
-	private OwnMailboxConnectivityChecker createChecker() {
-		return new OwnMailboxConnectivityChecker(clock, mailboxApiCaller,
-				mailboxApi, db, mailboxSettingsManager);
-	}
-}

bramble-core/src/test/java/org/briarproject/bramble/plugin/PollerImplTest.java

@@ -1,6 +1,5 @@
 package org.briarproject.bramble.plugin;
 
-import org.briarproject.bramble.api.Cancellable;
 import org.briarproject.bramble.api.connection.ConnectionManager;
 import org.briarproject.bramble.api.connection.ConnectionRegistry;
 import org.briarproject.bramble.api.contact.ContactId;
@@ -21,6 +20,7 @@ import org.briarproject.bramble.api.properties.TransportProperties;
 import org.briarproject.bramble.api.properties.TransportPropertyManager;
 import org.briarproject.bramble.api.system.Clock;
 import org.briarproject.bramble.api.system.TaskScheduler;
+import org.briarproject.bramble.api.system.TaskScheduler.Cancellable;
 import org.briarproject.bramble.test.BrambleMockTestCase;
 import org.briarproject.bramble.test.ImmediateExecutor;
 import org.briarproject.bramble.test.RunAction;

bramble-core/src/test/java/org/briarproject/bramble/rendezvous/RendezvousPollerImplTest.java

@@ -1,6 +1,5 @@
 package org.briarproject.bramble.rendezvous;
 
-import org.briarproject.bramble.api.Cancellable;
 import org.briarproject.bramble.api.connection.ConnectionManager;
 import org.briarproject.bramble.api.contact.PendingContact;
 import org.briarproject.bramble.api.contact.PendingContactState;
@@ -28,6 +27,7 @@ import org.briarproject.bramble.api.rendezvous.event.RendezvousConnectionOpenedE
 import org.briarproject.bramble.api.rendezvous.event.RendezvousPollEvent;
 import org.briarproject.bramble.api.system.Clock;
 import org.briarproject.bramble.api.system.TaskScheduler;
+import org.briarproject.bramble.api.system.TaskScheduler.Cancellable;
 import org.briarproject.bramble.test.BrambleMockTestCase;
 import org.briarproject.bramble.test.CaptureArgumentAction;
 import org.briarproject.bramble.test.DbExpectations;

bramble-core/src/test/java/org/briarproject/bramble/sync/EagerSimplexOutgoingSessionTest.java

@@ -1,134 +0,0 @@
-package org.briarproject.bramble.sync;
-
-import org.briarproject.bramble.api.contact.ContactId;
-import org.briarproject.bramble.api.db.DatabaseComponent;
-import org.briarproject.bramble.api.db.Transaction;
-import org.briarproject.bramble.api.event.EventBus;
-import org.briarproject.bramble.api.plugin.TransportId;
-import org.briarproject.bramble.api.sync.Ack;
-import org.briarproject.bramble.api.sync.GroupId;
-import org.briarproject.bramble.api.sync.Message;
-import org.briarproject.bramble.api.sync.MessageId;
-import org.briarproject.bramble.api.sync.SyncRecordWriter;
-import org.briarproject.bramble.api.sync.Versions;
-import org.briarproject.bramble.api.transport.StreamWriter;
-import org.briarproject.bramble.test.BrambleMockTestCase;
-import org.briarproject.bramble.test.DbExpectations;
-import org.junit.Test;
-
-import static java.util.Arrays.asList;
-import static java.util.Collections.emptyList;
-import static java.util.Collections.singletonList;
-import static org.briarproject.bramble.api.sync.SyncConstants.MAX_MESSAGE_BODY_LENGTH;
-import static org.briarproject.bramble.api.sync.SyncConstants.MAX_MESSAGE_IDS;
-import static org.briarproject.bramble.test.TestUtils.getContactId;
-import static org.briarproject.bramble.test.TestUtils.getMessage;
-import static org.briarproject.bramble.test.TestUtils.getRandomId;
-import static org.briarproject.bramble.test.TestUtils.getTransportId;
-
-public class EagerSimplexOutgoingSessionTest extends BrambleMockTestCase {
-
-	private static final int MAX_LATENCY = Integer.MAX_VALUE;
-
-	private final DatabaseComponent db = context.mock(DatabaseComponent.class);
-	private final EventBus eventBus = context.mock(EventBus.class);
-	private final StreamWriter streamWriter = context.mock(StreamWriter.class);
-	private final SyncRecordWriter recordWriter =
-			context.mock(SyncRecordWriter.class);
-
-	private final ContactId contactId = getContactId();
-	private final TransportId transportId = getTransportId();
-	private final Ack ack =
-			new Ack(singletonList(new MessageId(getRandomId())));
-	private final Message message = getMessage(new GroupId(getRandomId()),
-			MAX_MESSAGE_BODY_LENGTH);
-	private final Message message1 = getMessage(new GroupId(getRandomId()),
-			MAX_MESSAGE_BODY_LENGTH);
-
-	@Test
-	public void testNothingToSendEagerly() throws Exception {
-		EagerSimplexOutgoingSession session =
-				new EagerSimplexOutgoingSession(db, eventBus, contactId,
-						transportId, MAX_LATENCY, streamWriter, recordWriter);
-
-		Transaction noAckTxn = new Transaction(null, false);
-		Transaction noIdsTxn = new Transaction(null, true);
-
-		context.checking(new DbExpectations() {{
-			// Add listener
-			oneOf(eventBus).addListener(session);
-			// Send the protocol versions
-			oneOf(recordWriter).writeVersions(with(any(Versions.class)));
-			// No acks to send
-			oneOf(db).transactionWithNullableResult(with(false),
-					withNullableDbCallable(noAckTxn));
-			oneOf(db).generateAck(noAckTxn, contactId, MAX_MESSAGE_IDS);
-			will(returnValue(null));
-			// No messages to send
-			oneOf(db).transactionWithResult(with(true),
-					withDbCallable(noIdsTxn));
-			oneOf(db).getUnackedMessagesToSend(noIdsTxn, contactId);
-			will(returnValue(emptyList()));
-			// Send the end of stream marker
-			oneOf(streamWriter).sendEndOfStream();
-			// Remove listener
-			oneOf(eventBus).removeListener(session);
-		}});
-
-		session.run();
-	}
-
-	@Test
-	public void testSomethingToSendEagerly() throws Exception {
-		EagerSimplexOutgoingSession session =
-				new EagerSimplexOutgoingSession(db, eventBus, contactId,
-						transportId, MAX_LATENCY, streamWriter, recordWriter);
-
-		Transaction ackTxn = new Transaction(null, false);
-		Transaction noAckTxn = new Transaction(null, false);
-		Transaction idsTxn = new Transaction(null, true);
-		Transaction msgTxn = new Transaction(null, false);
-		Transaction msgTxn1 = new Transaction(null, false);
-
-		context.checking(new DbExpectations() {{
-			// Add listener
-			oneOf(eventBus).addListener(session);
-			// Send the protocol versions
-			oneOf(recordWriter).writeVersions(with(any(Versions.class)));
-			// One ack to send
-			oneOf(db).transactionWithNullableResult(with(false),
-					withNullableDbCallable(ackTxn));
-			oneOf(db).generateAck(ackTxn, contactId, MAX_MESSAGE_IDS);
-			will(returnValue(ack));
-			oneOf(recordWriter).writeAck(ack);
-			// No more acks
-			oneOf(db).transactionWithNullableResult(with(false),
-					withNullableDbCallable(noAckTxn));
-			oneOf(db).generateAck(noAckTxn, contactId, MAX_MESSAGE_IDS);
-			will(returnValue(null));
-			// Two messages to send
-			oneOf(db).transactionWithResult(with(true), withDbCallable(idsTxn));
-			oneOf(db).getUnackedMessagesToSend(idsTxn, contactId);
-			will(returnValue(asList(message.getId(), message1.getId())));
-			// Try to send the first message - it's no longer shared
-			oneOf(db).transactionWithNullableResult(with(false),
-					withNullableDbCallable(msgTxn));
-			oneOf(db).getMessageToSend(msgTxn, contactId, message.getId(),
-					MAX_LATENCY, true);
-			will(returnValue(null));
-			// Send the second message
-			oneOf(db).transactionWithNullableResult(with(false),
-					withNullableDbCallable(msgTxn1));
-			oneOf(db).getMessageToSend(msgTxn1, contactId, message1.getId(),
-					MAX_LATENCY, true);
-			will(returnValue(message1));
-			oneOf(recordWriter).writeMessage(message1);
-			// Send the end of stream marker
-			oneOf(streamWriter).sendEndOfStream();
-			// Remove listener
-			oneOf(eventBus).removeListener(session);
-		}});
-
-		session.run();
-	}
-}

bramble-core/src/test/java/org/briarproject/bramble/sync/MailboxOutgoingSessionTest.java

@@ -1,231 +0,0 @@
-package org.briarproject.bramble.sync;
-
-import org.briarproject.bramble.api.contact.ContactId;
-import org.briarproject.bramble.api.db.DatabaseComponent;
-import org.briarproject.bramble.api.db.Transaction;
-import org.briarproject.bramble.api.event.EventBus;
-import org.briarproject.bramble.api.plugin.TransportId;
-import org.briarproject.bramble.api.sync.Ack;
-import org.briarproject.bramble.api.sync.DeferredSendHandler;
-import org.briarproject.bramble.api.sync.GroupId;
-import org.briarproject.bramble.api.sync.Message;
-import org.briarproject.bramble.api.sync.MessageId;
-import org.briarproject.bramble.api.sync.SyncRecordWriter;
-import org.briarproject.bramble.api.sync.Versions;
-import org.briarproject.bramble.api.transport.StreamWriter;
-import org.briarproject.bramble.test.BrambleMockTestCase;
-import org.briarproject.bramble.test.DbExpectations;
-import org.junit.Test;
-
-import java.util.ArrayList;
-import java.util.List;
-
-import static java.util.Collections.emptyList;
-import static java.util.Collections.singletonList;
-import static org.briarproject.bramble.api.mailbox.MailboxConstants.MAX_FILE_PAYLOAD_BYTES;
-import static org.briarproject.bramble.api.record.Record.RECORD_HEADER_BYTES;
-import static org.briarproject.bramble.api.sync.SyncConstants.MAX_MESSAGE_BODY_LENGTH;
-import static org.briarproject.bramble.api.sync.SyncConstants.MAX_MESSAGE_IDS;
-import static org.briarproject.bramble.test.TestUtils.getContactId;
-import static org.briarproject.bramble.test.TestUtils.getMessage;
-import static org.briarproject.bramble.test.TestUtils.getRandomId;
-import static org.briarproject.bramble.test.TestUtils.getTransportId;
-
-public class MailboxOutgoingSessionTest extends BrambleMockTestCase {
-
-	private static final int MAX_LATENCY = Integer.MAX_VALUE;
-
-	private final DatabaseComponent db = context.mock(DatabaseComponent.class);
-	private final EventBus eventBus = context.mock(EventBus.class);
-	private final StreamWriter streamWriter = context.mock(StreamWriter.class);
-	private final SyncRecordWriter recordWriter =
-			context.mock(SyncRecordWriter.class);
-	private final DeferredSendHandler deferredSendHandler =
-			context.mock(DeferredSendHandler.class);
-
-	private final ContactId contactId = getContactId();
-	private final TransportId transportId = getTransportId();
-	private final Message message = getMessage(new GroupId(getRandomId()),
-			MAX_MESSAGE_BODY_LENGTH);
-	private final Message message1 = getMessage(new GroupId(getRandomId()),
-			MAX_MESSAGE_BODY_LENGTH);
-	private final int versionRecordBytes = RECORD_HEADER_BYTES + 1;
-
-	@Test
-	public void testNothingToSend() throws Exception {
-		MailboxOutgoingSession session = new MailboxOutgoingSession(db,
-				eventBus, contactId, transportId, MAX_LATENCY,
-				streamWriter, recordWriter, deferredSendHandler,
-				MAX_FILE_PAYLOAD_BYTES);
-
-		Transaction noAckIdTxn = new Transaction(null, true);
-		Transaction noMsgIdTxn = new Transaction(null, true);
-
-		long capacityForMessages = MAX_FILE_PAYLOAD_BYTES - versionRecordBytes;
-
-		context.checking(new DbExpectations() {{
-			// Add listener
-			oneOf(eventBus).addListener(session);
-			// Send the protocol versions
-			oneOf(recordWriter).writeVersions(with(any(Versions.class)));
-			// Calculate capacity for acks
-			oneOf(recordWriter).getBytesWritten();
-			will(returnValue((long) versionRecordBytes));
-			// No messages to ack
-			oneOf(db).transactionWithResult(with(true),
-					withDbCallable(noAckIdTxn));
-			oneOf(db).getMessagesToAck(noAckIdTxn, contactId, MAX_MESSAGE_IDS);
-			will(returnValue(emptyList()));
-			// Calculate capacity for messages
-			oneOf(recordWriter).getBytesWritten();
-			will(returnValue((long) versionRecordBytes));
-			// No messages to send
-			oneOf(db).transactionWithResult(with(true),
-					withDbCallable(noMsgIdTxn));
-			oneOf(db).getMessagesToSend(noMsgIdTxn, contactId,
-					capacityForMessages, MAX_LATENCY);
-			will(returnValue(emptyList()));
-			// Send the end of stream marker
-			oneOf(streamWriter).sendEndOfStream();
-			// Remove listener
-			oneOf(eventBus).removeListener(session);
-		}});
-
-		session.run();
-	}
-
-	@Test
-	public void testSomethingToSend() throws Exception {
-		MailboxOutgoingSession session = new MailboxOutgoingSession(db,
-				eventBus, contactId, transportId, MAX_LATENCY,
-				streamWriter, recordWriter, deferredSendHandler,
-				MAX_FILE_PAYLOAD_BYTES);
-
-		Transaction ackIdTxn = new Transaction(null, true);
-		Transaction noAckIdTxn = new Transaction(null, true);
-		Transaction msgIdTxn = new Transaction(null, true);
-		Transaction msgTxn = new Transaction(null, true);
-
-		int ackRecordBytes = RECORD_HEADER_BYTES + MessageId.LENGTH;
-		long capacityForMessages =
-				MAX_FILE_PAYLOAD_BYTES - versionRecordBytes - ackRecordBytes;
-
-		context.checking(new DbExpectations() {{
-			// Add listener
-			oneOf(eventBus).addListener(session);
-			// Send the protocol versions
-			oneOf(recordWriter).writeVersions(with(any(Versions.class)));
-			// Calculate capacity for acks
-			oneOf(recordWriter).getBytesWritten();
-			will(returnValue((long) versionRecordBytes));
-			// One message to ack
-			oneOf(db).transactionWithResult(with(true),
-					withDbCallable(ackIdTxn));
-			oneOf(db).getMessagesToAck(ackIdTxn, contactId, MAX_MESSAGE_IDS);
-			will(returnValue(singletonList(message.getId())));
-			// Send the ack
-			oneOf(recordWriter).getBytesWritten();
-			will(returnValue((long) versionRecordBytes));
-			oneOf(recordWriter).writeAck(with(any(Ack.class)));
-			oneOf(deferredSendHandler)
-					.onAckSent(singletonList(message.getId()));
-			// No more messages to ack
-			oneOf(db).transactionWithResult(with(true),
-					withDbCallable(noAckIdTxn));
-			oneOf(db).getMessagesToAck(noAckIdTxn, contactId, MAX_MESSAGE_IDS);
-			will(returnValue(emptyList()));
-			// Calculate capacity for messages
-			oneOf(recordWriter).getBytesWritten();
-			will(returnValue((long) versionRecordBytes + ackRecordBytes));
-			// One message to send
-			oneOf(db).transactionWithResult(with(true),
-					withDbCallable(msgIdTxn));
-			oneOf(db).getMessagesToSend(msgIdTxn, contactId,
-					capacityForMessages, MAX_LATENCY);
-			will(returnValue(singletonList(message1.getId())));
-			// Send the message
-			oneOf(db).transactionWithNullableResult(with(true),
-					withNullableDbCallable(msgTxn));
-			oneOf(db).getMessageToSend(msgTxn, contactId, message1.getId(),
-					MAX_LATENCY, false);
-			will(returnValue(message1));
-			oneOf(recordWriter).writeMessage(message1);
-			oneOf(deferredSendHandler).onMessageSent(message1.getId());
-			// Send the end of stream marker
-			oneOf(streamWriter).sendEndOfStream();
-			// Remove listener
-			oneOf(eventBus).removeListener(session);
-		}});
-
-		session.run();
-	}
-
-	@Test
-	public void testAllCapacityUsedByAcks() throws Exception {
-		// The file has enough capacity for a max-size ack record, another
-		// ack record with one message ID, and a few bytes left over
-		long capacity = RECORD_HEADER_BYTES + MessageId.LENGTH * MAX_MESSAGE_IDS
-				+ RECORD_HEADER_BYTES + MessageId.LENGTH + MessageId.LENGTH - 1;
-
-		MailboxOutgoingSession session = new MailboxOutgoingSession(db,
-				eventBus, contactId, transportId, MAX_LATENCY,
-				streamWriter, recordWriter, deferredSendHandler, capacity);
-
-		Transaction ackIdTxn1 = new Transaction(null, true);
-		Transaction ackIdTxn2 = new Transaction(null, true);
-
-		int firstAckRecordBytes =
-				RECORD_HEADER_BYTES + MessageId.LENGTH * MAX_MESSAGE_IDS;
-		int secondAckRecordBytes = RECORD_HEADER_BYTES + MessageId.LENGTH;
-
-		List<MessageId> idsInFirstAck = new ArrayList<>(MAX_MESSAGE_IDS);
-		for (int i = 0; i < MAX_MESSAGE_IDS; i++) {
-			idsInFirstAck.add(new MessageId(getRandomId()));
-		}
-		List<MessageId> idsInSecondAck =
-				singletonList(new MessageId(getRandomId()));
-
-		context.checking(new DbExpectations() {{
-			// Add listener
-			oneOf(eventBus).addListener(session);
-			// Send the protocol versions
-			oneOf(recordWriter).writeVersions(with(any(Versions.class)));
-			// Calculate capacity for acks
-			oneOf(recordWriter).getBytesWritten();
-			will(returnValue((long) versionRecordBytes));
-			// Load the IDs for the first ack record
-			oneOf(db).transactionWithResult(with(true),
-					withDbCallable(ackIdTxn1));
-			oneOf(db).getMessagesToAck(ackIdTxn1, contactId, MAX_MESSAGE_IDS);
-			will(returnValue(idsInFirstAck));
-			// Send the first ack record
-			oneOf(recordWriter).writeAck(with(any(Ack.class)));
-			oneOf(deferredSendHandler).onAckSent(idsInFirstAck);
-			// Calculate remaining capacity for acks
-			oneOf(recordWriter).getBytesWritten();
-			will(returnValue((long) versionRecordBytes + firstAckRecordBytes));
-			// Load the IDs for the second ack record
-			oneOf(db).transactionWithResult(with(true),
-					withDbCallable(ackIdTxn2));
-			oneOf(db).getMessagesToAck(ackIdTxn2, contactId, 1);
-			will(returnValue(idsInSecondAck));
-			// Send the second ack record
-			oneOf(recordWriter).writeAck(with(any(Ack.class)));
-			oneOf(deferredSendHandler).onAckSent(idsInSecondAck);
-			// Not enough capacity left for another ack
-			oneOf(recordWriter).getBytesWritten();
-			will(returnValue((long) versionRecordBytes + firstAckRecordBytes
-					+ secondAckRecordBytes));
-			// Not enough capacity left for any messages
-			oneOf(recordWriter).getBytesWritten();
-			will(returnValue((long) versionRecordBytes + firstAckRecordBytes
-					+ secondAckRecordBytes));
-			// Send the end of stream marker
-			oneOf(streamWriter).sendEndOfStream();
-			// Remove listener
-			oneOf(eventBus).removeListener(session);
-		}});
-
-		session.run();
-	}
-}

bramble-core/src/test/java/org/briarproject/bramble/sync/SimplexOutgoingSessionTest.java

@@ -14,12 +14,18 @@ import org.briarproject.bramble.api.sync.Versions;
 import org.briarproject.bramble.api.transport.StreamWriter;
 import org.briarproject.bramble.test.BrambleMockTestCase;
 import org.briarproject.bramble.test.DbExpectations;
+import org.briarproject.bramble.test.ImmediateExecutor;
 import org.junit.Test;
 
+import java.util.LinkedHashMap;
+import java.util.Map;
+import java.util.concurrent.Executor;
+
+import static java.util.Collections.emptyMap;
 import static java.util.Collections.singletonList;
+import static org.briarproject.bramble.api.record.Record.MAX_RECORD_PAYLOAD_BYTES;
 import static org.briarproject.bramble.api.sync.SyncConstants.MAX_MESSAGE_BODY_LENGTH;
 import static org.briarproject.bramble.api.sync.SyncConstants.MAX_MESSAGE_IDS;
-import static org.briarproject.bramble.sync.SimplexOutgoingSession.BATCH_CAPACITY;
 import static org.briarproject.bramble.test.TestUtils.getContactId;
 import static org.briarproject.bramble.test.TestUtils.getMessage;
 import static org.briarproject.bramble.test.TestUtils.getRandomId;
@@ -35,18 +41,21 @@ public class SimplexOutgoingSessionTest extends BrambleMockTestCase {
 	private final SyncRecordWriter recordWriter =
 			context.mock(SyncRecordWriter.class);
 
+	private final Executor dbExecutor = new ImmediateExecutor();
 	private final ContactId contactId = getContactId();
 	private final TransportId transportId = getTransportId();
 	private final Ack ack =
 			new Ack(singletonList(new MessageId(getRandomId())));
 	private final Message message = getMessage(new GroupId(getRandomId()),
 			MAX_MESSAGE_BODY_LENGTH);
+	private final Message message1 = getMessage(new GroupId(getRandomId()),
+			MAX_MESSAGE_BODY_LENGTH);
 
 	@Test
 	public void testNothingToSend() throws Exception {
 		SimplexOutgoingSession session = new SimplexOutgoingSession(db,
-				eventBus, contactId, transportId, MAX_LATENCY,
+				dbExecutor, eventBus, contactId, transportId, MAX_LATENCY,
-				streamWriter, recordWriter);
+				false, streamWriter, recordWriter);
 
 		Transaction noAckTxn = new Transaction(null, false);
 		Transaction noMsgTxn = new Transaction(null, false);
@@ -65,7 +74,7 @@ public class SimplexOutgoingSessionTest extends BrambleMockTestCase {
 			oneOf(db).transactionWithNullableResult(with(false),
 					withNullableDbCallable(noMsgTxn));
 			oneOf(db).generateBatch(noMsgTxn, contactId,
-					BATCH_CAPACITY, MAX_LATENCY);
+					MAX_RECORD_PAYLOAD_BYTES, MAX_LATENCY);
 			will(returnValue(null));
 			// Send the end of stream marker
 			oneOf(streamWriter).sendEndOfStream();
@@ -76,11 +85,44 @@ public class SimplexOutgoingSessionTest extends BrambleMockTestCase {
 		session.run();
 	}
 
+	@Test
+	public void testNothingToSendEagerly() throws Exception {
+		SimplexOutgoingSession session = new SimplexOutgoingSession(db,
+				dbExecutor, eventBus, contactId, transportId, MAX_LATENCY,
+				true, streamWriter, recordWriter);
+
+		Transaction noAckTxn = new Transaction(null, false);
+		Transaction noIdsTxn = new Transaction(null, true);
+
+		context.checking(new DbExpectations() {{
+			// Add listener
+			oneOf(eventBus).addListener(session);
+			// Send the protocol versions
+			oneOf(recordWriter).writeVersions(with(any(Versions.class)));
+			// No acks to send
+			oneOf(db).transactionWithNullableResult(with(false),
+					withNullableDbCallable(noAckTxn));
+			oneOf(db).generateAck(noAckTxn, contactId, MAX_MESSAGE_IDS);
+			will(returnValue(null));
+			// No messages to send
+			oneOf(db).transactionWithResult(with(true),
+					withDbCallable(noIdsTxn));
+			oneOf(db).getUnackedMessagesToSend(noIdsTxn, contactId);
+			will(returnValue(emptyMap()));
+			// Send the end of stream marker
+			oneOf(streamWriter).sendEndOfStream();
+			// Remove listener
+			oneOf(eventBus).removeListener(session);
+		}});
+
+		session.run();
+	}
+
 	@Test
 	public void testSomethingToSend() throws Exception {
 		SimplexOutgoingSession session = new SimplexOutgoingSession(db,
-				eventBus, contactId, transportId, MAX_LATENCY,
+				dbExecutor, eventBus, contactId, transportId, MAX_LATENCY,
-				streamWriter, recordWriter);
+				false, streamWriter, recordWriter);
 
 		Transaction ackTxn = new Transaction(null, false);
 		Transaction noAckTxn = new Transaction(null, false);
@@ -98,23 +140,23 @@ public class SimplexOutgoingSessionTest extends BrambleMockTestCase {
 			oneOf(db).generateAck(ackTxn, contactId, MAX_MESSAGE_IDS);
 			will(returnValue(ack));
 			oneOf(recordWriter).writeAck(ack);
+			// One message to send
+			oneOf(db).transactionWithNullableResult(with(false),
+					withNullableDbCallable(msgTxn));
+			oneOf(db).generateBatch(msgTxn, contactId,
+					MAX_RECORD_PAYLOAD_BYTES, MAX_LATENCY);
+			will(returnValue(singletonList(message)));
+			oneOf(recordWriter).writeMessage(message);
 			// No more acks
 			oneOf(db).transactionWithNullableResult(with(false),
 					withNullableDbCallable(noAckTxn));
 			oneOf(db).generateAck(noAckTxn, contactId, MAX_MESSAGE_IDS);
 			will(returnValue(null));
-			// One message to send
-			oneOf(db).transactionWithNullableResult(with(false),
-					withNullableDbCallable(msgTxn));
-			oneOf(db).generateBatch(msgTxn, contactId,
-					BATCH_CAPACITY, MAX_LATENCY);
-			will(returnValue(singletonList(message)));
-			oneOf(recordWriter).writeMessage(message);
 			// No more messages
 			oneOf(db).transactionWithNullableResult(with(false),
 					withNullableDbCallable(noMsgTxn));
 			oneOf(db).generateBatch(noMsgTxn, contactId,
-					BATCH_CAPACITY, MAX_LATENCY);
+					MAX_RECORD_PAYLOAD_BYTES, MAX_LATENCY);
 			will(returnValue(null));
 			// Send the end of stream marker
 			oneOf(streamWriter).sendEndOfStream();
@@ -124,4 +166,63 @@ public class SimplexOutgoingSessionTest extends BrambleMockTestCase {
 
 		session.run();
 	}
+
+	@Test
+	public void testSomethingToSendEagerly() throws Exception {
+		SimplexOutgoingSession session = new SimplexOutgoingSession(db,
+				dbExecutor, eventBus, contactId, transportId, MAX_LATENCY,
+				true, streamWriter, recordWriter);
+
+		Map<MessageId, Integer> unacked = new LinkedHashMap<>();
+		unacked.put(message.getId(), message.getRawLength());
+		unacked.put(message1.getId(), message1.getRawLength());
+
+		Transaction ackTxn = new Transaction(null, false);
+		Transaction noAckTxn = new Transaction(null, false);
+		Transaction idsTxn = new Transaction(null, true);
+		Transaction msgTxn = new Transaction(null, false);
+		Transaction msgTxn1 = new Transaction(null, false);
+
+		context.checking(new DbExpectations() {{
+			// Add listener
+			oneOf(eventBus).addListener(session);
+			// Send the protocol versions
+			oneOf(recordWriter).writeVersions(with(any(Versions.class)));
+			// One ack to send
+			oneOf(db).transactionWithNullableResult(with(false),
+					withNullableDbCallable(ackTxn));
+			oneOf(db).generateAck(ackTxn, contactId, MAX_MESSAGE_IDS);
+			will(returnValue(ack));
+			oneOf(recordWriter).writeAck(ack);
+			// No more acks
+			oneOf(db).transactionWithNullableResult(with(false),
+					withNullableDbCallable(noAckTxn));
+			oneOf(db).generateAck(noAckTxn, contactId, MAX_MESSAGE_IDS);
+			will(returnValue(null));
+			// Two messages to send
+			oneOf(db).transactionWithResult(with(true), withDbCallable(idsTxn));
+			oneOf(db).getUnackedMessagesToSend(idsTxn, contactId);
+			will(returnValue(unacked));
+			// Send the first message
+			oneOf(db).transactionWithResult(with(false),
+					withDbCallable(msgTxn));
+			oneOf(db).generateBatch(msgTxn, contactId,
+					singletonList(message.getId()), MAX_LATENCY);
+			will(returnValue(singletonList(message)));
+			oneOf(recordWriter).writeMessage(message);
+			// Send the second message
+			oneOf(db).transactionWithResult(with(false),
+					withDbCallable(msgTxn1));
+			oneOf(db).generateBatch(msgTxn1, contactId,
+					singletonList(message1.getId()), MAX_LATENCY);
+			will(returnValue(singletonList(message1)));
+			oneOf(recordWriter).writeMessage(message1);
+			// Send the end of stream marker
+			oneOf(streamWriter).sendEndOfStream();
+			// Remove listener
+			oneOf(eventBus).removeListener(session);
+		}});
+
+		session.run();
+	}
 }

bramble-core/src/test/java/org/briarproject/bramble/system/TestTaskScheduler.java

@@ -1,6 +1,5 @@
 package org.briarproject.bramble.system;
 
-import org.briarproject.bramble.api.Cancellable;
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.bramble.api.system.Clock;
 import org.briarproject.bramble.api.system.TaskScheduler;

bramble-core/src/test/java/org/briarproject/bramble/transport/agreement/TransportKeyAgreementIntegrationTest.java

@@ -345,17 +345,11 @@ public class TransportKeyAgreementIntegrationTest
 					.canSendOutgoingStreams(aliceId, DUPLEX_TRANSPORT_ID));
 		}
 
-		// Sync client versioning update from Alice to Bob
+		// Sync initial client versioning updates
 		syncMessage(alice, bob, bobId, 1, true);
-		// Sync client versioning update and ack from Bob to Alice
 		syncMessage(bob, alice, aliceId, 1, true);
-		// Sync second client versioning update, mailbox properties and ack
+		syncMessage(alice, bob, bobId, 1, true);
-		// from Alice to Bob
+		sendAcks(bob, alice, aliceId, 1);
-		syncMessage(alice, bob, bobId, 2, true);
-		// Sync mailbox properties and ack from Bob to Alice
-		syncMessage(bob, alice, aliceId, 1, true);
-		// Sync final ack from Alice to Bob
-		sendAcks(alice, bob, bobId, 1);
 
 		return new Pair<>(aliceId, bobId);
 	}

bramble-core/witness.gradle

@@ -35,7 +35,7 @@ dependencyVerification {
         'org.apache-extras.beanshell:bsh:2.0b6:bsh-2.0b6.jar:a17955976070c0573235ee662f2794a78082758b61accffce8d3f8aedcd91047',
         'org.bitlet:weupnp:0.1.4:weupnp-0.1.4.jar:88df7e6504929d00bdb832863761385c68ab92af945b04f0770b126270a444fb',
         'org.bouncycastle:bcprov-jdk15to18:1.70:bcprov-jdk15to18-1.70.jar:7df4c54f29ce2dd616dc3b198ca4db3dfcc79e3cb397c084a0aff97b85c0bf38',
-        'org.briarproject:jtorctl:0.4:jtorctl-0.4.jar:4e61f59dc9f3984438a7151c4df8d7c1f83d5fb3eb8c151acfc794a8fef85a36',
+        'org.briarproject:jtorctl:0.3:jtorctl-0.3.jar:f2939238a097898998432effe93b0334d97a787972ab3a91a8973a1d309fc864',
         'org.checkerframework:checker-compat-qual:2.5.3:checker-compat-qual-2.5.3.jar:d76b9afea61c7c082908023f0cbc1427fab9abd2df915c8b8a3e7a509bccbc6d',
         'org.checkerframework:checker-qual:2.5.2:checker-qual-2.5.2.jar:64b02691c8b9d4e7700f8ee2e742dce7ea2c6e81e662b7522c9ee3bf568c040a',
         'org.codehaus.mojo.signature:java16:1.1:java16-1.1.signature:53799223a2c98dba2d0add810bed76315460df285c69e4f397ae6098f87dd619',

bramble-java/src/main/java/org/briarproject/bramble/plugin/tor/UnixTorPluginFactory.java

@@ -9,9 +9,13 @@ import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
 import org.briarproject.bramble.api.plugin.Backoff;
 import org.briarproject.bramble.api.plugin.BackoffFactory;
 import org.briarproject.bramble.api.plugin.PluginCallback;
+import org.briarproject.bramble.api.plugin.TorConstants;
 import org.briarproject.bramble.api.plugin.TorControlPort;
 import org.briarproject.bramble.api.plugin.TorDirectory;
 import org.briarproject.bramble.api.plugin.TorSocksPort;
+import org.briarproject.bramble.api.plugin.TransportId;
+import org.briarproject.bramble.api.plugin.duplex.DuplexPlugin;
+import org.briarproject.bramble.api.plugin.duplex.DuplexPluginFactory;
 import org.briarproject.bramble.api.system.Clock;
 import org.briarproject.bramble.api.system.LocationUtils;
 import org.briarproject.bramble.api.system.ResourceProvider;
@@ -19,18 +23,43 @@ import org.briarproject.bramble.api.system.WakefulIoExecutor;
 
 import java.io.File;
 import java.util.concurrent.Executor;
+import java.util.logging.Logger;
 
-import javax.annotation.Nullable;
 import javax.annotation.concurrent.Immutable;
 import javax.inject.Inject;
 import javax.net.SocketFactory;
 
 import static java.util.logging.Level.INFO;
+import static java.util.logging.Logger.getLogger;
 import static org.briarproject.bramble.util.OsUtils.isLinux;
 
 @Immutable
 @NotNullByDefault
-public class UnixTorPluginFactory extends TorPluginFactory {
+public class UnixTorPluginFactory implements DuplexPluginFactory {
+
+	private static final Logger LOG =
+			getLogger(UnixTorPluginFactory.class.getName());
+
+	private static final int MAX_LATENCY = 30 * 1000; // 30 seconds
+	private static final int MAX_IDLE_TIME = 30 * 1000; // 30 seconds
+	private static final int MIN_POLLING_INTERVAL = 60 * 1000; // 1 minute
+	private static final int MAX_POLLING_INTERVAL = 10 * 60 * 1000; // 10 mins
+	private static final double BACKOFF_BASE = 1.2;
+
+	private final Executor ioExecutor, wakefulIoExecutor;
+	private final NetworkManager networkManager;
+	private final LocationUtils locationUtils;
+	private final EventBus eventBus;
+	private final SocketFactory torSocketFactory;
+	private final BackoffFactory backoffFactory;
+	private final ResourceProvider resourceProvider;
+	private final CircumventionProvider circumventionProvider;
+	private final BatteryManager batteryManager;
+	private final Clock clock;
+	private final File torDirectory;
+	private int torSocksPort;
+	private int torControlPort;
+	private final CryptoComponent crypto;
 
 	@Inject
 	UnixTorPluginFactory(@IoExecutor Executor ioExecutor,
@@ -44,39 +73,74 @@ public class UnixTorPluginFactory extends TorPluginFactory {
 			CircumventionProvider circumventionProvider,
 			BatteryManager batteryManager,
 			Clock clock,
-			CryptoComponent crypto,
 			@TorDirectory File torDirectory,
 			@TorSocksPort int torSocksPort,
-			@TorControlPort int torControlPort) {
+			@TorControlPort int torControlPort,
-		super(ioExecutor, wakefulIoExecutor, networkManager, locationUtils,
+			CryptoComponent crypto) {
-				eventBus, torSocketFactory, backoffFactory, resourceProvider,
+		this.ioExecutor = ioExecutor;
-				circumventionProvider, batteryManager, clock, crypto,
+		this.wakefulIoExecutor = wakefulIoExecutor;
-				torDirectory, torSocksPort, torControlPort);
+		this.networkManager = networkManager;
+		this.locationUtils = locationUtils;
+		this.eventBus = eventBus;
+		this.torSocketFactory = torSocketFactory;
+		this.backoffFactory = backoffFactory;
+		this.resourceProvider = resourceProvider;
+		this.circumventionProvider = circumventionProvider;
+		this.batteryManager = batteryManager;
+		this.clock = clock;
+		this.torDirectory = torDirectory;
+		this.torSocksPort = torSocksPort;
+		this.torControlPort = torControlPort;
+		this.crypto = crypto;
 	}
 
-	@Nullable
 	@Override
-	String getArchitectureForTorBinary() {
+	public TransportId getId() {
-		if (!isLinux()) return null;
+		return TorConstants.ID;
-		String arch = System.getProperty("os.arch");
+	}
-		if (LOG.isLoggable(INFO)) {
+
-			LOG.info("System's os.arch is " + arch);
+	@Override
+	public long getMaxLatency() {
+		return MAX_LATENCY;
+	}
+
+	@Override
+	public DuplexPlugin createPlugin(PluginCallback callback) {
+		// Check that we have a Tor binary for this architecture
+		String architecture = null;
+		if (isLinux()) {
+			String arch = System.getProperty("os.arch");
+			if (LOG.isLoggable(INFO)) {
+				LOG.info("System's os.arch is " + arch);
+			}
+			if (arch.equals("amd64")) {
+				architecture = "linux-x86_64";
+			} else if (arch.equals("aarch64")) {
+				architecture = "linux-aarch64";
+			} else if (arch.equals("arm")) {
+				architecture = "linux-armhf";
+			}
+		}
+		if (architecture == null) {
+			LOG.info("Tor is not supported on this architecture");
+			return null;
 		}
-		if (arch.equals("amd64")) return "linux-x86_64";
-		else if (arch.equals("aarch64")) return "linux-aarch64";
-		else if (arch.equals("arm")) return "linux-armhf";
-		return null;
-	}
 
-	@Override
+		if (LOG.isLoggable(INFO)) {
-	TorPlugin createPluginInstance(Backoff backoff,
+			LOG.info("The selected architecture for Tor is " + architecture);
-			TorRendezvousCrypto torRendezvousCrypto, PluginCallback callback,
+		}
-			String architecture) {
+
-		return new UnixTorPlugin(ioExecutor, wakefulIoExecutor,
+		Backoff backoff = backoffFactory.createBackoff(MIN_POLLING_INTERVAL,
+				MAX_POLLING_INTERVAL, BACKOFF_BASE);
+		TorRendezvousCrypto torRendezvousCrypto =
+				new TorRendezvousCryptoImpl(crypto);
+		UnixTorPlugin plugin = new UnixTorPlugin(ioExecutor, wakefulIoExecutor,
 				networkManager, locationUtils, torSocketFactory, clock,
 				resourceProvider, circumventionProvider, batteryManager,
 				backoff, torRendezvousCrypto, callback, architecture,
 				MAX_LATENCY, MAX_IDLE_TIME, torDirectory, torSocksPort,
 				torControlPort);
+		eventBus.addListener(plugin);
+		return plugin;
 	}
 }

bramble-java/src/test/java/org/briarproject/bramble/plugin/tor/BridgeTest.java

@@ -89,9 +89,6 @@ public class BridgeTest extends BrambleTestCase {
 	private final static long MEEK_TIMEOUT = MINUTES.toMillis(6);
 	private final static int UNREACHABLE_BRIDGES_ALLOWED = 6;
 	private final static int ATTEMPTS_PER_BRIDGE = 5;
-	// Use different ports from Briar Desktop to avoid conflicts
-	private final static int SOCKS_PORT = DEFAULT_SOCKS_PORT + 10;
-	private final static int CONTROL_PORT = DEFAULT_CONTROL_PORT + 10;
 
 	private final static Logger LOG = getLogger(BridgeTest.class.getName());
 
@@ -167,8 +164,8 @@ public class BridgeTest extends BrambleTestCase {
 		factory = new UnixTorPluginFactory(ioExecutor, wakefulIoExecutor,
 				networkManager, locationUtils, eventBus, torSocketFactory,
 				backoffFactory, resourceProvider, bridgeProvider,
-				batteryManager, clock, crypto, torDir,
+				batteryManager, clock, torDir, DEFAULT_SOCKS_PORT,
-				SOCKS_PORT, CONTROL_PORT);
+				DEFAULT_CONTROL_PORT, crypto);
 	}
 
 	@After

briar-android/build.gradle

@@ -26,8 +26,8 @@ android {
 	defaultConfig {
 		minSdkVersion 16
 		targetSdkVersion 30
-		versionCode 10408
+		versionCode 10406
-		versionName "1.4.8"
+		versionName "1.4.6"
 		applicationId "org.briarproject.briar.android"
 
 		vectorDrawables.useSupportLibrary = true
@@ -100,7 +100,6 @@ dependencies {
 	implementation project(path: ':briar-core', configuration: 'default')
 	implementation project(path: ':bramble-core', configuration: 'default')
 	implementation project(':bramble-android')
-	implementation 'org.briarproject:dont-kill-me-lib:0.2.2'
 
 	implementation 'androidx.fragment:fragment:1.3.4'
 	implementation 'androidx.preference:preference:1.1.1'
@@ -115,7 +114,7 @@ dependencies {
 	implementation 'de.hdodenhof:circleimageview:3.1.0'
 	implementation 'com.google.zxing:core:3.3.3'  // newer version need minSdk 24
 	implementation 'uk.co.samuelwall:material-tap-target-prompt:3.3.0'
-	implementation 'com.vanniktech:emoji-google:0.7.0' // newer versions need minSdk 21
+	implementation 'com.vanniktech:emoji-google:0.6.0' // newer versions need minSdk 21
 	implementation 'com.github.kobakei:MaterialFabSpeedDial:1.2.1'
 	implementation 'com.github.chrisbanes:PhotoView:2.3.0'
 	def glideVersion = '4.11.0'