Update lint suppressions.

briar-android/src/main/java/org/briarproject/bramble/account/BriarAccountManager.java

@@ -25,7 +25,7 @@ class BriarAccountManager extends AndroidAccountManager {
 	public void deleteAccount() {
 		synchronized (stateChangeLock) {
 			super.deleteAccount();
-			Localizer.reinitialize();
+			Localizer.reinitialize(appContext);
 			UiUtils.setTheme(appContext,
 					appContext.getString(R.string.pref_theme_light_value));
 		}

briar-android/src/main/java/org/briarproject/briar/android/AndroidNotificationManagerImpl.java

@@ -579,6 +579,7 @@ class AndroidNotificationManagerImpl implements AndroidNotificationManager,
 
 	@UiThread
 	private void updateContactAddedNotification() {
+		if (contactAddedTotal == 0) return;
 		BriarNotificationBuilder b =
 				new BriarNotificationBuilder(appContext, CONTACT_CHANNEL_ID);
 		b.setSmallIcon(R.drawable.notification_contact_added);
@@ -713,4 +714,16 @@ class AndroidNotificationManagerImpl implements AndroidNotificationManager,
 	public void unblockAllBlogPostNotifications() {
 		androidExecutor.runOnUiThread((Runnable) () -> blockBlogs = false);
 	}
+
+	@Override
+	public void restartNotifications(boolean locked, boolean mayAlertAgain) {
+		androidExecutor.runOnUiThread(() -> {
+			updateForegroundNotification(locked);
+			updateContactNotification(mayAlertAgain);
+			updateBlogPostNotification(mayAlertAgain);
+			updateForumPostNotification(mayAlertAgain);
+			updateGroupMessageNotification(mayAlertAgain);
+			updateContactAddedNotification();
+		});
+	}
 }

briar-android/src/main/java/org/briarproject/briar/android/BriarApplicationImpl.java

@@ -81,6 +81,7 @@ public class BriarApplicationImpl extends Application
 		rootLogger.setLevel(IS_DEBUG_BUILD ? FINE : INFO);
 
 		LOG.info("Created");
+		Localizer.getInstance().setLocaleLegacy(this);
 
 		EmojiManager.install(new GoogleEmojiProvider());
 	}
@@ -104,7 +105,9 @@ public class BriarApplicationImpl extends Application
 	@Override
 	public void onConfigurationChanged(@NonNull Configuration newConfig) {
 		super.onConfigurationChanged(newConfig);
-		Localizer.getInstance().setLocale(this);
+		Localizer.getInstance().applicationConfigurationChanged(this, newConfig,
+				applicationComponent.androidNotificationManager(),
+				applicationComponent.lockManager().isLocked());
 	}
 
 	private void setTheme(Context ctx, SharedPreferences prefs) {

briar-android/src/main/java/org/briarproject/briar/android/Localizer.java

@@ -6,12 +6,16 @@ import android.content.res.Configuration;
 import android.content.res.Resources;
 
 import org.briarproject.bramble.api.nullsafety.NotNullByDefault;
+import org.briarproject.briar.api.android.AndroidNotificationManager;
 
 import java.util.Locale;
 
 import javax.annotation.Nullable;
 
+import androidx.core.text.TextUtilsCompat;
+
 import static android.os.Build.VERSION.SDK_INT;
+import static androidx.core.view.ViewCompat.LAYOUT_DIRECTION_LTR;
 import static org.briarproject.briar.android.settings.SettingsFragment.LANGUAGE;
 
 @NotNullByDefault
@@ -21,6 +25,7 @@ public class Localizer {
 	@Nullable
 	private static Localizer INSTANCE;
 	private final Locale systemLocale;
+	@Nullable
 	private final Locale locale;
 
 	private Localizer(SharedPreferences sharedPreferences) {
@@ -30,10 +35,17 @@ public class Localizer {
 
 	private Localizer(Locale systemLocale, @Nullable Locale userLocale) {
 		this.systemLocale = systemLocale;
-		if (userLocale == null) locale = systemLocale;
+		locale = userLocale;
-		else locale = userLocale;
+		setLocaleAndSystemConfiguration(locale);
 	}
 
+	private Localizer(Locale systemLocale) {
+		this.systemLocale = systemLocale;
+		locale = null;
+		setLocaleAndSystemConfiguration(systemLocale);
+	}
+
+
 	// Instantiate the Localizer.
 	public static synchronized void initialize(SharedPreferences prefs) {
 		if (INSTANCE == null)
@@ -41,9 +53,11 @@ public class Localizer {
 	}
 
 	// Reinstantiate the Localizer with the system locale
-	public static synchronized void reinitialize() {
+	public static synchronized void reinitialize(Context appContext) {
-		if (INSTANCE != null)
+		if (INSTANCE != null && INSTANCE.locale != null) {
-			INSTANCE = new Localizer(INSTANCE.systemLocale, null);
+			INSTANCE = new Localizer(INSTANCE.systemLocale);
+			INSTANCE.forceLocale(appContext, INSTANCE.systemLocale);
+		}
 	}
 
 	// Get the current instance.
@@ -64,29 +78,98 @@ public class Localizer {
 		if (tag.contains("-")) {
 			String[] langArray = tag.split("-");
 			return new Locale(langArray[0], langArray[1]);
-		} else
+		} else {
 			return new Locale(tag);
 		}
+	}
 
 	// Returns the localized version of context
 	public Context setLocale(Context context) {
+		if (locale == null || SDK_INT < 17) return context;
 		Resources res = context.getResources();
 		Configuration conf = res.getConfiguration();
-		Locale currentLocale;
+		updateConfiguration(conf, locale);
-		if (SDK_INT >= 24) {
+		return context.createConfigurationContext(conf);
-			currentLocale = conf.getLocales().get(0);
+	}
-		} else
+
-			currentLocale = conf.locale;
+	// For API < 17 only.
-		if (locale.equals(currentLocale))
+	public void setLocaleLegacy(Context appContext) {
-			return context;
+		if (SDK_INT >= 17 || locale == null) return;
-		Locale.setDefault(locale);
+		forceLocale(appContext, locale);
+	}
+
+	// Forces the update of the resources through the deprecated API.
+	private void forceLocale(Context context, Locale locale) {
+		Resources res = context.getResources();
+		Configuration conf = res.getConfiguration();
+		updateConfiguration(conf, locale);
+		res.updateConfiguration(conf, res.getDisplayMetrics());
+	}
+
+	private void updateConfiguration(Configuration conf, Locale locale) {
 		if (SDK_INT >= 17) {
 			conf.setLocale(locale);
-			context.createConfigurationContext(conf);
+		} else {
-		} else
 			conf.locale = locale;
+		}
+	}
+
+	private void setLocaleAndSystemConfiguration(@Nullable Locale locale) {
+		if (locale == null) return;
+		Locale.setDefault(locale);
+		if (SDK_INT >= 23) return;
+		Resources systemResources = Resources.getSystem();
+		Configuration systemConfiguration = systemResources.getConfiguration();
+		updateConfiguration(systemConfiguration, locale);
+		// DateUtils uses the system resources, so we need to update them too.
 		//noinspection deprecation
-		res.updateConfiguration(conf, res.getDisplayMetrics());
+		systemResources.updateConfiguration(systemConfiguration,
-		return context;
+				systemResources.getDisplayMetrics());
+	}
+
+	private Locale getLocaleFromConfig(Configuration config) {
+		if (SDK_INT >= 24) {
+			return config.getLocales().get(0);
+		} else {
+			//noinspection deprecation
+			return config.locale;
 		}
 	}
+
+	public void applicationConfigurationChanged(Context appContext,
+			Configuration newConfig,
+			AndroidNotificationManager androidNotificationManager,
+			boolean locked) {
+		Locale newLocale = getLocaleFromConfig(newConfig);
+		if (locale == null && newLocale != systemLocale) {
+			androidNotificationManager.restartNotifications(locked, false);
+		}
+		if (newLocale == locale) return;
+		setLocaleAndSystemConfiguration(locale);
+		if (SDK_INT < 17) setLocaleLegacy(appContext);
+	}
+
+	/**
+	 * Indicates whether the language represented by locale
+	 * should be offered to the user on this device.
+	 * * Android doesn't pick up Asturian on API < 21
+	 * * RTL languages are supported since API >= 17
+	 */
+	public static boolean isLocaleSupported(Locale locale) {
+		if (SDK_INT >= 21) return true;
+		if (locale.getLanguage().equals("ast")) return false;
+		if (SDK_INT >= 17) return true;
+		return isLeftToRight(locale);
+	}
+
+	// Exclude RTL locales on API < 17, they won't be laid out correctly
+	private static boolean isLeftToRight(Locale locale) {
+		// TextUtilsCompat returns the wrong direction for Hebrew on some phones
+		String language = locale.getLanguage();
+		if (language.equals("iw") || language.equals("he")) return false;
+		int direction =
+				TextUtilsCompat.getLayoutDirectionFromLocale(locale);
+		return direction == LAYOUT_DIRECTION_LTR;
+	}
+
+}

briar-android/src/main/java/org/briarproject/briar/android/settings/SettingsFragment.java

@@ -44,7 +44,6 @@ import javax.inject.Inject;
 import androidx.annotation.Nullable;
 import androidx.annotation.StringRes;
 import androidx.core.content.ContextCompat;
-import androidx.core.text.TextUtilsCompat;
 import androidx.preference.ListPreference;
 import androidx.preference.Preference;
 import androidx.preference.Preference.OnPreferenceChangeListener;
@@ -70,7 +69,6 @@ import static android.provider.Settings.EXTRA_APP_PACKAGE;
 import static android.provider.Settings.EXTRA_CHANNEL_ID;
 import static android.provider.Settings.System.DEFAULT_NOTIFICATION_URI;
 import static android.widget.Toast.LENGTH_SHORT;
-import static androidx.core.view.ViewCompat.LAYOUT_DIRECTION_LTR;
 import static java.util.Objects.requireNonNull;
 import static java.util.logging.Level.INFO;
 import static java.util.logging.Level.WARNING;
@@ -296,13 +294,20 @@ public class SettingsFragment extends PreferenceFragmentCompat
 			Locale locale = Localizer.getLocaleFromTag(tag);
 			if (locale == null)
 				throw new IllegalStateException();
-			// Exclude RTL locales on API < 17, they won't be laid out correctly
+			// Check if the locale is supported on this device
-			if (SDK_INT < 17 && !isLeftToRight(locale)) {
+			if (!Localizer.isLocaleSupported(locale)) {
 				if (LOG.isLoggable(INFO))
-					LOG.info("Skipping RTL locale " + tag);
+					LOG.info("Skipping unsupported locale " + tag);
 				continue;
 			}
-			String nativeName = locale.getDisplayName(locale);
+			String nativeName;
+			// Unknown languages won't be translated to their native name.
+			if (locale.getLanguage().equals("ast")) {
+				nativeName = "Asturianu";
+			} else if (locale.getLanguage().equals("oc")) {
+				nativeName = "Occitan";
+			} else {
+				nativeName = locale.getDisplayName(locale);
 				// Fallback to English if the name is unknown in both native and
 				// current locale.
 				if (nativeName.equals(tag)) {
@@ -310,6 +315,7 @@ public class SettingsFragment extends PreferenceFragmentCompat
 					if (!tmp.isEmpty() && !tmp.equals(nativeName))
 						nativeName = tmp;
 				}
+			}
 			// Prefix with LRM marker to prevent any RTL direction
 			entries.add("\u200E" + nativeName.substring(0, 1).toUpperCase()
 					+ nativeName.substring(1));
@@ -319,13 +325,6 @@ public class SettingsFragment extends PreferenceFragmentCompat
 		language.setEntryValues(entryValues.toArray(new CharSequence[0]));
 	}
 
-	private boolean isLeftToRight(Locale locale) {
-		// TextUtilsCompat returns the wrong direction for Hebrew on some phones
-		String language = locale.getLanguage();
-		if (language.equals("iw") || language.equals("he")) return false;
-		int direction = TextUtilsCompat.getLayoutDirectionFromLocale(locale);
-		return direction == LAYOUT_DIRECTION_LTR;
-	}
 
 	private void setTorNetworkSummary(int torNetworkSetting) {
 		if (torNetworkSetting != PREF_TOR_NETWORK_AUTOMATIC) {

briar-android/src/main/java/org/briarproject/briar/api/android/AndroidNotificationManager.java

@@ -93,4 +93,7 @@ public interface AndroidNotificationManager {
 	void blockAllBlogPostNotifications();
 
 	void unblockAllBlogPostNotifications();
+
+	void restartNotifications(boolean locked, boolean mayAlertAgain);
+
 }