Kaladaran/briar
0
0
Fork 0
mirror of https://code.briarproject.org/briar/briar.git synced 2026-02-19 22:29:53 +01:00
Code Issues Projects Releases Wiki Activity

akwizgran
2016-04-13 10:45:07 +00:00
parent e7d4bc2747
commit 3f62d401db
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
development-workflow.md

@@ -13,8 +13,8 @@
* At least one other person must review your code before it's merged to master * At least one other person must review your code before it's merged to master
* You should address all the reviewer's comments before merging * You should address all the reviewer's comments before merging
* If a comment is better dealt with as a separate ticket after merging, create a ticket and reply with the ticket number * If an issue needs to be fixed before merging, push the fix to your branch and let the reviewer know
* Let the reviewer know when all the comments have been addressed * If an issue is better dealt with after merging, create a ticket and reply with the ticket number
* Once your branch has been merged you can delete the remote branch * Once your branch has been merged you can delete the remote branch
* When reviewing a branch: * When reviewing a branch:
* Check out and run the code as well as reading it * Check out and run the code as well as reading it
@@ -23,7 +23,7 @@
# Tests # Tests
* Before opening a merge request, make sure the tests still pass * Run the tests before putting a branch up for review
* To run the tests in Android Studio: * To run the tests in Android Studio:
* Select 'Run > Edit Configurations' from the menu * Select 'Run > Edit Configurations' from the menu
* Click '+' and select 'JUnit' * Click '+' and select 'JUnit'