From 4f1057e6ec507f79daa238896e929afde5b2096b Mon Sep 17 00:00:00 2001
From: Torsten Grote <t@grobox.de>
Date: Tue, 26 Jan 2021 11:28:44 +0000
Subject: [PATCH] Android UI - Icon Drawables

---
 pre-review-checklist.md | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/pre-review-checklist.md b/pre-review-checklist.md
index 6d308ee..ec26f15 100644
--- a/pre-review-checklist.md
+++ b/pre-review-checklist.md
@@ -1,3 +1,5 @@
+## Java
+
 #### Thread safety
 * Classes should be immutable where possible
 * Classes that may be used by multiple threads must be thread-safe
@@ -31,3 +33,13 @@
 * Use dedicated lock objects rather than `synchronized`
 * Don't call into other classes while holding locks
 * Don't start database transactions while holding locks
+
+## Android UI
+
+#### Icon Drawables
+
+* Use `app:srcCompat` instead of `android:src` to define drawables in XML files
+* Use `setImageResource()` to set icons instead of `setImageDrawable()`
+* If you need to set a drawable directly, but can't use `setImageResource()`, use `VectorDrawableCompat.create()` to get the drawable
+* Don't use vector(-only) drawables for notification icons (unless that's supported now)
+* Test icon display on API < 21
\ No newline at end of file