From 74d580c73073684f1b3f8005bc1b43756a401275 Mon Sep 17 00:00:00 2001 From: Sebastian Date: Wed, 29 Jun 2022 11:47:34 +0000 Subject: [PATCH] Update pre review checklist --- pre-review-checklist.md | 1 + 1 file changed, 1 insertion(+) diff --git a/pre-review-checklist.md b/pre-review-checklist.md index ec26f15..18fb945 100644 --- a/pre-review-checklist.md +++ b/pre-review-checklist.md @@ -23,6 +23,7 @@ * Use checked exceptions rather than special return values to indicate errors * Unchecked exceptions should only be used for programming errors * If you catch an InterruptedException in a synchronous method, interrupt the current thread so the caller learns about the interrupt +* RuntimeExceptions thrown by our own code are expected to crash the app, and RuntimeExceptions thrown by libraries should either be caught immediately or allowed to escape and crash the app - but shouldn't be allowed to propagate through layers of our own code before being caught. #### Blocking * Don't call blocking methods from the UI thread