From 1358aaa705cc4cd026ae5090959ae07837e2327f Mon Sep 17 00:00:00 2001
From: Sirttas <sophiegaelle.calloch@gmail.com>
Date: Sun, 31 May 2026 18:33:35 +0200
Subject: [PATCH] cleanup routes names

---
 src/App.vue                                |  3 +-
 src/market/type/MarketTypeLabel.vue        |  3 +-
 src/pages/Market.vue                       |  3 +-
 src/pages/Rules.vue                        |  4 +--
 src/pages/market/TypeInfo.vue              |  3 +-
 src/pages/rules/EditRuleBook.vue           |  3 +-
 src/pages/rules/ListCharacterRuleBooks.vue |  3 +-
 src/pages/rules/ListRuleBooks.vue          |  5 ++--
 src/routes.ts                              | 35 +++++++++++++++-------
 src/sidebar/Sidebar.vue                    |  3 +-
 10 files changed, 43 insertions(+), 22 deletions(-)

diff --git a/src/App.vue b/src/App.vue
index 5dfade2..80efca1 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -2,11 +2,12 @@
 import { computed } from 'vue';
 import { RouterView, useRoute } from 'vue-router';
 import { Sidebar } from './sidebar';
+import { routeNames } from '@/routes';
 
 const route = useRoute();
 
 const hideSidebar = computed(() => {
-    return route.name === 'callback' || route.name === 'about';
+    return route.name === routeNames.callback || route.name === routeNames.about;
 });
 </script>
 
diff --git a/src/market/type/MarketTypeLabel.vue b/src/market/type/MarketTypeLabel.vue
index 3584c70..3eade8e 100644
--- a/src/market/type/MarketTypeLabel.vue
+++ b/src/market/type/MarketTypeLabel.vue
@@ -1,6 +1,7 @@
 <script setup lang="ts">
 import { ClipboardButton } from '@/components';
 import { InformationCircleIcon } from '@heroicons/vue/24/outline';
+import { routeNames } from '@/routes';
 
 
 interface Props {
@@ -21,7 +22,7 @@ withDefaults(defineProps<Props>(), {
         <img v-if="id" :src="`https://images.evetech.net/types/${id}/icon?size=32`" class="inline-block w-5 h-5 me-1 mt-1" alt="" />
         <template v-if="name">
             {{ name }}
-            <RouterLink v-if="id" :to="{ name: 'market-types', params: { type: id } }" class="button btn-icon ms-1 me-1 mt-1" title="Show item info">
+            <RouterLink v-if="id" :to="{ name: routeNames.marketTypes, params: { type: id } }" class="button btn-icon ms-1 me-1 mt-1" title="Show item info">
                 <InformationCircleIcon  />
             </RouterLink>
             <ClipboardButton v-if="!hideCopy" :value="name" />
diff --git a/src/pages/Market.vue b/src/pages/Market.vue
index d4cc44c..712fcfe 100644
--- a/src/pages/Market.vue
+++ b/src/pages/Market.vue
@@ -1,11 +1,12 @@
 <script setup lang="ts">
 import {RouterLink, RouterView} from 'vue-router';
+import {routeNames} from '@/routes';
 </script>
 
 <template>
     <div class="mt-4">
         <div class="flex border-b-2 border-emerald-500">
-            <RouterLink :to="{name: 'market-types'}" class="tab">
+            <RouterLink :to="{name: routeNames.marketTypes}" class="tab">
                 <span>Item Info</span>
             </RouterLink>
             <RouterLink to="/market/tracking" class="tab">
diff --git a/src/pages/Rules.vue b/src/pages/Rules.vue
index 24db91c..f72f708 100644
--- a/src/pages/Rules.vue
+++ b/src/pages/Rules.vue
@@ -1,12 +1,12 @@
 <script setup lang="ts">
-
 import {RouterLink, RouterView} from "vue-router";
+import {routeNames} from '@/routes';
 </script>
 
 <template>
   <div class="mt-4">
     <div class="flex border-b-2 border-emerald-500">
-      <RouterLink :to="{ name: 'list-rule-books' }" class="tab">
+      <RouterLink :to="{ name: routeNames.listRuleBooks }" class="tab">
         <span>Rule Books</span>
       </RouterLink>
       <RouterLink to="/characters/rules" class="tab">
diff --git a/src/pages/market/TypeInfo.vue b/src/pages/market/TypeInfo.vue
index 5e339bf..9622471 100644
--- a/src/pages/market/TypeInfo.vue
+++ b/src/pages/market/TypeInfo.vue
@@ -7,6 +7,7 @@ import {BookmarkIcon, BookmarkSlashIcon, ShoppingCartIcon} from '@heroicons/vue/
 import log from "loglevel";
 import {computed, ref, watch} from "vue";
 import {useRoute, useRouter} from "vue-router";
+import {routeNames} from "@/routes";
 import {computedAsync} from "@vueuse/core";
 
 const buyModal = ref<typeof BuyModal>();
@@ -52,7 +53,7 @@ const view = () => {
     }
 
     router.push({
-        name: 'market-types',
+        name: routeNames.marketTypes,
         params: {
             type: inputItem.value.id
         }
diff --git a/src/pages/rules/EditRuleBook.vue b/src/pages/rules/EditRuleBook.vue
index 56fb677..6b06ff6 100644
--- a/src/pages/rules/EditRuleBook.vue
+++ b/src/pages/rules/EditRuleBook.vue
@@ -5,6 +5,7 @@ import {useDebounceFn} from "@vueuse/core";
 import log from "loglevel";
 import {activityTypes, RuleInput, Rules, useRuleBooksStore} from "@/rules";
 import {PlusIcon, TrashIcon} from "@heroicons/vue/24/outline";
+import {routeNames} from "@/routes";
 
 const ruleBookId = ref<string>();
 const name = ref<string>('');
@@ -21,7 +22,7 @@ const save = async () => {
       ledgerRefs: ledgerRefs.value,
       rules: rules.value
     })
-    await router.push({ name: 'edit-rule-book', params: {ruleBookId: created.ruleBookId}})
+    await router.push({ name: routeNames.editRuleBook, params: {ruleBookId: created.ruleBookId}})
 
   } else {
     await update(ruleBookId.value, {
diff --git a/src/pages/rules/ListCharacterRuleBooks.vue b/src/pages/rules/ListCharacterRuleBooks.vue
index 8c5ca3d..011f9ff 100644
--- a/src/pages/rules/ListCharacterRuleBooks.vue
+++ b/src/pages/rules/ListCharacterRuleBooks.vue
@@ -2,6 +2,7 @@
 import {storeToRefs} from "pinia";
 import {CharacterLabel, useCharactersStore} from "@/characters";
 import {PencilSquareIcon} from "@heroicons/vue/24/outline";
+import {routeNames} from "@/routes";
 
 const {characters} = storeToRefs(useCharactersStore());
 
@@ -11,7 +12,7 @@ const {characters} = storeToRefs(useCharactersStore());
   <div class="grid mb-2 mt-4">
     <div v-for="character in characters" :key="character.characterId" class="flex items-center mb-2">
       <CharacterLabel class="flex grow" :character="character" />
-      <RouterLink class="btn-icon ms-2" :to="{ name: 'character-rulebook', params: { characterId: character.characterId } }"><PencilSquareIcon /></RouterLink>
+      <RouterLink class="btn-icon ms-2" :to="{ name: routeNames.characterRulebook, params: { characterId: character.characterId } }"><PencilSquareIcon /></RouterLink>
     </div>
   </div>
 </template>
\ No newline at end of file
diff --git a/src/pages/rules/ListRuleBooks.vue b/src/pages/rules/ListRuleBooks.vue
index d7be907..b90056a 100644
--- a/src/pages/rules/ListRuleBooks.vue
+++ b/src/pages/rules/ListRuleBooks.vue
@@ -2,6 +2,7 @@
 import {storeToRefs} from "pinia";
 import {PencilSquareIcon, TrashIcon} from "@heroicons/vue/24/outline";
 import {useRuleBooksStore} from "@/rules";
+import {routeNames} from "@/routes";
 
 const {ruleBooks} = storeToRefs(useRuleBooksStore());
 
@@ -10,11 +11,11 @@ const {ruleBooks} = storeToRefs(useRuleBooksStore());
 <template>
   <div class="grid mb-2 mt-4">
     <div class="flex justify-end border-b-1">
-      <RouterLink class="button mb-2 ms-2" :to="{ name: 'new-rule-book'}">New Rule Book</RouterLink>
+      <RouterLink class="button mb-2 ms-2" :to="{ name: routeNames.newRuleBook}">New Rule Book</RouterLink>
     </div>
     <div v-for="ruleBook in ruleBooks" :key="ruleBook.ruleBookId" class="flex items-center mt-2">
       <span class="flex grow me-2">{{ruleBook.name}}</span>
-      <RouterLink class="btn-icon me-1" :to="{ name: 'edit-rule-book', params: { ruleBookId: ruleBook.ruleBookId } }"><PencilSquareIcon /></RouterLink>
+      <RouterLink class="btn-icon me-1" :to="{ name: routeNames.editRuleBook, params: { ruleBookId: ruleBook.ruleBookId } }"><PencilSquareIcon /></RouterLink>
       <button class="btn-icon"><TrashIcon /></button>
     </div>
   </div>
diff --git a/src/routes.ts b/src/routes.ts
index 3d5acc5..20b3bde 100644
--- a/src/routes.ts
+++ b/src/routes.ts
@@ -1,8 +1,19 @@
 import {RouteRecordRaw} from 'vue-router';
 
+export const routeNames = {
+    home: 'home',
+    callback: 'callback',
+    listRuleBooks: 'list-rule-books',
+    newRuleBook: 'new-rule-book',
+    editRuleBook: 'edit-rule-book',
+    characterRulebook: 'character-rulebook',
+    marketTypes: 'market-types',
+    about: 'about',
+} as const;
+
 export const routes: RouteRecordRaw[] = [
-    {path: '/', name: 'home', component: () => import('@/pages/Index.vue')},
-    {path: '/callback', name: 'callback', component: () => import('@/pages/Index.vue')},
+    {path: '/', name: routeNames.home, component: () => import('@/pages/Index.vue')},
+    {path: '/callback', name: routeNames.callback, component: () => import('@/pages/Index.vue')},
 
     {path: '/ledgers', component: () => import('@/pages/Ledgers.vue'), children: [
         {path: '', component: () => import('@/pages/ledger/ListLedgers.vue')},
@@ -11,17 +22,19 @@ export const routes: RouteRecordRaw[] = [
     {path: '/rules', component: () => import('@/pages/Rules.vue'), children: [
         {path: '', redirect: '/rule-books'},
         {path: '/rule-books', children: [
-                {path: '', name: 'list-rule-books', component: () => import('./pages/rules/ListRuleBooks.vue')},
-                {path: 'new', name: 'new-rule-book', component: () => import('@/pages/rules/EditRuleBook.vue')},
-                {path: ':ruleBookId', name: 'edit-rule-book', component: () => import('@/pages/rules/EditRuleBook.vue')},
-            ]},
-        {path: '/characters/rules', component: () => import('./pages/rules/ListCharacterRuleBooks.vue')},
-        {path: '/characters/:characterId/rules', name: 'character-rulebook', component: () => import('@/pages/rules/EditCharacterRuleBook.vue')},
+            {path: '', name: routeNames.listRuleBooks, component: () => import('@/pages/rules/ListRuleBooks.vue')},
+            {path: 'new', name: routeNames.newRuleBook, component: () => import('@/pages/rules/EditRuleBook.vue')},
+            {path: ':ruleBookId', name: routeNames.editRuleBook, component: () => import('@/pages/rules/EditRuleBook.vue')},
+        ]},
+        {path: '/characters/rules', children: [
+            {path: '', component: () => import('@/pages/rules/ListCharacterRuleBooks.vue')},
+            {path: '/characters/:characterId/rules', name: routeNames.characterRulebook, component: () => import('@/pages/rules/EditCharacterRuleBook.vue')},
+        ]}
     ]},
 
     {path: '/market', component: () => import('@/pages/Market.vue'), children: [
         {path: '', redirect: '/market/types'},
-        {path: 'types/:type?', name: 'market-types', component: () => import('@/pages/market/TypeInfo.vue')},
+        {path: 'types/:type?', name: routeNames.marketTypes, component: () => import('@/pages/market/TypeInfo.vue')},
         {path: 'tracking', component: () => import('@/pages/market/Tracking.vue')},
         {path: 'acquisitions', component: () => import('@/pages/market/Acquisitions.vue')},
     ]},
@@ -31,5 +44,5 @@ export const routes: RouteRecordRaw[] = [
     {path: '/tools', component: () => import('@/pages/Tools.vue')},
 
     {path: '/characters', component: () => import('@/pages/Characters.vue')},
-    {path: '/about', name: 'about', component: () => import('@/pages/About.vue')},
-];
\ No newline at end of file
+    {path: '/about', name: routeNames.about, component: () => import('@/pages/About.vue')},
+] as const;
\ No newline at end of file
diff --git a/src/sidebar/Sidebar.vue b/src/sidebar/Sidebar.vue
index d12cced..95b4891 100644
--- a/src/sidebar/Sidebar.vue
+++ b/src/sidebar/Sidebar.vue
@@ -1,6 +1,7 @@
 <script setup lang="ts">
 import {Dropdown} from '@/components';
 import {RouterLink} from 'vue-router';
+import {routeNames} from '@/routes';
 
 const links = [
   {name: "Ledger", path: "/ledgers"},
@@ -28,7 +29,7 @@ const logout = async () => {
               <RouterLink class="sidebar-button py-0.5 px-2" to="/characters">Characters</RouterLink>
             </li>
             <li>
-              <RouterLink class="sidebar-button py-0.5 px-2" :to="{name: 'about'}">About EVE Online</RouterLink>
+              <RouterLink class="sidebar-button py-0.5 px-2" :to="{name: routeNames.about}">About EVE Online</RouterLink>
             </li>
             <li>
               <a class="sidebar-button py-0.5 px-2 text-amber-700" @click="logout">Logout</a>