From 75d1d5f7fab4f6b9d1e486ce980974e5ca059416 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sophie-Ga=C3=ABlle=20CALLOCH?=
 <sophie-gaelle.calloch@siteflow.com>
Date: Tue, 7 Jul 2026 15:41:01 +0200
Subject: [PATCH] refactor: remove refresh from stores

---
 src/characters/chartacters.ts                 |  2 +-
 src/ledger/ledger.ts                          |  2 +-
 .../acquisition/AcquisitionResultTable.vue    |  9 +++----
 src/market/acquisition/AcquisitionsPanel.vue  |  8 +++++--
 src/market/acquisition/acquisition.ts         |  2 +-
 src/market/order/order.ts                     | 24 ++++---------------
 src/pages/market/Acquisitions.vue             |  6 +++--
 src/rules/rules.ts                            |  2 +-
 8 files changed, 24 insertions(+), 31 deletions(-)

diff --git a/src/characters/chartacters.ts b/src/characters/chartacters.ts
index 2fedab0..0d2230a 100644
--- a/src/characters/chartacters.ts
+++ b/src/characters/chartacters.ts
@@ -24,5 +24,5 @@ export const useCharactersStore = defineStore('characters', () => {
 
     refresh();
 
-    return {characters, findById, reloadActivities, refresh};
+    return {characters, findById, reloadActivities};
 })
\ No newline at end of file
diff --git a/src/ledger/ledger.ts b/src/ledger/ledger.ts
index ae05c82..1827edf 100644
--- a/src/ledger/ledger.ts
+++ b/src/ledger/ledger.ts
@@ -74,7 +74,7 @@ export const useLedgersStore = defineStore('ledgers', () => {
 
     onActivitiesProcessed(refresh);
 
-    return {ledgers, findById, findAllById, createMain, createCombined, updateMain, updateCombined, refresh};
+    return {ledgers, findById, findAllById, createMain, createCombined, updateMain, updateCombined};
 })
 
 const getLedgerId = (ledger: Ledger | string): string => typeof ledger == 'string' ? ledger : ledger.ledgerId;
diff --git a/src/market/acquisition/AcquisitionResultTable.vue b/src/market/acquisition/AcquisitionResultTable.vue
index 947af40..22d9930 100644
--- a/src/market/acquisition/AcquisitionResultTable.vue
+++ b/src/market/acquisition/AcquisitionResultTable.vue
@@ -1,9 +1,9 @@
 <script setup lang="ts">
 import {SliderCheckbox} from '@/components';
 import {SortableHeader, useSort, VirtualScrollTable} from '@/components/table';
-import {MarketType, MarketTypeLabel, TaxInput, useMarketOrdersStore, useMarketTaxStore} from "@/market";
+import {getListedSellTypeIds, MarketType, MarketTypeLabel, TaxInput, useMarketTaxStore} from "@/market";
 import {MinusIcon, PlusIcon} from '@heroicons/vue/24/outline';
-import {useStorage} from '@vueuse/core';
+import {computedAsync, useStorage} from '@vueuse/core';
 import {computed, ref} from 'vue';
 import {AcquiredType} from './AcquiredType';
 import AcquisitionQuartilesTooltip from './AcquisitionQuartilesTooltip.vue';
@@ -66,14 +66,15 @@ const columnsToIgnore = computed(() => {
 
 const marketTaxStore = useMarketTaxStore();
 const ledgersStore = useLedgersStore();
-const marketOrdersStore = useMarketOrdersStore();
+
+const listedTypeIds = computedAsync(getListedSellTypeIds, new Set<number>());
 
 const threshold = useStorage('market-acquisition-threshold', 10);
 const filter = ref("");
 const unlistedOnly = ref(false);
 const matchesFilter = (r: AcquiredType) =>
     r.type.name.toLowerCase().includes(filter.value.toLowerCase())
-    && (!unlistedOnly.value || !marketOrdersStore.listedTypeIds.has(r.type.id));
+    && (!unlistedOnly.value || !listedTypeIds.value.has(r.type.id));
 const { sortedArray, headerProps, showColumn } = useSort<Result>(computed(() => {
     const filteredItems = props.items.filter(matchesFilter);
 
diff --git a/src/market/acquisition/AcquisitionsPanel.vue b/src/market/acquisition/AcquisitionsPanel.vue
index 88a82de..98d64c2 100644
--- a/src/market/acquisition/AcquisitionsPanel.vue
+++ b/src/market/acquisition/AcquisitionsPanel.vue
@@ -21,7 +21,7 @@ const sellModal = ref<typeof SellModal>();
 const apraisalStore = useApraisalStore();
 const enriched = ref<AcquiredType[]>([]);
 
-watch(() => props.items, async itms => {
+const refresh = async (itms: RawAcquiredType[] = props.items) => {
     if (itms.length === 0) {
         enriched.value = [];
         return;
@@ -40,7 +40,11 @@ watch(() => props.items, async itms => {
             sell: price.sell
         };
     });
-}, {immediate: true});
+};
+
+watch(() => props.items, refresh, {immediate: true});
+
+defineExpose({refresh});
 </script>
 
 <template>
diff --git a/src/market/acquisition/acquisition.ts b/src/market/acquisition/acquisition.ts
index 1e1b586..15796f6 100644
--- a/src/market/acquisition/acquisition.ts
+++ b/src/market/acquisition/acquisition.ts
@@ -69,5 +69,5 @@ export const useAcquiredTypesStore = defineStore('market-acquisition', () => {
 
     onActivitiesProcessed(refresh);
 
-    return { acquiredTypes: types, addAcquiredType, removeAcquiredType, processNewActivities, refresh };
+    return { acquiredTypes: types, addAcquiredType, removeAcquiredType, processNewActivities };
 });
diff --git a/src/market/order/order.ts b/src/market/order/order.ts
index 13ed173..dd05e06 100644
--- a/src/market/order/order.ts
+++ b/src/market/order/order.ts
@@ -1,21 +1,7 @@
-import {defineStore} from "pinia";
-import {computed, ref} from "vue";
 import {marketApi} from "@/mammon";
-import {MarketOrderResponse, MarketOrderResponseDirectionEnum} from "@/generated/mammon";
+import {MarketOrderResponseDirectionEnum} from "@/generated/mammon";
 
-export const useMarketOrdersStore = defineStore('market-orders', () => {
-    const orders = ref<MarketOrderResponse[]>([]);
-
-    const listedTypeIds = computed(() => new Set(
-        orders.value
-            .filter(o => o.direction === MarketOrderResponseDirectionEnum.Sell)
-            .map(o => o.marketTypeId)
-    ));
-
-    const refresh = () => marketApi.findAllMarketOrders()
-        .then(response => orders.value = response.data);
-
-    refresh();
-
-    return {orders, listedTypeIds, refresh};
-});
+export const getListedSellTypeIds = (): Promise<Set<number>> => marketApi.findAllMarketOrders()
+    .then(response => new Set(response.data
+        .filter(o => o.direction === MarketOrderResponseDirectionEnum.Sell)
+        .map(o => o.marketTypeId)));
diff --git a/src/pages/market/Acquisitions.vue b/src/pages/market/Acquisitions.vue
index b071f56..6497e7f 100644
--- a/src/pages/market/Acquisitions.vue
+++ b/src/pages/market/Acquisitions.vue
@@ -2,11 +2,13 @@
 import {AcquisitionsPanel, useAcquiredTypesStore} from '@/market/acquisition';
 import {ArrowPathIcon} from '@heroicons/vue/24/outline';
 import {useAutoRefresh} from '@/composables';
+import {ref} from 'vue';
 
 const acquiredTypesStore = useAcquiredTypesStore();
+const panel = ref<InstanceType<typeof AcquisitionsPanel>>();
 
 const refresh = async () => {
-  await acquiredTypesStore.refresh();
+  await panel.value?.refresh();
 }
 
 const {active: autoRefresh, toggle: toggleAutoRefresh} = useAutoRefresh(refresh, 5 * 60 * 1000);
@@ -22,6 +24,6 @@ const {active: autoRefresh, toggle: toggleAutoRefresh} = useAutoRefresh(refresh,
                 </button>
             </div>
         </div>
-        <AcquisitionsPanel :items="acquiredTypesStore.acquiredTypes" ignoredColums="date" />
+        <AcquisitionsPanel ref="panel" :items="acquiredTypesStore.acquiredTypes" ignoredColums="date" />
     </div>
 </template>
\ No newline at end of file
diff --git a/src/rules/rules.ts b/src/rules/rules.ts
index 10b01b9..e82b896 100644
--- a/src/rules/rules.ts
+++ b/src/rules/rules.ts
@@ -24,7 +24,7 @@ export const useRuleBookStore = defineStore('rule-book', () => {
 
     refresh();
 
-    return {ruleBook, refresh, update};
+    return {ruleBook, update};
 })
 
 export const fetchScriptDefinitions = (): Promise<string> =>