Follow mammon location rename in the generated client (UniverseApi→LocationApi, MarketLocationResponse→DockableLocationResponse) #31

Closed
opened 2026-07-10 11:19:18 +02:00 by Sirttas · 0 comments
Owner

Summary

mammon #53 (and the location consolidation, #52–#55) renamed the universe slice to
location and changed its OpenAPI @Tag universelocation, and renamed the location
DTOs Market*Dockable*. Regenerating the mammon client therefore produces two renamed
symbols that the hand-written frontend consumers still reference under their old names:

  • UniverseApiLocationApi
  • MarketLocationResponseDockableLocationResponse

The generated client under src/generated/mammon/ has already been regenerated and exposes the
new names. Only the hand-written consumers remain broken; npm run build currently fails on
them. This is a name-only follow-up — endpoints, request args and response fields are unchanged.

Scope

  • src/mammon/mammonService.ts: import UniverseApiLocationApi; rename the exported
    universeApi instance to locationApi.
  • src/market/location/MarketLocation.ts:
    • import locationApi instead of universeApi, and update the searchLocations call site.
    • import DockableLocationResponse instead of MarketLocationResponse and re-point the local
      export type MarketLocation = ... alias to it.

The searchLocations(search) call needs no argument change — search maps to the name
parameter of the new searchLocations(name, limit?) signature. DockableLocationResponse keeps
id/name (plus system/region fields), so downstream .id access is unaffected.

Explicitly out of scope

  • Regenerating src/generated/mammon/ — already done; do not hand-edit generated files.
  • Renaming gemory's own local vocabulary. The frontend keeps its independent naming: the
    MarketLocation type alias, MarketLocationInput.vue, searchMarketLocations, and the
    src/market/location/ directory stay as-is. Only the generated-type import is re-pointed.
    Consequently CompareAppraisal.vue, CompareResultTable.vue, MarketLocationInput.vue and
    src/market/location/index.ts require no changes.
  • Any behavioural/UI change — endpoints and payloads are unchanged.

Acceptance criteria

  • npm run build (vue-tsc + vite) passes.
  • No UniverseApi / universeApi identifiers remain in src/ (outside generated files).
  • No import of MarketLocationResponse remains in src/; the MarketLocation alias points
    to DockableLocationResponse.
  • Location search still resolves against the same /locations endpoint with identical
    results.

Related

Follows mammon #52–#55 (location consolidation, Market*Dockable*) and #53 (tag rename).
Part of the item-comparison epic.

## Summary mammon #53 (and the location consolidation, #52–#55) renamed the `universe` slice to `location` and changed its OpenAPI `@Tag` `universe` → `location`, and renamed the location DTOs `Market*` → `Dockable*`. Regenerating the mammon client therefore produces two renamed symbols that the hand-written frontend consumers still reference under their old names: - `UniverseApi` → `LocationApi` - `MarketLocationResponse` → `DockableLocationResponse` The generated client under `src/generated/mammon/` has already been regenerated and exposes the new names. Only the hand-written consumers remain broken; `npm run build` currently fails on them. This is a name-only follow-up — endpoints, request args and response fields are unchanged. ## Scope - `src/mammon/mammonService.ts`: import `UniverseApi` → `LocationApi`; rename the exported `universeApi` instance to `locationApi`. - `src/market/location/MarketLocation.ts`: - import `locationApi` instead of `universeApi`, and update the `searchLocations` call site. - import `DockableLocationResponse` instead of `MarketLocationResponse` and re-point the local `export type MarketLocation = ...` alias to it. The `searchLocations(search)` call needs no argument change — `search` maps to the `name` parameter of the new `searchLocations(name, limit?)` signature. `DockableLocationResponse` keeps `id`/`name` (plus system/region fields), so downstream `.id` access is unaffected. ## Explicitly out of scope - Regenerating `src/generated/mammon/` — already done; do not hand-edit generated files. - Renaming gemory's own local vocabulary. The frontend keeps its independent naming: the `MarketLocation` type alias, `MarketLocationInput.vue`, `searchMarketLocations`, and the `src/market/location/` directory stay as-is. Only the generated-type import is re-pointed. Consequently `CompareAppraisal.vue`, `CompareResultTable.vue`, `MarketLocationInput.vue` and `src/market/location/index.ts` require no changes. - Any behavioural/UI change — endpoints and payloads are unchanged. ## Acceptance criteria - [x] `npm run build` (vue-tsc + vite) passes. - [x] No `UniverseApi` / `universeApi` identifiers remain in `src/` (outside generated files). - [x] No import of `MarketLocationResponse` remains in `src/`; the `MarketLocation` alias points to `DockableLocationResponse`. - [x] Location search still resolves against the same `/locations` endpoint with identical results. ## Related Follows mammon #52–#55 (location consolidation, `Market*`→`Dockable*`) and #53 (tag rename). Part of the item-comparison epic.
Sirttas changed title from Follow mammon `universe`→`location` API tag rename (UniverseApi → LocationApi) to Follow mammon location rename in the generated client (UniverseApi→LocationApi, MarketLocationResponse→DockableLocationResponse) 2026-07-14 17:11:31 +02:00
Sirttas removed the
Status
To Refine
label 2026-07-14 17:11:37 +02:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: eveal/gemory#31