Merge branch 'optional-tests' into 'master'

Specify optional tests with an environment variable

See merge request briar/briar!916

bramble-android/build.gradle

@@ -49,8 +49,3 @@ project.afterEvaluate {
 		into 'src/main/res/raw'
 	}
 }
-
-tasks.withType(Test) {
-	// Use entropy-gathering device specified on command line, if any
-	systemProperty 'java.security.egd', System.getProperty('java.security.egd')
-}

bramble-api/build.gradle

@@ -31,8 +31,3 @@ task jarTest(type: Jar, dependsOn: testClasses) {
 artifacts {
 	testOutput jarTest
 }
-
-tasks.withType(Test) {
-	// Use entropy-gathering device specified on command line, if any
-	systemProperty 'java.security.egd', System.getProperty('java.security.egd')
-}

bramble-api/src/test/java/org/briarproject/bramble/test/TestUtils.java

@@ -24,6 +24,7 @@ import java.util.Map;
 import java.util.Random;
 import java.util.concurrent.atomic.AtomicInteger;
 
+import static java.util.Arrays.asList;
 import static org.briarproject.bramble.api.identity.Author.FORMAT_VERSION;
 import static org.briarproject.bramble.api.identity.AuthorConstants.MAX_AUTHOR_NAME_LENGTH;
 import static org.briarproject.bramble.api.identity.AuthorConstants.MAX_PUBLIC_KEY_LENGTH;
@@ -173,4 +174,10 @@ public class TestUtils {
 			Collection<? extends Number> samples) {
 		return Math.sqrt(getVariance(samples));
 	}
+
+	public static boolean isOptionalTestEnabled(Class testClass) {
+		String optionalTests = System.getenv("OPTIONAL_TESTS");
+		return optionalTests != null &&
+				asList(optionalTests.split(",")).contains(testClass.getName());
+	}
 }

bramble-core/build.gradle

@@ -44,8 +44,3 @@ task jarTest(type: Jar, dependsOn: testClasses) {
 artifacts {
 	testOutput jarTest
 }
-
-tasks.withType(Test) {
-	// Use entropy-gathering device specified on command line, if any
-	systemProperty 'java.security.egd', System.getProperty('java.security.egd')
-}

bramble-java/build.gradle

@@ -40,7 +40,5 @@ project.afterEvaluate {
 }
 
 tasks.withType(Test) {
-	// Use entropy-gathering device specified on command line, if any
-	systemProperty 'java.security.egd', System.getProperty('java.security.egd')
 	systemProperty 'java.library.path', 'libs'
 }

bramble-java/src/test/java/org/briarproject/bramble/plugin/tor/BridgeTest.java

@@ -12,7 +12,6 @@ import org.briarproject.bramble.test.BrambleTestCase;
 import org.briarproject.bramble.test.DaggerBrambleJavaIntegrationTestComponent;
 import org.junit.AfterClass;
 import org.junit.Before;
-import org.junit.Ignore;
 import org.junit.Test;
 
 import java.io.File;
@@ -28,11 +27,12 @@ import static java.util.Collections.singletonList;
 import static java.util.concurrent.TimeUnit.SECONDS;
 import static org.briarproject.bramble.test.TestUtils.deleteTestDirectory;
 import static org.briarproject.bramble.test.TestUtils.getTestDirectory;
+import static org.briarproject.bramble.test.TestUtils.isOptionalTestEnabled;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
+import static org.junit.Assume.assumeTrue;
 
-@Ignore("Might fail non-deterministically when bridges are down")
 public class BridgeTest extends BrambleTestCase {
 
 	private final static long TIMEOUT = SECONDS.toMillis(23);
@@ -61,6 +61,9 @@ public class BridgeTest extends BrambleTestCase {
 
 	@Before
 	public void setUp() {
+		// Skip this test unless it's explicitly enabled in the environment
+		assumeTrue(isOptionalTestEnabled(BridgeTest.class));
+
 		BrambleJavaIntegrationTestComponent component =
 				DaggerBrambleJavaIntegrationTestComponent.builder().build();
 		component.inject(this);

briar-android/build.gradle

@@ -184,8 +184,3 @@ task verifyTranslations {
 project.afterEvaluate {
 	preBuild.dependsOn.add(verifyTranslations)
 }
-
-tasks.withType(Test) {
-	// Use entropy-gathering device specified on command line, if any
-	systemProperty 'java.security.egd', System.getProperty('java.security.egd')
-}

briar-api/build.gradle

@@ -11,8 +11,3 @@ dependencies {
 
 	signature 'org.codehaus.mojo.signature:java16:1.1@signature'
 }
-
-tasks.withType(Test) {
-	// Use entropy-gathering device specified on command line, if any
-	systemProperty 'java.security.egd', System.getProperty('java.security.egd')
-}

briar-core/build.gradle

@@ -32,8 +32,3 @@ dependencies {
 
 	signature 'org.codehaus.mojo.signature:java16:1.1@signature'
 }
-
-tasks.withType(Test) {
-	// Use entropy-gathering device specified on command line, if any
-	systemProperty 'java.security.egd', System.getProperty('java.security.egd')
-}

build.gradle

@@ -6,6 +6,14 @@ allprojects {
 		mavenLocal()
 		google()
 	}
+	afterEvaluate {
+		tasks.withType(Test) {
+			// Allow tests to be re-run if any optional tests are enabled
+			outputs.upToDateWhen { System.getenv("OPTIONAL_TESTS") == null }
+			// Use entropy-gathering device specified on command line, if any
+			systemProperty 'java.security.egd', System.getProperty('java.security.egd')
+		}
+	}
 }
 
 buildscript {