Kaladaran/briar
0
0
Fork 0
mirror of https://code.briarproject.org/briar/briar.git synced 2026-02-21 15:19:53 +01:00
Code Issues Projects Releases Wiki Activity

Android UI - Icon Drawables

Torsten Grote
2021-01-26 11:28:44 +00:00
parent 76933af665
commit 4f1057e6ec
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pre-review-checklist.md

@@ -1,3 +1,5 @@
## Java
#### Thread safety #### Thread safety
* Classes should be immutable where possible * Classes should be immutable where possible
* Classes that may be used by multiple threads must be thread-safe * Classes that may be used by multiple threads must be thread-safe
@@ -31,3 +33,13 @@
* Use dedicated lock objects rather than `synchronized` * Use dedicated lock objects rather than `synchronized`
* Don't call into other classes while holding locks * Don't call into other classes while holding locks
* Don't start database transactions while holding locks * Don't start database transactions while holding locks
## Android UI
#### Icon Drawables
* Use `app:srcCompat` instead of `android:src` to define drawables in XML files
* Use `setImageResource()` to set icons instead of `setImageDrawable()`
* If you need to set a drawable directly, but can't use `setImageResource()`, use `VectorDrawableCompat.create()` to get the drawable
* Don't use vector(-only) drawables for notification icons (unless that's supported now)
* Test icon display on API < 21