Kaladaran/briar
0
0
Fork 0
mirror of https://code.briarproject.org/briar/briar.git synced 2026-02-24 00:29:52 +01:00
Code Issues Projects Releases Wiki Activity

Update pre review checklist

Sebastian
2022-06-29 11:47:34 +00:00
parent d387e5b8fb
commit 74d580c730
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
pre-review-checklist.md

@@ -23,6 +23,7 @@
* Use checked exceptions rather than special return values to indicate errors * Use checked exceptions rather than special return values to indicate errors
* Unchecked exceptions should only be used for programming errors * Unchecked exceptions should only be used for programming errors
* If you catch an InterruptedException in a synchronous method, interrupt the current thread so the caller learns about the interrupt * If you catch an InterruptedException in a synchronous method, interrupt the current thread so the caller learns about the interrupt
* RuntimeExceptions thrown by our own code are expected to crash the app, and RuntimeExceptions thrown by libraries should either be caught immediately or allowed to escape and crash the app - but shouldn't be allowed to propagate through layers of our own code before being caught.
#### Blocking #### Blocking
* Don't call blocking methods from the UI thread * Don't call blocking methods from the UI thread